Changelogs

Overview

These changelogs reflect the history of all files in the Subversion repository. The changelog has been generated at 2016-05-09 08:38:04

Changes per page:

25 50 100 250 500 1000 2000

Changelog for wxWidgets (70435 changes):

2014-07-14 20:38 SC, revision 76927

trying xcrun notation for sdk

2014-07-14 19:35 AW, revision 76926

Search through all properties in wxPG::GetPropertyByLabel. Function should search for given label through all properties. This is consistent with searching by name (in GetPropertyByName) which is not limited to the subset of properties. Closes #15251.

2014-07-14 19:18 AW, revision 76925

Resolve ambiguity in multiple inheritance of function GetPropertyByLabel in wxPGPage. In wxPropertyGridPage class derived from wxPropertyGridPageState and wxPropertyGridInterface, function GetPropertyByLabel is inherited from both base classes. To resolve this ambiguity, function defined in wxPGInterface is introduced in wxPGPage through 'using-declaration'. (This is a temporary fix and finally GetPropertyByLabel function should be removed from wxPropertyGridPageState.) See #15251.

2014-07-14 19:15 SC, revision 76924

forgotten commit

2014-07-14 18:36 SC, revision 76923

removing extraneous parentheses

2014-07-14 18:27 SC, revision 76922

adding standard options for OS compatibility

2014-07-14 18:03 SC, revision 76921

using in place swapping macros

2014-07-14 18:03 SC, revision 76920

completing in place swapping macros

2014-07-14 17:50 SC, revision 76919

fixing commit

2014-07-14 17:42 SC, revision 76918

adding in place replacements avoiding self assignment

2014-07-14 17:37 SC, revision 76917

attempt at getting rid of unused-function warning

2014-07-14 15:57 SC, revision 76916

trial build with special warnings ON

2014-07-14 13:54 VZ, revision 76915

Ensure that wxCmdLineParser::FoundSwitch() asserts when used wrongly. This makes CmdLine unit test pass with the assertions backported from trunk, where FoundSwitch() does assert when called for a non-switch.

2014-07-14 13:38 VZ, revision 76914

Shorten wxOSX builds labels. Too long labels made some of the buildbot tables quite unreadable, so shorten them to something more reasonable.

2014-07-14 12:25 SC, revision 76913

adding CoreText to iOS builds

2014-07-14 11:37 SC, revision 76912

adding separate trunk fir c++

2014-07-13 18:38 AW, revision 76911

Use native renderers in wxPG under MSW by default.

2014-07-13 18:34 AW, revision 76910

Use native renderer for drawing check boxes in wxPG only if wxPG_USE_RENDERER_NATIVE flag is set. wxPG_USE_RENDERER_NATIVE flag is used in wxPG code to control whether native renderers can be called and we need to employ it. Legacy custom drawing code is used if this flag is no set.

2014-07-13 16:30 VZ, revision 76909

Fix inserting an element of wxArrayString itself back into it. Do the insertion/addition before deallocating the old memory to allow things like array.Add(array[0]) to work correctly. Closes #2290.

2014-07-13 16:30 VZ, revision 76908

Fix memory leak in ArraysTestCase unit test. Clear the items in PTR array explicitly, this is not done by the array itself.

2014-07-13 16:27 VZ, revision 76907

Fix inserting an element of wxArrayString itself back into it. Do the insertion/addition before deallocating the old memory to allow things like array.Add(array[0]) to work correctly. Closes #2290.

2014-07-13 16:27 VZ, revision 76906

Fix memory leak in ArraysTestCase unit test. Clear the items in PTR array explicitly, this is not done by the array itself.

2014-07-13 15:53 VZ, revision 76905

Fix socket leaks in wxFTP if starting up/downloading fails. Add the missing delete statements. Closes #2250.

2014-07-13 15:53 VZ, revision 76904

Fix socket leaks in wxFTP if starting up/downloading fails. Add the missing delete statements. Closes #2250.

2014-07-13 14:22 VZ, revision 76903

Don't DLL-export the private wxSimpleFontEnumerator class. This class is only used internally, so there is no need to export it from the shared library.

2014-07-13 14:17 VZ, revision 76902

Use dictionary sort for wxListBox strings. This should result in more expected, and more consistent with MSW, order of the items differing in case only. Also do the same for wxChoice in wxGTK1. Closes #16356.

2014-07-13 10:52 JS, revision 76901

Fix for context menu key under wxGTK

2014-07-13 10:52 JS, revision 76900

Fix for context menu key under wxGTK

2014-07-13 10:47 JS, revision 76899

Fix for text parsing when the text object has properties

2014-07-13 10:47 JS, revision 76898

Fix for text parsing when the text object has properties

2014-07-13 10:44 JS, revision 76897

Layout fix for paragraphs after floating objects not centering

2014-07-12 21:34 AW, revision 76896

Credit for patch (r76895).

2014-07-12 18:34 AW, revision 76895

Use native renderer to draw check boxes in wxPG. Use wxRendererNative procedure instead of custom check box drawing to get native look and feel of the check boxes in wxPG. Closes #14881.

2014-07-12 18:07 AW, revision 76894

Check if colour database exists before trying to use it in wxColourProperty. Sanity check in wxColourProperty ctor.

2014-07-12 12:47 AW, revision 76893

Allow use of all wxPG colours. wxPG-specific colours are added to the colour database when wxColourProperty is created (already existing colours are not overwritten by wxPG ones). Original list of wxPG colours was restored. Closes #15597.

2014-07-12 10:31 TIK, revision 76892

wxBitmapComboBoxBase uses wxArrayPtrVoid, so we need to #include "wx/dynarray.h". This fixes a compile error in situations where wx/dynarray.h is not implicitly included through other headers, e.g. when building wx with many features disabled.

2014-07-12 10:31 TIK, revision 76891

wxBitmapComboBoxBase uses wxArrayPtrVoid, so we need to #include "wx/dynarray.h". This fixes a compile error in situations where wx/dynarray.h is not implicitly included through other headers, e.g. when building wx with many features disabled.

2014-07-11 19:25 AW, revision 76890

Allow clearing wxPG from within wxPG event handlers. If wxPG::Clear is called from within event handler then it is not possible to delete all property items directly because some vital internal wxPG data are still in use. In this case it is necessary to put all items on the list for deferred deletion in wxPG idle state. Closes #16222.

2014-07-11 19:01 AW, revision 76889

Adjust list of items for deferred deletion/removal if wxPG property item is actually deleted/removed. When property is actually deleted/removed it must be also removed from the respective list of items for deferred deletion/removal in order to avoid crashes when it would be attempted to delete/remove it again at next wxPG idle state. Because lists of items for deferred operations can be updated at every actual deletion/removal it is necessary to rearrange iteration through these lists in wxPG::OnIdle. See #16222.

2014-07-11 18:38 AW, revision 76888

Prevent duplicating wxPG property items on the list of items for deferred deletion/removal. It is necessary to prevent duplicating items on the list of items to be deleted/removed later on (in wxPropertyGrid::OnIdle) to avoid crashes when it would be attempted to delete/remove already deleted/removed item. See #16222.

2014-07-11 15:38 VZ, revision 76887

Fix using wrong variable in wxMotif DoSetSizeIntr(). Use y instead of using x twice.

2014-07-10 18:35 AW, revision 76886

Use XOR operation to toggle the state of check box in wxPG. Minor optimization by using single XOR operation instead of separate AND, OR operations to toggle the state of wxSimpleCheckBox.

2014-07-10 18:22 AW, revision 76885

Defer using of editable check box in wxPG until it is fully initialized. Currently, when wxPGCheckBoxEditor is clicked then associated check box (wxSimpleCheckBox) is created and immediately after that its state is changed. This causes problems when underlaying validation is performed because the check box object is not yet registered as an active editor and thus it is not visible from within e.g. validation function. We need to defer changing the initial state of the check box until this box is registered by queuing the special event which will be processed after initialization. Closes #16361.

2014-07-10 11:55 TIK, revision 76884

Fix a compile error with some compilers introduced in r76812.

2014-07-10 11:51 TIK, revision 76883

Fix a compile error with some compilers introduced in r76813.

2014-07-09 20:56 AW, revision 76882

Use automatically generated ID values for wxPG sub-controls. Currently in wxPG there are used fixed "magic" ID values to identify sub-controls and this can lead to side effects if these values overlap with ID values assigned to another controls in the application (like e.g. menu items). Closes #13634.

2014-07-08 17:56 AW, revision 76876

Fix wxEnumProperty::GetIndexForValue GetIndexForValue should indicate that given property value does not exist by returning special index value(-1). Closes #14450.

2014-07-08 00:32 AW, revision 76875

Refresh property grid when property is switched to read-only state. Property grid is refreshed to reflect the new state of the property. Small refactoring of wxPropertyGridInterface class: SetPropertyReadOnly() function body moved from header file to source file. Closes #16306.

2014-07-07 22:48 RD, revision 76874

revert last commit

2014-07-07 21:39 AW, revision 76873

2014-07-07 20:03 SC, revision 76872

adding libs for ios

2014-07-07 19:11 VZ, revision 76871

Correct the addition of wxLANGUAGE_KABYLE. Repair (too late?) the ABI breakage for all the language constants following wxLANGUAGE_KABYLE in alphabetical order by adding this enum element at the end of the enum instead of in the middle. Also add wxLANGUAGE_KABYLE to langtabl.txt so that it doesn't disappear when the generated fragments are updated by running misc/languages/genlang.py the next time. This corrects/supersedes r75753.

2014-07-07 16:21 SC, revision 76870

making choice of libcppunit explicit, no system installed version anymore

2014-07-07 11:33 TIK, revision 76869

Tools can be specified without name in the XRC, so GetID() of the node returns wxID_ANY. Use the auto-assigned ID of the tool to refer to it instead.

2014-07-07 11:33 TIK, revision 76868

Tools can be specified without name in the XRC, so GetID() of the node returns wxID_ANY. Use the auto-assigned ID of the tool to refer to it instead.

2014-07-07 07:16 SC, revision 76867

reverting incorrect change

2014-07-07 07:15 SC, revision 76866

reverting incorrect fixes

2014-07-06 21:39 SC, revision 76865

adding padding nuls

2014-07-06 21:32 SC, revision 76864

adding padding nuls

2014-07-06 16:59 SC, revision 76863

removing wxMacLaunch dependancy for ios

2014-07-06 16:58 SC, revision 76862

fixing warning

2014-07-06 16:58 SC, revision 76861

adding ios build

2014-07-06 16:56 SC, revision 76860

added missing impl

2014-07-06 16:55 SC, revision 76859

note for further action

2014-07-06 13:31 TIK, revision 76858

Implement wxGenericListCtrl::EndEditLabel.

2014-07-06 12:33 SC, revision 76857

support for 64 bit ios

2014-07-06 12:32 TIK, revision 76856

Implement wxGenericListCtrl::EndEditLabel.

2014-07-06 12:05 TIK, revision 76855

Fix typo in documentation.

2014-07-06 12:05 TIK, revision 76854

Fix typo in documentation.

2014-07-06 12:01 TIK, revision 76853

Do not assert if not editing a label when calling wxGenericTreeCtrl::EndEditLabel

2014-07-06 12:01 TIK, revision 76852

Do not assert if not editing a label when calling wxGenericTreeCtrl::EndEditLabel

2014-07-06 10:10 SC, revision 76851

reverting name changes, doesn't seem to get reflected w/o restart

2014-07-06 10:02 SC, revision 76850

building trunk with libc++ adjusting cppunit

2014-07-06 09:00 SC, revision 76849

add zero termination for utf16

2014-07-05 21:30 SC, revision 76848

adding carbon option and sdk

2014-07-05 21:14 SC, revision 76847

typo

2014-07-05 21:08 SC, revision 76846

add sdk again

2014-07-05 21:04 SC, revision 76845

change quoting

2014-07-05 21:03 SC, revision 76844

change quoting

2014-07-05 21:00 SC, revision 76843

adding flags, LDFLAGS need architecture as well

2014-07-05 20:22 SC, revision 76842

next try

2014-07-05 20:21 SC, revision 76841

next try

2014-07-05 20:20 SC, revision 76840

next try

2014-07-05 20:19 SC, revision 76839

xml error

2014-07-05 20:17 SC, revision 76838

switching attributes, spaces got eliminated to aggressively

2014-07-05 18:44 SC, revision 76837

adding builds for stable branch

2014-07-05 18:13 SC, revision 76836

attempt at using variables

2014-07-05 17:15 SC, revision 76835

clang and ccache warnings suppression also for .mm files, turn off other builds temporarily

2014-07-05 16:37 SC, revision 76834

clang warnings

2014-07-05 16:13 SC, revision 76833

trying to tune ccache and clang cooperation

2014-07-05 15:29 SC, revision 76832

raising trunk SDK, removing Carbon build

2014-07-05 12:16 SC, revision 76831

revert in case the buildbot problem was caused by this change

2014-07-05 12:14 SC, revision 76830

remove carbon build temporarily

2014-07-04 22:10 SC, revision 76829

adding base virtuals

2014-07-04 18:58 SC, revision 76828

supporting NSString also in Carbon

2014-07-04 18:52 SC, revision 76827

resolving ambiguity

2014-07-04 14:43 TIK, revision 76826

Fix compilation if configured with --disable-printarch

2014-07-04 14:43 TIK, revision 76825

Fix compilation if configured with --disable-printarch

2014-07-04 14:23 VZ, revision 76824

Skip mouse button release events in wxGenericListCtrl. This is similar to r76094 for wxGenericTreeCtrl and fixes a similar problem: clicking in a wxListCtrl inside wxNotebook confused GtkNotebook mouse tracking logic because it didn't get some events. Closes #16365.

2014-07-04 14:22 VZ, revision 76823

Fix typo in wxTreeCtrl::AppendItem() documentation. The greater sign got lost in Doxygen translation, restore it. Closes #16366.

2014-07-04 14:22 VZ, revision 76822

Skip mouse button release events in wxGenericListCtrl. This is similar to r76093 for wxGenericTreeCtrl and fixes a similar problem: clicking in a wxListCtrl inside wxNotebook confused GtkNotebook mouse tracking logic because it didn't get some events. Closes #16365.

2014-07-04 14:16 VZ, revision 76821

Fix typo in wxTreeCtrl::AppendItem() documentation. The greater sign got lost in Doxygen translation, restore it. Closes #16366.

2014-07-04 13:50 VZ, revision 76820

Remove accidentally committed wxCompilerPrefix setting. Don't use "vc120" compiler prefix by default.

2014-07-04 13:31 VZ, revision 76819

Extract setup.h copying into a separate project for MSVC11+. This fixes problems with parallel builds in Visual Studio 2012 or 2013 IDE as multiple projects may try to copy setup.h file at once, resulting in errors. Use _custom_build project as a common dependency to ensure that the copy step is done only once. This is a backport of r76419 from trunk, see #16177.

2014-07-04 12:35 SC, revision 76818

adding 10.9 constants

2014-07-04 09:58 SC, revision 76817

fixing non-precomp build on carbon

2014-07-04 00:51 VZ, revision 76816

Still continue to use QuickTime framework in wxOSX/Carbon builds. Amend the changes of r76803 to only avoid QuickTime framework when using Cocoa, under Carbon it's needed by wxSound too, and not only wxMediaCtrl, and there is no real reason to avoid it in the first place anyhow.

2014-07-04 00:03 VZ, revision 76815

Hopefully finish removing the old wxCocoa port. Get rid of the rest of __WXCOCOA__ tests in the sources. Drop configure option for using it. Also remove the documentation for this port. This should have also been part of r76735.

2014-07-04 00:03 VZ, revision 76814

Still continue to use QuickTime framework in wxOSX/Carbon builds. Amend the changes of r76800 to only avoid QuickTime framework when using Cocoa, under Carbon it's needed by wxSound too, and not only wxMediaCtrl, and there is no real reason to avoid it in the first place anyhow.

2014-07-03 18:47 TIK, revision 76813

Items appended via the menu have no item data. Don't crash if right-clicking these items.

2014-07-03 18:45 TIK, revision 76812

Items appended via the menu have no item data. Don't crash if right-clicking these items.

2014-07-03 16:33 TIK, revision 76811

Add some files created by building with Visual Studio 2013 to svn:ignore.

2014-07-03 16:33 TIK, revision 76810

Add some files created by building with Visual Studio 2013 to svn:ignore.

2014-07-03 16:25 TIK, revision 76809

wxListTextCtrlWrapper::Finish and wxTreeTextCtrl::Finish cannot be called multiple times without crashing. wxListTextCtrlWrapper already used to protect against this in the past, but revision 51150 removed the safety check. This patch reimplements the functionality in a slighly different way for both controls, so that Finish is not called multiple times.

2014-07-03 16:16 TIK, revision 76808

wxListTextCtrlWrapper::Finish and wxTreeTextCtrl::Finish cannot be called multiple times without crashing. wxListTextCtrlWrapper already used to protect against this in the past, but revision 51150 removed the safety check. This patch reimplements the functionality in a slighly different way for both controls, so that Finish is not called multiple times.

2014-07-03 11:57 VZ, revision 76807

Revert "Don't link with OpenGL framework unconditionally under Mac OS X." OpenGL framework is, in fact, always needed because of the code in src/osx/core/glgrab.cpp which is currently used to implement wxScreenDC::GetAsBitmap(). This reverts r76799.

2014-07-02 15:28 VZ, revision 76806

Remove the inclusions of wx/cocoa headers which don't exist any more. This should have been part of r76735: in addition to removing the old Cocoa port headers, also remove the references to them from the common include files.

2014-07-02 15:28 VZ, revision 76805

Fix wxMSW compilation with old MinGW versions without ASSOCXXX constants. Define ASSOCF_NOTRUNCATE and ASSOCSTR_DEFAULTICON ourselves to let the code compile with older MinGW.

2014-07-02 15:28 VZ, revision 76804

Stop duplicating wxFrame dtor in all ports. wxGTK1, wxGTK, wxMSW and wxOSX all did the same thing in their wxFrame dtor, so just do it in wxFrameBase instead.

2014-07-02 14:06 VZ, revision 76803

Don't link with QuickTime framework unnecessarily under OS X. Only use QuickTime when wxUSE_MEDIACTRL is true.

2014-06-30 20:43 TIK, revision 76802

Disabled bitmaps of toolbar tools are now rendered at the correct position if using GTK3. Extend toolbar sample to include a button with a custom disabled bitmap.

2014-06-30 20:41 TIK, revision 76801

Disabled bitmaps of toolbar tools are now rendered at the correct position if using GTK3. Extend toolbar sample to include a button with a custom disabled bitmap.

2014-06-30 14:02 VZ, revision 76800

Don't link with QuickTime framework unnecessarily under OS X. Only use QuickTime when wxUSE_MEDIACTRL is true.

2014-06-30 14:02 VZ, revision 76799

Don't link with OpenGL framework unconditionally under Mac OS X. "-framework OpenGL" is already added when wxUSE_OPENGL is true, there is no need to always include it.

2014-06-30 03:00 VZ, revision 76798

Check for conversion failure correctly in wx[F]File::Write(). Check for the length of the buffer to determine whether the conversion failed instead of checking whether it's NULL because this is currently never the case because of the code in wxString::AsCharBuf() which returns "" and not NULL in case of conversion failure. This at least eliminates silent data loss when saving data that can't be converted to the current locale encoding. Closes #16348.

2014-06-30 03:00 VZ, revision 76797

Don't call strlen() unnecessarily in wxFFile::Write(). We already have the length of the string, either in the buffer if we actually converted the string from Unicode to multi-byte, or in the string itself in non-Unicode build.

2014-06-30 03:00 VZ, revision 76796

Don't use C++ streams in wxString::FromCDouble() implementation. This doesn't work if the global C++ locale had been changed and we can't call imbue(locale::classic()) to ensure that the stream we use here uses the C locale because imbue() is hopelessly broken in some implementations. So just get rid of this code and keep only the hack replacing the decimal separator with the dot explicitly. This is ugly but should always work in practice and is also consistent with ToCDouble(). Closes #16343.

2014-06-30 03:00 VZ, revision 76795

No real changes, just use symbolic constants with BM_SETCHECK. Use BST_CHECKED and BST_UNCHECKED instead of implicitly relying on their values being 1 and 0. See #11665.

2014-06-30 03:00 VZ, revision 76794

Fix appearance of custom drawn wxToggleButton in wxMSW. Ensure that the owner-drawn toggle buttons are drawn in the pressed state when they are pressed, even if they are also selected or under mouse. Closes #11665.

2014-06-30 03:00 VZ, revision 76793

Check for conversion failure correctly in wx[F]File::Write(). Check for the length of the buffer to determine whether the conversion failed instead of checking whether it's NULL because this is currently never the case because of the code in wxString::AsCharBuf() which returns "" and not NULL in case of conversion failure. This at least eliminates silent data loss when saving data that can't be converted to the current locale encoding. Closes #16348.

2014-06-30 03:00 VZ, revision 76792

Don't call strlen() unnecessarily in wxFFile::Write(). We already have the length of the string, either in the buffer if we actually converted the string from Unicode to multi-byte, or in the string itself in non-Unicode build.

2014-06-30 02:27 VZ, revision 76791

Don't use C++ streams in wxString::FromCDouble() implementation. This doesn't work if the global C++ locale had been changed and we can't call imbue(locale::classic()) to ensure that the stream we use here uses the C locale because imbue() is hopelessly broken in some implementations. So just get rid of this code and keep only the hack replacing the decimal separator with the dot explicitly. This is ugly but should always work in practice and is also consistent with ToCDouble(). Closes #16343.

2014-06-30 02:03 VZ, revision 76790

Fix appearance of custom drawn wxToggleButton in wxMSW. Ensure that the owner-drawn toggle buttons are drawn in the pressed state when they are pressed, even if they are also selected or under mouse. Closes #11665.

2014-06-30 01:43 VZ, revision 76789

No real changes, just fix a harmless warning under OS X. Don't use "size" variable unnecessarily under non-Mac platforms, this also fixes a warning about reassigning it immediately after assigning a previous values to it under Mac. Closes #16353.

2014-06-30 01:42 VZ, revision 76788

No real changes, just fix a harmless warning under OS X. Don't use "size" variable unnecessarily under non-Mac platforms, this also fixes a warning about reassigning it immediately after assigning a previous values to it under Mac. Closes #16353.

2014-06-30 01:42 VZ, revision 76787

Fix harmless unused parameters warnings in builds without wxLogTrace(). Fix warnings appearing when building with --disable-debug under Unix by either referencing the parameters or variables which become unused then, because wxLogTrace() calls are compiled out, or by not compiling the code whose only purpose is to call wxLogTrace() at all.

2014-06-30 01:39 VZ, revision 76786

Fix harmless unused parameters warnings in builds without wxLogTrace(). Fix warnings appearing when building with --disable-debug under Unix by either referencing the parameters or variables which become unused then, because wxLogTrace() calls are compiled out, or by not compiling the code whose only purpose is to call wxLogTrace() at all.

2014-06-28 12:37 TIK, revision 76785

Fix wxStaticBox' clipping region in RTL mode.

2014-06-28 12:36 TIK, revision 76784

Fix wxStaticBox' clipping region in RTL mode.

2014-06-28 11:49 TIK, revision 76783

Improve handling of right-to-left support in wxStaticBox on wxMSW. Back in #8101 I made fixes for wxStaticBox and right-to-left handling under Windows. While this worked fine in wx2.8, the old patch has some unfortunate consequences on wx3: * Since the box is always set to LTR, its children also inherit LTR * Text was always right-aligned This follow-up patch removes the RTL-specific code from wxStaticBox. Instead, the wxMemoryDC in wxStaticBox::OnPaint is made to inherit attributes from the wxPaintDC. Tested on XP (both XP and classic theme), Windows 7 and 8.1

2014-06-28 11:47 TIK, revision 76782

Improve handling of right-to-left support in wxStaticBox on wxMSW. Back in #8101 I made fixes for wxStaticBox and right-to-left handling under Windows. While this worked fine in wx2.8, the old patch has some unfortunate consequences on wx3: * Since the box is always set to LTR, its children also inherit LTR * Text was always right-aligned This follow-up patch removes the RTL-specific code from wxStaticBox. Instead, the wxMemoryDC in wxStaticBox::OnPaint is made to inherit attributes from the wxPaintDC. Tested on XP (both XP and classic theme), Windows 7 and 8.1

2014-06-27 07:38 DS, revision 76781

Fix wxMenuItem::SetBitmap infinite recursion differently. Don't call SetBitmap from GetHBitmapForMenu but instead handle possibly needed bitmap modifications earlier on during SetBitmap. Allows for GetHBitmapForMenu to be const and gets rid of the clumsy re-entry check introduced in r76754. Also check the bitmap for alpha presence instead of needlessly converting the bitmap to an image and checking the latter for alpha.

2014-06-27 07:29 DS, revision 76780

Fix compilation with wxUSE_MENUITEMINFO==0. Add argument to a call to GetHBitmapForMenu, which doesn't have a default parameter any more. Fixes (this part of) WinCE compilation. Broken since r76760.

2014-06-26 22:43 SC, revision 76779

adding AVFoundation implementation for media ctrl

2014-06-26 15:38 SC, revision 76778

remove unnecessary includes

2014-06-26 07:58 JJ, revision 76777

Update of OpenVMS makefile

2014-06-25 20:07 VS, revision 76776

Revert wxCurrentPopupMenu clearing in HandleMenuPopup(). WM_COMMAND is delivered after WM_UNINITMENUPOPUP and clearing wxCurrentPopupMenu in the latter's handler broke delivery of the command event to the wxTextCtrl control.

2014-06-25 20:06 VS, revision 76775

wxTextCtrl: call UpdateUI() when showing OLE-based context menu.

2014-06-25 20:04 VS, revision 76774

Fix IRichEditOleCallback compilation with MinGW. MinGW headers declare the IRichEditOleCallback interface and the corresponding IID, but the libraries don't contain the latter symbol. Work around it by defining it ourselves. Fixes #16340.

2014-06-25 20:04 VS, revision 76773

Revert wxCurrentPopupMenu clearing in HandleMenuPopup(). WM_COMMAND is delivered after WM_UNINITMENUPOPUP and clearing wxCurrentPopupMenu in the latter's handler broke delivery of the command event to the wxTextCtrl control.

2014-06-25 20:03 VS, revision 76772

wxTextCtrl: call UpdateUI() when showing OLE-based context menu.

2014-06-25 20:01 VS, revision 76771

Fix IRichEditOleCallback compilation with MinGW. MinGW headers declare the IRichEditOleCallback interface and the corresponding IID, but the libraries don't contain the latter symbol. Work around it by defining it ourselves. Fixes #16340.

2014-06-25 17:17 VZ, revision 76770

Generate debug information in MSVC 11/12 builds too. This partially (as MSVC 10 projects were already correct) backports r76475 from trunk, see #16236.

2014-06-25 01:56 VZ, revision 76769

Mention the addition of x64 configs in MSVC 8/9 projects in the change log. Should have been part of the previous commit.

2014-06-25 01:54 VZ, revision 76768

Generate 64 bit configurations in MSVC 8/9 projects. Update bakefile configuration to include x64 configurations into MSVS 2005 and 2008 projects (2003 doesn't support building in 64 bits, 2010 and later are manually maintained and already have them) and rebake the projects. Closes #13675.

2014-06-25 01:52 VZ, revision 76767

Generate 64 bit configurations in MSVC 8/9 projects. Update bakefile configuration to include x64 configurations into MSVS 2005 and 2008 projects (2003 doesn't support building in 64 bits, 2010 and later are manually maintained and already have them) and rebake the projects. See #13675.

2014-06-24 20:54 DS, revision 76760

Clean up GetHBitmapForMenu. Merge wxMenuItem::GetHBitmapForMenuCheckable and ::DoGetHBitmapForMenu into wxMenuItem::GetHBitmapForMenu. Change its boolean parameter to an enum specifying the kind of bitmap that is wanted (normal, checked, or unchecked).

2014-06-24 04:47 DS, revision 76759

Fixes for building wxMSW under Cygwin. Replace a few __WXMSW__ tests with __WINDOWS__ as the former is not defined any longer (since r73290) when compiling with wxUSE_GUI set to 0. Tested changes with both wxGTK and wxMSW builds under Cygwin. Closes #14382.

2014-06-24 04:46 DS, revision 76758

Fix non-MSVS compilation of webview_ie.cpp. Use wxCRT_StricmpW instead of the Visual C++ specific _wcsicmp. See #14382.

2014-06-23 22:05 DS, revision 76757

Fix failing Win32 calls with checkable menu item. Since r76202 InsertMenuItem is used when adding checkable menu items even without a bitmap. The call fails because hbmpChecked and hbmpUnchecked are set to HBMMENU_CALLBACK on pre-Vista, making the menu owner drawn unnecessarily. Fix by adding GetHBitmapForMenuCheckable which is used when assigning values to hbmpChecked and hbmpUnchecked. GetHBitmapForMenu remains unchanged (for possible porting reasons) and is used for hBmpItem only.

2014-06-23 22:01 DS, revision 76756

Make checkable menu item with bitmap owner drawn. Since r44192 a checkable menu item with bitmap on pre-Vista assigns HBMMENU_CALLBACK to hbmpChecked and hbmpUnchecked members of MENUITEMINFO. However this value is only valid for hbmpItem and for other bitmaps InsertMenuItem will fail (with "the parameter is incorrect") resulting in making the menu owner drawn later. Instead check earlier on in MSWMustUseOwnerDrawn if we're dealing with a checkable menu item with a bitmap and if so make it owner drawn explicitly.

2014-06-23 22:00 DS, revision 76755

Fix exception while reinserting menu item. After removing an item from a menu that item's parent menu is set to NULL and can't be used any longer to insert the item again. Fix by remembering the parent menu before removing the item from it. Regression since r76251 (this commit is a partial revert of that commit).

2014-06-23 21:58 DS, revision 76754

Fix wxMenuItem::SetBitmap infinite recursion (Vista+). Calling a menu item's SetBitmap can result in a stack overflow. This occurs when setting a bitmap after the menu item has already been added to the menu and while running under Vista (and later). Under those circumstances [Do]SetBitmap will call GetHBitmapForMenu which itself calls SetBitmap again. Fix by adding a simple check for re-entry. Regression since r76202.

2014-06-23 14:02 VZ, revision 76753

Add wxDictionaryStringSortAscending comparison function. Add "dictionary sort" callbacks and document them and the already existing wxStringSortAscending() and wxStringSortDescending(). See #16330.

2014-06-23 03:08 VZ, revision 76752

Avoid harmless warning about unused variables in wxOSX/Carbon. Declare the variables only used when wxUSE_STATUSBAR==1 inside the check for it. Closes #16331.

2014-06-23 03:08 VZ, revision 76751

Allow specifying custom comparator for wxSortedArrayString. Add a possibility to order wxSortedArrayString in some order different from the default alphabetical one. Closes #16330.

2014-06-23 03:08 VZ, revision 76750

Change wxStringSort{As,De}cending() to use references, not pointers. This is more convenient to use and makes more sense as the arguments are never null. See #16330.

2014-06-23 03:08 VZ, revision 76749

Handle wxSYS_COLOUR_LISTBOXTEXT in wxMotif wxSystemSettings. At the very least, don't fail with an assert if this colour is requested.

2014-06-23 03:08 VZ, revision 76748

Force wxUSE_GRAPHICS_CONTEXT to 0 for wxMotif build. wxGraphicsContext is not implemented in this port.

2014-06-23 03:08 VZ, revision 76747

Fix wxVector3f ctor in the propgrid sample. Even if this code is not used, it was still wrong as it didn't initialize the (shadowed) member variables, so fix it to actually do it. Closes #16342.

2014-06-22 23:36 VZ, revision 76746

Fix crash when right clicking AUI toolbar while left button is pressed. Ignore the unrelated mouse events during the item dragging. This avoids a crash due to m_actionItem being NULL when right clicking an item while the left mouse button is kept pressed. See #16327.

2014-06-22 16:23 VZ, revision 76745

Use wxIntNN types in wxQuantize code instead of INTNN ones. Rely on the already properly defined wx types instead of using INTNN which could clash with the system headers (e.g. INT32 is already defined in some Motif headers) and are not guaranteed to be always defined correctly (while int is always 32 bit on all currently supported platforms, this is not guaranteed to always remain the case).

2014-06-20 10:15 SC, revision 76744

fixes 64 bit to 32 warnings, see #16329

2014-06-20 10:14 SC, revision 76743

using proper types for webkit variants, see #16329

2014-06-20 03:35 DS, revision 76742

Fix finding menu items in wxMenuItem::DoSetBitmap. FindChildItem gets passed the id of a menu item as returned by GetMSWId, however GetMSWId should be used in combination with Win32 API functions. Instead use GetId: this fixes finding menu items that have a negative id (as a result of using wxID_ANY as id) or have a sub menu.

2014-06-20 00:35 VZ, revision 76741
  • D /wxWidgets/trunk/docs/publicity/publicity.txt

Remove file with obsolete release announcement information. This file was last (really) updated in 2003 and, unsurprisingly, information in it is not relevant 10+ years later and most of URLs in it simply don't exist any more (or exist but are no longer used, such as freshmeat.net, since yesterday). Any additional places to announce wxWidgets releases should be added to the "Announcement" section of docs/contributing/how-to-release.md now.

2014-06-20 00:11 VZ, revision 76740

Correct the name of the "preferences" sample in configure. Fix building (all) samples under Unix.

2014-06-19 15:10 SC, revision 76739

supporting retina, see #15887

2014-06-19 15:05 SC, revision 76738

supporting 2x display on retina displays, fixes #15887

2014-06-19 11:29 TIK, revision 76737

wxBitmap::GetMask() asserts on invalid bitmap. Check for valid bitmap before calling GetMask().

2014-06-19 11:29 TIK, revision 76736

wxBitmap::GetMask() asserts on invalid bitmap. Check for valid bitmap before calling GetMask().

2014-06-18 18:52 SC, revision 76735
  • D /wxWidgets/trunk/include/wx/cocoa
  • D /wxWidgets/trunk/src/cocoa

removing 'old' cocoa port

2014-06-18 16:55 SC, revision 76734

the old cocoa code will be removed in the next step

2014-06-18 16:27 SC, revision 76733

remove dependency from former cocoa port

2014-06-18 16:22 SC, revision 76732

adapting const parameter convention

2014-06-18 15:28 SC, revision 76731

remove dependency from former cocoa port

2014-06-18 15:25 SC, revision 76730

in reality there are only 2 different native toolbar sizes

2014-06-18 15:13 SC, revision 76729

remove dependency from former cocoa port

2014-06-18 15:11 SC, revision 76728

remove dependency from former cocoa port

2014-06-18 15:05 SC, revision 76727

only flush a client dc if it was not inheriting the native CGContextRef from an outside paint context, fixes #16334

2014-06-18 14:57 VS, revision 76726

Use IRichEditOleCallback for wxTextCtrl's context menu. In wxMSW, use IRichEditOleCallback::GetContextMenu() to provide our default context menu for rich text controls, instead of using EVT_CONTEXT_MENU. The latter completely overrides native control's handling and in particular breaks Windows 8's builtin spellchecking support. Fall back to the previous non-OLE code for older richtext versions.

2014-06-18 14:57 VS, revision 76725

Add wxMenu::MSWDetachHMENU(). Make it possible to pass ownership of a wxMenu to win32.

2014-06-18 14:57 VS, revision 76724

Handle WM_*MENU* events in wxWindow. Contrary to MSDN implications, at least some of these messages are not actually sent to the TLW for popup menus, but to the owning window or even its parent window (!). Catch the events in wxWindow and forward to the TLW.

2014-06-18 14:51 VS, revision 76723

Use IRichEditOleCallback for wxTextCtrl's context menu. In wxMSW, use IRichEditOleCallback::GetContextMenu() to provide our default context menu for rich text controls, instead of using EVT_CONTEXT_MENU. The latter completely overrides native control's handling and in particular breaks Windows 8's builtin spellchecking support. Fall back to the previous non-OLE code for older richtext versions. Also make the new MSWCreateContextMenu() method virtual so that the context menu can be customized.

2014-06-18 14:51 VS, revision 76722

Add wxMenu::MSWDetachHMENU(). Make it possible to pass ownership of a wxMenu to win32.

2014-06-18 14:51 VS, revision 76721

Handle WM_*MENU* events in wxWindow. Contrary to MSDN implications, at least some of these messages are not actually sent to the TLW for popup menus, but to the owning window or even its parent window (!). Move the handling of these events from wxTLW to wxWindow. Move menu depth tracking to wxFrame, because it only makes sense for frame's menus and move DoGiveHelp() from wxTLW to wxFrame.

2014-06-17 17:05 VZ, revision 76720

Clarify wxEVT_SLIDER event handler argument type in the documentation. Unlike all other events generated by wxSlider, this one receives a wxCommandEvent and not a wxScrollEvent. Unfortunately @beginEventEmissionTable doesn't handle the case of a class producing events of different types, perhaps it shouldn't be used at all here.

2014-06-17 17:05 VZ, revision 76719

Clarify wxEVT_SLIDER event handler argument type in the documentation. Unlike all other events generated by wxSlider, this one receives a wxCommandEvent and not a wxScrollEvent. Unfortunately @beginEventEmissionTable doesn't handle the case of a class producing events of different types, perhaps it shouldn't be used at all here.

2014-06-17 16:39 VZ, revision 76718

Add a reminder to update the date on download page to release HOWTO. This is probably useful as it was forgotten for 3.0.1.

2014-06-16 19:50 VZ, revision 76717

Update the version to 3.0.2 and rebake everything. This is the result of running misc/scripts/inc_release and bakefile_gen.

2014-06-16 16:51 VZ, revision 76716

Update the release notes and checksums for 3.0.1 release. Also add an explicit notice about needing to compile the library even after downloading the installer.

2014-06-16 00:18 TIK, revision 76715

Under certain conditions, selecting a menu item triggers an assert in toplevel.cpp:1544: wxASSERT_MSG( m_menuDepth > 0, wxS("No open menus?") ); The conditions to reproduce: - Windows 8.1 - An application manifest that indicates Windows 8.1 compatibility In this case, wxGetWinVersion() used to return wxWinVersion_Unknown (Without a manifest indicating 8.1 support, wxWinVersion_8 is being returned). This in turn causes the version check against Windows98 in toplevel.cpp:455 to fail, ultimately leading to the mentioned assert. See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724439%28v=vs.85%29.aspx for details. This patch on the 3.x branch of wx adjusts wxGetWinVersion to return wxWinVersion_8 on 8.1 instead of wxWinVersion_Unknown if there's such a manifest. In future, a different approach needs to be chosen that does not depend the deprecated GetVersion function.

2014-06-16 00:17 TIK, revision 76714

Under certain conditions, selecting a menu item triggers an assert in toplevel.cpp:1539: wxASSERT_MSG( m_menuDepth > 0, wxS("No open menus?") ); The conditions to reproduce: - Windows 8.1 - An application manifest that indicates Windows 8.1 compatibility In this case, wxGetWinVersion() used to return wxWinVersion_Unknown (Without a manifest indicating 8.1 support, wxWinVersion_8 is being returned). This in turn causes the version check against Windows98 in toplevel.cpp:450 to fail, ultimately leading to the mentioned assert. See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724439%28v=vs.85%29.aspx for details. This patch on trunk adjusts adds the wxWinVersion_8_1 enum value and returns it on Windows 8.1 if the program is manifested as such. In future, a different approach needs to be chosen that does not depend the deprecated GetVersion function.

2014-06-15 17:14 VZ, revision 76713

Add a page containing the screenshots of all controls to the manual. It can be helpful to see all the controls at a glance, especially if you don't know which control is needed.

2014-06-15 17:14 VZ, revision 76712

Make picker controls description in the manual less useless. It's not really clear what potential benefit could library users extract from the knowledge that the picker controls behaviour is "highly platform-dependent". Try to be flighty more helpful.

2014-06-15 14:58 VZ, revision 76711

Display wxString in more readable way in MSVS debug visualizer. Use "sb" format specifier to avoid having L"..." around the string and then add just the quotes back manually.

2014-06-15 03:33 VZ, revision 76710

Remove the old release making instructions and scripts. Using git-based scripts seems to work well and the old scripts are not maintained any more and having several ways of making releases is just confusing, so leave only one set of scripts, the one actually used since 2.9.

2014-06-15 02:50 VZ, revision 76709

Tag 3.0.1 release.

2014-06-15 02:30 VZ, revision 76708

Update the release notes and the announcement for 3.0.1 release. Document the changes in this release. Remove the "Documentation" section from the README as it doesn't seem to be very useful there, the link to the online documentation is the most important thing and it's mentioned in the very beginning.

2014-06-15 02:30 VZ, revision 76707

Set the 3.0.1 release date. Update the release date in the change log and the manual.

2014-06-15 02:30 VZ, revision 76706

Add MSVS visualizers for wxArrayString, wxVector, wxWindowList. Make viewing the contents of the (most common) container types easier when debugging in MSVS 2012 or later. Provide std::{vector,list}-like visualizers for wxVector and wxWindowList and a special visualizer allowing to see the contents of wxArrayString in a relatively common case when it has just or two elements.

2014-06-15 02:30 VZ, revision 76705

Add a file with debug visualizers for MSVS 2013 and later. For now this file contains just the visualizer for wxWindow which shows its real (most derived) type as this is often the most useful thing you need to know about the window.

2014-06-15 02:30 VZ, revision 76704

Add debugger visualizers for Visual Studio 2012+. Starting with 2012, Visual Studio uses a new, XML-based and actually quite understandable format for the debug visualizers. Only basics are included so far.

2014-06-15 02:00 BP, revision 76703

Updated date in manual for 3.0.1 release.

2014-06-14 23:03 VZ, revision 76702

Add MSVS visualizers for wxArrayString, wxVector, wxWindowList. Make viewing the contents of the (most common) container types easier when debugging in MSVS 2012 or later. Provide std::{vector,list}-like visualizers for wxVector and wxWindowList and a special visualizer allowing to see the contents of wxArrayString in a relatively common case when it has just or two elements.

2014-06-14 23:03 VZ, revision 76701

Add a file with debug visualizers for MSVS 2013 and later. For now this file contains just the visualizer for wxWindow which shows its real (most derived) type as this is often the most useful thing you need to know about the window.

2014-06-14 22:23 TIK, revision 76700

Remove the unused anonymous function OffsetWindow to fix a compiler warning.

2014-06-14 22:22 TIK, revision 76699

Remove the unused anonymous function OffsetWindow to fix a compiler warning.

2014-06-14 22:20 TIK, revision 76698

Don't redefine _FORCENAMELESSUNION it if it is already defined. Fixes a warning when compiling with MinGW.

2014-06-14 22:19 TIK, revision 76697

Don't redefine _FORCENAMELESSUNION it if it is already defined. Fixes a warning when compiling with MinGW.

2014-06-13 19:19 VZ, revision 76696

Compilation fix for wxFont in wxMotif. Include wx/crt.h containing wxSscanf() declaration.

2014-06-12 19:14 VZ, revision 76695

Allow using wxALIGN_CENTER in XRC for wxStaticText. Only wxALIGN_CENTRE was allowed previously in the XRC, while both worked in the code and also even in XRC but for wxSizer alignment.

2014-06-12 19:13 VZ, revision 76694

Fix wxDynamicLibrary compilation under Solaris. Add const_cast<> needed for the call to dladdr() to compile.

2014-06-12 19:13 VZ, revision 76693

Allow using wxALIGN_CENTER in XRC for wxStaticText. Only wxALIGN_CENTRE was allowed previously in the XRC, while both worked in the code and also even in XRC but for wxSizer alignment.

2014-06-11 23:31 VZ, revision 76692

Added a brief version of README in markdown for Github users. Now that we have CONTRIBUTING.md there doesn't seem to be any reason for not having README.md as well. Perhaps this one will replace docs/readme.txt in the future.

2014-06-11 23:31 VZ, revision 76691

Update the README after recent changes. Update the platform list after dropping Win9x and OS/2 support. Use new URLs after web site redesign and Trac upgrade.

2014-06-11 23:14 VZ, revision 76690

Convert contributors documentation to markdown. The conversion is very superficial and there are probably many problems in the Markdown rendering, but this is the first step towards making these documents more readable when viewing them online.

2014-06-11 23:14 VZ, revision 76689

Rename tech notes to files with reasonable names. Keep the old files to avoid breaking existing links to them, but just point to the files in the new contributing subdirectory with more meaningful names now. Also remove a couple of long obsolete tech notes.

2014-06-11 22:01 VZ, revision 76688

Add brief contribution instructions for Github users. This should show up when opening Github pull requests.

2014-06-11 17:25 VZ, revision 76687

Fix misspellings of "occurred" and "occurrences". See https://github.com/wxWidgets/wxWidgets/pull/9

2014-06-11 17:25 VZ, revision 76686

Portuguese translations update from Manuella Silva. Update to use new (1990) spelling. See https://github.com/wxWidgets/wxWidgets/pull/5

2014-06-11 16:56 VZ, revision 76685

Install private headers used by wx/unix/execute.h. Although private headers are not normally installed, do install the ones included from the (erroneously) public wx/unix/execute.h to allow code including it to compile. Closes #16325.

2014-06-11 16:55 VZ, revision 76684

Avoid g++ warning about using possibly uninitialized PangoContext. Initialize it to NULL as it could indeed be left uninitialized in some build configurations before.

2014-06-11 16:55 VZ, revision 76683

Move include/wx/unix/execute.h to include/wx/unix/private. This header is private and is not supposed to be used from the outside the library. See #16325.

2014-06-10 02:38 VZ, revision 76682

Show the shaped frame with start shape initially in the sample. It's not clear that setting the window shape actually works if the initial shape is not set.

2014-06-10 02:38 VZ, revision 76681

Don't assert in wxOSX if a shaped window doesn't define a valid shape. A window with wxFRAME_SHAPED style can still not defined any valid shape actually, in which case wxFRAME_SHAPED should be just ignored.

2014-06-10 02:38 VZ, revision 76680

Show the shaped frame with start shape initially in the sample. It's not clear that setting the window shape actually works if the initial shape is not set.

2014-06-10 02:38 VZ, revision 76679

Don't assert in wxOSX if a shaped window doesn't define a valid shape. A window with wxFRAME_SHAPED style can still not defined any valid shape actually, in which case wxFRAME_SHAPED should be just ignored.

2014-06-09 23:31 VZ, revision 76678

Fix wxMSW build without PCH after recent wxListBox font fix. This should have been part of r76673. See #3577.

2014-06-09 23:31 VZ, revision 76677

Fix wxMSW build without PCH after recent wxListBox font fix. This should have been part of r76671. See #3577.

2014-06-09 22:33 VZ, revision 76676

Fix changing the label of a submenu in wxMSW. Use position, not the ID, to find the native menu items to allow the code in wxMenuItem::SetItemLabel() and DoSetBitmap() to also work with submenus and not just the normal items. Closes #16246.

2014-06-09 22:33 VZ, revision 76675

Fix getting position of wxPopupWindow in wxMSW. Don't offset the returned values by the parent window origin unnecessarily: as popup windows are created as children of the desktop window in wxMSW, their coordinates are already expressed in screen coordinate system (which is exactly the same as display window coordinate system) and we must not try to translate them to it once again, this is completely wrong and was probably a left over from earlier wxPopupWindow implementation in which it wasn't created as a child of desktop. Closes #4440.

2014-06-09 22:30 VZ, revision 76674

Fix getting position of wxPopupWindow in wxMSW. Don't offset the returned values by the parent window origin unnecessarily: as popup windows are created as children of the desktop window in wxMSW, their coordinates are already expressed in screen coordinate system (which is exactly the same as display window coordinate system) and we must not try to translate them to it once again, this is completely wrong and was probably a left over from earlier wxPopupWindow implementation in which it wasn't created as a child of desktop. In 3.0 branch we still need to continue overriding virtual DoGetPosition() for ABI reasons, but don't do anything in it any more. Closes #4440.

2014-06-09 02:54 VZ, revision 76673

Fix wxMSW wxCheckListBox appearance when using larger than normal fonts. Update the height of the items when changing the font to ensure that there is enough space to show the item text when using fonts larger than normal. Closes #3577.

2014-06-09 02:54 VZ, revision 76672

Fix changing wxWindow ID in wxMSW. This must be done both at wxWidgets and MSW level, otherwise changing the ID results in window not recognizing itself as the recipient of the messages sent to it by Windows. Closes #3697.

2014-06-09 02:53 VZ, revision 76671

Fix wxMSW wxCheckListBox appearance when using larger than normal fonts. Update the height of the items when changing the font to ensure that there is enough space to show the item text when using fonts larger than normal. Closes #3577.

2014-06-09 02:24 VZ, revision 76670

Work around broken wxWindow::SetId() in wxMSW 3.0 in XRC code. As wxWindow::SetId() doesn't update the ID at the Windows level in 3.0 and can't be modified to do it because of ABI compatibility concerns, work around this in the code calling SetId() in XRC wxUnknownControlContainer itself. Closes #3697.

2014-06-08 18:39 TIK, revision 76669

When loading wxTextCtrl from XRC files, only call SetHint if the XRC specifies a hint. Otherwise an assert is triggered on multi-line text controls.

2014-06-08 15:55 JS, revision 76668

Reverting previous fix for floating object update in 3.0 branch pending further investigation.

2014-06-05 13:29 VZ, revision 76667

Compilation fix for wxMSW with wxUSE_TOOLTIPS==0. This is another fix after the changes of r76657, see #16265.