Changelogs

Document that wxRadioBox::SetSelection() doesn't accept wxNOT_FOUND. A radio box always has selection and it can't be unset (at least not under all platforms), so document that the item passed to its SetSelection() must be valid, unlike with SetSelection() methods in some other classes. Closes #15233.

2013-06-01 01:21 VZ, revision 74072

Change wxMSW wxTreeCtrl::DoFreeze() to not hide the tree any more. Hiding the tree when it's frozen, as done in r72665, results in its own problems, e.g. loss of focus. So don't do this but resize the control to a very small size when freezing it and restore it to its old size afterwards. Closes #15166.

2013-06-01 01:21 VZ, revision 74071

Add wxFileDialog::GetCurrentlySelectedFilename(). Also send wxEVT_UPDATE_UI events for the extra controls in wxFileDialog. The combination of these changes allows extra controls to update their state depending on the current selection in the dialog. Show a simple example of doing it in the dialogs sample. Closes #15235.

2013-06-01 01:21 VZ, revision 74070

Don't create multiple parent-less top level frames in layout sample. This resulted in unexpected behaviour if the main frame was closed while the other ones were still shown as they remained shown and had to be hunted and closed one by one to make the application exit. Fix this simply by creating all the other frames as children of the main one. This also results in better UI when minimizing and restoring the main frame. Also get rid of unused position parameters in child frame constructors and get rid of the title parameter which is not really needed as it's always the same too. See #11923.

2013-06-01 01:21 VZ, revision 74069

Fix wxStyledTextCtrl::SetInsertionPointEnd(). This relied on SetInsertionPoint(-1) working like in wxTextCtrl but it didn't. Add an explicit check to it for consistency with the other classes and to make SetInsertionPointEnd() work. Closes #15234.

2013-06-01 01:21 VZ, revision 74068

Improve horizontal scrolling in wxRibbonControl. Scroll by entire "sections", i.e. panes of the ribbon, instead of scrolling by a fixed number of pixels as it's much more useful and user-friendly to uncover the next section entirely instead of asking the user to press on the arrow several times before being able to use it. Closes #15232.

2013-06-01 01:21 VZ, revision 74067

Use deferred window positioning in wxWindow::Layout() in wxMSW. Ensure that {Begin,End}RepositioningChildren() are called before/after changing the positions of multiple children, whether we're using sizers or constraints. This fixes display corruption which could happen under Windows 7 and a child resized first became bigger, pushing off the children resized later. Closes #15214.

2013-06-01 01:21 VZ, revision 74066

Add wxWindow::BeginRepositioningChildren() and EndRepositioningChildren(). This is just a refactoring of wxMSW code to make it possible to use deferred window positioning from other places in subsequent commits.

2013-06-01 01:20 VZ, revision 74065

Make wxSharedPtr::Release() really MT-safe. Using wxAtomicDec() is not enough, its result also must be checked as it will return 0 only in one of the threads if multiple threads call it in parallel, while the old test for m_count==0 could pass for more than one thread, resulting in deleting the same pointer more than once. Closes #15227.

2013-06-01 01:20 VZ, revision 74064

Fix for special characters in Doxygen comments. Escape "-" characters in the beginning of the paragraph as they are not handled properly by Doxygen otherwise. Escape the space after "i.e." to prevent the brief doc string from being terminated by it. Escape "--" which is translated to a dash by Doxygen otherwise. Closes #15228.

2013-06-01 01:20 VZ, revision 74063

M /wxWidgets/trunk/src/generic/grid.cpp

Fix assert when adding columns to wxGrid using native header. Change the order of updating m_colWidths array and the native header control in wxGird::Redimension() to ensure that we can test whether the column is shown (which results in accessing m_colWidths element at this column index) from the wxGridHeaderCtrl::SetColumnCount(). Closes #15225.

2013-05-31 20:19 SC, revision 74062

M /wxWidgets/trunk/src/osx/menu_osx.cpp

using an empty default menu bar when no menubar is available, see #12402

2013-05-31 20:18 SC, revision 74061

M /wxWidgets/trunk/src/osx/cocoa/menuitem.mm

make sure we have a default handling the quit command, see #12402

2013-05-31 19:33 SC, revision 74060

M /wxWidgets/trunk/src/osx/carbon/app.cpp

avoiding reshow of hidden windows when app is brought forward #12402

2013-05-26 17:32 JS, revision 74058

Applied patch for #15189 - avoid crash when deleting focused cell (dghart)

2013-05-26 15:14 VZ, revision 74057

Reset row and columns count in wxRichTextTable::ClearTable(). No real changes, just update the internal variables in ClearTable() to avoid inconsistent internal state, even if this doesn't seem to result in any problems for now. Closes #15190.

2013-05-26 15:14 VZ, revision 74056

M /wxWidgets/trunk/src/gtk/menu.cpp

Ensure that detached menus don't keep focus grab in wxGTK. A widget being hidden must remove its focus grab with GTK+, otherwise GTK+ would continue sending all input messages to it but fail to process them because the widget is not realized any more, resulting in a complete freeze of the entire program. Do it when detaching menus from menubar and menubar from the frame to fix just such a problem in case SetMenuBar() was called while the previous menubar was opened. Closes #15221.

2013-05-26 15:14 VZ, revision 74055

Fix printing multiple copies in wxMSW. If wxPrinterDC was created by the native "Print" dialog for a printer that supports printing multiple copies, we must not manually print multiple copies ourselves as this results in too many copies being printed. However we still need to loop explicitly for wxPrinterDC objects created manually or for the printers without support for multiple copies (supposing they still exist). Closes #10323.

2013-05-26 15:14 VZ, revision 74054

Use C locale representation for floating point numbers in wxAny. Always use the decimal point, regardless of the current locale. This completes the changes of r74019.

2013-05-26 13:55 VZ, revision 74053

M /wxWidgets/trunk/locale/ta.po

Tamil translations update from DINAKAR T.D.

2013-05-24 19:05 SC, revision 74052

M /wxWidgets/trunk/docs/readme.txt

adding x server license terms for polygon methods

2013-05-24 19:04 SC, revision 74051

M /wxWidgets/trunk/docs/doxygen/mainpages/copyright.h

adding x server license terms for polygon methods

2013-05-24 19:01 SC, revision 74050

A /wxWidgets/trunk/docs/xserver.txt

adding x server license terms for polygon methods

2013-05-24 18:54 SC, revision 74049

M /wxWidgets/trunk/src/osx/carbon/region.cpp

using scan-line polygon conversion for constructing wxregion

2013-05-24 18:05 RD, revision 74048

Add wxRTTI for the wxFileSystemWatcherEvent class

2013-05-24 16:38 SJL, revision 74047

M /wxWidgets/trunk/interface/wx/webview.h

Correctly link to wxWebViewNavigationError from wxWebViewEvent.

2013-05-24 16:04 SJL, revision 74046

M /wxWidgets/trunk/interface/wx/webview.h

Document the unused baseURL parameter in wxWebViewIE. See #15223.

2013-05-22 16:13 VZ, revision 74045

Add ctor and assign() taking an iterator range to wxVector<>. Do it for consistency with wxArray and std::vector<>, even if the current implementation is suboptimal. See #15216.

2013-05-22 16:13 VZ, revision 74044

M /wxWidgets/trunk/include/wx/dynarray.h

Add ctor from two input iterators to wxArray in STL build too. This ctor already existed in non-STL build but was omitted from the STL version. Closes #15216.

2013-05-22 15:36 VZ, revision 74043

Fix regression in wxGTK wxFilePickerCtrl due to wxFileDialog changes. Revert the changes of r72979 and fix wxFileDialog::GetDirectory() return value bug (see #14786) differently to avoid breaking wxFilePickerCtrl which relies on getting wxEVT_BUTTON event when the associated dialog is dismissed. Closes #15218.

2013-05-22 15:36 VZ, revision 74042

M /wxWidgets/trunk/src/gtk/filepicker.cpp

Fix GTK+ errors during wxFilePickerCtrl destruction after recent changes. We do need to destroy the dialog (see #15156), but we must not destroy its GtkWidget as it is owned by GtkFileChooserButton itself, so amend the changes of r74030 to only destroy the C++ object, not GTK+ one.

2013-05-22 01:47 VZ, revision 74041

M /wxWidgets/trunk/src/osx/cocoa/preferences.mm

Use the best instead of current page size in OS X preferences dialog. The page, which is typically just a wxPanel, is usually not created with the correct size, so resize it to its best size before showing it in the preferences dialog. This makes OS X behaviour consistent with MSW and GTK and is generally more useful.

2013-05-22 01:17 VZ, revision 74040

M /wxWidgets/trunk/src/generic/preferencesg.cpp

Fit modeless preferences dialog to its contents too. When a preferences dialog is shown non-modally, it should still fit to the contents of its pages, so move the code added for the modal case in r73624 to the base wxGenericPreferencesEditorImplBase class.

2013-05-21 14:02 VZ, revision 74039

M /wxWidgets/trunk/locale/tr.po

Turkish translations update from Kaya Zeren.

2013-05-20 17:26 VZ, revision 74038

M /wxWidgets/trunk/src/common/stream.cpp

Fix last count value after ReadAll() and WriteAll(). This corrects the bugs introduced when applying the patch adding these functions in r74034: we can't simply use m_lastcount directly in them because it's also modified by each call to Read() and Write(), so do use the temporary variable. See #12056.

2013-05-20 15:15 VZ, revision 74037

Add a public wxModalDialogHook class for intercepting modal dialogs. Extract wxModalDialogHook from wx/testing.h into its own wx/modalhook.h, extend it to allow to be notified not only about showing modal dialogs but also about dismissing them and document it and show its use in the dialogs sample. Also replace all the WX_TESTING_SHOW_MODAL_HOOK macros occurrences with WX_HOOK_MODAL_DIALOG.

2013-05-20 15:15 VZ, revision 74036

Fix return value of wxCountingOutputStream::LastWrite(). Don't reuse m_lastcount in wxCountingOutputStream to store the stream length, this doesn't make any sense and results in LastWrite() returning completely wrong results as it expects m_lastcount to be the number of bytes written by the last operation. Add m_lastPos member to store the stream length instead. Also correct wxCountingOutputStream documentation. Closes #15215.

2013-05-20 15:15 VZ, revision 74035

M /wxWidgets/trunk/src/common/imagbmp.cpp

Make code reading BMP files more robust. Check that we did correctly read the requested amount of data instead of blindly assuming that the needed (from the point of view of BMP format specification) number of bytes are always available -- this doesn't work so well with corrupted or truncated files. Closes #12056.

2013-05-20 15:15 VZ, revision 74034

Add wxInputStream::ReadAll() and wxOutputStream::WriteAll(). Unlike Read() and Write(), these functions always transfer exactly the specified number of bytes or fail. See #12056.

2013-05-19 19:26 VZ, revision 74033

Link with liblzma when using built-in libtiff if it's available. New version of libtiff includes code using liblzma if it's available, so we need to link with it in this case. Closes #14963.

2013-05-19 14:47 VZ, revision 74032

M /wxWidgets/trunk/src/stc/stc.cpp.in

Propagate wxEVT_COMMAND_TEXT_UPDATED renaming to the real stc.cpp. wxEVT_COMMAND_TEXT_UPDATED was renamed to wxEVT_TEXT in the generated stc.cpp but not in stc.cpp.in it was generated from. Do it there too to prevent the correct version in stc.cpp from being overwritten during the next regeneration. See #10661.

2013-05-19 14:38 VZ, revision 74031

M /wxWidgets/trunk/src/common/log.cpp

Trigger wxLog auto-creation when getting old logger in wxLogChain ctor. This ensures that a program that uses wxLogChain or one of the classes deriving from it, such as wxLogWindow, can do it directly without worrying about the standard logging being completely suppressed if the default log target hadn't been instantiated yet.

2013-05-19 14:38 VZ, revision 74030

Delete the associated dialog in wxGTK wx{File,Dir}Button. The code seemed to rely on Destroy() being called for deleting the dialog, but it's actually not used for child windows, so do it in dtor instead. Closes #15156.

2013-05-19 14:38 VZ, revision 74029

Add conversions to/from long long to wxUniChar. Allow conversions to/from long long and unsigned long long values in wxUniChar for consistency with the other integral types. Also make the code shorter by using helper wxDO_FOR_INT_TYPES() and wxDO_FOR_CHAR_INT_TYPES() macros to avoid duplicating the same code for all of the integral types and having to handle wchar_t (and wxLongLong_t now) specially because sometimes we may need to overload on it and sometimes not. Finally, add more tests to check that all the wxUniChar methods compile and work with all the different types. Closes #15206.

2013-05-19 14:38 VZ, revision 74028

M /wxWidgets/trunk/tests/menu/menu.cpp

Disable menu event test case in wxGTK buildbot slaves. This test sporadically fails for unknown reason and I don't know what to do about it, so disable it for now to let the test suite pass consistently and be notifed about any new failures.

2013-05-18 16:07 SJL, revision 74020

Use wxCOMPtr throughout the wxWebViewIE Find code. As well as making the code a bit neater this seems to fix some memory issues. See #15207.

2013-05-17 22:00 VZ, revision 74019

Test using wxString::ToCDouble() in wxAny. Apparently the heap corruption problems in wxOSX/PPC build are due to using wxString::ToDouble() and not anything done specifically in wxAny at all.

2013-05-17 13:53 VZ, revision 74017

M /wxWidgets/trunk/tests/any/anytest.cpp

Try using wxString::ToCDouble() instead of ToDouble() in wxAny case. Apparently enabling the call to ToDouble() in the test is enough to corrupt the heap in wxOSX PPC build. No idea how can this be possible but try to check if using ToCDouble() helps...

2013-05-17 13:53 VZ, revision 74016

M /wxWidgets/trunk/include/wx/preferences.h

Make wxPreferencesEditor dtor virtual. Mainly just to suppress g++ warnings about a class with virtual functions but non-virtual dtor, this class isn't really supposed to be used polymorphically.

2013-05-16 20:00 RD, revision 74014

M /wxWidgets/trunk/interface/wx/richtext/richtextctrl.h

Add richtext event types.

2013-05-16 20:00 RD, revision 74013

M /wxWidgets/trunk/interface/wx/richtext/richtextctrl.h

More richtext fixes and cleanup for Phoenix

2013-05-16 19:57 RD, revision 74012

M /wxWidgets/trunk/interface/wx/slider.h

Add docs for SetMin and SetMax

2013-05-16 16:43 VZ, revision 74011

M /wxWidgets/trunk/include/wx/xrc/xmlreshandler.h

Initialize wxXmlResourceHandler members in its ctor. Not sure if this results in any real problems but at the very least memory checking tools give errors about reading uninitialized memory in wxXmlResourceHandlerImpl::CreateResource() if we leave them uninitialized, so do initialize all the pointers.

2013-05-16 16:43 VZ, revision 74010

Allow wxPreferencesEditor::Dismiss() to work when using modal dialogs too. The modal dialog case is not really different, the dialog may still need to be dismissed if the associated object doesn't exist any longer.

2013-05-16 16:43 VZ, revision 74009

Add wxPreferencesEditor::ShownModally(). While this is not necessary to use wxPreferencesEditor in normal scenario, it can be useful if the program needs to handle modal dialogs in some special way.

2013-05-16 16:43 VZ, revision 74008

Make wxPreferencesEditor::Show() virtual. This allows derived classes to override it to do something before/after showing the dialog, which can be useful on the platforms where modal dialogs are used for wxPreferencesEditor implementation.

2013-05-16 16:42 VZ, revision 74007

Use "<Application> Preferences" as generic wxPreferencesEditor dialog title. This is more appropriate than just "Preferences" under MSW and GTK which use the generic wxPreferencesEditor, OS X has its own native version which continues to correctly use "Preferences" for the title.

2013-05-16 16:42 VZ, revision 74006

Allow to specify the title used by wxPreferencesEditor window. Customize the title is useful for "Settings"-style windows which are used for editing the properties of the given object, that should be identified in the window title, as opposed to the global program preferences.

2013-05-16 16:42 VZ, revision 74005

M /wxWidgets/trunk/src/generic/preferencesg.cpp

Open generic wxPreferencesEditor at last shown page. This is very convenient under systems using a modal dialog for the preferences editor implementation (such as MSW), as it allows to do several changes in the same page without having to select it manually every time.

2013-05-16 16:42 VZ, revision 74004

M /wxWidgets/trunk/src/generic/preferencesg.cpp

Rename CreateWindow() to CreateDialog() in generic wxPreferencesEditor code. No real changes, just rename a method to avoid confusion with wxPreferencesPage::CreateWindow(). Also return the concrete type of the dialog, not a base wxDialog, as it will be useful for future changes.

2013-05-16 16:33 VZ, revision 74003

Add wxEVT_DIRCTRL_FILEACTIVATED wxDirCtrl event. Allow processing double clicks on the files in the directory control. Closes #15208.

2013-05-16 16:33 VZ, revision 74002

Rename wxEVT_DIRCTRL_CHANGED to wxEVT_DIRCTRL_SELECTIONCHANGED. This is more consistent with the existing wxEVT_FILECTRL_SELECTIONCHANGED. Closes #15209.

2013-05-16 16:32 VZ, revision 74001

Allow associating a validator with wxGridCellTextEditor. Add wxGridCellTextEditor::SetValidator() for finer control over text input in wxGrid. Closes #15176.

2013-05-16 16:32 VZ, revision 74000

M /wxWidgets/trunk/tests/any/anytest.cpp

Re-enable yet another hopefully harmless test in wxAny test case.

2013-05-16 16:15 VS, revision 73999

Call wxThread::Create() from Run() automatically. In the common case, when Run() is called immediately after Create() and default stack size is used, it's unnecessarily verbose. Just create the thread in Run() if it wasn't done explicitly yet.

2013-05-16 16:15 VS, revision 73998

M /wxWidgets/trunk/src/unix/threadpsx.cpp

Move POSIX implementation of wxThread::Create() to wxThreadInternal. No real changes, just refactoring to follow the same pattern as other implementations use.

2013-05-16 16:15 VS, revision 73997

M /wxWidgets/trunk/src/unix/threadpsx.cpp

Lock m_critsect in POSIX wxThread::Create(). This is the documented behavior: all methods accessing m_internal should lock it.

2013-05-16 13:40 VZ, revision 73996

M /wxWidgets/trunk/tests/any/anytest.cpp

Re-enable wxAny<double>::GetAs<wxString>() test.

2013-05-16 08:18 JJ, revision 73995

M /wxWidgets/trunk/include/wx/datstrm.h

m_useExtendedPrecision is only used if the macro wxUSE_APPLE_IEEE is defined

2013-05-16 03:45 VZ, revision 73994

M /wxWidgets/trunk/tests/any/anytest.cpp

Enable wxAny<double>::GetAs<unsigned long>() test.

2013-05-15 23:45 VZ, revision 73993

M /wxWidgets/trunk/tests/any/anytest.cpp

Re-enable a single m_anyDoubleDouble1 test in wxAny test case.

2013-05-15 23:45 VZ, revision 73992

M /wxWidgets/trunk/src/xml/xml.cpp

Fix wxXmlNode self-assignment. Don't lose the node contents if it's assigned to itself.

2013-05-15 22:02 VZ, revision 73991

M /wxWidgets/trunk/tests/any/anytest.cpp

Reenable m_anyBool1 tests in wxAny test case too.

2013-05-15 22:01 VZ, revision 73990

Fix memory leak in wxXmlNode::operator=(). We must delete all children and attributes in the node being overwritten and not just the first one of each. Add a unit test exercising this code to be able to check that valgrind doesn't report memory leak any more after the fix.

2013-05-15 15:05 VZ, revision 73989

M /wxWidgets/trunk/tests/any/anytest.cpp

Re-enable conversions of wxAny to boolean tests.

2013-05-15 15:05 VZ, revision 73988

Restore ability to parse hours only with wxDateTime::ParseTime(). This was accidentally removed in r51059, but worked in 2.8 and so should continue to work. Also add a unit test to ensure that this doesn't get broken again in the future. Closes #15204.

2013-05-15 15:05 VZ, revision 73987

M /wxWidgets/trunk/src/gtk/popupwin.cpp

Fix crash in wxGTK wxPopupWindow when creating it without parent. Popup windows don't necessarily have a parent, so don't crash if parent pointer is NULL in wxPopupWindow::Create(). Closes #15173.

2013-05-15 15:05 VZ, revision 73986

M /wxWidgets/trunk/include/wx/dynarray.h

Allow shrinking the array with wxArray::resize(). This method did nothing if its argument was less than the current array size, as it was just a synonym for SetSize() which was documented to behave like this, but this was inconsistent with std::vector and wxVector resize() which does shrink the array, so change wxArray version to shrink it too. Closes #15195.

2013-05-15 15:05 VZ, revision 73985

M /wxWidgets/trunk/tests/controls/textentrytest.cpp

Fix typo in a closing "#endif" comment in the test. Closes #15203.

2013-05-14 18:58 VS, revision 73984

Move wxTransform2D methods' bodies to geometry.cpp. They are all virtual and so cannot be inlined anyway and having them in the header like this confuses the g++ linker into always pulling some of the methods in merely because geometry.h was included.

2013-05-14 13:07 VZ, revision 73982