Changelogs

Overview

These changelogs reflect the history of all files in the Subversion repository. The changelog has been generated at 2015-03-05 06:30:01

Select Changelog:

FileZilla 3, FileZilla,
FileZilla Server, wxWidgets

Changes per page:

25 50 100 250 500 1000 2000

Changelog for wxWidgets (70435 changes):

2015-02-18 18:37 JS, revision 78522

Now uses the correct font and text effect when drawing bullet text.

2015-02-18 18:19 AW, revision 78521

Restore original grid size when finishing the tests in propgrid sample.

2015-02-18 18:17 AW, revision 78520

Fix "Multiple Columns" test in propgrid sample. Resize grid to make the results of test visible.

2015-02-18 18:13 AW, revision 78519

Suppress sending spurious wxEVT_PG_SELECTED events. Don't send wxEVT_PG_SELECTED event when wxPG is ordered to unselect current property but no property is actually selected.

2015-02-18 13:18 JS, revision 78518

Now allows space for a bullet even if no left subindent was specified; added a MeasureBullet function to support this.

2015-02-18 12:10 JS, revision 78517

Comment correction

2015-02-18 12:07 JS, revision 78516

Fix for GetVisibleLineForCaretPosition, and a weird boolean test.

2015-02-17 21:52 AW, revision 78515

Initialize wxPGChoices object properly in its copy ctor if source object has no data. Internal data must be always initialized whether the source object contains choices data or not. This is the backport of r78484. See #16855.

2015-02-17 21:42 AW, revision 78514

Refresh property grid when property is switched to read-only state. Property grid is refreshed to reflect the new state of the property. This is the backport of r76875. See #16306.

2015-02-17 18:36 AW, revision 78513

Implement more detailed validation of wxArrayDoubleProperty in propgrid sample. Added wxArrayDoubleProperty::ValidateValue() method checks if pending value is of proper type (wxArrayDouble). Pending value of improper type is used to signal that invalid numeric value was entered into the edit field.

2015-02-17 07:19 DS, revision 78512

Fix exception when creating a wxGauge. Platforms that don't make use of wxGaugeBase::Create when creating a wxGauge (such as GTK and MSW) access the uninitialised m_appProgressIndicator. Fix by initialising m_appProgressIndicator to NULL in the wxGaugeBase constructor. Regression since r78499.

2015-02-16 22:42 RD, revision 78511

Add some missing default ctors and Create methods.

2015-02-16 22:40 RD, revision 78510

Add some missing default ctors and Create methods.

2015-02-16 21:50 AW, revision 78509

When drawing wxPG items (with double buffering) use the same layout direction as the window uses. Memory DC used for double buffering purposes should inherit layout direction from the window DC to ensure that texts are rendered correctly. This is the backport of r76931. See #15797.

2015-02-16 21:38 AW, revision 78508

Fix saving edited property value when wxPG property is in the 'invalid value' state. When wxPGProperty is loosing focus in 'invalid value' state its pending value should be stored before resetting property to 'normal' state because this operation (wxPG::OnValidationFailureReset) also resets pending value. This is the backport of r77887. See #16587.

2015-02-16 14:00 VZ, revision 78507

Correct wxLogSysError() calls after chdir() failure in wxGTK. Another fix for the changes of r78480: don't forget to pass the file/directory name to wxLogSysError(). Closes #16865.

2015-02-16 02:06 VZ, revision 78506

Increase the buffer size used for the host names in wxIPaddress. This avoids failing to set the host name if the system /etc/hosts file has any host names that wouldn't fit in our buffer: at least under Linux/glibc, gethostname_r() returns error if any such names exist even if we don't ask for them. Closes #16641.

2015-02-16 02:05 VZ, revision 78505

Increase the buffer size used for the host names in wxIPaddress. This avoids failing to set the host name if the system /etc/hosts file has any host names that wouldn't fit in our buffer: at least under Linux/glibc, gethostname_r() returns error if any such names exist even if we don't ask for them. Closes #16641.

2015-02-16 00:26 AW, revision 78504

Display additional information for EVT_PG_SELECTED event in propgrid sample.

2015-02-16 00:23 AW, revision 78503

wxEVT_PG_SELECTED event object generated when property is unselected should refer to the property being unselected. Currently, wxEVT_PG_SELECTED event object generated when property is unselected doesn't refer to the property being unselected (in fact it doesn't refer to any property; pointer to the property is NULL) and therefore it is not possible to determine unselected property or to check its state.

2015-02-15 23:54 VZ, revision 78502

Fix wxDV_ROW_LINES drawing when horizontally scrolled in generic version. Use the correct, i.e. logical, as wxDC does the translation to physical internally, coordinates for drawing the highlighted rows. Closes #16815.

2015-02-15 23:54 VZ, revision 78501

Fix wxDV_ROW_LINES drawing when horizontally scrolled in generic version. Use the correct, i.e. logical, as wxDC does the translation to physical internally, coordinates for drawing the highlighted rows. Closes #16815.

2015-02-15 23:21 AW, revision 78500

Prevent sending wxEVT_PG_LABEL_EDIT_ENDING events recursively. By preventing sending wxEVT_PG_LABEL_EDIT_ENDING events recursively (recursive generation can happen due to the calling wxPropertyGrid::RefreshProperty() directly or indirectly from within wxEVT_PG_LABEL_EDIT_ENDING event handler) spurious events are not sent to the application and wxPropertyGrid::DoEndLabelEdit() function is not reentered. Closes #16864.

2015-02-15 21:09 DS, revision 78499

Add OS X implementation of wxAppProgressIndicator. Closes #16638.

2015-02-15 19:35 VZ, revision 78498

Show how to handle files on command line in docview sample. This is not totally obvious, so show how to do it, including the Mac-specific MacNewFile() overriding part. Closes #16816.

2015-02-15 18:11 DS, revision 78497

No code changes, fix some typos. Change several occurrences of "it's" where "its" is meant, as well as a few other minor typos.

2015-02-15 14:52 AW, revision 78496

Fix using a value of enumerated type in propgrid sample. Referring to enumerated type name (wxNumericPropertyValidator::NumericType) in expression is incorrect however it is accepted by VC++. GCC is not so merciful.

2015-02-15 01:02 VZ, revision 78495

Make wxUIActionSimulator::Text() to work with punctuation characters. Currently this only really works when using the standard US keyboard layout as we don't have information about the mapping from the characters to the keyboard keys for the other layouts, which is not ideal but better than nothing as it allows e.g. Text("foo_bar") to really produce "foo_bar" in the currently focused text control instead of "foo-bar" as before.

2015-02-15 01:01 VZ, revision 78494

Remove code not doing anything from wxUIActionSimulator::Char(). The changes of r69762 and r69960 cancelled each other out, leaving a long switch statement which didn't do absolutely anything -- and doesn't seem to be needed at all, so drop it. See #13671.

2015-02-15 01:01 VZ, revision 78493

No real changes, just fix a typo in a comment. s/ommitted/omitted/

2015-02-15 01:01 VZ, revision 78492

Remove useless check for NULL in wxFindWindowRecursively(). This is an internal function which is only ever called with non-NULL window.

2015-02-14 20:09 VZ, revision 78491

Use non-static reentrancy guard in wxScrollHelper::AdjustScrollbars(). This prevented calls to AdjustScrollbars() of another window from doing anything if they were called due to a size change from AdjustScrollbars() of an outer window. Closes #16852.

2015-02-14 19:37 DS, revision 78490

Regenerate Xcode projects. Update the Xcode projects to include addremovectrl.cpp, dbgrptg.cpp, and debugrpt.cpp .

2015-02-14 16:05 VZ, revision 78489

Fix coordinates of wxSetCursorEvent in wxGTK. The event coordinates remained in the client coordinates of the window the initial event had been sent to, even when the event was propagated to its parent.

2015-02-14 16:04 VZ, revision 78488

Fix coordinates of wxSetCursorEvent in wxGTK. The event coordinates remained in the client coordinates of the window the initial event had been sent to, even when the event was propagated to its parent.

2015-02-14 15:46 VZ, revision 78487

Correct wxInfoBar::ShowMessage() flags argument documentation. The default value is wxICON_INFORMATION, not wxICON_NONE. Closes #16861.

2015-02-14 15:46 VZ, revision 78486

Correct wxInfoBar::ShowMessage() flags argument documentation. The default value is wxICON_INFORMATION, not wxICON_NONE. Closes #16861.

2015-02-13 22:49 DS, revision 78485

Update XML Tools URL.

2015-02-13 20:42 AW, revision 78484

Initialize wxPGChoices object properly in its copy ctor if source object has no data. Internal data must be always initialized whether the source object contains choices data or not. Closes #16855

2015-02-13 20:36 VZ, revision 78483

Use non-static reentrancy guard in wxScrollHelper::AdjustScrollbars(). This prevented calls to AdjustScrollbars() of another window from doing anything if they were called due to a size change from AdjustScrollbars() of an outer window. Closes #16852.

2015-02-12 23:48 VZ, revision 78482

PCH-less build fixes after r78480. Must include wx/log.h to use wxLogSysError() when not using PCH.

2015-02-12 22:56 VZ, revision 78481

Avoid warnings about not checking read() result in wxJoystick code. Explicitly ignore errors if we can't read from the associated FD. This is mostly done to avoid -Wunused-result warning about not checking read() return value under Ubuntu.

2015-02-12 22:56 VZ, revision 78480

Avoid warnings about not checking chdir() result in wxGTK. Give error if changing directory when wxFD_CHANGE_DIR or wxDIRP_CHANGE_DIR flags are used, this is a good idea generally speaking and it also avoids warnings about not checking chdir() return value that we got under Ubuntu.

2015-02-12 07:12 PC, revision 78479

More complete fix to avoid GDK assertion "impl_window->update_freeze_count > 0" on Ubuntu. Any frozen window in the whole TLW could be affected, not just a child of the enabled window. Also do a more complete search for scrollbars. Closes #16795

2015-02-11 22:16 VZ, revision 78478

Make wxStaticText alignment work with wxGTK2. Alignment was silently ignored in wxStaticText with GTK+ 2 since 2.12 or so, make it work even at the price of using a non-default ellipsize mode as this seems to be the only way to have it at all. Closes #12539.

2015-02-11 22:16 VZ, revision 78477

Add convenient wxST_ELLIPSIZE_MASK constant. This is simply a combination of all 3 different wxST_ELLIPSIZE_XXX styles and makes it simpler to test if any of them is specified. No real changes.

2015-02-11 22:16 VZ, revision 78476

Remove obsolete checks for wxOS_WINDOWS_NT from wxMSW wxStaticText. We don't support Windows 9x any more, so there is no need to check for NT damily at run-time.

2015-02-11 19:11 PC, revision 78475

build fix for __WXUNIVERSAL__

2015-02-11 19:05 PC, revision 78474

avoid GDK assertion "impl_window->update_freeze_count > 0" on Ubuntu when enabling frozen window closes #16795

2015-02-11 07:12 MAR, revision 78473

Re-introduce private mbstowcs/wcstombs for wxQt-Android These functions are needed due Android NDK lacking wide character support, as wchar_t == char according to Android NDK bionic libc/include/wchar.h WARNING: They are minimally functional (provided provisorily until proper workaround is found, specially maybe using Qt built-in functionality). "Basically they produce complete garbage with non-ASCII characters" For more info see discussion in wx-dev list: https://groups.google.com/d/msg/wx-dev/71qtIFcujgM/Q-lbwl59vOIJ Thanks @seandepagnier (modified a bit the comments, added #warning and restructured #if blocks to be only specific for __ANDROID__)

2015-02-11 05:36 MAR, revision 78472

For Android (wxQT), add private wcstol, wcstoul and wcstod These functions are needed by wxString::ToLong wxString::ToDouble etc.. They do exist in the android library, but do not work corretly. This change implements them using strtol strtoul and strtod For more info see discussion in wx-dev list: https://groups.google.com/d/msg/wx-dev/71qtIFcujgM/TRCfCjGHUhEJ Thanks @seandepagnier (modified a bit the comments)

2015-02-11 00:14 VZ, revision 78471

Fix spurious assert in wxGTK wxDataViewCtrl::EditItem(). The assert in wxGtkTreeSelectionLock ctor failed after the first time this object was created as it doesn't reset the selection function to NULL with wxGTK2, fix this by checking for different values depending on whether it's actually the first time we do it or not. In the future we should just reset the selection function to NULL as it does work in GTK+ 3, also update the comment explaining the problem to mention this.

2015-02-11 00:14 VZ, revision 78470

Fix handling of disabled cells in wxGTK wxDataViewCtrl. The original code (see r66404 and r66416) didn't work because it used wxDataViewRenderer::SetMode() to make the renderer inactive but then used its GetMode() to restore the previous state -- which was lost. The result of this was that if the overridden IsEnabled() in the model ever returned false for any row, all the cells in this column, in all the rows, became insensitive, as could be seen by the inability to edit any rating in the first page of the dataview sample (even though it was disabled for a single row only) and any checkboxes on its third page (even though only the last two of them were supposed to be disabled). Fix this simply by making the renderer insensitive at GTK level only, but do not change the mode at wx level. See #12686.

2015-02-11 00:14 VZ, revision 78469

Add check for wxUSE_ADDREMOVECTRL being defined. This should have been part of r78462.

2015-02-11 00:14 VZ, revision 78468

Fix typos in wxTreeEvent::GetOldItem() documentation. Use the correct EVT_TREE_SEL_CHANG{ING,ED} event names instead of the non-existent EVT_TREE_ITEM_CHANG{ING,ED} ones. Closes #16847.

2015-02-11 00:14 VZ, revision 78467

Don't validate and transfer data from hidden dialogs when closing. This is unexpected and resulted e.g. in calling the user-defined TransferDataFromWindow() multiple times for wxPreferencesPages used in wxPreferencesEditor under wxGTK (where it is modeless).

2015-02-09 19:19 PC, revision 78466

don't assume size-allocate implies a widget is realized

2015-02-09 13:10 VZ, revision 78465

Fix DLL declaration of wxAddRemoveCtrlNameStr. The control, and its name string, are in the "adv" library, not "core".

2015-02-09 13:10 VZ, revision 78464

Undo accidental change to the notebook sample. This debugging/testing change was accidentally committed as part of r78462.

2015-02-09 13:10 VZ, revision 78463

Really break into the debugger at the assertion line under wxGTK. This completes the changes of r78408: in addition to making wxTrap() a macro, we also need to call it directly from the assert macro expansion instead of doing it from deep inside wx assert dialog code. See #11184.

2015-02-09 01:26 VZ, revision 78462

Add wxAddRemoveCtrl class. This is a simple high level helper combining an arbitrary control showing multiple items with the buttons allowing to add items to and remove items from this control, but using the buttons and the layout appropriate for the current platform. Add the implementation itself, an example of using it to the dialogs sample and the documentation.

2015-02-09 01:25 VZ, revision 78461

Add an accessor for GtkToolbar widget of wxToolBar. This can be used to customize the toolbar beyond the capabilities of wx API.

2015-02-08 17:36 SC, revision 78460

correcting NSSmallSquareBezelStyle layout inset (top and bottom 1 pixel)

2015-02-08 13:51 AW, revision 78459

Use wxSwap() function to swap values of array elements in wxArrayDoubleEditorDialog::ArraySwap()

2015-02-08 13:48 AW, revision 78458

Use bool constants instead of BOOL ones in propgrid sample. s/FALSE/false/ and s/TRUE/true for the sake of consistency.

2015-02-08 13:45 AW, revision 78457

Implement validator for wxArrayDoubleProperty in propgrid sample. In wxArrayDoubleProperty::DoGetValidator() there is instantiated a wxTextValidator accepting numeric characters, token delimiter and spaces.

2015-02-08 12:17 BP, revision 78456

Turn off batchmode for PDF manual, and no longer update latex_header.

2015-02-08 03:53 BP, revision 78455

Shorten PDF manual ToC, and fix ToC indents. The table of contents is over 600 pages long with the default settings. Now it only lists down to section, and runs 45 pages. Section numbers were also colliding with names, so this fixes the margins in the table of contents.

2015-02-07 23:13 BP, revision 78454

Center the PDF manual logo.

2015-02-06 20:28 VZ, revision 78453

Allow documents without template nor views be deleted correctly again. The changes of r78282 didn't take into account the case of a document without any views nor template and, consequently, without the associated manager. Such documents were not deleted at all any longer. Fix this by ensuring that a document is always associated with a manager: if not with the one specified by its template, then with the global one.

2015-02-06 02:51 BP, revision 78452

Fix LaTeX docs for PDF manual. LaTeX fails to handle tables nested in @param sections, and we've only used them to expand on enums that should be documented on their own anyway, so the docs have been extracted here.

2015-02-06 02:51 BP, revision 78451

Minor adjustments to LaTeX manual header.

2015-02-06 02:51 BP, revision 78450

Sync with Doxygen LaTeX header. Using a custom header is an "experimental" feature since it bypasses several Doxygen configuration options, and skips configuration changes necessary for all automatically generated LaTeX. This continues to use the nicer looking custom header, but brings it up-to-date with the automatically generated one from 1.8.8.

2015-02-04 18:58 BP, revision 78449

Backport r78447: Updated logos in the reference manual.

2015-02-04 18:44 VZ, revision 78448

Fix the expected size of the header logo on www.wxwidgets.org. The image has been updated in the website repository and online, update its expected size to reflect it and fix the unit test suite.

2015-02-04 18:44 BP, revision 78447

Updated logos in the reference manual.

2015-02-04 18:05 AW, revision 78446

Fix small typo in propgrid sample.

2015-02-04 17:53 AW, revision 78445

Use wxPG_IMPLEMENT_PROPERTY_CLASS macro in the propgrid sample. Replace old WX_PG_IMPLEMENT_PROPERTY_CLASS macro with new and simplified wxPG_IMPLEMENT_PROPERTY_CLASS macro. See #15541

2015-02-04 17:46 AW, revision 78444

Replace WX_PG_IMPLEMENT_PROPERTY_CLASS macro with simplified wxPG_IMPLEMENT_PROPERTY_CLASS macro. New macro have no obsolete parameters and its name conforms to the naming standard (prefixed with wx). Closes #15541

2015-02-04 17:18 VZ, revision 78443

Make wxNativePrinterDC::IsOk() const in wxOSX. Closes #16837.

2015-02-04 17:17 VZ, revision 78442

Minor changes in wxChmTools: add const, remove semicolons. Also fix a typo in a comment. Closes #16836.

2015-02-04 14:19 VZ, revision 78441

Fix a couple of typos in comments in wxX11 code. Closes #16835.

2015-02-04 14:19 VZ, revision 78440

Remove unnecessary statement from wxX11 wxTextCtrl code. We don't care about size_x variable value and should probably get rid of it entirely, but for now at least don't update it unnecessarily. Closes #16834.

2015-02-04 14:19 VZ, revision 78439

Don't declare unnecessary variable in wxUSE_NANOX wxX11 build. Closes #16833.

2015-02-04 14:18 VZ, revision 78438

Don't check if an unsigned variable is less than 0. This doesn't risk ever being true. Closes #16831.

2015-02-04 14:18 VZ, revision 78437

De-TAB wxX11 code. Remove hard TABs.

2015-02-04 14:16 VZ, revision 78436

Fix harmless unused variable warning in some build configurations. Don't declare the variables if they are not going to be used. Closes #16830.

2015-02-04 14:16 VZ, revision 78435

Suppress harmless unused parameter warnings in release build. Use WXUNUSED_UNLESS_DEBUG() for the parameters used only inside debug checks. Closes #16829.

2015-02-03 19:28 VZ, revision 78434

Consistently refuse to create bitmaps with 0 width or height. Homogenize the behaviour of all ports when creating bitmaps with 0 width or height: just fail always as it doesn't seem to make sense to support this. Closes #16828.

2015-02-02 19:31 PC, revision 78433

set transient parent for 'about' dialog, closes #16823

2015-02-02 18:23 PC, revision 78432

use logical operator, rather than bitwise, on bools, closes #16824

2015-02-01 19:06 PC, revision 78431

avoid passing invalid rect to Refresh(), closes #16819

2015-02-01 12:33 VZ, revision 78430

Prettify configure output when checking for backtrace(). The output of "checking for backtrace()" was interspersed with the output of "checking for library containing backtrace", which was ugly and potentially confusing, so move AC_SEARCH_LIBS() out of AC_CACHE_CHECK() to fix it.

2015-02-01 12:14 AW, revision 78429

Fix vertical positioning of text field in the combo box editor associated with wxPG property under wxMSW. Vertical position of text field in wxOwnerDrawnComboBox control (instantiated at property selection) doesn't need any special adjustment. This is a backport of r77687. See #16556.

2015-01-31 22:49 AW, revision 78428

Encapsulate wxPGProperty::m_children member variable. Implement RemoveChild and SortChildren methods to perform operations on m_children member variable.

2015-01-31 22:45 AW, revision 78427

Use getter methods to get access to wxPGProperty member variables. Use GetValueImage() getter to get access to m_valueBitmap data member. Use GetMaxLength() getter to get access to m_maxLen data member. Use GetAttributes() getter to get access to m_attributes data member. Use GetChoices() to get access to m_choices data member. Use GetDepth() to get access to m_depth member variable. Use GetBaseName() method to get access to m_name data member Use GetLabel() method to get access to m_label member variable.

2015-01-31 22:42 AW, revision 78426

Use getter/setter methods to get access to wxPGProperty::m_flags. Use dedicated wxPGProperty::HasFlags, wxPGProperty::SetFlag methods to check or modify wxPGProperty::m_flags member variable.

2015-01-30 16:53 VS, revision 78425

Avoid unneeded use of wxLocale in wxDateTime::Format() On OS X, wxDateTime::Format() uses wxString::Replace() to unconditionally replace locale-specific %c, %x and %X specifiers in the format string if present. Doing so causes three wxLocale::GetInfo() calls that are often not necessary. Check for the presence of these specifiers before calling GetInfo().

2015-01-30 16:53 VS, revision 78424

Handle 5+ letter codes in TranslateFromUnicodeFormat() Unicode TR #35 v26 allows for five-letter (MMMMM) or even six-letter (EEEEEE) forms of some of the fields, but TranslateFromUnicodeFormat() asserts in these situations. Fix it to fall back to short forms for MMMMM and EEEEEE that are used in practice e.g. on OS X if the user has custom formatting settings. Consulting the table of sensible specifiers from http://userguide.icu-project.org/formatparse/datetime, it appears these two were the only omissions in this function.

2015-01-30 16:53 VS, revision 78423

Avoid unneeded use of wxLocale in wxDateTime::Format() On OS X, wxDateTime::Format() uses wxString::Replace() to unconditionally replace locale-specific %c, %x and %X specifiers in the format string if present. Doing so causes three wxLocale::GetInfo() calls that are often not necessary. Check for the presence of these specifiers before calling GetInfo().

2015-01-30 16:53 VS, revision 78422

Handle 5+ letter codes in TranslateFromUnicodeFormat() Unicode TR #35 v26 allows for five-letter (MMMMM) or even six-letter (EEEEEE) forms of some of the fields, but TranslateFromUnicodeFormat() asserts in these situations. Fix it to fall back to short forms for MMMMM and EEEEEE that are used in practice e.g. on OS X if the user has custom formatting settings. Consulting the table of sensible specifiers from http://userguide.icu-project.org/formatparse/datetime, it appears these two were the only omissions in this function.

2015-01-29 13:25 VZ, revision 78421

Reset wxUSE_LIBNOTIFY if libnotify not detected in configure. This avoids WARNING: libnotify not found, wxNotificationMessage will use generic implementation. followed by Which GUI toolkit should wxWidgets use? GTK+ 2 with support for libnotify at the end.

2015-01-27 12:51 VZ, revision 78420

Fix wxEVT_TREE_STATE_IMAGE_CLICK generation in wxMSW wxTreeCtrl. Use GET_{X,Y}_LPARAM() to extract them from the event position, which handle negative coordinates (and coordinates can perfectly well be negative when using multiple displays) correctly, unlike {LO,HI}WORD(). Closes #16812.

2015-01-27 12:49 VZ, revision 78419

Fix wxEVT_TREE_STATE_IMAGE_CLICK generation in wxMSW wxTreeCtrl. Use GET_{X,Y}_LPARAM() to extract them from the event position, which handle negative coordinates (and coordinates can perfectly well be negative when using multiple displays) correctly, unlike {LO,HI}WORD(). Closes #16812.

2015-01-27 12:03 VZ, revision 78418

Improve wxThread::SetPriority() comment and documentation. Don't claim that SetPriority() can only be called before the thread is created, this is just wrong. Do document that it must be done after creating the thread in wxMSW (this is a limitation of this port as POSIX implementation allows calling it at any moment and could be lifted in the future). Closes #16809.

2015-01-26 16:10 VZ, revision 78417

Don't leave too much blank space in wxDatePickerCtrl under XP. In our efforts to account for the longest possible string we made the control too wide by default which didn't look very good, so reduce the amount of space added to it, this still seems to be (just) enough for all the reasonable date formats (tested under Windows XP SP3 with default DPI).

2015-01-24 23:09 VZ, revision 78416

Clarify wxExpectModal<> use and implementation. The only change in this commit is the omission of the primary wxExpectModal<> template as it's not needed and it's enough to just forward declare it, otherwise the changes are to the comments only and try to better explain how this class should be used, i.e. that it's not required, although it may be convenient, to specialize it, and also how it is implemented, notably the need for the CRTP in wxExpectModalBase<>.

2015-01-24 23:09 VZ, revision 78415

Use C++ RTTI in dialog testing code if wxRTTI is not available. This allows to get the best possible description of the dialog: if its class uses wxRTTI macros, its user-readable name will be used, but otherwise we now fall back on possibly unreadable but still informative mangled C++ class name rather than showing just "wxDialog" which is not useful at all.

2015-01-24 23:08 VZ, revision 78414

Cosmetic change to wxTestingModalHook error message. Don't include the word "dialog" in it, by default the description is just the class name and so typically already includes "dialog" in it, e.g. we could have "Expected wxFileDialog dialog" which was redundant.

2015-01-24 23:08 VZ, revision 78413

Provide better description of the expected message boxes. While the example in the previous commit message, with two identical expectations, still requires a custom description to be have unambiguous failure messages, in other cases it's enough to show the expected message box buttons in the error to make it possible to immediately see which expectation failed, so include the information deduced from the expected button into the description.

2015-01-24 23:08 VZ, revision 78412

Allow providing descriptions for dialog tests expectations. This makes test failure errors much more intelligible, e.g. in the following case ... some code ... wxTEST_DIALOG(wxYield, wxExpectModal<wxMessageDialog>(wxID_OK)); ... some more code ... wxTEST_DIALOG(wxYield, wxExpectModal<wxMessageDialog>(wxID_OK)); it was previously impossible to distinguish the first test failure from the second one from just the failure description (it could be done by looking at the line numbers since the recent change however), but with ... wxTEST_DIALOG(wxYield, wxExpectModal<wxMessageDialog>(wxID_OK). Describe("first warning message box")); ... wxTEST_DIALOG(wxYield, wxExpectModal<wxMessageDialog>(wxID_OK). Describe("successful completion message box")); the failure becomes immediately clear.

2015-01-24 23:08 VZ, revision 78411

Allow predefining wxTEST_DIALOG_HOOK_CLASS before wx/testing.h inclusion. Although it already was (and remains) possible to #undef and re-#define wxTEST_DIALOG_HOOK_CLASS after including wx/testing.h, it should also be possible to just define it globally in the testing code before including anything else and not have to bother with the #undef part.

2015-01-24 23:08 VZ, revision 78410

Improve error reporting from wxTEST_DIALOG() macro. Give the location (i.e. file name, line number and the name of the function) at which this macro itself appears instead of the location of ReportFailure() method inside wxTestingModalHook which was quite useless as it was the same for all the tests.

2015-01-24 23:08 VZ, revision 78409

Add wxASSERT_MSG_AT() and wxFAIL_MSG_AT() macros. These macros are useful for functions called from other macros to allow pretending that an assert inside such function actually happens at the point in the sources where the macro itself appears.

2015-01-24 23:08 VZ, revision 78408

Define wxTrap() as a macro for gcc on Intel platforms too. It is more convenient to break into the debugger at the exact location of the assert instead of inside a nested wxTrap() function. This does the same thing for gcc/x86 as was done for MSVC in r73124. See #11184.

2015-01-24 23:08 VZ, revision 78407

Fix typo in a comment for NewCloseButton(). s/common/current/

2015-01-24 16:00 VS, revision 78406

Allow disabling SetProcessDPIAware() call Add Windows-specific wxMSWDisableSettingHighDPIAware() function then can be called before startup (i.e. wxEntry() call) to disable wxWidgets' handling of DPI awareness. This is useful for code embedded in non-wx applications as well as for purely wx application that are not HiDPI-ready (although the latter has the option of forcing dpiAware=false in the manifest). See also https://groups.google.com/d/msg/wx-dev/Z0VpgzCY34U/f1FfPqGDppMJ and #16116.

2015-01-22 18:32 AW, revision 78405

Use constant variables to store cached constants in wxPGGlobalVarsClass.

2015-01-22 17:24 VZ, revision 78404

Remove accidentally left over wxLogMessage() from wxGTK wxWebViewWebKit. This resulted in a message box being shown each time Find() was called and was clearly undesirable. Closes #16801.

2015-01-21 18:28 AW, revision 78403

Use polymorphism to differentiate behaviour of wxEnumProperty and wxEditEnumProperty. Override OnSetValue(), StringToValue(), ValidateValue() methods instead of using RTTI in conditional statements to check if wxEditEnumProperty object is actually handled.

2015-01-21 18:14 AW, revision 78402

Refactor propgrid sample (rounding numbers). Use wxRound function to round floating point numbers.

2015-01-21 18:11 AW, revision 78401

Refactor propgrid sample (attribute constants). Use attribute constants instead of strings when calling wxPGProperty::SetProperty and wxPGProperty::GetProperty in propgrid samples.

2015-01-21 18:06 AW, revision 78400

Refactor property attribute names in wxPGProperty::GetAttribute calls. Use attribute constants instead of strings in wxPGProperty and wxPGDefaultRenderer classes and in NumericValidation() function.

2015-01-21 17:59 AW, revision 78399

Refactor wxPGSpinCtrlEditor. Declare and use attribute constant instead of explicit string "MotionSpin".

2015-01-21 15:31 JS, revision 78398

Remove selection before container is deleted or it could cause a crash later.

2015-01-21 15:31 JS, revision 78397

Remove selection before container is deleted or it could cause a crash later.

2015-01-20 16:26 VS, revision 78396

Use wxNB_MULTILINE in wxPreferencesEditor The size of the dialog in wxPreferencesEditor's generic implementation is determined from notebook pages alone and doesn't account for label size, which may be significantly longer in some languages (German, Danish). If the labels don't fit into the window, some of the tabs are hidden behind scroll buttons that are easy to overlook. Improve usability by using wxNB_MULTILINE, which will use multiple rows of tabs in this situation. This is what e.g. Internet Explorer does in its preferences as well.

2015-01-20 16:26 VS, revision 78395

Use wxNB_MULTILINE in wxPreferencesEditor The size of the dialog in wxPreferencesEditor's generic implementation is determined from notebook pages alone and doesn't account for label size, which may be significantly longer in some languages (German, Danish). If the labels don't fit into the window, some of the tabs are hidden behind scroll buttons that are easy to overlook. Improve usability by using wxNB_MULTILINE, which will use multiple rows of tabs in this situation. This is what e.g. Internet Explorer does in its preferences as well.

2015-01-20 16:01 TIK, revision 78394

Fix memory leak introduced in r78183: wxMenuItemBase::SetAccel does not take ownership of the passed pointer nor keeps it for later use.

2015-01-20 16:00 TIK, revision 78393

Fix memory leak introduced in r78179: wxMenuItemBase::SetAccel does not take ownership of the passed pointer nor keeps it for later use.

2015-01-19 21:19 AW, revision 78392

Function wxPGProperty::HasFlag should return Boolean value.

2015-01-19 20:58 AW, revision 78391

Implement deprecated wxPGProperty::GetValueString function only in wxPG 1.4 compatibility mode. This function was marked as deprecated in 2008.

2015-01-19 18:22 AW, revision 78390

Fix a hack implemented in wxEnumProperty::ValueFromString_ and wxEnumProperty::ValueFromInt_ functions. wxEnumProperty code is refactored in order to fix a hack which purpose was (apparently) to bypass constness of these functions by caching determined indices in wxEnumProperty::ms_nextIndex static member variable for further processing. (Unclear concept of using this static member was referred in http://trac.wxwidgets.org/ticket/12779#comment:9) Now, determined index is returned to the caller and processed there if necessary and hence caching of this index is not necessary.

2015-01-19 13:18 VZ, revision 78389

Use logical operations instead of bit-wise ones for booleans. wxUniv "Windows" theme code wrongly used bitwise operations on boolean values, fix this. Closes #16796.

2015-01-19 04:05 MAR, revision 78388

remove wxMISSING_IMPLEMENTATION because wxQtDCImpl::DoBlit is implemented Thanks @seandepagnier

2015-01-19 04:03 MAR, revision 78387

Fix problem with scrollbar events in wxQT the local variable event shadowed the parameter which caused the incorrect value to be sent Thanks @seandepagnier

2015-01-19 04:02 MAR, revision 78386

Fix crash from possible NULL pointer in wxQT list ctrl Thanks @seandepagnier

2015-01-19 04:01 MAR, revision 78385

Fix problem with clipping region in wxqt. QPainter cannot set the clipping region when it is not active. Thanks @seandepagnier

2015-01-19 03:57 MAR, revision 78384

wxQT: move destroyed debug log into class method (remove global function to handle destroyed signal) This is needed for applications because the global function is not exported, yet it is used by the opengl library. An alternative is to add utils.cpp to the opengl library Thanks @seandepagnier

2015-01-19 03:44 MAR, revision 78383

wxQt: Fix compiler error for ambiguous call (when compiling without unicode support) Thanks @seandepagnier

2015-01-19 03:41 MAR, revision 78382

wxQT: Add guard to wxWindowQt for building without unicode support Thanks @seandepagnier

2015-01-19 03:39 MAR, revision 78381

wxQt: fix performance issue with font comparisons Thanks @seandepagnier

2015-01-19 03:38 MAR, revision 78380

Added wxUSE_XLOCALE ifdef guard to wxTimePickerGenericImp Allow to compile wxQT when configure with --disable-xlocal Thanks @seandepagnier

2015-01-19 03:31 MAR, revision 78379

Fix building for wxQT-android with sockets enabled The bionic library on android does not have gethostbyname_r even though it has gethostbyname_r. The configure script in wxwidgets assumes if it has one it has the other. This change does the right thing for android, but perhaps the script should instead test for both? Thanks @seandepagnier

2015-01-19 03:29 MAR, revision 78378

Fix Select on wxQT DC implementation Need to set the underlying qt painter up with the current pen, brush and font when a new object is selected Thanks @seandepagnier

2015-01-19 03:22 MAR, revision 78377

Specify needed header files more correctly (needed for wxqt-android) Thanks @seandepagnier

2015-01-19 03:18 MAR, revision 78376

Correct wxWindowQt::DoSetSize() for possible NULL member de-reference. Thanks David Register

2015-01-19 02:03 MAR, revision 78375

Remove duplicate declaration in wxRichTextCtrl buffer interface This is needed to compile wxPython Phoenix

2015-01-18 09:06 RD, revision 78374

another test commit, undoing the last one

2015-01-18 08:48 RD, revision 78373

This is just a test commit.

2015-01-16 03:39 VZ, revision 78372

Fix typo in wxSOCKET_NOWAIT_WRITE description in the manual. Don't contradict ourselves. Closes #16779.

2015-01-16 03:39 VZ, revision 78371

Fix checks for WXWIN_COMPATIBILITY_3_0: use #if, not #ifdef. The deprecated methods were always available as WXWIN_COMPATIBILITY_3_0 is always defined, we need to check its value and not its definedness. Closes #16782.

2015-01-13 18:05 JS, revision 78370

Bullet no longer gets the attributes from the first object in the list paragraph, so we can control it via paragraph attributes.

2015-01-13 17:41 AW, revision 78369

Fix using WXWIN_COMPATIBILITY_3_0 in conditional blocks in wxPG code. Check the value of WXWIN_COMPATIBILITY_3_0 instead of checking whether it is defined.

2015-01-12 21:37 AW, revision 78368

Preserve alpha channel flag when rescaling bitmap in wxPGProperty::SetValueImage (when wxUSE_IMAGE == 0). Rescaled bitmap must have the same alpha channel flag as the source bitmap flag in order to be properly displayed.

2015-01-12 21:32 AW, revision 78367

Let system decide about required depth of rescaled bitmap in wxPGProperty::SetValueImage. There is not necessary to fix the color depth - everything is determined internally when converting wxImage to wxBitmap.

2015-01-12 21:29 AW, revision 78366

Sanity check regarding DC in wxPropertyGrid::OnComboItemPaint Ensure that wxDC used by drawing functions in wxPropertyGrid::OnComboItemPaint is valid.

2015-01-12 21:23 AW, revision 78365

Don't attempt to draw element-specific bitmap when drawing wxPGChoices element inside the control field of wxEnumProperty with wxPGComboBox. The only bitmap which can be drawn in the control field is a "general" value bitmap (assigned to the property). Closes #16781

2015-01-11 23:49 VZ, revision 78364

Fix selection of items inserted in virtual generic wxDataViewCtrl. Call wxSelectionStore::OnItemsInserted() explicitly instead of just using our UpdateCount() to update the count of items managed by the selection. This needs to be done to ensure that the newly added items have the correction selection, i.e. are always unselected, as previously this wasn't the case: if wxSelectionStore was in the "selected by default" state as it happened e.g. after selecting all the items in the control, the new items also ended up being selected.

2015-01-11 23:49 VZ, revision 78363

Fix selection in virtual generic wxDataViewCtrl after deleting items. The number of items managed by selection was first decremented by our own UpdateCount() and then, again, by an explicit call to wxSelectionStore:: OnItemDelete(), which resulted in the selection ending up in an invalid state. Fix this by not calling UpdateCount(), and hence wxSelectionStore:: SetItemCount(), at all, just OnItemDelete() is enough.

2015-01-10 10:13 SC, revision 78362

removing overridden ProcessIdle, reverting that part of r75289

2015-01-09 04:30 VZ, revision 78361

Send deactivation events to MDI children frame in wxMSW too. For some reason, the code only forwarded activation events to the current MDI child, but not the deactivation ones. And even though this was literally always the case (the check for the event being the activation one is there since r9), it is clearly wrong as the focus restoring code in wxTopLevelWindow in wxMSW doesn't work if the focus hadn't been previously saved. This fix hopefully completes the changes started by r78340 and r78341 and ensures that the focus is always properly restored to the last focused window inside an MDI child.

2015-01-09 04:30 VZ, revision 78360

No changes, just fix a slightly misleading comment in wxMSW focus code. DefWindowProc() never preserves the focused window actually, whether we use WM_NEXTDLGCTL (which is only handled by DefDlgProc() anyhow) or not.

2015-01-09 04:30 VZ, revision 78359

Make specifying minimal size for "unknown" XRC controls work. At least since the changes of r44456 (see #8378), minimal size specified in the XRC for unknown controls didn't have any effect as it was set on wxUnknownControlContainer itself and was overridden by the subsequent call to SetSizerAndFit() which reset the minimal size to the best size of the control contained in it, meaning that it was impossible to make this contained control bigger by specifying min size greater than its best size in the XRC. Fix this by honouring both the min size of the container and of the control contained in it (and do the same thing for the max size for good measure). To avoid not totally obvious interaction of overriding GetMinSize() and DoGetBestClientSize() with sizer code, also position the child control manually instead of using a sizer for it, it's an overkill for such a simple case anyhow.

2015-01-09 04:30 VZ, revision 78358

Make generic wxDataViewCtrl initially usable from keyboard. This control doesn't react to the keyboard at all if it doesn't have a current row and as it doesn't have it initially, it means that there is no way to do anything with the control without clicking it with the mouse first. Fix this by giving it a current row, if possible, whenever it gains focus.

2015-01-09 04:29 VZ, revision 78357

Always invalidate wxStaticText best size after changing its label. wxST_NO_AUTORESIZE style only affects whether the control is actually resized when its text changes, but its best size should always change, so that if the window containing it is explicitly relaid out the size does change. Moreover, in wxMSW and wxOSX the best size was never invalidated at all when the label was ellipsized, so it was never updated for them, preventing, for example, comparing the best size with the current one to check if the text is effectively ellipsized (and so needs to be shown in a tooltip, for example). Fix this by calling InvalidateBestSize() unconditionally, this should make these ports behave in the same was as wxGTK already did.

2015-01-08 15:11 VZ, revision 78356

only flush a client dc if it was not inheriting the native CGContextRef from an outside paint context, fixes #16334

2015-01-06 21:20 VZ, revision 78355

Fix wxBitmap conversion to wxImage in 64-bit wxOSX builds. Don't assume that sizeof(long) == 4, this is just wrong. Closes #16770.

2015-01-06 21:08 VZ, revision 78354

Fix wxBitmap conversion to wxImage in 64-bit wxOSX builds. Don't assume that sizeof(long) == 4, this is just wrong. Closes #16770.

2015-01-06 08:12 MAR, revision 78353

Added new ctor for wxBitmap using wxCursor for wxQT (similar to wxGTK) This is the implementation that should had been included in r78348

2015-01-05 13:49 TIK, revision 78350

On wxMac, modal event loops avoid deleting pending objects. Hide the text control after editing a label in the generic tree control so it does not remain visible e.g. if the tree control is used in a dialog.

2015-01-05 13:48 TIK, revision 78349

On wxMac, modal event loops avoid deleting pending events. Hide the text control after editing a label in the generic tree control so it does not remain visible e.g. if the tree control is used in a dialog.

2015-01-04 04:51 MAR, revision 78348

Added new ctor for wxBitmap using wxCursor for wxQT (similar to wxGTK)

2015-01-04 03:49 MAR, revision 78347

Added missing ctor for wxBitmap using wxIcon for wxQT (taken from wxOSX)

2015-01-03 21:45 VZ, revision 78346

Fix wxFileDialog::GetFilterIndex() when opening files in wxOSX. Update m_filterIndex in the "opening" case, just as we already did in the "saving" one (see #13158 and r67550). Closes #16764.

2015-01-03 21:45 VZ, revision 78345

Fix wxFileDialog::GetFilterIndex() when opening files in wxOSX. Update m_filterIndex in the "opening" case, just as we already did in the "saving" one (see #13158 and r67550). Closes #16764.

2015-01-03 16:20 AW, revision 78344

Optimize wxPGChoices::Add methods. Remove unnecessary variables, limit the scope of variables and implement some sanity checks.

2015-01-03 16:10 AW, revision 78343

Optimize wxPGChoices::Set method. There is no need to check if referenced array with values is valid since "reference cannot be bound to dereferenced null pointer in well-defined C++ code". Moreover, conditional call of Add() methods(one with explicit parameter and one with default one) is not necessary.

2015-01-03 14:33 VZ, revision 78342

Fix the size of the "new" bitmap in the toolbar sample. It was broken by the changes of r78238 and was too small for the height in the header, resulting in an immediate crash on toolbar sample startup.

2015-01-03 02:07 VZ, revision 78341

Don't change MDI children order after showing a file dialog in wxMSW. Don't use the generic focus saving/restoring code for wxMDIParentFrame in wxMSW as it already saves and restores the active MDI child on its own and we should let it do it, as our code could change the active child when restoring focus if it hadn't been saved correctly previously. The fact that it is isn't saved is another bug, but even if it is fixed, we should let MSW MDI implementation handle activation as we can't do it any better -- but can do worse, as the bug described in #16635 shows. Closes #16635.

2015-01-03 02:07 VZ, revision 78340

Fix saving focus for MDI child frames in wxMSW. Use wxWindow::IsDescendant() instead of wxGetTopLevelParent() to determine whether the focused window is inside the TLW, as the former works correctly for any window, including wxMDIChildFrames, while the latter would return wxMDIParentFrame for them (as MDI children are not considered to be TLWs) and so saving the focus would always fail and the focus was always restored to the first child of wxMDIChildFrame after switching from it to another child frame and back, as could be seen by applying the simple patch: ---------------------------------- >8 -------------------------------------- diff --git a/samples/docview/view.cpp b/samples/docview/view.cpp index 9f20032..8386522 100644 --- a/samples/docview/view.cpp +++ b/samples/docview/view.cpp @@ -160,8 +160,9 @@ bool TextEditView::OnCreate(wxDocument *doc, long flags) wxFrame* frame = wxGetApp().CreateChildFrame(this, false); wxASSERT(frame == GetFrame()); m_text = new wxTextCtrl(frame, wxID_ANY, "", - wxDefaultPosition, wxDefaultSize, + wxPoint(5, 5), wxDefaultSize, wxTE_MULTILINE); + new wxButton(frame, wxID_ANY, "Button", wxPoint(5, 100)); frame->Show(); return true; ---------------------------------- >8 -------------------------------------- Notice that the bug usually stayed hidden because it didn't happen if wxMDIChildFrame contained a wxPanel (which also stores the last focus) inside it or if the focus switched away from the entire application instead of just going to another child and back, as in this case the last focus was stored in wxMDIParentFrame, for which the old code did work.

2015-01-03 02:07 VZ, revision 78339

Add include/wx/richtext/richtexttabspage.h to the MSBuild project. This seems like an occidental omission.

2015-01-03 02:07 VZ, revision 78338

Remove files not being compiled from richtext MSBuild project. Several sources in this project are actually not compiled at all, but are included from other files, so they don't appear in the master sources list. Update the project accordingly, for consistency with the earlier versions of MSVC. If these files should appear in it, they need to be added to RICHTEXT_HDR variable.

2015-01-03 02:07 VZ, revision 78337

Add appprogress.{h,cpp} to the files list. The wxMSW header was absent from both the bakefile and master file list, and the latter also lacked the other wxAppProgressIndicator-related files. Also regenerate the project file to contain the MSW header.

2015-01-03 02:07 VZ, revision 78336

No changes, just sort files alphabetically in the bakefiles files list. Keep MSW_SRC files list sorted, appprogress.cpp was added in a wrong place.

2015-01-03 00:49 VZ, revision 78334

2015-01-02 17:15 AW, revision 78333

Delete wxDC object when exiting from wxPropertyGrid::OnPaint

2015-01-02 15:26 VZ, revision 78332

Improve widgets sample UI consistency. Ensure that the various attributes (colours, font, border, ...) are preserved when a widget is recreated or the current page is changed. This is more convenient and also avoids discrepancies between the state of the menu items and the actual state of the widget. Closes #16576.

2015-01-01 00:36 RD, revision 78331

a commit to test Trac/SVN integration. Closes #16754

2014-12-31 23:25 RD, revision 78330

just another test commit

2014-12-31 23:20 RD, revision 78329

just a test commit

2014-12-28 21:06 AW, revision 78328

Pass outside wxPG a modified clone of wxEVT_TEXT event instead of hacking current event object. Using a clone of event (with PG id) instead of replacing id in the currently processed event coming from wxPGTextCtrlEditor seems to be less intrusive and safer action.

2014-12-27 15:24 VZ, revision 78327

Fix reading of not NUL-terminated strings using wxRegKey. Even though this is typically the case, some strings in Windows registry are not NUL-terminated, deal with them correctly by using the explicit length. Closes #16719.

2014-12-27 15:24 VZ, revision 78326

Revert "Add support for reading multi string values to wxRegKey." Reverts r78136 (see #15727) because the multi-string values in Windows registry are actually not "name=value" pairs at all but just NUL-separated strings and the API provided for reading them was inappropriate. Also see #16719.

2014-12-27 15:24 VZ, revision 78325

Fix flickering when resizing a frame with status bar in wxMSW. The flicker was only visible under Windows XP or when using a class theme and was due to mis-positioning the status bar initially in PositionStatusBar(). Fix this by adjusting its position by the toolbar offset before calling its SetSize(). Closes #16705.

2014-12-27 15:24 VZ, revision 78324

Make disabling submenus work in wxMSW. As submenu items don't have a valid ID, we need to address them by their position when calling EnableMenuItem() -- and for simplicity do it for all the items. Closes #16747.

2014-12-27 15:17 VZ, revision 78323

Make disabling submenus work in wxMSW. As submenu items don't have a valid ID, we need to address them by their position when calling EnableMenuItem() -- and for simplicity do it for all the items. Closes #16747.

2014-12-27 15:17 VZ, revision 78322

Fix handling of fast clicks in wxRibbonBar under MSW. Second click can result in a double click event instead of the usual simple click if it happens quickly enough after the first one, so handle double clicks in the same way as simple clicks instead of ignoring them. Closes #16551.

2014-12-27 12:30 AW, revision 78321

Do not actually reconnect PG event handlers when attempting to reconnect them to the same window. When in wxPropertyGridManager::ReconnectEventHandlers() new window ID is the same as old window ID then there is no need to do anything with handlers. An assertion warning is displayed in this case to notify about this unusual (and maybe unintended) situation.

2014-12-25 02:32 VZ, revision 78320

Fix removing tools from wxToolBar in wxOSX. Release the tool instead of retaining it (typo?) and also remove it from the toolbar view. See #16663.

2014-12-25 02:32 VZ, revision 78319

Don't overflow the message queue in wxEventLoop::WakeUp() in wxOSX. First, don't add any events at all to it unless it's empty. Second, post new events with low priority instead of high one, we really don't care about them getting processed, other, real, events should take priority. Closes #14256.

2014-12-25 02:32 VZ, revision 78318

Blind fix for wxTextDataObject trailing NUL under OS X. Use the length provided to SetData() instead of assuming it is NUL-terminated. Closes #9522.

2014-12-25 02:32 VZ, revision 78317

Generate wxEVT_DATAVIEW_ITEM_ACTIVATED on Enter in wxOSX wxDVC. Allow activating wxDataViewCtrl items from keyboard under OS X. Closes #16272.

2014-12-25 02:32 VZ, revision 78316

Allow setting hints for multi-line wxTextCtrl when supported. Don't prevent people from using hints in wxMSW and wxGTK2, where they work with multiline text controls too, even though they do not work with wxGTK3 nor wxOSX. Closes #14456.

2014-12-25 02:31 VZ, revision 78315

Add support for strikeout fonts to wxMSW wxTextCtrl. Map them to CFE_STRIKEOUT in the native rich text control. See #16591.

2014-12-25 02:31 VZ, revision 78314

Fix handling of fast clicks in wxRibbonBar under MSW. Second click can result in a double click event instead of the usual simple click if it happens quickly enough after the first one, so handle double clicks in the same way as simple clicks instead of ignoring them. Closes #16551.

2014-12-24 21:02 MAR, revision 78313

Match the wxQT wxColour with public interface Now the type of the value returned by Red, Green, Blue and Alpha methods are consistent with wxGTK and wxMSW. This could fix ticket #16713 (symbols exported)

2014-12-24 20:19 MAR, revision 78312

Fix SIGSEGV due bad pointer in wxMessageDialog (wxQT) m_qtWindow should be used instead of m_qtMessageBox (removed). If not, PostCreation() cannot call wxMessageDialog::GetHandle() as it is virtual (and it is called from the ctor), so it fails to set the base window pointer, raising a SIGSEGV in wxWindow::DoSetSize (for more info, see architecture in docs)

2014-12-24 14:57 VZ, revision 78311

Fix some typos in the comments and messages in the samples. Closes #16738.

2014-12-24 14:57 VZ, revision 78310

Update dialog editors list in the manual. Remove wxDesigner which is not offered any more and add wxCrafter. Also use more neutral "form designer" term to avoid giving the impression that these tools can only be used for the dialogs. Closes #16744.

2014-12-24 14:57 VZ, revision 78309

Add brief documentation for wxLog::Flush(). See #16744.

2014-12-24 14:57 VZ, revision 78308

Escape space after "e.g." or "i.e." in the manual. This fixes formatting of the Doxygen-generated docs (maybe we should just switch to the civilized spelling of "eg" and "ie" instead?). See #16744.

2014-12-24 14:56 VZ, revision 78307

Correct minor typo in wxMimeTypesManager documentation. See #16744.

2014-12-24 14:56 VZ, revision 78306

Correct typo in wxStopWatch example in the documentation. See #16744.

2014-12-24 14:56 VZ, revision 78305

Czech translations update from Zbyn?k Schwarz.

2014-12-23 10:50 VZ, revision 78303

Use Cmd-click, not Apply-click, to select items in wxVListBox. Using Apple key here under Mac was unexpected, we should use Cmd which corresponds to Ctrl used under the other platforms and which is already mapped to it by wxKeyboardState::ControlDown().

2014-12-22 02:31 VZ, revision 78297

Don't try setting width before column is added to wxOSX wxDVC. This is not going to work anyhow and the width will be really set later, when InsertColumn() is called.

2014-12-22 02:31 VZ, revision 78296

Don't warn if model cell value is empty in wxOSX wxDVC. This follows similar change to wxGTK a few commits ago and makes wxOSX consistent with the generic version.

2014-12-22 02:31 VZ, revision 78295

Refactor type checks in wxOSX wxDVC implementation. Check the type in one place only, before calling MacRender() instead of doing it in each and every implementation of it. Also replace wxFAIL_MSG() with wxLogDebug() as the former resulted in a crash due to assert reentrancy, as usual when asserting inside a wxEVT_PAINT handler which is constantly called all the time, and so wasn't particularly useful.

2014-12-22 02:31 VZ, revision 78294

Remove unnecessary methods of wxCocoaOutlineDataSource. {append,remove}Child() were never used, remove them to make it easier to remove the use of "children" array itself later (see #16740).

2014-12-22 02:31 VZ, revision 78293

Don't warn if model cell value is empty in wxGTK wxDVC. Make wxGTK consistent with the generic version and, generally speaking, more reasonable by allowing to leave any cell empty by just not filling in the wxVariant in the model GetValue() for it.

2014-12-22 02:31 VZ, revision 78292

Replace wxLogError() with wxLogDebug() in wxGTK wxDVC code. The type mismatch between the value returned from the model and the one returned by the control cannot be due to any user action, so it is quite useless to show it to the user, it is only relevant for the developers. Use wxLogDebug() and not wxASSERT() because asserting in a wxEVT_PAINT callback would result in a crash due assert reentrancies.

2014-12-22 02:31 VZ, revision 78291

Fix arguments of type mismatch error message in wxGTK wxDVC. The "required" and "actual" arguments were exchanged, making the message pretty confusing.

2014-12-20 22:52 VZ, revision 78290

Centre text vertically in wxDataViewCtrl by default in generic version. This was already the case in the native GTK (possibly unintentionally) and OS X (because vertical alignment is not supported at all there) versions, but in the generic version using the default wxALIGN_NOT alignment when calling wxDataViewCtrl::AppendXXXColumn() methods resulted in top-aligned text which looked ugly (this could be seen on the second page of the dataview sample for example). Fix this by handling wxALIGN_NOT as wxDVR_DEFAULT_ALIGNMENT in these functions to do the right thing by default.

2014-12-20 22:51 VZ, revision 78289

Use helper functions for {app,prep}ending wxDataViewCtrl columns. Make the code more maintainable by using helper functions instead of duplicating the same logic a dozen times for each of appending and prepending. This is just a refactoring, no changes in behaviour.

2014-12-20 22:51 VZ, revision 78288

Add GetDefaultType() to all standard wxDataViewRenderer-derived classes. This makes it possible to refer to the associated wxVariant types without hard coding the string constants, i.e. instead of writing "string" (error prone as typos are not detected) it is now possible to write wxDataViewTextRenderer:: GetDefaultType(). This will also make it simpler to write generic (in C++ templates sense) code using renderers.

2014-12-20 22:51 VZ, revision 78287

Undo the change of the number of items in dataview sample. Increasing it to 10000000 in r77905 brought both the native GTK (see #16741) and OSX (see #16740) wxDataViewCtrl implementation to their knees, so don't do this. This is, of course, just hiding the real bug, but still better than not allowing people to run the sample at all.

2014-12-20 22:51 VZ, revision 78286

Suppress unused parameter warning in wxRichTextCtrl code. The entire event handler should arguably be removed entirely if it's unused, but for now just avoid the warning.

2014-12-20 11:15 TIK, revision 78285

Add Windows 10 support to wxGetOsDescription(). Map Windows 10 to wxWinVersion_8 in wxGetWinVersion() to not change ABI.

2014-12-20 11:13 TIK, revision 78284

Add Windows 10 support to wxGetWinVersion() and wxGetOsDescription().

2014-12-19 16:56 VZ, revision 78283

Remove assert about unsupported wxMOD_ALTGR in wxUIActionSimulator. wxMOD_ALTGR is wxMOD_ALT + wxMOD_CONTROL and so is, actually, supported as simulating it involves only simulating both Alt and Control being pressed, at least under MSW.

2014-12-19 16:56 VZ, revision 78282

Destroy all views associated to wxDocument being forcefully closed. Forcefully closing a modified document misbehaved in several ways: first, the question about whether the document should be saved was asked twice if the first message box was cancelled. Second, DeleteAllViews() didn't actually delete the views if the second message box was cancelled as well -- so the views could be left alive while their associated document was destroyed, resulting in more or less guaranteed crash (e.g. during the next event handling as wxDocChildFrameAnyBase::TryProcessEvent() assumes that m_childDocument is still alive if m_childView is). Fix both problems by really forcing the document to close by pretending that it is not modified. We still ask the user once though, as it could be useful to be able to save the document even when it will be closed. Ideally, the message box shown in this case shouldn't have a "Cancel" button at all, but this is left for the future.

2014-12-17 18:44 PC, revision 78281

guard functions with wxCHECK_* macros rather than wxASSERT_*

2014-12-17 17:04 JS, revision 78280

Added shadows to box attributes, and relevant controls in the Background page.

2014-12-16 21:16 VZ, revision 78279

Fix inserting tools removed from wxToolBar back into it in wxMSW. Make sure to reset the "to be deleted" flag we set on the tool when removing it from the toolbar to avoid layout problems if the tool is added back later. Closes #16735.

2014-12-16 21:16 VZ, revision 78278

Move wxRendererMSW::DrawTextCtrl() implementation to wxRendererGeneric. This ensures that wxRendererGeneric::DrawGauge() is actually usable as otherwise calling it always resulted in an assertion failure because it used DrawTextCtrl() which was not implemented in wxRendererGeneric. So this fixes using DrawGauge() in non-MSW ports which was added by r77023 (see #16406) but apparently never worked. Also remove wxRendererMSW::DrawGauge() as it's exactly the same as the version inherited from wxRendererGeneric. Closes #16725.

2014-12-16 21:16 VZ, revision 78277

Remove unnecessary wxUSE_MFC option. This didn't do (almost) anything, so just remove it, using MFC and wxWidgets together works just fine without it.

2014-12-16 21:15 VZ, revision 78276

No real changes, just fix some typos in comments in the samples. Closes #16734 (for 3.0).

2014-12-16 21:15 VZ, revision 78275

Fix inserting tools removed from wxToolBar back into it in wxMSW. Make sure to reset the "to be deleted" flag we set on the tool when removing it from the toolbar to avoid layout problems if the tool is added back later. Closes #16735 (for 3.0).

2014-12-16 14:59 VZ, revision 78274

Add wxEVT_MAGNIFY mouse event. Currently this is implemented for wxOSX only. Closes #14322.

2014-12-16 14:51 VZ, revision 78273

No real changes, just fix some typos in comments in the samples. Closes #16734.

2014-12-16 14:49 VZ, revision 78272

Fix building with -std=gnu++11 -stdlib=libstdc++ under OS X. Take into account the possibility of using C++11 compiler with non-C++11 standard library as this may happen when targeting OS X < 10.7, in which case C++11 libc++ can't be used. Closes #16730.

2014-12-14 12:12 SN, revision 78271

No real changes, just fixed a couple of typos in comments, fixes #16726.

2014-12-13 18:40 PC, revision 78270

Allow setting icon before m_widget is valid. There is no need to require a valid m_widget, the "realize" handler will take care of things later. Closes #16731

2014-12-12 23:58 AW, revision 78269

Remove unused member variable from wxSimpleCheckBox (used in wxPGCheckBoxEditor).

2014-12-12 23:56 AW, revision 78268

Fix typo in a comment

2014-12-12 23:40 AW, revision 78267

Create wxPropertyGridManager with default size in the propgrid sample Since r78150 wxPropertyGridManager can be created with default size with no issues.

2014-12-12 23:36 AW, revision 78266

Use wxBufferedPaintDC to implement double buffering in wxPG. This also fixes drawing the PG when buffer is not available and there is necessary do draw directly on window DC. wxPropertyGrid::DrawItems method is simplified and wxPropertyGrid::DoDrawItems method is reimplemented since its 3-rd argument (isBuffered) is unneeded anymore.

2014-12-11 21:31 TIK, revision 78265

In wxMBConvStrictUTF8::ToWChar the length of a multibyte UTF-8 sequence is obtained from a table, with the leading byte as offset. Later in that function, the prefix of the leading byte is compared against the expected prefix for the given length. Unless the table is faulty, this comparison can never fail. It is thus redundant and not needed. As optimizing compilers aren't smart enough yet to detect this, this commit removes the redundant check.

2014-12-11 21:31 TIK, revision 78264

In wxMBConvStrictUTF8::ToWChar the length of a multibyte UTF-8 sequence is obtained from a table, with the leading byte as offset. Later in that function, the prefix of the leading byte is compared against the expected prefix for the given length. Unless the table is faulty, this comparison can never fail. It is thus redundant and not needed. As optimizing compilers aren't smart enough yet to detect this, this commit removes the redundant check.