Changelogs

Overview

These changelogs reflect the history of all files in the Subversion repository. The changelog has been generated at 2014-04-18 11:00:03

Select Changelog:

FileZilla 3, FileZilla,
FileZilla Server, wxWidgets

Changes per page:

25 50 100 250 500 1000 2000

Changelog for wxWidgets (68404 changes):

2014-04-18 04:30 PC, revision 76367

fix building or running on GTK < 2.14 after r76365

2014-04-18 04:28 PC, revision 76366

remove wxOVERRIDE, forgot that it's trunk only

2014-04-17 19:36 PC, revision 76365

Add a separate GTK-specific wxDisplay implementation. This separates the GTK implementation from Unix/X11, except for the wxVideoMode stuff, and _NET_WORKAREA when GTK < 3.4. wxDisplay and wxClientDisplayRect() should now work as well as they can with Wayland.

2014-04-17 18:15 PC, revision 76364

allow using wxEventLoopGuarantor when wxUSE_GUI==1 fixes wxOSX-Cocoa build when wxUSE_CONSOLE_EVENTLOOP==0 closes #14980

2014-04-17 17:21 PC, revision 76363

use correct signature for callback

2014-04-17 08:22 PC, revision 76362

use a prefix match for interactive search having to type in the whole string to get a match is worthless

2014-04-17 08:09 PC, revision 76361

Avoid assertion failure when GtkTreeView interactive search is started. The treeview does an unselect_all causing a "changed" signal with no selection. The problem is easily triggered by pressing Ctrl-F (the "start-interactive-search" key binding)

2014-04-16 18:41 VS, revision 76359

Initialize wxFileDialog::m_filter{Panel,Choice} in ctor.

2014-04-16 18:41 VS, revision 76358

Initialize wxFileDialog::m_filter{Panel,Choice} in ctor.

2014-04-15 19:39 PC, revision 76354

remove extraneous semicolons

2014-04-15 19:23 PC, revision 76353

don't use Cairo functions when wxUSE_CAIRO==0

2014-04-15 18:16 PC, revision 76352

wxASSERT(false) --> wxFAIL

2014-04-15 18:16 PC, revision 76351

initialize members in ctor, avoid int-to-bool warnings

2014-04-15 18:16 PC, revision 76350

avoid unused variable warning with wxUSE_VALIDATORS==0

2014-04-15 18:07 PC, revision 76349

use gtk_window_set_opacity() in SetTransparent() when GTK >= 2.12

2014-04-15 17:46 PC, revision 76348

fix wxClientDisplayRect() when wxUSE_DISPLAY==0 GDK_WINDOWING_X11 was not getting defined, causing hard coded size to be used

2014-04-14 05:36 RD, revision 76343

Update how the docset is generated. Use a more human-friendly name, put the files in doxygen/out/docset instead of in html, etc.

2014-04-14 05:36 RD, revision 76342

Avoid possible infinite recursion

2014-04-14 05:36 RD, revision 76341

Add the CellHighlight getters too.

2014-04-14 05:36 RD, revision 76340

Add some missing wxGrid methods

2014-04-14 05:24 RD, revision 76332

Add the CellHighlight getters too.

2014-04-14 05:24 RD, revision 76331

Avoid possible infinite recursion

2014-04-14 05:24 RD, revision 76330

Add some missing wxGrid methods

2014-04-14 05:24 RD, revision 76329

Update how the docset is generated. Use a more human-friendly name, put the files in doxygen/out/docset instead of in html, etc.

2014-04-14 00:07 VZ, revision 76328

Use wxWS_EX_VALIDATE_RECURSIVELY in native Cocoa wxPreferencesEditor too. Transfer data recursively for consistency with the generic implementation and because this generally just makes more sense.

2014-04-14 00:07 VZ, revision 76327

Use wxWS_EX_VALIDATE_RECURSIVELY in native Cocoa wxPreferencesEditor too. Transfer data recursively for consistency with the generic implementation and because this generally just makes more sense.

2014-04-13 02:00 VZ, revision 76326

Disable TextCtrlTestCase::LongText() for non-MSW platforms. At least under GTK SetMaxLength(), tested by this test, can't be used with multiline text controls at all, so running it fails. Keep the test for MSW only where SetMaxLength() works with controls of all kinds.

2014-04-13 00:56 VZ, revision 76325

Add error handling to wxSound under wxOSX. Don't assume that we can open any file as a sound, check for the return value from AudioServicesCreateSystemSoundID().

2014-04-13 00:56 VZ, revision 76324

Don't use timer inside wxSound in wxOSX/Cocoa. The timer is only used by Carbon code, there is no need for it in Cocoa, so don't complicate things by starting it unnecessarily.

2014-04-13 00:56 VZ, revision 76323

Fix crash when playing invalid sounds under wxOSX. Sound ID 0 is not actually invalid, it is returned by AudioServicesCreateSystemSoundID() when it fails to open the file and currently we don't consider this to be an error. However, because we never called AudioServicesDisposeSystemSoundID() for this sound ID, we continued to receive the notifications from the callback registered by AudioServicesAddSystemSoundCompletion() for it even after the corresponding sound object was destroyed, resulting in crashes when playing it more than once. Fix this by keeping a separate flag indicating whether we're playing a sound and always disposing of the sound if we are, even if ID is 0.

2014-04-13 00:56 VZ, revision 76322

Call wxDataViewRenderer::Validate() under OS X too. Ensure that the custom renderers get a chance to validate (and maybe change) the value entered by user, as previously it was completely impossible with the native OS X implementation of wxDataViewCtrl.

2014-04-13 00:54 VZ, revision 76321

Fix crash when playing invalid sounds under wxOSX. Sound ID 0 is not actually invalid, it is returned by AudioServicesCreateSystemSoundID() when it fails to open the file and currently we don't consider this to be an error. However, because we never called AudioServicesDisposeSystemSoundID() for this sound ID, we continued to receive the notifications from the callback registered by AudioServicesAddSystemSoundCompletion() for it even after the corresponding sound object was destroyed, resulting in crashes when playing it more than once. Fix this by keeping a separate flag indicating whether we're playing a sound and always disposing of the sound if we are, even if ID is 0.

2014-04-13 00:54 VZ, revision 76320

Call wxDataViewRenderer::Validate() under OS X too. Ensure that the custom renderers get a chance to validate (and maybe change) the value entered by user, as previously it was completely impossible with the native OS X implementation of wxDataViewCtrl.

2014-04-13 00:54 VZ, revision 76319

Avoid selecting invalid tab when removing last page from wxOSX wxNotebook. Closes #15897 (backport of r75663 from trunk).

2014-04-12 17:42 PC, revision 76318

make validator pointer const

2014-04-12 02:11 VZ, revision 76317

Compilation fix for MinGW in GDI+ code. Don't use the XXXModeInvalid constants which are missing from MinGW headers for some reason.

2014-04-12 02:10 VZ, revision 76316

Use the same wxWeakRef implementation for complete and incomplete classes. This fixes an ODR violation which could arise if wxWeakRef<T> was seen both when T was an incomplete (e.g. just forward-defined) class and when it was complete. As different implementations, with different binary layouts, were used in these two cases, this resulted in fatal run-time problems. Fix this by always using the slightly less efficient (because storing an extra pointer) but simpler and safe "dynamic" wxWeakRef implementation. Also get rid of checks for the ancient compilers such as VC6 and g++ < 3.3, they are not supported any longer. Closes #15884.

2014-04-11 19:49 VZ, revision 76315

Restore correct handling of wxDocument::OnCreate() error return value. The changes of r74515 didn't quite restore the old behaviour, the document was still not being cleaned up if its OnCreate() simply returned false and not threw an exception. Do add cleanup in this code branch too, just duplicating what we in case of exception (this duplication can't be easily avoided unfortunately). This backports changes of r75646 from trunk, see #15883.

2014-04-11 18:04 PC, revision 76314

build fix for wxUSE_VALIDATORS==0 when NULL is defined to be nullptr casting nullptr is not allowed

2014-04-11 17:53 PC, revision 76313

build fix for wxUSE_VALIDATORS==0

2014-04-11 13:48 VZ, revision 76312

Fixes to the previous Nepalese translation update.

2014-04-11 06:48 PC, revision 76311

build fix for wxUSE_TOGGLEBTN==0

2014-04-11 06:48 PC, revision 76310

build fix for wxUSE_DRAG_AND_DROP==0

2014-04-11 06:48 PC, revision 76309

build fix for wxUSE_THREADS==0

2014-04-10 17:57 PC, revision 76308

fix invisible multi-line wxTextCtrl selection when custom foreground/background color is used with GTK3 closes #16176

2014-04-09 06:41 PC, revision 76307

fix invisible wxTextCtrl selection when custom foreground/background color is used with GTK3 closes #16176

2014-04-08 23:38 VZ, revision 76306

Nepalese translations update from Him Prasad Gautam.

2014-04-08 23:38 VZ, revision 76305

Don't set wxINTERPOLATION_GOOD quality by default in wxGDIPlusContext. This is inconsistent with wxOSX and also doesn't play well with the existence of wxINTERPOLATION_DEFAULT which is different from wxINTERPOLATION_GOOD. See #14134.

2014-04-08 23:31 VZ, revision 76304

Document unexpected default wxGraphicsContext interpolation quality. In 3.0, keep wxINTERPOLATION_GOOD as the default value instead of wxINTERPOLATION_DEFAULT for compatibility, but at least mention this and warn about the changes in 3.1. See #14134.

2014-04-08 23:23 VZ, revision 76303

Fix mouse events after calling WarpPointer() under OS X. See #16169.

2014-04-08 11:14 SC, revision 76302

fixes #16169

2014-04-07 22:34 VZ, revision 76301

Remove "default" clause from enums in wxGDIPlusContext code. This will allow the compiler to give us a warning if more elements are added to the enum later but not added to the switch. Also add error checking to Graphics::SetSmoothingMode() call.

2014-04-07 22:34 VZ, revision 76300

Fix mismatch between GDI+ and wxGraphicsContext interpolation quality. Use wxGDIPlusContext own method instead of using GDI+ method directly when setting the interpolation mode in wxGDIPlusContext initialization code to ensure that m_interpolation field matches the real interpolation mode used.

2014-04-07 22:34 VZ, revision 76299

Initialize wxGraphicsContext::m_interpolation field. This member wwas never initialized, resulting in erratic behaviour of SetInterpolationQuality() which compared its parameter with m_interpolation.

2014-04-07 22:29 VZ, revision 76298

Fix mismatch between GDI+ and wxGraphicsContext interpolation quality. Use wxGDIPlusContext own method instead of using GDI+ method directly when setting the interpolation mode in wxGDIPlusContext initialization code to ensure that m_interpolation field matches the real interpolation mode used.

2014-04-07 22:29 VZ, revision 76297

Initialize wxGraphicsContext::m_interpolation field. This member wwas never initialized, resulting in erratic behaviour of SetInterpolationQuality() which compared its parameter with m_interpolation.

2014-04-07 19:16 PC, revision 76296

update comment for wxBG_STYLE_TRANSPARENT

2014-04-07 19:15 PC, revision 76295

fix transparent window example wxBG_STYLE_TRANSPARENT can only be set before window creation. closes #16161

2014-04-07 18:23 JS, revision 76294

Object position calculation correction

2014-04-06 21:33 PC, revision 76293

avoid warnings about double-to-float conversion

2014-04-06 21:30 PC, revision 76292

avoid warning about shadowed variable

2014-04-06 21:28 PC, revision 76291

cast to proper type to avoid warning

2014-04-06 21:27 PC, revision 76290

remove unused macro definition

2014-04-06 21:27 PC, revision 76289

avoid warning about unreachable code

2014-04-05 19:13 PC, revision 76288

avoid double-to-float conversion warnings in headers

2014-04-05 12:44 VZ, revision 76287

Don't use %i format specifier for size_t values. In 64 bit build, size_t can be 64 bits while %i expects a 32 bit value. Fix this by just avoiding the unnecessary use of size_t, the number of entries in the index is not going to be greater than 2^32. Closes #16163.

2014-04-05 12:44 VZ, revision 76286

Fix warning about %lu being used with an int in 32 bit wxOSX build. NSUInteger is unsigned long in 64 bit builds, but unsigned int in 32 bits, so case it to long explicitly to avoid warnings about using it with %lu format specifier.

2014-04-05 12:44 VZ, revision 76285

Don't use %i format specifier for size_t values. In 64 bit build, size_t can be 64 bits while %i expects a 32 bit value. Fix this by just avoiding the unnecessary use of size_t, the number of entries in the index is not going to be greater than 2^32. Closes #16163.

2014-04-05 12:44 VZ, revision 76284

Fix warning about %lu being used with an int in 32 bit wxOSX build. NSUInteger is unsigned long in 64 bit builds, but unsigned int in 32 bits, so case it to long explicitly to avoid warnings about using it with %lu format specifier.

2014-04-04 20:32 VZ, revision 76283

Remove unused variables from wxRichTextListStylePage code. This avoids warnings about them.

2014-04-04 18:55 PC, revision 76282

avoid preprocessor directives inside macro invocation

2014-04-04 18:46 PC, revision 76281

remove unused member functions

2014-04-04 18:44 PC, revision 76280

remove unused macro definitions and limit others to the configurations which use them

2014-04-04 18:00 PC, revision 76279

assertion messages don't need to be translated

2014-04-04 17:56 PC, revision 76278

remove redundant assertion messages, wxLogError has already been called

2014-04-04 17:28 VZ, revision 76277

Add more precise wxRibbonBar::ShowPanels() overload. The existing overload taking bool didn't allow to specify whether the panel should be just expanded or expanded and pinned, add a new one supporting this. Also fix a bug with not updating the ribbon state in the old method. Closes #16133.

2014-04-04 17:28 VZ, revision 76276

Turkish translation update from Hakki Dogusan.

2014-04-04 17:28 VZ, revision 76275

Document wxRibbonDisplayMode enum. See #16133.

2014-04-04 17:28 VZ, revision 76274

Document wxRibbonDisplayMode enum. See #16133.

2014-04-04 17:26 PC, revision 76273

fix typo in size 2530 --> 3530

2014-04-04 17:09 PC, revision 76272

fix some asserts that were clearly meant to be wxFAIL_MSG

2014-04-04 08:45 PC, revision 76271

fix more memory leaks

2014-04-04 08:41 PC, revision 76270

Improve conversion between wxPaperSize and GtkPaperSize Eliminates many "Gtk-WARNING **: Unknown paper size", and the occasional "GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed". And fixes approximately one zillion memory leaks.

2014-04-04 08:36 PC, revision 76269

fix missing semicolon typo

2014-04-04 08:05 PC, revision 76268

Improve conversion between wxPaperSize and GtkPaperSize by using a table to map the screwy Windows DMPAPER_* stuff, which wxWidgets stupidly uses. Eliminates many "Gtk-WARNING **: Unknown paper size", and the occasional "GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed". And fixes approximately one zillion memory leaks.

2014-04-03 15:54 JS, revision 76267

Removed unnecessary list renumbering

2014-04-03 15:53 JS, revision 76266

Removed unnecessary list renumbering

2014-04-03 15:53 JS, revision 76265

Removed unnecessary list renumbering

2014-04-03 03:40 RD, revision 76264

working version of the trac hooks

2014-04-03 03:28 RD, revision 76263

Yet another test commit. Closes #16155

2014-04-03 03:08 RD, revision 76262

Yet another test commit. Closes #16155

2014-04-03 01:59 RD, revision 76261

Another test commit. Closes #16155

2014-04-03 01:51 RD, revision 76260

Another test commit. Closes #16155

2014-04-03 01:35 RD, revision 76259

Another test commit. Closes #16155

2014-04-03 01:26 RD, revision 76258

Update svn hooks. Closes #16155

2014-04-03 00:39 VZ, revision 76257

Fix return value of wxRichMessageDialog with only an "OK" button. Apply the same workaround as was applied in r67771 to wxMessageDialog to wxRichMessageDialog and map IDCANCEL returned from it to IDOK if "Cancel" is the only button in the dialog -- as in this case it's really just a renamed (for convenience of allowing the user to use "Esc" to close it) "OK". Closes #16153.

2014-04-03 00:39 VZ, revision 76256

Show the result of closing rich message box in the sample. Improve showing the button which closed the message box by doing it inside the dialog used for testing it instead of popping up a separate message box just for this. And do the same thing for rich message boxes as for the normal ones. See #16153.

2014-04-03 00:39 VZ, revision 76255

Decrease the size of the message box test dialog in the sample. This dialog was getting too tall, especially in the rich message boxes case, so reduce its vertical size. Also centre it on screen to prevent it from being displayed partially off it because contents was added to the dialog after creating it.

2014-04-03 00:38 VZ, revision 76254

Fix return value of wxRichMessageDialog with only an "OK" button. Apply the same workaround as was applied in r67771 to wxMessageDialog to wxRichMessageDialog and map IDCANCEL returned from it to IDOK if "Cancel" is the only button in the dialog -- as in this case it's really just a renamed (for convenience of allowing the user to use "Esc" to close it) "OK". Closes #16153.

2014-04-02 00:49 VZ, revision 76253

Don't build the drawing test in GUI-less builds. This test requires GUI parts. Closes #16145.

2014-04-01 19:45 PC, revision 76252

Fix invalid use of g_object_get_property()

2014-04-01 14:46 VZ, revision 76251

Fix recently introduced assert when using owner drawn items in wxMSW. Relax the check added in r76202, the item might not be added to its parent menu yet even if the menu is not NULL. See #13878.

2014-04-01 11:02 JJ, revision 76250

Update OpenVMS compile support

2014-04-01 10:56 JJ, revision 76249

OpenVMS (Alpha only) uses != operator in std::find ->needs operator defenition

2014-03-31 21:42 SC, revision 76248

fixing missing wxON_BLOCK_EXIT_OBJ1 error on gtk build

2014-03-31 20:28 SC, revision 76247

extra semicolon

2014-03-31 20:28 SC, revision 76246

testing whether this helps getting the drawing testsuite to build

2014-03-31 18:46 JS, revision 76245

Use style sheet when copying to the clipboard if available

2014-03-31 18:11 JS, revision 76244

Use style sheet when copying to the clipboard if available

2014-03-31 18:11 JS, revision 76243

Use style sheet when copying to the clipboard if available

2014-03-31 17:47 SC, revision 76242

single wxFALLTHROUGH change to test different builds

2014-03-31 17:46 SC, revision 76241

fixing parameter type

2014-03-31 17:46 SC, revision 76240

fixing extra semicolon

2014-03-31 17:46 SC, revision 76239

getting rid of clang warning due to variable size array

2014-03-31 17:45 SC, revision 76238

silencing paranoid analyzer

2014-03-31 17:44 SC, revision 76237

fixing include style

2014-03-31 17:28 SC, revision 76236

adding wxFALLTHROUGH to indicate intended fall through in switch statements

2014-03-31 14:58 SC, revision 76235

adding log for nonprecomp builds, hopefully fixes test compiles on builbot

2014-03-31 14:34 SC, revision 76234

adding correct return type

2014-03-31 13:23 SC, revision 76233

make sure platform constants exist by using defs.h instead of setup.h

2014-03-31 09:55 SC, revision 76232

adding minimal ios support for webview

2014-03-31 09:28 SC, revision 76231

removing extra semicola

2014-03-31 09:08 SC, revision 76230

removing extra semicola

2014-03-31 08:15 SC, revision 76229

removing unnecessary header

2014-03-31 08:02 SC, revision 76228

fixing extra semicola

2014-03-31 04:16 PC, revision 76227

use wxDialog::ShowModal() rather than gtk_dialog_run() so all the things wxDialog::ShowModal() does are not bypassed

2014-03-30 21:23 PC, revision 76226

Prevent dialog widget from being destroyed during ShowModal()

2014-03-30 19:17 VZ, revision 76225

2014-03-30 13:47 SC, revision 76224

removing superfluous semicolon

2014-03-30 13:46 SC, revision 76223

adding empty base class implementation for OnNextIteration, call from OSXDoRun, allowing console event loop to override

2014-03-30 09:07 PC, revision 76222

use "new" wx-prefixed macros in samples

2014-03-30 03:52 PC, revision 76221

adjust size hints when decor size changes, to prevent changing a set client size during initial show closes #15794

2014-03-30 01:02 PC, revision 76220

use wxOVERRIDE

2014-03-29 17:53 VZ, revision 76219

Avoid overflows when calculating metafile coordinates in wxMSW. Use MulDiv() instead of naive multiplication followed by division as this could overflow, and did when large paper sizes were used in print preview. Closes #16138.

2014-03-29 17:53 VZ, revision 76218

Another PrepareForItem()-related fix in generic wxDataViewCtrl. This fix is similar to the previous commit but more speculative, as we currently don't have a bug scenario for it. Still, it seems to be wrong to call PrepareForItem() just before GetLineStart() which undoes its effect, so exchange the order of the calls. See #16132.

2014-03-29 17:53 VZ, revision 76217

Fix clicking on activatable toggle column in generic wxDataViewCtrl. Call PrepareForItem() after calling GetLineStart() as the latter calls PrepareForItem() for other items internally, undoing the effects of the first call. Closes #16132.

2014-03-29 17:53 VZ, revision 76216

Fix use of expander in non left most position in wxDataViewCtrl. Correct the expander rectangle definition to work when the expander column left boundary is not 0, i.e. if the expander column is not the left most one. Closes #16131.

2014-03-29 17:53 VZ, revision 76215

Simplify wxMSW wxToolBar controls support implementation. Rely on being able to set the separator size, which is supported since comctl32.dll v4.71 (the version distributed with IE 4.0...). This allows to remove big chunks of code dealing with multiple separators and simplifies the rest. Closes #16129.

2014-03-29 17:53 VZ, revision 76214

Avoid overflows when calculating metafile coordinates in wxMSW. Use MulDiv() instead of naive multiplication followed by division as this could overflow, and did when large paper sizes were used in print preview. Closes #16138.

2014-03-29 17:52 VZ, revision 76213

Another PrepareForItem()-related fix in generic wxDataViewCtrl. This fix is similar to the previous commit but more speculative, as we currently don't have a bug scenario for it. Still, it seems to be wrong to call PrepareForItem() just before GetLineStart() which undoes its effect, so exchange the order of the calls. See #16132.

2014-03-29 17:52 VZ, revision 76212

Fix clicking on activatable toggle column in generic wxDataViewCtrl. Call PrepareForItem() after calling GetLineStart() as the latter calls PrepareForItem() for other items internally, undoing the effects of the first call. Closes #16132.

2014-03-29 17:52 VZ, revision 76211

Fix use of expander in non left most position in wxDataViewCtrl. Correct the expander rectangle definition to work when the expander column left boundary is not 0, i.e. if the expander column is not the left most one. Closes #16131.

2014-03-29 14:06 VS, revision 76210

Don't emit wxEVT_TEXT in wxMSW's wxTextCtrl::SetFont(). Native text control sends EN_CHANGE when the font changes, producing a wxEVT_TEXT event as if the user changed the value. This is not the case, so supress the event.

2014-03-29 14:04 VS, revision 76209

Revert "Don't emit wxEVT_TEXT in wxMSW's wxTextCtrl::SetFont()." This reverts accidentally committed r76207.

2014-03-29 14:03 VS, revision 76208

OS X: fix wxFileDialog::SetupExtraControls()'s sandbox test. OS X 10.9 (possibly earlier) don't have nil contentView in NSSavePanel anymore, a NSRemoteView instance is used. The wx code that follows this test still crashes under sandbox, though, so update the check to use the APP_SANDBOX_CONTAINER_ID environment variable, which is only set when running under the sandbox. This is just another quick fix for the existing uncomfortably long-lived sandbox crash hotfix, not a proper solution.

2014-03-29 14:03 VS, revision 76207

Don't emit wxEVT_TEXT in wxMSW's wxTextCtrl::SetFont(). Native text control sends EN_CHANGE when the font changes, producing a wxEVT_TEXT event as if the user changed the value. This is not the case, so supress the event.

2014-03-29 14:02 VS, revision 76206

OS X: fix wxFileDialog::SetupExtraControls()'s sandbox test. OS X 10.9 (possibly earlier) don't have nil contentView in NSSavePanel anymore, a NSRemoteView instance is used. The wx code that follows this test still crashes under sandbox, though, so update the check to use the APP_SANDBOX_CONTAINER_ID environment variable, which is only set when running under the sandbox. This is just another quick fix for the existing uncomfortably long-lived sandbox crash hotfix, not a proper solution.

2014-03-27 23:10 VZ, revision 76205

Make "NOT the index" in wxListCtrl::SortItems() stand out even more. Any reasonable person expects the sort callback to receive the indices of the items, but it doesn't: it's passed the client data associated with them instead. Make it even more noticeable in the documentation.

2014-03-27 13:46 JS, revision 76204

Allow derivation from wxRichTextBufferDataObject

2014-03-27 13:05 VZ, revision 76203

Russian translations update from Pavel Maryanov.

2014-03-27 01:02 VZ, revision 76202

Make wxMSW owner drawn menu item code more clear and correct. The user-visible effect of this change is that removing the item from the menu and adding it back doesn't lose its icon any more. At the code level, wxMenuItem::SetBitmaps() and related methods are implemented outside of "#if wxUSE_OWNER_DRAWN" which allows to use them even in minimalistic library builds. And IsOwnerDrawn() is not used any more to determine whether the item has bitmaps, just only if it's really owner drawn, making the code more clear and fixing at least the bug above and possible more. Closes #13878.

2014-03-27 01:02 VZ, revision 76201

Rename wxMenuItem::MustUseOwnerDrawn() to MSWMustUseOwnerDrawn(). No real changes, just make it clear that this method is MSW-specific and is about using owner drawn items at MSW level and not wx one. See #13878.

2014-03-27 01:02 VZ, revision 76200

Close monitoring thread handles as soon as possible in wxMSW. Don't leave the handles of all threads used for monitoring the child processes open until the main process termination, rather close them as soon as the monitored process terminates. This ensures that we don't accumulate potentially unbounded number of open handles if we keep launching new child processes. An even better idea would be to actually use a single thread for monitoring all of them, but this fix is much simpler and should fix the most acute problem for now. Closes #16123.

2014-03-27 00:41 VZ, revision 76199

Close monitoring thread handles as soon as possible in wxMSW. Don't leave the handles of all threads used for monitoring the child processes open until the main process termination, rather close them as soon as the monitored process terminates. This ensures that we don't accumulate potentially unbounded number of open handles if we keep launching new child processes. An even better idea would be to actually use a single thread for monitoring all of them, but this fix is much simpler and should fix the most acute problem for now. Closes #16123.

2014-03-26 14:40 VZ, revision 76198

Dutch translations update from Thomas De Rocker.

2014-03-24 19:46 VZ, revision 76197

Add missing wxUSE_WXDIB checks. Fix compilation with wxUSE_WXDIB==0. Closes #16113.

2014-03-24 19:46 VZ, revision 76196

Don't change bitmap depth in wxMSW when copying it. Sometimes, creating a DDB may fail to create the bitmap of the requested depth and so a copy of wxBitmap could have a different depth than the original wxBitmap. Avoid this problem by falling back on using DIB if DDB with the right depth couldn't be created. Closes #11640.

2014-03-24 14:19 VZ, revision 76195

Add "View text" menu item to the webview sample. Allow to view just the text of the web page. Closes #16098.

2014-03-24 14:17 VZ, revision 76194

Fix reentrancy issues in wxMSW wxTextCtrl max length handling code. The changes of r75936 didn't work correctly if the handler of wxEVT_TEXT in some text control modified a (potentially) different text control, as the same global variable was reused with disastrous results. Avoid this by keeping a stack of insertion lengths instead. Additionally, fix another problem in r75936 which used 0 as a special marker for the insertion length, which result in redoing each insertion of empty string (which is another word for Remove()) twice unnecessarily, by using -1 instead. Closes #15980.

2014-03-24 14:06 VZ, revision 76193

Fix reentrancy issues in wxMSW wxTextCtrl max length handling code. The changes of r75940 didn't work correctly if the handler of wxEVT_TEXT in some text control modified a (potentially) different text control, as the same global variable was reused with disastrous results. Avoid this by keeping a stack of insertion lengths instead. Using a per-control field would work too, but would be a bit wasteful as the size of the stack will rarely be more than 1 (and never much more) and this change can also be applied to 3.0 branch without breaking ABI. Additionally, fix another problem in r75940 which used 0 as a special marker for the insertion length, which result in redoing each insertion of empty string (which is another word for Remove()) twice unnecessarily, by using -1 instead. Closes #15980.

2014-03-23 18:54 VZ, revision 76192

Add files included by richtext library to MSVC1{1,2} projects. Closes #16104.

2014-03-23 16:18 VZ, revision 76191

Fix setting menu item bitmaps after appending them in wxMSW. Update the bitmap used by Windows when using non-owner-drawn items with bitmaps. Closes #9388.

2014-03-23 16:18 VZ, revision 76190

Refactor wxMSW: move some code from wxMenu to wxMenuItem. This will allow reusing it for other wxMenuItem bitmap-related operations. See #9388.

2014-03-23 01:57 VZ, revision 76189

Fix toolbar repainting after deleting a tool in wxMSW. The toolbar was in an inconsistent state when recalculating the sizes of the separators used as placeholders for the controls and stretch spacers as the tool was already deleted from the native toolbar but still present in wx internal toolbar data and this resulted in discrepancies between the indices in the native and wx toolbars. Fix this by specially marking the already deleted but not yet removed tool and ignoring it during the recalculations. This makes the old, and only partially successful, attempt to work around this bug in DoDeleteTool() unnecessary and so the code is actually simplified by this change. Closes #16095.

2014-03-23 01:57 VZ, revision 76188

Document what wxPrintQuality really is. Mention that it can be either a predefined constant or a number expressing the resolution. See #14085.

2014-03-23 01:57 VZ, revision 76187

Fix wxFileSystemWatcher::RemoveAll() to actually work. We need to call DoRemove() on all watcher objects to really remove them, just removing our record of them was not enough and e.g. resulted in errors if we tried to re-add a previously watched path again. Closes #15531.

2014-03-23 01:57 VZ, revision 76186

Fix handling deletion of watched directory in MSW wxFileSystemWatcher. Don't log an incomprehensible error when the watched directory itself is deleted, but generate wxFSW_EVENT_DELETE for it. This is consistent with the behaviour under Unix and generally more useful. Closes #13294.

2014-03-23 01:57 VZ, revision 76185

Small refactoring in wxFileSystemWatcher MSW implementation. Make wxIOCPService::GetStatus() smarter about its return value, it makes sense to encapsulate the convention used to indicate the thread exit condition inside wxIOCPService class itself instead of sharing it between it wxIOCPThread itself. It will also make it easier to detect more detailed error conditions in this code.

2014-03-23 01:56 VZ, revision 76184

Disable the use of "override" keyword for MSVC < 11. While the keyword is indeed supported since MSVC 8, it's only since MSVC 11 that using it doesn't generate C4481 compiler warning ("nonstandard extension used"), so avoid using it with the earlier versions. See #16100.

2014-03-23 01:51 VZ, revision 76183

Fix toolbar repainting after deleting a tool in wxMSW. The toolbar was in an inconsistent state when recalculating the sizes of the separators used as placeholders for the controls and stretch spacers as the tool was already deleted from the native toolbar but still present in wx internal toolbar data and this resulted in discrepancies between the indices in the native and wx toolbars. Fix this by specially marking the already deleted but not yet removed tool and ignoring it during the recalculations. This makes the old, and only partially successful, attempt to work around this bug in DoDeleteTool() unnecessary and so the code is actually simplified by this change. Closes #16095.

2014-03-23 01:10 VZ, revision 76182

Fix wxFileSystemWatcher::RemoveAll() to actually work. We need to call DoRemove() on all watcher objects to really remove them, just removing our record of them was not enough and e.g. resulted in errors if we tried to re-add a previously watched path again. Closes #15531.

2014-03-23 01:10 VZ, revision 76181

Fix handling deletion of watched directory in MSW wxFileSystemWatcher. Don't log an incomprehensible error when the watched directory itself is deleted, but generate wxFSW_EVENT_DELETE for it. This is consistent with the behaviour under Unix and generally more useful. Closes #13294.

2014-03-23 01:10 VZ, revision 76180

Small refactoring in wxFileSystemWatcher MSW implementation. Make wxIOCPService::GetStatus() smarter about its return value, it makes sense to encapsulate the convention used to indicate the thread exit condition inside wxIOCPService class itself instead of sharing it between it wxIOCPThread itself. It will also make it easier to detect more detailed error conditions in this code.

2014-03-22 23:03 VZ, revision 76179

Handle normalization of directory names correctly in wxFileHistory. Don't use relative path for the directories, which can also be managed by wxFileHistory, because they don't have any and the old code resulted in showing an empty string for them.

2014-03-20 20:52 VZ, revision 76177

Put a __cplusplus guard around C++-specific tests in wx/defs.h. This avoids the warning about __cplusplus being undefined in the recently added wxOVERRIDE logic and make the existing wx_xxx_cast<>s definitions simpler.

2014-03-20 20:45 VZ, revision 76176

Mark some deprecated wxGrid methods as deprecated in the documentation. Point people to the new names of the deprecated methods. Closes #16103.

2014-03-20 20:45 VZ, revision 76175

Use Doxygen @deprecated tags for deprecated methods. Instead of just mentioning that the methods are deprecated in the documentation text, use the @deprecated tag for them to make it possible to detect it in documentation-processing tools too. Closes #16102.

2014-03-20 16:49 VZ, revision 76174

Remove configure test for override keyword. Detect its support in the code by testing __cplusplus value and using specific checks for MSVC and Clang as configure detects it as being available when using recent g++ versions in non-C++11 mode, which do support this keyword but warn when it is used without -std={gnu,c}++11 option, which makes actually using it a bad idea in this case.

2014-03-20 14:26 VZ, revision 76173

Add wxOVERRIDE and use it in common and wxOSX code. Make overriding virtual methods more explicit and enable additional checks provided by C++11 compilers when "override" is used. Closes #16100.

2014-03-20 14:26 VZ, revision 76172

Compilation fix in wchar_t build after r76171. Don't concatenate narrow wxLongLongFmtSpec with wide strings, just don't use wxT() at all. Closes #14685.

2014-03-19 23:57 VZ, revision 76171

Add wxInt64 support to wxText{Input,Output}Stream. Add explicit Read64[S]() and Write64() methods. Closes #14685.

2014-03-19 19:06 VZ, revision 76170

Use "virtual" keyword with overridden methods. No real changes, just make the code more clear by explicitly using "virtual". Closes #16097.

2014-03-19 19:01 VZ, revision 76169

Remove more unnecessary headers from drawing test. Don't include GUI headers in non-GUI code.

2014-03-19 18:59 VZ, revision 76168

Fix WX_ASSERT_SAME_AS_FILE() definition in the new drawing test. This macro should use AreFilesContentsEqual(), not AreImagesFilesContentsEqual(), used by WX_ASSERT_SAME_AS_IMAGE_FILE().

2014-03-18 21:12 VZ, revision 76166

Don't include apparently unnecessary headers in drawing test. wx/window.h shouldn't be needed in this non-GUI test.

2014-03-18 21:10 VZ, revision 76165

Remove redundant forward declaration of wxCursor from wx/window.h. We include wx/cursor.h from wx/window.h anyhow (and can't avoid it as we have a member of wxCursor type in wxWindowBase).

2014-03-18 20:31 VZ, revision 76164

Add a new test checking wxGraphicsContext implementation correctness. This test verifies that the output of wxGraphicsContext on the current system matches the pregenerated reference output.

2014-03-18 20:28 VZ, revision 76163

Include the individual headers that we really need instead.

2014-03-18 20:28 VZ, revision 76162

Don't include wx/dc.h from wx/graphics.h. This is not necessary and prevents compilation of this header in wxUSE_GUI=0 case.

2014-03-18 20:28 VZ, revision 76161

Don't include wx/cursor.h from wx/dc.h. This is simply not needed.

2014-03-18 18:23 VZ, revision 76160

Add font colour support to wxFontPickerCtrl. Currently this is only really implemented under Windows, just as the colour support in wxFontDialog, but make the API available under all platforms for consistency. Closes #11614.

2014-03-18 18:23 VZ, revision 76159

Use helper GetPickerWidget() function in wxFontPickerCtrl. No real changes, just use a helper function instead of an ugly M_PICKER macro. See #11614.

2014-03-18 18:08 VZ, revision 76158

Use "MultiProcessorCompilation" instead of explicit /MP in MSVS projects. Use the user-visible option instead of the command line option which is now hidden in the IDE. Closes #16093.

2014-03-18 18:07 VZ, revision 76157

Use "MultiProcessorCompilation" instead of explicit /MP in MSVS projects. Use the user-visible option instead of the command line option which is now hidden in the IDE. Closes #16093.

2014-03-18 15:21 VZ, revision 76156

Add margin to the right of the message in wxGenericProgressDialog. For some reason the border was used only on the left side but not on the right one, resulting in the ugly looking label flush to the right dialog border if it was long enough. Closes #16094.

2014-03-18 15:20 VZ, revision 76155

Add margin to the right of the message in wxGenericProgressDialog. For some reason the border was used only on the left side but not on the right one, resulting in the ugly looking label flush to the right dialog border if it was long enough. Closes #16094.

2014-03-18 10:14 JS, revision 76154

Improved calculation of spanning column widths.

2014-03-16 17:39 PC, revision 76153

update for GTK3

2014-03-16 14:05 VZ, revision 76152

Disable the use of new style wxDirDialog under Vista. IFileDialog-based dialog has a bug making it return a wrong path sometimes under Vista, disable its use there to avoid it. Closes #16005.

2014-03-16 14:05 VZ, revision 76151

Disable the use of new style wxDirDialog under Vista. IFileDialog-based dialog has a bug making it return a wrong path sometimes under Vista, disable its use there to avoid it. Closes #16005.

2014-03-15 20:34 PC, revision 76150

build fixes for wxUniversal

2014-03-15 19:44 PC, revision 76149

for GTK+ 3.6 and later, invalidate cached best size when GTK's style cache is updated, see #16088

2014-03-14 20:22 VZ, revision 76148

Fix showing of 32bpp bitmaps without alpha in wxMSW wxStaticBitmap. The native control doesn't make a secret copy of the image in this case (0RGB bitmap, i.e. 32bpp ARGB bitmap with all alpha values set to 0) and just shows the bitmap we assigned to it directly, so we must not delete it in this case, otherwise nothing is shown at all. Closes #16084.

2014-03-14 20:22 VZ, revision 76147

Also free internal handlers when wxMSW wxStaticBitmap is destroyed. r76142 fixed the resource leak when wxStaticBitmap image was replaced by another one but the leak still happened at the end, when the wxStaticBitmap was destroyed. Fix it there as well in the same way. Closes #16068.

2014-03-14 20:22 VZ, revision 76146

Fix recently introduced compilation error in wxUSE_PALETTE==0 build. Add missing "#if wxUSE_PALETTE" tests. Closes #16083.

2014-03-14 20:21 VZ, revision 76145

Also free internal handlers when wxMSW wxStaticBitmap is destroyed. r76141 fixed the resource leak when wxStaticBitmap image was replaced by another one but the leak still happened at the end, when the wxStaticBitmap was destroyed. Fix it there as well in the same way. Closes #16068.

2014-03-14 02:36 VZ, revision 76144

Add support for loading old V1 bitmap files to wxBMPHandler. Such files are apparently still seen in the wild, even though this format has been superseded since Windows 3.0 (!). Closes #3433.

2014-03-13 18:09 SC, revision 76143

adding 10.5 compatibility again

2014-03-13 17:20 VZ, revision 76142

Fix resource leak in wxMSW wxStaticBitmap when using RGBA icons. Release the old handle if it wasn't freed by STM_SETIMAGE itself. Closes #16068.

2014-03-13 17:19 VZ, revision 76141

Fix resource leak in wxMSW wxStaticBitmap when using RGBA icons. Release the old handle if it wasn't freed by STM_SETIMAGE itself. Closes #16068.

2014-03-13 17:17 VZ, revision 76140

Avoid unused variable warning in wxUSE_VALIDATORS==0 build. Closes #16076.

2014-03-13 17:15 VZ, revision 76139

Install wx/preferences.h and wx/testing.h in "make install". These headers were accidentally forgotten in files.bkl, add them there and rebake.

2014-03-13 17:12 VZ, revision 76138

Install wx/preferences.h and wx/testing.h in "make install". These headers were accidentally forgotten in files.bkl, add them there and rebake.

2014-03-13 14:03 VZ, revision 76137

Compilation fix to wxScopedArray use. The ctor taking the number of elements doesn't exist in 3.0, don't use it to fix compilation after the changes of r76124.

2014-03-13 00:04 VZ, revision 76136

Use wxScopedXXX<> instead of explicit memory management in wxBMPHandler. Make the code simpler and ensure there are no memory leaks in it.

2014-03-13 00:04 VZ, revision 76135

No changes, just use properly const variable in wxBMPHandler code. Initialize "data" pointer consistently with "alpha".

2014-03-13 00:04 VZ, revision 76134

Add support for saving 32bpp icons too. Save in 32bpp format if alpha channel is present in the image being saved in ICO format. See #15918.

2014-03-13 00:04 VZ, revision 76133

Allow saving 24 bpp ICO file in wxImage. Create ICO files with 24bpp if the image being saved contains more than 256 colours. Also use smaller values (4 bpp or monochrome) if the image uses fewer colours. See #15918.

2014-03-13 00:04 VZ, revision 76132

Add support for saving 256*256 ICOs in PNG format. Allow saving icons larger than 127*127 pixels (up to 256*256 which is the maximal size supported by the ICO format) and save large icons with the item data in PNG format, as it is normally done for these sizes. See #15918.

2014-03-13 00:04 VZ, revision 76131

Add support for loading icons in PNG format to wxImage. ICO files can contain data in PNG, as well as BMP, format in recent (i.e. from this millennium) versions of Windows, so check for this case in wxICOHandler and load such data using wxPNGHandler. See #15918.

2014-03-13 00:04 VZ, revision 76130

Handle verbosity correctly in wxICOHandler loading code. Pass on the "verbose" argument to LoadDib() function instead of always being verbose in it. Also remove the unused IsBmp variable. See #15918.

2014-03-13 00:04 VZ, revision 76129

Allow loading icons of width 256 from ICO files. Account for the tweak of ICO file format which uses 0 if the width is 256. See #15918.

2014-03-13 00:03 VZ, revision 76128

Fix possible memory leak in wxICOHandler loading code. Use wxScopedArray<> instead of a raw pointer to ensure that the memory is always freed, even in case of error return. See #15918.

2014-03-12 23:54 VZ, revision 76127

Add support for loading icons in PNG format to wxImage. ICO files can contain data in PNG, as well as BMP, format in recent (i.e. from this millennium) versions of Windows, so check for this case in wxICOHandler and load such data using wxPNGHandler. See #15918.

2014-03-12 23:54 VZ, revision 76126

Handle verbosity correctly in wxICOHandler loading code. Pass on the "verbose" argument to LoadDib() function instead of always being verbose in it. Also remove the unused IsBmp variable. See #15918.

2014-03-12 23:54 VZ, revision 76125

Allow loading icons of width 256 from ICO files. Account for the tweak of ICO file format which uses 0 if the width is 256. See #15918.

2014-03-12 23:54 VZ, revision 76124

Fix possible memory leak in wxICOHandler loading code. Use wxScopedArray<> instead of a raw pointer to ensure that the memory is always freed, even in case of error return. See #15918.

2014-03-12 23:20 VZ, revision 76123

Reset the system last error value before checking it in wxLog test. Explicitly set the last error indicator to 0 before checking that wxLogSysError() logs it correctly as it wasn't always set to 0 otherwise.

2014-03-12 17:02 VZ, revision 76122

Update the version string in manually managed VC11 project files. Use "31", not "30".

2014-03-12 14:23 VZ, revision 76121

Upgrade included Scintilla to version 3.3.9. Closes #15742.

2014-03-11 21:48 VZ, revision 76120

Add wxFont::GetBaseFont(). This can be used to "undo" the result of Bold() ,Underlined() or Italic() methods and returns an unadorned version of the font. Closes #11815.

2014-03-11 21:48 VZ, revision 76119

Remove unnecessarily overridden methods from wxToggleButtonBase. These methods already do exactly the same thing in the base wxAnyButton class, there is no need to override them again.

2014-03-11 21:48 VZ, revision 76118

No changes, just fix typos in my own name ("Zeitlin").

2014-03-11 17:04 VZ, revision 76117

Add wxEnhMetaFile::Detach(). Allow getting the handle from this class, this is useful if it needs to be passed to some other library, for example. Closes #15706.

2014-03-11 17:04 VZ, revision 76116

Correct wxThread::SetPriority() under Unix to hopefully work. The old implementation was completely broken, the new should hopefully work if pthread_setschedparam() behaviour really corresponds to its documentation. Mapping of our priorities in 0..100 range to pthread 1..99 range remains ugly but this seems to be unavoidable, unfortunately. Closes #14985.

2014-03-11 17:04 VZ, revision 76115

Fix accelerators in appended submenu items in wxGTK. They were not previously taken into account because we didn't call gtk_widget_add_accelerator() on the right GtkAccelGroup. Closes #16050.

2014-03-11 17:04 VZ, revision 76114

Add wxDynamicLibrary::GetModuleFromAddress(). Use dladdr() under Unix, if available, to provide the same functionality as we get from GetModuleHandleEx() under MSW and export it in a new public function. Closes #15248.

2014-03-11 16:20 VZ, revision 76113

Fix accelerators in appended submenu items in wxGTK. They were not previously taken into account because we didn't call gtk_widget_add_accelerator() on the right GtkAccelGroup. Closes #16050.

2014-03-10 20:05 VZ, revision 76111

Do run TextStreamTestCase::TestULongLong() test case. We ran TestLongLong test case twice because of an accidental typo.

2014-03-10 12:08 JS, revision 76110

Added on-demand image loading option to wxRTC.

2014-03-09 21:58 VZ, revision 76109

Fix size calculation for multi-column vertical toolbars in wxMSW. The width was calculated incorrectly in this case as we simply multiplied the width of the widest column by their number in this case, but actually each of them has its own width which needs to be calculated separately. See #13579.

2014-03-09 21:58 VZ, revision 76108

Fix background painting of multi-row toolbars in wxMSW. The item rectangle used wrong vertical coordinates which didn't matter (much?) for the single row toolbars but was completely wrong for toolbars with more than one row. Don't always anchor the rectangle at the window top to avoid this. See #13579.

2014-03-09 21:58 VZ, revision 76107

Disable stretchable spaces in multi-row toolbars in wxMSW. Stretchable separators simply don't work correctly when the space they are supposed to stretch onto is distributed across several different toolbar rows or columns, so just disable them for multi-row (or column, for vertical toolbars) case. See #13579.

2014-03-09 21:56 VZ, revision 76106

Fix size calculation for multi-column vertical toolbars in wxMSW. The width was calculated incorrectly in this case as we simply multiplied the width of the widest column by their number in this case, but actually each of them has its own width which needs to be calculated separately. See #13579.

2014-03-09 21:55 VZ, revision 76105

Fix background painting of multi-row toolbars in wxMSW. The item rectangle used wrong vertical coordinates which didn't matter (much?) for the single row toolbars but was completely wrong for toolbars with more than one row. Don't always anchor the rectangle at the window top to avoid this. See #13579.

2014-03-09 21:55 VZ, revision 76104

Disable stretchable spaces in multi-row toolbars in wxMSW. Stretchable separators simply don't work correctly when the space they are supposed to stretch onto is distributed across several different toolbar rows or columns, so just disable them for multi-row (or column, for vertical toolbars) case. See #13579.

2014-03-09 17:54 TIK, revision 76103

Don't assert if no keyboard has been found in wxGetKeyState(). Sometimes there really is no keyboard plugged in.

2014-03-09 17:51 TIK, revision 76102

wxBitmap::GetMask() asserts on invalid bitmap. Check for valid bitmap before calling GetMask().

2014-03-09 15:05 VZ, revision 76101

Make Move{Before,After}InTabOrder() work at any time in wxGTK. These functions only worked if called at the beginning, before showing the parent window containing the children whose TAB order was being adjusted, because it didn't refresh the GTK+ TAB order on the correct window: we need to do it for the parent of the window being moved, not this window itself. Closes #16032.

2014-03-09 15:03 VZ, revision 76100

Make Move{Before,After}InTabOrder() work at any time in wxGTK. These functions only worked if called at the beginning, before showing the parent window containing the children whose TAB order was being adjusted, because it didn't refresh the GTK+ TAB order on the correct window: we need to do it for the parent of the window being moved, not this window itself. Closes #16032.