Changelogs

Overview

These changelogs reflect the history of all files in the Subversion repository. The changelog has been generated at 2016-05-09 08:38:04

Select Changelog:

FileZilla 3, FileZilla Server,
Legacy FileZilla 2, Legay FileZilla Server

Select page:

[] [1 2 3 4 5 6 7 17 26 36] []

Changes per page:

25 50 100 250 500 1000 2000

Changelog for wxWidgets (70435 changes):

2011-06-22 22:21 SC, revision 68023

carbon prebuilt

2011-06-22 22:19 SC, revision 68022

new settings

2011-06-22 21:45 SC, revision 68020

wxcocoa prebuilt

2011-06-22 21:41 SC, revision 68019

new settings

2011-06-22 20:33 JC, revision 68018

Fixed a minor during merge

2011-06-22 20:04 JC, revision 68017

Merged src/gtk3 to src/gtk

2011-06-22 19:49 JC, revision 68016

Merged src/gtk3 to src/gtk

2011-06-22 19:44 JC, revision 68015

Merged src/gtk3 to src/gtk

2011-06-22 19:40 SC, revision 68014

new settings

2011-06-22 19:19 JC, revision 68013

Merged src/gtk3 to src/gtk

2011-06-22 19:15 JC, revision 68012

Merged src/gtk3 to src/gtk

2011-06-22 19:11 SC, revision 68011

new settings, removing incorrect setup

2011-06-22 19:10 SC, revision 68010

new settings for iphone

2011-06-22 19:09 SC, revision 68009

new settings for iphone

2011-06-22 18:56 JC, revision 68008

Merged src/gtk3 to src/gtk

2011-06-22 18:22 JC, revision 68007

Merged src/gtk3 to src/gtk

2011-06-22 18:15 SC, revision 68006

adding new xcconfigs

2011-06-22 18:10 JC, revision 68005

Merged src/gtk3 to src/gtk

2011-06-22 18:03 JC, revision 68004

Merged src/gtk3/utilsgtk.cpp to src/gtk/utilsgtk.cpp

2011-06-22 08:51 JC, revision 68003

Merged src/gtk3/window.cpp to src/gtk/window.cpp

2011-06-22 08:32 JC, revision 68002

Merged some source files from src/gtk3 to src/gtk

2011-06-22 08:04 JC, revision 68001

Trying to merge from src/gtk3 to src/gtk

2011-06-22 08:01 JC, revision 68000

Trying to merge from src/gtk3 to src/gtk

2011-06-22 07:57 JC, revision 67999

Trying to merge from src/gtk3 to src/gtk

2011-06-22 07:53 JC, revision 67998

Trying to merge from src/gtk3 to src/gtk

2011-06-22 07:50 JC, revision 67997

Trying to merge from src/gtk3 to src/gtk

2011-06-21 11:56 JS, revision 67996

Fixed shift-click selection

2011-06-21 11:56 JS, revision 67995

Fixed shift-click selection

2011-06-21 11:01 SC, revision 67994

set default deployment and compiler flags

2011-06-21 10:57 SC, revision 67993

set default deployment and compiler flags

2011-06-21 10:55 SC, revision 67992

use same flags as command line build

2011-06-20 00:46 VZ, revision 67990

Fix bug when setting an out of range date in wxMSW wxDatePickerCtrl. The internally stored date value was getting out of sync with the real date in the control itself when SetValue() was called with a date out of the currently set range. This resulted in an assert failure and other unpleasantness later. Fix the bug and add a unit test checking for it (and also with some other basic wxDatePickerCtrl checks).

2011-06-20 00:46 VZ, revision 67989

Extract wxDateTime-related cppunit helpers in a separate header file. No real changes, just refactor the code to allow using CPPUNIT_ASSERT_EQUAL with wxDateTime in other tests in the future.

2011-06-20 00:46 VZ, revision 67988

Document surprising behaviour of wxDatePickerCtrl::GetRange() in wxMSW. wxMSW native control always has a built-in lower limit as MSW doesn't support the dates before the year 1601 so wxDatePickerCtrl::GetRange() always returns a valid range start, even if SetRange() hadn't been called to set it. As this can be unexpected, document this behaviour clearly.

2011-06-20 00:46 VZ, revision 67987

Implement wxCalendarCtrl::SetDateRange() in the native GTK version. While GTK+ doesn't support imposing ranges for dates selection natively, we can do it ourselves by preventing the user from selecting any date outside of the currently valid range. This allows to use ranges under all platforms and not only in wxCalendarCtrl itself but in wxDatePickerCtrl as well.

2011-06-20 00:46 VZ, revision 67986

Suppress harmless gcc warnings about enum elements unhandled in switch. Latest mingw64 MinGW compiler has the headers required for enabling wxUSE_DBGHELP, fix the warnings given by g++ when compiling wxDbgHelpDLL code.

2011-06-19 22:52 PC, revision 67985

fix GTKGetLabel() and DoApplyWidgetStyle(): children are GtkWidget, not GtkBoxChild

2011-06-18 21:40 SC, revision 67984

adding universal as devices

2011-06-18 18:47 SC, revision 67983

adding universal as devices

2011-06-18 18:46 SC, revision 67982

adding instantiated xcodeproj

2011-06-18 17:53 SC, revision 67980

removing obsolete flags, switching to universal builds

2011-06-18 17:23 SC, revision 67979

fixing iphone build

2011-06-18 16:30 SC, revision 67978

updating project format to 3.2

2011-06-18 16:21 SC, revision 67977

removing old settings

2011-06-18 14:03 PMO, revision 67976

Update to trunk r67975

2011-06-18 13:32 PMO, revision 67975

Added panel.h, panel.cpp

2011-06-18 13:28 PMO, revision 67974

Use common Init

2011-06-17 23:53 VZ, revision 67973

Fix g++ warnings about initialized variables being declared extern. Don't declare variables extern when initializing them, this is already the case implicitly anyhow and explicit "extern" results in g++ warnings.

2011-06-17 23:53 VZ, revision 67972

Use GdipStringFormatCachedGenericTypographic hack for MinGW as well. When using GDI+ with MinGW, the same hack as for Cygwin is needed (see r66787) as it uses the same w32api headers and libraries for GDI+ support (if it has them at all). See #11716.

2011-06-17 23:53 VZ, revision 67971

Don't use __declspec(dllexport) for MinGW gcc 4.5 and later. Due to the changes in gcc 4.5, copies of dllexported inline functions are now generated in all object files including their declarations, increasing their sizes tenfold, and they are also now instantiated in the DLL itself increasing its size fourfold. Moreover, linking such a gigantic DLL requires inordinate amounts of memory and takes a very long time, see some statistics at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43601. To avoid all these problems, don't use dllexport at all any more but rely on binutils support for auto export/import which seems to work fine and results in much smaller DLLs which are created much faster.

2011-06-17 23:53 VZ, revision 67970

Avoid problems with conflicting UINT16 definitions in Cygwin headers. UINT16 is incorrectly defined inside Gdiplus namespace in w32api gdiplus.h used by Cygwin and MinGW resulting in compilation errors about ambiguous symbols. Fix this by forcefully redefining UINT16 in our own code. Closes #13113.

2011-06-17 07:02 JC, revision 67969

Tried to make sample/minimal work. Several bugs has been found and fixed. But samples/minimal still does not work. dcscreen and dcclient remain a lot to modify

2011-06-16 18:22 VZ, revision 67968

Fix wxStringOutputStream in wxUSE_UNICODE_UTF8 build. For some reason the conversion of the bytes written to this stream to Unicode was only done in wxUSE_UNICODE_WCHAR build but not in wxUSE_UNICODE_UTF8 one. Do it in any wxUSE_UNICODE build now. This allows to use wxStringOutputStream under Unix again, in particular it fixes an assert in samples/html/zip when trying to load the raw contents of a ZIP file in wxHtmlWindow.

2011-06-16 18:14 VZ, revision 67967

Italian translations update from Roberto Boriotti.

2011-06-16 18:12 VZ, revision 67966

Italian translations update from Roberto Boriotti.

2011-06-16 17:19 VZ, revision 67965

Disable wxFileSystemWatcher in configure if threads are disabled. wxFileSystemWatcher requires threads under MSW so disable it automatically in configure if --disable-threads was used to avoid compilation errors in wx/msw/chkconf.h later.

2011-06-16 17:14 VZ, revision 67964

Suppress various harmless warnings in MinGW build with -Wconversion. No real changes, simply add casts to make the implicit conversions that g++ warns about when using -Wconversion explicit.

2011-06-16 17:13 VZ, revision 67963

Make wxUIActionSimulator mouse move events marginally more precise. Round the values instead of truncating them when converting from pixel values to Win32 ::mouse_event() 0..65535 scale. This probably doesn't make any real difference in practice but seems more correct and also avoids g++ warnings.

2011-06-16 17:13 VZ, revision 67962

Use symbolic WAIT_FAILED constant instead of raw -1. No real changes, just make the code slightly more readable by using a symbolic constant instead of a magic value. This also avoids g++ warnings about implicit conversion of a signed value (-1) to unsigned type (DWORD).

2011-06-16 17:13 VZ, revision 67961

Round the values in wxDC coordinate calculations. Make the conversion of logical coordinates to the device ones more precise by avoiding errors due to truncation of floating point values to integer ones. See #13284.

2011-06-16 17:13 VZ, revision 67960

Round font sizes in AdjustToSymbolicSize() instead of truncating. This was mainly done to suppress g++ warning about implicit float to int conversion but it also seems to make more sense to round the value here instead of truncating it to int.

2011-06-16 11:07 JJ, revision 67959

add src/gtk/anybutton.cpp to OpenVMS makefile

2011-06-16 09:54 JC, revision 67958

Milestone 1: Preliminary port to gtk3 has been done. Compilation pass

2011-06-16 02:43 RD, revision 67949

Use wxAnyButton's DoGetBestSize for toggle buttons

2011-06-15 23:56 VZ, revision 67948

Generic wxHyperlinkCtrl appearance and behaviour improvements. Show focus rectangle around the control when it has focus. Also handle the space key to trigger the link. Also allow using either the native or generic version of the class in the widgets sample. Closes #11285.

2011-06-15 23:56 VZ, revision 67947

Don't crash in wxOSX wxTextEntry if the window wasn't created yet. Assert instead of crashing in wxTextEntry method if the associated window hadn't been fully created yet. Closes #13218.

2011-06-15 23:31 VZ, revision 67946

Fall back to the valid normal bitmap if no state-specific bitmap is set. After the recent changes we could try to use an invalid bitmap in wxMSW toggle button code as GetNormalState() could return State_Pressed and then we used the bitmap for the pressed state unconditionally even if it wasn't set. It seems more correct to always fall back to the normal bitmap as the pressed state is already taken into account by GetButtonState(). This fixes unit test failures under MSW after the button classes refactoring.

2011-06-15 16:19 LV, revision 67945

* Downgraded to Xcode 3 from Xcode 4 * Tabs -> spaces

2011-06-15 15:33 VZ, revision 67944

Fix keyboard navigation in wxGrid with reordered columns. Don't mix up column internal indices and display positions in wxGrid keyboard navigation code. This ensures that pressing left/right cursor arrows always moves the cursor to the previous/next column on the display, even if the columns were reordered. Closes #13281.

2011-06-15 15:33 VZ, revision 67943

Rename some parameters in wxGrid code to make them more clear. No real changes, just call the variables containing display positions "pos" and not "line" in wxGridOperations to avoid giving the impression that they contain indices.

2011-06-15 15:33 VZ, revision 67942

Fix crash when creating and quickly destroying a wxTLW in wxGTK. Don't crash in timer callback added to work around broken Ubuntu 11.04 WM, remove it when the window is being destroyed. This corrects a crash which happened if a TLW was created and destroyed before this timer had time to fire under Ubuntu. Closes #13146.

2011-06-15 15:14 JS, revision 67941

Removed header guards

2011-06-15 09:55 JS, revision 67940

Caret dropout fix

2011-06-15 09:54 JS, revision 67939

Caret dropout fix

2011-06-15 09:28 JC, revision 67938

window.cpp has been port to gtk3

2011-06-15 01:24 LV, revision 67937

Interface and dummy (stub) implementation of native wxMobile

2011-06-15 00:19 RD, revision 67936

wxButtonBase::GetDefaultSize is declared but not implemented in the wxOSX-cocoa port. Add an implementation that uses wxAnyButton::GetDefaultSize.

2011-06-15 00:05 JC, revision 67935

wx_gtk.cpp has been ported to wxgtk3

2011-06-14 23:15 SJL, revision 67934

Add wxWebView backend wxUSE_ macros

2011-06-14 20:46 JC, revision 67933

toplevel.cpp passed the compilation

2011-06-14 17:18 LV, revision 67932

native (iOS) Xcode mobiledemo target

2011-06-14 15:00 VZ, revision 67931

Refactor wxButton and wxToggleButton to derive from wxAnyButton. Introduce wxAnyButton class, a common base class for wxButton and wxToggleButton, allowing to reuse the same implementation for them. This also allows to implement support for bitmaps in wxToggleButton for all platforms and make wxBitmapToggleButton a trivial subclass of it everywhere, similarly to wxBitmapButton and wxButton. Closes #13198.

2011-06-14 09:04 JC, revision 67930

Making effort to port toplevel.cpp to gtk+3 even though there is compilation error messages

2011-06-14 06:22 PC, revision 67929

ensure new menubar is sized correctly, fixes #13280

2011-06-13 04:47 JC, revision 67928

My previous port work has been completely merged to wxWidgets GSOC2011 branch. The future port will be totally based one this branch.

2011-06-13 04:00 JC, revision 67927

The code of gtk2 and gtk3 differs a lot, so I push the compilation through. Need to be fixed in future

2011-06-13 01:16 JC, revision 67926

Merged aboutdlg.cpp and app.cpp

2011-06-12 23:19 JC, revision 67925

Added __WXGTK30__ flag in needed include/wx/* headers

2011-06-12 09:00 JC, revision 67924

Merged clipbrd.h and clipbrd.cpp

2011-06-12 08:02 JC, revision 67923

Merged bitmap.h

2011-06-12 05:39 SC, revision 67922

adding docset processing instructions

2011-06-12 04:47 SC, revision 67921

adding lighter css variant for xcode docsets

2011-06-12 01:56 VZ, revision 67920

Implement wxDataViewCtrl::SetRowHeight() for wxGTK. Also document that this method can only be used to increase the row height compared to the default, not to make it smaller. See #12749.

2011-06-11 17:41 SC, revision 67917

adding more specific info for docset

2011-06-11 05:08 LV, revision 67916

wxmobile-demo now builds/runs on OSX (sort of); Xcode project added

2011-06-11 01:48 LV, revision 67915

autogen'ed configure

2011-06-10 08:25 JC, revision 67914

Merged assertdlg_gtk.cpp and bitmap.h

2011-06-10 05:12 SC, revision 67913

adding implementation for osx

2011-06-10 01:05 SC, revision 67912

adding implementation for osx

2011-06-10 01:05 SC, revision 67911

adding default interpolation enum

2011-06-09 23:44 SC, revision 67910

fixing test, adding minimal docs

2011-06-09 23:38 SC, revision 67909

adding placeholders for interpolation setting

2011-06-09 09:18 JC, revision 67907

Initial effort to merge my previous port from src/gtk3 to src/gtk

2011-06-09 05:30 JC, revision 67906

Update tags files for easy browsing

2011-06-09 03:25 SC, revision 67905

fixing two warnings

2011-06-09 03:24 SC, revision 67904

fixing memory leak

2011-06-09 03:09 SC, revision 67903

inner layout support

2011-06-09 03:08 SC, revision 67902

adapting ownership semantics to cocoa convention

2011-06-09 03:07 SC, revision 67901

init pattern

2011-06-09 02:32 SC, revision 67900

better ownership handling

2011-06-09 02:31 SC, revision 67899

guard against nullptr

2011-06-09 02:30 SC, revision 67898

using common colorspace method

2011-06-09 02:29 SC, revision 67897

add member for sheetdialog

2011-06-09 02:28 SC, revision 67896

add member for sheetdialog

2011-06-09 02:24 SC, revision 67895

better retain/release semantics

2011-06-09 01:05 SC, revision 67894

adapting to init pattern

2011-06-09 01:05 SC, revision 67893

adding fallback

2011-06-09 01:02 SC, revision 67892

newstate already set

2011-06-09 01:01 SC, revision 67891

adding fallback

2011-06-09 01:00 SC, revision 67890

making intention clearer by explicit parentheses

2011-06-09 00:58 SC, revision 67889

fixing uninit vars warning and memory errors

2011-06-09 00:50 SC, revision 67888

adapting to init pattern

2011-06-09 00:48 SC, revision 67887

adapting to init pattern

2011-06-08 10:19 JC, revision 67886

Added personal settings about tag generation and vim

2011-06-08 00:49 VZ, revision 67885

Add wxDataViewCtrl::SetRowHeight() and provide its generic implementation. Allow changing the (fixed) row height without using wxDV_VARIABLE_LINE_HEIGHT which may slow down the control display too much. The new method is not implemented for the native GTK and OS X implementations yet but should be simple to implement there. See #12749.

2011-06-08 00:49 VZ, revision 67884

Update status bar fields widths from WM_SIZE handler. Doing it immediately after calling ::SetWindowPos(), as we used to do, didn't work correctly (presumably because the status bar fields widths were not updated yet internally) and resulted in not updating the ellipsized fields values when "Show window contents while dragging" Windows option was off. Doing it when we get WM_SIZE works in this case too. Closes #13257.

2011-06-08 00:27 VZ, revision 67883

Handle colours with alpha channel correctly in wxSVGFileDC. wxColour::GetAsString(wxC2S_HTML_SYNTAX) doesn't accept colours with alpha channel as alpha is not representable in HTML syntax, so avoid calling this function with such colours, remove the alpha component in the caller before using it instead. Also slightly simplify wxBrushString() and wxPenString() functions code in wxSVGFileDC implementation. Closes #13214.

2011-06-07 18:48 VZ, revision 67882

Replace more DECLARE_CLASS occurrences with DECLARE_DYNAMIC_CLASS. Correct more mismatches between DECLARE_CLASS and IMPLEMENT_DYNAMIC_CLASS usage.

2011-06-07 18:24 PC, revision 67881

avoid direct struct access for GTK3

2011-06-07 16:28 VZ, revision 67880

Use DECLARE_DYNAMIC_CLASS instead of DECLARE_CLASS. Correctly use DECLARE_DYNAMIC_CLASS for the classes that are supposed to be dynamically creatable as using DECLARE_CLASS doesn't work any longer after the last commit.

2011-06-07 15:06 VZ, revision 67879

Make wxDECLARE_CLASS synonym of wxDECLARE_ABSTRACT_CLASS. Previously wxDECLARE_CLASS was a synonym for wxDECLARE_DYNAMIC_CLASS which was inconsistent with its documentation and wxIMPLEMENT_CLASS that was the same as wxIMPLEMENT_ABSTRACT_CLASS. Resolve this in the most backwards compatible and also arguably logical way.

2011-06-07 15:06 VZ, revision 67878

Vietnamese translation update from Trần Ngọc Quân.

2011-06-07 07:56 JC, revision 67877

Added WXGTK3 support

2011-06-07 07:45 JC, revision 67876

Added WXGKT3 flag

2011-06-07 04:27 JC, revision 67875

Rename from .c to .cpp to make bakefile and make happy

2011-06-07 04:20 JC, revision 67874

Modified bakefile file.bkl to hold gtk3 source files

2011-06-07 01:23 SC, revision 67873

using higher abstraction to allow for optimized implementations

2011-06-07 01:15 SC, revision 67872

speeding up rectangle drawing by using specific methods, needs 40% less time

2011-06-06 23:13 SC, revision 67871

10.4 compatibility

2011-06-06 23:12 SC, revision 67870

reverting to idle handling

2011-06-06 22:13 JC, revision 67869

Migrated to gtk3

2011-06-06 22:13 JC, revision 67868

Migrated to gtk3

2011-06-06 21:19 SC, revision 67867

turning off unconditional usage of filter-delegate, using native capabilities under 10.6, proper handling of empty default directories for dialogs by passing in nil to native calls,

2011-06-06 18:32 SC, revision 67866

supporting nested window disablers on the same window

2011-06-06 17:53 JC, revision 67865

Fixed UNICODE support in configure.in

2011-06-06 17:39 JC, revision 67864

Added gtk3 define entry in setup.h.in

2011-06-06 09:09 JC, revision 67863

Define -D__WXGTK3__

2011-06-06 04:28 SC, revision 67862

supporting native background color on wxWindow descendants that are not themselves native controls, like eg wxPanel , see #13032

2011-06-05 22:26 LV, revision 67861

autogen'ed configure

2011-06-05 18:08 SC, revision 67860

supporting native background on nonownedwindow, see #13032

2011-06-05 17:32 SC, revision 67859

adding another assert for tracking modalSession problems

2011-06-05 11:26 LV, revision 67858

Merged JS's wxMobile proposal (http://wiki.wxwidgets.org/Development:_wxMobile_Proposal) incl. vector artwork

2011-06-03 19:18 JS, revision 67850

Removed erroneous second reference to status bar height

2011-06-03 19:18 JS, revision 67849

Removed erroneous second reference to status bar height

2011-06-03 19:17 JS, revision 67848

Added missing defines

2011-06-03 11:15 SC, revision 67847

allowing more system keys in fullscreen mode, properly taking framestyle into account

2011-06-02 11:25 SC, revision 67843

first implementation for state on custom renderer, see #12890

2011-06-02 10:36 SC, revision 67842

fixes #12867

2011-06-02 10:19 SC, revision 67841

reactivate commented out method

2011-06-02 10:18 SC, revision 67840

cleanup

2011-06-02 08:30 JC, revision 67839

Added -with-gtk=3 flag

2011-06-02 06:51 JC, revision 67838

Added gtk3 flag

2011-06-02 06:50 JC, revision 67837

Added gtk3 flag

2011-06-02 05:18 JC, revision 67835

2011-06-02 00:58 VZ, revision 67832

No changes, just avoid unused parameters warnings. Wrap parameters of the stub implementation of the newly added StartEditor() in WXUNUSED().

2011-06-01 22:05 SC, revision 67831

first stab at supporting custom renderers

2011-06-01 20:56 JC, revision 67830

2011-06-01 20:50 JC, revision 67829

2011-06-01 19:31 JC, revision 67828
  • D /wxWidgets/branches/SOC2011_GTK3/src/test.txt

deleted test.txt

2011-06-01 19:28 JC, revision 67827

Added a test.txt to see the version number chanage under git-svn

2011-05-31 21:36 RD, revision 67817

Virtualize StartEditor and add implementations for the ports that can do it.

2011-05-31 21:16 RD, revision 67816

Build fixes for using Cairo on MSW.

2011-05-31 19:16 PC, revision 67814

fix memory leak in wxScreenDC, fixes #13249

2011-05-31 10:09 SC, revision 67813

making sure

2011-05-31 07:53 JC, revision 67812

Added one entry in todo list

2011-05-31 07:14 JC, revision 67811

Import my previous gtk3 port

2011-05-31 07:14 JC, revision 67810

Try again with github

2011-05-31 06:30 JC, revision 67809

Added a TODO list

2011-05-31 05:07 JC, revision 67808

Recreate my branch for GTK3 port

2011-05-31 05:04 JC, revision 67807
  • D /wxWidgets/branches/SOC2011_GTK3

I decided to remove the old SOC2011_GTK3 branch and recreate one.

2011-05-28 21:35 VZ, revision 67806

Free calloc()'d pointer correctly in wxFSWatchEntryMSW. OVERLAPPED struct was allocated using calloc() but deleted later. Fix this by deallocating it with free() instead.

2011-05-27 21:47 SJL, revision 67805

Overhaul the wxWebView sample. Bring the style into line with the other samples and improve naming and consistency. Also use a wxInfoBar rather than a custom notification system.

2011-05-27 18:24 JC, revision 67804

Import my previous gtk3 work

2011-05-27 14:25 DS, revision 67802

Fixed saving GIFs on big-endian architectures. Word (16 bits) values were written in the wrong order resulting in invalid GIF files on for example PowerPC machines.

2011-05-27 11:46 VZ, revision 67801

Use #ifdef, not #if, to check for __WXGTK26__ symbol. This fixes gcc warning given if __WXGTK26__ is not defined (which almost never happens nowadays but still).

2011-05-27 08:32 JC, revision 67800
  • D /wxWidgets/branches/SOC2011_GTK3/interface

Remove interface directory

2011-05-27 08:31 JC, revision 67799
  • D /wxWidgets/branches/SOC2011_GTK3/build

Remove build directory

2011-05-27 08:14 JC, revision 67798
  • D /wxWidgets/branches/SOC2011_GTK3/lib

Remove lib directory and try to use symbolic link

2011-05-27 07:31 JC, revision 67797
  • D /wxWidgets/branches/SOC2011_GTK3/samples

Remove samples directory and try to use symbolic link

2011-05-27 07:29 JC, revision 67796
  • D /wxWidgets/branches/SOC2011_GTK3/distrib

Remove distrib directory and try to use symbolic link

2011-05-27 07:28 JC, revision 67795
  • D /wxWidgets/branches/SOC2011_GTK3/debian

Remove debian directory and try to use symbolic link

2011-05-27 07:27 JC, revision 67794
  • D /wxWidgets/branches/SOC2011_GTK3/utils

Remove utils directory and try to use symbolic link

2011-05-27 07:25 JC, revision 67793
  • D /wxWidgets/branches/SOC2011_GTK3/misc

Remove misc directory and try to use symbolic link

2011-05-27 07:23 JC, revision 67792
  • D /wxWidgets/branches/SOC2011_GTK3/locale

Remove locale directory and try to use symbolic link

2011-05-27 07:22 JC, revision 67791
  • D /wxWidgets/branches/SOC2011_GTK3/docs

Remove docs directory and try to use symbolic link

2011-05-27 07:17 JC, revision 67790
  • D /wxWidgets/branches/SOC2011_GTK3/demos

Remove demos directory and try to use symbolic link

2011-05-27 07:14 JC, revision 67789
  • D /wxWidgets/branches/SOC2011_GTK3/art

Remove art directory and try to use symbolic link

2011-05-26 21:53 SJL, revision 67788

Load the wxWidgets homepage by default in the wxWebView sample

2011-05-26 21:36 SJL, revision 67787

Do not show the wxWebView sample tools menu unless a page has been loaded. Originally it crashed but it doesn't make sense to change the zoom or view the source if there is no page loaded.

2011-05-26 21:17 SJL, revision 67786

Remove various bit of redundant code from the wxWebView sample source view dialog.

2011-05-26 20:43 SJL, revision 67785

Add a new event type for new window creation, document and implement under MSW. Update the sample to veto new window events, this means under Window we no long get Internet Explorer windows appearing for some links.

2011-05-25 13:26 SC, revision 67784

using systemui for full screen to allow modal dialogs

2011-05-25 10:37 JMS, revision 67783

In wxVListBoxComboPopup::Insert(), code adding client data was missing (fixes #13244)

2011-05-24 23:19 VZ, revision 67782

Correct the picker button best size computation. Fix the typo in the changes of r67763. See #13232.

2011-05-24 19:38 SC, revision 67781

guard against NULL textctrl, fixes #13247

2011-05-24 01:20 VZ, revision 67780

Correct type MSVCProjectBuilder in the build script. This prevented MSVC version detection from environment variables from working. Closes #13243.

2011-05-23 17:26 VZ, revision 67777

Don't use native MSW wxHyperlinkCtrl implementation in wxUniv. Move src/msw/hyperlink.cpp and include/wx/msw/hyperlink.h to ADVANCED_MSW_NATIVE_SRC/HDR from ADVANCED_MSW_SRC/HDR respectively to ensure that these files are not used in wxUniv build that uses its own, generic, versions. This should fix wxUniv/MSW build as the native files didn't even compile with wxUniv.

2011-05-23 17:26 VZ, revision 67776

Rebake after the addition of more richtext headers. The project files haven't been updated after the last files.bkl modification, do it now.

2011-05-23 13:06 VZ, revision 67775

Add a trivial benchmark for wxDateTime::ParseDate(). Add a test to check the performance of this method. See #13242.

2011-05-22 12:53 VZ, revision 67774

Italian translations update from Stefano <l.stickell@@yahoo.it>. Minor updates to the translations themselves. Also changed the charset to UTF-8 from Latin-1.

2011-05-21 00:48 DS, revision 67771

Fixed wxMessageBox with only an OK button returning wxCANCEL under MSW. Since r67620 when wxMessageDialog::ShowModal uses a native task dialog and only has an OK button it actually uses a Cancel button, this resulted in the function's return value wrongly changing to wxID_CANCEL. Fix this by handling the special case with only an OK button and return wxID_OK instead of wxID_CANCEL (and thus wxMessageBox, which uses wxMessageDialog::ShowModal, returning wxOK instead of wxCANCEL).

2011-05-21 00:44 DS, revision 67770

Applied patch containing small corrections to German translations. Patch by Blake Oleander (snowleopard2) with input from Robert Hoffmann. Closes #13212.

2011-05-20 16:29 VZ, revision 67769

Avoid conversion from wxString to wxChar* and back in wxListBase::DoCopy(). Don't use temporary wxChar* variable to store the node string. This is not only inefficient because we need to convert wxString to it only to convert it back to wxString on the next line but also breaks compilation when wxUSE_STD_STRING==1 and wxUSE_STD_CONTAINERS==0 as there is no implicit conversion between wxString and wxChar* in this case. Also modify the code for long keys in the same way just for consistency.

2011-05-20 16:26 JMS, revision 67768

Allow wxPGProperty::IsChildSelected() to work recursively

2011-05-19 22:43 SJL, revision 67767

Don't pass raw urls to logging functions in the wxWebView sample as they can contain percent characters which then cause format string errors.

2011-05-19 22:14 SJL, revision 67766

Block new frames being created in wxWebViewIE, bringing it into line with the other ports. The existing code was mostly correct but a missing break in the switch caused many spurious events.

2011-05-19 21:42 SJL, revision 67765

Remove defined values from wxWebView enums. We probably don't want people relying on these as they may well end up changing and there is no benefit to fixing them.

2011-05-19 20:28 SJL, revision 67764

Move wxWebView documentation into a separate interface file and add the wxWeb library to the libraries page

2011-05-19 16:14 VZ, revision 67763

Make picker control at least as high as the associated text and square. Ensure that the height of the picker control is at least as big as the height of the associated text control and that it's at least as wide as it is high as it looks bad otherwise. Closes #13232.

2011-05-18 18:35 SJL, revision 67762

Update wxWebViewIE::Reload so that reloading without using the cache works and doesn't crash.

2011-05-18 09:32 SC, revision 67761

making sure clip (device coordinages) is applied before any transforms, fixes #13216

2011-05-18 00:12 VZ, revision 67760

Allow passing wxLongLong values directly to wx pseudo-vararg functions. Allow passing wxLongLong objects when a "%lld" format specifier (or equivalent) is used just as we already do for wxString objects when "%s" is used. This is more convenient and makes wxLongLong closes to the native type.

2011-05-18 00:12 VZ, revision 67759

Don't construct invalid wxDateTime in GTK calendar control callbacks. GTK+ may momentarily return invalid date when switching the month in the calendar control. Check for this and adjust the date ourselves to make it valid if necessary in order to avoid the asserts from wxDateTime ctor. Closes #13224.

2011-05-17 15:35 VZ, revision 67758

Fix client to screen translation in wxWindowMSW::PopupMenu(). Use wxWidgets ClientToScreen() function for computing the screen coordinates of the popup menu instead of Windows ::ClientToScreen() as the latter doesn't know about the toolbar which may be present in wxFrame and excluded from the client area. Closes #13223.

2011-05-16 22:49 SJL, revision 67755

Rename source files for consistency

2011-05-16 16:07 VZ, revision 67754

Ensure that we never return negative client size. wxMSW could return negative client size for tiny windows with borders, this was unexpected and shouldn't happen so explicitly ensure it does not. Also add a unit test to check that this problem doesn't exist in other ports. Closes #13184.

2011-05-16 12:01 VZ, revision 67753

No changes, just refactor the code in MSW wxGetOsDescription() slightly. Construct the description string from several pieces: the OS name, its build number and any extra information about it, instead of duplicating the code appending the build number to the name in several places.

2011-05-16 12:01 VZ, revision 67752

Recognize Windows 7 and Server 2008 versions in wxGetOsDescription(). Use marketing names for these systems instead of just describing them as "Window NT x.y". Closes #13220.

2011-05-15 18:16 VZ, revision 67751

Allow dragging floating AUI frames by the gripper. Previously starting to drag a pane by its gripper worked but once it undocked it was impossible to drag it by the gripper any more which was annoying for the user and unexpected. Fix this by ensuring that we move the correct top level window and not the child window when dragging floating panes. Closes #13177.

2011-05-14 16:18 VZ, revision 67745

Fix small error in floating AUI frames client size under wxMSW. The client size of the floating frames ended up being wrong because we changed the wxRESIZE_BORDER flag after setting it and this changed it (at least under MSW). Reset wxRESIZE_BORDER first now and set the client size correctly afterwards. Closes #13043.

2011-05-14 16:18 VZ, revision 67744

Fix restoring of wxAuiManager::m_has_maximized when restoring perspective. If the perspective being loaded contains a maximized pane, set the m_has_maximized flag to true. Otherwise the flag and the effective pane state was out of sync resulting in several problems in the UI behaviour. Closes #12527.

2011-05-14 16:18 VZ, revision 67743

Correct the drawing of check tools with a drop down button in wxAuiToolBar. This combination was simply not covered by the existing code, add the missing DrawDropDownButton() call. Closes #11139.

2011-05-14 16:18 VZ, revision 67742

Reset the checked state of the first radio item in wxAuiToolBar too. Fix the condition of the loop in wxAuiToolBar::ToggleTool() to also uncheck the item with index 0 that was always excluded before because of "i > 0" check in the loop. Also exclude the item being turned on itself from the loops, it's useless to reset its checked state only to turn it on again below. Closes #11110.

2011-05-14 16:18 VZ, revision 67741

Check for NULL pane window in wxAuiManager. Check that the AUI pane has a non-NULL associated frame before checking whether it's shown. This should fix a crash which could happen when docking an undocked toolbar. Closes #10926.

2011-05-14 16:18 VZ, revision 67740

Improve checking for the landing point when docking windows in wxAUI. This is especially important for multiple monitor setups in which the old code could result in false positives and suggest docking a window on a wrong display. Closes #10612.

2011-05-14 16:17 VZ, revision 67739

Draw wxAuiToolbar button text even if it has no bitmap. Don't skip drawing the button label if it doesn't have any bitmap. Closes #10303.

2011-05-14 16:17 VZ, revision 67738

Take the AUI floating title bar height into account when dragging it. The cursor wasn't positioned correctly when a floating toolbar was dragged by pressing the mouse over its gripper because its position didn't take into account the difference between the client and window coordinates of the floating window (which is basically the height of the window title bar). Notice that the same problem still remains when starting to drag a docked toolbar as it doesn't have the title bar initially but does have it later so the same fix should probably be applied when we reparent the toolbar. Closes #9984.

2011-05-14 16:17 VZ, revision 67737

Cancel dragging in wxAuiNotebook on capture loss. Don't leave the display and internal variables in inconsistent state when the mouse capture is lost while a notebook page is being dragged (as can happen if Alt-Tab is pressed under Windows, for example). Closes #9976.

2011-05-13 15:30 VZ, revision 67735

Don't use the standard containers by default. Revert the change of wxUSE_STD_CONTAINERS to 1 by default as this introduces more incompatibilities which risk hamper upgrading to 3.0 unnecessarily. Update the documentation to better explain why do the non-standard container classes exist in wxWidgets and, especially, that they shouldn't be used when possible. Also document the differences between the normal and STL containers build in the manual.

2011-05-13 15:30 VZ, revision 67734

Fix the comparison function in the list control sample to do what it says. The comment in the function implied that it exchanged the items but in fact it did not and kept their existing order instead. Do revert them now, at least like this something visibly happens in the sample when the items are sorted.

2011-05-13 15:30 VZ, revision 67733

Make wxListCtrl sort function take wxIntPtr, not long, arguments. As the arguments to the sort function contain the client data associated with the items, they may be pointers and hence of greater size than long in Win64 builds. Use wxIntPtr instead of long everywhere to fix this. Notice that this doesn't break compatibility for 32 bit code where long can still be used as it is the same as wxIntPtr there after the previous commit. Closes #4309.

2011-05-13 15:29 VZ, revision 67732

Define wx[U]IntPtr as long, not [s]size_t, in 32 bit builds. Defining wxIntPtr as ssize_t or long in 32 bit builds doesn't really change anything but using long means that we can replace longs in the existing API with wxIntPtr without breaking compatibility, like in wxListCtrl::SortItems(). It is also more compatible with 64 bit builds where wxIntPtr is long already. So it has some minor advantages and no apparent drawbacks.

2011-05-13 15:29 VZ, revision 67731

Remove duplicated portability warning from wxShowEvent description. The warning about this event not being generated by all ports was already present, remove the second copy.

2011-05-13 13:24 DS, revision 67730

Fixed wxUSE_STD_DEFAULT==0 compilation. ScintillaWX.cpp didn't compile because std::string is unknown. Include <string> in case the defines that (by default) are set to wxUSE_STD_DEFAULT are 0.

2011-05-11 20:03 JC, revision 67729
  • D /wxWidgets/branches/SOC2011_GTK3/test.txt

This is a test

2011-05-11 20:02 JC, revision 67728

2011-05-11 18:45 JS, revision 67727

wxRTC doc updates

2011-05-11 18:44 JS, revision 67726

Use more appropriate border style

2011-05-11 17:52 VZ, revision 67725

Don't document wxFileSystemWatcher::AddTree() as pure virtual. It isn't. See #12847.

2011-05-11 08:46 SC, revision 67724

separating observers for default mode (outer 'normal' loop) and common mode loops, fixes #13208

2011-05-10 11:58 VS, revision 67723

Clarify that wxFileName::GetPath() appends separator for toplevel dirs.

2011-05-10 10:54 VZ, revision 67722

Attempt to work around Mac g++ 4.0 bug in fswatcher unit test. Don't define the class overriding a virtual base class method inside the test function as g++ 4.0 under OS X 10.5 fails to compile this for some mysterious reason.

2011-05-10 10:50 VZ, revision 67721

Fix inserting radio menu items in wxGTK too. After fixing the insertion of radio menu items in wxMSW, also do it for wxGTK to make the newly added unit test pass there as well. Remove the unneeded wxMenu::m_prevRadio which doesn't make any sense neither (just as the "current radio group" pointer removed from wxMSW code before) and simply use the radio group of the existing item this radio item is being inserted before or after instead. See #13200.

2011-05-10 10:50 VZ, revision 67720

Rewrote wxMSW radio menu items code to support not only appending them. Previously the radio menu items could only be appended to a menu in wxMSW, inserting them (either in an existing radio group or to start a new one) not only didn't work but could even result in crashes because invalid iterators in the menu items list could be used. Fix this by storing the ranges of all radio groups in wxMenu itself instead of storing the information about the radio group an item belongs to in the item itself and by updating this data whenever a new radio item is inserted. Also get rid of the notion of "current radio group" in wxMenu which doesn't really make any sense. Finally add a unit test checking that inserting radio items works as expected. Closes #13200.

2011-05-09 21:44 JMS, revision 67719

Fixed a bug: Disabling a property didn't work properly if a child item was selected.

2011-05-09 12:08 JS, revision 67718

Added further wxRTC files to files.bkl

2011-05-09 11:21 VZ, revision 67717

Document wxBitmapToggleButton XRC parameters. Describe the properties specific to this class in the XRC format documentation. Closes #13204.

2011-05-09 11:21 VZ, revision 67716

Add wx/richtext/richtextuicustomization.h to the headers list. This header wasn't installed before, add it to RICHTEXT_HDR files list in files.bkl to fix this. Closes #13203.

2011-05-09 11:21 VZ, revision 67715

No changes, just sort richtext files in files.bkl. Sort RICHTEXT_{SRC,HDR} contents in alphabetical order, just as it's done for all the other files list and to make it easier to check if a file already occurs in these lists or not.

2011-05-08 20:29 JS, revision 67714

More work on improving wxRTC documentation, copied buffer and control headers to interface folder.

2011-05-06 17:28 SJL, revision 67712

Enable IE backend in msw builds unconditionally until the backend flags work properly. Conditionally define INET constants only under mingw as it does not apparently provide them. Fix some typos. The sample now compiles under msw.

2011-05-06 15:37 SJL, revision 67711

Use correct reload flags on all platforms to avoid compilation errors

2011-05-06 14:59 SJL, revision 67710

Move msw configuration checking to chkconf.h

2011-05-06 13:00 SJL, revision 67709

Add the correct dll export macros

2011-05-06 01:52 DS, revision 67708

Fixed failing to load ANI, BMP, and ICO images from non-seekable streams. Guarded recently added SeekI() calls by calling is IsSeekable() first. Regression since r67671. Closes #12861 (again).

2011-05-05 22:51 SJL, revision 67707

Minor fixes to allow web sample to compile

2011-05-05 22:30 SJL, revision 67706

Fix compilation under dll builds. Wrap source files in wxUSE_WEB checks to allow minimal builds.

2011-05-05 20:48 SJL, revision 67705

A few more build fixes

2011-05-05 19:56 RD, revision 67704

When we're using GDI+, the DC might have transforms applied to it, but the renderer APIs don't respect them. So we need to apply the transforms to the rect ourselves.

2011-05-05 15:01 SJL, revision 67702

Various typos fixes and minor build system changes. After a rebake wxMSW should now compile, although without any functionality.

2011-05-04 21:03 SJL, revision 67700

Tidy the files list, move the wxWEB files to their own section. Include the headers in the all headers section.

2011-05-04 20:24 SJL, revision 67699

Set the correct svn properties on the new files. Correct a minor date typo.

2011-05-04 17:40 SJL, revision 67698

Application of the most recent wxWebView patch, the only changes were so tab to space conversions. Please note this probably won't compile.

2011-05-04 02:41 RD, revision 67697

Adda virtual dtor to silence warnings

2011-05-04 02:40 RD, revision 67696

Wipe the old framework (if any) when building a new one. Fix symlinks. Add a plist.

2011-05-04 02:01 VZ, revision 67695

Fix compilation of wxFileSystemWatcher unit test in non-PCH build. Add #include of wx/timer.h needed when not using PCH.

2011-05-04 01:31 VZ, revision 67694

Fix wxFileSystemWatcher usage instructions. Don't mention the virtual OnXXX() functions which were removed from the final API. Also mention AddTree() limitations on non-MSW platforms. See #12847.

2011-05-04 01:31 VZ, revision 67693

Implement watching directory correctly in MSW wxFileSystemWatcher. The directories used to be always monitored recursively, even when this wasn't requested, in wxMSW implementation. Change this but also implement efficient support for monitoring the entire hierarchies using the native support for this. Also update the sample to allow monitoring directories recursively as well. See #12847.

2011-05-04 01:31 VZ, revision 67692

Don't watch directories recursively in wxMSW wxFileSystemWatcher. MSW implementation of this class always watched the added entries recursively, i.e. always behaved as if the entry to watch was added using AddTree(). Fix this simply by not asking ::ReadDirectoryChangesW() to watch the entire subtree. See #12847.

2011-05-04 01:31 VZ, revision 67691

Fix wxFileSystemWatcher::Remove() in wxMSW. Removing the path watched by wxFileSystemWatcher didn't do anything in wxMSW implementation so we still continued getting events for the changes to this path even after calling Remove(). Fix this by really implementing Remove() properly. Also add a unit test checking that we don't get any events after calling Remove(). See #12847.

2011-05-04 01:31 VZ, revision 67690

No changes, just slightly simplify wxFileSystemWatcher unit test. CheckResult() method of the test event handler doesn't need to return anything, it uses CPPUNIT_ASSERTs and related macros inside it to check that everything is expected.

2011-05-04 01:31 VZ, revision 67689

Fix assert when creating wxBitmapButton without a valid bitmap in wxMSW. wxBitmapButton can be created without a valid bitmap if SetBitmapLabel() is called later, so don't call SetBitmapLabel() from the constructor if no bitmap was provided.

2011-05-03 21:05 SC, revision 67687

project files for xcode

2011-05-03 20:28 SC, revision 67686
  • D /wxWidgets/trunk/src/wxWindows.xcodeproj

removing old xcode files

2011-05-03 20:24 SC, revision 67685
  • D /wxWidgets/trunk/src/jpeg/jpegM8.xml
  • D /wxWidgets/trunk/src/regex/regexM8.xml
  • D /wxWidgets/trunk/src/stc/stcM8.xml
  • D /wxWidgets/trunk/src/zlib/zlibM8.xml
  • D /wxWidgets/trunk/utils/helpview/src/helpviewM5.xml

removing old codewarrior files

2011-05-03 20:22 SC, revision 67684
  • D /wxWidgets/trunk/samples/access/accesstestW7.xml
  • D /wxWidgets/trunk/samples/controls/controlsW7.xml
  • D /wxWidgets/trunk/samples/dialogs/dialogsW7.xml
  • D /wxWidgets/trunk/samples/dnd/dndW7.xml
  • D /wxWidgets/trunk/samples/docview/docviewW7.xml
  • D /wxWidgets/trunk/samples/minimal/minimalW7.xml

removing old codewarrior files

2011-05-03 20:21 SC, revision 67683
  • D /wxWidgets/trunk/samples/minimal/minimal.xcodeproj

removing old xcode files

2011-05-03 20:21 SC, revision 67682
  • D /wxWidgets/trunk/samples/minimal/minimal.xcode

removing old xcode files

2011-05-03 18:29 DS, revision 67681

Replaced Ok() occurrences with IsOk() throughout trunk. Additionally renamed wxOSX' private wxNativePrinterDC::Ok() function to IsOk(). Didn't deprecate the various Ok() functions: given the amount of changes already introduced in 3.0 a trivial one like this seems more suitable for after 3.0.

2011-05-03 14:47 DS, revision 67679

Restored wxNotebook::HitTest for wxOSX-Carbon. Since the copying of src/osx/carbon/notebmac.cpp to src/osx/notebook_osx.cpp in r55202 the code in wxNotebook::HitTest has been disabled. Enabled it again for at least the Carbon build. See #13045.

2011-05-03 12:40 VZ, revision 67678

Don't crash on startup of console programs in monolithic wxX11 build. When using monolithic build, GUI-specific wxWinModule is still linked in but its initialization crashes because there is no global display. Simply don't do anything in this module OnInit() in this case to avoid the problem (which affected e.g. wxrc in this build configuration).

2011-05-03 12:40 VZ, revision 67677

Correct wxDirExists() check in OS X wxFileSystemWatcher implementation. Pass the full path to wxDirExists, not the relative path from the watched directory as this won't work unless the watched directory is the same as the current one. Closes #13161.

2011-05-03 12:40 VZ, revision 67676

Add wxDocManager::GetPageSetupDialogData() accessor. Allow accessing the print data stored in wxDocManager from outside the class. Closes #13190.

2011-05-03 12:40 VZ, revision 67675

Increase the number of index items shown by default in wxHTML. Consider that small index is up to 1000 items, not up to 100 which is really too small. See #10573.

2011-05-02 09:25 JJ, revision 67673

add src/common/affinematrix2d.cpp to OpenVMS makefiles

2011-05-02 01:35 DS, revision 67671

Fixed reading multiple images from ANI and ICO image files. In r60852 various 'unneeded' SeekI(0) calls were removed. Examined the changes in that revision and restored all SeekI(0) calls after finding out their removal caused problems with reading more than one image from ICO and ANI files. The image handling code for these formats expects to read from the start of a stream for reading its images (as well as for DoCanRead and DoGetImageCount), regardless of the index of the requested image. Closes #12861.

2011-05-01 21:07 SC, revision 67666

support multiline strings using the same workaround as msw, fixes #13019

2011-05-01 20:44 VS, revision 67665

Make wxSpinCtrlGeneric usable as wxDVC editor control. wxDVC installs temporary event handler that watches for focus changes and some key events. Make wxSpinCtrlGeneric look like a native wxControl in this respect even though it's actually a composite control.

2011-05-01 18:06 VZ, revision 67664

Create branch for GSoC 2011 animation project.

2011-05-01 18:06 VZ, revision 67663

Create branch for wxiOS GSoC 2011 project.

2011-05-01 18:05 VZ, revision 67662

Create branch for wxWebView GSoC 2011 project.

2011-05-01 18:05 VZ, revision 67661

Create branch for GTK3 porting GSoC 2011 project.

2011-05-01 17:58 VZ, revision 67660

Translate various user-visible strings in rich text print code. Make default wxRichTextPrintout title and the name of wxRichTextPrinting object translatable. Closes #13187.

2011-05-01 17:47 VZ, revision 67659

Verify the validity of the buffer size in wxBufferedDC. Passing invalid (e.g. negative) buffer size to wxBufferedDC resulted in many problems later on so refuse it immediately. Closes #13175.

2011-05-01 17:47 VZ, revision 67658

Add a section about STL containers-related incompatible changes. Document the main incompatibilities between the STL and non-STL containers builds.

2011-05-01 16:58 DS, revision 67657

Rebaked test GUI projects with toplevel.cpp included. Added toplevel.cpp to GUI test projects and removed the test suite from the unnamed registry so that by default its tests don't run (some regarding ShowWithoutActivating are failing). This way at least the source file has more of a chance to be in a compilable state (compilation was broken). toplevel.cpp has never been included in a project since its addition in r62508 ("[...] until the mainloop issues are resolved [...]").

2011-04-30 12:57 DS, revision 67656

No code changes, fixed some typos. Changed several occurrences of "it's" where "its" is meant, as well as a few other minor typos.

2011-04-29 22:03 RD, revision 67650

Fix popen2 deprecation warning. Fix binary name inside the framework to be the same as the framework name. Inject a bit of info about the framework into wx-config, so it can output framework flags/names instead of lib flags/names.

2011-04-28 18:57 VZ, revision 67645

Remove fixed size of gs_encodingNames array in font mapper code. Specifying the size explicitly made wxCOMPILE_TIME_ASSERT() checking that the array sizes were synchronized useless as the array always had the correct size, independently of the real number of elements in it.

2011-04-28 18:57 VZ, revision 67644

Correct wxFontMapper tables for Big-5, Shift-JIS and GB2312 encodings. As wxFONTENCODING_{BIG5,SHIFT_JIS,GB2312} are only synonyms for the other encoding constants, we must append the corresponding names to the array of names for the real encoding value instead of having the (never used) separate entries for them in the names array. Closes #13164.

2011-04-28 18:16 VZ, revision 67643

Fix wxULongLongNative::ToDouble() compilation with VC6. The problem alluded to by the commit message of r40658 arose only in the DLL build using VC6 so reintroduce the workaround for it removed by r67634 but make it VC6-specific and, arguably even more importantly, also make it work correctly for wxULongLongNative values greater than LONGLONG_MAX.

2011-04-28 16:29 VZ, revision 67642

Use correct GTK macro in wx_gtk_widget_get_sensitive(). Using GTK_WIDGET_VISIBLE() to test for sensitivity was not going to work (and, in fact, it didn't and broke the unit tests).

2011-04-28 16:20 VZ, revision 67641

Fix check in assert in wxULongLong::ToULong(). We can convert values up to ULONG_MAX to unsigned long losslessly, not up to LONG_MAX.

2011-04-28 16:20 VZ, revision 67640

Don't specialize std::numeric_limits<> for wxLongLong when using VC6. This doesn't work with VC6 anyhow as it doesn't provide numeric_limits<> specialization for __int64 and results in many warnings C4663 as the standard header itself uses obsolete template specialization syntax.

2011-04-28 08:08 RD, revision 67638

Change --j to --jobs, add --mac_framework_prefix, add some helper functions to be used from build-wxpython.py and fix a bunch of other little stuff.

2011-04-27 20:51 VZ, revision 67634

Fix wxULongLong::ToDouble() for MSVC. The conversion of wxULongLong to double was broken for MSVC by r40658 which was supposed to correct some unspecified compilation problem but this code seems to compile fine with at least recent versions of MSVC and, in any case, correcting compilation only for the code to work incorrectly during run-time doesn't look like a good idea. This fixes current unit test failures in wxMSW.

2011-04-27 20:44 VZ, revision 67633

Disable numeric_limits<wxLongLong> test for VC6. VC6 doesn't specialize numeric_limits<> for its __int64 so it's not specialized for wxLongLong neither when using this compiler.

2011-04-27 20:44 VZ, revision 67632

Get rid of useless temporaries in wxAffineMatrix2D unit test. See #13092.

2011-04-27 20:43 VZ, revision 67631

Add wxUSE_DC_TRANSFORM_MATRIX checks to the unit test. Allow the unit test to compile even when wxUSE_DC_TRANSFORM_MATRIX is 0. See #13092.

2011-04-27 12:26 JJ, revision 67627

Add wxUSE_DC_TRANSFORM_MATRIX to setup for OpenVMS

2011-04-27 00:57 VZ, revision 67624

Change VIEWPORT_EXTENT constant in wxMSW wxDC code to be a power of two. Notice that this commit doesn't really change anything, in particular it doesn't correct zooming for zoom factors that are power of 2 (which was broken before as ticket #11669 showed), this was already done by the previous commit. This one simply makes multiplying by VIEWPORT_EXTENT a tiny bit more efficient. See #9554.

2011-04-27 00:57 VZ, revision 67623

Avoid rounding errors in wxMSW wxDC scaling code. Multiply by scale factor when it's > 1 and divide by it when it's < 1 to avoid rounding errors. By choosing whether to increase the viewport or window extents we increase precisions without any apparent negative effects (at least under Windows NT where the coordinates in 2^27 range are supported, but even under Windows 9x it's not clear if the old code was better as while we never overflowed the viewport extents, we could overflow the window ones easily for small zoom factors). Closes #9554.

2011-04-27 00:57 VZ, revision 67622

Remove apparently erroneous -1 from DrawBitmap() in wxMSW wxGC code. We didn't draw the last line and row of the image for some reason, simply remove the -1 which prevented us from doing this. Closes #12476.

2011-04-27 00:57 VZ, revision 67621

Make wxSMALL_FONT larger under MSW as it was unreadable otherwise. The default size of the normal font is 9pt under MSW and 7pt is too small for wxSMALL_FONT, use 8pt for it instead. Closes #13104.

2011-04-27 00:57 VZ, revision 67620

Ensure that message boxes with only "OK" can be closed with Escape in wxMSW. The native task dialog doesn't allow using Escape (nor Alt-F4 but this is less annoying) to close it unless it has a Cancel button, so by default the dialogs with only "OK" couldn't be closed with Escape. Work around this by creating a Cancel button with "OK" label instead. This is not ideal but there doesn't seem to be any other way to make this work. See #12501.

2011-04-27 00:57 VZ, revision 67619

Allow showing the print preview frame non modally. Still show the print preview app modally by default, i.e. disabling all the other windows, but also allow disabling only the preview parent or nothing at all. Closes #13108.

2011-04-27 00:57 VZ, revision 67618

No changes, just replace #defines with enums in printing sample. This makes it more convenient to define menu ids with consecutive values as will be done in the next commit.

2011-04-27 00:57 VZ, revision 67617

Add a unit test for wxAffineMatrix2D class and its support in wxDC. Verify that applying a world transformation to wxDC really does result in the expected transformation. See #13092.

2011-04-27 00:57 VZ, revision 67616

Make it easier to compare wxImages in the unit tests. Instead of forcing the tests to manually use memcmp(), specialize CppUnit::assertion_traits<> for wxImage. This allows to simply use CPPUNIT_ASSERT_EQUAL() and related macros with wxImage objects.

2011-04-27 00:57 VZ, revision 67615

Update line height in generic wxListCtrl to match images height. The height of the items of the generic wxListCtrl remained too small if an image of a greater than standard size was used. Fix this by forcing the line height recalculation when adding an item using an image higher than the current line height. Closes #12806.

2011-04-27 00:57 VZ, revision 67614

No changes, just simplify the mask checks in wxImage::Paste(). Replace the test of the form "(!a && b) || (a && b)" with a simple test for "b" and then also replace the test for "b || (c && !b)" with just "b || c". The end result is much easier to read and understand.

2011-04-27 00:57 VZ, revision 67613

Optimize alpha handling in wxImage::Rotate90() too. The changes of r66309 optimized the rotation of the pixel data by doing it in entire strips instead of pixel by pixel, apply the same technique now to the rotation of alpha data as well. Closes #12739.

2011-04-27 00:57 VZ, revision 67612

Fix assert when destroying wxDataViewCtrl being edited in wxGTK. If wxDataViewCtrl was destroyed while showing a generic editor, an assert occurred in wxWindowBase dtor as the event handler pushed on it by the editor. Fix this by calling CancelEditing() when the control is destroyed and also fix the crash in CancelEditing() in wxGTK due to recursive calls to FinishEditing(). Closes #12683.

2011-04-27 00:56 VZ, revision 67611

No changes, just get rid of wxDataViewColumn::GetConstGtkHandle(). If both const and non-const accessors are needed, it's custom to use the same name for both but in this case we don't even need them as the const version can always be used, so simply remove the weird and badly named (because the returned handle is not const at all) GetConstGtkHandle().

2011-04-27 00:56 VZ, revision 67610

Specialize std::numeric_limits<> for wxLongLong and wxULongLong. numeric_limits<> should be specialized for number-like types to allow using them in a similar way to the built-in types. Closes #13162.

2011-04-26 21:02 RD, revision 67608

Don't change CC and CXX for the SDK options until after the compiler version has been chosen so it doesn't mess up the version tests.

2011-04-26 19:39 RD, revision 67604

Remove lipo options, that hack is no longer needed since we are not supporting OSX 10.3 any more. Also some work to get framework builds working properly.

2011-04-26 19:35 RD, revision 67603

Use DESTDIR properly and fix change-install-names script. Closes #12461

2011-04-26 19:14 SC, revision 67602

fixes #12220

2011-04-26 01:18 RD, revision 67600

Fix the size of the tree's text editing box on Cocoa

2011-04-25 15:18 DS, revision 67598

Fixed filename in wxOSX-Cocoa's file dialog using extension of wrong file type. When using SetFilterIndex to indicate a different initial file type the dialog would still use the extension of the first file type (if the filename had no extension then unchecking "Hide extension" would append the first file type's extension). Fixed this by calling code, that formerly got called only from OnFilterSelected, to notify OS X of the file type change.

2011-04-24 15:14 VS, revision 67592

Don't rely on RVO in wxON_BLOCK_EXIT_SET(). MakeVarSetter() relies on the compiler always using RVO, as VariableSetterImpl<> doesn't have correct copy ctor; worse yet, its use wasn't detected at compile time. With some compilers (e.g. VC++ 2008 with non-trivial variable types), this resulted in the variable being reset too soon, immediately in the place where the macro was used. Fixed by using the same technique already used in wxScopeGuardImpl. In fact, VariableSetterImpl is just another special case of wxScopeGuardImpl, so just derive from the latter.

2011-04-23 20:01 VZ, revision 67591

Don't generate wxEVT_COMMAND_DATAVIEW_CACHE_HINT for empty control. Don't send any cache hint events for empty wxDataViewCtrl. Sending them was unnecessary, inconsistent with wxListCtrl (which doesn't send them when it's empty) and the events also had incorrect range. Just don't create them at all to avoid all these problems at once. Closes #13132.

2011-04-23 19:36 VZ, revision 67590

Don't close arcs drawn in wxPostScriptDC. Draw arcs, not pies, in DoDrawArc(): simply remove the apparently unnecessary last lineto and closepath PostScript statements. Closes #13141.

2011-04-23 18:19 VZ, revision 67589

Change wxNotebook selection before sending page changed event in wxMSW. wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGED handler should see the new page selected in the control, not the old one as was the case if the page was changed using the mouse in wxMSW. This should have been done together with the other changes of r66224, see its commit message for more details. Closes 13145.

2011-04-23 18:03 VZ, revision 67588

Add wxDC::SetTransformMatrix() and related methods and implement them in wxMSW. Add support for world transformations to wxDC too. Currently this is implemented in wxMSW only but could be easily provided in the ports that use wxGraphicsContext for wxDC implementation later. Closes #13092.

2011-04-23 17:12 VZ, revision 67587

Fix compilation error in recent change to wxSizeEvent generation. Wrong variable name was used in r67583, fix it.

2011-04-23 16:53 VZ, revision 67586

Correct names of parameters in wxAffineMatrix2D documentation. Some parameters were misnamed in @param paragraphs, fix this. Closes #13143.

2011-04-23 16:53 VZ, revision 67585

Add a simple unit test for wxParseCommonDialogsFilter(). Verify that this function (which is used for parsing the wildcard strings used with file-related dialogs) works as expected and also asserts when given invalid input. See #4489.

2011-04-23 13:17 VZ, revision 67584

Document that wxTreeCtrl::SelectItem() generates events. This is another exception to the general rule that program actions don't generate any events so document it explicitly. See #13153.

2011-04-23 13:17 VZ, revision 67583

Set event object correctly for the generated wxSizeEvents. wxSizeEvent event object was not set correctly in at least a couple of places. Do set it now. Closes #13156.

2011-04-23 13:17 VZ, revision 67582

Remove duplicate negated option indicator in wxCmdLineParser help. The indicator of a negatable option (one with wxCMD_LINE_SWITCH_NEGATABLE flag) appeared twice in the usage message, don't add it the second time. Closes #13157.

2011-04-23 13:17 VZ, revision 67581

Fix file paths in wxFileSystemWatcherEvent under OS X. The separator between the watched directory and the name of the file in the generated event was missing, add it now. Closes #13161.

2011-04-23 12:49 VZ, revision 67580

Set page range in the print preview correctly. The valid pages range was set too early before, we need to postpone it until after the OnPreparePrinting() call of the user-defined wxPrintout object as only it can determine the number of pages (after running the pagination algorithm) in general. Set the pages range during the first call to RenderPageIntoDC() to fix this. Also add wxPrintPageMaxCtrl class for symmetry with the existing wxPrintPageTextCtrl and use a shared constant MAX_PAGE_NUMBER instead of hard coded 99999. Slightly improve the layout of wxPrintPageMaxCtrl too. Closes #12965.

2011-04-23 12:41 VZ, revision 67579

Make the source files non-executable again. Revert the (probably accidental) mode change of r67576.

2011-04-22 21:20 RD, revision 67578

Use a relative link for wx-config so it will also work even when not located at the install prefix. Ported from the wxPy-2.9.1.1 tag/branch.

2011-04-22 21:18 RD, revision 67577

Explicitly specify the Mac SDK for wxPython builds

2011-04-22 20:25 VS, revision 67576

Return wxWindow* from wxDataViewCustomRenderer::CreateEditorCtrl(). There's no reason to limit custom editor controls to wxControl, which would rule out e.g. composite controls or any custom widgets. Make appropriate changes to related functions and code too.

2011-04-22 17:48 SC, revision 67575

osx 64 bit multilib build needs an explicit export as in this architecture our visibility flags get respected for obj-c classes as well

2011-04-22 17:20 SC, revision 67574

implementation of HotKey, see #12354

2011-04-22 16:50 VS, revision 67573

Compilation fix for DEFINE_GUID uses. DEFINE_GUID doesn't define the value, only declares an external variable, unless initguid.h was included. This leads to linker errors.

2011-04-22 12:43 DS, revision 67572

Fixed wxUSE_STD_STRING==0 compilation. With at least MSVC9 numformatter.cpp wouldn't compile because of unknown identifiers related to locales. Include <locale.h> in case wxUSE_STD_STRING is set to 0.

2011-04-22 01:43 VZ, revision 67570

Define ACO_AUTOAPPEND for MinGW/Cygwin. Apparently this symbol is not defined in MinGW headers neither, so do it ourselves as well.

2011-04-22 01:43 VZ, revision 67569

Use "wx" prefix for the GUIDs we (re)define in wxMSW code. CLSID_AutoComplete became ambiguous with MinGW because it does define it in its shlguid.h header (although MSVC/Platform SDK does not define this one) so use a "wx" prefix for it to avoid ambiguity. Also use the same prefix for the IID_IAutoCompleteDropDown value we define for consistency.

2011-04-21 17:47 VZ, revision 67567

Redefine IAutoCompleteDropDown in our code as it's not always available. MinGW doesn't have shobjidl.h header file which is normally part of the Platform SDK and doesn't have IAutoCompleteDropDown interface definition in any of its headers at all, so define this interface and its IID ourselves to make the code compile with it. Notice that MinGW-64 does have the interface declaration but still doesn't define IID_IAutoCompleteDropDown. So to be on the safe side just always define everything ourselves, as long as we need to do it for one of the compilers, it's not more difficult to do it for all of them.

2011-04-21 14:44 JS, revision 67566

Added ForceDelayedLayout

2011-04-21 14:44 JS, revision 67565

Added ForceDelayedLayout

2011-04-20 16:54 DS, revision 67551

Make use of SetFilterIndex in wxOSX-Cocoa's file dialog. Previously the file type would solely be based on the extension of the passed filename. This is still done, but any valid filter index as set by the user will now take precedence. See also #12429.

2011-04-20 09:53 DS, revision 67550

Fixed saving dialog's filter index always being -1 with wxOSX-Cocoa. This problem was reproducable using the Save file dialog in the dialogs sample. The member m_filterIndex was only initialised to -1 and never set at another point. Set it to the filter's selection during ModalFinishedCallback. Closes #13158.

2011-04-19 07:17 PC, revision 67546

fix conversion of gdk_input_add() to g_io_add_watch() from r67326

2011-04-19 01:50 VZ, revision 67541

Do send wxEVT_UPDATE_UI events to hidden windows. Failing to send wxEVT_UPDATE_UI to hidden windows made it impossible to show them from their update UI handler which was totally unexpected as the documented wxUpdateUIEvent::Show() method could never be used. Do send these events to the hidden windows themselves but avoid sending the update UI events to the children of hidden windows as this is really useless because any change of their state wouldn't be seen by the user anyhow (even if the child is shown, it would still remain hidden until its parent is) and would just waste time processing a lot of needless events.

2011-04-19 01:36 VZ, revision 67540

Don't send wxWindowDestroyEvent if we hadn't sent wxWindowCreateEvent. Don't generate wxWindowDestroyEvent when destroying the windows that had been never created for symmetry with wxWindowCreateEvent which wasn't sent for this window neither.

2011-04-19 01:36 VZ, revision 67539

Don't assert when destroying a never created window in wxGTK. The other ports don't assert if a default-constructed wxWindow object for which Create() had never been called is Destroy()d and wxGTK shouldn't do this neither. The new behaviour is more logical but also fixes a problem with an assert in wxOwnerDrawnComboBox that can currently be seen in wxGTK unit tests.

2011-04-18 15:47 VZ, revision 67532

Correct a typo in DoAutoCompleteCustom() stub in wxMSW. Fix a compilation error introduced by r67518.

2011-04-18 12:06 JMS, revision 67531

Use Connect() to bind embedded wxTextCtrl events instead of event table. This seems to be more reliable approach here, and fixes a bug with wxPropertyGrid's wxEditEnumProperty.

2011-04-18 12:03 JMS, revision 67530

In wxComboCtrlBase::OnTextCtrlEvent(), make sure to call event.StopPropagation() only after it has been copied

2011-04-18 11:58 JMS, revision 67529

Also show EVT_TEXT_ENTER in the combo sample

2011-04-18 01:15 VZ, revision 67527

Correct wrong port-specific note in AutoCompleteFileNames() documentation. This function is only implemented in wxMSW, not wxGTK2.

2011-04-18 01:14 VZ, revision 67526

Implement auto-completion support for wxTextEntry in wxOSX/Cocoa. Both completing a set of fixed strings and dynamic completion using a custom completer are supported, although completing the file names remains MSW-only for now. Note that, unlike under MSW, auto-completion under Mac is not automatic and has to be triggered manually by calling complete: method. This is done by pressing F5 key by default. In the future we should call it automatically on a timer event to make it more obviously discoverable.

2011-04-18 01:14 VZ, revision 67525

Refactor: extract wxTextCompleterFixed from wxMSW to a header. This class will be used in other ports too so don't make it private to wxMSW (although it still remains private to wxWidgets for now as it doesn't make much sense to use it in user code).

2011-04-17 23:47 DS, revision 67524

Removed wxOSX conditional code from generic calendar control. Tested the calendar sample with Cocoa and Carbon to determine the behaviour and looks are still the same.

2011-04-17 23:46 DS, revision 67523

Improved year control of generic calendar being too narrow when using a locale with long month names. See #11444.

2011-04-17 23:45 DS, revision 67522

Removed invalid use of sizeFlags parameter for SetSize call in generic calendar control. In r39715 the height parameter of a call to SetSize was changed to -1, however the previous coordinate value remained and became the fifth parameter which represents bit flags. Simply removed the fifth parameter.

2011-04-17 02:09 VZ, revision 67520

Add wxAffineMatrix2D and related classes. This class represents an affine 2D transformation and will be used in wxDC for now and maybe in wxGC later. Closes #13143.

2011-04-17 02:09 VZ, revision 67519

Fix wxXmlDocument::SetRoot() broken by recent changes. Support for wxXML_PI_NODE introduced in r67346 broke SetRoot() and, because of this, saving XML documents. Correct this and add a unit test for this method. Closes #13135.

2011-04-17 01:17 VZ, revision 67518

Define wxTextEntry::DoAutoCompleteStrings() stub in wxMSW code too. Forgot to define this function in !HAS_AUTOCOMPLETE case. This fixes linking problems with old compilers/headers such as VC6 with its original SDK.

2011-04-16 19:27 VZ, revision 67515

Split wxTextCompleter into a base class and wxTextCompleterSimple. Allow overriding either the iterator-like methods of the base class or the single and possibly more convenient, albeit slightly less efficient, method of the derived wxTextCompleterSimple class. This makes it possible to completely delegate to wxTextCompleter from wxMSW IEnumString implementation and actually makes the code there easier, even if it it still not quite trivial because of multi-threading concerns. It also would make it possible to show the completions progressively, as they are retrieved, in a future generic implementation of auto-completion (MSW native implementation doesn't do this unfortunately and waits until all of the completions become available before showing them).

2011-04-16 19:27 VZ, revision 67514

Don't block the main UI thread while generating completions in wxMSW. The native IAutoComplete implementation takes care to retrieve the completions from a background thread to prevent the UI from freezing while they're being generated, but we worked against it by always generating all the completions from the main thread and just enumerating them from the background one. Change this now and call wxTextCompleter::GetCompletions() method from the background thread itself to never block the main one.

2011-04-16 19:27 VZ, revision 67513

Use ACO_AUTOAPPEND option for text completion in wxMSW. This option appends the first candidate completion value to the text control itself making it more user-friendly as it reduces the amount of typing needed to enter it. See #11465.

2011-04-16 19:27 VZ, revision 67512

Added private wxEVT_AFTER_CHAR event for wxMSW implementation needs. This event is sent by wxMSW after the default handling of WM_CHAR has taken place. It can be used to define an event handler triggered by key presses and having access to the new value of the control, updated to take the last key press into account. This event will be used by auto-completion implementation for wxMSW only for now.

2011-04-16 19:27 VZ, revision 67511

Add support for dynamic auto-completion in wxTextEntry. Add wxTextCompleter class which allows to return the possible completions dynamically and wxTextCompleter::AutoComplete() overload using it. So far this is only implemented for wxMSW. Also fix calling wxTextEntry::AutoComplete(wxArrayString) multiple times under MSW, this didn't correctly update the list of shown completions before.

2011-04-16 19:27 VZ, revision 67510

No changes, just simplify preprocessor checks in wxMSW wxTextEntry. Separate !HAS_AUTOCOMPLETE stub versions from the real one as the code was too difficult to read otherwise and would become even more so after the addition of the upcoming custom auto-completer support.

2011-04-16 19:27 VZ, revision 67509

Refactor wxTextEntry::AutoComplete() to simply call DoAutoCompleteXXX(). No real changes, just make the public AutoComplete() non-virtual and add virtual DoAutoCompleteXXX() methods to make it easier to add new public AutoComplete() overloads in the upcoming commits.

2011-04-16 18:59 SC, revision 67508

adding missing part when using the native paint CGContextRef on osx, see #11853

2011-04-16 15:07 SC, revision 67505

supprting flag for pixel offsetting for msw, see #11853

2011-04-16 15:05 SC, revision 67504

supprting flag for pixel offsetting for osx, see #11853

2011-04-16 14:47 SC, revision 67503

supprting flag for pixel offsetting for cairo, see #11853

2011-04-16 14:21 SC, revision 67502

support generic flag for pixel offsetting, see #11853

2011-04-15 21:18 DS, revision 67497

Replaced C++ comments with C ones in C files. Replaced C++ comments (occurring outside of __cplusplus blocks) in files that contain the warning "THIS IS A C FILE" with C comments.

2011-04-15 20:31 PC, revision 67496

workaround for broken window managers which claim to support _NET_REQUEST_FRAME_EXTENTS, but don't respond to it see #13146

2011-04-15 11:23 JMS, revision 67494

Removed wxPG_DOUBLE_BUFFER constant. Now all wxPG rendering is done double-buffered, regardless of the platform. Code path with wxPG_DOUBLE_BUFFER = 0 did not render correctly (fixes #13140). In future should probably use wxAutoBufferedPaintDC or something similar, but this will require non-trivial code changes and testing.

2011-04-14 15:22 JMS, revision 67488

Rebuild textctrl events using copy ctor

2011-04-13 18:39 JMS, revision 67440

wxEVT_COMMAND_TEXT_UPDATED events from wxComboCtrl's embedded wxTextCtrl kept confusing wxPropertyGrid::HandleCustomEditorEvent(). We need to ignore them.

2011-04-13 18:35 JMS, revision 67439

Completely re-construct the wxComboCtrl textctrl-events instead of just redirecting them

2011-04-13 11:22 SC, revision 67438

preparing for completions support

2011-04-12 11:35 JMS, revision 67436

Describe what re-implemented wxComboPopup::DestroyPopup() should do

2011-04-11 18:59 JS, revision 67435

When we load an image from the block, we should invalidate the cached bitmap.

2011-04-11 12:23 JJ, revision 67434

Update Makefile for OpenVMS

2011-04-11 11:36 JJ, revision 67433

revoke OpenVMS dependend part of r67326

2011-04-10 17:36 VZ, revision 67429

Re-define push_back() in wxSortedArrayString to behave correctly. Adding items to wxSortedArrayString should always keep them sorted but while Add() did this, push_back() didn't breaking the class invariant. Redefine push_back() in _WX_DEFINE_SORTED_TYPEARRAY_2 macro to fix this and add a unit test checking that wxSortedArrayString::push_back() does work now. Closes #13134.

2011-04-10 17:36 VZ, revision 67428

Allow customizing AUI tab colours in wxAuiTabArt. Add wxAuiTabArt::SetColour() and SetActiveColour() methods and provide trivial default implementation of them in wxAuiDefaultTabArt to allow customizing the tab colours. Closes #11411.

2011-04-10 17:36 VZ, revision 67427

Fix off by one pixel error when drawing active tab in wxAUI. The active tab had a drawing artefact because its gradient background was drawn in a rectangle one pixel too short. See #11411.

2011-04-10 17:35 VZ, revision 67426

Correct Javanese language code. It is "jv" and not "jw", the latter was an error in a previous edition of ISO 639 standard and was corrected since then. Closes #13131.

2011-04-09 12:28 JS, revision 67421

Correction to position in character insertion event when also deleting selected text.

2011-04-09 12:28 JS, revision 67420

Correction to position in character insertion event when also deleting selected text.

2011-04-09 11:22 SC, revision 67419

fixing configure builds for iphone

2011-04-08 22:22 TIK, revision 67418

Fix a comment typo.

2011-04-08 18:31 SC, revision 67417

see #9715

2011-04-08 17:09 SC, revision 67416

workaround OSX bug, fixes #4555

2011-04-08 14:16 SC, revision 67415

support 3.X deployment

2011-04-08 10:08 JJ, revision 67414

Update OpenVMS compile support

2011-04-07 14:55 SC, revision 67412

adding 10.5 APIs to avoid CGErrors, fixes #13121

2011-04-06 19:04 PC, revision 67411

build fix for wxUSE_LOG==0

2011-04-06 19:03 PC, revision 67410

avoid GCC warning "suggest braces around empty body in an ‘else’ statement"

2011-04-06 19:02 PC, revision 67409

fix typo from r67326

2011-04-06 18:37 VZ, revision 67408

Fix vararg function in wxXml unit test broken by recent changes. The changes in r67345 changed CheckXml() vararg function to take a reference as the first argument but this doesn't work with va_start(), so revert to using a pointer here. This fixes the current unit test failures in the XML tests.

2011-04-06 16:37 VZ, revision 67407

Avoid dereferencing invalid iterator in wxMessageDialog code. The iterator wxString::rbegin().base()+1 is invalid so check that we don't use it. Closes #13126.

2011-04-06 16:37 VZ, revision 67406

Correctly restore the old locale in wxXLocale functions. In non-wxHAS_XLOCALE_SUPPORT case we didn't restore the original locale correctly in wxStrtoxxx_l() functions as the return value of wxSetlocale() was incorrectly assumed to be the old locale instead of the new one. Fix this and also replace the macros used by the old code with a small helper class, this simplifies the code and is less ugly. Finally add a unit test which failed before these changes when the program ran in any non-C locale but passes now. Closes #13117.

2011-04-06 16:37 VZ, revision 67405

Fix incorrect use of setlocale() in wxLocale::IsAvailable(). The return value of setlocale() was used incorrectly in this code: it represents the newly set locale and not the previously active one so we didn't actually restore the original locale before. Fix the code and check that we do actually restore the locale in a new unit test for it. See #13117.

2011-04-06 10:53 JJ, revision 67401

Update OpenVMS compile support

2011-04-06 10:47 JJ, revision 67400

Fix for broken wxGTK1 compilation

2011-04-06 00:29 VZ, revision 67399

Don't do anything in WX_ASSERT_FAILS_WITH_ASSERT when wxDEBUG_LEVEL==0. We can't test for assert failure when using a build of wxWidgets in which asserts don't exist at all. Closes #13119.

2011-04-06 00:29 VZ, revision 67398

Fix VarArgTestCase compilation when type traits are unavailable. When type traits are unavailable we can't check whether a type can be passed to a vararg function but we still need to pass a copyable object to wxString::Format() for the code to compile, even if we just want to check that it will fail with the assert at run-time. Closes #13118.

2011-04-05 17:50 PC, revision 67394

build fix for gtk1

2011-04-05 00:07 DS, revision 67393

Compilation fixes for wxUSE_LOCALE and wxUSE_XLOCALE set to 0.

2011-04-04 20:01 JS, revision 67390

Corrected XML conversion for style names, face name to avoid loading errors

2011-04-04 19:56 JS, revision 67389

Corrected XML conversion in style names and face names

2011-04-04 19:55 JS, revision 67388

Further commenting

2011-04-04 11:21 DS, revision 67387

Changed licence references to "wxWindows licence". Use "wxWindows licence" and not "wxWidgets licence" and also use British spelling for licence. Updated new occurrences in recently added files and a couple of previously (r64940) missed ones. See #12165.

2011-04-04 00:41 DS, revision 67386

Fixed failing image test. ImageTestCase::DibPadding was always failing due to differences in pixel data between the decoded GIF and encoded ICO image. Instead of comparing image content just check if the saving of the ICO succeeds (prior to r67296 it would crash).

2011-04-03 22:52 DS, revision 67385

No code changes, fixed forgotten typo that is a part of r67384. See #13076.

2011-04-03 22:31 DS, revision 67384

No code changes, fixed various typos. Applied patch by snowleopard2 fixing typos in interface/. Extended the fixes throughout trunk. Closes #13076.

2011-04-03 07:19 PC, revision 67383

For wxGTK2, link with X11 explicitly, since we use many X11 functions directly. Some linkers, notably newer Linux ones, don't implicitly link against dependent libs Fixes #13100

2011-04-03 01:37 PC, revision 67382

Correct query for formats supported by wxDataObject in wxGTK wxClipboard, closes #11811

2011-04-03 01:37 PC, revision 67381

fix for wxUSE_COMBOBOX==0, closes #12268

2011-04-03 01:31 VZ, revision 67380

Disable wxUSE_STD_CONTAINERS by default for MSVC6. This compiler can't compile its own standard headers with the default options as it overflows an internal heap. Disable the use of standard containers by default for it to avoid this problem and indicate that /Zm option must be used to avoid this.

2011-04-03 00:19 PC, revision 67379

make sure value label updates even if handle position does not change, fixes #13042

2011-04-02 22:43 PC, revision 67378

need to override DoGetBestClientSize() to get correct size, fixes #13088

2011-04-02 20:28 PC, revision 67377

fix overwrite of upper left part of parent window with sunken/raised border, fixes #13072

2011-04-02 18:38 VZ, revision 67376

No real changes, just some more minor cleanup in wxSVGFileDC. Harmonize spaces, remove unnecessary semicolons, remove useless return statements from void functions.

2011-04-02 18:38 VZ, revision 67375

Remove wxSVG_DEBUG from wxSVGFileDC. Remove the weird wxSVG_DEBUG which could apparently be used to trace the code execution by triggering asserts in all functions. This is really not the right way to implement tracing and seems pretty useless, just remove it.

2011-04-02 18:37 VZ, revision 67374

Clean up of string operations in wxSVGFileDC code. Use operator+=() instead of "s = s + ...". See #13086.

2011-04-02 18:37 VZ, revision 67373

Add support for alpha channel in colours in wxSVGFileDC. Use stroke-opacity and fill-opacity SVG attributes to handle pens and brushes created from colours with alpha channel in wxSVGFileDC. Closes #13086.

2011-04-02 18:37 VZ, revision 67372

No changes, just merge some strings in wxSVGFileDC. Concatenate string literals at compile-time instead of run-time. See #13086.

2011-04-02 18:37 VZ, revision 67371

Use wxPENSTYLE_XXX and wxBRUSHSTYLE_XXX instead of wxXXX constants. Use non-deprecated constants in wxMSW wxGC code. Closes #13109.

2011-04-01 18:20 PC, revision 67368

build fix for GTK1 after r67299

2011-03-31 19:22 JMS, revision 67365

Added wxComboPopup::DestroyPopup(), which responsibility is to call Destroy() for the popup control and also delete the combo popup object itself. The default implementation should be able to handle common cases.

2011-03-31 15:11 JS, revision 67363

Buffer size calculation correction

2011-03-31 15:10 JS, revision 67362

Buffer size calculation correction

2011-03-31 12:52 JJ, revision 67361

Update configuration for OpenVMS

2011-03-31 12:08 VZ, revision 67360

Compilation fix for wxUSE_STL==1 build after r67356. An explicit conversion to char* is required in wxUSE_STL build.

2011-03-31 11:38 VZ, revision 67359

Implement wxGraphicsContext::GetSize() for Cairo. As the implementation of this method is basically the same for all ports move it to the base class itself instead of requiring the derived classes to implement it. Now the derived classes need to fill in m_width and m_height members instead. Do fill them when creating wxGraphicsContext in Cairo version.

2011-03-31 11:37 VZ, revision 67358

Tentative compilation fix for wxMSW with MinGW after STL changes. Include wx/stack.h, which includes the standard <stack> header, before <windows.h> as the latter redefines min and max as macros conflicting with the standard headers.

2011-03-31 11:28 VZ, revision 67357

Add wx/msw/panel.h to the list of wxMSW headers in bakefile. Also move src/msw/panel.cpp to the list of normal wxMSW sources from the list of low-level ones as it's not needed by wxUniv. Closes #13103.

2011-03-31 11:28 VZ, revision 67356

Fix alpha handling in CSS syntax in wxColour in non-"C" locale. Use locale-independent functions to parse and generate the floating point alpha representation in CSS syntax for colours to make it work in locales which don't use period as decimal separator. Closes #13077.

2011-03-31 11:28 VZ, revision 67355

Fix HMENU to wxMenu translation in wxMSW code. We didn't find the menus corresponding to the submenu handles. This resulted in incorrect processing of EVT_UPDATE_UI events for the submenus and probably other problems. Fix this by searching for the HMENU recursively in all menus. Closes #13080.

2011-03-31 11:28 VZ, revision 67354

Document unexpected wxWindowDisabler taskbar UI in wxMSW. It may be unexpected that the application can still be closed from the taskbar even if its main window is disabled. Mention this in the documentation and indicate how to prevent this from happening if required. Closes #13081.

2011-03-31 11:28 VZ, revision 67353

Correct wxGraphicsContext::StrokeLines(n, points) documentation. This method draws a single polyline. Closes #13099.

2011-03-31 10:19 DS, revision 67352

Moved mention of buffer overrun fix from 2.8.12 to 2.8.13 section because it was too late for 2.8.12.

2011-03-30 16:16 VZ, revision 67347

Remove REMOVE_UNUSED_ARG option from setup.h files. This identifier wasn't used anywhere as WXUNUSED() is always defined as nothing for all compilers since quite some time. Also moved wxUSE_IOSTREAMH together with the other wxUSE_STD_XXX options and removed the "compiler (mis)features" section which became empty after doing this.

2011-03-30 16:16 VZ, revision 67346

Add support for elements preceding the document node in wxXML. This is mainly useful for parsing and generating processing instructions but can be used for any kind of elements, e.g. also comments, occurring before the document node in XML documents. Closes #11593.

2011-03-30 16:16 VZ, revision 67345

Fix memory leaks in wxXml unit test. Ensure that the root wxXmlNode is deleted by storing it in a wxScopedPtr instead of a raw pointer. See #11593.

2011-03-30 16:16 VZ, revision 67344

Always update internally stored AUI floating frame position. Update the internally stored position of a floating AUI frame even if the user is dragging it too fast to update its position on screen. This prevents the frame from snapping back to the initial position when movement is over. Closes #13014.

2011-03-30 16:16 VZ, revision 67343

Add wxUSE_STD_CONTAINERS and turn it on by default. Previously, wxUSE_STL enabled both implicit conversion of wxString to std::[w]string and use of standard containers for the implementation of their wx equivalents. Split up the two roles now by allowing to enable the use of the standard containers independently of (backwards incompatible) implicit conversion in wxString and actually enable wxUSE_STD_CONTAINERS by default.

2011-03-30 16:15 VZ, revision 67342

Fix XTI compilation in STL build. Use explicit c_str() calls in XTI code as implicit conversion to "const char *" doesn't exist in STL build. This fixes compilation problems when wxUSE_EXTENDED_RTTI && wxUSE_STL. Closes #13087.

2011-03-30 11:26 DS, revision 67341

Tagged 2.8.12 release

2011-03-30 07:59 PC, revision 67339

build fix for older GTK2

2011-03-30 07:35 PC, revision 67338

convert assertdlg_gtk to C++

2011-03-30 07:29 PC, revision 67337

prepare to convert file to C++

2011-03-29 20:40 SC, revision 67336

fix clang warning (? having two different operand types)

2011-03-29 19:49 PC, revision 67335

must use deprecated function for gtk2

2011-03-29 07:29 PC, revision 67334

don't crash on error

2011-03-29 07:17 PC, revision 67333

build fix

2011-03-29 07:16 PC, revision 67332

fix typo

2011-03-29 07:15 PC, revision 67331

GTK_WIDGET_SENSITIVE should have been converted to gtk_widget_get_sensitive

2011-03-28 16:10 VS, revision 67328

wxDataViewChoiceRenderer's editor control should have the same size as the cell. It looks weird when it's significantly shorter than the content cell being edited.

2011-03-28 08:27 PC, revision 67326

avoid deprecated functions and direct struct access

2011-03-27 21:38 PC, revision 67324

yet more avoiding direct struct access

2011-03-27 20:41 PC, revision 67321

add more functions we will need

2011-03-27 20:30 JMS, revision 67320

Instead of just deleting m_popupInterface, call Destroy() of its wxWindow-based popup control obtained via GetControl() member function. Also still delete m_popupInterface if there was no popup control, or if it was implemented as a separate class (versus being multiple-inherited along side wxComboPopup, as has been the common practice).

2011-03-27 19:23 VS, revision 67319

Always use gtk2-compat.h definitions. We support building against newer GTK+ version and using an older one at runtime, so we must provide our implementations of these functions even if GTK_CHECK_VERSION would indicate the function is already available in GTK+.

2011-03-27 19:23 VS, revision 67318

Renamed wx/gtk/private/compat.h to gtk2-compat.h.

2011-03-27 09:17 PC, revision 67317

more avoiding direct struct access

2011-03-27 08:51 PC, revision 67316

remove unused mouse event and redundant checks

2011-03-27 08:38 PC, revision 67315

a few changes for gtk3, avoiding direct struct access

2011-03-26 19:09 VS, revision 67313

Compilation fix for r67312: add explicit cast to GtkStateType.

2011-03-26 16:49 VS, revision 67312

Use accessor functions instead of deprecated GTK+ macros.

2011-03-25 17:42 JS, revision 67311

Fix for image saving speedup

2011-03-25 17:41 JS, revision 67310

Fix for image saving speedup

2011-03-25 16:08 VS, revision 67308

Don't use deprecated gtk_widget_ref().

2011-03-25 12:00 VS, revision 67307

Revert r67137. GTK_DISABLE_SINGLE_INCLUDES causes trouble with other included libraries (libgnomeprint this time) too. This check for trivially fixed problems is not worth the continuing trouble. Fixes #13078.

2011-03-24 18:53 JS, revision 67306

wxRTC image writing speedup didn't make it into 2.8.12

2011-03-24 17:52 PC, revision 67305

fix tool item enter/leave notify, fixes #13083

2011-03-24 17:08 VZ, revision 67304

Set m_inheritBgCol flag in wxPanel with a background bitmap. This ensures that the panel background is used by its transparent children under wxMSW even when the panel itself is inside a wxNotebook with themed background: making InheritsBackgroundColour() return true prevents the notebook from overriding our background.

2011-03-24 11:59 JS, revision 67303

Speeded up image saving to XML (WriteHex).

2011-03-24 11:58 JS, revision 67302

Speeded up image saving to XML (WriteHex).

2011-03-23 18:37 PC, revision 67299

move deprecated GtkTooltips forward declaration to one place that still needs it

2011-03-23 18:36 PC, revision 67298

clean up wxGTK tooltip code

2011-03-23 16:22 DS, revision 67297

backported r67296. ( Fixed buffer overflow when saving certain images in the Windows icon format. When an image did not have a width with a multiple of 4 the calculations for the number of padding bytes (to get a scan line DWORD aligned) would be wrong. This caused a buffer overrun when saving the 1 bits per pixel mask. See #12937. )

2011-03-23 16:20 DS, revision 67296

Fixed buffer overflow when saving certain images in the Windows icon format. When an image did not have a width with a multiple of 4 the calculations for the number of padding bytes (to get a scan line DWORD aligned) would be wrong. This caused a buffer overrun when saving the 1 bits per pixel mask. Fixes #12937.

2011-03-23 14:57 VS, revision 67295

Only react to clicks on the checkbox in wxDataViewToggleRenderer. Previously, left click anywhere in the cell toggled the checkbox. This was unexpected when the cursor was far from the checkbox in a wide column. With this change, one has to be over the checkbox to toggle it.

2011-03-23 13:59 VZ, revision 67294

Add WXK_CONTROL_A..WXK_CONTROL_Z constants. These key codes provide nicer symbolic values for ASCII values in 1..26 range generated by Ctrl+Letter keys. Closes #13075.

2011-03-23 11:37 VZ, revision 67293

Prevent event generation in wxGtkCalendarCtrl::SetDate(). Block not only gtk_day_selected_callback() but also gtk_month_changed_callback() as we don't want wxEVT_CALENDAR_PAGE_CHANGED generated neither when calling SetDate(). This fixes partial resetting of the just set value in wxDatePickerCtrl as calling SetDate() there resulted in the date being reset from inside it and the behaviour of the control was clearly wrong as could be seen in the widgets sample. Closes #13073.

2011-03-23 11:37 VZ, revision 67292

Use correct month in the date picker page of the widgets sample. Months returned by wxDateTime::GetMonth() start from 0 while people mostly expect to have 1-based months in the UI.

2011-03-22 20:13 VS, revision 67290

Fix <object_ref> processing to respect overridden attributes. r60494 accidentally broke this, by adding faster code path for child-less <object_ref>s. Unfortunately, this made it ignore <object_ref>s without children, but with attributes overrides. Fixes #13061.

2011-03-22 19:44 SC, revision 67289

wiring notifications

2011-03-22 18:15 VZ, revision 67288

Add wxUSE_THREADS checks around wxMSW functions dealing with threads. This removes the code unneeded in wxUSE_THREADS==0 build and also fixes compilation of wxGUIAppTraits::WaitForThread() which didn't compile any more with wxUSE_THREADS==0 since r67185. Closes #13050.

2011-03-22 18:15 VZ, revision 67287

Don't consider fully opaque bitmaps as having alpha in wxMSW. Remove the alpha channel from the DIB we create not only if all of its pixels are fully transparent but also if they are all fully opaque. This prevents us from erroneously creating bitmaps with alpha channel when none is needed nor expected. Closes #13056.

2011-03-22 18:15 VZ, revision 67286

Add wxText{Input,Output}Stream::Get{Input,Output}Stream() methods. These methods simply return the underlying low-level stream. See #10807.

2011-03-22 18:15 VZ, revision 67285

Post size events to the event handler and not window itself. Post the artificial wxSizeEvent to the window event handler and not window itself in SendSizeEvent() as otherwise any event handlers wouldn't see this event at all. Closes #13066.

2011-03-22 18:15 VZ, revision 67284

Use disabled version of normal bitmap for disabled one in wxMSW::wxButton. Initialize the disabled button bitmap with a greyed out version of the normal one instead of using the same normal bitmap for it. This is more consistent with the other ports and makes more sense. Closes #13070.

2011-03-22 17:40 SC, revision 67283

first version of osx_cocoa implementation

2011-03-22 17:39 SC, revision 67282

only remove from parent if not content view, fixes #13068

2011-03-22 16:07 VZ, revision 67281

Correctly align background brush when erasing owner drawn bitmaps in wxMSW. Add a hack to work around the problem with background alignment when drawing the owner-drawn buttons in wxMSW. This fixes the alignment for any custom brushes used for background painting but doesn't help with user-defined EVT_ERASE_BACKGROUND handlers which still don't work well with the owner-drawn buttons. Unfortunately DrawThemeParentBackground() remains a mystery and I couldn't understand why not only doesn't it position the DC correctly on its own but also ignores any attempts to do it manually. This also doesn't help with the stubbornly remaining one pixel non-transparent border around non-owner-drawn buttons which I just can't get rid of.

2011-03-22 15:17 DS, revision 67280

Fixed various typos. Applied patch by snowleopard2 fixing a bunch of typos such as misspellings and double words in the documentation. Combined the patch with some local queued typos waiting to be committed as well as adding new typo fixes inspired by the patch. Function names with American spelling were not changed nor was third-party code touched. The only code changes involve some changes in strings that are translated ("Can not" -> "Cannot"). Closes #13063 (again).

2011-03-22 15:08 BP, revision 67279

Extensive documentation typo patch (closes #13063).

2011-03-22 15:06 DS, revision 67278

No code changes, removed tabs from source file.

2011-03-22 11:57 JJ, revision 67277

Update OpenVMS makefiles for WXMARKUP

2011-03-22 10:56 JMS, revision 67276

To have better support for themed and custom backgrounds for wxMSW wxComboCtrl, use WS_EX_COMPOSITED and wxBG_STYLE_ERASE instead of custom double-buffering (when made possible by the OS version)

2011-03-22 09:59 JMS, revision 67275

In wxComboCtrlBase::DrawButton(), let the button background rendering changes also apply to buttons with user-defined bitmaps

2011-03-22 09:45 JMS, revision 67274

Added entry for recent wxComboCtrl background rendering changes

2011-03-22 08:10 SC, revision 67273

fixes #13064

2011-03-22 07:44 SC, revision 67272

fixes #12579

2011-03-21 12:00 VZ, revision 67269

Fix wxMSW build without PCH after recent wxPanel changes. Add missing include of wx/bitmap.h in !WX_PRECOMP case. Closes #13060.

2011-03-21 11:59 VZ, revision 67268

Allow using milliseconds in wxLog timestamp. Use wxDateTime::UNow() instead of time() and wxDateTime::Format() instead of localtime() to make it possible to use "%l" specifier in wxLog time stamp. Closes #13059.

2011-03-20 23:33 VZ, revision 67267

Added a simple example of semi-transparent window to the erase sample. Show how to create a custom control with transparent background. Notice that this doesn't work in wxGTK currently.

2011-03-20 23:33 VZ, revision 67266

Remove keyboard-related code from the erase sample. This code seems irrelevant in this sample and just complicates it unnecessarily.

2011-03-20 23:33 VZ, revision 67265

Don't draw the mysterious black rectangle in the erase sample. The black rectangle drawn in EVT_PAINT handler in the sample prevented the custom background from showing through the wxStaticBitmap. Maybe it was initially done intentionally but this makes the sample look broken so just don't do this.

2011-03-20 20:48 DS, revision 67264

Made some TIFF reading adjustments. Read a few TIFF tags that assist with having a similar TIFF file when saving the image again, instead of (by default) always saving as a 24-bit RGB image. Also, in accordance with libtiff, allow reading X and Y resolution values even if the resolution unit tag is not set. Applied (modified) patch by scottb. Closes #13015.

2011-03-20 13:27 JS, revision 67259

Removed ugly black (simple) border around wxHTML help window in wxGTK.

2011-03-20 12:50 VZ, revision 67258

Fix test for wxHAS_GENERIC_PANEL for PCH-less build. wxHAS_GENERIC_PANEL is only defined in wx/panel.h so test for it after including this file, not before. This fixes link errors due to missing wxPanel symbols in PCH-less builds.

2011-03-20 12:50 SC, revision 67257

spinctrl on mac is generic, so the peer is a userpane, fixes #13058

2011-03-20 12:15 JMS, revision 67256

Added wxComboCtrlBase::m_hasTcBgCol. Re-using base wxWindow::m_hasBgCol was trouble.

2011-03-20 11:59 JMS, revision 67255

Redone (generic) wxComboCtrl background painting and handling. The 'actual' wxWindow background colour is now largely ignored and overridden to refer the text-area's background colour instead (as is usually the case with controls like this). Base 'transparent' background is now only painted when double-buffered rendering is required, and otherwise delegated to the system, as appropriate. This should significantly improve control's appearance and compliancy with GTK+ and OS X themes and custom backgrounds.

2011-03-20 01:14 DS, revision 67254

No changes, synchronised source names that appear commented at the top of files with the actual path to the files. Fixed commented names (path, filename, and extension) of files in include/ and src/. Prepended the names in src/ with "src/" everywhere, while starting those in include/wx/ with "wx/".

2011-03-20 01:00 VZ, revision 67253

Add wxPanel::SetBackgroundBitmap(). This method provides a simple way to set a background bitmap without defining an EVT_ERASE_BACKGROUND handler and, more importantly, one that works correctly in wxMSW for a window with children as it paints the background of transparent children too. Add a test of this method to the erase sample.

2011-03-20 01:00 VZ, revision 67252

Deprecate old style wxPanel ctor taking separate coordinates. wxPanel had a ctor in very old (wx 1.x-compatible?) style which was marked as "old" and not documented but not officially deprecated. Do deprecate it now in view of removing it in later releases.

2011-03-20 01:00 VZ, revision 67251

Split wxPanel in wxPanelBase and platform-specific files. So far we have only wxMSW-specific implementation (and also a trivial wxUniv-specific one) but it's still tidier to have all platform-specific code in separate files, especially as we're going to have more of it for wxMSW soon.

2011-03-20 01:00 VZ, revision 67250

No changes, just refactor wxMSW background brush methods. Factor out MSWGetCustomBgBrush() from MSWGetBgBrushForChild(). This is useful as in the vast majority of cases the parent window will want to use the same background brush for all of its children so it doesn't really care about the concrete child passed to MSWGetBgBrushForChild() and we can adjust the brush to the child origin in the common code instead of asking each derived class overriding MSWGetBgBrushForChild() to do this. This doesn't change anything but will make the upcoming changes to wxPanel background painting simpler.

2011-03-19 21:35 JS, revision 67249

Applied #13055: socket thread safety

2011-03-19 13:29 JS, revision 67248

Document wxRTC XML performance fix

2011-03-19 13:27 JS, revision 67247

Fix very poor performance on wxGTK when loading a lot of paragraphs with fonts due to pango calls in font accessors called from FindOrCreateFont.

2011-03-19 12:57 VZ, revision 67246

Fix wxRegKey::GetKeyInfo() output parameters in 64 bit builds. Use intermediate 32 bit DWORD variables for ::RegQueryInfoKey() outputs as size_t is 64 bit in 64 bit MSW builds and so the variables of type size_t can't/shouldn't be passed directly to this function to avoid only filling their lower 32 bits. Closes #11778.

2011-03-19 12:57 VZ, revision 67245

Slightly improve wxMouseCaptureLostEvent documentation. Minor changes to make the event description more clear. Closes #13052.

2011-03-19 12:57 VZ, revision 67244

Document wxPopupTransientWindow. Also fix a typo in a comment in the real class declaration. Closes #13044.

2011-03-19 09:36 SC, revision 67243

going private with userpane info

2011-03-18 23:22 DS, revision 67240

Fixed documentation of enum wxImageResizeQuality. A C-style comment was not closed and resulted in the explanation of wxIMAGE_QUALITY_NORMAL additionally containing the explanation of wxIMAGE_QUALITY_BOX_AVERAGE and the latter having none. Regression since r67203.

2011-03-18 16:45 SC, revision 67233

moving userpane attribute into implementation

2011-03-18 16:10 DS, revision 67232

Set svn properties on various files throughout the repository (skipped docs/ ). Added missing svn:eol-style (set to native) and svn:keywords (set to Id) properties to c/cpp/cxx/h/mm files.

2011-03-18 15:33 SC, revision 67231

going private for m_peer to give a foundation for better encapsulation

2011-03-18 15:20 SC, revision 67230

going private for m_peer to give a foundation for better encapsulation

2011-03-18 10:16 VZ, revision 67229

Fix exporting clipboard data to primary selection in wxGTK. Honour the requested selection in our selection handler instead of always returning the default one resulting in wrong data being pasted when using primary selection (e.g. middle clicking). Closes #12947.

2011-03-18 10:16 VZ, revision 67228

Add wxHtmlHelpController::SetShouldPreventAppExit(). Add a method which can be used to indicate that the help window should prevent the application from exiting and use it in the help sample to prevent it from closing prematurely. Closes #13046.

2011-03-18 10:16 VZ, revision 67227

Limit the search in wxMSW virtual wxListCtrl by time. Instead of performing the search only up to a certain number of items, do it for as long as it takes less than the given time threshold (currently fixed at half a second). Closes #13038.

2011-03-18 08:16 JJ, revision 67226

Update configuration for OpenVMS

2011-03-17 12:35 VZ, revision 67224

Add a wxStaticText to the erase simple. This control explains better what is going on in the sample and also allows to test whether wxStaticText itself has properly transparent background (this is not currently the case under MSW).

2011-03-17 10:46 JS, revision 67223

Fixed problems caused by duplicated names across different style types.

2011-03-17 10:23 JS, revision 67222

Fixed problems caused by duplicated names across different style types.

2011-03-16 20:16 SC, revision 67221

adding missing newline at end of file

2011-03-16 14:15 SC, revision 67220

removing condition that is always true anyway (unsigned>=0)

2011-03-16 13:46 DS, revision 67219

Added support for reading image resolutions from PNG images. Patch by scottb. Closes #12893.

2011-03-16 11:58 SC, revision 67218

fixing unused params

2011-03-16 11:57 SC, revision 67217

always skip OnSize

2011-03-16 11:56 SC, revision 67216

calling explicit base class constructor from copy constructor

2011-03-16 11:55 SC, revision 67215

calling explicit base class constructor from copy constructor

2011-03-16 08:22 SC, revision 67214

replace usage of objective-c keyword 'id'

2011-03-16 08:18 SC, revision 67213

fixing iterator use

2011-03-16 08:16 SC, revision 67212

replace usage of objective-c keyword 'id'

2011-03-16 08:06 SC, revision 67211

replace usage of objective-c keyword 'id'

2011-03-16 08:00 SC, revision 67210

replace usage of objective-c keyword 'id'

2011-03-16 07:57 SC, revision 67209

making conversion explicit silences deprecation warning

2011-03-16 07:49 SC, revision 67208

signed/unsigned warning fix

2011-03-16 07:40 SC, revision 67207

signed/unsigned warning fix

2011-03-16 07:36 SC, revision 67206

replace usage of objective-c keyword 'id'

2011-03-16 07:34 SC, revision 67205

silence incorrect warning about missing return value

2011-03-15 21:21 SC, revision 67204

fixing iphone build

2011-03-15 17:42 DS, revision 67203

Changed behaviour of wxImageResizeQuality parameter in wxImage.Scale and wxImage.Rescale. Made the following changes: * Formerly specifying to resize using wxIMAGE_QUALITY_BICUBIC or wxIMAGE_QUALITY_BILINEAR could result in the ResampleBox method being used. Now always resize with the method that the user actually specified. * Added wxIMAGE_QUALITY_BOX_AVERAGE to explicitly allow resizing with the ResampleBox method. * Previously wxIMAGE_QUALITY_HIGH was equal to wxIMAGE_QUALITY_BICUBIC. It has been changed to use wxIMAGE_QUALITY_BOX_AVERAGE when reducing the size of an image and wxIMAGE_QUALITY_BICUBIC in all other cases. Closes #12845.

2011-03-15 17:37 DS, revision 67202

Changed wxImage.ResampleBox to always use a box size of at least 2 by 2 pixels. Previously when resizing by more than 50% (for example resizing from 100x100 to 51x51 or 140x140) a box size of 1x1 would be used which effectively would give the same result as using nearest neighbour. Make sure that at least a box size of 2x2 pixels is always used. Patch by scottb, see also #12845.

2011-03-15 12:10 VZ, revision 67201

Always use icons with wxToolbook in the notebook sample. wxToolbook asserts and doesn't work if it has no images so always use them with it in the sample to avoid it. Closes #11656.

2011-03-15 12:10 VZ, revision 67200

Use consistent sizes for all icons used in the button page of widgets sample. Explicitly pass wxART_BUTTON to wxArtProvider to ensure that all the icons are returned in the same size, otherwise they didn't look well and could result in an assert too, see #12909.

2011-03-15 12:10 VZ, revision 67199

Fix setting tooltips for generic wxSpinCtrl. Forward the tooltip set for the control to its subcontrols. Closes #9817.

2011-03-15 12:10 VZ, revision 67198

Document wxEVT_COMMAND_SLIDER_UPDATED in wxSlider documentation too. This even was only documented in wxCommandEvent documentation but not in wxSlider, mention it there too. Closes #12292.

2011-03-15 00:25 VZ, revision 67195

No changes, just clean up wxSVGFileDC code a little. Use literal strings instead of macros such as "newline", "space" and "semicolon" and also use wxColour::GetAsString() instead of reimplementing it. Closes #13037.

2011-03-14 12:55 VZ, revision 67192

Show wx{Note,Tool}book-specific styles in the notebook sample too. Demonstrate the use of styles such as wxNB_FIXEDWIDTH or wxTBK_HORZ_LAYOUT specific to particular controls and not only the ones common to all of them. Closes #13036.

2011-03-14 12:55 VZ, revision 67191

Don't generate wxEVT_CHAR_HOOK events while the mouse is captured. This prevents the parent TLW from interfering with the keyboard handling of the window that captured the mouse which very often needs Escape for itself to cancel the capture. In particular, this fixes the problems with Escape closing the entire dialog containing the controls instead of closing just the combobox drop down or a popup menu in wxMSW. Also modify wxGTK for consistency and update the documentation. Closes #12952.

2011-03-14 12:54 VZ, revision 67190

Document EVT_CHAR_HOOK. Explain that it is sent to the active TLW and not the focus window and that handling it suppresses all the normal keyboard events. Mention that it is not generated by wxOSX/Cocoa currently, see #12431.

2011-03-14 12:54 VZ, revision 67189

Don't intercept Escape key while IME is active. Escape is used by IME and intercepting it at wxWidgets level to generate EVT_CHAR_HOOK breaks the IME UI and may result in unexpected loss of data entered by user. To work around this, don't generate EVT_CHAR_HOOK for Escape while IME is active by checking for the special semaphore variable (which could be also used for other things in the future, see #9102) value. Closes #11386.

2011-03-14 12:54 VZ, revision 67188

Produce correct SVG files in all locales. Using wxSVGFileDC in locales using comma as decimal separator resulted in invalid SVG files being created as a decimal period should always be used in them. Fix this by replacing "%g" format specification with wxString::FromCDouble() call (wrapped in a convenient NumStr() helper function). Closes #12008.

2011-03-14 12:54 VZ, revision 67187

Fix changing the size of the bitmaps in wxMSW wxButton. The size of the wxImageList used to store the bitmaps wasn't updated before and so the old bitmap size continued to be used even after changing the actual bitmaps. Recreate wxXPButtonImageData to ensure that the image list size does change. Closes #12909.

2011-03-14 12:54 VZ, revision 67186

Print everything by default in non-interactive mode. IF we don't show the dialog allowing the user to select the pages range, we should print everything by default instead of printing nothing at all as we used to do. Closes #12998.

2011-03-14 12:54 VZ, revision 67185

Allow wxThread::Wait() and Delete() to block, even under wxMSW. Add "wait mode" parameter to these methods which can be used to make them block even under wxMSW where they currently dispatch messages when called which can be totally unexpected. Do keep the old behaviour for compatibility however, although it will change i 3.2. Closes #12998.

2011-03-14 12:54 VZ, revision 67184

Respect alignment flags for owner-drawn buttons in wxMSW. Honour wxBU_{LEFT,RIGHT,TOP,BOTTOM} flags for owner drawn buttons too, this ensures that you can both change the colour and align the text differently for buttons under XP and later. Closes #12995.

2011-03-14 11:27 JS, revision 67183

Added initialisation and checks

2011-03-14 11:27 JS, revision 67182

Added initialisation and checks

2011-03-13 14:53 VZ, revision 67181

Added precision parameter to wxString::From[C]Double(). Optionally support fixed precision in wxString::FromDouble() and FromCDouble() methods. This is mostly useful for the latter to be able to format numbers in portable way (using dot as decimal separator) without loss of precision but also do it for the former for consistency. Closes #12973.

2011-03-13 14:53 VZ, revision 67180

No changes, just correct a wrong trailing comment in #else. The test meaning was inverted.

2011-03-13 14:33 VZ, revision 67179

Document wxTE_MULTILINE support in wxTextEntryDialog. It wasn't immediately obvious that this dialog could be used for multiline text entry too so mention it explicitly in the documentation. Also show this in action in the dialogs sample.

2011-03-13 10:32 JMS, revision 67178

wxComboCtrl and wxOwnerDrawnComboBox had incorrect (edge) background colour under some GTK+ themes

2011-03-12 16:57 SC, revision 67174

add external utf16 text type explicitely, as it otherwise gets treated like plain-text

2011-03-12 16:19 PMO, revision 67173

Move/Position the controls after they have been created

2011-03-12 16:05 PMO, revision 67172

Added QtTest library and '-fmessage-length=0' for easier error parsing

2011-03-11 20:54 SC, revision 67170

supporting 24 and 64 sizes via scaling up

2011-03-10 19:56 SC, revision 67168

under cocoa a too-small static box leads to erroneous layout information, therefore use fixed code layout info, fixes #13006

2011-03-10 19:55 SC, revision 67167

safeguard against not-yet-shown view which leads to crashes under OSX

2011-03-09 18:22 PC, revision 67164

add wxEVT_MAXIMIZE support to wxGTK

2011-03-09 17:35 VZ, revision 67163

Make brush hatches in wxGTK consistent with wxMSW. The cross, vertically and horizontally hatched brushes used 4 pixels between the hatches in wxGTK but 7 in wxMSW which was very noticeable. Use the same pattern in wxGTK as MSW uses (as we can't change it there anyhow). Closes #13029.

2011-03-09 17:35 VZ, revision 67162

Correct the name of the header for GTK+ < 2.14. Remove the extra ".h" suffix added during recent GTK+ 3-related changes.

2011-03-09 17:35 VZ, revision 67161

Add tests of other hatched brushes to the drawing sample. Test wxCROSS_HATCH, wxVERTICAL_HATCH and wxHORIZONTAL_HATCH brushes and not only the wxCROSSDIAG_HATCH one. See #13029.

2011-03-09 17:35 VZ, revision 67160

Don't pop up annoying message box in the drawing sample. The rubber banding selection message box was shown even after a simple click, i.e. when nothing was actually selected which was quite annoying, so don't do this. Also remove unnecessary casts and use wxLogMessage() instead of wxString::Printf() + wxMessageBox().

2011-03-09 11:07 VZ, revision 67159

Corrections to wxTextCtrl::HitTest() documentation. Fix the signature of the overload returning row and column which got corrupted during transition to Doxygen and document the overload returning the position as well. Also document all the parameters. Closes #12954.

2011-03-09 10:44 VZ, revision 67158

Send wxEVT_COMMAND_DATAVIEW_CACHE_HINT to proper window. The event was sent to wxDataViewCtrl parent instead of the control itself for some reason, fix this. Closes #13020.

2011-03-09 10:40 VZ, revision 67157

Mention that wxEVT_MAXIMIZE is only generated by a few ports. Currently only wxMSW, wxOSX/Cocoa and wxOS2 generate this event. Notably wxGTK does not. See #13022.

2011-03-09 10:40 VZ, revision 67156

Correct EVT_MAXIMIZE macro name in wxTLW documentation. EVT_ACTIVATE was mistakenly used instead. See #13022.

2011-03-09 10:28 VZ, revision 67155

Fix search for item by text in wxMSW wxListCtrl. LVN_ODFINDITEM handler could enter infinite loop if its selection was 0 and a key not matching any of the items first letters was pressed. Rewrite the loop in a simpler form to ensure that it is correct. Also clarify some comments. Finally, fix the behaviour when no matching item was found (if it didn't hang in infinite loop, it used to select the first item in the control). Closes #13026.

2011-03-09 10:28 VZ, revision 67154

Don't assert if starting search position in LVN_ODFINDITEM is invalid. Just use wxLogDebug() if this happens, asserting here is not the right thing to do as it doesn't indicate an error in the program but rather invalid external input and, moreover, we can recover from it easily. No changes in behaviour in normal case.

2011-03-08 18:22 VZ, revision 67151

Add another missing #if wxUSE_MARKUP check. The definition of DoSetLabelMarkup() should only be compiled when wxUSE_MARKUP==1.

2011-03-08 18:22 VZ, revision 67150

Czech translation update from Zbynek Schwarz. Fix some incorrect terms.

2011-03-08 15:47 JS, revision 67149

Fixed a hang in wxYield caused by menubar fix sending size events in a loop. Now only resizes the frame's contents if the menubar has changed height, to avoid triggering the loop.

2011-03-07 21:26 SC, revision 67146

support app activated and deactivated events, also bring back float_on_parent windows to normal level on deactivate to avoid behaving like stay_on_top

2011-03-07 20:04 SC, revision 67144

window level support

2011-03-07 18:31 SC, revision 67143

bracket unused function

2011-03-07 14:02 JMS, revision 67142

To prevent wxPropertyGrid from stealing frocus from other controls, only let SetFocusOnCanvas() move focus to the main grid 'canvas' if focus was already in on the grid's child controls

2011-03-07 13:07 VS, revision 67141

gtk/gtkunixprint.h only exists since GTK+ 2.14.

2011-03-06 19:22 VS, revision 67137

Don't directly include GTK+ semi-public headers. Only the main headers (e.g. gtk/gtk.h) should be included and GTK+ 3 is strict about this. Enable compile-time checks for this that work with GTK+ 2.24.

2011-03-06 19:22 VS, revision 67136

Include gdk/gdkkeysyms-compat.h. GTK+ 2.22 changed GDK_* keysym constants to GDK_KEY_* and introduced a new header for the old names. This header must be explicitly included in GTK+ 3, so do it for now. In the long run, we should migrate to the new names.

2011-03-06 16:27 SC, revision 67135

use FixedToFloat everywhere to make sure we don't round too early, preserve fractional width with CoreText as well

2011-03-06 16:24 SC, revision 67134

position buttons to the right on OSX as well

2011-03-06 15:49 SC, revision 67133

fix positioning bug with window disabler and hidden windows

2011-03-06 10:09 JS, revision 67132

Fixed #13017: wxRichTextCtrl CopyToClipboard regression

2011-03-05 20:57 PMO, revision 67131

Update to trunk r67129

2011-03-05 19:36 SC, revision 67130

merge error

2011-03-05 13:21 SC, revision 67129

support wxWindowDisabler on osx_cocoa

2011-03-05 12:16 VZ, revision 67128

Add a dependency of wxUSE_TASKBARICON on wxUSE_MENUS. PopupMenu() method of wxTaskBarIcon doesn't make much sense without wxMenu.

2011-03-05 12:16 VZ, revision 67127

Don't initialize wxGBSpan with invalid values in wxGBSizerItem. Default wxGBSizerItem ctor initialized wxGBSpan with invalid values which resulted in an assert when loading wxGBSizer from XRC since r66964. Fix this by simply using the default wxGBSpan ctor instead. Closes #13004.

2011-03-04 17:36 SC, revision 67125

fixing a CG error during construction on 10.6, resizing the client area so that the content doesn't extend over the shape's boundingbox at the right and the bottom

2011-03-03 22:24 PMO, revision 67121

Improved creation of controls

2011-03-03 18:51 PC, revision 67120

fix Activate signature after r67099

2011-03-03 16:09 JS, revision 67119

Fixed crash on exit caused by deleting old logger in wxLogChain dtor.

2011-03-02 22:17 SC, revision 67114

proper focus lost for multiline textfields and having all demanding a focusrect

2011-03-02 22:16 SC, revision 67113

the wx part knows better whether it has the focus (may be the embedded NSView, not the m_peer)

2011-03-02 21:55 JS, revision 67112

Fixed a problem with paste resetting the content paragraph style.

2011-03-02 21:55 JS, revision 67111

Fixed a problem with paste resetting the content paragraph style.

2011-03-02 17:23 SC, revision 67110

move accel handling in front of the normal keyDown handling, support non-command menu accels

2011-03-02 17:21 SC, revision 67109

move accel handling in front of the normal keyDown handling

2011-03-02 16:43 SC, revision 67108

supporting more key equivalents for display, fixing setHidden: method warning

2011-03-02 16:42 SC, revision 67107

removing code that will not have to be updated

2011-03-02 11:29 VZ, revision 67106

Japanese translations update from Suzumizaki-Kimitaka. See #13003.

2011-03-02 11:28 VZ, revision 67105

Japanese translations update from Suzumizaki-Kimitaka. Closes #11773. Closes #13003.

2011-03-02 11:28 VZ, revision 67104

Fix typo in wxStack<T> documentation. I somehow managed to misspell wxStack<T> as wxSort<>. Closes #13002.

2011-03-02 11:15 VZ, revision 67103

Add missing wxUSE_MARKUP checks in wxOSX code. Don't define wxWidgetImpl::SetLabelMarkup() when wxUSE_MARKUP is off and definitely don't reimplement it in wxButtonCocoaImpl as this code doesn't compile without markup support.

2011-03-01 22:29 DS, revision 67101

Improved palette handling with saving PNG files. Instead of converting alpha to a mask an attempt is made to write a palettised PNG file with an ARGB palette using a maximum of 256 transparency values where formerly just up to one was supported. GIF images with 256 colours and transparency can now also be saved as a palettised PNG instead of true colour, making the image a lot smaller. Applied (modified) patch by troelsk. Closes #12850.

2011-03-01 13:16 VS, revision 67099

Pass wxRect/wxPoint arguments to wxDataViewCustomRenderer by reference. Instead of passing them by value, use const reference. This change is safe to do, because these methods' signatures were different in 2.8 anyhow.

2011-03-01 13:16 VS, revision 67098

Fixed typo.

2011-03-01 01:02 VZ, revision 67095

Relax the restriction on the number of colours in wxMSW wxPalette. Refuse to create palettes with more than 65536 colours and not 256 ones. It doesn't seem very useful to use more than 256 of them anyhow as any colours above index 255 can't be accessed via GetRGB() but don't break the palette creation with more colours in the stable branch without a good reason, maybe someone makes some use of this.

2011-02-28 22:23 VS, revision 67094

Toggle checkboxes in generic wxDataViewCtrl with single click. Both GTK+ and OS X native controls use single click to toggle checkboxes, instead of double-click activation used by the generic version. So does wxCheckListBox on Windows, so make wxDVC behave the same way. See #11185.

2011-02-28 22:23 VS, revision 67093

Get rid of WXGetAsCustom(). Instead, have WXOnActivate() and WXOnLeftClick() with same signatures as their public API counterparts and just call Activate/LeftClick() from them for wxDataViewCustomRenderer. This accomplishes the same thing, but makes it easier to override behaviour in wx's internal implementations of renderers.

2011-02-28 22:23 VS, revision 67092

wxDataViewCtrl: Fully prepare renderer for Activate() call. Instead of just setting the value in the generic implementation, do full preparation (incl. attributes etc.) as everywhere else.

2011-02-28 20:46 SC, revision 67091

adding hour constant to carbon build

2011-02-28 20:29 SC, revision 67090

fixing non-precomp headers

2011-02-28 15:47 SC, revision 67088

disable cursorRects for global busy state

2011-02-28 15:39 SC, revision 67087

avoid setting live cursor during busy state

2011-02-28 14:44 SC, revision 67086

add watch cursor to osx_cocoa

2011-02-28 13:14 SC, revision 67085

don't swallow command events that are not handled by accels, fixes #12373

2011-02-28 11:12 SC, revision 67084

adding taskbar implementation for statusitem (menubar) and dock, fixes #12838

2011-02-28 11:10 SC, revision 67083

moving appdelegate declaration to header

2011-02-28 11:07 SC, revision 67082

make sure the quit item is only shown where appropriate on osx

2011-02-28 10:26 SC, revision 67081

osx_cocoa supports both kind of taskbaricons in the menubar (standard) and as function of the dock (type DOCK)

2011-02-27 21:38 SC, revision 67078

make sure 10.4 command-key events are routed via the wx-accelerator route as well, fixes #12373

2011-02-27 19:36 VZ, revision 67077

Use single quotes in wxMarkupText unit test to work around VC6 bug. VC6 seems to have a strange bug with escaped quotes used in strings passed to macros and failed to compile the original code with nonsensical error messages. Use single quotes to try to work around this issue. They are also somewhat more readable as they don't need to be escaped inside C strings.

2011-02-27 19:36 VZ, revision 67076

Add a trivial virtual dtor to wxMarkupParserOutput. This class isn't really supposed to be used polymorphically but add a virtual dtor just to suppress g++ warning about it.

2011-02-27 19:36 VZ, revision 67075

Another fix for PCH-less build in markup code. Include wx/control.h to use wxControl::RemoveMnemonics() and FindAccelInIndex().

2011-02-27 16:09 DS, revision 67074

Fixed drawing glitch with vertical MSW toolbars. In case of a certain amount of whitespace at the bottom of a vertical toolbar it would not be drawn correctly: the more whitespace the more painting would be clipped starting from the left (covering the whole height of the toolbar) until the toolbar would look completely empty. This was reproducible using the toolbar sample, setting the toolbar on the left or right edge of the window and then increasing the height of the window sufficiently. Regression since r62971.

2011-02-27 15:01 VZ, revision 67073

Replace template function with template class to placate VC6. VC6 has very poor support for template functions and in particular doesn't understand explicitly choosing the type of the function to call so replace template DoApplyToFont() function with FontModifier template class in wxMarkupParserAttrOutput implementation.

2011-02-27 14:17 VZ, revision 67072

Fix for PCH-less build in markup code. Include wx/log.h to use wxLogDebug().

2011-02-27 14:10 VZ, revision 67071

Refuse to create palettes with more than 256 colours. Creating palettes with more than USHRT_MAX could result in memory corruption and there is really no reason to allow more than 256 of them anyhow as we already check that the color index is in 0..255 range in GetRGB().

2011-02-27 13:48 VZ, revision 67070

Update markup support documentation. Mention that wxButton and wxStaticText now support markup in all major ports (using the generic version of the latter under MSW). Also mention markup changes in the change log.

2011-02-27 13:48 VZ, revision 67069

Add markup support to wxOSX/Cocoa wxStaticText and wxButton. Add wxMarkupToAttrString helper that converts wx markup to OS X attribute strings and use it in wxStaticText and wxButton. This required adding new SetLabelMarkup() method to wxWidgetCocoaImpl, it seems to make sense to have it there as it could be implemented by more controls in the future.

2011-02-27 13:48 VZ, revision 67068

No real changes, just make wxColour::OSXGetNSColor() const. There is no reason to not allow calling this method on const wxColour objects.

2011-02-27 13:48 VZ, revision 67067

Add markup support to generic wxStaticText implementation. wxMarkupText allows to easily support markup in the controls that we draw ourselves so use it in wxGenericStaticText to have a possibility to use markup on all platforms, even those where there is no native markup support in wxStaticText itself.

2011-02-27 13:48 VZ, revision 67066

Implement support for markup labels for wxGTK wxButton. Simply directly set the markup for the GtkLabel used by GtkButton internally.

2011-02-27 13:48 VZ, revision 67065

Add markup support to wxMSW wxButton and show it in the sample. Use recently added wxMarkupText to implement support for markup in wxMSW wxButton. Update the button page of the widgets sample to show markup support.

2011-02-27 13:48 VZ, revision 67064

Add generic wxMarkupText class implementing handling of markup. wxMarkupText is a private class that implements generic handling of markup strings, i.e. can measure them and render them onto a wxDC. This class will be used for markup support in wxMSW wxButton. Also add wxMarkupParserAttrOutput which will be useful for other wxMarkupText implementations.

2011-02-27 13:48 VZ, revision 67063

Add wxDC::GetFontMetrics() and implement it for wxMSW. Add a new wxDC method allowing to retrieve the font characteristics not available from GetTextExtent(), notably the internal leading (and also the average font width). Currently this is implemented for wxMSW only, the internal leading is always 0 in the other ports.

2011-02-27 13:48 VZ, revision 67062

Add wxUSE_MARKUP and wrap SetLabelMarkup() in it. Make it possible to disable all the new markup-related code by setting wxUSE_MARKUP to 0 in setup.h or using configure --disable-markup option.

2011-02-27 13:47 VZ, revision 67061

No changes, just add a couple of #if wxUSE_COMMANDLINKBUTTON tests. Don't even declare m_chkCommandLink if we have no support for command link buttons in the library.

2011-02-27 13:47 VZ, revision 67060

Draw the underline 1 pixel higher in wxDC::DrawLabel(). Adjust the height of the underline to be compatible with native MSW behaviour. Notice that in wxGTK we should use pango_font_metrics_get_underline_position() to get the font-dependent value that should be used here.

2011-02-27 13:47 VZ, revision 67059

Restore height tweaking in wxMSWButton::GetFittingSize(). The change of r66893 was wrong, we do need to adjust the button height here because the increase to standard height is not enough if we use bigger fonts that require making taller buttons. The real problem was the use of EDIT_HEIGHT_FROM_CHAR_HEIGHT() which added too much to the height, so replace it with something based on the actual font height. This is still arbitrary but slightly better.

2011-02-27 13:47 VZ, revision 67058

Initialize wxButton::m_authNeeded in ctor and not Create() in wxMSW. Ensure that the member is always initialized as calling GetAuthNeeded() for a default-constructed button would access a non-initialized variable before.

2011-02-27 13:47 VZ, revision 67057

No changes, just do wxButton fields initialization in Init() in wxMSW. Add a helper function called from ctors and initialize m_imageData in it instead of doing it in each ctor -- this will be more important when we add more wxButton members.

2011-02-27 13:47 VZ, revision 67056

No changes, just move wxMSW wxButton::MakeOwnerDrawn() around. Put this method in the existing private section at the end of the class instead of having an extra access specifier just for it for some reason. Also add a comment explaining what it does and when is it used.

2011-02-27 13:47 VZ, revision 67055

Replace wxST_MARKUP style with wxControl::SetLabelMarkup(). This is an incompatible change which removes the wxStaticText-specific wxST_MARKUP style and adds wxControl::SetLabelMarkup() replacing it. It doesn't actually change anything yet but it simplifies wxStaticText code a lot by getting rid of many markup-related functions in it which had to behave differently depending on whether wxST_MARKUP was used or not and also paves way for adding markup support for the other controls in the future.

2011-02-27 13:47 VZ, revision 67054

Don't call base class SetLabel() from GTKSetLabelForLabel(). Calling wxControlBase::SetLabel() only from GTKSetLabelForLabel() made its behaviour inconsistent with GTKSetLabelWithMarkupForLabel() and also was redundant in all but two places from which it was called, so remove this call from this function itself and instead add it to its callers where it's really needed.

2011-02-27 13:47 VZ, revision 67053

Remove unnecessary use of RemoveMarkup() in wxMSW wxHyperlinkCtrl. Only the ampersands need to be escaped when setting the text of a native hyper link control in MSW and this is done by wxControl::EscapeMnemonics(), not by wxStaticText::RemoveMarkup() which also removes any tags which is not wanted at all here.

2011-02-27 13:47 VZ, revision 67052

Add wxFont::SetSymbolicSize() and SetSymbolicSizeRelativeTo(). These methods allow to set the font size using CSS-like absolute size specifications. Notice that the factors used here are incompatible with (but better than) the ones used in wxBuildFontSizes() in src/html/winpars.cpp. In the future it would be nice to reuse the new wxFont functions in wxHTML code.

2011-02-27 13:46 VZ, revision 67051

Add wxFont::Underlined() and MakeUnderlined() methods. Add two more helpers for consistency with the existing methods such as Bold() and MakeBold().

2011-02-27 13:46 VZ, revision 67050

Use wxMarkupParser in wxStaticText for dealing with markup. No real changes, just remove markup parsing code from wxStaticText implementation and reuse wxMarkupParser methods there instead. This makes include/wx/private/stattext.h file unnecessary as it is used only in a single place now so remove it and move its remaining contents to src/gtk/mnemonics.cpp.

2011-02-27 13:46 VZ, revision 67049

Add wxMarkupParser::Strip(). This helper function strips all markup tags from the string (and also decodes the XML entities in it).

2011-02-27 13:46 VZ, revision 67048

Add a class for parsing simple markup. This code is not used anywhere yet, this commit only adds the parser for the markup and the related classes as well as the corresponding unit test.

2011-02-27 13:46 VZ, revision 67047

Add a simple wxStack<> template class based on wxVector<>. This is still simpler than std::stack<> which can be used with any container and not just wxVector<> but better than the WX_DECLARE_STACK() macro which was all that we had before.

2011-02-27 13:45 VZ, revision 67046

Disable NumValidatorTestCase::Interactive() for build bot slaves. This test consistently fails on the MSW build slave machines (see e.g. http://buildbot.tt-solutions.com/wx/builders/XPSP2 VC9 wxMSW trunk release/builds/2084/steps/test/logs/stdio) for unknown reason so disable it for them. Notice that it does pass when ran locally so it looks like another instance of a problem with wxUIActionSimulator on these machines rather than the problem with the class itself.

2011-02-27 13:45 VZ, revision 67045

Only use wxBU_EXACTFIT for width calculations in wxMSW wxButton. wxBU_EXACTFIT should affect the width of the button best size but not its height which should be at least the same as the height of a standard button even when wxBU_EXACTFIT is specified, otherwise buttons created with it (like the one in generic wxCollapsiblePane implementation) look completely ugly. This commit restores the old behaviour which was recently changed by wxButton sizing code simplifications.

2011-02-27 13:45 VZ, revision 67044

Specify correct size for disabled image list in wxMSW wxToolBar. Use the real bitmap size instead of the default tool size when creating the disabled image list as the actual bitmap size could be less than the default one and in this case adding images to the image list later would fail (as could be seen by using custom bitmaps in the toolbar sample).

2011-02-27 09:51 JMS, revision 67043

Include image.h and check for wxUSE_IMAGE

2011-02-27 09:16 JS, revision 67042

Change log for wxRTC fix

2011-02-27 09:15 JS, revision 67041

Applied #12986: Improved installation instructions for Mac OS X for 2.8.12 branch

2011-02-27 09:13 JS, revision 67040

Applied #12985: Improved installation instructions for wxWidgets for Mac OS X Cocoa and Carbon

2011-02-26 18:51 VZ, revision 67033

Fix libraries order in screenshotgen bakefile. The richtext library must come before the adv one as it depends on the classes in the latter and with the old libraries order linking failed in static build.

2011-02-26 18:46 VZ, revision 67032

Mention wxZlib classes in archives overview. Closes #12974.

2011-02-26 18:46 VZ, revision 67031

Don't use wxTE_PROCESS_ENTER in wxSpinCtrlGeneric. We don't need to catch Enter presses to generate spin control events as we do it anyhow when we lose focus. So simply remove the Enter handling code entirely (it could be used to generate wxEVT_COMMAND_TEXT_ENTER events but we don't generate them nor wxEVT_COMMAND_TEXT_UPDATED at all currently in the generic version). Closes #12980.

2011-02-26 18:46 VZ, revision 67030

Don't use wxTE_NOHIDESEL in wxSpinCtrlGeneric. There is no reason to use this flag for the spin control and doing it makes it gratuitously different from the native one under wxMSW.

2011-02-26 16:44 SC, revision 67029

fixing support for true children of wxStaticBox with wxStaticBoxSizer under osx_cocoa

2011-02-26 12:04 SC, revision 67028

making GetPosition 1:1 symmetrical to Move (respecting contentViews), fixing borderDrawing within NSBox

2011-02-25 18:28 JS, revision 67026

Fix for #11647: text from WriteText not scrolled to be visible in wxRichTextCtrl IsPositionVisible was incorrect.

2011-02-25 18:28 JS, revision 67025

Fix for #11647: text from WriteText not scrolled to be visible in wxRichTextCtrl IsPositionVisible was incorrect.

2011-02-25 14:00 JMS, revision 67024

In wxPGProperty::SetValueImage(), use wxImage::Rescale() for scaling down the bitmap instead of wx(Memory)DC functions. Results should look much nicer and also retains alpha channel with much less effert.

2011-02-25 13:25 JS, revision 67023

Applied patch in #12279: in wxRichTextCtrl, when wxRE_READONLY is set, the undo, redo function should be disabled

2011-02-25 13:25 JS, revision 67022

Applied patch in #12279: in wxRichTextCtrl, when wxRE_READONLY is set, the undo, redo function should be disabled

2011-02-25 13:21 JS, revision 67021

Applied #12601: Background color when saving wxRichText to HTML file

2011-02-25 12:37 JS, revision 67020

Applied #12941: Fixes and enhancements for wxRTC (Robert Hoffman)

2011-02-25 11:31 JS, revision 67019

Added missing colour index case

2011-02-25 10:38 JS, revision 67018

Added wxSYS_COLOUR_LISTBOXHIGHLIGHTTEXT to fix tree and list control selection rendering.

2011-02-25 10:37 JS, revision 67017

Added wxSYS_COLOUR_LISTBOXHIGHLIGHTTEXT to correct tree and list control selection rendering.

2011-02-24 21:34 VZ, revision 67015

Handle ANSI release configuration correctly in msvc/wx/setup.h. Preprocessor operations don't work with empty values so check for the case of empty suffix specially. This avoid warnings about "not enough actual parameters for macro 'wxSTRINGIZE_HELPER'" from MSVC.

2011-02-24 21:34 VZ, revision 67014

No changes, just fix a typo in the changelog. s/futher/further/

2011-02-24 19:08 JS, revision 67013

Better unfocused selected list item colouring

2011-02-24 15:56 SC, revision 67012

reverting part of r58797, otherwise wxClientDC get no graphics context at all

2011-02-24 11:02 JS, revision 67011

Fix for #12979: wrong unfocused selected text colour in wxTreeCtrl/wxListCtrl

2011-02-24 10:35 JS, revision 67010

Documented fixes

2011-02-24 09:42 JS, revision 67009

Applied #12959: Fix build with libpng-1.5

2011-02-24 00:35 VZ, revision 67006

Update and improve "Hello world" example in the documentation. The example was corrupted by transition to Doxygen (the menu item labels got eaten), fix it to actually work. Also use this opportunity to improve and modernize it.

2011-02-23 19:43 JS, revision 67004

Note to add --disable-gui

2011-02-23 19:41 JS, revision 67003

Tweak from #12975

2011-02-23 19:37 JS, revision 67002

Assertion fixed (colours not in sync with wxSystemColour)

2011-02-22 19:51 SC, revision 67001

supporting content size scaling (retina display)

2011-02-22 16:47 SC, revision 66998

building iphone again

2011-02-22 14:55 VZ, revision 66997

Update Czech translations. Apply update from Zbynek Schwarz.

2011-02-22 14:26 VZ, revision 66996

Don't duplicate INVALID_FILE_ATTRIBUTES definition. Move it in wx/msw/missing.h header instead of defining it in two different places. Closes #12964.

2011-02-22 14:26 VZ, revision 66995

Test for cairo_push_group() in configure. This function is required by wxGraphicsContext Cairo-based implementation but is missing in old Cairo versions so check for it in configure and disable wxGraphicsContext is it's not available. Closes #12966.

2011-02-22 14:25 VZ, revision 66994

Put storage class outside WXDLLIMPEXP_DATA_CORE() macros. The storage class must come first in a declaration so put it in front of WXDLLIMPEXP_DATA_CORE() and not inside it to avoid warnings from some compilers (notably Intel one). Closes #12932.

2011-02-22 14:25 VZ, revision 66993

Remove duplicated control names strings declarations from wxOSX. There is no need to declare wxFooNameStr constants in wx/osx/foo.h files as they are already declared in wx/foo.h. Also remove a couple of header/forward declarations unnecessary for the same reason.

2011-02-22 14:25 VZ, revision 66992

Move wxCheckBoxNameStr declarations to wx/tglbtn.h from wx/port/tglbtn.h. Don't duplicate wxCheckBoxNameStr declarations in all ports. Of course, the question still remains why does wxToggleButton use wxCheckBoxNameStr and not a specific name in the first place.

2011-02-22 13:13 JS, revision 66991

Documented menu bar fix

2011-02-22 13:10 JS, revision 66990

VC6 build fix

2011-02-20 21:08 JS, revision 66986

Regenerated makefiles using Bakefile 0.2.9

2011-02-20 19:18 VS, revision 66985

Put normal space between Back and Next buttons in wxWizard. Use regular space between these two buttons even on Windows, where they were previously close together. This used to be done in older Windows versions, but modern Windows HIG documents show wizards with equal spacing between all buttons and that's what Windows OS itself does. In other words, not treating this pair of buttons specially is more native.

2011-02-20 13:05 JS, revision 66984

Corrected a hit test problem when tabs are present

2011-02-20 13:05 JS, revision 66983

Corrected a hit test problem when tabs are present

2011-02-20 12:04 TIK, revision 66982

Check for bind() failing. Closes #12299

2011-02-20 11:48 TIK, revision 66981

Apply #12084: Double-clicking disabled left/right scroll buttons in wxAuiNotebook no longer counts as background doubleclick.

2011-02-20 11:26 TIK, revision 66980

Need to call wxFrame::Create instead of wxWindowBase::CreateBase in the wxPseudoTransparentFrame constructor. Fixes crash reported in #11474

2011-02-20 07:31 SC, revision 66979

handling nil images correctly, solves #12956

2011-02-19 17:18 SC, revision 66978

appeasing clang

2011-02-19 15:51 SC, revision 66977

only draw separator line on the area adjacent to content, avoids double frames

2011-02-19 15:26 VZ, revision 66976

Work around an intermittent crash in GSocket under Mac. The socket descriptor may somehow be invalid when an input timeout notification is received. This is almost certainly not the right fix but the code has completely changed in 2.9 so it doesn't make much sense to spend time on fixing it properly here. But adding this check seems to be enough to fix the crash, see #12264. Closes #8904.

2011-02-19 15:26 VZ, revision 66975

No changes, just de-TAB gsocket.cpp. TABs must be removed before committing other (significant) changes to this file which would otherwise be blocked by svn commit hook.

2011-02-19 15:17 VZ, revision 66974

Remove unused variables in wxOSX code. Simply remove some unused variables that Xcode 4 compiler warned about. See #12927.

2011-02-19 15:16 VZ, revision 66973

Remove extra semicolons in Objective-C code. The semicolons after the method signature in its implementation are useless and, in fact, provoke warnings from the compiler used by Xcode 4. Simply remove them. See #12927.

2011-02-19 15:16 VZ, revision 66972

Remove stray #pragma implementation. This #pragma is obsolete and shouldn't be used any more (if it ever had to be). See #12927.

2011-02-19 15:16 VZ, revision 66971
  • D /wxWidgets/trunk/src/html/htmlfilter.cpp
  • D /wxWidgets/trunk/src/html/search.cpp

Remove long unused wxHTML files. These files seem to be left overs from the initial cvs import many years ago, remove them to avoid confusion. See #12927.

2011-02-19 14:54 VZ, revision 66970

Define forward-compatible wxT_2() macro. This macro is the same as wxT() in wx 2.8 but allows to write code compatible with wxWidgets 3 where it expands to nothing. See #12925 and r66968.

2011-02-19 14:54 VZ, revision 66969

Replace a name with Latin-1 characters with ASCII equivalent. The file wxchar.h currently doesn't have UTF-8 encoding but contained non-ASCII 'å' character which prevented any changes to it from being committed. Instead of converting the file to UTF-8 (which would be better but just might create some unforeseen problems) simply use the ASCII spelling of the name, as it's already done in several other files.

2011-02-19 14:44 VZ, revision 66968

Add wxT_2() macro for compatibility with wxWidgets 2 API. This macro can be used to make the same code compile with both v2 and v3 as it expands to wxT() in 2.8 and nothing in later versions. See #12925.

2011-02-19 13:33 VZ, revision 66967

Add wxAutomationInstance_SilentIfNone flag for wxMSW OLE code. This flag allows to suppress the error message in case there are no currently running instances of this object and can be useful if the caller doesn't know in advance whether it's available or not. Closes #12734.

2011-02-19 13:32 VZ, revision 66966

Move "static" keyword out from wxDEPRECATED() macros to placate icc. Intel compiler gives warnings if the static keyword is not at the beginning of the declaration and this happened when using it inside wxDEPRECATED() and related macros because the declaration started with __declspec(deprecated) or __attribute__((deprecated)) instead. To avoid this problem, simply move "static" outside the macro. Closes #12932.

2011-02-19 13:32 VZ, revision 66965

Correct signed/unsigned comparison in wxGridBagSizer code. Casting a signed value to unsigned type is a recipe for disaster if it actually turns out to be negative because the comparison remains always false and the loop becomes practically infinite. So cast the unsigned value to signed int instead, this should be perfectly safe as the number of columns or rows in a sizer can't exceed INT_MAX anyhow. Notice that after the changes of the previous revision the signed value should actually be always positive so this change is not strictly needed but it is still safer to write the comparison like this. See #12934.

2011-02-19 13:32 VZ, revision 66964

Don't accept invalid values for rows/columns in wxGBSpan ctor. wxGBSpan must have strictly positive row and column span as otherwise the grid bag sizer code could enter an infinite loop trying to exceed a negative number which it casted to an unsigned one. And while the cast itself is incorrect too the program still behaves undesirably (produces a lot of asserts in debug build and then crashes or crashes directly in release) if a zero size span is used so it seems better to prevent this from happening. Closes #12934.

2011-02-19 01:30 VZ, revision 66961

Fix out of bounds string access in wxMSW wxDirDialog. Using the initial directory of "/" (or "\\" or in fact any string consisting solely of slashes and backslashes) resulted in a crash as the code incorrectly tried to read the character before the beginning of the string. Fix this by checking that the string is not empty before using s.end()-1 iterator. Closes #12946.

2011-02-19 01:30 VZ, revision 66960

Don't ask for wxTextAttr colour if it doesn't have any in text sample. This fixes an assert which could happen when showing the rich text editor. Also show the colour in a more readable form if possible. Closes #12950.

2011-02-19 01:30 VZ, revision 66959

Compilation fix for PCH-less wxOSX build. Forward declare wxChoice. Closes #12953.

2011-02-19 00:42 JS, revision 66958

Version number change

2011-02-18 20:06 SC, revision 66956

fixes #12935

2011-02-18 19:44 SC, revision 66955

bail out with error in case of carbon set for 64 bit architecture

2011-02-18 19:25 SC, revision 66954

precomp header fixes

2011-02-18 18:48 SC, revision 66953

updating sysopt string

2011-02-18 18:29 SC, revision 66952

support for file-type popup, compatible for 10.4+, solves #12429

2011-02-18 08:26 SC, revision 66951

support non precomp builds

2011-02-17 23:08 JS, revision 66949

Change log updates and version/date updates

2011-02-17 16:01 JS, revision 66945

Workaround for #10040: wxGrid scrolls back to the previous edit position

2011-02-17 14:39 JS, revision 66943

Applied backport for #11157: Generic wxTreeCtrl - SelectItem toggles selection if item already in desired state

2011-02-17 13:30 JS, revision 66942

Applied fix #11254: assert on wxEVT_MOUSE_CAPTURE_LOST and wxGrid

2011-02-17 12:01 JS, revision 66941

Backport for for #12143: Click anywhere inside wxListBox generates wxEVT_COMMAND_LISTBOX_SELECTED event Needs wxUSE_LISTBOX_SELECTION_FIX to be set to 1 in include/wx/msw/listbox.h since it is not binary compatible.

2011-02-17 11:20 JS, revision 66940

Fix for backport

2011-02-17 11:12 JS, revision 66939

Applied backport for fix to #4111: wxFileName::IsFileReadable fails under Windows 98

2011-02-17 10:57 JS, revision 66938

Fixed #12312: Can't use --disable-radiobtn with 2.8

2011-02-17 10:53 JS, revision 66937

Fixed bug #9856: wxSizer::Replace( size_t, wxSizerItem *) doesn't call SetContainingSizer

2011-02-17 10:52 JS, revision 66936

Fixed bug #9856: wxSizer::Replace( size_t, wxSizerItem *) doesn't call SetContainingSizer

2011-02-17 10:46 SC, revision 66935

activating high-res support via artprov mac

2011-02-17 07:46 SC, revision 66934

patch applied with thanks, fixes #10524

2011-02-17 00:51 VZ, revision 66932

Correct example of wxRegKey use in its documentation. Don't check for the key existence, it ought to exist if we create it like this. Also don't allocate wxRegKey object on the heap unnecessarily.

2011-02-17 00:45 VZ, revision 66931

Remove WXDLLIMPEXP_CORE from VC6 wxCompositeWindow declaration. Hopefully not using WXDLLIMPEXP_CORE here should fix VC6 warnings about using non dll-interface class as a base class for a dll-interface one.

2011-02-17 00:45 VZ, revision 66930

Don't use native MSW wxProgressDialog version in wxUniv. The native version should only be used in the native port.

2011-02-17 00:44 VZ, revision 66929

Compile wxUIActionSimulator in wxUniv builds. Move wxUIActionSimulator implementation files to low level sources to ensure that they are included in wxUniv builds.

2011-02-17 00:31 JS, revision 66928

Applied #11097: wxGraphicsContext::DrawBitmap: x and y coords should not be affected by stretch factor

2011-02-17 00:27 JS, revision 66927

Applied patch #12444: wxAcceleratorEntry::IsOk() is broken

2011-02-17 00:25 JS, revision 66926

Applied #10079: wxAuiToolBar: Allow right-click on any kind of button

2011-02-17 00:19 JS, revision 66925

Applied #11389: dataview GetValueByRow, SetValueByRow

2011-02-16 23:58 JS, revision 66924

Applied #10576: msw build fails when using watcom with no-threads option

2011-02-16 23:37 JS, revision 66923

Applied #11350: LP64 LLP64 conflicts in wxStyledTextCtrl result in crashing win64 applications

2011-02-16 23:26 JS, revision 66922

Applied #10111: race condition bugs in wxCondition

2011-02-16 23:00 JS, revision 66920

Applied #12549: command line usage correction

2011-02-16 22:57 JS, revision 66919

Applied #11536: null ptr deref

2011-02-16 22:55 JS, revision 66918

Applied fix #11520: resource leak

2011-02-16 22:51 JS, revision 66917

Applied #12437: use static wxColourData in wxGetColourFromUser

2011-02-16 22:48 JS, revision 66916

Applied #12436: added wxFD_FILE_MUST_EXIST flag to wxFileSelector

2011-02-16 22:46 JS, revision 66915

Applied #12438 IsUNCPath patch

2011-02-16 22:44 JS, revision 66914

Check for double creation (patch #12434)

2011-02-16 22:40 JS, revision 66913

Fix for OLE conversion to date (patch #12857)

2011-02-16 22:35 JS, revision 66912

Fix CalculatePositions optimization (corrects #12435)

2011-02-16 22:31 JS, revision 66911

Allow m_docManager to be NULL (patch #12435)

2011-02-16 21:53 JS, revision 66910

Updated version

2011-02-16 19:51 SC, revision 66908

adding edit menu in order to be able to support native edit menu commands (osx)

2011-02-16 19:32 SC, revision 66907

support native edit menu handling (cocoa enables menu items in built-in modal dialogs automagically, if they have the proper selectors)

2011-02-16 19:31 SC, revision 66906

toolbar support in all orientations

2011-02-16 19:30 SC, revision 66905

toolbar support in all orientations

2011-02-16 17:37 SC, revision 66904

remove ununsed member

2011-02-16 17:10 SC, revision 66903

conforming to deprecation recommendation for 10.6

2011-02-16 08:38 SC, revision 66901

support for file types in save panel

2011-02-16 07:59 SC, revision 66900

support wxFD_MULTIPLE

2011-02-16 07:55 SC, revision 66899

fixing naming to conform to effective ownership, cleaning up releasing

2011-02-16 06:13 PC, revision 66898

fix GCC warning

2011-02-15 21:31 MBN, revision 66897

Fixed compilation when WXINTL_NO_GETTEXT_MACRO is defined.

2011-02-15 11:15 VZ, revision 66894

Make the source file non-executable. The file ctrlcmn.cpp somehow got the executable bit in r66871, undo this.

2011-02-14 23:12 VZ, revision 66893

Don't increase button height in wxMSWButton::GetFittingSize(). This is unnecessary and resulted in too high buttons in some cases for buttons with images. As we increase the button height to at least the standard value later in all code using function anyhow, it's not necessary to do anything with the height inside it. Now the buttons with an image get the same height whether they have the text or not. This change also gets rid of (completely arbitrary) decision to use 11/10 of the label height when computing the fitting button size and it's always nice to get rid of dirty hacks like this. Closes #12924.

2011-02-14 23:12 VZ, revision 66892

Don't make buttons with images too wide in wxMSW. We used to increase the button size to the standard size first and then add the extra padding the buttons with images. This resulted in too much padding for the buttons with short text labels and images. Instead, add the padding for the image first and only then increase the button size to the standard one if still needed. See #12924.

2011-02-14 23:12 VZ, revision 66891

Don't add margins for buttons with text and images by default in wxMSW. For some reason wxXPButtonImageData added (big) margins around the button by default resulting in too much padding. Simply remove these margins to make it behave similarly to wxODButtonImageData. See #12924.

2011-02-14 23:11 VZ, revision 66890

Clarify wxButton::AdjustForBitmapSize() semantics in wxMSW. This method should only be called if we do have an image, assert (instead of silently returning) if it's called when we don't. Also explain in a comment why do we need to call CacheBestSize() only when we have an image in DoGetBestSize().

2011-02-14 20:13 SC, revision 66888

support framelayout for choice

2011-02-14 13:30 VZ, revision 66885

Remove X11-specific wxWindowIsVisible() from common Unix file. XGetWindowAttributes() used in this function resulted in link problems under Fedora 14 because we don't explicitly link with libX11. Instead of doing this, simply get rid of this function as it seems to be used in exactly one place in wxX11 code only anyhow.

2011-02-14 12:59 VZ, revision 66884

Explain wxSizer::SetVirtualSizeHints() deprecation. Tell people that FitInside() should be used instead.

2011-02-13 18:09 VS, revision 66881

Fix VC2008 dependencies with Bakefile 0.2.9.

2011-02-09 20:52 VS, revision 66875

More wxControl::Ellipsize() tests.

2011-02-09 20:52 VS, revision 66874

Don't eliminate text completely in Ellipsize(). If the shortened text is so short there's nothing left of the original, show one character and "...". This is standard behaviour on both Windows and OS X, in addition to making lot of sense. Fixes #11360.

2011-02-09 20:52 VS, revision 66873

Calculate ellipsized width exactly. Width calculation using partial extents is just an inaccurate estimate: partial extents have sub-pixel precision and are rounded by GetPartialTextExtents(). Use partial extents to estimate string width and only verify it with GetTextExtent() when it looks good.

2011-02-09 20:52 VS, revision 66872

Don't shorten text too much in wxControl::Ellipsize(). If the allowed width is so small that nothing reasonable can fit it, overlap it. Ellipsized text must always contain "..." to indicate that it was shortened, it isn't acceptable to omit it. See #11360.

2011-02-09 20:51 VS, revision 66871

Ellipsization can't shorten 1-character string. It doesn't make sense to attempt to shorten 1 character long string, so don't do it. Note that 2 characters strings may be shortened (consider e.g. "mm" in some typefaces).

2011-02-09 20:51 VS, revision 66870

Remove "safety margin" from wxControl::Ellipsize(). When ellipsizing kicks in, the text is much shorter than the available space -- there's a "safety margin" of one character's width that is always left unused. This appears to be some kludge that worked around algorithm defects, not something that should really be needed.

2011-02-09 20:11 JMS, revision 66869

Added missing wxBitmapComboBox::Insert() implementation

2011-02-08 18:24 VZ, revision 66866

Tweak offset in the RichTextCtrlTestCase::UrlEvent() to make it pass. The mouse was not positioned over the URL in this test so clicking it didn't work. Tweak the offset to make it pass but it would be better to have some more fool-proof way of finding the real position of the text in the control.

2011-02-08 18:24 VZ, revision 66865

Use wxLocale instead of setlocale() to change the locale in the tests. Numeric validator tests rely on wxLocale::GetInfo() returning the decimal point and calling setlocale() is not enough to ensure this under MSW, we must use wxLocale for this currently.

2011-02-08 15:19 SC, revision 66864

disabling multiline text controls correctly

2011-02-08 15:11 SC, revision 66863

forward enable functionality to inner view in scrollview (eg for multiline textviews)

2011-02-08 14:36 VZ, revision 66862

Fix wxWrapSizer minimal size calculation. Add a unit test checking that wxWrapSizer::CalcMin() returns the expected results. Closes #12464.

2011-02-08 14:36 VZ, revision 66861

Fix bytes to integers conversion in png2c script. Use really correct coefficients for all the bytes.

2011-02-08 14:36 VZ, revision 66860

Define KEY_WOW64_64KEY if it is missing from SDK headers. Fixes compilation with old SDKs, e.g. the one used by VC6.

2011-02-08 11:47 SC, revision 66859

copy item text for app menu items from wx menus

2011-02-06 02:01 VZ, revision 66853

Correct more wxEVT_AUXn_XXX event types names. This completes the changes of r64414 and also removes the extraneous "MOUSE" from the event types listed in the wxMouseEvent ctor documentation. Closes #12095.

2011-02-06 02:01 VZ, revision 66852

Use better title by default in wxDocPrintout. Use the document name instead of the default "Printout" if no title is explicitly specified when creating wxDocPrintout. Closes #12885.

2011-02-06 02:01 VZ, revision 66851

Allow accessing 64 bit registry from 32 bit MSW code and vice versa. Implement support for KEY_WOW64_32KEY and KEY_WOW64_64KEY in wxRegKey code. Closes #10792.

2011-02-06 02:00 VZ, revision 66850

Use Explorer style for wxTreeCtrl with wxTR_TWIST_BUTTONS in wxMSW. The tree control style used by Explorer uses rotating triangles instead of the standard "+/-" buttons and so seems to correspond relatively well to this style. And this provides a possibility to have a more standard-looking tree controls in wxWidgets programs.

2011-02-06 02:00 VZ, revision 66849

Clean up wxMSW wxTreeCtrl code by removing obsolete workarounds. Remove wxUSE_COMCTL32_SAFELY that hasn't been needed for years, the current code seems to work just fine on all the systems so remove this obsolete workaround to simplify it.

2011-02-05 21:25 VZ, revision 66848

Link console programs with PNG library in monolithic build. PNG images are used by the main wxWidgets library itself now and so linking with the monolithic wx library introduces dependencies on PNG as well, even for the console applications. Link them with linpng to avoid linker errors. Closes #12889.

2011-02-05 21:24 VZ, revision 66847

Correct decoding of 4-byte integers in png2c script. Wrong multiplier was used for the most significant byte. Fix it even though it doesn't risk to be a problem in practice as the images of such gigantic size would surely break some limit anyhow.

2011-02-05 21:24 VZ, revision 66846

Re-enable generation of wxEVT_MOVE_{START,END} events under wxMSW. Handling of WM_{ENTER,EXIT}SIZEMOVE was disabled as a side-effect of r47927, possibly unintentionally. Revert this change to generate these events again. Also document that they're MSW-only for now.

2011-02-05 17:38 VZ, revision 66845

Don't adjust menu item positions for title for menubar menus in wxMSW. The code in wxMSW menu code which accounted for the extra items used to show popup menu title has become incorrect since the changes of r66178 as now the non-popup menus have titles as well. Correct the check to only do the adjustment for the popup menus. Closes #12922.

2011-02-05 17:36 VZ, revision 66844

Deprecate second parameter of wxSlider::SetTickFreq(). This parameter was never needed nor properly documented. Simply remove it from SetTickFreq() and keep the overload still taking it for backwards compatibility only. Closes #12907.

2011-02-05 17:36 VZ, revision 66843

Implement restoring default video mode under OS X. Use CGRestorePermanentDisplayConfiguration() to implement switching to default video mode in wxOSX wxDisplay implementation. Closes #12914.

2011-02-05 17:14 VZ, revision 66842

Check for WLAN interface names in wxDialUpManager under Unix. Recognize "wlan" and "ath" interfaces as well as the "eth" ones. Closes 12923.

2011-02-03 21:05 JS, revision 66838

Fix for lines not wrapping soon enough if tabs are present

2011-02-03 21:05 JS, revision 66837

Fix for lines not wrapping soon enough if tabs are present

2011-02-03 16:02 VZ, revision 66836

Rebake everything using bakefile 0.2.9. Update configure and bakefile.m4 for the new version too. Also add the missing makefiles and projects for the XTI sample.

2011-02-03 11:59 JJ, revision 66835

Avoid incompatible operand types

2011-02-03 11:20 SC, revision 66834

fixes #10978

2011-02-02 14:49 SC, revision 66829

switching to assert

2011-02-02 12:19 DS, revision 66828

Added support for reading comments from a GIF image. Applied (modified) patch by troelsk. Changed comments (which are allowed per frame in an animated GIF) to be read using wxIMAGE_OPTION_GIF_COMMENT with wxImage.GetOption. Added unit tests for reading and writing GIF comments. Closes #12843.

2011-02-02 08:56 SC, revision 66827

testing for define alone is sufficient and more portable

2011-02-02 08:55 SC, revision 66826

fixing searchctrl on osx_cocoa, changing type for peer to wxSearchCtrl

2011-02-02 08:36 SC, revision 66825

guard against null ptr access

2011-01-31 19:23 VS, revision 66823

Account for first removal char with wxELLIPSIZE_MIDDLE. wxControl::Ellipsize() in wxELLIPSIZE_MIDDLE mode starts the string-shortening loop with the removal interval initially set to remove only the len/2-th character. But it didn't add its size to the running total of removal characters' length, thus always removing one more character. Fixed by making the initial interval 0-sized rather than 1-sized.

2011-01-31 19:23 VS, revision 66822

Remove chars one-by-one with wxELLIPSIZE_MIDDLE. Previously, Ellipsize() would always remove two characters at a time in wxELLIPSIZE_MIDDLE mode. This was clearly a bug: it led to shortening the text more than was strictly necessary.

2011-01-31 17:54 VS, revision 66821

Fix vertical rules rendering in generic wxDataViewCtrl. Vertical rules are now drawn in the last pixel of a column instead of in the first, so that they align perfectly with native MSW wxHeaderCtrl as well as for consistency with MSW native list control. There's no vertical rule at the most-left side of the control anymore.

2011-01-30 20:01 SC, revision 66819

adding support for wxCANCEL_DEFAULT

2011-01-29 15:20 VZ, revision 66814

OLE uses VARIANT_TRUE and not TRUE for its boolean values. VARIANT_TRUE is -1, unlike TRUE which is just 1, and we must use the former and not the latter with OLE VARIANT values. Closes #12910.

2011-01-29 14:55 VZ, revision 66813

Revert "Set up pages range in the wxMSW print dialog correctly." This patch changed the relative order of calls to wxPrintout::GetPageInfo() and OnPreparePrinting(), breaking the existing code and the documentation promise about OnPreparePrinting() being called first, so revert it. Reverts r66549. See #12819. Closes #12911.

2011-01-28 16:01 JJ, revision 66804

Update OpenVMS makefile

2011-01-28 09:36 DS, revision 66803

Allow writing a comment to each GIF frame. Don't write a comment as part of the GIF header during the first frame only but write a possible comment for each wxImage in an animation.

2011-01-28 09:10 DS, revision 66802

Added support for writing a long comment to a GIF image. Instead of limiting a comment to a maximum length of 255 bytes write multiple comment data blocks (each a Pascal string) followed by the block terminator.

2011-01-28 08:35 SC, revision 66801

clang fix, fixes #12332

2011-01-28 08:27 DS, revision 66800

Changed the procedure for writing a comment to a GIF image. Use wxImage.SetOption with newly introduced wxIMAGE_OPTION_GIF_COMMENT to set a GIF's image comment now. Formerly this was done (since recently) using wxGIFHandler::ms_comment which has now been removed.

2011-01-28 07:39 PC, revision 66799

build fix for wxUSE_XPM==0

2011-01-28 07:18 PC, revision 66798

better way to silence unused parameter warning

2011-01-28 03:35 BP, revision 66797

Backport of r66796 (Properly account for floated panes while restoring maximized pane.) - closes #11385

2011-01-28 03:21 BP, revision 66796

Properly account for floated panes while restoring maximized pane.

2011-01-27 19:35 SC, revision 66792

clang fixes, fixes #12332

2011-01-27 18:15 SC, revision 66791

clang fix

2011-01-27 14:27 VZ, revision 66788

Document wxEVT_COMMAND_SPINCTRL_UPDATED in EVT_SPINCTRL description. Also mention the name of the event type when documenting the corresponding event table macro. Closes #12897.

2011-01-27 14:27 VZ, revision 66787

Fix link errors under Cygwin with wxUSE_GRAPHICS_CONTEXT==1. Define ourselves _GdipStringFormatCachedGenericTypographic variable referenced by Cygwin GDI+ headers to fix linking errors due to the fact that we don't link with gdiplus.lib at all but load gdiplus.dll dynamically. Closes #11716.

2011-01-27 14:00 SC, revision 66786

__BIG_ENDIAN__ is either defined AND has a value of 1, or it is not defined at all, so #ifdef is sufficient

2011-01-27 13:38 SC, revision 66785

fixing return type

2011-01-27 12:54 SC, revision 66784

clang warnings

2011-01-27 12:53 SC, revision 66783

good catch by clang ...

2011-01-27 12:37 SC, revision 66782

clang warnings

2011-01-27 12:04 SC, revision 66781

reverting inadvertent commit

2011-01-27 12:00 SC, revision 66780

supporting clang 2.0 under xcode, see #12332

2011-01-26 19:49 SC, revision 66777

keeping opaqueness and backgroundcolor in synch with bgstyle

2011-01-26 19:46 SC, revision 66776

per default wx' static text items have a transparent background

2011-01-26 17:15 SC, revision 66775

artmac extended for cocoa

2011-01-26 16:55 SC, revision 66774

fixing toplevel position

2011-01-26 16:54 SC, revision 66773

hinting support

2011-01-26 16:53 SC, revision 66772

PNG is the native format on iOS

2011-01-26 16:52 SC, revision 66771

avoid populating the array with NULL controls during creation (SetWindowVariant calling SetFont crashing)

2011-01-26 16:51 SC, revision 66770

support for hints, fixing textfield implementation on iOS

2011-01-26 08:42 SC, revision 66766

Maximize for iPhone

2011-01-25 19:47 SC, revision 66761

supporting a null cgimage so that we don't get exceptions, only an wxbitmap that is !Ok()

2011-01-25 19:46 SC, revision 66760

support for separator (fixed width spacE)

2011-01-25 16:47 SC, revision 66759

adding constructor from CGImageRef

2011-01-25 12:23 DS, revision 66758

Fixed heap corruption when reading a corrupted RLE TGA image. There were no boundary checks in place to verify an indicated repeat of pixels would still be inside the image's data. Added these checks and a unit test making sure these kind of TGAs now fail to load.

2011-01-25 09:15 DS, revision 66757

Fixed typo in wxFileName::GetHumanReadableSize docs. Closes #12898.

2011-01-25 06:14 RD, revision 66752

Save the mode in SetMode

2011-01-25 06:03 RD, revision 66751

Add wxRTTI macros for the wxSimpleHtmlListBox class

2011-01-24 18:36 PC, revision 66743

remove deprecated voidp, closes #12896

2011-01-24 17:45 SC, revision 66742

fixing toolbar repositioning (iOS)

2011-01-24 17:45 SC, revision 66741

guarding code in case of delayed controller release

2011-01-24 15:35 VS, revision 66740

Don't allow user to resize non-resizable columns to best size. Double-clicking columns separator resizes the column to the best width for its content. This should only be done for resizeable columns, though.

2011-01-24 15:35 VS, revision 66739

Remove incorrect comment. UpdateColumnWidthToFit() is in fact used when double-clicking columns separators.

2011-01-24 14:17 SC, revision 66738

direct constructor from CGImageRef

2011-01-23 11:13 JMS, revision 66734

To work around harmless memory leaks reported by Visual C++ static runtime libs, assume that C++ typeid operator works well with VC++ 9.0 and later (fixes #12023)

2011-01-23 11:10 SC, revision 66733

loading png and jpg from resource bundle

2011-01-22 22:25 JS, revision 66731

Reverted for a quiet life

2011-01-22 21:43 JS, revision 66730

Don't pointlessly forbid calling AddGrowableRow/Col before adding items.

2011-01-22 20:02 VS, revision 66729

wxDataViewCtrl: fix autosized columns recalculation. The code and its assumptions were correct only for generic wxHeaderCtrl, it didn't work for MSW implementation. Fixed by updating all columns every time.

2011-01-22 15:38 DS, revision 66728

Use wxString's empty() when checking if the string is (non-)empty throughout wx. Instead of constructs such as if "( s.length() )" and "if (s.length() > 0)" use "if ( !s.empty() )" instead. Similarly for "if (s.length() == 0)" or "if ( s.IsNull() )", use "if ( s.empty() )". No code changes intended except for a few instances where a construct like "if ( s.length() && wxFileExists(s) )" was changed to not check the length of the string and let wxFileExists handle such cases.

2011-01-20 16:06 VZ, revision 66727

Explicitly set "C" locale for the tests using decimal point. Ensure that the tests expecting the results with a point as decimal separator really are done in C locale. This should help the tests pass in (French) locale used by the MSW build bot slaves.

2011-01-20 16:06 VZ, revision 66726

Further improve caching of locale-specific data in wxNumberFormatter. Also update the cached data if setlocale() was called explicitly instead of using wxLocale to change the locale because at least under Unix systems calling setlocale() changes the result of wxLocale::GetInfo() and so the result returned by wxNumberFormatter::GetDecimalSeparator() and GetThousandsSeparatorIfUsed() could be inconsistent with the locale being really used.

2011-01-20 16:02 JS, revision 66725

Fixed some bugs in up/down cursor navigation.

2011-01-20 09:38 SC, revision 66724

using explicit fixes #12689

2011-01-20 00:47 VZ, revision 66723

Include more information in assert in wxNumberFormatter. Show more information in the assert failure message to try to understand why is the unit test failing on the buildbot.

2011-01-20 00:47 VZ, revision 66722

Work around wxNumValidator compilation problems with MSVC 6. Surprisingly, MSVC 6 seems to be able to compile most of the code but chokes on a wxCOMPILE_TIME_ASSERT involving an inherited typedef. As this assert is not critical, simply disable it for this compiler.

2011-01-19 21:40 SC, revision 66721

make sure Raise is also activating the window

2011-01-19 19:36 SC, revision 66720

missing release

2011-01-19 19:32 SC, revision 66719

support icns in bundle

2011-01-19 16:08 VZ, revision 66718

Use setUp/tearDown() for NumFormatter test case locale setup. Setting the locale in the ctor of the test object doesn't work because the locale is changed by the other tests that run before this one, use the initialization method provided by cppunit to change the locale instead, this is somewhat wasteful but at least it does work, unlike the old version.

2011-01-19 14:47 DS, revision 66717

Improved detection of alpha channels in TIFF images. Some TIFF images are not properly formed, for example having an extra channel marked as being unspecified data while they should be treated as being an alpha channel. Detect some of those cases so that these TIFF images now will have alpha. Applied patch by gmeeker. Closes #12874.

2011-01-19 13:28 DS, revision 66716

Added GIF and animated GIF saving support. Applied (modified) patch by troelsk. Also added a basic unit test for checking the frames of a saved animated GIF (a previous unit test already handles content of a GIF with a single frame). Closes #8583.

2011-01-19 12:30 DS, revision 66715

removed some leftover debugging code

2011-01-19 11:48 VZ, revision 66714

Add wxIntegerValidator and wxFloatingPointValidator classes. Add validators for integer and floating point numbers. Add an example of their use to the validate sample as well as a new unit test and documentation for them. Use the new classes instead of wxTextValidator in wxGrid code. Closes #12166.

2011-01-19 11:48 VZ, revision 66713

Update cached values in wxNumberFormatter when locale changes. Caching the decimal and thousands separators in wxNumberFormatter is a useful performance optimization, however it can give wrong results if the locale changed since the cached values were initialized. So remember the locale used for the initialization and redo it if it changed. This should still be almost as fast as the previous version but now also correct (still not MT-safe though).

2011-01-19 11:47 VZ, revision 66712

Add support for long long to wxNumberFormatter. It seems to make sense to allow using it for formatting and parsing long long values as well as it can be done trivially using almost the same code as for long. It would be nice to support long double in a similar way but we don't wrap C99 strtold() right now so it wouldn't be as simple, leave it for later.

2011-01-19 11:47 VZ, revision 66711

Add wxHAS_LONG_LONG_T_DIFFERENT_FROM_LONG symbol. Instead of writing a rather unreadable "defined(wxLongLong_t) && !defined(wxLongLongIsLong)" expression every time we need to decide if a function needs to be overloaded for both long and long long, add a new symbol which can be tested directly. No real changes in the code.

2011-01-19 11:47 VZ, revision 66710

Add wxNumberFormatter class helping to deal with thousands separators. wxNumberFormatter formats and parses numbers with thousands separators. Add the class itself as well as documentation and the unit test for it. See #12166.

2011-01-19 11:46 VZ, revision 66709

Mention modal dialogs in the wxWindow objects allocation guide. The modal dialogs are an important exception to the usual rules of dealing with wxWindow-derived objects so mention them here too. Closes #12880.

2011-01-19 11:46 VZ, revision 66708

Avoid collapsing the hidden root in wxTreeCtrl::CollapseAllChildren(). The hidden root item can't be collapsed so don't even try to do it as this just results in an assert. This is similar to the changes of r48097 in ExpandAllChildren(). Closes #12881.

2011-01-19 10:33 JMS, revision 66707

In wxStringProperty::ValueToString(), regenerate composed value string also when it was empty. This is needed in cases where property's children were added before property itself was added to the wxPropertyGrid (fixes #12877).

2011-01-19 09:09 RD, revision 66706

On OSX don't propogate the alignment setting from column to renderer if it is a custom renderer. This allows the Render function to deal with the alignment itself and brings the behavior into alignment (pun intended!) with the GTK and generic DV classes. Fixes #12883

2011-01-18 14:34 JS, revision 66705

Fix for incorrect programmatic formatting (default style set immediately if not using Thaw/Freeze)

2011-01-18 13:32 JS, revision 66704

Fixed some problems with floating objects

2011-01-17 11:11 JMS, revision 66699

Changed wxMSW wxGraphicsContext font rendering and extent calculation to take into the account that the page scale has been manually changed when using print contexts (fixes #12830)

2011-01-17 00:24 VZ, revision 66698

Add skeleton documentation for wxAuiToolBar and related classes. Add classes declarations to Doxygen-generated documentation. This doesn't replace the real documentation but is better than nothing. See #10232.

2011-01-17 00:24 VZ, revision 66697

Document wxDialog::ShowWindowModal(). This function is not yet really implemented under all platforms but provide the documentation for it hinting at how (and where) it works. Closes #12873.

2011-01-17 00:24 VZ, revision 66696

Override HasTransparentBackground() in wxHyperlinkCtrl to return true. At least in wxMSW the control must override HasTransparentBackground() to return true if it really wants its background to be transparent, so do it in wxHyperlinkCtrlBase to fix the background appearance when using the generic implementation in wxMSW. See #12271.

2011-01-16 15:09 VZ, revision 66695

Remove undefined wxScrollBarBase::Create() declaration. Create() method in a base class can't be implemented and actually shouldn't even have been defined there in the first place.

2011-01-15 19:52 PMO, revision 66689

Handle 'central widget' in wxFrame, Introduce wxQtSignalHandler, wxQtEventSignalHandler

2011-01-15 16:31 JS, revision 66688

Corrected wrong range in GetText

2011-01-15 14:20 JS, revision 66687

XML import corrections

2011-01-14 20:32 JS, revision 66684

Small doc tweaks

2011-01-14 20:32 JS, revision 66683

Removed GCC 4 warning

2011-01-14 13:15 JS, revision 66682

Compile fix

2011-01-14 13:08 JS, revision 66681

Compile fixes

2011-01-14 12:57 JS, revision 66680

Implemented text boxes and tables, and further editing pages for backgrounds, borders and margins. wxRTC functions now operate on the currently focused object, which by default is the whole buffer. Up to three property commands are now shown on the context menu, depending on available objects in the current hierarchy.

2011-01-13 15:49 VZ, revision 66678

Fixes for parsing invalid HTML without tag ends. The code in wxHtmlParser supposed in many places that a '<' character must be always followed by a '>' one and could create (and sometimes dereference) invalid iterators if this wasn't the case resulting in asserts from MSVC debug CRT and possibly crashes. Fix this by ensuring that only valid iterators are used and add a trivial unit test for wxHtmlParser which checks that it can parse invalid HTML without crashing. Closes #12869.

2011-01-13 15:49 VZ, revision 66677

No changes, just remove a level of indentation in wxHtmlTagsCache ctor. Get rid of characters not starting a tag immediately in the beginning of the loop instead of putting the entire loop body inside an if statement. This doesn't change anything (this becomes more apparent if the patch is viewed with "ignore white space changes" option) except making the code easier to read and modify.

2011-01-13 15:49 VZ, revision 66676

Fix MSVC warnings about signed to unsigned conversion in the tests. Recently modified client data test added calls to SetClient{Object,Data}(-1) and MSVC complained about them, suppress these warnings.

2011-01-13 09:45 JJ, revision 66675

wxComboBox::GetClassInfo() should not be defined here

2011-01-12 19:04 PC, revision 66673

non-pch build fix

2011-01-12 18:58 JMS, revision 66672

In wxBitmapComboBox::RecreateControl(), only call ChangeValue() if the control doesn't have wxCB_READONLY style (fixes #12859)

2011-01-12 14:39 VZ, revision 66670

Add support for icons in wxAUI panes title bars. Add wxAuiPaneInfo::Icon() method and shows its use in the sample. Closes #12856.

2011-01-12 14:39 VZ, revision 66669

Fix crash in wxGenericRichMessageDialog::IsCheckBoxChecked(). The test for checkbox existence was inversed resulting in a guaranteed crash when calling IsCheckBoxChecked() before showing the dialog. Closes #12866.

2011-01-12 14:39 VZ, revision 66668

Disable deprecation and other warnings in MFC sample. VC8+ give tons of deprecation warnings for the standard functions which are usually suppressed by wx headers but they need to be included first for the suppression to be effective. In the MFC sample they were not resulting in many useless warnings. Fix this by pre-defining _CRT_SECURE_NO_WARNINGS to suppress them in the sample itself. Also suppress a warning about WINVER being undefined.

2011-01-12 14:39 VZ, revision 66667

Fix entry point in Unicode build of the MFC sample. MFC needs the entry point to be wWinMainCRTStartup() in Unicode builds but the bakefile-generated projects use the default WinMain() so the sample didn't link in Unicode. Fix this by providing WinMain() which simply forwards to wWinMainCRTStartup() as this seems to work for all MSVC/CRT versions.

2011-01-11 18:05 JJ, revision 66666

make sure wxNativeFontInfo is defined

2011-01-11 17:32 JJ, revision 66665

update OpenVMS makefile

2011-01-10 13:00 VZ, revision 66664

Check index in wxItemContainer methods working with client data. The test for index validity should be done by the base class public methods themselves so that the protected methods in the derived classes don't need to do it because this allows to have the check in one place only and not in every port-specific derived class and also because a protected method can reasonably expect to be called with already validated parameters. This makes it unnecessary to perform the same check in many derived classes and fixes the problem with those that forgot to check for item validity at all before (like wxGTK wxChoice). Also add a unit test checking for the correct behaviour. Unfortunately we don't have any way to test for the precise assert being triggered so the test passed for wxGTK wxChoice even before in debug builds because the expected assert was raised by wxArray::Item() but the code crashed in release build -- whereas now it doesn't any more. Closes #12858.

2011-01-10 13:00 VZ, revision 66663

Remove redundant top level const in wxRibbonBar::ShowPanels(). Use just "bool show" instead of "const bool show". This fixes compilation for some compilers (notably OpenVMS one) broken since r66612.

2011-01-10 12:42 SC, revision 66662

adding new files

2011-01-10 12:40 SC, revision 66661

adding new files

2011-01-10 12:32 SC, revision 66660

adding new files

2011-01-08 19:22 PC, revision 66658

remove always-true test of unsigned >= 0

2011-01-08 19:05 PC, revision 66657

remove unneeded #includes

2011-01-08 18:55 PC, revision 66656

fix GCC warning about not explicitly initializing base class

2011-01-08 18:45 PC, revision 66655

remove always-true tests of unsigned >= 0

2011-01-08 18:33 PC, revision 66654

fix GCC warning about not explicitly initializing base class

2011-01-08 18:17 PC, revision 66653

proper const-ness for GetLine() and operator[]()

2011-01-08 18:16 PC, revision 66652

proper const-ness for Item(), operator[](), and Last()

2011-01-08 11:22 SC, revision 66651

removing xti code which isn't necessary for unicode under trunk anymore

2011-01-08 09:03 SC, revision 66650

rearranging xti code

2011-01-08 07:57 PC, revision 66649

update docs after r66615

2011-01-08 07:42 PC, revision 66648

Move SendIdleEvents() from wxApp to wxWindow. Use it to properly implement idle events for wxGTK menubar, toolbar and statusbar.

2011-01-08 07:39 SC, revision 66647

adding xti info for commandlinkbutton

2011-01-07 23:52 SC, revision 66646

gcc fixes

2011-01-07 23:46 SC, revision 66645

bracketing xti-only methods

2011-01-07 23:37 SC, revision 66644

adding xti info

2011-01-07 23:31 SC, revision 66643

common rtti in nbkbase.cpp

2011-01-07 23:14 SC, revision 66642

correcting merge conflict

2011-01-07 23:01 SC, revision 66641

common rtti in fontcmn.cpp

2011-01-07 22:51 SC, revision 66640

avoid type conflict with univ wxMenuInfo

2011-01-07 22:50 SC, revision 66639

avoid type conflict with univ wxMenuInfo

2011-01-07 22:37 SC, revision 66638

fixing class name

2011-01-07 22:36 SC, revision 66637

having menu classinfo at one place

2011-01-07 21:55 SC, revision 66636

routing to common classinfo for non-xti builds

2011-01-07 21:06 SC, revision 66635

remove non-xti classinfo

2011-01-07 19:26 VS, revision 66634

Implement wxCOL_WIDTH_AUTOSIZE on OS X. Only Cocoa build on 10.5+ is supported. Before that, NSOutlineView didn't have reasonable support for determining cell sizes.

2011-01-07 19:15 PC, revision 66633

move default OnInternalIdle processing to wxWindowBase

2011-01-07 19:14 SC, revision 66632

updated xti sample

2011-01-07 18:50 SC, revision 66631

xti changes

2011-01-07 18:49 SC, revision 66630

xti changes

2011-01-07 18:46 SC, revision 66629

removing xti info from msw specific files

2011-01-07 18:45 SC, revision 66628

removing xti info from msw specific files

2011-01-07 18:44 SC, revision 66627

aligning definition of rtti

2011-01-07 18:43 SC, revision 66626

xti changes

2011-01-07 18:42 SC, revision 66625

adding range type

2011-01-07 18:41 SC, revision 66624

moved xti info to common file

2011-01-07 18:29 SC, revision 66623

props

2011-01-07 18:28 SC, revision 66622

additional file, test auto-props

2011-01-07 18:22 SC, revision 66621

XTI updates

2011-01-07 18:20 PC, revision 66620

remove some extraneous semicolons

2011-01-07 18:18 PC, revision 66619

build fix, should have been part of r66615

2011-01-07 15:03 JJ, revision 66618

Update OpenVMS compile support

2011-01-07 09:48 DS, revision 66617

Fixed saving PNG in wrong format sometimes. When explicitly requesting saving as a palettised image but then later on that turns out to not be possible (or desired) the image would be marked as PNG_COLOR_TYPE_GRAY or PNG_COLOR_TYPE_GRAY_ALPHA. Simply set the colour type to RGB if this occurs also updated the unit test to catch this case. This is similar to the fix in r66590 but that one was related to wxUSE_PALETTE == 0 cases.

2011-01-07 07:45 PC, revision 66616

build fix, should have been part of r66615

2011-01-07 06:26 PC, revision 66615

Move wxColourData and wxFontData into separate files. This eliminates a linking dependency that would drag in the printing code for any program that used wxColourDialog or wxFontDialog (which is currently all of them, due to more link dependencies...)

2011-01-07 05:51 PC, revision 66614

build fix

2011-01-07 05:50 PC, revision 66613

non-pch build fixes

2011-01-06 23:02 VZ, revision 66612

Add possibility to hide panels in wxRibbon. Add wxRibbonBar::{Show,Hide}Panels() and ArePanelsShown() accessor. Also add a toggle button to the sample to test the new functionality (unfortunately it couldn't be done by a control in the ribbon itself as there would be no way to show the panels back then). Closes #12707.

2011-01-06 20:52 SJL, revision 66611

Add missing code tag before lots of wxEventTypes in the documentation. Although most of the documentation did this quite a few were missing.

2011-01-06 15:33 VS, revision 66610

Fix typo and a leftover.

2011-01-06 13:05 SC, revision 66609

reverting AssignAny fix, not needed if wxAny is not instantiated during static globals init

2011-01-06 12:06 SC, revision 66608

fixing a few typos, wxAny copy constructor implementation, making wxAnyList available everywhere

2011-01-06 10:30 JJ, revision 66607

Update compile support for OpenVMS

2011-01-06 00:54 VZ, revision 66604

Remove wxFileSystemWatcher::OnXXX() virtual methods documentation. These functions don't exist any more (they had been present initially but were removed in r61484 and r61476 for Unix and MSW respectively) so don't document them. See #12847.

2011-01-06 00:54 VZ, revision 66603

Correct wxFileSystemWatcher::GetWatchedPathsCount() documentation. The method name was misspelt. Also improve the description slightly. See #12847.

2011-01-06 00:52 VZ, revision 66602

Correct measurement for owner drawn menu items with only unchecked bitmap. Check for either checked or unchecked bitmap being specified for the item instead of checking the checked/normal bitmap twice which was an obvious typo and also resulted in items with unchecked bitmap only not being measured correctly (although I'm not sure if this is actually a supported use case). Closes #12846.

2011-01-06 00:49 VZ, revision 66601

No changes, just fix a typo in a variable name. s/widtht/width/ See #12846.

2011-01-05 19:38 PC, revision 66593

make wxMarkupEntities fully const

2011-01-05 19:27 PC, revision 66592

move variable definitions to more appropriate places, remove now-empty src/common/datacmn.cpp

2011-01-05 12:41 DS, revision 66591

Allow loading 8-bit TGA images when wxUSE_PALETTE is set to 0. Previously the image would only be loaded when wxPalette is available. This is unneccessary and probably not wanted. Instead decode as usual but use a plain memory buffer for the palette instead of wxPalette functions and don't set the image's palette.

2011-01-05 12:39 DS, revision 66590

Always save PNG as a true colour image instead of possibly a palettised image when wxUSE_PALETTE is set to 0. With wxUSE_PALETTE set to 0 and the user forcing to want a wxPNG_TYPE_PALETTE format the image would (partially) be marked as PNG_COLOR_TYPE_GRAY or PNG_COLOR_TYPE_GRAY_ALPHA instead and also saving would fail later on. Instead detect this specific case and save in the wxPNG_TYPE_COLOUR format.

2011-01-05 12:37 DS, revision 66589

fixed compilation of image test units when wxUSE_PALETTE is set to 0

2011-01-05 11:44 SC, revision 66588

was missing in xti merge

2011-01-05 11:29 SC, revision 66587

was missing in xti merge

2011-01-05 10:56 SC, revision 66586

was missing in xti merge

2011-01-05 08:30 JJ, revision 66585

Update compile support for OpenVMS

2011-01-05 07:56 PC, revision 66584

set eol-style and keywords properties on new files

2011-01-05 00:48 VZ, revision 66583

Fix wxImage test compilation for MSVC6. Don't reuse variables declared inside for loops as VC6 doesn't implement proper scoping for them.

2011-01-04 22:33 VZ, revision 66582

Disable wxCompositeWindow<> code for VC6. Revert the attempt to work around VC6 bug from the last commit and simply disable this code completely for VC6, it's not worth the trouble to try to fix it for this compiler.

2011-01-04 20:00 DS, revision 66581

compilation fixes for wxMSW compilation with wxUSE_PALETTE set to 0

2011-01-04 18:08 VZ, revision 66580

Attempt to make wxCompositeWindow<> compile with MSVC6. Blind attempt to work around VC6 error about ambiguity between "const T&" and "T" in DoSetForAllParts() template function.

2011-01-04 17:21 VZ, revision 66579

Remove duplicate IMPLEMENT_XXX_CLASS macros from wxUniv code. The RTTI macros are now used in common code only and having them in wxUniv too results in linker errors because of duplicate symbols. Just remove them to fix this.

2011-01-04 17:21 VZ, revision 66578

Declare wxStaticText in wxUniv as being dynamic, not abstract, class. This fixes a wxUniv build error due to the use of IMPLEMENT_DYNAMIC_CLASS() for wxStaticText in common code now. Closes #12842.

2011-01-04 16:10 VZ, revision 66577

Compilation fix for PNG saving code when wxUSE_PALETTE==0. Don't handle wxPNG_TYPE_PALETTE and don't compile PaletteFind() in at all when wxUSE_PALETTE is off. Closes #12505.

2011-01-04 16:08 SC, revision 66576

correct macro name

2011-01-04 15:37 SC, revision 66575

is a #deffed var

2011-01-04 15:13 VZ, revision 66574

Use wxControl instead of wxControlWithItems with wxRTTI macros. wxControlWithItems is just a convenient combination of wxControl and wxItemContainer mix-in and it is not useful to include it in wxRTTI classes hierarchy. Also, using wxControlWithItems as the base class for wxChoice and wxListBox but not for wxComboBox is inconsistent but wxControlWithItems can't be used for the latter so resolve this by not using it at all. Ideally we'd have a way of retrieving the list of supported interfaces (such as wxItemContainer or wxTextEntry) via wxRTTI too.

2011-01-04 15:13 VZ, revision 66573

Use wxControl as wxComboBox base class for wxRTTI in all ports. wxComboBox only derives from wxChoice in wxMSW but not in the other ports so use wxControl as its base class in wxIMPLEMENT_DYNAMIC_CLASS_XTI() macro in all ports. See #12841.

2011-01-04 15:09 SC, revision 66572

fixing rti

2011-01-04 14:33 DS, revision 66571

Minor wxPNGHandler cleanup. Use int instead of png_uint_16 everywhere regarding number of palette entries, similar to how libpng exposes it (internally it uses png_uint_16).

2011-01-04 14:06 DS, revision 66570

Fixed deprecated usage warnings in wxPNGHandler. Since upgrading to a newer libpng its structure members are marked as deprecated (probably as a way to discourage their direct usage). Replaced accessing them by using function calls instead.

2011-01-04 13:52 SC, revision 66569

add rtti for generic class

2011-01-04 12:48 VZ, revision 66568

Remove duplicate IMPLEMENT_DYNAMIC_CLASS() for wxGtkCalendarCtrl. wxIMPLEMENT_DYNAMIC_CLASS_XTI(wxCalendarCtrl) in the common code makes the use of IMPLEMENT_DYNAMIC_CLASS() in wxGTK implementation unnecessary. This fixes wxGTK linking.

2011-01-04 12:48 VZ, revision 66567

Don't use "/*" inside a C comment. gcc warns about it so replace the outer comment with "#if 0" to avoid it.

2011-01-04 12:47 DS, revision 66566

Cleaned up wxGIFDecoder. Applied patch by troelsk which mostly makes the GIF decoder more readable by using named constants instead of magic numbers. Left out the edits that changed unsigned char to wxUint8. In addition removed unnecessary casts around wxInputStream.GetC() calls. Closes #12506.

2011-01-04 12:41 SC, revision 66565

removing msw dependency in non-precomp build

2011-01-04 12:33 VZ, revision 66564

wxMSW compilation fix for wxCompositeWindow. Not all ports override SetXXX() methods in their wxWindow class so use the versions from wxWindowBase which are definitely known to exist. Notice that the call itself is still virtual so it doesn't matter which base class do we use. Closes #12840.

2011-01-04 12:30 VZ, revision 66563

Mention that wxDV_ROW_LINES is not implemented in the generic version. wxDV_ROW_LINES is currently only supported by the native implementations of wxDataViewCtrl. See #12834.

2011-01-04 12:17 SC, revision 66562

removing msw dependency in non-precomp build

2011-01-04 11:47 SC, revision 66561

porting back exact semicolon version

2011-01-04 11:46 SC, revision 66560

fixing placing of common files for grid and calctrl

2011-01-04 10:20 SC, revision 66559

fixing duplicate rti info for gtk

2011-01-04 10:14 SC, revision 66558

fixing duplicate rti info

2011-01-04 10:13 SC, revision 66557

fixing duplicate rti info

2011-01-04 09:34 SC, revision 66556

updating xti makefile

2011-01-04 09:31 SC, revision 66555

merging back XTI branch part 2

2011-01-04 09:28 SC, revision 66554

fixing selectors

2011-01-04 09:25 SC, revision 66553

add methods needed for XTI

2011-01-03 23:22 DS, revision 66552

Added support for saving PNG files with palette. Based on (heavily modified) patch by troelsk. Closes #12505.

2011-01-03 19:44 VZ, revision 66549

Set up pages range in the wxMSW print dialog correctly. Propagate the information about the number of pages from the printout to the print dialog in wxWindowsPrinter::Print(). Closes #12819.

2011-01-03 19:44 VZ, revision 66548

Add "virtual" keywords to the overridden functions in the printing sample. There are no real changes, just make it easier to understand that the sample code overrides the base class virtual methods by reusing the virtual keyword in the derived class. See #12819.

2011-01-03 19:43 VZ, revision 66547

Don't create slider with invalid range in mediaplayer sample. Use dummy but valid [0, 1] range instead of invalid [0, 0] one. Closes #12828.

2011-01-03 19:43 VZ, revision 66546

Don't name variables "id" in public headers. This name clashes with Objective-C reserved keyword and so prevents the headers using it from being included from Objective-C++ code. Closes #12832.

2011-01-03 19:08 SC, revision 66545

fixing warning and compile error against 10.4

2011-01-03 18:43 SC, revision 66544

adding new files for xti merge

2011-01-03 18:15 PC, revision 66543

build fix for wxUSE_CONSOLE_EVENTLOOP==0

2011-01-03 18:06 PC, revision 66542

non-pch build fix

2011-01-03 16:57 VZ, revision 66541

Decrease the margins around the page in the print preview. Don't hard code 40 pixel margins, this may be too big on small screens. Use twice the default border size between the dialog elements instead, this is still pretty arbitrary but at least smaller.

2011-01-03 16:57 VZ, revision 66540

Don't hardcode wxPreviewControlBar size in print preview code. For some reason the control bar height was hard coded to 40 pixels which could be not enough to use the buttons of the appropriate size. Don't hardcode its size any more and let the sizer determine it instead.

2011-01-03 16:57 VZ, revision 66539

Improve print preview appearance and functionality. Allow to directly enter the page number in the print preview itself instead of opening a separate dialog in order to do it. Rearrange the buttons in more visually appealing groups and replace the text arrows in them with the images.

2011-01-03 16:34 VS, revision 66538

Debug messages aren't meant to be translated. Fixed several incorrect uses of _() in dataview_osx.cpp.

2011-01-03 15:58 VZ, revision 66537

Don't use deprecated NSTableView selectRow:byExtendingSelection: method. Use selectRowIndexes:byExtendingSelection: instead even if this means that we need to create a trivial NSIndexSet containing a single index only.

2011-01-03 15:58 VZ, revision 66536

Allow selecting any kind of file in the sound sample. This is especially useful under Mac where wxSound can play files other than .wav too (e.g. .aiff files which can be found under /System/Library/Sounds).

2011-01-03 14:46 JJ, revision 66535

update configuration for OpenVMS

2011-01-03 12:24 VZ, revision 66534

Add wxCompositeWindow<> and use it in wxDatePickerCtrlGeneric. wxCompositeWindow<> is a convenient base class for composite windows, i.e. windows consisting of several other wxWindows. Currently it just automatically forwards various attributes setters calls to all of the composite window parts but it could become more useful in the future. Similarly, for now it is only used in wxDatePickerCtrlGeneric but it could (and should) be used for other composite controls later and we probably should even make this class public to allow its use in the client code.

2011-01-03 12:23 VZ, revision 66533

No real changes, just remove an unneeded header dependency. There was some commented out code in (core) valgen.cpp file using wxDatePickerCtrl (from adv library). Also comment out the inclusion of wx/datectrl.h header as it's not needed as long as this code remains commented out and creates an unexpected dependency of a core library file on an adv library header.

2011-01-03 12:01 DS, revision 66532

Fixed compilation of datectlg.cpp. Only including wx/datectrl.h does not always include wx/generic/datectrl.h, for example it does not for MSW non-Universal. As a result when compiling datectlg.cpp wxDatePickerCtrlGeneric is unknown and compilation fails. Fixed by including wx/generic/datectrl.h again (regression since r66524).

2011-01-02 23:05 VZ, revision 66528

Remove calls to wxApp::SetTopWindow() from the samples and documentation. It is definitely not necessary to call SetTopWindow() when there is only a single top level window and it is arguable whether it's useful to do it even when there are many of them so don't encourage its use in the documentation and also remove all its occurrences from the samples. Closes #12816.

2011-01-02 23:04 VZ, revision 66527

Simplify wxFileNameFromPath() implementation to avoid redundancy. No real changes, just use wxFileName::GetFullName() in wxFileNameFromPath() instead of reimplementing it there. Closes #12818.

2011-01-02 23:04 VZ, revision 66526

Fix memory leak if wxDC::DrawBitmap() fails in wxOS2. Don't forget to free the buffer if we return abnormally. Closes #12825.

2011-01-02 23:04 VZ, revision 66525

Use correct delete[] for a buffer allocated with new[]. Fix mismatch between scalar new and array delete in GetPathForIconFile() in wxOSX wxMimeTypeManager code. Closes #12826.

2011-01-02 23:03 VZ, revision 66524

Forward declare classes instead of including their declarations. No real changes, just reduce the compilation dependencies a bit by only forward declaring wxComboCtrl and wxCalendarCtrl in wx/generic/datectrl.h instead of including the headers with their full declarations.

2011-01-02 17:59 PC, revision 66523

fix preprocessor expression, closes #12822

2011-01-02 17:49 JMS, revision 66522

Allow any.cpp to compile without wxDateTime support (see #12821)

2011-01-02 13:08 JS, revision 66521

Added circle-outline standard bullet style

2011-01-02 11:14 JMS, revision 66520

Added 'HasAlpha' attribute for wxColourProperty. Setting it to true allows user to edit the alpha component.

2011-01-01 17:25 SC, revision 66515

pusing a dummy event, to make sure the stop: succeeds in immediate runloop termination, instead of waiting for the next user event

2011-01-01 12:10 SC, revision 66514

bracketing msw enhanced metafile usage

2011-01-01 12:06 SC, revision 66513

fixing iterator comparison

2010-12-31 20:38 VZ, revision 66510

PCH-less compilation fix in recently added wxTangoArtProvider. The use of wxLogDebug() requires inclusion of wx/log.h.

2010-12-31 18:39 VZ, revision 66506

Add wxUSE_ARTPROVIDER_STD build option. Make it possible to exclude wxDefaultArtProvider from build. Now that a Tango-based provider exists, it may make sense to disable the standard bitmaps if the program doesn't need the few of them not provided by Tango anyhow.

2010-12-31 18:39 VZ, revision 66505

Add wxArtProvider using Tango icons. The icons are embedded as PNG images directly in the source code to avoid the need for installing them. This does make the library larger though so provide a wxUSE_ARTPROVIDER_TANGO option to turn the new code and associated bloat off. Also turn it off by default under wxGTK as the native art provider is used there anyhow.

2010-12-31 18:39 VZ, revision 66504

Add go to first/last and plus/minus art provider icons. These icons will be used in the upcoming new implementation of the print preview frame and as they are also natively supported by GTK+ it makes sense to have support for them in wx itself. Notice that the existing bookmark add/remove icons are already mapped to the icons which look like plus and minus signs respectively in wxGTK but we need plus/minus in print preview in the other ports too so add these icons under explicit names.

2010-12-31 18:38 VZ, revision 66503

Make art provider id of type "char *" instead of "wxChar *". These strings don't need to be wide and, as elsewhere, prefer the compatibility with 2.8 ANSI build to compatibility with Unicode build.

2010-12-31 18:38 VZ, revision 66502

Add an option to embed image size in its name to PNG-to-C script. When a PNG image exists in several sizes it makes sense to use its size as a suffix to distinguish the different versions, so update the png2c script to optionally allow to do this. Current implementation simply checks the PNG header directly to avoid any extra dependencies.

2010-12-31 18:38 VZ, revision 66501

Show wxART_BUTTON icons in art provider sample resource browser. The button icons have a different size from all the other clients in wxGTK so it may be interesting to see them in the sample, add wxART_BUTTON to the list of art clients that can be chosen in it.

2010-12-31 18:38 VZ, revision 66500

Accept file names with dashes in PNG-to-C converter. Tango icon files often have dashes in their names so accept them in png2c conversion script and simply replace them with underscores to form a C identifier for the array containing the image data.

2010-12-31 18:29 VZ, revision 66499

Use open command to run the GUI unit test on Mac build slave. Running the application binary directly still doesn't work quite the same as when it's opened from Finder (or executed using open) and some tests involving event loops fail because of this. Run it using open even if it means that we lose the detailed log output.

2010-12-31 16:23 JMS, revision 66498

Revert unintended commit

2010-12-31 16:20 JMS, revision 66497

Try to better revert to the original string value in wxBitmapComboBox::RecreateControl()

2010-12-31 14:12 VZ, revision 66496

Document how to get the previous selection in wxEVT_GRID_SELECT_CELL handler. Make explicit the fact that the cell coordinates in the event are the coordinates of the newly selected cell and that the previously selected one is available from wxGrid itself.

2010-12-30 23:37 VZ, revision 66495

Move wxMSW wxCommandLinkButton files to native-only part. wxMSW wxCommandLinkButton implementation shouldn't be used in wxUniv so move src/msw/commandlinkbutton.cpp and include/wx/msw/commandlinkbutton.h to ADVANCED_MSW_NATIVE_{SRC,HDR} from ADVANCED_MSW_{SRC,HDR} in files.bkl and rebake the makefiles. This fixes wxUniv/MSW compilation.

2010-12-30 23:37 VZ, revision 66494

Compilation fixes for wxUniversal/MSW. Don't use wxMSW-specific functions when building wxUniversal.

2010-12-30 23:37 VZ, revision 66493

Move wxGetLibraryVersionInfo() to core from base. This function uses the GUI toolkit information and so can't be defined in wxBase. The code only compiled before because the function was erroneously defined in wxCore even though it was declared as WXDLLIMPEXP_BASE. Fix this by declaring it with WXDLLIMPEXP_CORE too. This corrects problems in MSW DLL build. If we need to get a string containing user-readable wxBase version too, we should add another function (as it's not possible to virtualize this one) but such function doesn't seem incredibly useful to have anyhow.

2010-12-30 23:36 VZ, revision 66492

Don't crash on malformed HTML in wxHTML font tag handler. Don't try to access the first character of the size parameter value before we are sure that it is not empty. Closes #12812.

2010-12-29 13:31 DS, revision 66491

Tightened icon and cursor file detection heuristics. When loading a TGA file that has an image type of uncompressed true colour it would be falsely detected as a cursor file and as an icon file if type is of uncompressed colour mapped. Lower the chance of this happening by also checking the remaining member of an ICO and CUR header which represents the number of images in the file. This member has to be non-zero (checked against all found ICO and CUR files in an XP installation). See also #12702.

2010-12-29 01:01 VZ, revision 66486

Update the generated makefile after wxOSX OpenGL changes. Rebake the makefile after the changes in r66357.

2010-12-28 23:38 DS, revision 66485

Added saving support to TGA image handler. Supports saving 24-bit and 32-bit (RGB with alpha). Updated image unit test to verify the alpha channel of saved TGA images. Also removed a condition skipping a test which only was in place for TGA (formerly its saving handler would do nothing yet say saving was succesful). See also #7661.

2010-12-28 23:05 DS, revision 66483

Expanded existing image saving test to also verify alpha content of saved images. Compare the alpha data of saved images (where applicable, currently for PNG only) to a generated alpha channel. Refactored most of ImageTestCase.CompareSavedImage into (static) function CompareImage to easily compare with a 24-bit image and then a 32-bit one.

2010-12-28 20:50 DS, revision 66478

Added some simple unit tests for verifying pixel content of loaded and saved images. Compare the data of loaded images in different formats against a reference image (one for 8-bit images, another for 24-bit). Do the same for images saved using SaveFile. Excluded some formats because they are either lossy or don't pass the test right now.

2010-12-28 17:44 SC, revision 66477

removing obsolete NO_PRAGMA

2010-12-28 16:57 DS, revision 66476

Updated manual regarding image alpha support for BMP, PNG, and TIFF handlers. For PNG it was mentioned only loading supports alpha, but alpha saving support has been available since r32414. Similarly there was no mention of alpha loading support for TIFF (supported since r47204) as well as BMP (since r54942).

2010-12-27 21:47 RD, revision 66474

Fix various missing or broken stuff needed for Project Phoenix

2010-12-27 14:16 SC, revision 66459

adding backtab to exception list

2010-12-27 12:50 JMS, revision 66458

Removed AdvImageFileProperty from the wxPropertyGrid sample. It was somewhat impractical and bug-prone.

2010-12-27 12:25 JMS, revision 66457

Test wxPropertyGrid::DoubleToString()

2010-12-27 12:17 JMS, revision 66456

No longer use semi-static IDs for wxPropertyGrid embedded controls and tool bar tools.

2010-12-27 07:31 SC, revision 66455

adding backtab to exception list

2010-12-27 07:30 SC, revision 66454

make sure we always have a return value

2010-12-26 17:29 VZ, revision 66452

Increase wxStaticText height in wxMSW to align its text with wxTextCtrl. The base lines of the text in wxTextCtrl and wxStaticText which were themselves vertically aligned didn't align, the text in the latter was one pixel too low. This seems to be happening because we don't give enough vertical space to the native static control by default and so, while the text wasn't truncated, it was positioned differently than usual. Work around this problem by allocating two extra pixels to wxStaticText height. While the exact explanation of the problem remains mysterious, this hack does result in correct appearance which seems to be sufficiently important to apply it.

2010-12-25 15:19 VZ, revision 66447

Compilation fix for wxMSW build without PCH. We need wxApp declaration since the changes of r66425.

2010-12-25 15:18 VZ, revision 66446

Test for wcsftime() in configure as it's not available everywhere. Contrary to the comment in wx/wxcrtbase.h, wcsftime() doesn't seem to be available under quite all the systems, notably it doesn't seem to be present in OpenBSD at all, even in the very latest version. Add a configure test for this function and fall back to our own implementation if the system doesn't have it. Closes #12766.

2010-12-25 15:18 VZ, revision 66445

Give an error from configure if wchar_t is not available. wxWidgets 2.9 doesn't support building without wchar_t any more so always define wxUSE_WCHAR_T and give an error from configure if wchar_t is really not available.

2010-12-25 14:46 VZ, revision 66444

Make the margin between wxSpinCtrlGeneric sub-windows compatible with MSW. Native MSW wxSpinCtrl uses a single pixel margin between the text part and the spin button while the generic version used 2 pixels which resulted in a slightly different appearance (see #12767). Use the same margin as MSW now in the generic version too, it should be fine for the other platforms as well and if it isn't we can always tweak them later.

2010-12-25 14:46 VZ, revision 66443

Correct bug in the wxSpinCtrlGeneric sub-controls resizing. The code in DoMoveWindow() didn't account for the margin and made the text control part of the window too large resulting in the truncation of the spin button. Simply remember to take margin into account when computing the text width. See #12767.

2010-12-25 14:19 VZ, revision 66442

Document wxItemContainer::SetStringSelection() as case-insensitive. Add unit tests checking that the behaviour really corresponds to the documentation too. And also mention that it's not a good idea to have strings differing by case only in wxComboBox anyhow.

2010-12-25 14:18 VZ, revision 66441

Minor improvements to wxComboBox documentation. Mention that wxCB_DROPDOWN is MSW (and Motif...) specific and don't document the much more often used wxCB_READONLY in its terms, just describe it directly instead.

2010-12-23 13:48 VZ, revision 66440

Run tests with "-t" option on OS X too. OS X build slave used its own commands to run unit tests, add -t to them too to be (hopefully) able to see better where does the test crash exactly.

2010-12-23 13:47 VZ, revision 66439

Correct Mac OX/iPhone check in libpng. Correct the syntax of preprocessor check for wxOSX_USE_IPHONE in libpng, it got somehow broken during upgrade to 1.4.4.

2010-12-23 11:26 JMS, revision 66438

Added dummy GetTextWidget() implementation for wxMotif wxComboCtrl

2010-12-22 19:44 JMS, revision 66435

Added section 'Customizing Keyboard Handling' into wxPropertyGrid overview

2010-12-22 18:43 JMS, revision 66433

Bring AddActionTrigger() doc string up to date with the interface

2010-12-22 18:25 JMS, revision 66432

Added wxPG_ACTION_EDIT, which allows specifying custom key to move focus to the property editor. Also documented wxPG_ACTION_FOOs better.

2010-12-22 14:57 VZ, revision 66431

Switch to GtkTooltip from deprecated GtkTooltips in wxGTK wxToolTip. Don't use deprecated GtkTooltips in wxGTK code any more, use the new GtkTooltip instead. Closes #12034.

2010-12-22 14:57 VZ, revision 66430

Really fix recently broken accelerators handling in menu items. As wxAcceleratorEntry::Create() now expects the full menu item label, just pass GetItemLabel() to it in wxMenuItemBase::GetAccel() instead of half- parsing it ourselves there. Closes #12794.

2010-12-22 14:57 VZ, revision 66429

Implement proper wxCursor cloning in wxDFB. wxDFB compilation was broken by recent wxObjectRefData copy ctor-related changes. Fix it by not using wxCursorRefData copy ctor any more, call wxCursorRefData::Clone() which does the right thing explicitly instead. Closes #12791.

2010-12-22 14:57 VZ, revision 66428

Use stock ids for menu items in the config sample. This not only removes some unnecessary code from the sample but also fixes a problem due to the use of a 0 id under wxOSX (which is unsupported there). Closes #12788.

2010-12-22 14:57 VZ, revision 66427

Compute print preview scale using real DPI values in wxGTK. Replace hardcoded 72 DPI which was "compensated" for with a 0.8 fudge factor with the values using the real screen DPI in wxGTK and PostScript print preview classes. Closes #12777.

2010-12-22 14:56 VZ, revision 66426

Correct and extend wxConfig::Create() documentation. Replace mentions of the non-existent wxCONFIG_WIN32_NATIVE with wxUSE_CONFIG_NATIVE. Also explain what does the "best implementation" really mean and link to wxAppTraitsBase::CreateConfig(). Closes #12787.

2010-12-22 14:56 VZ, revision 66425

Use generic wxHyperlinkCtrl under Vista/7 without comtrl32.dll v6. Replace the test for the OS version with the test for comtrl32.dll version in HasNativeHyperlinkCtrl() wxMSW function as the native control could be not available even under Vista/7 if we're not using comtrl32.dll v6 and this can happen if the program was linked without the appropriate manifest or, possibly more likely, if a DLL using wxWidgets was loaded by such a program. Closes #12711.

2010-12-21 20:38 RR, revision 66424

Don't let anything, such as pressing F2, start editing an entry if the renderer is set to wxDATAVIEW_CELL_INERT

2010-12-21 20:27 RR, revision 66423

model column and index of column in the dataview can be different, correct this and also make wxGTK and wxMSW report the same thing in the event following wxDataViewModel::SetValue(), fixes #12755: wxDataViewCtrl bug when the column is mapped to different model column. Also commit some older change reseting the cursor under the mouse.

2010-12-21 12:12 JS, revision 66422

XML output corrections

2010-12-21 12:12 JS, revision 66421

Fixed bad rendering with tabs by correcting the position tabs are calculated from

2010-12-21 12:11 JS, revision 66420

Fixed bad rendering with tabs by correcting the position tabs are calculated from

2010-12-20 20:15 RR, revision 66417

Better wording in docs

2010-12-20 20:13 RR, revision 66416

Correction to: Support diabling items in GTK+, see #12686: Allow disabling of wxDVC items

2010-12-20 18:40 JS, revision 66413

Added apos entity

2010-12-20 15:54 JMS, revision 66412

Removed non-implemented function prototype OnMouseWheel() from wxVListBoxComboPopup

2010-12-20 15:21 JMS, revision 66411

Use locale-specific decimal point in wxNumericPropertyValidator (fixes #12790)

2010-12-20 14:55 JMS, revision 66410

Added OwnerDrawnComboBoxTestCase (currently only has copies of wxComboBox tests)

2010-12-20 14:51 JMS, revision 66409

Added wxComboPopup::FindItem() to help in deciding how SetValue() should change the value of a read-only wxComboCtrl. This allows wxOwnerDrawnComboBox to have the same behavior as wxComboBox in that respect.

2010-12-20 14:33 JJ, revision 66408

correction to make wxGTK1 compile

2010-12-20 12:27 JMS, revision 66407

Have wxUniv wxComboBox inherit from wxItemContainer instead of wxComboBoxBase, since the latter is derived from wxTextEntry which conflicts with the recent change in wxComboCtrl (fixes #12789)

2010-12-20 12:23 JMS, revision 66406

Added dummy-wxTextEntry implementation section for wxUniversal

2010-12-20 10:23 JJ, revision 66405

include compile support for tests on OpenVMS (part3)

2010-12-19 20:43 RR, revision 66404

Support diabling items in GTK+, see #12686: Allow disabling of wxDVC items

2010-12-19 16:02 VZ, revision 66403

Add the possibility to disable invisible wxDataViewCtrl items. Add new wxDataViewModel::IsEnabled() and wxDataViewListStore::IsEnabledByRow() methods and implement support for actually disabling the items in wxOSX/Cocoa native implementation of wxDataViewCtrl and limited support for it in the generic version. We need to implement this in wxGTK using GtkCellRenderer "sensitive" propriety later. Closes #12686.

2010-12-19 16:02 VZ, revision 66402

Store menus titles in menus themselves in wxOSX. Get rid of wxMenuBar::m_titles array which doesn't seem to be needed and just store the titles in the menus themselves instead. This makes wxMenu::GetTitle() work as in the other ports and fixes unit test failures in menu test. It also makes it unnecessary to duplicate the base class Find[Menu]Item() methods in wxOSX wxMenuBar so simply remove them entirely.

2010-12-19 16:02 VZ, revision 66401

No real changes, just get rid of _wxMenuAt() in wxOSX menu code. The _wxMenuAt() function was totally unnecessary and duplicated the existing wxMenuBar::GetMenu() so simply remove it and use GetMenu() instead.

2010-12-19 16:02 VZ, revision 66400

Fix initial gradient point calculation in wxOSX. This fixes the bug introduced in r63879 which used the wrong indices into the stops array resulting in visual artefacts in wxAUI, for example (and also possible crashes due to accessing out of bound array elements). Closes #12784.

2010-12-19 15:08 VZ, revision 66399

Preserve wxSlider value when changing its range in wxOSX too. This fix is similar to r66368 for wxMSW and preserves the slider value when its range changes. This is necessary because while the underlying native control value doesn't change when the range is, the logical value of wxSlider does change if it must be inversed as this depends on the range. See #12765.

2010-12-17 13:23 JMS, revision 66398

Make wxOwnerDrawnComboBox sorting identical to the MSW sorting (same as wxComboBox)

2010-12-17 13:08 JMS, revision 66397

Add wxComboBox-compatible Popup() and Dismiss() functions in wxComboCtrl

2010-12-17 12:50 JMS, revision 66396

Add enough default arguments to one wxOwnerDrawnComboBox ctor so it can be consructed using only two arguments, same as the wxComboBox

2010-12-17 12:39 JMS, revision 66395

Mostly change the wxOwnerDrawnComboBox text value using ChangeValue() instead of SetValue()

2010-12-17 12:20 JMS, revision 66394

Make the wxComboCtrl's wxTextEntry interface more complete and consistent. All text is no longer selected on SetValue(), but only when user selects an item from the drop-down list.

2010-12-17 01:56 RD, revision 66391

Use a " " (space) for the menu item if an empty string is used for an item in a wxChoice, in order to avoid an assert in wxMenuItem.

2010-12-16 20:25 JMS, revision 66389

Removed a return statement from void function

2010-12-16 19:13 JMS, revision 66388

Resolve ambiguity with wxOwnerDrawnComboBox::Clear(), virtual method which is derived from two base classes

2010-12-16 19:08 JMS, revision 66387

In wxBitmapComboBox dtor, call DoClear() instead of ambiguous Clear()

2010-12-16 19:07 JMS, revision 66386

Override wxTextEntry::GetSelection(long *from, long *to) in wxOwnerDrawnComboBox to resolve virtual method hiding issues

2010-12-16 18:21 JMS, revision 66385

Instead of having wxComboCtrl mimic wxTextEntry interface, make it actually inherit from the class and implement functions to redirect to the embedded wxTextCtrl. This allows us to simplify the code and get rid of the dirty trick of directing wxComboCtrl's validator to the embedded wxTextCtrl. Also see #12779, which issue 1 is fixed by this change.

2010-12-16 17:12 JMS, revision 66384

Document how the sign is omitted from wxFloatProperty's displayed value when it is effectively zero (closes #12738).

2010-12-15 14:36 VZ, revision 66383

Initialize wxLogWindow::m_pLogFrame in ctor to avoid (rare) crash. If the log frame creation itself generates log messages, the code using wxLogWindow could crash because its m_pLogFrame member variable wasn't initialized yet at this moment. Do set it to NULL initially now to avoid this.

2010-12-15 13:04 VZ, revision 66382

Compilation fixes for wx{X11,GTK1,Motif} after making ref data non copyable. Don't use wrong compiler-generated copy ctors in the other ports neither (see r66371..66373 for wxGTK fixes). This fixes compilation after r66374 without reducing functionality but just making it more clear where it is missing.

2010-12-15 13:04 VZ, revision 66381

Compilation fix for wxMotif PCH build. We need to include wx/unix/utilsx11.h even when using PCH to get wxCharCodeXToWX() declaration.

2010-12-15 13:03 VZ, revision 66380

Update accelerator unit test to pass after recent changes. Changes of r66379 broke the unit test as wxAcceleratorEntry::Create() now requires the TAB to be present in the string passed to it (again). Update the test to make it pass.

2010-12-15 12:18 VZ, revision 66379

Don't pass strings not containing accelerators to ParseAccel(). Check for the presence of accelerator part in the string passed to wxAcceleratorEntry::Create() and don't call ParseAccel() at all if it's not there. This avoids the spurious warnings about unrecognized accelerators when creating menu items that don't have any accelerators at all. Also update wxAcceleratorEntry::FromString() documentation to mention that the new code should pass just the accelerator to this function and that it only accepts full menu item labels for compatibility. Closes #12770.

2010-12-15 11:54 JJ, revision 66378

Include compilation of tests for OpenVMS (part2)

2010-12-15 10:51 JJ, revision 66377

Include compilation of tests for OpenVMS (part1)

2010-12-14 19:44 VZ, revision 66376

Return false, not NULL, from a function returning bool. Fix a warning (which might be an error with some compilers) about returning NULL from bool wxRichTextImageBlock::DoMakeImageBlock() function.

2010-12-14 19:43 VZ, revision 66375

No real changes, just add a cast to fix a warning. Fix warning about implicitly converting -1 to CGKeyCode when building wxOSX with 10.4 SDK.

2010-12-14 19:43 VZ, revision 66374

Make wxRefCounter non copyable. wxRefCounter copy ctor was wrong as the new object had the same reference count as the old one instead of starting its life with reference count set to 1 as any new object should. While we could fix its copy ctor, it seems to be better to forbid copying wxRefCounter objects at all because the semantics of doing this is not obvious and the compiler-generated copy ctor in the derived classes often doesn't do what the code using it expects it to do, as was discovered by making wxRefCounter non copyable: see the fixes in the previous commits. To uncover all such bugs, make wxRefCounter and classes deriving from it non copyable. If this uncovers more problems, they should be fixed by implementing copying properly (and explicitly) in the derived classes. Closes #12768.

2010-12-14 19:43 VZ, revision 66373

Fail in CloneGDIRefData() instead of implementing it incorrectly in wxOSX. wxIcon and wxMetaFile implemented CloneGDIRefData() using copy ctors of the corresponding ref data classes but the copy ctors were either wrong (for wxIconRefData as using it would result in messing up IconRef reference count) or had wrong semantics (wxMetafileRefData copy ctor performed shallow copy only while CloneGDIRefData() supposes a deep copy is done). Replace the wrong implementations of these functions with assert that will be triggered if they are ever used (which doesn't seem to be the case so far). See #12768.

2010-12-14 19:43 VZ, revision 66372

Don't use implicit wxBitmapRefData copy ctor in wxGTK code. wxBitmapRefData didn't have a proper copy ctor but the code in wxGTK wxBitmap implementation used it nevertheless and then manually patched the newly copied object to avoid double pointer deletion and other unpleasantness. Make the code more obviously correct by not using (nor providing) copy ctor at all. There are no real changes otherwise. See #12768.

2010-12-14 19:43 VZ, revision 66371

Fail instead of crashing in wxGTK wxCursor::CloneGDIRefData(). CloneGDIRefData() used wxCursorRefData copy ctor which wasn't implemented correctly and simply copied its internal m_cursor member without incrementing its reference count which resulted in a crash when it was then dereferenced twice. Unfortunately there doesn't seem to be any simple way to clone GDK cursors but as this should be something only rarely (if ever?) needed, simply don't implement CloneGDIRefData() at all for now and just leave an assert in it if it's ever really called. Also don't define wxCursorRefData copy ctor at all as it can't be done correctly.

2010-12-14 19:43 VZ, revision 66370

Improve wxImage handlers documentation, especially ownership aspect. Correct wxImage::RemoveHandler() documentation which was plain wrong. Also mention that the handler will be deleted by wxImage in AddHandler() documentation. And add an example of using AddHandler() as well as fix the broken text in wxInitAllImageHandlers() description. Closes #12772.

2010-12-13 19:10 VZ, revision 66368

Preserve value when changing range of inverted wxSlider in wxMSW. The logical value of wxSlider was changed when its range was changed in wxMSW if the slider had wxSL_INVERSE style because the logical value was actually computed using the range and the actual physical control value and we forgot to update the latter when changing the range. Do update it now in SetRange() to fix this. Also add unit tests checking for this and, more generally, for other operations with inversed sliders. Closes #12765.

2010-12-13 17:07 JMS, revision 66367

Have wxPropertyGrid::DoubleToString() to also take comma into account as a decimal separator. In addition, the function now returns target wxString (makes writing tests easier).

2010-12-11 12:57 JMS, revision 66363

Added code to remove sign from zero in wxPropertyGrid::DoubleToString(). Fixes #12738.

2010-12-11 12:48 SC, revision 66362

changing compositing mode for Clear, see #12756

2010-12-07 16:46 SC, revision 66360

adding support for layout coordinates via insets from framecoordinates

2010-12-07 16:41 SC, revision 66359

fixing redraw debugging

2010-12-07 14:28 SC, revision 66358

attempt at making the line continuation characters stay correct

2010-12-07 11:11 SC, revision 66357

updating files list for iphone opengl

2010-12-07 10:45 SC, revision 66356

updated comment was not saved in former commit

2010-12-07 10:10 SC, revision 66355

updated comment was not saved in former commit

2010-12-07 09:53 SC, revision 66354

reverting content area calculation for iphone as translucent status bars get ignored otherwise

2010-12-06 19:40 TIK, revision 66344

In some cases menu bar height is reported as 0 when the menu hasn't fully realized yet. Nee to update the height during idle time if it is 0, otherwise no menu is shown.

2010-12-04 14:34 SC, revision 66332

fixing osx iphone build

2010-12-04 14:33 SC, revision 66331

guarding compile

2010-12-04 14:33 SC, revision 66330

adapting inheritance to other osx ports

2010-12-04 14:32 SC, revision 66329

guarding against non-implemented parts

2010-12-03 15:12 VZ, revision 66315

Rename wxGenericDirCtrl::ExpandDir() to PopulateNode(). This function doesn't really expand anything (unlike CollapseDir()) so give it a better name while keeping the old one too for compatibility. See #12735.

2010-12-03 15:00 VZ, revision 66314

Set the window in focus event sent by wxComboCtrl correctly. The window parameter wasn't copied correctly in the forwarded event. Fix this and avoid future problems of the same kind by using the copy ctor for creating the new event and then override the fields that we need to change from the original event instead of recreating the new event from bits and pieces of the original one. Closes #12741.

2010-12-03 13:40 VZ, revision 66313

Update AUI bitmaps when its colours change. Extract the bitmaps initialization in wxAuiDefaultDockArt::InitBitmaps() and call it from SetColour() to ensure that the bitmaps are updated when the colour scheme changes. Closes #12532.

2010-12-03 13:40 VZ, revision 66312

No changes, just clean up duplicate colour functions in wxAUI. Reuse wxcolour::AlphaBlend() and ChangeLightness() methods instead of duplicating them in wxAUI-specific wxAui{Blend,Step}Colour(). See #12532.

2010-12-03 13:40 VZ, revision 66311

Update the directory icon in wxGenericDirCtrl::ExpandDir(). Calling ExpandDir() to notify the control that a new item was added in a previously empty directory didn't work as wxTreeCtrl::SetItemHasChildren() wasn't called. Fix this by moving SetItemHasChildren() to ExpandDir() from OnExpandItem(), it must be always done and not just in response to an interactive action. Closes #12735.

2010-12-03 13:40 VZ, revision 66310

No changes, just clean up duplicate colour functions in wxSearchCtrl. Use wxColor::ChangeLightness() instead of private wxStepColour() that duplicates it. Close #12744.

2010-12-03 13:40 VZ, revision 66309

Optimize pixels rotation in wxImage::Rotate90(). Rotate the image by entire strips instead of doing it pixel by pixel. This seems to result in about 50% performance gain. Closes #12739.

2010-12-03 13:39 VZ, revision 66308

Don't require leading TAB in wxAcceleratorEntry::FromString(). FromString() should parse string returned by ToString() successfully but this wasn't the case because the accelerator parsing functions always insisted on having a TAB in the string. Fix this, document the string format and add a unit test checking for the correct behaviour. Closes #12745.

2010-12-03 13:39 VZ, revision 66307

Don't try to extract accelerators from menu items which don't have any. We don't need to call wxAcceleratorEntry::Create() in wxMenuItem::GetAccel() if the menu item doesn't have any accelerator at all, i.e. if there is no TAB in its label. Calling wxAcceleratorEntry::Create() is useless and won't work correctly any more when Create() is updated to allow passing it strings without TAB in them in the next commit. See #12745.

2010-12-03 13:39 VZ, revision 66306

Fix wxRect::SetRightTop() which set the wrong corner. SetRightTop() erroneously forwarded to SetTopLeft() instead of SetTopRight(). Closes #12746.

2010-12-03 13:39 VZ, revision 66305

Mention in wxHashSet documentation that its contents is not sorted. The documentation gave a wrong impression that this class was a std::set replacement which it isn't. See #12727.

2010-12-01 08:42 SC, revision 66304

fixing missing return value

2010-11-30 19:41 PC, revision 66303

merge libpng 1.4.4 to trunk

2010-11-30 19:01 PC, revision 66302

add src/gtk1/mnemonics.cpp to files.bkl and rebake

2010-11-30 11:19 JJ, revision 66301

Add mnemonics to wxGTK1

2010-11-30 10:59 SC, revision 66300

adding standard menu items for cocoa, adding translation macro to menulabels, fixes #12732

2010-11-30 07:09 PC, revision 66299

tag libpng 1.4.4

2010-11-30 07:07 PC, revision 66298

upgrade to libpng 1.4.4

2010-11-29 21:20 JS, revision 66297

Fix for caret positioning inaccuracy when there are tabs and a non-zero control margin

2010-11-29 09:57 SC, revision 66293

adding defines to support building against 10.4u.SDK

2010-11-28 16:14 VZ, revision 66287

Don't compare invalid iterators in wxCommandProcessor code. Comparing invalid iterators results in an assert failure in STL build. We might also change wxList::compatibility_iterator::operator==() to allow comparing invalid iterators (which should be different from all the other ones but what about comparing two invalid iterators?) but it would probably be better to get rid of all uses of compatibility_iterator in the code instead in the long term. Closes #12730.

2010-11-27 22:57 PMO, revision 66285

Added support for submenus

2010-11-27 21:25 PMO, revision 66284

Added more implementations in wxDisplay

2010-11-27 21:23 PMO, revision 66283

Fixed wrong signature of GetItemText()

2010-11-27 18:30 PMO, revision 66282

Use the generic text entry dialog for now

2010-11-27 18:30 PMO, revision 66281

Skeleton implementation for wxTextCtrl

2010-11-27 16:42 PMO, revision 66280

Skeleton implementation for wxStaticBox. Use wxQtGroupBox for wxStaticBox and wxRadioBox.

2010-11-27 14:35 PMO, revision 66279

Skeleton implementation for wxSpinCtrl/wxSpinCtrlDouble

2010-11-27 12:34 VZ, revision 66278

Verify the return value of wxItemContainer::Insert() in the tests. Check that Insert() returns the index of the last inserted item. Also document this behaviour for mulit-item renames explicitly.

2010-11-27 12:34 VZ, revision 66277

Fix the return value of wxSimpleHtmlListBox::Insert(). The returned index was off by 1. Closes #12717.

2010-11-27 12:34 VZ, revision 66276

Add wx(Simple)HtmlListBox unit test. For now just test the wxItemContainer methods.

2010-11-27 12:34 VZ, revision 66275

Document wxSimpleHtmlListBox inheritance from wxItemContainer. Without wxItemContainer in the docs all the item maintenance methods were absent from wxSimpleHtmlListBox. See #12717.

2010-11-27 09:42 RD, revision 66270

Move the Mac methods from wxAppConsole to wxApp

2010-11-27 09:40 RD, revision 66269

wxDefaultVideoMode is const

2010-11-27 09:38 RD, revision 66268

wxPlatformInfo does not derive from wxObject

2010-11-26 18:39 JMS, revision 66267

Fix 100% CPU usage on wxGTK caused by a recent change in wxPropertyGridEditorEventForwarder::ProcessEvent()

2010-11-26 17:31 JS, revision 66266

Allow bullet style to be switched off via the UI

2010-11-26 14:31 VZ, revision 66265

Update configure helper scripts to latest versions from GNU project. The new version (the one we used was 6 years out of date) notably detects 64 bit MinGW platforms correctly which closes #12356. Also update config.{guess,sub} scripts in 3rd party libraries directories to bring them all in sync with the main one and ensure that MinGW 64 is supported by them too.

2010-11-26 14:31 VZ, revision 66264

Small bug fixes for GetLibraryVersionInfo() changes. Fix the minor version determination for libtiff which was done wrongly by r66259 and provide a properly formatted description for Scintilla version. See #12690.

2010-11-26 14:30 VZ, revision 66263

No real changes, just remove unnecessary const workaround. The comment about "wxString doesn't having enough const members" was totally incomprehensible and clearly wrong. Just remove the hack it was explaining.

2010-11-26 14:30 VZ, revision 66262

Allow wxAutomationObject::GetInstance() create new instance if needed. When getting an instance of an OLE automation object, it is often useful to connect to the existing instance if any or start a new one otherwise. Make GetInstance() behave like this by default while still allowing to use the wxAutomationInstance_UseExistingOnly flag to reestablish the old behaviour. Also improve the error reporting in wxAutomationObject. See #12489.

2010-11-26 14:30 VZ, revision 66261

No real changes, just use ProgID term instead of incorrect CLSID. CLSID was used instead of ProgID in several places in the code and the documentation but they are different things so clear up the confusion. See #12489.

2010-11-25 19:04 SC, revision 66260

led to build issues with xcode and graphics context

2010-11-25 01:53 VZ, revision 66259

Add wxVersionInfo and functions returning it for 3rd party libraries. Add simple wxVersionInfo class holding the version information. Also add GetLibraryVersionInfo() static method to wx{JPEG,PNG,TIFF}Handler, wxStyledTextCtrl and wxXmlDocument classes and wxGetZlibVersionInfo() and wxGetLibraryVersionInfo() global functions using it. Closes #12690.

2010-11-25 01:53 VZ, revision 66258

Document some previously undocumented wxAboutDialogInfo getters. See #12690.

2010-11-25 01:53 VZ, revision 66257

Mention status bar fields limits under pre-XP MSW systems. Mention that before comctl32.dll status bar fields were limited to 127 characters only. See #12709.

2010-11-24 13:43 VZ, revision 66255

Warn that normalizing a valid path may make it invalid sometimes. Mention the special case of a path without file name and with directory that normalizes to empty string. See #10960.

2010-11-24 13:43 VZ, revision 66254

Optimize wxImage::Rotate90() by rotating alpha separately. Bringing the alpha rotation out in a separate loop results in an approximatively 10% performance improvement. Closes #12712.

2010-11-24 01:42 VZ, revision 66253

Add support for negatable command line switches. Add wxCMD_LINE_SWITCH_NEGATABLE which allows to use a dash after a command line switch to inverse its meaning (i.e. use "/X-" form). Also add new wxCmdLineParser::FoundSwitch() allowing to check for whether the switch was specified in normal or negated form. Closes #11643.

2010-11-24 01:42 VZ, revision 66252

Rewind the input stream after failing to load image from it. For seekable streams, don't change the current position when loading image fails. This allows the subsequent image handlers to succeed during image format auto-detection even if a previous, erroneously chosen, handler failed. Closes #12702.

2010-11-24 01:42 VZ, revision 66251

Improve error messages from wxImage::LoadFile(). The error given when loading an image file failed was not very useful because they didn't specify which file exactly we failed to load and also because the numeric handler type which means nothing at all to the end user (and not much to the developer) was used. Use the description of the file format instead and also always give the name of the file that we failed to load. Finally, remove the test for file existence: this is one of many reasons why opening the file could fail and it doesn't make sense to handle it specially, just let the underlying stream generate the appropriate error message in all cases.

2010-11-24 01:42 VZ, revision 66250

Skip mouse events outside of item area in wxDataViewCtrl. Don't consume mouse events outside of the area occupied by the items in the generic implementation of wxDataViewCtrl as this prevented wxEVT_CONTEXT_MENU events from being generated. Closes #12706.

2010-11-23 23:14 RD, revision 66249

Use an enum for the colour/string conversion flags

2010-11-23 23:14 RD, revision 66248

Fixed parameter names. They can't be named "short"

2010-11-23 14:12 VZ, revision 66246

VC6 compilation fix: don't return void values. Fix VC6 compilation broken by r66237: don't return the result from a void function, this compiler doesn't support this C++ feature.

2010-11-23 14:11 VZ, revision 66245

Simplify timezone-related code and fix some minor bugs in it. Try to make the chain of preprocessor checks for different ways of getting time zone from the CRT more clear. Also call _tzset() for all MSVC versions, not just MSVC8+ (closes #12700). We should probably call tzset() for the other compilers too, in fact. And multiply the timezone returned from ftime() by 60 as it's supposed to be in minutes and not seconds as needed.

2010-11-23 14:11 VZ, revision 66244

Center task dialog-based wxProgressDialog on the parent window. wxProgressDialog was created without the parent when using task dialogs so it was centred on screen and not on its parent as usual. Fix this by explicitly positioning it so that it's centered over the parent. Closes #12699.

2010-11-23 14:10 VZ, revision 66243

Deselect all items in wxMSW wxListBox when selection is set to -1. Even though this behaviour is somewhat counterintuitive, the documentation mentions that this is what should happen and wxGTK and wxOSX already behave like this so bring wxMSW in line. wxListBox::DeselectAll() should probably just call SetSelection(wxNOT_FOUND) when the item to leave selected is not specified too now. Closes #12705.

2010-11-22 17:38 SC, revision 66242

fixing 64 bit ranger error

2010-11-22 17:18 VZ, revision 66241

Initialize time zone information before using it in wxGetTimeZone(). We must call _tzset() before calling _get_timezone() as while this is normally done implicitly by the other time functions, it might not have been done yet if create a wxDateTime::TimeZone before calling any of them. Closes #12700.

2010-11-22 15:28 JMS, revision 66240

Have wxPropertyGridEditorEventForwarder::ProcessEvent() return true more often - that is when the event was recognized as being 'handled', and specifically for the case of property editor's button being pressed (fixes #12487).

2010-11-22 13:51 VZ, revision 66239

Fix wxUniv build after deriving wxStatusBar from wxControl. wxUniv build was broken since the base class of wxStatusBar was changed from wxWindow to wxControl in r66226 because it derived twice from wxInputConsumer now. Fix this by simply not inheriting wxStatusBarUniv from wxInputConsumer any more, it already derives from it via wxControl now.

2010-11-22 13:49 VZ, revision 66238

Revert "Always define WXUSINGDLL when compiling Scintilla in shared wx build." Finally it's unnecessary to define WXUSINGDLL when building wxScintilla library as it doesn't use the main DLL, it is simply used as part of it. This reverts r66222 and finally closes #12626.

2010-11-22 13:49 VZ, revision 66237

Don't try to center task dialogs under Windows. This is either unnecessary or doesn't work anyhow (they are always centered on the parent window) and just results in debug error messages. Simply don't do anything in wxMessageDialog::Centre() when using task dialog implementation under MSW. Closes #12699.

2010-11-22 13:48 VZ, revision 66236

Set the width of the last status bar pane correctly in wxMSW. The total width of status bar panes must add up to the size of the status bar as otherwise an extra unwanted border is drawn after the last pane and we did have this border for status bar with a size grip. So while we still use the width without the size grip for calculating the fields widths, pass the width with the size grip to Windows to prevent this from happening. Also, don't pretend that the last field stretches up to the status bar edge when it should end before the size grip and Windows even already helpfully does it for us. Closes #12655.

2010-11-22 13:48 VZ, revision 66235

Add status bar styles mapping to MSW styles broken by recent changes. SBARS_SIZEGRIP and CCS_TOP should be added to the normal style, not the extended one. This restores the behaviour broken by r66227.

2010-11-22 13:48 VZ, revision 66234

Put WINDRES_CPU_DEFINE in RESFLAGS and not RESCOMP in configure. WINDRES_CPU_DEFINE is just another resource compiler flag which should be part of RESFLAGS instead of being added to RESCOMP definition itself. This is not only more logical but also fixes the problem with matching RESCOMP against "windres" or "wrc" in wx-config. See #12356.

2010-11-22 02:23 VZ, revision 66233

Make wxChoicebook background transparent. This fixes the appearance of an empty wxChoicebook used as a child of a wxNotebook under MSW. Closes #12503.

2010-11-22 02:23 VZ, revision 66232

Deprecate not working wxSplitterWindow::SetSashSize(). Setting sash size to non default value didn't work correctly and didn't make much sense anyhow as the sash appearance is platform-dependent and current code for drawing it doesn't work for arbitrary sizes. Simply remove the possibility to set the sash size. Closes #12412.

2010-11-22 02:23 VZ, revision 66231

Don't set explicit background colour for wxStatusBar in wxMSW. Setting the background colour for the status bar explicitly is unnecessary and probably prevents it from rendering correctly with some themes. Simply remove the call to SetBackgroundColour() from wxStatusBar::Create(). We should also define Get[Class]DefaultAttributes() in wxStatusBar in the future.

2010-11-22 02:23 VZ, revision 66230

Don't forbid creating wxSplitterWindow with border style. Any border specified for wxSplitterWindow was explicitly discarded when creating it but there doesn't seem to be any reason to forbid it, the original code probably predated the addition of wxWindow::GetDefaultBorder() which allowed to have different borders by default for different classes. In any case, simply remove this code now to allow creating splitters with borders if so desired. Closes #12413.

2010-11-22 02:22 VZ, revision 66229

Delete pending objects in wxApp::ProcessPendingEvents() and not ProcessIdle(). Move DeletePendingObjects() call from ProcessPendingEvents() to ProcessIdle() to ensure that we delete the objects marked for destruction even if the application is sitting in a tight OnIdle() loop, i.e. if the idle event handler keeps requesting more events. Also make sure that the event loop terminates if its OnExit() was called even if the idle event handler continues to request more events. Closes #12424.

2010-11-22 02:22 VZ, revision 66228

Silently ignore timer events from timers which were just stopped. An assert in wxTimerWndProc() could be provoked by valid user code which simply started and stopped the timers quickly enough because a WM_TIMER could have been already generated just before we stopped the timer. Simply ignore events from unknown timer under assumption that they must come from the recently stopped ones instead of asserting. Ideally we'd somehow distinguish between the situation described above and the really bogus events which could indicate bugs in wx code or a change in behaviour in a future version of Windows but there is no easy way to do it so for now just settle for not asserting in normal case. Closes #10052.

2010-11-22 02:22 VZ, revision 66227

Refactor wxStatusBar creation in wxMSW to do it in standard way. Use wxControl-provided CreateControl() and MSWCreateControl() methods to create the status bar instead of duplicating their code in its Create(). Also translate wx styles to MSW ones in overridden MSWGetStyle() now. In addition to making the code smaller and more clear, this fixes the non-respect of the styles specified at status bar creation (e.g. border), see #12655.

2010-11-22 02:22 VZ, revision 66226

Derive wxStatusBar from wxControl and not wxWindow. wxStatusBar is no less a control than wxToolBar and deriving it from wxControl gives access to convenient native control creation functions under MSW (which will be used by the next commit).

2010-11-22 02:22 VZ, revision 66225

Use status full, not client, size to determine frame client size in wxMSW. We need to account for the full size of status bar, including potential borders, when calculating the client size of the frame containing it. Closes #12697.

2010-11-22 02:22 VZ, revision 66224

Send page changed event after changing the page in wxMSW wxNotebook. Update the currently selected page before generating wxEVT_COMMAND_NOTEBOOK_PAGE_CHANGED event in wxMSW wxNotebook. This is more consistent with other ports and more logical as "-ED" events are supposed to be sent after the action they notify about is completed. And it also allows to set the focus in this event handler whereas any attempts to do it would have been disregarded before as changing the active page resets focus. Notice that this does introduce an incompatibility: calling wxNotebook::GetSelection() from PAGE_CHANGED event handler now returns the new page and not the old one as before. Again, this is more logical and more consistent. Closes #12688.

2010-11-22 02:22 VZ, revision 66223

Use correct wxDEBUG_LEVEL value when building wxscintilla library. wxScintilla code uses wxVector<> which brings in wxDEBUG_LEVEL-dependent code so we must use the wxDEBUG_LEVEL value consistent with the rest of the library when building it. Simply pass wxDEBUG_LEVEL definition on the compiler command line if it's different from the default. Closes #12626.

2010-11-22 02:22 VZ, revision 66222

Always define WXUSINGDLL when compiling Scintilla in shared wx build. We need WXUSINGDLL even in monolithic build because Scintilla references wx debugging functions (wxOnAssert(), wxTheAssertHandler &c) which still must be seen as being exported from the (monolithic) DLL in this case. See #12626.

2010-11-21 14:00 VZ, revision 66221

Correct wxFont::GetFamily() unit test to test for wxFONTFAMILY_DEFAULT. GetFamily() returns wxFONTFAMILY_DEFAULT and not wxFONTFAMILY_UNKNOWN since r65670. Correct the test to handle wxFONTFAMILY_DEFAULT as allowed value.

2010-11-21 14:00 VZ, revision 66220

Revert r66070: "Unload bogus XRC resources in "garbage" unit test." This change is not needed any longer after r66219 which fixed the real underlying problem, i.e. that attempting to load an invalid XRC file resulted in failures when loading all subsequent XRC files.

2010-11-21 00:53 VZ, revision 66219

Don't keep entries for XRC resources that failed to load in wxXmlResource. Attempting to load a resource that couldn't be loaded resulted in wxXmlResource::Load() returning false for this and _all_the_subsequent_ calls to it because each call to Load() reattempted to reload all resources, including the one(s) that failed to load initially. Instead, try to load just the resource(s) that we should load right now and ignore all the other ones. Also, don't add entries for the one(s) that we fail to load. This fixes the unit test failures in the XRC test case which was affected by the test checking that XRC couldn't be loaded from garbage that ran before it. It also makes the code simpler by ensuring that wxXmlResourceDataRecords elements always have a valid wxXmlDocument associated with them. Also clean up the code: use wxScopedPtr instead of manually deleting pointers and reorganize #if checks to be easier to follow.

2010-11-21 00:53 VZ, revision 66218

Don't consider extra ".." an error in wxFileName::Normalize(). The path being normalized could have come from user and there doesn't seem to be any point in complaining about too many ".."s in it when we can handle them correctly instead. So simply ignore the extra ".."s for the absolute paths and keep them unchanged for the relative ones instead of returning an error. See #10960.

2010-11-20 12:58 JMS, revision 66217

Reworked wxSystemColourProperty::StringToValue() to use wxColour::Set() instead of doing string-to-colour conversion by itself. This adds support for HTML-colours, among other things (closes #12696).

2010-11-19 08:57 RD, revision 66210

Fix some bad parameter names, add missing methods, add missing classes, etc.

2010-11-19 08:51 RD, revision 66209

Add a SetSize to wxSizeEvent

2010-11-18 15:10 VZ, revision 66205

Improve documentation about handling C++ exceptions in wx programs. Try to explain the different exception handling strategies more clearly in the overview and also update OnUnhandledException() documentation.

2010-11-18 13:41 VZ, revision 66203

Check wxDateTime components validity more rigorously. Check that the provided day is strictly positive and also that the month is in valid range: while it should always be, considering that it's an enum element, in practice people often cast ints to wxDateTime::Month with potentially fatal results. Catch this with an assert in wxDateTime::Tm::IsValid().

2010-11-18 13:41 VZ, revision 66202

Explicitly include "wx/dynlib.h" from src/msw/combobox.cpp. This header was only included implicitly via wx/msw/uxtheme.h and thus the code failed to compile with wxUSE_UXTHEME==0 but wxUSE_DYNLIB_CLASS==1. See #12664.

2010-11-17 06:57 PC, revision 66180

remove const from by-value return type, it's useless

2010-11-17 02:22 VZ, revision 66179

Remove obsolete warning from wxMenuBar::GetTitle() documentation. This method can be used for menu bar entries also since the previous commit. Do mention that SetTitle() can't be used to change a menu bar menu title however.

2010-11-17 02:20 VZ, revision 66178

Simplify wxMSW wxMenuBar title management. Store the titles of the menu bar menus in the menu objects themselves. This makes wxMenu::GetTitle() return the expected result for them (which also fixes the current unit test failures for wxMSW) and makes wxMenuBar code simpler. This removes the wxMenuInfo class which existed for XTI purposes only but as it was apparently unfinished and MSW-specific it shouldn't be a big loss.

2010-11-17 02:20 VZ, revision 66177

No real changes, just minor cleanup of wxImage code. Make more local variables const. Use consistent spacing. Don't use needless comparison with NULL. Don't avoid not using double negation. See #12682.

2010-11-17 02:20 VZ, revision 66176

Don't pass a bool to wxImage::MakeEmptyClone() which takes an enum. Correct the changes of r66167 which accidentally left a call to MakeEmptyClone() using its previous signature. See #12682.

2010-11-16 23:38 VZ, revision 66175

Correct form of mnemonics returned by wxGTK wxMenu::GetTitle(). wxMenu::GetTitle() returned a string in GTK+ format (i.e. using underscores instead of ampersands) instead of the expected wx one. This is, of course, the right thing to do and it also fixes wxMenuBar::FindMenuItem() as a side effect. Closes #12672.

2010-11-16 23:38 VZ, revision 66174

Emphasize that wxUSE_DYNLIB_CLASS shouldn't be disabled in wxMSW. Mention in the setup.h comment that wxDynamicLibrary is used in a lot of places internally and disabling it can result in a loss of a lot of important functionality. See #12664.

2010-11-16 23:38 VZ, revision 66173

Add more checks for wxUSE_DYNLIB_CLASS to wxMSW. Compilation fixes for wxApp and wxComboBox for wxUSE_DYNLIB_CLASS==0. See #12664.

2010-11-16 23:38 VZ, revision 66172

Correct checks for wxUSE_PRINTING_ARCHITECTURE and wxUSE_ENH_METAFILE. Compilation fixes for building without one or both of these symbols. See #12664.

2010-11-16 23:38 VZ, revision 66171

Avoid asserts due to not overriding OnGetItemText() in VirtListCtrlTestCase. A virtual list control must override wxListCtrl::OnGetItemText() method and wxMSW native implementation asserts if this is not the case (the generic one should arguably do it as well). Avoid the asserts by providing a dummy implementation of OnGetItemText() in the unit test.

2010-11-16 23:38 VZ, revision 66170

Add an explicit SetFocus() call to fix wxTreeCtrl unit test. Fixing the implicit focus grabbing by wxTreeCtrl::SelectItem() in r65905 broke its unit test case as the simulated key event was not delivered to wxTreeCtrl itself any more. Fix this by simply setting the focus to the tree explicitly before sending it any key strokes.

2010-11-16 23:38 VZ, revision 66169

Correct wxMSW wxToolTip behaviour for wxRadioBox items tooltips. The assert added in r66053 checking that we couldn't have tooltips for child windows if we didn't have the tooltip for the main one turned out to be wrong, at least in wxRadioBox case it's perfectly possible to have the tooltips for the individual radio buttons without having one for the box itself. Replace the assert with a simple if check. This fixes a unit test failure in RadioBoxTestCase.

2010-11-16 23:38 VZ, revision 66168

Don't use some "recent" C++98 features not supported by VC6. Don't return void values nor redeclare the same variable in for loops to fix VC6 compilation.

2010-11-16 23:37 VZ, revision 66167

No changes, just refactor common code in wxImage cloning functions. Extract code common to several wxImage methods creating new images based on an existing one in a new MakeEmptyClone() method. Closes #12682.

2010-11-16 23:37 VZ, revision 66166

Fix crashes in wxDateTime::ParseDate() for some invalid dates. Parsing an incomplete date with nothing but whitespace and/or date delimiter characters at the end crashed as we happily went beyond the end of string. Fix this by not using a loop which didn't check for the iterator validity. Closes #12685.

2010-11-15 09:52 JJ, revision 66161

Update OpenVMS makefile

2010-11-15 01:22 VZ, revision 66157

VC6 compilation fix in wxDIB::Create(). Deal with the lack of scope around variables declared inside the for loop in this compiler, previously it gave "error C2360: initialization of 'x' is skipped by 'case' label" message and also complained about redefinition of 'x'.

2010-11-15 01:11 VZ, revision 66156

Fix incorrect use of word "alternative" in the documentation. There can't be only one alternative. Closes #12681.

2010-11-14 15:04 VZ, revision 66153

Restore code for closing inherited file descriptors in the child. The code closing all file descriptors inherited from the parent in the child process created by wxExecute() was removed in r57324 by mistake (probably due the fact that its meaning was poorly explained) but we still do need to do this, of course, to avoid descriptor "leaks" (e.g. the parent couldn't really close any of them). Restore the code for closing all unneeded file descriptors in the child in slightly modified form and add a comment pointing to an URL explaining how to do it better in the future. Closes #12636.

2010-11-14 15:04 VZ, revision 66152

Fix spurious errors when writing to the child process stdin under Unix. Since the child pipe was made non-blocking in r65993, it became possible to write to child process without deadlocking when the pipe became full. However this still resulted in an error from wxFileOutputStream as it didn't handle EAGAIN returned from write() any differently than any other error, even though it is an expected situation in this particular case. Change Unix wxExecute() to use wxPipeOutputStream which ignores EAGAIN unlike wxFileOutputStream to fix this. See #12636.

2010-11-14 15:04 VZ, revision 66151

No real changes, just reamed HAS_PIPE_INPUT_STREAM. Renamed the symbol indicating whether pipe-based streams are available from HAS_PIPE_INPUT_STREAM to HAS_PIPE_STREAMS as it's not really input-specific. See #12636.

2010-11-14 13:09 VZ, revision 66150

Add wxFile::{Get,Clear}LastError() functions. Remember the errno of the last file operation instead of just remembering whether there was an error or not. See #12636.

2010-11-14 13:09 VZ, revision 66149

Handle image hot spot in wxImage::Rotate180(). Set the hot spot coordinates correctly for the image returned from Rotate180(), just as it's already done by Rotate90(). Closes #12680.

2010-11-14 02:02 VZ, revision 66146

Add wxImage::Rotate180() function. Closes #12679.

2010-11-14 02:02 VZ, revision 66145

Handle hot spots in wxImage::Rotate90(). Set hot spot coordinates for the rotated image if the original one had them. Also handle the case when the source image has both alpha and mask correctly. Closes #3680.

2010-11-13 18:13 VZ, revision 66144

Don't use standard menu ids in the unit test to avoid Mac problems. wxOSX rearranges the standard menu items such as wxID_EXIT and wxID_ABOUT and, for the former, changes its text to "Quit", so don't use them in the menu unit test which expects to find the items in the menus to which they were added and exactly with the labels used when adding them.

2010-11-13 16:03 VZ, revision 66143

Don't put cursor at the end of wxGridCellEnumEditor control. Putting the cursor to the end of the control when the editing starts doesn't make much sense as this should be the default behaviour anyhow and, worse, this results in an assert under wxMSW where a read-only wxComboBox doesn't have any cursor to move. Closes #12446.

2010-11-13 16:03 VZ, revision 66142

Initialize scrollbar positions in wxGTK correctly. The scrollbar positions stored in wxWindow::m_scrollPos were not initially correct in wxGTK because wxScrollHelper::SetScrollbars() didn't update them and only set the values of the underlying GtkAdjustments themselves. This resulted in filtering out of the first scroll event as the code (wrongly) believed that the scrollbar position hadn't changed. Fix this by setting m_scrollPos to the real scrollbar positions. Closes #12468.

2010-11-13 16:03 VZ, revision 66141

Add a unit test checking selection updating in virtual wxListCtrl. Verify that the selection is updated correctly after the number of items in the control is decreased. See #12378.

2010-11-13 16:03 VZ, revision 66140

Don't assert if config file contains an invalid boolean value. Asserts should be only triggered by programming errors, not by user actions, and the assert checking that the value is either 0 or 1 in wxConfigBase::DoReadBool() could happen if the user edited the file and put a wrong value into it. Replace the assert with a warning message. See #11437.

2010-11-13 16:03 VZ, revision 66139

Add a beginning of wxMenu unit test. Test wxMenu and wxMenuBar item search and counting functions. See #12672.

2010-11-13 16:02 VZ, revision 66138

Make menu operations always work with "Test" menu in the sample. Some tests in the "Menu" menu of the menu sample worked with the "Test" menu while others used the last one ("Help" initially but possibly something else if the test commands from "Menubar" menu were used). Harmonize all menu commands to use the "Test" menu now. See #12668.

2010-11-13 16:02 VZ, revision 66137

Fix resizing of wxGrid columns when they were reordered. The column resizing code in wxGrid didn't take account of the fact that the column positions and indices could be different. Correct it by inserting calls to wxGrid::GetColAt() and GetColPos() in a new wxGridOperations::GetLineBefore() method. Closes #11984.

2010-11-12 08:15 JJ, revision 66124

Update SETUP for OpenVMS

2010-11-11 16:51 MW, revision 66121

Use wxFS_SEEKABLE flag loading images.

2010-11-11 13:09 VZ, revision 66120

Improve check for ASCII locale in wxGTK initialization code. Use wxFontMapper::GetEncodingFromName() to check if the current locale encoding is ASCII instead of just comparing the name with "US-ASCII" which is not the name used by most platforms (e.g. current Linux systems call this encoding "ANSI_X3.4-1968"). This avoid creating a wxCSConv object for ASCII encoding unnecessarily on startup.

2010-11-11 13:09 VZ, revision 66119

Initialize wxCSConv immediately instead of deferring it. Deferred initialization code was not MT-safe and just wasn't that useful anyhow because it is rare to create a wxCSConv object and not use it afterwards. Remove the deferred initialization logic and create the real conversion used by wxCSConv immediately in its ctor. Also improve the comments by clearly explaining the possible values of wxCSConv::m_name and m_encoding. Closes #12630.

2010-11-11 13:09 VZ, revision 66118

Fix typo in error message given if wxUSE_CAIRO is undefined. Replaced the wrongly copy-and-pasted wxUSE_BUTTON with wxUSE_CAIRO.

2010-11-11 05:09 RD, revision 66117

No docs yet, just the bare interace so we can get XML for Phoenix.

2010-11-11 02:29 RD, revision 66116

Fix a parameter type and add some missing const keywords

2010-11-10 14:53 VZ, revision 66103

Disable unit tests which can't work in ANSI build. Disable unit tests involving operations (such as conversions between UTF and anything but plain ASCII) not available in ANSI build. This fixes the test suite for non-Unicode build under Unix.

2010-11-10 14:53 VZ, revision 66102

Use wxString::To8BitData() instead of mb_str() to handle NULs correctly. In ANSI build wxString::mb_str() returns a pointer to the internal wxString data directly instead of a buffer with a proper length, so it provides access to the part of the string before the first embedded NUL only. Use To8BitData() which always returns the buffer of the correct size in all builds. The open question remains whether mb_str() should be changed to return a (non owned) buffer and not just a pointer in ANSI build. This would make manipulating strings with embedded NULs safer but mb_str() would be less efficient and less compatible.

2010-11-10 14:53 VZ, revision 66101

Fix wxString::{Before,After}{First,Last} unit test for ANSI build. The test used a wide character constant and so didn't work in ANSI build. Use an ASCII string there now while still keeping the original version in Unicode build.

2010-11-10 14:53 VZ, revision 66100

Don't check for wxDF_UNICODETEXT support in ANSI builds. wxDF_UNICODETEXT clipboard format can't be even constructed without provoking an assert in ANSI build of wxGTK, so avoid using it, we don't support it anyhow.

2010-11-10 14:53 VZ, revision 66099

Initialize paragraph descent in wxRichTextParagraph::Layout(). This variable was used as the initial value for the descent but was never initialized, so the descent computation could be completely wrong.

2010-11-10 14:53 VZ, revision 66098

Don't crash in wxGUIEventLoop::Exit() if not running in wxX11. The implementation of wxEventLoop::IsRunning() has changed since this code was written and it doesn't check for m_impl != NULL any more. Because of this, calling Exit() for an active but not running event loop resulted in a crash in wxX11. Fix this by doing nothing in this case. This seems better than asserting as the event handling code exits the loop if an event handler throws an exception and the loop might not be running in this case yet (events could be processed because of a wxYield() call).

2010-11-10 14:53 VZ, revision 66097

Implement bitmap mask copying in wxX11. Copy the mask pixmap properly in wxX11, otherwise copying masks resulted in freeing the same pixmap twice and an X error. This fixes the bitmap unit test for wxX11.

2010-11-10 14:52 VZ, revision 66096

Don't test for DC validity in wxX11 wxDC text extent functions. The code in GetTextExtent() and GetChar{Width,Height}() works fine even for non-initialized wxMemoryDC and the ellipsization unit test relies on this working so simply remove the asserts which resulted in the test failures.

2010-11-10 14:52 VZ, revision 66095

Disable measuring context unit test for wxX11. wxCairoRenderer::CreateMeasuringContext() is only implemented for wxGTK so the test fails under other ports when using Cairo. Disable it for wxX11 for now.

2010-11-10 14:52 VZ, revision 66094

Use Cairo for wxGraphicsContext in wxX11. Check for Cairo in configure for wxX11 too. Fix compilation of wxCairoContext for non-{GTK,MSW} platforms. Also make wxUSE_CAIRO a "normal" option, i.e. add it to all wx/setup.h files instead of defining it as 1 unconditionally for wxGTK and 0 for everything else.

2010-11-10 14:52 VZ, revision 66093

Disable unit test for wxColour alpha under wxX11. wxX11 doesn't support alpha component of wxColour currently.

2010-11-10 14:52 VZ, revision 66092

Fix signed/unsigned comparison warnings in wxUniv wxNotebook. Recent replacement of size_t wxNotebook::m_selection with int wxBookCtrlBase::m_selection resulted in appearance of many warnings in wxUniv wxNotebook. Fix them by removing some now unnecessary casts between int and size_t and adjusting the remaining ones.

2010-11-10 14:52 VZ, revision 66091

Add #if checks fixing minimal wxGTK build. Check for functions availability before using them. This fixes compilation of wxGTK with all features disabled.

2010-11-10 14:52 VZ, revision 66090

Fix harmless unused parameter warnings in minimal build. No real changes, just add some wxUnusedVar() to avoid warnings about parameters unused in some non-default build configurations.

2010-11-10 14:52 VZ, revision 66089

Don't exclude a bunch of wxDir methods when wxUSE_LONGLONG==0. The #endif part of a #if wxUSE_LONGLONG check was incorrectly positioned and excluded the definition of several wxDir methods not related to wxLongLong when wxUSE_LONGLONG was 0.

2010-11-10 14:52 VZ, revision 66088

Fix wxGLCanvas compilation with wxUSE_PALETTE==0. This fixes compilation problems with the minimal build of wxGTK and will make removing palette support in the future simpler.

2010-11-10 14:51 VZ, revision 66087

Fix wxStandardDialogLayoutAdapter compilation with wxUSE_BUTTON==0. This class probably should not be compiled in at all in the minimal build but in the meanwhile just add #if checks around its button-related parts.

2010-11-10 14:51 VZ, revision 66086

Make wxBitmap::ConvertToDisabled() available in all ports. This method was defined in wxBitmapBase which is not used by wxMSW (and wxOS2) so it wasn't available there. Move the definition of the method inline and reuse it for all ports, making it part of either wxBitmapBase or wxBitmap as appropriate. This is clearly ugly but we still have no good solution for deriving wxBitmap from wxBitmapBase in wxMSW as it already inherits from MSW-specific wxGDIImage there. Also document that ConvertToDisabled() is only available when wxUSE_IMAGE==1.

2010-11-10 01:36 VZ, revision 66082

Disconnect "hide" menu signal to fix menu destruction in wxGTK. The "hide" signal handler was triggered when destroying a sub-menu (even if it was not shown at this time). Disconnect it to avoid asserts due to attempts to generate an event for an already detached menu and to avoid the (bogus) wxEVT_MENU_CLOSE event as well. Closes #12668.

2010-11-10 01:36 VZ, revision 66081

Add a test for deleting a sub-menu to the menu sample. Also fix some typos in the help message. See #12668.

2010-11-10 01:36 VZ, revision 66080

Fix wxUSE_DC_CACHEING spelling in the documentation. It was consistently misspelt as wxUSE_DC_CACHE. Closes #12377.

2010-11-10 01:36 VZ, revision 66079

No changes, just simplify docview sample a bit. Remove some unnecessary function arguments and m_frame member variable. Closes #12374.

2010-11-10 01:36 VZ, revision 66078

Correct wxID_SEPARATOR description in menu documentation. Also correct a typo in Delete() function links. Closes #12666.

2010-11-10 00:53 VZ, revision 66077

Fix preprocessor definitions for wxBase build under OS X. Define __WXOSX__ for non-GUI build under Darwin. Ensure that the rest of the code compiles correctly when just __WXOSX__ is defined but neither of __WXOSX_{CARBON,COCOA,IPHONE}__ is. This ensures that wxBase can actually be built under Mac. Move OS X symbols definitions in wx/platform.h after wx/setup.h inclusion as they rely on __DARWIN__ and wxUSE_GUI values which are both define in that file now. Still keep them before wx/chkconf.h inclusion which relies on __WXOSX_XXX__ being defined. Yes, it's a mess and should be cleaned up more permanently some day. Also remove some redundancy from wx/osx/{carbon,cocoa}/private.h by factoring out common parts into wx/osx/core/private.h. Also include this header itself from wx/osx/private.h directly instead of including it thrice from different sub-ports headers. Closes #12660.

2010-11-10 00:53 VZ, revision 66076

Fix timeval struct initialization in wxSelectDispatcher. The tv_usec field could overflow its maximal value while tv_sec was always left 0. It would be even better to reuse SetTimeValFromMS() from socket.cpp here in the future. See #11542.

2010-11-10 00:53 VZ, revision 66075

Fix crash in wxCFEventLoop::AddSourceForFD(). Don't reset CFFileDescriptorRef before passing it to CFFileDescriptorCreateRunLoopSource(), this resulted in a crash inside this function. Closes #11542.

2010-11-10 00:53 VZ, revision 66074

Remove non-existent functions declarations from wxOSX/Carbon. wxMacSetupConverters() and wxMacCleanupConverters() don't seem to exist any more so don't declare them.

2010-11-08 17:28 VZ, revision 66071

Document wxRenameFile() behaviour when destination is a directory. Document that the source file is moved to the destination if it's a directory, apparently this is not obvious.

2010-11-08 17:28 VZ, revision 66070

Unload bogus XRC resources in "garbage" unit test. Leaving invalid XRC entries in wxXmlResource internal list of loaded resources resulted in failures in the XRC unit test which executed after this one. It seems that loading an invalid resource shouldn't prevent the other ones from loading correctly later and this probably should be corrected at wxXmlResource level but for now work around this problem in the test itself.

2010-11-08 14:50 VZ, revision 66069

Fix crash in XRC ID range support code. Really fix removing the record from the linked list. This code was modified by r66064 but was still wrong because the wrong pointer was updated.

2010-11-07 23:13 VZ, revision 66066

Compilation fix for STL build after ID range changes in XRC. Fix compilation of the new code which relied on implicit conversion of wxString to "const char *" which is unavailable when wxUSE_STL==1.

2010-11-07 20:34 VZ, revision 66065

Factor our hash function used for XRC ids hash map. Define the hash function in a separate function instead of duplicating it in XRCID_Lookup() and RemoveXRCIDEntry(). The hash function is extremely simplistic and inefficient right now, it should be replaced with wxStringHash::stringHash().

2010-11-07 20:33 VZ, revision 66064

Fix memory leak of XRC ids introduced by the ID range support patch. Fix bug in linked list processing in RemoveXRCIDEntry() added in r66059: it incorrectly overwrote the XRC id table entry with the next element in the list instead of just updating the pointer used during iteration.

2010-11-07 20:33 VZ, revision 66063

Reformat long lines in the new part of the xrc sample. No changes, just break the too long lines.

2010-11-07 20:33 VZ, revision 66062

Use Connect() of Bind() in the new part of xrc sample. Use Connect() for compatibility (notably with VC6 which doesn't support Bind()). Also connect the event handlers on loading the dialog instead of waiting until the relevant page is selected, this makes the code slightly simpler as we don't need to remember whether we connected them or not any longer.

2010-11-07 20:33 VZ, revision 66061

Test both ChangeSelection() and SetSelection() in notebook sample. Test wxBookCtrl::SetSelection() too to be able to check that it does generate events as expected.

2010-11-07 20:33 VZ, revision 66060

Don't require skipping "page changed" event in wxMSW wxNotebook. wxMSW wxNotebook implementation used to handle EVT_NOTEBOOK_PAGE_CHANGED event to update the currently shown page which meant that page changing was broken if the user code handled and didn't skip this event. As the other ports don't require the user code to skip this event, don't do this in wxMSW neither and always update the selected page unconditionally.

2010-11-07 15:00 VZ, revision 66059

Add support for id ranges to XRC. Allow to declare ranges of consecutive IDs in XRC by using the "id[n]" syntax. Show this functionality in the xrc sample and test it in the new unit test. Also show and test the "object reference" XRC functionality. Closes #11431.

2010-11-07 15:00 VZ, revision 66058

Make wxXmlResource::ReportError() wxXmlNode parameter const. This function (and the related DoReportError()) doesn't need to modify its "context" argument so take a const-pointer in it. See #11431.

2010-11-07 15:00 VZ, revision 66057

Mention the GUI test in the unit test tech note. Update the tech note to mention the (relatively) new GUI test program too. See #11431.

2010-11-07 15:00 VZ, revision 66056

Update and reorganize XRC overview to make it more useful. Emphasize the parts most useful for the new users instead of more advanced concepts and generally make the text more readable. Closes #12661.

2010-11-07 14:44 PJC, revision 66055

Add support for toggle buttons to wxRibbonButtonBar.

2010-11-07 14:16 VZ, revision 66054

Fix build with Borland C++ compiler. Disable some parts of the code that this compiler had problems with. Add parentheses to work around its bugs elsewhere. Closes #12558.

2010-11-07 14:12 VZ, revision 66053

Update all windows associated with the tooltip when it changes in wxMSW. Although the tooltip was initially correctly set for all windows associated with it, it was only updated for the main one if its text changed later. This resulted in leaving the old tooltip for the composite controls such as wxComboBox or controls with sub-windows such as wxRadioBox. Fix this by storing all windows associated with the tooltip (for space efficiency, only allocate the array if necessary however as it will be empty in the majority of cases) and apply SetTip() to all of them, not just the main one. Closes #12659.

2010-11-07 12:54 SC, revision 66052

disable code because of OS bug, fixes #12478, fixes #12554

2010-11-07 00:46 PJC, revision 66051

Improve behaviour of scrolling through a ribbon gallery.

2010-11-06 16:48 SC, revision 66048

routing the tab, return events for single line fields back to standard wx handler (doesn't work for secure fields unfortunately), fixes #12386 and partly #12392

2010-11-06 16:37 SC, revision 66047

implementing turning off of default button as well

2010-11-05 22:43 VZ, revision 66043

Minor cosmetic fix to generic check tools appearance in wxOSX. Use rounded rectangle to indicate the selected tool instead of a plain one. Closes #12409.

2010-11-05 22:43 VZ, revision 66042

Fix check toolbar items behaviour in non-native toolbars in wxOSX. Update the button state when the tool is toggled. Also use NSToggleButton for this tool and not NSOnOffButton as the latter doesn't use the alternative (toggled) image. Closes #12408.

2010-11-05 22:43 VZ, revision 66041

Avoid using wx GDI classes from non-main thread in wxOSX/Cocoa. OS X uses a background thread for pulsing the default button and we intercept the draw requests from it. As our drawing code is not MT-safe, executing it from the non-main thread can result in crashes. Avoid this by simply not doing anything fancy when called from a background thread and simply deferring to the superclass instead. Closes #12407.

2010-11-05 22:43 VZ, revision 66040

Really update tooltip when wxToolBar::SetShortHelp() is called. Changing a toolbar tool tooltip didn't work in wxOSX/Cocoa because the new value was never propagated to the native control. See #12362.

2010-11-05 22:43 VZ, revision 66039

Remove trailing comma from an enum. Comma after last enum element is not allowed in C++98 and some compilers will warn about it. Closes #12591.

2010-11-05 22:42 VZ, revision 66038

Show the first, not the last, inserted item in wxListBox in wxOSX. The listbox showed its last, not first, item after creation in wxOSX which was inconsistent with the other ports and generally inconvenient. Fix this by ensuring that the first item being inserted is shown, and not the last one as was (implicitly) the case before. A better fix would be to avoid scrolling entirely but I don't know how to do this with NSClipView. Closes #12365.

2010-11-05 22:42 VZ, revision 66037

Use CGFloat instead of float for mouse wheel event parameters. This fixes mouse wheel handling in 64 bits where CGFloat has size different from float. Closes #12168.

2010-11-05 22:41 VZ, revision 66036

Fix showing the frames full screen under OS X. Don't leave space for the title bar when showing the frame full screen. Closes #11701.

2010-11-05 22:40 VZ, revision 66034

Improve default position for new TLWs in wxOSX. Put the new windows in the upper left corner of the screen but not at (0, 0) as before, this was rather inconvenient and too different from the normal application behaviour under OS X. Closes #11926.

2010-11-05 22:40 VZ, revision 66033

Ensure that strings returned by wxMBConv_cf are in NFC form. Normalize all Unicode strings used internally even though the Darwin kernel gives them to us in decomposed (NFD) form. Closes #11730.

2010-11-05 22:39 VZ, revision 66032

Remove duplicate wxEVT_COMMAND_TEXT_ENTER generation from wxOSX/Cocoa. The code in -[wxNSTextField control:textView:doCommandBySelector:] generated a second copy of this event as it was also generated from wxNSTextFieldControl::controlAction() for single line text controls. Closes #11691.

2010-11-05 22:39 VZ, revision 66031

Don't update scrollbars when the window is being destroyed in wxOSX. Updating scrollbars for a window that is being destroyed anyhow is useless and resulted in crashes in the htlbox sample because it used client-to-screen coordinates conversion which asserted because the TLW was invalid any more and this unexpected assert during window destruction led to a crash. Simply don't do it at all to avoid the problem. Closes #11776.

2010-11-05 22:39 VZ, revision 66030

Fix crash in wxColour ctor from NSColor in wxOSX/Cocoa. wxColour ctor from NSColor added by Kevin Ollivier in r62525 never worked as it passed NULL pointer to NSColor:getComponents and so always crashed. This resulted in a crash in the rich text editor of the text sample, for example. Fix this by passing a valid array containing colour components instead.

2010-11-05 22:38 VZ, revision 66029

Remove unnecessary wxOSX_USE_COCOA guards in Cocoa-only file. The #if wxOSX_USE_COCOA seems unnecessary in a file that is used in wxOSX/Cocoa only so simply remove it.

2010-11-05 22:38 VZ, revision 66028

Assume sizeof(wchar_t) is always 4 under OS X. wchar_t used to be 2 bytes in Mach-O builds but they're not supported any longer so remove the code checking for sizeof(wchar_t) and just assume it's always 4. Closes #10442.

2010-11-05 22:37 VZ, revision 66027

Add another test for the insertion point position after SetValue(). Verify that setting the value of a previously not empty control resets the insertion point to its beginning. See #10051.

2010-11-05 22:37 VZ, revision 66026

Disable keyboard unit test with wxUIActionSimulator under OS X. The test doesn't work because the test window never get any events. This might be a bug in the test or in wxUIActionSimulator itself but for now I just have no idea about how to fix it, so disable the test to let the rest of the test suite run.

2010-11-05 17:05 CE, revision 66022

add execmon to CE exclude (no console)

2010-11-05 16:45 CE, revision 66021

missing namespace

2010-11-05 16:24 CE, revision 66019

missing namespace

2010-11-05 13:53 VZ, revision 66018

Remove test code accidentally committed as part of r66015. Don't call wxMenuItem::Set{Background,Text}Colour() in the menu sample, this was for testing only.

2010-11-05 07:55 JJ, revision 66017

Update OpenVMS makefiles

2010-11-04 17:13 VZ, revision 66016

Correct a trivial typo in wxLog documentation. Just remove an extra word.

2010-11-04 11:57 VZ, revision 66015

Use explicit menu item background if it's given under MSW. An explicit item background colour specified in user code should override the default theme background. Closes #12652.

2010-11-04 11:57 VZ, revision 66014

No changes, just use RAII-based classes in MSW owner drawn menu code. Add helper HDC{TextCol,BgCol,BgMode}Changer classes which ensure that the corresponding HDC attribute is reset on scope exit instead of manually calling the corresponding MSW functions to set and reset it.

2010-11-04 11:49 VZ, revision 66013

Pas long to _get_timezone() even for VC8. Apparently the MSDN documentation for VC8 is wrong and _get_timezone() function expects a long and not int when using it (as is already the case with VC9 and VC10). Closes #12653.

2010-11-04 08:38 JJ, revision 66012

Updating makefiles for OpenVMS

2010-11-04 00:48 VZ, revision 66009

Remove unused mouse event handler from dataview sample. The mouse event handler for the frame was never executed because the frame is entirely covered by other windows in this sample. Not sure what was meant here but this handler is useless so just remove it.

2010-11-04 00:48 VZ, revision 66008

Remove unnecessary tests for m_log from dataview sample. The sample contained a lot of unnecessary checks for m_log, remove them to make the code shorter and simpler to understand.

2010-11-03 17:36 VZ, revision 66007

Add wxAuiPaneInfo::IsDockable(). This function checks if the pane can be docked at any side. It is useful in its own right but most importantly is needed to fix compilation broken in r66005 which used it before it was added. See #12648.

2010-11-03 17:29 VZ, revision 66006

Set column field of wxDVC ITEM_{ACTIVATED,CONTEXT_MENU} events. Add missing calls to wxDataViewEvent::SetColumn() and SetDataViewColumn(). In the future it would be nice to refactor the code to have a common event object initialization function that would make it impossible to forget to do this. Closes #12649.

2010-11-03 17:29 VZ, revision 66005

Don't dock undockable panes in wxAuiManager::LoadPerspective(). All panes were docked when loading a perspective, including those that were created to be non-dockable. Don't dock the latter ones now. Closes #12648.

2010-11-03 17:29 VZ, revision 66004

Optimize wxDataViewMainWindow::FindNode() in generic wxDataViewCtrl. Avoid unnecessary heap allocations and extra indirections and just use the items pointers directly. Also avoid copying the (potentially huge) nodes arrays. Closes #12647.

2010-11-03 17:29 VZ, revision 66003

Don't copy potentially big arrays in generic wxDataViewCtrl. Use reference to hold the array of nodes instead of copying it. (Really) closes #12587.

2010-11-03 17:29 VZ, revision 66002

Handle wxLOCALE_DECIMAL_POINT in wxLOCALE_CAT_MONEY correctly in wxMSW. Use LOCALE_SMONDECIMALSEP and not LOCALE_SDECIMAL when querying for the decimal separator in money category, it can be different from the usual numeric one.

2010-11-03 17:29 VZ, revision 66001

Support wxLOCALE_THOUSANDS_SEP in wxMSW wxLocale::GetInfo(). Simply use ::GetLocaleInfo(LOCALE_STHOUSAND) for it. Closes #12643.

2010-11-03 15:44 JJ, revision 66000

replace m_nSelection by m_selection

2010-11-03 09:54 JJ, revision 65999

Update OpenVMS compile support

2010-11-02 23:55 VS, revision 65997

Fix compilation error in wxImplicitConversionType<> in gcc strict mode.

2010-11-02 12:57 VZ, revision 65994

Use _get_timezone() function instead of _timezone with MSVC8+. While some (but not all) versions of VC8 CRT still define _timezone variable, it is deprecated and shouldn't be used and referencing it can result in linking problems if it pulls in static CRT. Just use _get_timezone() function instead for the VC versions that support it (as was already done in r54417 for VC8 in 2.8 branch). Closes #4691.

2010-11-02 12:57 VZ, revision 65993

Make write end of the child process pipe non-blocking under Unix. We need to make at least one end of the pipe used to communicate with wxExecute() child process non-blocking to avoid deadlocks, so unblock the write end of the pipe. It seems to be unnecessary to unblock the reading ends of std{out,err} pipes as we can already check for the presence of input there. This is also consistent with wxMSW behaviour. Closes #12636.

2010-11-02 12:57 VZ, revision 65992

Refactor: extract code to make an fd non-clocking into a function. Simply extract part of the code from evtloopunix.cpp into a reusable wxPipe::MakeNonBlocking() function to be able to reuse it elsewhere. See #12636.

2010-11-02 12:57 VZ, revision 65991

Don't scroll the grid too much to bring selection in view. wxGrid scrolled completely to the right in row selection mode as it was always trying to make the bottom right selection corner visible. This was due to adjusting the selection block corner to cover the entire row in this mode (of course, the same was true for the column selection mode too). Don't do this any more as it's unnecessary, making the real selection block corner visible is enough for the block selection mode and nothing else is needed in row/column modes. See #12638.

2010-11-02 12:57 VZ, revision 65990

Changed wxImage::ConvertAlphaToMask() return type to bool. Make this function more useful by returning true from it if alpha channel was really converted to the mask by it. Closes #12637.

2010-11-02 12:57 VZ, revision 65989

Avoid crash when releasing the mouse in wxRibbonToolBar. The active tool pointer can be changed/set to NULL by the event handler in wxRibbonToolBar::OnMouseUp() so test for it before using it after processing the event. Closes #12640.

2010-11-02 04:09 RD, revision 65987

Add some asserts to ensure cols and rows are >= 0 to avoid crashes

2010-11-02 04:07 RD, revision 65986

Fix return types on wxRect::Inflate and Deflate

2010-11-01 18:01 PMO, revision 65974

More wxRadioBox implementation

2010-11-01 18:00 PMO, revision 65973

Improved naming for internal functions

2010-11-01 13:30 PMO, revision 65971

Update to trunk r65969

2010-11-01 12:58 JJ, revision 65970

Create work-around for wxGetEnvMap on OpenVMS (correction)

2010-11-01 10:48 JJ, revision 65969

Create work-around for wxGetEnvMap on OpenVMS

2010-10-31 14:41 VZ, revision 65968

Make wxMBConv_iconv MT-safe by not using wxString in it. Use just "char *" for wxMBConv_iconv::m_name to avoid MT-safety problems related to using a wxString (which is not always MT-safe) from multiple threads. See #12630.

2010-10-31 14:33 VZ, revision 65967

Avoid events when implicitly selecting first wxBookCtrl page. The first page added to a wxBookCtrlBase-derived control is always selected, even if "bSelect" argument of AddPage() was false. This is necessary because a non-empty book control must always have a selection but the "selection changed" event generated when doing it is unexpected. Fix this by not generating any events when the first page is implicitly selected. Closes #12075.

2010-10-31 12:37 VZ, revision 65966

Reposition wxSpinCtrl correctly after reparenting it in wxMSW. The position of wxSpinCtrl after reparenting was wrong because we didn't remember the old position early enough. There also was a more minor bug which resulted in the position not being set correctly if (any of its components) was -1 before reparenting. Closes #12633.

2010-10-31 12:37 VZ, revision 65965

Destroy correct HWND in wxMSW wxSpinCtrl::Reparent(). NULL HWND was passed to ::DestroyWindow() as wxWindow::UnsubclassWin() NULLed it after unsubclassing. See #12633.

2010-10-31 01:51 VZ, revision 65964

Document wxMessageQueueError. Document the enum defining the error codes of wxMessageQueue<> class. Closes #12634.

2010-10-31 01:51 VZ, revision 65963

wxUniv/MSW compilation fix in wxWindowBase::GetDlgUnitBase(). This wxWindowBase method can't access protected m_font member of another wxWindow object -- but can access it in wxWindowBase object. Closes #12358.

2010-10-31 01:51 VZ, revision 65962

No changes, just use AutoHBITMAP instead of manual DeleteObject() in wxMSW. Use RAII AutoHBITMAP class instead of manually calling DeleteObject() on temporary bitmaps in wxMSW wxImageList and wxBitmap code.

2010-10-31 01:51 VZ, revision 65961

Fix conversion of bitmaps with alpha to icons/cursors in wxMSW. CreateIconIndirect() applies pre-multiplication to the bitmap itself (as can be seen by experimenting with this or reading WINE sources for it) and so we must pass it a bitmap with data in non-pre-multiplied format to avoid doing it twice. This is similar to the change to wxImageList in the previous commit, see #9050.

2010-10-31 01:50 VZ, revision 65960

Add bitmaps in non-premultiplied format to wxImageList in wxMSW. ImageList_Draw() applies pre-multiplication to the bitmap itself (as can be seen by experimenting with this or reading WINE sources for it) and so the image list must store bitmaps with data in non-pre-multiplied format to avoid doing it twice. Do it by converting wxBitmaps passed to wxImageList::Add() and Replace() to wxImage and then to non-pre-multiplied DIBs. This is obviously very inefficient but at least results in correct appearance of images drawn by wxImageList so it's a step forward. Closes #9050.

2010-10-31 01:50 VZ, revision 65959

Allow creating DIBs storing pixels in non-premultiplied format in wxMSW. wxDIB assumed that MSW always uses bitmaps in pre-multiplied pixel format but this turns out to be wrong: some Windows functions such as ImageList_Draw() or CreateIconIndirect() apply pre-multiplication internally and so must be given data in non-pre-multiplied format on input. This commit adds a possibility to create wxDIB in such format but doesn't use it anywhere yet, this will be done in subsequent commits. See #9050.

2010-10-31 01:50 VZ, revision 65958

Make it impossible to initialize AutoHBITMAP after construction. Add default ctor and Init() method to wxMSW private AutoHBITMAP class. This doesn't change anything for now but will be used by an upcoming commit.

2010-10-31 01:50 VZ, revision 65957

Fix fatal bug in wxGetWindowFromHWND() for radio buttons. wxGetWindowFromHWND() could crash if it was called for a HWND of a radio button which was not created by wxWidgets because it blindly dereferenced the user data associated with the button expecting it to be a pointer to wxRadioBox and crashed if it was something different. And this actually happened when using the standard Windows printing dialog which can contain radio buttons which obviously used their user data field for their own purposes. Fix this by maintaining a global hash map with radio buttons HWNDs as keys and radio boxes as values. This ensures that we can always safely check whether the given HWND is a radio button in one of our radio boxes or not. Also change wxSpinCtrl which already did something similar in a different way (using an array instead or a more efficient hash map) for consistency. Closes #12083.

2010-10-31 01:50 VZ, revision 65956

Restore the old logger in wxLogChain dtor instead of deleting it. wxLogChain was leaving the global log target pointing to a deleted object, resulting in crashes when using wxLogWindow without any explicit SetActiveTarget() calls. Restore the original logger as the active target in wxLogChain dtor to ensure that the active log target remains valid.

2010-10-31 01:50 VZ, revision 65955

Fix confusion with LOGFONT{A,W} parameters to MSW GetTheme[Sys]Font(). Change the signature of GetThemeFont() and GetThemeSysFont() methods of wxUxThemeEngine to take an artificial wxUxThemeFont::Ptr type instead of LOGFONT which allows the broken code to compile correctly and even work in Unicode builds but crashed in ANSI ones under Windows Vista/7 as these functions expect a LOGFONTW and not LOGFONTA even in non-Unicode build under these systems. This generalizes the previous fix/workaround for the same problem in wxStaticBox so remove it now and use wxUxThemeFont both there and in wxMenuItem to avoid crashes when using owner-drawn menus in ANSI build. Closes #12364.

2010-10-31 01:50 VZ, revision 65954

No real changes, just cleanup of wxMSW MenuDrawData. Derive MenuDrawData::Margins from Windows MARGINS struct to avoid ugly (and potentially dangerous) reinterpret_cast<>s when using it. Also add some helper functions to Margins to make using it less painful.

2010-10-30 21:01 VZ, revision 65953

Use TAbs in debian/rules, not spaces, as it's a makefile. Fix make syntax error in debian/rules. Closes #12631.

2010-10-30 21:01 VZ, revision 65952

Fix order of arguments in wxOSX/Carbon wxListCtrl::ScrollList(). wxMacDataBrowserTableViewControl::SetScrollPosition() takes "top" and "left" arguments so swap "dx" and "dy" parameters being passed to it. It might be better to fix SetScrollPosition() to follow the more natural (at least from wx point of view) convention and as it's used in only a few places this wouldn't be difficult to do. But let's keep the changes to this code to the minimum for now. Closes #12339.

2010-10-30 17:57 VS, revision 65951

For large dataview controls, don't use all items to calculate best column width. Instead, use just top and bottom N/2 items for some large enough value of N. N is determined dynamically so that column best width calculation doesn't take more than 50ms.

2010-10-30 17:57 VS, revision 65950

Add wxDataViewRendererBase::PrepareForItem() helper. For calling SetValue() and SetAttr() consistently, instead of having the same code duplicated all over the place.

2010-10-30 17:57 VS, revision 65949

Account for text attrs in generic wxDataViewCtrl's renderers. When determining cell content's size, GetSize() measured the text using wxDataViewCtrl's font, even though it could be renderer in bold or italics. Corrected by setting the attributes - and not only the value - prior to GetSize() calls, and by using the right font in GetTextExtent() calls.

2010-10-30 17:57 VS, revision 65948

Add optional columns autosizing to wxDataViewCtrl. Only implemented in the generic and GTK+ versions at the moment, OS X support will be added later.

2010-10-30 17:57 VS, revision 65947

Add wxRenderer::GetHeaderButtonMargin(). Used for best size calculations of column width.

2010-10-28 18:41 PC, revision 65945

fix iconize event detection, logical operators don't work for testing bits

2010-10-28 16:23 VZ, revision 65944

Use floating point arithmetic in wxDC::GradientFillConcentric(). Use doubles to avoid accumulated rounding errors from using integers in the generic implementation of wxDC::GradientFillConcentric(). This results in smoother gradient. Also avoid using the expensive pow() function inside the inner loop when we just need to calculate a square. Closes #12337.

2010-10-28 16:23 VZ, revision 65943

Fix generic implementation of wxDC::GradientFillConcentric(). The selected colour was not used as the code simply changed the value of m_pen but didn't call SetPen() to actually use it. This resulted in always using the default (black) colour when drawing concentric gradients. Fix this by calling SetPen(). See #12337.

2010-10-28 16:23 VZ, revision 65942

Relax validation of wxCheckBox flags. Changes of r65824 resulted in asserts when creating wxCheckBox with just wxBORDER_NONE style. This is useless but used to be harmless so continue to allow this. Closes #12628.

2010-10-28 15:52 VZ, revision 65941

Improve positioning of wxSlider min/max labels in wxMSW. Put the min/max labels on the sides or a horizontal slider or above/below a vertical one to make them visually more distinct from the current value label. See #11427.

2010-10-28 12:27 VZ, revision 65940

wxOSX/Carbon compilation fix after wxListBoxBase changes. Making wxListBoxBase::CalcAndSendEvent() broke wxOSX/Carbon build, fix it by making the class which needs to call it friend of wxListBox in this port.

2010-10-28 12:27 VZ, revision 65939

Don't crash when waiting for thread termination in wxMSW. The changes of r65882 adding wxThread::On{Delete,Kill}() introduced a bug which made normal wxThread::Wait() crash. Fix it by calling OnDelete() only if we're really deleting a thread. Closed #12627, see #9046.

2010-10-28 01:22 VZ, revision 65938

Fix list box unit test under wxGTK. Select an item initially to prevent GTK from doing it automatically as soon as the listbox is clicked anywhere (even outside of the items area). This makes all GUI tests finally pass under wxGTK.

2010-10-28 01:22 VZ, revision 65937

No changes, just use wxGtkObject<> instead of g_object_unref(). Use smart pointer class instead of manually writing g_object_unref(). This makes code shorter and less error-prone.

2010-10-28 01:22 VZ, revision 65936

Don't duplicate event sending code in wxGTK wxListBox. Reuse wxListBoxBase::SetEvent() instead of duplicating its code in wxGTK. Also get rid of the code checking for selection of the item with index -1: this can't happen any more since r65865 which changed GTK_SELECTION_SINGLE to GTK_SELECTION_BROWSE.

2010-10-28 01:21 VZ, revision 65935

Don't send SELECTED events for an already selected item in wxGTK wxListBox. Bring wxGTK in line with wxMSW behaviour and avoid sending the wxEVT_COMMAND_LISTBOX_SELECTED events when the user clicks on an already selected item. Refactor wxMSW code to extract the logic to avoid such events into a reusable in other ports wxListBoxBase::DoChangeSingleSelection() function. Also add wxListBox::GTKOnSelectionChanged() to wxGTK to avoid having to make the new function public just so that it could be called by GTK callback and make the previously existing CalcAndSendEvent() protected as well. This fixes a unit test failure in ListBoxTestCase::ClickEvents() under wxGTK.

2010-10-27 23:41 VZ, revision 65934

wxOSX compilation fix: remove just added extra semicolon. r65931 forgot to remove a now extra semicolon from wx/osx/notebook.h, fix it.

2010-10-27 22:23 VZ, revision 65933

Fix warnings about signed/unsigned comparisons inside wxMax() and friends. wxMax, wxMin and wxClip work correctly when called with a mix of signed and unsigned arguments but give warnings about comparing them when compiled with g++. Cast both arguments to the result type, which is defined consistently with standard C rules for implicit promotion, before comparing them to avoid this. Also add more tests to check that using these functions in this case doesn't provoke warnings.

2010-10-27 21:42 RR, revision 65932

Use window-state-event to send ICONIZE events under GTK+, probably fixes #10973: Iconize event triggered when switching workspaces with Ctrl+Alt+[Arrow Key]

2010-10-27 18:54 VZ, revision 65931

Refactor: use wxBookCtrlBase::m_selection in all derived classes. All book control classes with the exception of wxGTK wxNotebook stored the currently selected page in m_selection or m_nSelection (or, in wxUniv wxNotebook case, m_sel) variable. Remove all of them and add m_selection directly to the base class itself so that it can be reused everywhere. Closes #12622.

2010-10-27 18:54 VZ, revision 65930

No real changes, just replace -1 with wxNOT_FOUND in wxBookCtrl code. Make the code consistently use wxNOT_FOUND instead of -1 everywhere. See #12622.

2010-10-26 17:11 VZ, revision 65929

Don't dispatch messages while waiting in worker thread in wxMSW. We only want to continue dispatching messages while waiting for another thread to terminate if we are waiting in the main thread. Closes #12618.

2010-10-26 17:11 VZ, revision 65928

Compilation fix for wxUSE_UNICODE_WCHAR && !wxUSE_STL_BASED_WXSTRING. Construct wxScopedWCharBuffer using CreateNonOwned() in wxString::ToStdWstring() in this case, creating it directly from wc_str() doesn't work (intentionally, as this doesn't tell if the buffer owns the string or not).

2010-10-26 17:10 VZ, revision 65927

Better document wxAutomationObject::GetDispatchPtr() return value. This function returns IDispatch pointer as a void one, mention that the user code needs to upcast it itself. Closes #12617.

2010-10-26 17:10 VZ, revision 65926

Rebake to add wx/meta/implicitconversion.h to the makefiles. Rebake after the addition of a new public header in r65920. Closes #12616.

2010-10-25 23:52 VZ, revision 65924

Mention that resource forks are deprecated under Mac in wxCursor docs. See #12614.

2010-10-25 22:46 VZ, revision 65923

Use the correct accelerator for the "Preferences" Apple menu item. Use the standard Command-, accelerator for the standard "Preferences" item in the Apple menu. Closes #12121.

2010-10-25 22:46 VZ, revision 65922

Use the application name in the "About" item of the Apple menu. To conform to Apple UI guidelines the application name should be included in the "About" menu item label in the Apple menu. See #12121.

2010-10-25 11:43 VS, revision 65921

Add wxImplicitConversionType tests.

2010-10-25 11:43 VS, revision 65920

Make wxMin, wxMax and wxClip template functions. Previously used macro's arguments were evaluated twice, but there were many occurences of their use in our code that didn't account for this and used expensive-to-evaluate arguments as if they were functions.

2010-10-25 11:24 JS, revision 65919

Style page no longer grows to fit very long style names; freeze/thaw used for speed

2010-10-25 11:22 VZ, revision 65918

Compilation fix: don't use "environ" under OS X. The global environ variable is not directly accessible under OS X, use _NSGetEnviron() instead.

2010-10-25 01:06 VZ, revision 65917

Make wxUString compilable with VC6. Provide replacements for std::basic_string functionality missing from this compiler standard library. Closes #12357.

2010-10-25 01:03 VZ, revision 65916

Fix typo in wxFILTER_NUMERIC documentation. Replace wxFILTER_SIMPLE_NUMBER with wxFILTER_DIGITS. Closes #12341.

2010-10-25 01:03 VZ, revision 65915

Add wxDocManager::FindTemplate() method. This allows to find the template corresponding to the document of the given class. Closes #12170.

2010-10-25 01:03 VZ, revision 65914

Don't handle RPC_E_CHANGED_MODE return of OleInitialize() as an error. This error means that OLE had already been initialized so from our point of view it counts as a success. Closes #12516.

2010-10-25 00:41 VZ, revision 65913

Do nothing in wxMemoryDC::SelectObject() if the bitmap is already selected. It doesn't make sense to make a copy of the bitmap in order to select it into wxMemoryDC if it's already selected into it. See #11640.

2010-10-25 00:41 VZ, revision 65912

Always create new OLE objects with reference count of 1, not 0. There are no real changes but ensure that the new objects of classes using DECLARE_OLE_UNKNOWN() macro are created with valid reference count of 1 instead of being created in phantom state with reference count of 0. Remove the now unnecessary AddRef() and add the now required DecRef() calls. See #11566.

2010-10-25 00:41 VZ, revision 65911

Fix problems with reference counting in wxActiveXContainer. Ensure that the IFrameSite object is created with valid (i.e. non-zero) reference count by calling AddRef() on it immediately after creation and remove the weird QueryInterface() call which was used to work around this bug. Closes #11566.

2010-10-25 00:41 VZ, revision 65910

Don't consider lack of connection points an error in wxActiveXContainer. Handle CONNECT_E_NOCONNECTION return value from IConnectionPointContainer:: FindConnectionPoint() as an expected error and don't complain about it. See #11566.

2010-10-25 00:41 VZ, revision 65909

Don't activate the window when updating its styles in wxMSW. Add SWP_NOACTIVATE to the flags used by wxWindow::MSWUpdateStyle(). This allows to change the style of a window without necessarily activating it. Closes #11560.

2010-10-25 00:41 VZ, revision 65908

Fix wrong wxLogDebug() call in fswatcher sample. Replace wxLogDebug() with wxLogTrace() as was probably intended. This fixes the assert which happened when running the sample because of the wrong number of parameters passed to wxLogDebug().

2010-10-25 00:41 VZ, revision 65907

Allow specifying the directory to watch on command line of fswatcher sample. This makes it more convenient to run the sample repeatedly as the directory to watch can be specified only once instead of having to choose it interactively after the sample startup every time.

2010-10-25 00:41 VZ, revision 65906

Avoid duplicate wxEVT_COMMAND_TREE_SEL_CHANG{ING,ED} events in wxMSW. When changing the selected item programmatically 2 CHANGING and CHANGED events were sent because the assumption that comctl32.dll didn't send these events itself was not correct any more, it does send them at least since XP. However to avoid the tests for its exact version it's simpler to just ignore the events it generates and continue sending our own ones. Closes #11274.

2010-10-25 00:41 VZ, revision 65905

Don't grab focus when calling wxTreeCtrl::SelectItem(). The workaround for the unexpected events order introduced in r49588 should only apply to the situation when the user selects an item in the tree, not when it's done programmatically as this results in unexpected focus changes (see #11274).

2010-10-25 00:40 VZ, revision 65904

Allow to use space to toggle spinning of the cube in OpenGL sample. Small enhancement to the cube OpenGL sample. Closes #11545.

2010-10-25 00:40 VZ, revision 65903

Don't send wxEVT_COMMAND_TREE_ITEM_MENU event without valid item in wxMSW. The generic wxTreeCtrl version only sends this event when the mouse is right clicked on a valid item so do the same in wxMSW version too for consistency. This is also consistent with wxEVT_COMMAND_TREE_ITEM_RIGHT_CLICK event and avoids strange problems with unexpected wxEVT_COMMAND_TREE_ITEM_MENU events generated on right double click. Finally, replace the checks for item validity in the event handler in the sample with asserts which should loudly complain if it happens to be invalid. Closes #11226.

2010-10-25 00:40 VZ, revision 65902

No real changes, just cleanup week days handling in wxGenericCalendarCtrl. Use helper GetWeek{Start,End}() functions instead of repeating tests for wxCAL_MONDAY_FIRST over and over again. Also replace some occurrences of GetWindowStyle() with shorter and more clear HasFlag().

2010-10-25 00:40 VZ, revision 65901

Keep displayed month and year in sync in wxGenericCalendarCtrl. When the date was constrained to a range in wxGenericCalendarCtrl, the display of the month in the month combobox could get out of sync with its real value. Ensure that the correct month is always displayed and also simplify the code by removing the apparently unnecessarily complex logic in ChangeYear() and ChangeMonth() functions. Closes #11060.

2010-10-25 00:40 VZ, revision 65900

No real changes, just inline wxDIB::Create(). After removing wxDIB::m_hasAlpha in the previous commit, this method became completely trivial so put it inline in the header.

2010-10-25 00:40 VZ, revision 65899

Remove wxDIB::m_hasAlpha from wxMSW. This field can't be set reliably as we don't know if LoadImage() Windows function loaded an 0RGB or an RGB bitmap so remove it completely to avoid the risk of using it wrongly.

2010-10-25 00:40 VZ, revision 65898

Fix conversion of 32 bit ARGB bitmaps to wxImage in wxMSW. wxDIB::m_hasAlpha can't be trusted when the DIB was loaded from a file so don't rely on it in wxDIB::ConvertToImage(). Instead, suppose that 32 bpp bitmaps do have alpha channel and only get rid of it at the end of conversion if it turns out that all alpha values were 0. Closes #10133.

2010-10-25 00:40 VZ, revision 65897

Don't hard code "open" verb in wxMSW wxLaunchDefaultApplication(). Don't choose the verb explicitly and let ShellExecuteEx() choose the default one. In the vast majority of cases this will do the same thing but if some file type doesn't have an "open" verb the new version will still open it correctly using its default verb while the old version failed. See #10707.

2010-10-25 00:40 VZ, revision 65896

Add support for specifying child process cwd and env to wxExecute(). Add an optional wxExecuteEnv parameter to wxExecute() which allows to specify the initial working directory and custom environment for the child process. Closes #12163.

2010-10-25 00:40 VZ, revision 65895

Treat wxToolbook symmetrically with others in the notebook sample. Use wxToolbook as the default notebook type if the other ones are not available. Closes #12610.

2010-10-25 00:39 VZ, revision 65894

Don't reserve space for hidden controller in wxBookCtrl. Even when the controller was hidden, space was still allocated for it by wxBookCtrl. Fix this by only reserving extra space when the controller is shown. Closes #12609.

2010-10-24 16:34 VZ, revision 65893

Set wxKeyEvent::m_rawFlags to hardware key code in wxGTK. The raw flags were previously unused in wxGTK but hardware key code is an important information which may be useful to the application, so pass it in the flags (this is rather symmetric with passing lParam in it under MSW as lParam contains the scan code, among other things). Also document the meaning of raw key code and flags in all the major ports.

2010-10-24 16:34 VZ, revision 65892

Output header to the same directory as the .cpp file in wxrc. If "-o" option is given, generate the output header file in the same directory as the .cpp file and not in the current directory. Closes #4054.

2010-10-24 16:34 VZ, revision 65891

Use wxChoicebook instead of wxNotebook in the xrc sample. wxNotebook was unusable with so many pages under all platforms and completely unusable under Mac. Replace it with wxChoicebook which allows to select any page quickly instead of having to do it sequentially (or not being able to do it at all under Mac). Another possibility could be to use wxTreebook and organize the pages in categories, similarly to how it is done in the widgets sample. Closes #3699.

2010-10-24 16:34 VZ, revision 65890

Rearrange xrc sample controls in alphabetical order. Several new pages were added in random positions, rearrange them to be in alphabetical order. Also remove wxToolBar from "The Rest" page as it is shown in one of the other pages now.

2010-10-24 16:33 VZ, revision 65889

Make it easier to define custom wxSizerXmlHandler subclasses. No real changes but refactor wxSizerXmlHandler to make it easier to derive from it by adding virtual IsSizerNode() and DoCreateSizer() methods. To add support for a custom sizer class you only need to override them in wxSizerXmlHandler subclass now. Also document wxSizerXmlHandler which was not documented at all previously. Closes #11845.

2010-10-24 16:23 VZ, revision 65888

Make wxXmlResourceHandler::IsOfClass() static. This simple helper function doesn't use any wxXmlResourceHandler data as it's just a trivial wrapper for wxXmlNode::GetAttribute(). Making it static allows, in particular, to call it from const member functions of wxXmlResourceHandler-derived classes (making it "const" itself would achieve this too, of course, but it just doesn't need to be non-static).

2010-10-23 23:47 VZ, revision 65887

Add wxIcon::GetSize() to wxIcon in wxOSX. This fixes the compilation errors under OS X after r65884 due to the lack of this method there.

2010-10-23 20:56 VZ, revision 65886

Don't use non-existent icon in XRC sample. appicon.xpm was removed so use another icon in the controls demo in the sample instead, it doesn't matter which one we use anyhow.

2010-10-23 20:56 VZ, revision 65885

Add XRC handler for wxToolbook. Closes #11615.

2010-10-23 20:56 VZ, revision 65884

Don't assume any particular default size for XRC image lists. Let the image list deduce its size from the first bitmap in it. This is better than the old behaviour of using the standard icon size as it allows to omit the size from the image lists provided they contain the bitmaps of the same size.

2010-10-23 20:56 VZ, revision 65883

Correct wxDialog::SetAffirmativeId() documentation. The return value of ShowModal() is the affirmative id and not wxID_OK, of course. See ##11413 (specifically comment 5).

2010-10-23 16:10 VZ, revision 65882

Added wxThread::OnKill() and OnDelete() callbacks. Call OnXXX() from wxThread::Kill() and Delete() respectively to allow the thread being terminated perform some cleanup. Closes #9046.

2010-10-23 16:10 VZ, revision 65881

Construct paths using wxFileName in wxHTML help. Use wxFileName instead of more complicated and error-prone manipulations with strings. Closes #12602.

2010-10-23 16:09 VZ, revision 65880

Use rpmbuild to build the RPMs in "make rpm" target. In recent versions of rpm rpmbuild must be used for building the RPMs instead of rpm itself. See #12567.

2010-10-23 16:09 VZ, revision 65879

Add more headers to "make dist" and remove .mo files. Add wx/persist headers to the list of files used by "make dist" and remove the message catalogs which shouldn't be part of the source distribution. See #12567.

2010-10-23 16:09 VZ, revision 65878

Include wxscintilla library in wxGTK RPM. Include libwxscintilla.a for static linking. See #12567.

2010-10-23 16:09 VZ, revision 65877

Generate the full list of wxBase headers paths in wxGTK.spec. Instead of hardcoding the list of wxBase headers path, build it automatically from the list of their base names which is generated by bakefile and so is always up to date. See #12567.

2010-10-23 16:09 VZ, revision 65876

Force the use of GNOME printing support and wxMediaCtrl in wxGTK RPMs. Explicitly enable the use of GNOME printing and media control to ensure that RPMs are always created with these features enabled. See #12567.

2010-10-23 16:09 VZ, revision 65875

Remove "release" suffix from wx-config links used in RPMs. We don't distinguish debug and release builds under Unix any more in 2.9 and don't use "release" and "debug" suffixes in full wx-config names. Remove these suffixes from the wx-config links created by RPM post-installation step. See #12567.

2010-10-23 16:09 VZ, revision 65874

Document that wxProcess::GetOutputStream() can't be used after CloseOutput(). As closing the output stream makes it unusable, it is destroyed as well and so GetOutputStream() returns NULL after calling CloseOutput(). Closes #12605.

2010-10-23 16:03 RR, revision 65873

wxDataViewCtrl::Expand() only works on items whose parents are already expanded. The attached patch fixes this by expanding all ancestors of the item before expanding the item itself. Closes #12585: wxDataviewCtrl::Expand() needs to expand all ancestors

2010-10-23 16:00 RR, revision 65872

Set focus to generic wxDataViewCtrl when clicking with any mouse button, not just left, closes #12586: wxDataviewCtrl only gets focused on left mouse

2010-10-23 15:53 RR, revision 65871

Implement wxDataViewCtrl::HitTest() under GTK+, second part of #12582: enhancing wxDataViewCtrl, closes #12582

2010-10-23 15:48 RR, revision 65870

Also set mouse position in ITEM_BEGIN_DRAG event in wxDataViewCtrl under GTK+, part of #12582: enhancing wxDataViewCtrl

2010-10-23 00:15 MW, revision 65869

Change the return code of the test program so that aborting a test with an exception doesn't count as a failure, to provide a way to skip tests that can't be performed.

2010-10-23 00:12 MW, revision 65868

Add debugging info to the trunk Linux builds.

2010-10-22 18:33 VZ, revision 65867

Enable ListBoxTestCase::HitTest() for wxGTK. wxListBox::HitTest() does work in wxGTK but we need to realize the control before using it.

2010-10-22 18:33 VZ, revision 65866

Restore the note about auto-repeat in key events documentation. Closes #12598.

2010-10-22 18:33 VZ, revision 65865

Use GTK_SELECTION_BROWSE instead of SINGLE for wxListBox in wxGTK. A single-selection listbox must always have a selected item, at least after initial selection is done, i.e. its selected item can't be deselected. This behaviour corresponds to GTK_SELECTION_BROWSE style in GTK+. Closes #2549.

2010-10-22 16:17 VZ, revision 65864

Fixes for calling Enable() on children of a disabled TLW in wxMSW. The change of the child window state wasn't reflected immediately if it was done while the TLW itself was disabled but only happened when it was reenabled and in some cases the child could not be enabled even then. Fix this by updating the child state immediately, even when its TLW parent is disabled and only skip the update of the children state when TLW is being disabled, not when it's enabled back. Closes #11622.

2010-10-22 16:17 VZ, revision 65863

Use single BeforeLast() call in wxConfigPathChanger ctor. Use a single BeforeLast() call with the "rest" argument and avoid calling AfterLast() laster in wxConfigPathChanger ctor. This is a small optimization which may count because wxConfigPathChanger is used in a lot of wxFileConfig functions but, even more importantly, this works around a bug in g++ 4 optimized build when the name was not filled by AfterLast() call correctly as apparently the optimizer decided it was not used. The real cause of this compiler bug was difficult to find as it couldn't be reproduced in a simple test case but this change avoids it and fixes wxFileConfig unit test in optimized build.

2010-10-22 16:17 VZ, revision 65862

Added "rest" argument to wxString::Before{First,Last}(). This allows to search the string just once, in BeforeXXX(), when both the parts of the string before and after some character are needed instead of having to do it twice in both BeforeXXX() and AfterXXX().

2010-10-22 16:17 VZ, revision 65861

No real changes, just use const_cast<> instead of C casts. Replace many comments indicating that the C cast used was really a const_cast<> with the proper cast itself. There is no reason to not use it any longer, all the supported compilers understand it.

2010-10-22 16:17 VZ, revision 65860

Don't add quotes to string representation in gdb. gdb adds quotes itself around string values so don't duplicate them.

2010-10-21 21:51 VZ, revision 65859

Add missing comparison operator declarations in wxString::iterator. Fix compilation in !wxUSE_UNICODE_UTF8 case after r65857. Modify the second declaration of wxString::iterator class which was not updated by the previous commit in the same way, i.e. add declaration of comparison operators taking const_iterator to iterator class.

2010-10-21 21:44 VZ, revision 65858

Document the meaning of wxToolBar tool id more clearly. Make it clear that the id is the same one as was passed to AddTool(). Closes #12597.

2010-10-21 21:22 VZ, revision 65857

Implement comparisons between wxString::iterator and const_iterator. Only comparisons between const_iterator and iterator worked before (because of implicit conversion from the latter to the former), implement the ones in the other direction explicitly now. Closes #12594.

2010-10-21 01:11 VZ, revision 65856

Add XRC handler for wxCommandLinkButton. Added a handler for wxCommandLinkButton class and a demo of it in the xrc sample. Closes #12593.

2010-10-21 01:11 VZ, revision 65855

Merge wxBitmapButton and wxButton panels in the xrc sample. There are already way too many pages in the "Controls Example" in the sample, combine wxBitmapButton and wxButton ones to save some space and make it more usable.

2010-10-21 01:11 VZ, revision 65854

Correct the fix that broke wxRegion::ConvertToBitmap(). The changes in r64874 were incorrect and made the size of the bitmap even more wrong than before. Fix it correctly now by just adding 1 extra pixel to the size of the bitmap used in the original (pre-r64874) version. Closes #12213.

2010-10-20 19:49 PJC, revision 65852

Improve support for ribbon panel sizers: panels with sizers should now automatically minimise at small sizes, and behave properly when popping up from a minimised state. Patch by johnr in trac issue #12580.

2010-10-20 15:08 MW, revision 65851

Check for window manager before running GUI tests on unix.

2010-10-19 01:43 VZ, revision 65847

Change wxSP_XXX flags values to avoid clashes with wxTE_XXX. wxSP_ARROW_KEYS conflicted with wxTE_AUTO_URL (which was probably not important in practice as URLs don't appear in spin controls anyhow) and wxSPWR conflicted with wxTE_NOHIDESEL (which could conceivably be a problem). Change their values to reuse the bits of wxTE_CHARWRAP and wxTE_RICH2 neither of which definitely makes sense for a spin control. Closes #11461.

2010-10-19 01:43 VZ, revision 65846

Use unsigned char for XBM bitmaps data. This fixes compilation with g++ in C++0x mode in which conversions of constants not fitting into signed char range to char are not permitted. Closes #12575.

2010-10-19 01:43 VZ, revision 65845

Correctly handle S_FALSE return value of IActiveMovie::get_Duration(). IActiveMovie::get_Duration() can return S_FALSE in which case outDuration isn't initialized and so wxAMMediaBackend::GetDuration() would return a completely wrong value. Fix this by returning 0 from it instead which seems like the only reasonable thing to do (in the absence of documentation of this interface it's not really clear what does S_FALSE return value mean nor why didn't it return it before).

2010-10-19 01:43 VZ, revision 65844

Correct recently broken checked state handling in wxRearrangeList. The checked state of them wasn't preserved correctly any more since r64875, correct this by changing the state only after storing the old one. Closes #12578.

2010-10-19 01:43 VZ, revision 65843

Add missing "static" to wxSystemOptions::SetOption() documentation. Closes #12576.

2010-10-18 15:55 JMS, revision 65841

Call wxScrollHelper::AdjustScrollbars() to fix scroll bar setup that broke after wxPropertyGrid was changed to inherit from wxScrollHelper instead of wxScrolledWindow

2010-10-17 20:17 VZ, revision 65840

Fix wxSTC compilation without wxUSE_DRAG_AND_DROP after r65827. Correct the changes of r65827 to also compile with wxUSE_DRAG_AND_DROP==0 (especially important for the ports without dnd support such as wxX11 and wxDFB). Also do the changes in the correct files, i.e. src/stc/stc.{h,cpp}.in and not in the generated files themselves to prevent them from being overwritten the next time gen_iface.py is ran. Finally keep backwards compatibility as SetDragAllowMove(bool) is a public method so preserve its old semantics and add a new SetDragFlags() instead of silently breaking the existing code using SetDragAllowMove(). See #11709.

2010-10-17 16:06 MW, revision 65839

Disable the Mingw x64 builds as there's no compiler.

2010-10-17 15:59 VZ, revision 65838

No real changes, just fix a warning in the test suite. Don't assign wxNO_LEN to int variable, this results in gcc warnings about overflow in implicit constant conversion. Use size_t for the variable containing string length to fix it.

2010-10-17 15:59 VZ, revision 65837

Revert the changes of r65826 in wxConvertToGTK(). This is not necessary any longer after the previous commit which changed cMB2WC() to not return NULL for empty input. See #12432.

2010-10-17 15:59 VZ, revision 65836

Return valid buffer from wxMBConv::c{MB,WC}2{WC,MB} for empty input. Returning invalid buffer for empty input is unexpected and resulted in e.g. wxString::utf8_str() returning NULL and not "" in ANSI build for empty strings (which, in turn, resulted in crashes in the test suite and undoubtedly not only) as well as crashes when calling GTK+ functions (see #12432). Other uses of cMB2WC() also show that NULL return value from it is unexpected as it is often passed to CRT functions not accepting NULL. So return empty buffer instead for empty input to avoid all these problems.

2010-10-17 01:05 VZ, revision 65835

Fix FileTestCase to really test strings with embedded NULs. The test was intended to verify that round trip via wxFile::Write/Read() worked even for the strings with embedded NULs but as the string wasn't constructed correctly it didn't actually contain any NULs but was ended by the first of them. Fix this by using explicit length of the string as usual when dealing with strings with embedded NULs. Also fix the conversion back to Unicode to use the correct length.

2010-10-17 01:05 VZ, revision 65834

Disable tests for UTF-encoded files in FileTestCase in ANSI build. These tests didn't work correctly in ANSI build because the conversion parameter of wxFile::Write() isn't used there, the contents of an ANSI wxString is always written to the file as is -- hence reading it back using UTF-16 or UTF-32 conversion fails. The test would need to be totally rewritten for ANSI build of wx and it wouldn't test wxFile but rather conversion functions already tested elsewhere so just disable it instead. This fixes a crash (due to passing NULL pointer to memcmp()) which prevented the test suite from running to completion in ANSI build.

2010-10-17 01:05 VZ, revision 65833

Compilation fix for STL build after r65830. Explicit conversion from wxString to "const char *" is needed in STL build. And even in non-STL build it's wrong to rely on implicit conversion as it wouldn't work correctly in non-UTF-8 locales.

2010-10-16 20:11 VZ, revision 65831

Avoid crashes in wxGenericListCtrl client<->screen conversion code. At least in wxUniv build, DoScreenToClient() can be called before the main control window is created which results in a crash when attempting to forward to its DoScreenToClient() version. Check for m_mainWin being non-NULL before using it to at least avoid the crash, even if it's not really clear whether this is a 100% correct fix. Closes #12390.

2010-10-16 20:11 VZ, revision 65830

Improve wxGTK print and page setup dialogs. Handle more fields (notably collation, number of copies and "print to file" flag) and fix the bug with return value of print dialog ShowModal(). Closes #12499.

2010-10-16 20:11 VZ, revision 65829

Transfer printer name to/from GTK+ native print setup dialog. Printer name in the GTK+ dialog was neither initialized nor retrieved before. See #12499.

2010-10-16 20:11 VZ, revision 65828

Correctly initialize wxGtkPrintNativeData members. In particular, create a valid GtkPrintOperation object instead of using an uninitialized pointer to it in wxGtkPrintDialog::ShowModal(), resulting in crashes or, at best, GTK errors. Closes #12483.

2010-10-16 20:11 VZ, revision 65827

Restore text drag-and-drop in wxSTC broken by Scintilla 2 update. Drag and drop in wxStyledTextCtrl was broken, apparently since upgrade to Scintilla 2. Restore it by using the correct wxDrag_XXX constants instead of boolean values in the code for wxEVT_STC_START_DRAG events generation. Closes #11709.

2010-10-16 20:10 VZ, revision 65826

Don't return invalid buffer from wxConvertToGTK(""). The result of wxConvertToGTK() is often passed to GTK+ functions directly and not all of them handle NULLs gracefully, e.g. gtk_editable_insert_text() just crashes. Return an empty string from wxConvertToGTK() explicitly for empty string input to avoid such problems. Another potential solution might have been to change wxMBConv::cMB2WC() to return empty buffer instead of invalid one for empty input but it's not clear if this is not going to break something else. Closes #12432.

2010-10-16 20:10 VZ, revision 65825

Add wxHAS_3STATE_CHECKBOX symbol. This symbol is defined for the ports that support wxCHK_3STATE style. While most of the ports do support it, a couple still do not and having this symbol makes it more convenient to exclude 3-state-checkbox-specific code, like in CheckBoxTestCase.

2010-10-16 20:10 VZ, revision 65824

Improve validation of wxCheckBox styles. Detect when incompatible styles are used (this required changing the value of wxCHK_2STATE to be non-null) and sanitize the styles (after asserting) in this case. Put the validation code in wxCheckBoxBase instead of having slightly different versions of it in port-specific wxCheckBox implementations. Add a unit test checking that the expected asserts are indeed generated.

2010-10-16 20:10 VZ, revision 65823

Put libraries in %{_libdir} when building wxGTK RPMs. Using the default libdir value ${_prefix}/lib is not always appropriate, notably this takes care of systems using /usr/lib64 instead of /usr/lib.

2010-10-16 12:24 JS, revision 65822

Disabled wxRTC tests that don't work in wxGTK

2010-10-16 01:46 VZ, revision 65821

Clear selection when generic wxDataViewCtrl is cleared. Selection could retain its old value and become invalid after calling Reset() before. Closes #12559.

2010-10-16 01:46 VZ, revision 65820

Add wx{Pen,Brush}::Is[Non]Transparent() methods and use them. Using GetStyle() == wx{PEN,BRUSH}STYLE_TRANSPARENT doesn't work for uninitialized pen or brush objects so add convenient helpers which do work for them. Use the new helper functions everywhere instead of explicitly checking for style. This makes the code shorter and more clear and also fixes some bugs (at least those in GTK printing code). Notice that this patch removes the main reason for explicitly initializing m_pen and m_brush in wxGTKDCImpl ctor but this initialization still can't be removed, at least for the latter, as doing this somehow breaks GetPixel(). It would be nice to understand why and do remove this initialization so that a newly created DC doesn't have any non-default pen nor brush. Closes #12522.

2010-10-16 01:46 VZ, revision 65819

Use wxDCPenChanger instead of setting/resetting pen explicitly. No real changes, just use wxDCPenChanger instead of manual calls to SetPen() in wxDCImpl::DrawPolygon(). This makes the code shorter and more clear.

2010-10-16 01:46 VZ, revision 65818

Add "GTK" prefix to wxChoice::{Dis,En}ableEvents() methods in wxGTK. This is more than a cosmetic change: adding "GTK" prefix in wxComboBox and not doing it in wxChoice in r64436 broke the event generation for wxComboBox as it didn't override wxChoice methods any longer but defined its own (useless) ones. Using the same name for the methods in both classes notably fixes unexpected event generation from wxComboBox::SetSelection(). Closes #12568.

2010-10-16 01:46 VZ, revision 65817

Include wx_presets.py in the distribution made by "make dist". This file is required by "make install".

2010-10-16 01:46 VZ, revision 65816

Check for task dialog availability even under Vista and later. Task dialogs are not always available under Vista and later Windows versions because we might not be using the right (i.e. 6+) version of comctl32.dll. Improve the check for task dialog availability and fall back to the classic message box if we can't use it. Closes #12553.

2010-10-16 01:46 VZ, revision 65815

Remove all mentions of non-existent contrib from .spec files. Remove contrib packages from .spec files. Closes #12567.

2010-10-16 01:46 VZ, revision 65814

Add libraries new in 2.9 to wxGTK.spec. Add propgrid, ribbon and stc libraries. Correct the name of the media library ("mmedia" was an old contrib library name that doesn't exist any more). See #12567.

2010-10-16 01:46 VZ, revision 65813

Fix GTK+ development RPM dependency in wxGTK.spec. Apparently the standard name for this RPM is gtk2-devel and not gtk+-2.0-devel, at least rpmfind.net database doesn't have any matches for the latter and plenty for the former. See #12567.

2010-10-16 01:45 VZ, revision 65812

Fix button order in wxGTK wxMessageDialog and wxStdDialogButtonSizer. The order of buttons in wxGTK wxMessageDialog was accidentally broken since r55482 and wxStdDialogButtonSizer implementation for wxGTK was subsequently modified to work in the same way as the broken version of wxMessageDialog. Fix wxMessageDialog and remove the "compatibility" workarounds from wxStdDialogButtonSizer to restore correct behaviour in both places. Closes #12565.

2010-10-15 17:49 JMS, revision 65808

Fix non-PCH builds

2010-10-15 17:18 JMS, revision 65807

Added the missing DLL export declaration for wxNumericPropertyValidator

2010-10-15 17:15 JMS, revision 65806

Added wxNumericPropertyValidator, which is a custom wxTextValidator with more accurate filtering of inappropriate input for wxIntProperty, wxFloatProperty and wxUIntProperty (fixes #12563).

2010-10-14 20:06 JS, revision 65805

Fixed #12566 (assert on deletion) due to inconsistent commit

2010-10-14 01:08 VZ, revision 65804

wxUniv/MSW compilation fix. wxUniv/MSW compilation was broken by r65589, fix it by not assuming that wxWindowMSW is a wxWindow because wxWindow derives from it in wxUniv. Closes #12534.

2010-10-14 01:02 VZ, revision 65803

Regenerate Makefile.in after recent changes to make_dist.mk. Rebake with changes of r65800, r65801 and r65802.

2010-10-14 00:53 VZ, revision 65802

Remove obsolete files from "make dist" rules. Avoid errors due to attempts to copy non-existing files when making Unix distribution.

2010-10-14 00:53 VZ, revision 65801

Skip Windows-only samples when making Unix distribution. Some samples are by definition Windows-only so they don't have Makefile.in files for Unix at all, skip them when creating the Unix distribution to avoid errors due to attempts to copy non-existent files.

2010-10-14 00:53 VZ, revision 65800

Include include/wx/generic/private/*.h files in distribution. We must include the generic private files into the distribution as well, otherwise at least wxGTK fails to build.

2010-10-14 00:10 VZ, revision 65799

Fix display of right aligned columns in wxGenericListCtrl. Take into account the width of the image when drawing the right aligned item in wxGenericListCtrl. Closes #12562.

2010-10-14 00:10 VZ, revision 65798

Pass last page in wxEVT_WIZARD_FINISHED event. Delay resetting the wizard page to NULL when it terminates to allow wxEVT_WIZARD_FINISHED event to carry the correct pointer to the last page. Closes #12537.

2010-10-14 00:10 VZ, revision 65797

Fix print format specifiers used for enum values. Enums are ints, not longs, so use %d instead of %ld to avoid asserts under LP64 64 bit architectures. Closes #12556.

2010-10-14 00:10 VZ, revision 65796

Don't return "false" when a pointer is needed. Return NULL and not false from wxFileTranslationsLoader:: GetAvailableTranslations(). This is, of course, more correct and also fixes a compilation problem with Borland, see #12558.

2010-10-10 14:48 VZ, revision 65789

Move wxList::Member() to pseudo-template base list class. Member() should be available in all list classes, not just specially crafted list of wxObjects (wxList). See #3616.

2010-10-10 11:34 JMS, revision 65788

When wxPGProperty is un-attached from wxPropertyGrid, keep its 'default' cell references invalid/NULL (fixes #12552)

2010-10-10 10:32 JMS, revision 65787

Also reset DatePicker property editor's global pointer (fixes #11787)

2010-10-09 00:17 JS, revision 65786

Compile fix

2010-10-08 23:51 JS, revision 65785

Blind fix for Mac compile problem

2010-10-08 13:16 MW, revision 65784

Fix for wxChm

2010-10-08 13:16 MW, revision 65783

Fix for wxChm

2010-10-07 22:57 VZ, revision 65782

Don't use default "Error" title for wxMessageOutputBest message box. Use the application display name as the message box title if possible andu se "Message" rather than "Error" otherwise. See #12548.

2010-10-07 22:43 VZ, revision 65781

Remove unnecessary check from IPC sample. No real changes, just remove a check for pointer passed to wxDELETE() bot being NULL as wxDELETE() already checks for this anyhow.

2010-10-06 23:27 JS, revision 65780

Don't use wxDC in header

2010-10-06 22:22 JS, revision 65779

Eliminated redundant wxRichTextAnchoredObject class; refactored XML I/O code so that objects can stream themselves; added a wxXmlDocument-based method of writing XML, though this turned out to be much slower than writing directly so the direct approach is retained and is the default (can be changed with wxRICHTEXT_USE_XMLDOCUMENT_OUTPUT). Loading and saving new attributes implemented. Added custom properties to objects.

2010-10-06 15:15 JS, revision 65778

More efficient access to name and value

2010-10-05 15:38 VZ, revision 65769

Destroy the in-place edit control in wxGenericListCtrl dtor. If the in-place text control was still alive when wxGenericListCtrl was destroyed, it resulted in asserts from wxWindow dtor about child windows still being alive, so explicitly destroy it from wxListMainWindow dtor. As this required a slightly different behaviour from wxListTextCtrlWrapper:: EndEdit(), replace its bool argument with an enum one which can take more than 2 values. Not using bool values when calling it also made the code more clear. Finally, added a unit test verifying that the in-place control is indeed destroyed correctly.

2010-10-05 15:37 VZ, revision 65768

Disable TimerEventTestCase::Multiple() test for ANSI wxGTK build. This test crashes for unknown reasons on wxGTK ANSI build slave and prevents the rest of the test suite from running, so disable it for now.

2010-10-05 15:37 VZ, revision 65767

Fix harmless unused variables warnings. Don't initialize the variables we never use in richtext sample, this results in g++ warnings.

2010-10-05 08:33 JS, revision 65765

Removed test code

2010-10-05 08:17 JS, revision 65764

Added a flag suppressing node content conversion when saving to XML. This helps improve the extremely poor performance of XML saving if you have, for example, hex data that does not need conversion.

2010-10-04 14:25 JS, revision 65762

Exports fixed

2010-10-04 14:20 JJ, revision 65761

Update OpenVMS Makefile

2010-10-04 12:53 VZ, revision 65760

Don't throw assert failure exception in the test suite if it's unsafe. Don't throw when already handling an exception as it would result in a call to terminate() and no useful information about the test failure would be given. Abort ourselves instead to at least give the message about the assert failure. This should help debug the mysterious ListCtrlTestCase failures in buildbot wxGTK builds.

2010-10-04 12:41 VZ, revision 65759

Fix timing format string in the test suite. wxStopWatch::Time() returns a long value so use %ld, not %d. This fixes assert failure when using "-t" option with the test suite under 64 bit Unix architectures.

2010-10-04 12:41 VZ, revision 65758

Fix tests compilation with wxUSE_TOOLTIPS==0 as in wxX11. Unit test suite didn't compile in wxX11 build because it doesn't support tooltips, just disable the relevant test then.

2010-10-04 11:27 JS, revision 65757

Removed redundant GetEditableWindow on GTK+

2010-10-04 10:37 JS, revision 65756

wxRTC no longer derives from wxTextCtrlBase; added wxRichTextAttr deriving from wxTextAttr with CSS-like attributes for future developments; removed image-specific attributes object

2010-10-04 10:10 JS, revision 65755

Avoid id clashes

2010-10-04 00:24 VZ, revision 65754

Fix wchar_t with int comparisons for Apple gcc. Apple gcc refuses to compile comparisons between wchar_t and int for some reason, so add explicit casts to int to make it work there.

2010-10-04 00:23 VZ, revision 65753

Fix wxUSING_VC_CRT_IO definition in the tests when not using MinGW. The condition was always true for non-MinGW compilers because of a missing pair of parentheses, do add them.

2010-10-04 00:23 VZ, revision 65752

Fix gcc warnings about comparing iterators with NULL in STL build. Iterators are not pointers and shouldn't be compared to NULL.

2010-10-03 19:34 VZ, revision 65749

Fix use of DELETE and BACKSPACE when starting editing grid with them. Using the current insertion position in wxGridCellTextEditor::StartingKey() didn't make much sense, it was always 0 -- so DELETE worked as expected and did delete the first character of the cell but BACKSPACE never did anything. Just always delete the first character when DELETE is used and always delete the last one when BACKSPACE is.

2010-10-03 19:34 VZ, revision 65748

Fix non-ASCII key handling in wxGrid editors. Use wxKeyEvent::GetUnicodeKey() correctly, there is no need to guess about what does it return now that its correct behaviour is documented and implemented. Simply check if it returns WXK_NONE to check for non-characters. Also use WXK_START instead of hard-coded 255 when checking GetKeyCode() result.

2010-10-03 19:16 VZ, revision 65747

Disable the use of __thread with MinGW. __thread keyword doesn't work correctly with at least some MinGW builds and in particular TLS unit tests failed with the official 4.4 version. Disable the use of __thread with MinGW entirely for now to be sure that the generated code behaves correctly. In the future we should white list the known good versions of MinGW and/or use run-time test for __thread support in configure instead of compile-time one only.

2010-10-03 19:16 VZ, revision 65746

Update CRT environment in wxSetEnv() for MinGW too. MinGW uses the same CRT as MSVC so we can use the same _putenv() call for it too. This ensures that wxGetenv() returns the value updated by wxSetEnv() and fixes CrtTestCase::SetGetEnv() unit test when using MinGW.

2010-10-03 19:16 VZ, revision 65745

Use wxUSING_VC_CRT_IO for MSVC CRT-specific test results. Move USING_VC_CRT into testprec.h to allow its reuse in other files and rename it to wxUSING_VC_CRT_IO as it only checks whether we're using MSVC STDIO implementation and could be false even when we are otherwise using MSVC CRT. Use this symbol for the tests whose result depends on the concrete version of the CRT we use. This fixes StringTestCase::FromDouble() failure under MinGW.

2010-10-03 19:15 VZ, revision 65744

Fix DirTestCase to run on the systems without "C:" drive. "C:" drive doesn't need to exist under Windows, rely on HOMEDRIVE environment variable defined in all recent Windows versions to get a valid drive letter (still fall back to "C:" if the variable is not defined -- we could have use wxFSVolume to find it then but this seems like an overkill).

2010-10-03 19:15 VZ, revision 65743

Run MBConvTestCase::LibcTests() only for MSVC and not other Windows compilers. This test fails for MinGW, probably because its CRT doesn't use the same locale names as MSVC CRT. Just disable it for now, as it was already disabled for non-MSW platforms. Also use LocaleSetter class (extracted from CLocaleSetter) to change the locale for this test duration only to avoid affecting any tests running after it.

2010-10-03 19:15 VZ, revision 65742

Show the failing string when conversion fails in MBConvTestCase. No real changes, just give more information when a test fails in MBConvTestCase::TestDecoder().

2010-10-03 19:15 VZ, revision 65741

No real changes, just simplify some MBConvTestCase code. Remove unnecessary casts and initialize the variable with its contents directly instead of using strange looking wxWCharBuffer ctor from size_t (even if it did work, it was unnecessary).

2010-10-03 19:15 VZ, revision 65740

Exclude tests relying on last error being set under MinGW. The value of the last error seems to change somewhere between our code and ::GetLastError() call, probably in MinGW CRT, so exclude the tests relying on it being preserved.

2010-10-03 19:15 VZ, revision 65739

Correct wxConvAuto::ToWChar() behaviour with wxNO_LEN input size. We didn't handle the case when the length of the input buffer was not specified correctly and wxConvAuto::DetectBOM() could read beyond the end of input. Moreover, the unit test actually relied on this as it didn't pass the correct length for the literal strings with embedded NULs. This somehow worked with MSVC but failed with MinGW (see #10713). Correct the code to handle wxNO_LEN case correctly and fix the unit test to pass the correct lengths.

2010-10-03 19:15 VZ, revision 65738

Fix VsnprintfTestCase for recent MinGW versions. MinGW now uses its own printf() implementation which handles %p differently from the VC CRT one and uses %8x instead of %8X for it. Compare the results of wxPrintf("%p") case-insensitively to let the test pass in any case. Also introduce a USING_VC_CRT macro instead of testing for __USE_MINGW_ANSI_STDIO in two different places.

2010-10-03 19:15 VZ, revision 65737

Remove redundant wxUSE_WXVSNPRINTF checks from the unit test. The entire VsnprintfTestCase is only used when using our own wxUSE_WXVSNPRINTF so remove the redundant tests for it inside the enclosing #if.

2010-10-03 19:14 VZ, revision 65736

Fix tests compilation without wxUSE_REGEX. Don't build wxRegEx unit tests when wxUSE_REGEX == 0.

2010-10-03 19:14 VZ, revision 65735

Suppress harmless g++ 4.4 warnings about missing braces. Put braces around MSW-only wxLogXXX() calls to avoid warnings when building with MinGW 4.4+.

2010-10-03 12:51 JMS, revision 65734

In wxBitmapComboBox::RecreateControl(), always get recreated control's height from the best size, and also set the ComboBox item height with CB_SETITEMHEIGHT message (fixes #12515).

2010-10-02 18:50 TIK, revision 65730

Backport r65494: Initialize all fields of struct tm used by wxDateTime::Format(). Closes #12455

2010-10-02 17:47 TIK, revision 65726

Backport r65192: Fix attributes escaping when writing XML. Closes #12275

2010-10-02 15:05 TIK, revision 65725

Backport fix for crash in wxCommandProcessor::Store. Closes #12027

2010-10-02 14:57 TIK, revision 65724

Backport r65496: Fix infinite loop in wxDateTime::Format() when fields width was used. Closes #12451

2010-10-02 11:39 TIK, revision 65723

Connect to events only if using native implementation instead of using event table. Closes #12469

2010-10-02 10:53 TIK, revision 65722

Apply #12469: Do not start rename timer if the generic implementation is used which has its own rename timer already.

2010-10-01 15:05 VZ, revision 65707

Add non-vararg wxFileTypeInfo ctor and various setters. This allows to create wxFileTypeInfo objects in a more readable even if more verbose way. This should also incidentally fix the unit tests compilation with VC6 which seems to have some existential troubles with the vararg ctor in debug DLL build (only). Using the non-vararg ctor should hopefully make it happy and let the unit tests pass with this compiler. Also document wxFileTypeInfo class which wasn't documented at all.

2010-10-01 15:05 VZ, revision 65706

Add wxHAS_BITMAPTOGGLEBUTTON and test for it in the unit test. Not all ports define wxBitmapToggleButton class currently, so add a special symbol which is defined only if this class is indeed available and test for it in the unit test for this class. This fixes the tests compilation under wxX11.

2010-10-01 15:05 VZ, revision 65705

Disable ItemClick() unit test for wxListCtrl under wxMSW. This test just doesn't want to work on MSW buildbot slaves even though it works perfectly locally. No idea why but disable it when running on a build bot slave for now to let the entire test suite pass. Also add a comment explaining why the test is disabled for wxGTK.

2010-09-30 19:35 VZ, revision 65694

Disable wxEVT_COMMAND_LIST_ITEM_FOCUSED test for wxMSW. This test fails on MSW buildbot slaves for unknown reasons so disable it to make the test suite pass. The failure is irreproducible locally so no idea how to debug this unfortunately.

2010-09-30 19:30 SC, revision 65693

opening ATSU Font info for Ulrich Telle's wxPDFContext

2010-09-30 16:33 VZ, revision 65692

Add default value for GetPopupMenuSelectionFromUser() position argument. Let the menu be popped up at the system-determined position, just as it can already be done with PopupMenu() itself. Closes #12530.

2010-09-30 16:30 VZ, revision 65691

Correctly convert wxPrintf() to a buffer even when it doesn't fit. ConvertStringToBuf() helper function was defined incorrectly for converting wxString to a char* buffer as it didn't fill the buffer at all if the string didn't fit into it entirely instead of putting as much of the string into it as possible as was already done for the conversion to wchar_t* buffer. This broke wxSprintf()-related functions in when the ASCII output buffer was not big enough as it was not filled at all.

2010-09-30 16:30 VZ, revision 65690

Correct handling of %hs and %ls in our wxPrintf() implementation. The strings corresponding to %hs and %ls are always narrow/wide independently of the build so using wxArgNormalizedString which is defined differently in different builds doesn't make sense in wxPrintf(). Instead, simply expect the parameter of the appropriate matching type for these conversion specifications. Any conversions to it, if necessary, had been already done before by wxFormatString. This fixes some VsnprintfTestCase::BigToSmallBuffer() unit test failures.

2010-09-30 16:30 VZ, revision 65689

Fix handling of asterisks in wxPrintf() implementation. Count the number of asterisks before modifying the string we use to do this, otherwise we were off by one for the format specifications containing two of them. This really fixes the handling of asterisks (used for width/precision) in wxPrintf() format string, it wasn't done correctly by r60120 but now VsnprintfTestCase::Asterisk() test does pass.

2010-09-30 16:30 VZ, revision 65688

Expect an assert in wxVsnprintf() test with too many parameters. The call to wxPrintf() should provoke an assert if there are too many parameters, so update the test to expect it.

2010-09-30 16:30 VZ, revision 65687

Disable test failing under VC6 only. Somehow the expected assert is not generated by wxString::Format("%d", ptr) with VC6. Disable this test to make the test suite pass for VC6 for now to at least be able to monitor the appearance of the new errors in it. Of course, this one should ideally be debugged (by someone who is interested in VC6 support) as well...

2010-09-30 16:30 VZ, revision 65686

Insert another item in the list control in its unit test. For some reason the test fails with a single item in the control when running on the buildbot slave, check if this is still the case if we add another item to the control.

2010-09-30 16:30 VZ, revision 65685

Remove out of date code in DoStringPrintfV(). We can't clear a NULL buffer, the code didn't make any sense any more because it wasn't updated when the function was changed as part of UTF-8 transition. Closes #12529.

2010-09-30 15:09 MW, revision 65683

A couple of fixes for wxChm

2010-09-30 15:09 MW, revision 65682

A couple of fixes for wxChm

2010-09-30 14:30 VZ, revision 65681

More compilation fixes for new wxRTC image code without PCH. Add more headers needed when not using PCH.

2010-09-30 13:44 VZ, revision 65680

No changes whatsoever, just remove trailing whitespace. There are no real changes in this commit but it removes all trailing white space from our source files. This avoids problems when applying patches and making diffs and it would be nice to prevent it from reappearing.

2010-09-30 13:31 VZ, revision 65679

Use Unix EOL format for the new files.

2010-09-30 13:31 VZ, revision 65678

Include correct headers from richtextimagedlg.*. Include or forward declares the classes used by the header to make it self-contained. Do not include wx/wx.h from the source file to make compiling it faster when not using PCH. This fixes compilation under Unix after SOC2010_RTC_IMAGES branch merge.

2010-09-30 13:30 VZ, revision 65677

Remove interface/implementation #pragmas from richtextimagedlg.*. These pragmas are not necessary and may actually be harmful, no idea why were they added in the first place to a new file.

2010-09-30 12:27 VZ, revision 65676

Merge of SOC2010_RTC_IMAGES branch. Added floating images and image property dialog to wxRichTextCtrl, by Mingquan Yang as part of GSOC 2010. Also changed image block creation to use a memory stream instead of creating a temporary file.

2010-09-30 00:01 VZ, revision 65675

Correct printf() format specifiers for long variables in life demo. Fix asserts in 64 bit builds due to using %u (expecting 32 bit values on a typical Unix LP64 platform) for 64 bit long values.

2010-09-29 15:46 VZ, revision 65674

Add EVT_RIBBONBAR_TAB_LEFT_DCLICK event. Generate a special event when a ribbon bar is double clicked. Closes #12399.

2010-09-29 15:46 VZ, revision 65673

Fix crash in wxWebKitCtrl when using JavaScript. Ignore the unknown types of the script result, in particular don't crash trying to dereference an uninitialized pointer if the script didn't return anything. Closes #12361.

2010-09-29 15:46 VZ, revision 65672

Preserve page size when changing increment in wxGTK wxSpinCtrlDouble. The page size was wrongly reset when changing the increment before. See #12342.

2010-09-29 15:46 VZ, revision 65671

Fix wrong return value of wxGTK wxSpinCtrlDouble::GetIncrement(). Due to confusion in gtk_spin_button_get_increments() parameters order the page size was returned instead of the increment. See #12342.

2010-09-29 15:46 VZ, revision 65670

Return wxFONTFAMILY_DEFAULT, not UNKNOWN, from wxFont::GetFamily(). Although returning wxFONTFAMILY_UNKNOWN when the font family is not recognized makes more sense, it breaks a lot of existing code including all the font-related code generated by DialogBlocks, so prefer to return wxFONTFAMILY_DEFAULT instead -- which can't be confused for a valid font family neither but can be passed to wxFont ctor or SetFamily() without problems. To ensure that this behaviour is correctly implemented by all ports, rename the existing wxFont::GetFamily() to DoGetFamily() and call the new method from wxFontBase::GetFamily() which adjusts the return value if needed. Closes #12330.

2010-09-29 15:45 VZ, revision 65669

Improve mouse handling code in wxAuiToolBar. Capture the mouse to handle mouse input on the buttons to ensure we always reset the button when the mouse leaves it. Closes #11784.

2010-09-29 15:45 VZ, revision 65668

Include wx/defs.h before testing for wxUSE_RADIOBOX. We need to include wx/defs.h that (indirectly) defines wxUSE_RADIOBOX before testing for it in wx/radiobox.h, otherwise the test may fail if the latter header is the first wx header included by the user code. This is similar to r65210 fix for wxUSE_CHECKLISTBOX. Closes #12526.

2010-09-28 20:59 JMS, revision 65666

Reset wxPGEditor singleton instance pointers in dtors. This is useful if wxPropertyGrid is being accessed from an external main loop.

2010-09-28 08:27 JS, revision 65661

Compile fix

2010-09-27 20:13 JS, revision 65660

Image dialog properties.

2010-09-27 14:55 VZ, revision 65659

Replace some stray _T()s with wxT(). We use wxT() exclusively now so replace some _T()s which crept in unnoticed. This also fixes compilation using Sun CC. See #12452.

2010-09-27 14:55 VZ, revision 65658

Fix wx/event.h compilation with Sun CC compiler. Move wxObjectEventFunctor::operator() definition after wxEvtHandler declaration as it uses call through a pointer to member of this class and Sun CC refuses to compile this without having the full class declaration. Closes #12452.

2010-09-27 14:48 VZ, revision 65657

Use wxString methods for UTF-8 conversions in wxX11 code. Use wxString::utf8_str() and FromUTF8() to convert to and from UTF-8. This is more efficient than using wxConvUTF8 as the code did before as it avoids the conversion entirely when wxString uses UTF-8 internally (as it does by default in wxX11) and also has the advantage of compiling in STL build unlike the old code. Closes #12518.

2010-09-27 14:48 VZ, revision 65656

Small clean up in wxX11 Pango code. Don't use unnecessary explicit casts of wxCharBuffer to "const char *". Use wxCharBuffer::length() instead of strlen().

2010-09-27 14:48 VZ, revision 65655

Fix wxX11 compilation when using PCH. wx/unix/utilsx11.h is not included by wx/wxprec.h so we need to include it when using PCH too. Closes #12517.

2010-09-27 13:57 VZ, revision 65654

Document wxSpinDoubleEvent class. Add documentation for the class itself and the associated EVT_SPINCTRLDOUBLE macro. Patch by Carsten Fuchs. Closes #12520.

2010-09-27 13:52 VZ, revision 65653

Close a modal dialog even when it doesn't have any buttons. The close button in the dialog title bar should work even if there are no buttons in the dialog itself (unlike the Escape key which works as an accelerator for a button), so close the dialog explicitly if the emulated button click wasn't processed in wxDialogBase::OnCloseWindow(). Closes #12513.

2010-09-27 13:51 VZ, revision 65652

Fix typo in wxStandardPathsBase::ResourceCat description and document it. Document the enum itself and also correct GetLocalizedResourcesDir() documentation which didn't specify the default value for the category parameter. Closes #12523.

2010-09-27 00:11 VZ, revision 65651

Compilation fix for MinGW STL build. std::tr1::unordeded_map<T *>::find() doesn't accept "const T *" pointer, at least with MinGW 4.4.0 standard library version, so add an explicit const_cast<> to fix compilation.

2010-09-27 00:11 VZ, revision 65650

Compilation fix for MinGW 4.x in new keyboard code. Explicitly choose the comparison operator to use when comparing wchar_t and int values, otherwise MinGW (correctly) complains about ambiguity between (int, int) and (wchar_t, const wxUniChar&) overloads.

2010-09-27 00:11 VZ, revision 65649

Make wxDateTime::Tm::yday public and document it. There doesn't seem any reason to allow access to all the other struct Tm fields but not yday so make it public, fill it in correctly when creating Tm without using its ctor from struct tm and document struct Tm itself including its yday field.

2010-09-27 00:11 VZ, revision 65648

Initialize wxDateTime::Tm::yday in the ctor. Set Tm::yday to a fixed value in the ctor as well instead of not initializing it at all. This bug actually didn't have any visible consequences as yday is currently a private member of struct tm and didn't seem to be used anywhere but it at least avoids MinGW 4.x warnings about possibly uninitialized variable and might become important in the future if we allow accessing this field.

2010-09-27 00:11 VZ, revision 65647

Correct g++ 4.x warnings about suggested explicit braces. Several warnings were generated for wxLogLastError() calls inside CALL_CARET_API macro by MinGW 4.4. Fix them by adding the extra braces. See also r61475.

2010-09-26 22:26 PMO, revision 65646

Added basic implementation for wxRadioBox and simplified choices handling for wxComboBox and wxChoice

2010-09-26 20:39 PMO, revision 65645

Added basic implementation for wxCheckBox

2010-09-26 18:38 PMO, revision 65644

Added implementation of wxWindow::DoFindFocus

2010-09-26 18:07 JS, revision 65643

General tidying of the floating image layout code Added CanEditProperties, EditProperties to make object editing more generic

2010-09-26 16:39 PMO, revision 65642

Added missing wxStaticLine::GetHandle() implementation

2010-09-26 16:33 PMO, revision 65641

Removed manual deletion of Qt widgets (wxQtPointer destructor is doing this now)

2010-09-26 14:00 PMO, revision 65640

Replaced QPointer usage with wxQtPointer

2010-09-25 16:15 JS, revision 65639

Fix

2010-09-24 19:44 JMS, revision 65631

Correct empty space drawing

2010-09-24 19:40 JMS, revision 65630

Removed debug log message

2010-09-24 17:22 JMS, revision 65629

Fixed PCH-less build

2010-09-24 16:47 JMS, revision 65628

Have wxPropertyGrid inherit from wxControl and wxScrollHelper instead of wxScrolledWindow. This is the approach other scrolled controls use.

2010-09-23 23:12 RD, revision 65627

Fix sending a size event for the displayed page when the notebook is sized

2010-09-23 23:11 RD, revision 65626

Use the wx version of the wxDECLARE_EVENT_TABLE_ENTRY macro

2010-09-23 23:10 RD, revision 65625

Avoid an endless recursion situation

2010-09-23 23:09 RD, revision 65624

Allow the renderer to also work with wxMemoryDCs

2010-09-23 23:08 RD, revision 65623

SetUserScale(1.0, 1.0) in Unmask() so the image will not be scaled again when blitted

2010-09-23 23:07 RD, revision 65622

CanSetTransparent needs to be virtual

2010-09-23 23:05 RD, revision 65621

Various build tweaks and updates for wxPython 2.9.1.1

2010-09-23 22:54 RD, revision 65620

Add flag to enable specifying an architecture to build on Mac. Also add x86_64 architecture to universal build when buildng wxOSX-Cocoa

2010-09-23 19:02 SJL, revision 65597

Remove an assert that was not backed up by the documentation and so failed on some platforms but not on others. Re-enable some tests that were disabled in wxGTK as they now pass.

2010-09-23 18:55 SJL, revision 65596

Add ClearEventCount to wxTestableFrame. This means we can clear an event count when an event counter goes out of scope so the are no spurious results in later tests.

2010-09-23 18:24 JS, revision 65595

Fix bug finding line after line break

2010-09-23 18:16 JS, revision 65594

Fix bug finding line after line break

2010-09-23 14:58 JMS, revision 65593

Streamline wxPropertyGrid tooltip code

2010-09-23 14:55 JMS, revision 65592

When setting empty string as a tooltip, call gtk_widget_set_has_tooltip() with FALSE to remove the tooltip. This will bring wxGTK behavior in line with wxMSW.

2010-09-22 21:24 SJL, revision 65591

Fix assert when changing the filter selection on a multiple selection wxGenericDirCtrl. Because ExpandPaths selects the item we can simply grab a list of selected paths and then expand them all in the multiple selection case. The single selection case is unchanged. Closes #12340

2010-09-22 15:31 VZ, revision 65590

Better checks for wxMSWKeyboard::VKToWX() return value. Don't generate key events without any valid key code (this shouldn't normally happen but might on exotic keyboards with keys that we don't know about). Also ensure that we can distinguish between VKToWX() returning dead keys and non-Latin-1 keys by setting wchar_t output parameter to WXK_NONE too in the former case but not the latter. Generate wxEVT_CHAR_HOOK events for non-Latin-1 keys too in Unicode build.

2010-09-22 15:31 VZ, revision 65589

Fix recently broken generation of wxEVT_CHAR_HOOK events in wxMSW. Changes to VKToWX() semantics broke the logic of the global keyboard hook function in wxMSW which didn't generate wxEVT_CHAR_HOOK events for ASCII special keys such as WXK_ESCAPE any more. Fix this and also generate wxEVT_CHAR_HOOK for all events, not just the non-ASCII keys for consistency with the documentation and wxGTK. Closes #12501.

2010-09-22 14:45 SJL, revision 65588

Re-enable disabled wxWindow label tests under wxGTK as they were fixed in r65374

2010-09-22 12:06 SJL, revision 65587

Send generic wxTreeCtrl wxEVT_COMMAND_TREE_KEY_DOWN events from OnKeyDown rather than OnChar. This change means it sends events for the same keys as the wxMSW control. It also fixes the failing unit test.

2010-09-22 10:48 SJL, revision 65586

Send generic wxListCtrl wxEVT_COMMAND_LIST_KEY_DOWN events from OnKeyDown rather than OnChar. Also remove the HasCurrent check. These changes bring the generic control into line with the control under wxMSW. Re-enable the previously failing unit test and document that the key down event might not have a valid item associated with it.

2010-09-21 21:54 PMO, revision 65583

Adding wxQtPointer to ease the memory management of Qt objects.

2010-09-21 14:57 VZ, revision 65582

Compilation fixes for old SDKs (VC6) after recent commit. Define WM_QUERYUISTATE in wx/msw/missing.h too as src/msw/statbox.cpp uses it now. Also move DT_HIDEPREFIX definition from wx/msw/private/button.h to missing.h as well as it's now used in statbox.cpp too. Include missing.h explicitly from the files that use DT_HIDEPREFIX.

2010-09-21 13:56 VZ, revision 65581

Compilation fix of wxSocket code for older Solaris versions. Include sys/filio.h to define FIONBIO in all cases (sometimes this header is already included from sys/ioctl.h but not always). Closes #12481.

2010-09-21 13:44 VZ, revision 65580

Correct drawing of mnemonics in wxStaticBox label under wxMSW. Only show the mnemonics if they need to be shown, i.e. use the same logic as the standard controls use, to avoid showing mnemonics in wxStaticBox with custom label colour even when other wxStaticBoxes don't show it.

2010-09-21 13:44 VZ, revision 65579

Fix wxStaticBox label redrawing when "Alt" is pressed in wxMSW. The default handling for Alt key press in the standard control is to redraw the label to account for showing of the keyboard queues (i.e. if the mnemonics were initially hidden, they are shown when Alt is pressed) but it doesn't redraw it in the correct colour resulting in any custom label colour being lost whenever Alt is pressed anywhere in the window containing the box. Fix this by forcing the box refresh which will result in repainting it using our code which does use the correct colour. Also update the static page of the widgets sample to allow changing the colours of all static controls on this page, including the wxStaticBox, and not just the main wxStaticText. Closes #12497.

2010-09-20 17:38 JMS, revision 65577

Call SetToolTip() for the property editor control when wxPG_EX_HELP_AS_TOOLTIPS style is used

2010-09-20 16:14 VZ, revision 65576

PCH-less compilation fix to GDI+ wxMSW code. Closes #12496.

2010-09-20 15:15 VZ, revision 65575

Correctly recognize when wglChoosePixelFormatARB() fails. This function returns TRUE even if it failed to find any matching formats, so test not only its return value but also the number of formats it found. Closes #12474.

2010-09-20 15:11 VZ, revision 65574

Always use native task dialog for wxProgressDialog under MSW if supported. Use task dialogs even for the dialogs with wxPD_AUTO_HIDE style flag and without wxPD_CAN_ABORT one. Generic fallback was used in this case as native task dialog doesn't support dialogs without buttons but it is finally better to create a dummy button and use the native dialog nevertheless. We already have a mostly disabled "Close" button for the dialogs without wxPD_AUTO_HIDE style so it seems logical to also have it (but just never enable it at all) when this style is used. Closes #12462.

2010-09-20 15:10 VZ, revision 65573

Ignore time component of SYSTEMTIME in wxMSW wxDatePickerCtrl. This is similar to the fix of r64208 for wxCalendarCtrl and ignores the time component of SYSTEMTIME objects returned by the native functions in wxDatePickerCtrl too to ensure that we operate with pure dates only. Closes #12493.

2010-09-20 14:52 VZ, revision 65572

Don't use native MSW functions in wxString::CmpNoCase(). While the native CompareString() is much more efficient than MSVC CRT version of _wcsicmp(), it gives unexpected results for non-letter characters, so don't use it but use the slow but correct wxStricmp() instead. At least don't use char-by-char comparison (in non-UTF-8 case) as it's the slowest possible implementation of this function, the new one using wxStricmp() is 3 times faster (by comparison, using CompareString() is 16 times faster still -- but wrong). Closes #10375.

2010-09-20 14:52 VZ, revision 65571

Add benchmarks for various ways to compare strings. Benchmark the abstraction overhead of wxString methods compared to plain functions and also benchmark native functions for string comparison under MSW.

2010-09-20 14:52 VZ, revision 65570

Flush output after every benchmark. This purely cosmetic change simply allows to see the output of the benchmarks sooner which is more user-friendly when running several long benchmarks.

2010-09-19 18:06 PMO, revision 65569

Minimal implementation for wxTreeCtrl, wxBitmapToggleButton, wxToggleButton, wxRadioBox, wxListCtrl

2010-09-19 12:02 SJL, revision 65568

Increase the number of expected events in TreeCtrlTestCase::KeyDown and ListBaseTestCase::KeyDown from four to six as this is the number of events seen when testing using their samples. This also stops the tests failing after the recent keyboard event improvements.

2010-09-18 18:26 VZ, revision 65565

Really fix setting fonts in RichEdit 4.1 controls. The fix applied in r64394 wasn't enough and the control could still decide to overwrite the font used by default when non-ASCII characters were inserted into it. To really force it to use the font we want we apparently must send it EM_SETCHARFORMAT with SCF_ALL flag (MSDN also documents SCF_DEFAULT but it's not clear if we should use it instead or together with SCF_ALL, for now it doesn't seem to be necessary).

2010-09-18 18:26 VZ, revision 65564

No changes, just refactor wxTextCtrl::SetStyle() in wxMSW. Split this overly long function into MSWSetCharFormat() and MSWSetParaFormat(). No real changes otherwise except for the use of PARAFORMAT instead of PARAFORMAT2 if wxUSE_RICHEDIT2 is not set as it was certainly intended (but the fact that nobody complained about this problem means that nobody must be compiling without wxUSE_RICHEDIT2 by now so arguably we should just remove it completely).

2010-09-18 18:26 VZ, revision 65563

Set wxTextCtrl::m_verRichEdit to 4 for RichEdit 4.1. Set m_verRichEdit to a different value for the version 4.1 of the control as it behaves subtly differently from the previous versions. Also clarify that value of 2 is used for both 2.0 and 3.0 versions of the control. No real changes yet.

2010-09-17 21:07 RR, revision 65562

Postpone EnsureVisible() to idle as this sometimes seems to be required, fixes #12480: wxDataViewCtrl::EnsureVisible does not make item visible in some circumstances on GTK

2010-09-17 13:17 DS, revision 65561

Set svn properties on .cpp files. Add missing svn:eol-style property to all .cpp files. Also set svn:keywords for .cpp files which don't have that property yet to Id, including src/osx/core/glgrab.cpp for consistency (it doesn't make use of the property).

2010-09-16 21:36 VZ, revision 65560

Allow setting Mac-specific menu item ids to wxID_NONE to suppress them. If s_macAboutMenuItemId or s_macPreferencesMenuItemId was explicitly set to wxID_NONE by the application, don't add them to the standard menu at all, otherwise they would be present there but be always disabled and useless. This is still not documented because we really need a better API for this but it at least provides a temporary workaround for having useless menu items under OS X.

2010-09-16 21:36 VZ, revision 65559

Allow use of report mode non-native wxListCtrl in wxListBook under Mac. The use of wxListBook in report mode was disabled for wxOSX in r54001 and r54318 (see #9484) because it created problems with the native wxListCtrl implementation but the report mode can be used if we're using the generic wxListCtrl version so do allow to use it if the system option governing the choice of the version to use is set to "generic". Of course, the real fix would be to correct the bugs in the native wxListCtrl version and use report mode always but for now this at least restores correct behaviour with the generic version.

2010-09-16 13:05 VZ, revision 65558

Only use wxFORCE_LINK_MODULE() in mediaplayer sample in static build. The linking optimization this macro protects against can't happen when using DLL and so using it is at best useless and actually harmful (because it doesn't contain the correct DLL export declarations) in the latter case.

2010-09-16 13:05 VZ, revision 65557

Compilation fixes for non-MSVC 9 compilers after r65555. Somehow MSVC 9 compiled invalid wxT(__FUNCTION__) expressions but both MinGW and MSVC 6 (correctly) failed. Don't use this construct at all but instead call wxLogLastError() with the real function name. Also refactor the code slightly to avoid having to repeat this fix thrice.

2010-09-16 11:05 VS, revision 65556

Fix wxMSW rendering artifacts with modal dialogs. When a modal dialog showed another modal dialog, parts of the parent window weren't refreshed correctly. This demonstrated itself as rendering artifacts when moving the child dialog to another position: parts of the dialog were shown as disabled, parts as enabled. Fixed by explicitly refreshing the window.

2010-09-16 01:04 VZ, revision 65555

Remove display information caching from MSW wxDisplay implementation. Don't cache display rectangle and client rectangle as they can both change during the program lifetime (especially the latter which changes whenever taskbar is moved or shown/hidden) and retrieving them every time they're needed doesn't seem to be a problem performance-wise anyhow. We still cache the list of all the monitors, ideally we'd refresh it when we receive a notification about a display being [dis]connected. Closes #4582.

2010-09-16 00:13 DS, revision 65554

Fix possible errors introduced while generating Xcode project. Under some unknown circumstances two added source files are concatenated into one faulty entry in an Xcode project (this probably occurs either at the Xcode or XMLTools2 level). Try to detect these errors in the Python script and fix them by patching up the project.pbxproj file.

2010-09-16 00:10 VZ, revision 65553

Document limitations of the generic wxTextEntry hints. Calling methods other than SetValue() or ChangeValue() doesn't update the display correctly currently, see #12475.

2010-09-16 00:10 VZ, revision 65552

Update the text hint display correctly when ChangeValue() is called. wxTextEntry::ChangeValue() doesn't generate any events so we need to explicitly update the text stored by wxTextEntryHintData when it is called to ensure that it corresponds to the real controls value.

2010-09-16 00:10 VZ, revision 65551

Fix several bugs in generic text entry hints implementation. The text controls contents and colour was not updated correctly in several situations (see #12475). The old code was completely wrong as it didn't store the actual value of the control at all and so could never work. Do store and update it now and show the hint if and only if the real contents is empty. Also handle "text updated" event to correctly update the hint when the control becomes [non-]empty. Closes #12475.

2010-09-16 00:10 VZ, revision 65550

Fix wxTextEntry::SelectAll() in presence of hints in wxGTK. Translation of wx (-1, -1) selection to (0, GetValue().length()) in wxTextCtrl::SetSelection() was unnecessary as it ended up calling the base class wxTextEntry::SetSelection() version which didn't need it. Moreover, this translation was actually harmful when the text control happened to show a hint string as its official value was empty in this case and so SetSelection(0, 0) was called which didn't do anything and broke clearing/changing the controls text when it was showing a hint. Simply don't translate the indices when using a single line control to fix this. See #12475.

2010-09-15 13:45 DS, revision 65549

Use a unique namespace for generating identifiers. Instead of using uuid.NAMESPACE_DNS as namespace use a newly generated UUID. Also minor cleanup of import uuid statement.

2010-09-15 13:29 DS, revision 65548

Make Xcode identifier consecutive when there is a collision. Making them consecutive groups source files that are repeated next to each other in the project file like Xcode does, instead of creating a complete new random identifier which resulted in creating a distance between the source files after they were sorted.

2010-09-14 20:35 VS, revision 65547

Click on wxOwnerDrawnComboBox's animating popup should close it. Previously, it behaved differently from native combo box: clicking the popup while its opening animation was running had no effect. This was different from the native control, which would close the popup in this case (just like when it's fully opened).

2010-09-14 19:35 PJC, revision 65544

Fix incorrect behaviour of wxRibbonGallery::EnsureVisible when the ribbon is vertical rather than horizontal.

2010-09-14 15:18 VZ, revision 65541

Fix drawing of items with custom background in wxGenericListCtrl. This was broken by the changes of r64879 which erroneously used wxRendererNative::DrawItemSelectionRect() even for the non-selected items. Now only use DrawItemSelectionRect() for the selected items to make them appear natively while drawing the non-selected items with custom background colour ourselves. Also refactor the code to avoid (the not quite and hence especially pernicious) duplication between wxListLineData::Draw() and DrawInReportMode(): rename SetAttributes() to ApplyAttributes() and draw the item background in this function now instead of doing it in both Draw() and DrawInReportMode().

2010-09-14 12:24 VZ, revision 65540

Fix hang on termination of wxProgressDialog with wxPD_AUTO_HIDE style. We don't need to run a modal event loop waiting for the wxProgressDialog to be closed when it has wxPD_AUTO_HIDE style because it does it on its own. Closes #12472.

2010-09-13 22:12 RR, revision 65539

Document wxDataViewListModel as common abstract base class for wxDataViewIndexListModel and wxDataViewVirtualListModel. Add wxDataViewListModel::GetCount() as both have it.

2010-09-13 22:02 RR, revision 65538

Further work on wxDataViewListModel::Reset()

2010-09-13 00:58 VZ, revision 65537

Update wxRibbonPanel documentation to mention use of sizers. This documents the changes of r65436. Closes #12418.

2010-09-13 00:58 VZ, revision 65536

Delete wxListCtrl item data after handling its deletion event in wxMSW. We deleted the data associated with the item too soon as we did it before the handler for the item deletion event was run and this handler could still access this data. Only free the data after the handler returns now. Closes #12449.

2010-09-13 00:58 VZ, revision 65535

Fix compilation of EnumerateLoadedModules() call for MinGW64 4.5. Our logic for detection of whether the first argument of PENUMLOADED_MODULES_CALLBACK is const or not didn't work for MinGW64 4.5. Replace it with a less error-prone (even if more ugly) version which simply casts the callback to the type expected by the function. Closes #12465.

2010-09-13 00:05 VZ, revision 65534

Define MAPVK_VK_TO_CHAR to fix wxMSW compilation with old SDK headers. At least MinGW headers don't define this constant.

2010-09-12 22:07 RR, revision 65533

Moved more code from wxDataViewCtrl to wxDataViewCtrlInternal. Add new special API for wxDataViewVirtualIndexModel::Reset() as wxDataViewModel::Clear is something different and needs a different, two step API under GTK+, one for destroying the current view and one for rereading the new contents. Added ::BeforeReset() and ::AfterReset() notifications for that purpose.

2010-09-12 18:16 JS, revision 65532

Fix for % symbols going missing from style parameter

2010-09-12 18:16 JS, revision 65531

Fix for % symbols going missing from style parameter

2010-09-11 13:20 VZ, revision 65528

Compilation fix for wxOSX. Remove stray closing brace. Also fix a warning about unused parameter.

2010-09-11 12:19 VZ, revision 65527

Generate the same flags for modifier key events in wxGTK as in wxMSW. Resolve the discrepancy between modifier flags of the key events corresponding to the modifier key itself between wxMSW and wxGTK by changing the latter to follow wxMSW behaviour. Clearly document the now officially correct behaviour of the modifiers for the key events corresponding to the modifiers keys themselves in the manual. This fix also makes it unnecessary to work around this bug in the keyboard unit test so remove it from there.

2010-09-11 12:19 VZ, revision 65526

Generate unshifted Unicode key codes in wxEVT_KEY_XXX events in wxGTK. wxGTK generated wxEVT_KEY_XXX with key codes corresponding to the unshifted state of the key (except for the letters) but Unicode key codes corresponding to the current shift state. This was inconsistent with wxMSW and also with the idea that key events, unlike char ones, don't depend on the modifiers states. Change wxGTK to behave as wxMSW and use unshifted values for Unicode key codes as well. Remove the now unnecessary workaround for different key event Unicode codes from test. Also try to explain the difference between normal and Unicode keys and key and char events even better and mention that the Unicode key codes for the key events are also untranslated in the documentation.

2010-09-11 12:19 VZ, revision 65525

Fix generation of key events for non-alphabetic keys under Windows. Don't hardcode the values of VK_OEM_XXX keys which are completely nonsensical on keyboards with non-US layouts. Use the real unshifted value of the key as its key code instead -- at least if it's a Latin-1 character. Otherwise, use WXK_NONE as the key code and pass the character generated by the key as Unicode character code. Also generate WXK_NONE events for dead keys to avoid confusing them with the corresponding normal key events.

2010-09-11 12:18 VZ, revision 65524

Improve printing out of pressed keys in the keyboard sample. Add missing elements of wxKeyCode enum ("Windows" and "Command" keys) to the GetVirtualKeyCodeName() function in the sample. Also output "unknown" and not blank for WXK_NONE.

2010-09-11 12:18 VZ, revision 65523

Rename wxCharCode{MSWToWX,WXToMSW}() and move them to a separate header. These functions were confusingly named as they work with MSW (virtual) key codes and not character codes, rename them to better indicate what they do. They also don't need to be in wx/msw/window.h included by all wx code when they are only really needed in a couple of files, so move them to a private header. No changes in behaviour.

2010-09-11 12:18 VZ, revision 65522

Fixes to key codes in keyboard events generated by wxMSW. Only set Unicode key code if the event corresponds to a character key and set it to (newly added) WXK_NONE for the other ones to avoid nonsensical values in it for e.g. "Home" key presses. Also set non-Unicode key to WXK_NONE for the characters that can't be represented in the current locale. This is consistent with wxGTK and avoids conflicts between special key values and Unicode keys. Clearly document the above behaviour. Notice that implementing the correct behaviour in wxMSW involved untangling previously interwoven WM_KEY{DOWN,UP} and WM_CHAR messages handlers. Clearly separate them now as they get different input (key codes for the former, characters for the latter) and especially don't try to convert from both kinds of input using a single wxCharCodeMSWToWX() function. As this function doesn't need to distinguish between keys and characters any more it can simply return the converted value in all cases instead of returning 0 sometimes to indicate a character value instead of a key. Simplify the code using this function accordingly.

2010-09-11 12:18 VZ, revision 65521

Add WXK_NONE symbolic constant indicating absence of a key. wxKeyEvent::GetKeyCode() and GetUnicodeKey() return 0 to indicate that the key code or Unicode character is not available, give symbolic name to this 0 to make the code using these methods more clear.

2010-09-11 12:18 VZ, revision 65520

No real changes, just use KF_EXTENDED instead of hard-coded bit mask. KF_EXTENDED is defined in Windows headers as the mask for extracting the "extended" bit from LPARAM of the keyboard messages. Use it instead of explicitly writing less clear "1 << 24".

2010-09-11 12:18 VZ, revision 65519

Add a simple test for keyboard events generation. Check that the events generated by wxUIActionSimulator result in the same wxKeyEvents being generated under all platforms. This is not the same as checking the event generation for the actual keys pressed by the user as there are some small differences between the two but better than nothing.

2010-09-11 12:18 VZ, revision 65518

Generate correct events for extended keys in wxMSW wxUIActionSimulator. Simulating keys such as WXK_END resulted in WXK_NUMPAD_END event being generated instead of the expected WXK_END one. Fix this by returning from wxCharCodeWXToMSW() whether the key code is a normal or extended one and use this to set KEYEVENTF_EXTENDEDKEY in wxUIActionSimulator::DoKey().

2010-09-11 12:18 VZ, revision 65517

Remember the last key event in wxGTK before passing it over to IM. Save the last key event before calling IM filter to be able to get the correct modifiers, timestamp, position &c to use for the CHAR event generated from IM commit callback. This restores the changes of r34504 which were reverted for unknown (or at least unmentioned) reason in r34521.

2010-09-11 12:18 VZ, revision 65516

Explicitly send events for modifier keys in wxUIActionSimulator. Key down/up events for the modifiers were already explicitly sent under wxMSW and wxOSX but not under wxGTK where, as the result, the corresponding events were not generated at all. Do send these events explicitly to make the events generation consistent under all platforms now. This means that wxUIActionSimulator::DoKey() now generates exactly one event everywhere. Notice that the modifiers for the key events generated by the modifier keys are also the same under all platforms now which is not the case for the events actually generated by the user (wxMSW sets the corresponding bit for the modifier key down event but not the key up one while wxGTK does exactly the contrary). This should be fixed in the future so that wxUIActionSimulator generates the same sequence of events as the user would and that it's still the same for all platforms.

2010-09-11 12:18 VZ, revision 65515

Remove assert checking for wxMOD_CONTROL from wxUIActionSimulator. It doesn't make sense to fail if modifiers parameter includes wxMOD_CONTROL telling the caller to use wxMOD_CMD instead as the latter is exactly the same as the former under non-Mac platforms.

2010-09-11 12:18 VZ, revision 65514

Add a convenient wxREGISTER_UNIT_TEST() macro. This macro can be used to easily register a test following a standard naming convention in both the global test suite and the test suite with the same name as this test instead of having to use 2 different cppunit macros to do the same thing.

2010-09-11 12:17 VZ, revision 65513

No real changes, just some small cleanup in wxMSW keyboard code. No changes, just use more clear variable name ("keycode" instead of "id") and anonymous namespace instead of static keyword.

2010-09-11 11:20 SC, revision 65512

fixing 'main screen'

2010-09-10 21:42 VZ, revision 65511

Use wxLocale::GetInfo() to get date format in wxDatePickerCtrlGeneric. Instead of trying (and failing) to manually decode the format used by "%x", simply use wxLocale::GetInfo(wxLOCALE_SHORT_DATE_FMT) and just change "%y" to "%Y" if necessary. The new code is more than 10 times shorter and also gives correct results unlike the old version.

2010-09-10 21:28 VZ, revision 65510

Don't add spurious NULs at the end of wxTextDataObject text under OS X. For some reason we added an extra NUL character to the data copied from wxTextDataObject but this doesn't seem necessary because the Pasteboard API is passed the correct data size and so the string doesn't need to be NUL-terminated. In fact, adding this NUL broke drag and drop between wx and native controls, including the case of dropping text in our own wxTextCtrl as this uses its built in support for dnd and not our code (the fact that we can't even set a drop target for a wxTextCtrl is a separate bug). In this case we got a string with an extra NUL in the control resulting in all sorts of hard to debug problems. So simply don't add the extra bytes, dnd works fine without them both between wx windows and from/to another OS X applications.

2010-09-10 19:26 VZ, revision 65509

Initialize wxGenericProgressDialog button members in Init() too. wxGenericProgressDialog::m_btn{Abort,Skip} were not initialized neither which resulted in crashes inside EnableAbort() which was called if the "Cancel" button was pressed in a native MSW dialog but the dialog wasn't cancelled (and hence the button needed to be reenabled).

2010-09-10 19:26 VZ, revision 65508

Fix closing logic in wxMSW native wxProgressDialog. The dialog must always close if the C++ object was destroyed, independently of whether it was cancelled or finished.

2010-09-10 19:26 VZ, revision 65507

Block in wxMSW wxProgressDialog::Update(max) until the dialog is dismissed. For consistency with the generic version and because it makes more sense than blocking in the dialog destructor (which is the only other alternative for the dialogs without wxPD_AUTO_HIDE to work), we should block in Update() when the maximal value is reached for dialogs without wxPD_AUTO_HIDE style until the dialog is dismissed. Document this behaviour even more clearly.

2010-09-10 19:25 VZ, revision 65506

Fix errors in handling of maximum field in wxGenericProgressDialog. Provide a SetMaximum() function for setting just m_maximum and return its value from GetRange() instead of using m_gauge->GetRange() which doesn't work when the native MSW version is used nor when the range is > USHRT_MAX under MSW in any case. More generally, this should fix a lot of bugs for progress dialogs using such range as the values were not interpreted correctly in many places.

2010-09-10 19:25 VZ, revision 65505

Rename wxGenericProgressDialog::ProgressDialogState to just State. Repeating "ProgressDialog" twice is redundant.

2010-09-10 19:25 VZ, revision 65504

No changes, just use less long progress dialog states names. We can refer to them using wxProgressDialog class name and not the base wxGenericProgressDialog so do this as it is shorter and more clear because these states have nothing to do with the generic version when used by the native MSW implementation.

2010-09-10 19:25 VZ, revision 65503

Use determinate mode in native wxMSW wxProgressDialog by default. The dialog was created in indeterminate ("marquee") mode for some reason.

2010-09-10 19:25 VZ, revision 65502

Add a possibility to show a progress dialog on dialog sample startup. Add a command line option to the dialogs sample to allow testing of different wxProgressDialog styles more easily. This also tests for showing them before the main event loop is started (see r65499).

2010-09-10 19:25 VZ, revision 65501

Don't use wxGenericProgressDialog::m_windowStyle for wxPD_XXX styles. Storing progress dialog styles in the normal window style didn't work because they clashed with the TLW styles. The original progress dialog implementation worked around this by using separate m_has{Abort,Skip}Button variables instead of relying on wxPD_CAN_{ABORT,SKIP} style bits but this didn't work for the other styles and was unclear so the new native MSW implementation blithely used m_windowStyle to test or them and other bits which didn't work at all, see #12416. Solve this by using a separate m_pdStyle variable for storing the progress dialog styles and use it for all wxPD_XXX tests in both the generic and MSW code. This fixes some bugs (although not all of them yet) and allows to get rid of m_has{Abort,Skip}Button.

2010-09-10 15:41 SC, revision 65500

adjusting to new gui mutex for osx, see #12411

2010-09-10 13:44 VZ, revision 65499

Create temporary wxEventLoop in wxGenericProgressDialog if needed. wxGenericProgressDialog needs to have an active event loop in order to repaint itself and process clicks on its buttons but it's more helpful to create a temporary event loop if there is no currently active one instead of just asserting. In particular, this allows to use wxProgressDialog from overridden wxApp::OnInit(). Add temporary event loop creation and remove the now unnecessary asserts verifying that there is an active event loop as there always will be one.

2010-09-10 13:44 VZ, revision 65498

Initialize wxGenericProgressDialog::m_winDisabler properly. This field wasn't initialized by Init() which might have been harmless considering the current code structure but still untidy, do set it to NULL there. Also move the forward declaration of wxWindowDisabler class in wx/generic/progdlgg.h to the top of the file for consistency with the other forward declarations.

2010-09-10 13:44 VZ, revision 65497

Don't return false from IsOk() for accelerators without flags. wxAcceleratorEntry::IsOk() checked for m_flags != 0 for some reason. Simply remove this test. See #12444.

2010-09-10 00:20 VZ, revision 65496

Fix infinite loop in wxDateTime::Format() when fields width was used. Just add a missing increment of the loop variable. See #12451.

2010-09-10 00:20 VZ, revision 65495

Fix cast of pointer to int in artprov sample. This prevented the sample from building when using MinGW-64 and also probably prevented it from working correctly on other 64-bit systems. Closes #12453.

2010-09-09 23:57 VZ, revision 65494

Initialize all fields of struct tm used by wxDateTime::Format(). Passing not fully initialized struct tm to strftime() results in Valgrind errors and possible nastiness, see #12455. Simply use memset() to set all fields of this system-dependent struct to 0 initially.

2010-09-09 23:49 VZ, revision 65493

Fix wxKill(wxSIGNONE) always returning true for child processes in wxMSW. The fact that a handle to a process can be opened doesn't mean that the process is still running. In fact, for a child process that we store a handle for ourselves we will always be able to open (another copy of the) handle even if it already terminated. Check for the process termination using WaitForSingleObject() instead in both normal and wxSIGNONE cases. Also simplify the code by not using GetExitCodeProcess() at all as we don't need the process exit code. Closes #2834.

2010-09-09 23:49 VZ, revision 65492

Remember last values used in exec sample "Kill" menu item dialogs. Remember the PID entered in the dialog and also remember the last used signal number. This makes these dialogs slightly less painful to use when testing even though ideally we'd have a single dialog for choosing both values instead of two consecutive modal dialogs.

2010-09-09 23:49 VZ, revision 65491

Very minor fixes to wxKill() documentation. Fix "the the" typo.

2010-09-09 23:48 VZ, revision 65490

Use minimal required process access mask in wxMSW wxKill(). We don't need PROCESS_TERMINATE permission if we are not going to call TerminateProcess() for it.

2010-09-09 22:59 VZ, revision 65489

Don't filter out Cairo libraries from GTK libraries list in configure. This undoes the hack of r35357 which surreptitiously removed all Cairo libraries from the GTK libraries list. This shouldn't be necessary any more as we use Cairo calls in our own code and so can't run without it anyhow and in fact is even actively harmful as it results in linking errors under Fedora 13 (which seems to use a slightly different linker?).

2010-09-09 22:53 VZ, revision 65488

Use the same logic for closing dialogs as for handling Escape key. Pressing "Esc" key closed the dialog with only wxID_OK button (but no wxID_CANCEL one) by default but pressing the "close window" button only closed it if wxID_CANCEL was present. Fix this by using the same code in OnCloseWindow() as in OnCharHook(), after extracting it into the new SendCloseButtonClickEvent() method.

2010-09-09 22:34 VZ, revision 65487
  • D /wxWidgets/trunk/src/msw/mediactrl.cpp

Remove the unused "monolithic" MSW wxMediaCtrl file. The contents of this file was split over src/msw/mediactrl_{am,qt,wmp10}.cpp a long time ago and this file is unused and not compiled into the library so having it in the repository is useless and confusing -- remove it.

2010-09-09 22:33 VZ, revision 65486

No real changes, just don't use obsolete FORCE_LINK_ME in wxMediaCtrl. Use wxFORCE_LINK_THIS_MODULE() instead of the obsolete FORCE_LINK_ME.

2010-09-09 22:33 VZ, revision 65485

Force linking of all wxMSW wxMediaCtrl backends in mediactrl sample. Force the linker to include all the backends in the sample executable instead of discarding them because they are not used directly to allow testing all of them in the sample.

2010-09-09 22:33 VZ, revision 65484

No changes, just remove cruft from mediactrl sample. Remove the test for wxUSE_GUI together with the comment questioning its presence.

2010-09-09 22:33 VZ, revision 65483

Remove debugging wxLogMessage from wxMediaCtrl::Create(). This was added apparently by mistake in r45478 and resulted in showing the backend being used by the control in a message box whenever it was created ever since.

2010-09-09 12:18 VZ, revision 65482

Don't exclude "contrib" from wxMSW setup.exe generation. This was presumably needed to exclude the top level contrib directory but also seems to apply to src/tiff/contrib and excluding this directory breaks configuration of libtiff as it looks for src/tiff/contrib/Makefile.in. As we don't even have top level contrib any more, simply don't exclude it any longer.

2010-09-09 10:57 DS, revision 65481

use svn:keywords instead of eol:keywords

2010-09-08 22:01 RR, revision 65480

Unregister configure callback, fixes #12447: wxGTK patch: Segfault on Drag&Drop

2010-09-08 22:00 RR, revision 65479

Unregister configure callback,part of #12447: wxGTK patch: Segfault on Drag&Drop

2010-09-08 19:11 DS, revision 65478

Make Xcode identifiers in generated project files be the same after each run. From the AppleScript that composes the Xcode projects call a Python script that bases the identifiers on an associated name instead of being random each run like Xcode does. After the Python script reopen the project again in Xcode to have the identifiers sorted (Xcode wants them to be), resulting in the project.pbxproj file being completely different inside but in the IDE the order of files still will be the same.

2010-09-07 23:37 VZ, revision 65477

Use correct Unicode define for wxScintilla compilation. Compilation of wxScintilla with Borland failed because -D_UNICODE was not passed on command line resulting in mismatches between wxChar and Windows TCHAR. It's a mystery why this didn't happen with the other compilers but defining _UNICODE for them too can't hurt.

2010-09-07 18:05 SC, revision 65475

resetting the wrapper flag later, otherwise the native destructors dealloc too much, fixes #12448

2010-09-07 08:51 SC, revision 65474

modeling subclassing along msw, unsubclassing filedialog at end of ShowModal, fixes #12236

2010-09-06 15:50 SC, revision 65473

using non-sleep version for GUI mutex, solves #12411

2010-09-05 15:31 SJL, revision 65472

Simplify ButtonTestCase::Bitmap. The old test was not correct as it tested all bitmaps to see if they were valid, however these do not get set by SetBitmap and so the tests only passed if the platform set valid defaults.

2010-09-05 15:14 SJL, revision 65471

Fix typo from previous commit.

2010-09-05 15:11 SJL, revision 65470

Move the second wxListBox sort test back to the ownerdrawn section and re-enable it under wxGTK.

2010-09-05 14:47 SJL, revision 65469

Wrap BitmapToggleButtonTestCase in a preprocessor check so compilation shouldn't fail on platforms that don't support it.

2010-09-04 15:33 VZ, revision 65468

Remove unused wxProgressDialogTaskRunner::m_parent field. This seems to be a left over from old version of the code and is not used any longer. See #12414.

2010-09-04 15:33 VZ, revision 65467

Fix crash in wxMSW wxProgressDialog without wxPD_APP_MODAL style. Use the correct method to retrieve the parent window to disable and check that this pointer is not NULL before dereferencing it. Closes #12414.

2010-09-04 15:33 VZ, revision 65466

Improve main and extended messages handling in new wxMSW wxMessageDialog. Don't use the main message if there is no extended message: this looks bad as the main message is emphasized to contrast with the extended one which doesn't make sense visually if there is no extended message. Also recognize the common use of wxMessageBox() with a multiline text composed of the first string that plays the role of the main message with the rest being the extended one and handle this appropriately automatically. This results in a better appearance by default for a lot of message boxes, including even the one in our own minimal sample.

2010-09-04 11:36 VZ, revision 65465

Add a link to Microsoft guidelines from wxICON_QUESTION documentation. Microsoft documentation provides explanations as to how the icons should be used in the message dialogs which can be useful for people wondering which icon style to use an when. See #12417.

2010-09-04 00:48 VZ, revision 65464

Don't link with long obsolete ctl3d32 library when using MinGW. ctl3d32 was used for Win16 development and is not used by wxMSW since many years, don't link with it unnecessarily when using MinGW. Also remove a FIXME comment about an issue which doesn't seem to need any fixing.

2010-09-03 21:33 VS, revision 65463

Fix wxOwnerDrawnComboBox keyboard navigation with duplicate items. If the combobox contained duplicate strings (i.e. multiple items with the same string value, but differing indexes), then navigating to the second and subsequent ones skipped to the first occurence instead. We need to preserve the index.

2010-09-03 21:33 VS, revision 65462

Fixed wxscintilla compilation for wxDFB.

2010-09-01 17:25 SJL, revision 65457

Fix compilation under MinGW, also add missing SVN properties.

2010-09-01 16:48 JS, revision 65456

wxRichTextCtrl::ApplyStyle now applies a paragraph style at the cursor without needing a selection, and setting the default style now avoids duplicating character attributes in subsequently typed text when they exist in the paragraph style.

2010-09-01 16:48 JS, revision 65455

wxRichTextCtrl::ApplyStyle now applies a paragraph style at the cursor without needing a selection, and setting the default style now avoids duplicating character attributes in subsequently typed text when they exist in the paragraph style.

2010-09-01 15:28 VS, revision 65454

Reduce flicker when removing wxNotebook page. wxMSW implementation hides all pages except the selected one. But when removing selected page from the control, this invariant is temporarily broken and this results in visible flicker. Hiding the page as soon as it gets removed fixes it.

2010-09-01 11:48 VZ, revision 65453

Update wx_dll.dsw to include the ribbon library. Add wx_ribbon project with dependency on core library.

2010-08-31 21:04 JS, revision 65452

Forgotten commits - image loading and XML speedups

2010-08-31 00:18 VZ, revision 65451

Add wxGrid::RefreshAttr() method to force attribute refresh. A cached attribute may continue to be used even though the attribute returned by a custom wxGridCellAttrProvider has changed so add a method to force wxGrid to update the attribute by forgetting the cached copy. Closes #12406.

2010-08-30 23:48 VZ, revision 65450

Don't center wxGenericMessageDialog elements. Centering doesn't seem to be appropriate on neither of the major platforms and makes wxGenericMessageDialog and wxGenericRichMessageDialog which uses it look even less native than otherwise. Simply don't do it neither for the text nor, especially, for the buttons where wxStdDialogButtonSizer already exists to take care of their alignment.

2010-08-30 23:48 VZ, revision 65449

Allow using custom labels for wxGenericMessageDialog buttons. Custom labels set for wxGenericMessageDialog buttons were simply ignored as it used CreateSeparatedButtonSizer() to create the actual buttons which in turn always used the standard labels. Fix this by explicitly creating the buttons with custom labels if necessary. This also fixes custom label support in wxGenericRichMessageDialog deriving from this class.

2010-08-30 23:48 VZ, revision 65448

Extract CreateSeparatedSizer() from wxDialog::CreateSeparatedButtonSizer(). Extract the code adding a separating wxStaticLine to the sizer in its own function to be able to reuse it in upcoming commits.

2010-08-30 23:48 VZ, revision 65447

Fix button order in wxStdDialogButtonSizer in all cases under GTK. The order of Yes/No/Cancel was recently fixed by the changes in r65346 but it broke the order of the buttons in Ok/Cancel case. Ensure the correct order is used in all cases now: the one described by GNOME HIG by default but different order for the special case of Yes/No/Cancel which follows the native message box.

2010-08-30 23:48 VZ, revision 65446

Rewrite GTK section of wxStdDialogButtonSizer using wxSizerFlags. Using wxSizerFlags makes the code shorter and more understandable but otherwise there are no real changes in behaviour except for a minor fix to one of the border which was wrong before.

2010-08-30 13:30 JS, revision 65445

Documented recent wxRTC fixes.

2010-08-30 13:27 JS, revision 65444

Fixed wrong line spacing calculation

2010-08-30 13:27 JS, revision 65443

Fixed wrong line spacing calculation

2010-08-30 10:47 JS, revision 65442

Don't add space before para twice in paragraph layout Discard attributes from empty text object when merging

2010-08-30 10:47 JS, revision 65441

Don't add space before para twice in paragraph layout Discard attributes from empty text object when merging

2010-08-29 18:53 PMO, revision 65439

Replaced copy&paste code to create the underlying qt widget with a template function

2010-08-29 17:18 PMO, revision 65438

Update to trunk r65433

2010-08-29 14:24 RR, revision 65437

include wx/sizer.h as buildbot complained

2010-08-29 11:42 RR, revision 65436

Add possibility to use sizers in ribbon panel, fixes #12404: wxRibbonPanel and wxSizer

2010-08-28 19:05 VS, revision 65435

Scale sizes more accurately in generic SetWindowVariant().

2010-08-28 13:29 PMO, revision 65434

Update to trunk r65433

2010-08-26 15:51 JMS, revision 65424

Changed wxArrayStringProperty default delimiter to comma. It should allow for better looking and more easily editable property values for common cases.

2010-08-26 15:25 JMS, revision 65423

Added missing wx/defs.h includes in propgrid headers

2010-08-26 08:53 JJ, revision 65422

correcting wxX11 for wxkeysym as was done for wxMOTIF

2010-08-25 17:02 VS, revision 65406

Fix wxListBox selection handling broken by r64500. r64500 introduced tracking of previous selection in wxMSW's wxListBox so that an event isn't sent when the user clicks already selected item again. Unfortunately, it forgot to account for programatic changes of selection (e.g. when all items are removed, so is the selection) and didn't update selection book-keeping information in that case. The result was that the event wasn't sent when it should be in some cases. Fixed by using UpdateOldSelections() even in single-selection case in wxMSW.

2010-08-24 19:22 RR, revision 65400

Reenable sorting tests for GTK

2010-08-24 19:06 RR, revision 65399

Make sorting of wxListBox, wxChoice and wxComboBox identical to the MSW sorting

2010-08-24 13:36 VZ, revision 65398

Remove unused wxDisplay implementation using DirectDraw from wxMSW. Remove commented out version of DirectDraw-based wxDisplayFactory implementation. It doesn't seem to have any advantages compared to the currently used version and nobody uses it anyhow. Closes #12387.

2010-08-24 13:23 JJ, revision 65397

wxKeysym problem for wxMOTIF fixed

2010-08-24 00:04 JTN, revision 65395

Clean up bakefile: Use platform specific evtloop, timer... Also, create a QCoreApplication before a QEventLoop if the former doesn't already exists (required by Qt)

2010-08-23 20:54 VZ, revision 65393

Compilation fix: forward declare wxTextEntry in unit tests code. This should fix tests compilation on the build bot Mac OS X slaves.

2010-08-23 09:50 JJ, revision 65392

Update openVMS compile support

2010-08-23 01:46 VZ, revision 65390

Use "C" locale for locale-dependent part of TextCtrlTestCase. As we expect to get decimal points in the text control when we stream floating point numbers into it, we must do it in a locale which uses decimal point, e.g. "C" one. Otherwise the test failed when ran in e.g. French locale.

2010-08-23 01:45 VZ, revision 65389

Document that wxFD_FILE_MUST_EXIST is implied under OS X. Mention in the documentation that the standard file open dialog under OS X can't be used to select a non-existing file.

2010-08-23 01:45 VZ, revision 65388

Remove unused src/osx/cocoa/bmpbuttn.mm file. This file was empty and unused any more so simply remove it and all references to it in the makefiles. This avoids warnings about empty object files in static builds of the library.

2010-08-23 00:58 VZ, revision 65387

Don't use uninitialized variable in wxCharCodeWXToOSX(). If an unsupported wxKeyCode was passed to this function, an undefined value was returned. Return -1 instead to indicate failure.

2010-08-23 00:16 VZ, revision 65386

Merge the new GUI tests from SOC2010_GUI_TEST branch. Add a lot of tests for many wx GUI classes. Add tests using the new wxUIActionSimulator class but disable them under OS X as too many of them currently fail there. Refactor the test suite to make organizing the existing tests and adding the new ones easier. Improve documentation using the information gathered while testing the classes. Also update the documentation of the testing system itself.

2010-08-23 00:15 VZ, revision 65385

Merge wxUIActionSimulator fixes from SOC2010_GUI_TEST branch. Correct a lot of problems with the initial implementation, notably make the API consistent across all platforms, e.g. all keyboard-related methods now take just a wxKeyCode. Add some useful higher-level helpers such as Text() and MouseDragDrop(). Improve documentation. wxUIActionSimulator now works under MSW, GTK and OS X and is enabled by default.

2010-08-23 00:15 VZ, revision 65384

Fix selection corner cases in wxOSX wxComboBox. Don't crash in wxComboBox::GetString() if it's passed an invalid index. Don't call GetString() with invalid index from GetStringSelection() if there is no selection. Do accept wxNOT_FOUND in SetSelectedItem() as it means, according to the docs, that the existing selection should be reset.

2010-08-23 00:15 VZ, revision 65383

Don't crash in wxOSX::wxClipboard::Clear() if initialization failed. Creating the clipboard may fail (e.g. when running from a ssh session to an OS X machine), don't crash by passing NULL pointer to PasteboardClear() if this happens but assert and return instead.

2010-08-23 00:15 VZ, revision 65382

Work around a crash on starting editing in wxGrid under wxOSX/Cocoa. wxOSX/Cocoa currently generates unexpected focus loss events with the window gaining focus being the same one as losing it. This is wrong and shouldn't happen but as long as it does, filter these events out to at least allow editing the grid to work. See #12267.

2010-08-23 00:15 VZ, revision 65381

Don't send event from wxMSW::wxListCtrl::DeleteAllItems() if it did nothing. wxEVT_COMMAND_LIST_DELETE_ALL_ITEMS should only be sent if the control hadn't been empty before. Document this behaviour and adjust wxMSW to match the other platforms. Also document the return value better. Closes #12336.

2010-08-23 00:15 VZ, revision 65380

Extract X11 Display wrapper class in a private header. No real changes, just extract a private Dpy class used by wxGTK to a header and rename it to wxX11Display. This will allow reusing it from X11 wxUIActionSimulator implementation in the upcoming commits.

2010-08-23 00:15 VZ, revision 65379

Add missing header required if wx/mousestate.h is included first. This header uses wxPoint so it must include wx/gdicmn.h (instead of relying on it having been already included).

2010-08-22 01:33 VZ, revision 65378

Don't report spurious errors from wxSocket in "no wait" mode. In wxSOCKET_NOWAIT mode wxSOCKET_WOULDBLOCK is not a real error as it's expected and should be just discarded. Failing to do this could result in the following scenario: 1. Try to read a big buffer with wxSOCKET_NOWAIT (setting wxSocket error to wxSOCKET_WOULDBLOCK). 2. Process small part of it. 3. Read more data from wxSocket -- which now goes to the data containing already cached data without going to the socket itself and this without resetting the error. 4. Check wxSocket::Error() which turns out to be (still) true. And this was exactly what happened in mysteriously failing unit test case reading wxImage contents from a socket: the failure was difficult to reproduce because it depended on how much data exactly did we read from the socket in one go. Fix this by resetting the error properly and reenable the unit test which was previously disabled for the build bot, it should pass now.

2010-08-21 19:06 VZ, revision 65376

Merge with the trunk and some minor fixes. This is the version of this branch which should be easier to merge into the trunk in the future as it's based on a more recent r65375. It also contains some minor changes by me to Julien's work and style fixes.

2010-08-21 12:17 RR, revision 65375

Allow calling wxGenericDirCtrl::GetPath() in multiple selection mode, fixes #12340 ([wxGenericDirCtrl] conflicts wxDirFilterListCtrl::OnSelFilter())

2010-08-21 11:54 RR, revision 65374

make Set/GetLabel() set and return something (albeit unused) as per the docs, fixes #12350: wxWindow Get/SetLabel non-functional in GTK

2010-08-21 11:53 RR, revision 65373

make Set/GetLabel() set and return title in wxTLW, fixes #12371: Dialog::GetLabel() Inconsistent behaviour across operating systems

2010-08-21 11:39 RR, revision 65372

Fix crash by checking if icon is valid before drawing it, fixes #12376: PATCH for Ribbon crash

2010-08-21 11:36 RR, revision 65371

Fix potential crash, fixes #12375: PATCH to fix help controller crash

2010-08-20 22:51 RR, revision 65370

Properly implement Cleared() by calling row_deleted on every child of root, fixes #12327: wxDataViewListCtrl Crash

2010-08-20 20:13 VZ, revision 65369

Mention that not all standard IDs are stock IDs. Also add a link to the list of stock IDs from the standard IDs documentation.

2010-08-20 17:38 JJ, revision 65368

include correct private.h for wxgtk1

2010-08-20 17:22 RR, revision 65367

Make it compile

2010-08-19 20:29 RR, revision 65366

Link to wxRichMessageDialog in some places

2010-08-19 20:17 RR, revision 65365

Make it compile a bit more

2010-08-19 17:41 VZ, revision 65364

Slightly improve wx[Generic]RichMessageDialog layout. Keep the icon at the top instead of centering it, this is more consistent with the native behaviour under both MSW and GTK. Get rid of an unnecessary sizer in wxGenericRichMessageDialog and give the checkbox the right border to align with the rest of the dialog contents.

2010-08-19 17:41 VZ, revision 65363

Make the main message of wxGenericMessageDialog stand out. Use larger bold font for the main message in wxGenericMessageDialog if the extended message is also given to make it stand out similarly to how it happens in the native GTK and MSW dialogs.

2010-08-19 14:12 JS, revision 65362

Better close button placement on tabs, especially for bottom tab alignment

2010-08-19 14:12 JS, revision 65361

Better close button placement on tabs, especially for bottom tab alignment

2010-08-19 11:53 SJL, revision 65360

Disable some more failing tests under wxGTK

2010-08-19 09:14 SC, revision 65359

fixing compilos

2010-08-19 09:13 JJ, revision 65358

update compile configuration for OpenVMS

2010-08-19 02:06 VZ, revision 65357

Compilation fix for STL build in wxGtkCollatableString code. Include wx/string.h to define wxString used by this class.

2010-08-19 02:06 VZ, revision 65356

Compilation fix for non-PCH build in wxGenericRichMessageDialog code. Move IsCheckBoxChecked() to the .cpp file where wxCheckBox is fully defined and not just forward declared (at least when not using PCH).

2010-08-19 01:57 VZ, revision 65355

Compilation fix for old SDKs in new native MSW wxHyperLinkCtrl code. Define WC_LINK ourselves if it's not defined in the headers.

2010-08-19 01:55 VZ, revision 65354

VC6 compilation fix for native wxProgressDialog implementation. Don't use return with a void value, VC6 doesn't support this and it's unnecessary here anyhow.

2010-08-19 00:49 VZ, revision 65352

Use task dialog for wxProgressDialog implementation in wxMSW. If available, the task dialog is now used for the wxProgressDialog under Windows. This provides a much more native looking dialog which doesn't look out of place under modern Windows versions, unlike the generic implementation. The internals of the code had to be significantly changed as the task dialog can only be shown modally so, to emulate wxProgressDialog modeless nature, a separate thread is used for the progress dialog management.

2010-08-19 00:48 VZ, revision 65351

Only use native wxHyperlinkCtrl in Unicode build under MSW. The native control is available to Unicode applications only so disable its use in non-Unicode build.

2010-08-19 00:48 VZ, revision 65350

Don't use native MSW wxCommandLinkButton in wxUniversal. Test for __WXUNIVERSAL__ when selecting the version of this class to use.

2010-08-19 00:48 VZ, revision 65349

Add wxRichMessageDialog class. This is a generalization of wxMessageDialog based on the native task dialog under recent (Vista and later) Windows versions and implemented generically for the other ports for now. It provides the possibility to use additional controls in the message boxes (checkbox useful for the "Don't ask me again" kind of dialogs and collapsible detailed explanations field) and better look and feel under Windows.

2010-08-19 00:48 VZ, revision 65348

Provide a task-dialog based wxMSW wxMessageDialog implementation. Use the task dialog instead of the legacy message box for wxMessageDialog implementation under wxMSW on recent (Vista and later) Windows versions. As part of this change, remove wxMessageDialogWithCustomLabels and integrate its functionality in wxMessageDialogBase itself as it's now used by all platforms.

2010-08-19 00:48 VZ, revision 65347

Handle mnemonics correctly in wxGTK::wxCollapsiblePaneSetLabel(). Convert mnemonics in wx format to the one used by GTK+, just as we already do in the ctor.

2010-08-19 00:48 VZ, revision 65346

Fix Yes/No/Cancel buttons order in wxGTK wxStdDialogButtonSizer. "Yes" and "No" buttons should be positioned next to each other for consistency with the native message box instead of separating them with the "Cancel" button.

2010-08-18 23:40 RR, revision 65345

Document recetnyl added name parameter in wxDataViewCtrl

2010-08-18 23:36 RR, revision 65344

Mention that you cannot call wxRadioButton::SetValue(false) if that radiobutton belongs to a group

2010-08-18 23:32 RR, revision 65343

GTK+ just won't let you uncheck any radiobutton that belongs to a group.

2010-08-18 23:29 RR, revision 65342

make wxChoice and wxComboBox sort in a case insensitive and locale adapted way, fixes #12351: Incorrect sort order in wxChoice / wxComboBox

2010-08-18 23:28 RR, revision 65341

Make wxListBox sort in a case insensitive way, fixes #12352: Incorrect sort order in wxListBox

2010-08-18 21:44 SJL, revision 65340

Enable wxUIActionSimulator by default

2010-08-18 20:34 SJL, revision 65339

Disable tests that fail under wxOSX so that they play nicely with the buildbot.

2010-08-18 18:46 SJL, revision 65338

Disable tests that fail under wxGTK so that they play nicely with the buildbot.

2010-08-18 15:57 MYA, revision 65337

Add a readme file of the implmentation detail

2010-08-18 14:59 JS, revision 65336

Use common inline version of wxHexToDec

2010-08-18 14:50 MYA, revision 65335

'Image para moving' feature works well now

2010-08-17 18:55 VZ, revision 65334

Provide native wxHyperlinkCtrl implementation for wxMSW. Use the "syslink" native control to implement wxHyperlinkCtrl under (recent enough, i.e. XP or later) versions of Windows.

2010-08-17 18:12 VZ, revision 65333

Compilation fix: include wx/button.h from wx/commandlinkbutton.h. Include the base class declaration to fix compilation under non-MSW.

2010-08-17 17:24 RAW, revision 65332

Parent window of MSW wxProgressDialog gains focus when the dialog ends.

2010-08-17 17:22 RAW, revision 65331

Updated documentation for wxMessageDialog.

2010-08-17 17:21 RAW, revision 65330

Finalized handling of right-alignment for MSW wxHyperlinkCtrl and updated the documentation.

2010-08-17 17:13 MYA, revision 65329

Move feature works mostly

2010-08-17 17:13 VZ, revision 65328

Export wxMSWButton::GetFittingSize() private function. It is now used by wxCommandLinkButton from adv library and so needs to be exported from core.

2010-08-17 16:48 VZ, revision 65327

Add new wxCommandLinkButton class. A command link button wraps a native MSW control under recent Windows versions and is implemented generically as a simple bitmap button elsewhere. In the future, GTK implementation should allow using a different font for the button label and its note.

2010-08-17 12:10 JS, revision 65326

Large image-loading speedup and small attribute-loading speedup

2010-08-17 08:21 SC, revision 65325

fixes horizontal scrolling in textfields, fixes #12322

2010-08-16 19:48 RR, revision 65324

Ignore non-existant string selection in wxComboBox::SetValue() in read-only mode, as per the very exact docs, fixes #12329: wxComboBox can set non-existing string in read only mode

2010-08-16 17:33 RR, revision 65323

Uncheck radiobutton when calling ::SetValue(false) as per wxMSW, fixes #12344: Cannot set GTK wxRadioButton to fasle

2010-08-16 17:01 MYA, revision 65321

Some fast fixup

2010-08-16 16:50 SJL, revision 65320

Add an extra paragraph to the unit testing tech-note about the classes that are available to help with GUI testing.

2010-08-16 16:28 MYA, revision 65319

Paragraph move feature

2010-08-16 12:45 RAW, revision 65318

Fixed crash when invoking a dynamically loaded TaskDialogIndirect().

2010-08-15 23:49 JWE, revision 65317

add svn:eol

2010-08-15 23:14 VZ, revision 65316

Improve EVT_SHOW documentation. Mention that it applies to the TLWs only and explain when it is generated (and not generated). Closes #12353.

2010-08-15 23:14 VZ, revision 65315

Fix wxMSW compilation in wxUSE_STL==1 case. A wxDECLARE_NO_ASSIGN_CLASS() was recently added to ClassRegInfo but storing it in a vector requires it to be "Assignable" so this broke compilation in STL case (wxVector<> doesn't enforce this requirement currently). Make ClassRegInfo assignable again to fix this. Closes #12355.

2010-08-15 23:14 VZ, revision 65314

Revert "Make wxComboBox::Popup() and ::Dismiss() emit events" This reverts commit r65310 which was not, in fact, necessary as the events were already sent. See #12335.

2010-08-15 21:31 JWE, revision 65313

correct WXK_BACK error

2010-08-15 20:32 JWE, revision 65312

resolved Visual c++ assert.

2010-08-15 19:53 JWE, revision 65311

correct focus feature under windows

2010-08-15 18:16 RR, revision 65310

Make wxComboBox::Popup() and ::Dismiss() emit events as per the docs, fixes (wxComboBox not sending popup and dismiss events)

2010-08-15 18:02 JWE, revision 65309

correct a error in default constructor

2010-08-15 17:45 JWE, revision 65308

add doc for change key features

2010-08-15 15:23 SJL, revision 65306

Set right button click value to 2. This fixes the tests that simulate right click events in wxGTK.

2010-08-15 15:11 SJL, revision 65305

Add extra wxYield calls to allow many more tests to run correctly in wxGTK. This needs to be done after every action rather than after batches of operations.

2010-08-15 14:29 RAW, revision 65304

GTK wxCollapsiblePane correctly handles mnemonics in SetLabel().

2010-08-15 12:59 RAW, revision 65303

Fixed bug with setting message dialog button labels for the dialog sample.

2010-08-15 10:34 RAW, revision 65302

Removed a black border from the MSW commandlink button image.

2010-08-15 06:38 RAW, revision 65301

Set eol-style property on new files.

2010-08-14 17:11 RAW, revision 65300

wxHyperlinkCtrl calculates size correctly under Win XP and can be right-aligned under Vista and greater.

2010-08-14 12:24 RAW, revision 65299

Calls to TaskDialogIndirect() are now done dynamically by retrieving the symbol from relevant DLL.

2010-08-13 22:12 JMS, revision 65297

Allow wxVariant::Convert(wxUniChar* value) to convert single-character string into a character.

2010-08-13 17:17 SJL, revision 65295

Only run BitmapComboBoxTestCase when it is natively supported.

2010-08-13 13:57 VZ, revision 65292

Fix harmless MSVC warning about double to float conversion. Make the constant double as well as it's compared with other doubles in the code below.

2010-08-13 13:04 SJL, revision 65291

Remove some assumptions in WindowTestCase that are not necessarily true.

2010-08-13 13:02 SJL, revision 65290

Remove assumption that no item is focussed by default in wxTreeCtrl.

2010-08-13 13:00 SJL, revision 65289

Stop wxRadioButton::SetValue(false) test under GTK as this is not supported.

2010-08-13 12:57 SJL, revision 65288

Set a sensible initial size for the wxListBook.

2010-08-13 12:55 SJL, revision 65287

Do not test values outside the range as the behaviour is unspecified. Also make sure a small enough indent is set.

2010-08-13 12:51 SJL, revision 65286

Test that no events are sent when an empty wxListControl is cleared.

2010-08-13 11:55 VZ, revision 65285

Update wxWinCE compilation instructions. Remove obsolete information about eVC. Give the example of using bakefile to generate VC[89] CE projects directly.

2010-08-13 11:36 JWE, revision 65284

add change choice key feature

2010-08-13 06:23 SC, revision 65283

no-op change to get build bot running

2010-08-12 15:30 SJL, revision 65282

Only include testableframe.h if we are compiling with wxUSE_GUI otherwise many compiler errors occur when compiling the non-gui tests.

2010-08-12 15:21 SJL, revision 65281

Wrap all individual tests in #if wxUSE_UIACTIONSIMULATOR blocks so they compile correctly when wxUIActionSimulator isn't available. The technote has also been updated to specify that this must be done.

2010-08-12 14:36 JTN, revision 65278

Move timer.cpp from core to base library

2010-08-12 10:52 SJL, revision 65277

Define a new macro WXUISIM_TEST that is only defined if wxUSE_UIACTIONSIMULATOR is defined. Wrap all existing tests that use wxUIActionSimulator in it and document that it should always be used for this reason. This will allow the tests to run on platforms that don't support wxUIActionSimulator and is especially important as it is not enabled be default.

2010-08-12 10:25 SC, revision 65276

no-op change to get build bot running

2010-08-12 01:11 JTN, revision 65273

New build slave for wxQt

2010-08-11 18:51 PJC, revision 65265

Improve wxRibbonMSWArtProvider's colour scheme generation when the primary and/or secondary colours are grey (see ticket #12331).

2010-08-11 18:46 SJL, revision 65264

Don't test a backwards range as this is properly handled by wxSL_INVERSE in wxSlider.

Select page:

[] [1 2 3 4 5 6 7 17 26 36] []

Imprint