Changelogs

Overview

These changelogs reflect the history of all files in the Subversion repository. The changelog has been generated at 2016-05-09 08:38:04

Select Changelog:

FileZilla 3, FileZilla Server,
Legacy FileZilla 2, Legay FileZilla Server

Select page:

[] [1 2 3 4 5 27 49 71] []

Changes per page:

25 50 100 250 500 1000 2000

Changelog for wxWidgets (70435 changes):

2014-04-28 00:39 VZ, revision 76406

Remove Windows version check from wxMBConv_win32. We don't support systems predating Windows 2000 SP4 any more, so there is no need to check for them. This also allows to get rid of the code checking for conversion correctness. Also remove the broken URLs from the comments, they didn't contain any particularly useful information anyhow.

2014-04-28 00:39 VZ, revision 76405

Fix precision in wxGraphicsContext::{Stroke,Draw}Lines() under MSW. Use floating point coordinates instead of ints which were used for some reason, resulting in a loss of precision. Closes #16187.

2014-04-28 00:38 VZ, revision 76404

Bring wxMSW wxBitmap::SetBitmapXXX(wxBitmap()) in line with wxGTK. Remove or reset the corresponding bitmap if the provided one is invalid instead of asserting, this is what wxGTK does and this behaviour seems to be more useful. Also document this behaviour as it's now implemented in both wxMSW and wxGTK. Closes #13569.

2014-04-28 00:38 VZ, revision 76403

Make wxMSW wxTextCtrl::AdjustSpaceLimit() safe to call in all cases. Allow calling this function not only from inside DoWriteText(): first, because the existing code could be doing this (although this is only a concern in 3.0 branch as it was made private in the trunk) and second because it could actually happen if the text limit was exceeded by user typing in the control. See #15980.

2014-04-28 00:38 VZ, revision 76402

Don't call AdjustSpaceLimit() explicitly in wxMSW wxTextCtrl any more. There is no need to do it as this is done by DoWriteText() and AdjustSpaceLimit() doesn't work correctly if called from outside of it now. Because of this, also make it private to prevent other accidental calls to it. Closes #15980.

2014-04-28 00:38 VZ, revision 76401

Suppress warnings about using _set_se_translator() for MSVC 12 too. We did it up to MSVC 11 but this still seems to work just fine without /EHa with MSVC 12 too, so relax the version check to allow it to pass.

2014-04-28 00:38 VZ, revision 76400

Get rid of deprecated warnings for ::GetVersionEx(). This does not solve the actual problem of this function not returning the correct value for Windows 8+ any more, but at least allows to compile the library without warnings with MSVC 12 and later.

2014-04-26 19:36 SC, revision 76399

adding wxFALLTHROUGH where until now we had comments, allows for code-analysis support

2014-04-26 19:11 PC, revision 76398

Delay GtkIMContext calls until widget is realized. This may avoid a locking bug seen on Ubuntu which causes a deadlock. See #16202

2014-04-25 23:03 SC, revision 76397

backport, get rid of performance warnings "For best performance, only use PostScript names when calling this API", see #15999

2014-04-25 16:35 SC, revision 76396

backport, get rid of performance warnings "For best performance, only use PostScript names when calling this API", see #15999

2014-04-25 15:02 SC, revision 76395

backport, add our own Apple Event handler for the quit app event, see #16200

2014-04-25 01:25 DS, revision 76394

Fixed wxFileDialog::MSWOnInitDone and wxFileDialog::MSWOnSelChange never being called. A condition was checking for the wrong CDN_XXX message range resulting in CDN_INITDONE and CDN_SELCHANGE no longer being processed. Broken since r75937 (branches/WX_3_0_BRANCH/) and r75941 (trunk/). See #16003.

2014-04-23 15:40 SC, revision 76393

in order to get rid of the warnings completely use the former font descriptor creation sequence and cache the result immediately, fixes #15999

2014-04-22 23:21 SC, revision 76392

add our own Apple Event handler for the quit app event, fixes #16200

2014-04-22 20:20 SC, revision 76391

The Human Interface Guidelines recommend using NSSmallSquareBezelStyle now

2014-04-22 18:27 JS, revision 76390

Added wxRichTextCtrl::DoLayoutBuffer so an application can perform custom tasks before or after layout.

2014-04-22 18:25 JS, revision 76389

Draw an unknown field using a fallback field type, so it's not invisible.

2014-04-22 18:24 JS, revision 76388

Don't Sync() if there is no buffer. This allows derived classes that handle the buffer differently (e.g. reuse the buffer).

2014-04-22 18:24 JS, revision 76387

Don't Sync() if there is no buffer. This allows derived classes that handle the buffer differently (e.g. reuse the buffer).

2014-04-22 18:23 JS, revision 76386

Don't Sync() if there is no buffer. This allows derived classes that handle the buffer differently (e.g. reuse the buffer).

2014-04-21 20:56 SC, revision 76385

removes zlib link statement from static builds, closes #16192

2014-04-21 20:52 SC, revision 76384

recreated project files, see #16192

2014-04-21 20:37 SC, revision 76383

adding built-in zlib sources, see #16192

2014-04-21 20:31 SC, revision 76382

adapting xcode build templates and config file to built-in zlib sources, see #16192

2014-04-20 14:45 VZ, revision 76380

Add wxGraphicsRenderer::GetName() and GetVersion() methods. Allow the code to determine which underlying technology is used for implementing wxGraphics API. This is needed by the unit tests to account for the known differences between platforms and may be useful in other cases. Closes #16154.

2014-04-20 14:44 VZ, revision 76379

Handle wxLANGUAGE_CAMBODIAN correctly in the generation script. Fix wxLANGUAGE_CAMBODIAN definition in autogenerated code, this was already done manually in r76368 but these changes would have been lost after the next generation, so update the script itself to generate them. Closes #16183.

2014-04-20 14:44 VZ, revision 76378

Fix the addition of Kabyle language. Data for this language was added manually in r75752, which meant that it was going to be lost after the next regeneration of the automatically generated files. Add it properly, by updating misc/language/langtabl.txt now.

2014-04-20 13:44 VZ, revision 76377

Italian translations update from bovirus.

2014-04-20 13:42 VZ, revision 76376

Aragonese translations update from Jorge Pérez Pérez.

2014-04-19 00:40 SN, revision 76368

Fixed wxLANGUAGE_USER_DEFINED, which is supposed to be the last element of the enum, but as such must still be given, before messing with the automatic internal counter of enum by defining synonyms. Fixes #16183.

2014-04-18 04:30 PC, revision 76367

fix building or running on GTK < 2.14 after r76365

2014-04-18 04:28 PC, revision 76366

remove wxOVERRIDE, forgot that it's trunk only

2014-04-17 19:36 PC, revision 76365

Add a separate GTK-specific wxDisplay implementation. This separates the GTK implementation from Unix/X11, except for the wxVideoMode stuff, and _NET_WORKAREA when GTK < 3.4. wxDisplay and wxClientDisplayRect() should now work as well as they can with Wayland.

2014-04-17 18:15 PC, revision 76364

allow using wxEventLoopGuarantor when wxUSE_GUI==1 fixes wxOSX-Cocoa build when wxUSE_CONSOLE_EVENTLOOP==0 closes #14980

2014-04-17 17:21 PC, revision 76363

use correct signature for callback

2014-04-17 08:22 PC, revision 76362

use a prefix match for interactive search having to type in the whole string to get a match is worthless

2014-04-17 08:09 PC, revision 76361

Avoid assertion failure when GtkTreeView interactive search is started. The treeview does an unselect_all causing a "changed" signal with no selection. The problem is easily triggered by pressing Ctrl-F (the "start-interactive-search" key binding)

2014-04-16 18:41 VS, revision 76359

Initialize wxFileDialog::m_filter{Panel,Choice} in ctor.

2014-04-16 18:41 VS, revision 76358

Initialize wxFileDialog::m_filter{Panel,Choice} in ctor.

2014-04-15 19:39 PC, revision 76354

remove extraneous semicolons

2014-04-15 19:23 PC, revision 76353

don't use Cairo functions when wxUSE_CAIRO==0

2014-04-15 18:16 PC, revision 76352

wxASSERT(false) --> wxFAIL

2014-04-15 18:16 PC, revision 76351

initialize members in ctor, avoid int-to-bool warnings

2014-04-15 18:16 PC, revision 76350

avoid unused variable warning with wxUSE_VALIDATORS==0

2014-04-15 18:07 PC, revision 76349

use gtk_window_set_opacity() in SetTransparent() when GTK >= 2.12

2014-04-15 17:46 PC, revision 76348

fix wxClientDisplayRect() when wxUSE_DISPLAY==0 GDK_WINDOWING_X11 was not getting defined, causing hard coded size to be used

2014-04-14 05:36 RD, revision 76343

Update how the docset is generated. Use a more human-friendly name, put the files in doxygen/out/docset instead of in html, etc.

2014-04-14 05:36 RD, revision 76342

Avoid possible infinite recursion

2014-04-14 05:36 RD, revision 76341

Add the CellHighlight getters too.

2014-04-14 05:36 RD, revision 76340

Add some missing wxGrid methods

2014-04-14 05:24 RD, revision 76332

Add the CellHighlight getters too.

2014-04-14 05:24 RD, revision 76331

Avoid possible infinite recursion

2014-04-14 05:24 RD, revision 76330

Add some missing wxGrid methods

2014-04-14 05:24 RD, revision 76329

Update how the docset is generated. Use a more human-friendly name, put the files in doxygen/out/docset instead of in html, etc.

2014-04-14 00:07 VZ, revision 76328

Use wxWS_EX_VALIDATE_RECURSIVELY in native Cocoa wxPreferencesEditor too. Transfer data recursively for consistency with the generic implementation and because this generally just makes more sense.

2014-04-14 00:07 VZ, revision 76327

Use wxWS_EX_VALIDATE_RECURSIVELY in native Cocoa wxPreferencesEditor too. Transfer data recursively for consistency with the generic implementation and because this generally just makes more sense.

2014-04-13 02:00 VZ, revision 76326

Disable TextCtrlTestCase::LongText() for non-MSW platforms. At least under GTK SetMaxLength(), tested by this test, can't be used with multiline text controls at all, so running it fails. Keep the test for MSW only where SetMaxLength() works with controls of all kinds.

2014-04-13 00:56 VZ, revision 76325

Add error handling to wxSound under wxOSX. Don't assume that we can open any file as a sound, check for the return value from AudioServicesCreateSystemSoundID().

2014-04-13 00:56 VZ, revision 76324

Don't use timer inside wxSound in wxOSX/Cocoa. The timer is only used by Carbon code, there is no need for it in Cocoa, so don't complicate things by starting it unnecessarily.

2014-04-13 00:56 VZ, revision 76323

Fix crash when playing invalid sounds under wxOSX. Sound ID 0 is not actually invalid, it is returned by AudioServicesCreateSystemSoundID() when it fails to open the file and currently we don't consider this to be an error. However, because we never called AudioServicesDisposeSystemSoundID() for this sound ID, we continued to receive the notifications from the callback registered by AudioServicesAddSystemSoundCompletion() for it even after the corresponding sound object was destroyed, resulting in crashes when playing it more than once. Fix this by keeping a separate flag indicating whether we're playing a sound and always disposing of the sound if we are, even if ID is 0.

2014-04-13 00:56 VZ, revision 76322

Call wxDataViewRenderer::Validate() under OS X too. Ensure that the custom renderers get a chance to validate (and maybe change) the value entered by user, as previously it was completely impossible with the native OS X implementation of wxDataViewCtrl.

2014-04-13 00:54 VZ, revision 76321

Fix crash when playing invalid sounds under wxOSX. Sound ID 0 is not actually invalid, it is returned by AudioServicesCreateSystemSoundID() when it fails to open the file and currently we don't consider this to be an error. However, because we never called AudioServicesDisposeSystemSoundID() for this sound ID, we continued to receive the notifications from the callback registered by AudioServicesAddSystemSoundCompletion() for it even after the corresponding sound object was destroyed, resulting in crashes when playing it more than once. Fix this by keeping a separate flag indicating whether we're playing a sound and always disposing of the sound if we are, even if ID is 0.

2014-04-13 00:54 VZ, revision 76320

Call wxDataViewRenderer::Validate() under OS X too. Ensure that the custom renderers get a chance to validate (and maybe change) the value entered by user, as previously it was completely impossible with the native OS X implementation of wxDataViewCtrl.

2014-04-13 00:54 VZ, revision 76319

Avoid selecting invalid tab when removing last page from wxOSX wxNotebook. Closes #15897 (backport of r75663 from trunk).

2014-04-12 17:42 PC, revision 76318

make validator pointer const

2014-04-12 02:11 VZ, revision 76317

Compilation fix for MinGW in GDI+ code. Don't use the XXXModeInvalid constants which are missing from MinGW headers for some reason.

2014-04-12 02:10 VZ, revision 76316

Use the same wxWeakRef implementation for complete and incomplete classes. This fixes an ODR violation which could arise if wxWeakRef<T> was seen both when T was an incomplete (e.g. just forward-defined) class and when it was complete. As different implementations, with different binary layouts, were used in these two cases, this resulted in fatal run-time problems. Fix this by always using the slightly less efficient (because storing an extra pointer) but simpler and safe "dynamic" wxWeakRef implementation. Also get rid of checks for the ancient compilers such as VC6 and g++ < 3.3, they are not supported any longer. Closes #15884.

2014-04-11 19:49 VZ, revision 76315

Restore correct handling of wxDocument::OnCreate() error return value. The changes of r74515 didn't quite restore the old behaviour, the document was still not being cleaned up if its OnCreate() simply returned false and not threw an exception. Do add cleanup in this code branch too, just duplicating what we in case of exception (this duplication can't be easily avoided unfortunately). This backports changes of r75646 from trunk, see #15883.

2014-04-11 18:04 PC, revision 76314

build fix for wxUSE_VALIDATORS==0 when NULL is defined to be nullptr casting nullptr is not allowed

2014-04-11 17:53 PC, revision 76313

build fix for wxUSE_VALIDATORS==0

2014-04-11 13:48 VZ, revision 76312

Fixes to the previous Nepalese translation update.

2014-04-11 06:48 PC, revision 76311

build fix for wxUSE_TOGGLEBTN==0

2014-04-11 06:48 PC, revision 76310

build fix for wxUSE_DRAG_AND_DROP==0

2014-04-11 06:48 PC, revision 76309

build fix for wxUSE_THREADS==0

2014-04-10 17:57 PC, revision 76308

fix invisible multi-line wxTextCtrl selection when custom foreground/background color is used with GTK3 closes #16176

2014-04-09 06:41 PC, revision 76307

fix invisible wxTextCtrl selection when custom foreground/background color is used with GTK3 closes #16176

2014-04-08 23:38 VZ, revision 76306

Nepalese translations update from Him Prasad Gautam.

2014-04-08 23:38 VZ, revision 76305

Don't set wxINTERPOLATION_GOOD quality by default in wxGDIPlusContext. This is inconsistent with wxOSX and also doesn't play well with the existence of wxINTERPOLATION_DEFAULT which is different from wxINTERPOLATION_GOOD. See #14134.

2014-04-08 23:31 VZ, revision 76304

Document unexpected default wxGraphicsContext interpolation quality. In 3.0, keep wxINTERPOLATION_GOOD as the default value instead of wxINTERPOLATION_DEFAULT for compatibility, but at least mention this and warn about the changes in 3.1. See #14134.

2014-04-08 23:23 VZ, revision 76303

Fix mouse events after calling WarpPointer() under OS X. See #16169.

2014-04-08 11:14 SC, revision 76302

fixes #16169

2014-04-07 22:34 VZ, revision 76301

Remove "default" clause from enums in wxGDIPlusContext code. This will allow the compiler to give us a warning if more elements are added to the enum later but not added to the switch. Also add error checking to Graphics::SetSmoothingMode() call.

2014-04-07 22:34 VZ, revision 76300

Fix mismatch between GDI+ and wxGraphicsContext interpolation quality. Use wxGDIPlusContext own method instead of using GDI+ method directly when setting the interpolation mode in wxGDIPlusContext initialization code to ensure that m_interpolation field matches the real interpolation mode used.

2014-04-07 22:34 VZ, revision 76299

Initialize wxGraphicsContext::m_interpolation field. This member wwas never initialized, resulting in erratic behaviour of SetInterpolationQuality() which compared its parameter with m_interpolation.

2014-04-07 22:29 VZ, revision 76298

Fix mismatch between GDI+ and wxGraphicsContext interpolation quality. Use wxGDIPlusContext own method instead of using GDI+ method directly when setting the interpolation mode in wxGDIPlusContext initialization code to ensure that m_interpolation field matches the real interpolation mode used.

2014-04-07 22:29 VZ, revision 76297

Initialize wxGraphicsContext::m_interpolation field. This member wwas never initialized, resulting in erratic behaviour of SetInterpolationQuality() which compared its parameter with m_interpolation.

2014-04-07 19:16 PC, revision 76296

update comment for wxBG_STYLE_TRANSPARENT

2014-04-07 19:15 PC, revision 76295

fix transparent window example wxBG_STYLE_TRANSPARENT can only be set before window creation. closes #16161

2014-04-07 18:23 JS, revision 76294

Object position calculation correction

2014-04-06 21:33 PC, revision 76293

avoid warnings about double-to-float conversion

2014-04-06 21:30 PC, revision 76292

avoid warning about shadowed variable

2014-04-06 21:28 PC, revision 76291

cast to proper type to avoid warning

2014-04-06 21:27 PC, revision 76290

remove unused macro definition

2014-04-06 21:27 PC, revision 76289

avoid warning about unreachable code

2014-04-05 19:13 PC, revision 76288

avoid double-to-float conversion warnings in headers

2014-04-05 12:44 VZ, revision 76287

Don't use %i format specifier for size_t values. In 64 bit build, size_t can be 64 bits while %i expects a 32 bit value. Fix this by just avoiding the unnecessary use of size_t, the number of entries in the index is not going to be greater than 2^32. Closes #16163.

2014-04-05 12:44 VZ, revision 76286

Fix warning about %lu being used with an int in 32 bit wxOSX build. NSUInteger is unsigned long in 64 bit builds, but unsigned int in 32 bits, so case it to long explicitly to avoid warnings about using it with %lu format specifier.

2014-04-05 12:44 VZ, revision 76285

Don't use %i format specifier for size_t values. In 64 bit build, size_t can be 64 bits while %i expects a 32 bit value. Fix this by just avoiding the unnecessary use of size_t, the number of entries in the index is not going to be greater than 2^32. Closes #16163.

2014-04-05 12:44 VZ, revision 76284

Fix warning about %lu being used with an int in 32 bit wxOSX build. NSUInteger is unsigned long in 64 bit builds, but unsigned int in 32 bits, so case it to long explicitly to avoid warnings about using it with %lu format specifier.

2014-04-04 20:32 VZ, revision 76283

Remove unused variables from wxRichTextListStylePage code. This avoids warnings about them.

2014-04-04 18:55 PC, revision 76282

avoid preprocessor directives inside macro invocation

2014-04-04 18:46 PC, revision 76281

remove unused member functions

2014-04-04 18:44 PC, revision 76280

remove unused macro definitions and limit others to the configurations which use them

2014-04-04 18:00 PC, revision 76279

assertion messages don't need to be translated

2014-04-04 17:56 PC, revision 76278

remove redundant assertion messages, wxLogError has already been called

2014-04-04 17:28 VZ, revision 76277

Add more precise wxRibbonBar::ShowPanels() overload. The existing overload taking bool didn't allow to specify whether the panel should be just expanded or expanded and pinned, add a new one supporting this. Also fix a bug with not updating the ribbon state in the old method. Closes #16133.

2014-04-04 17:28 VZ, revision 76276

Turkish translation update from Hakki Dogusan.

2014-04-04 17:28 VZ, revision 76275

Document wxRibbonDisplayMode enum. See #16133.

2014-04-04 17:28 VZ, revision 76274

Document wxRibbonDisplayMode enum. See #16133.

2014-04-04 17:26 PC, revision 76273

fix typo in size 2530 --> 3530

2014-04-04 17:09 PC, revision 76272

fix some asserts that were clearly meant to be wxFAIL_MSG

2014-04-04 08:45 PC, revision 76271

fix more memory leaks

2014-04-04 08:41 PC, revision 76270

Improve conversion between wxPaperSize and GtkPaperSize Eliminates many "Gtk-WARNING **: Unknown paper size", and the occasional "GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed". And fixes approximately one zillion memory leaks.

2014-04-04 08:36 PC, revision 76269

fix missing semicolon typo

2014-04-04 08:05 PC, revision 76268

Improve conversion between wxPaperSize and GtkPaperSize by using a table to map the screwy Windows DMPAPER_* stuff, which wxWidgets stupidly uses. Eliminates many "Gtk-WARNING **: Unknown paper size", and the occasional "GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed". And fixes approximately one zillion memory leaks.

2014-04-03 15:54 JS, revision 76267

Removed unnecessary list renumbering

2014-04-03 15:53 JS, revision 76266

Removed unnecessary list renumbering

2014-04-03 15:53 JS, revision 76265

Removed unnecessary list renumbering

2014-04-03 03:40 RD, revision 76264

working version of the trac hooks

2014-04-03 03:28 RD, revision 76263

Yet another test commit. Closes #16155

2014-04-03 03:08 RD, revision 76262

Yet another test commit. Closes #16155

2014-04-03 01:59 RD, revision 76261

Another test commit. Closes #16155

2014-04-03 01:51 RD, revision 76260

Another test commit. Closes #16155

2014-04-03 01:35 RD, revision 76259

Another test commit. Closes #16155

2014-04-03 01:26 RD, revision 76258

Update svn hooks. Closes #16155

2014-04-03 00:39 VZ, revision 76257

Fix return value of wxRichMessageDialog with only an "OK" button. Apply the same workaround as was applied in r67771 to wxMessageDialog to wxRichMessageDialog and map IDCANCEL returned from it to IDOK if "Cancel" is the only button in the dialog -- as in this case it's really just a renamed (for convenience of allowing the user to use "Esc" to close it) "OK". Closes #16153.

2014-04-03 00:39 VZ, revision 76256

Show the result of closing rich message box in the sample. Improve showing the button which closed the message box by doing it inside the dialog used for testing it instead of popping up a separate message box just for this. And do the same thing for rich message boxes as for the normal ones. See #16153.

2014-04-03 00:39 VZ, revision 76255

Decrease the size of the message box test dialog in the sample. This dialog was getting too tall, especially in the rich message boxes case, so reduce its vertical size. Also centre it on screen to prevent it from being displayed partially off it because contents was added to the dialog after creating it.

2014-04-03 00:38 VZ, revision 76254

Fix return value of wxRichMessageDialog with only an "OK" button. Apply the same workaround as was applied in r67771 to wxMessageDialog to wxRichMessageDialog and map IDCANCEL returned from it to IDOK if "Cancel" is the only button in the dialog -- as in this case it's really just a renamed (for convenience of allowing the user to use "Esc" to close it) "OK". Closes #16153.

2014-04-02 00:49 VZ, revision 76253

Don't build the drawing test in GUI-less builds. This test requires GUI parts. Closes #16145.

2014-04-01 19:45 PC, revision 76252

Fix invalid use of g_object_get_property()

2014-04-01 14:46 VZ, revision 76251

Fix recently introduced assert when using owner drawn items in wxMSW. Relax the check added in r76202, the item might not be added to its parent menu yet even if the menu is not NULL. See #13878.

2014-04-01 11:02 JJ, revision 76250

Update OpenVMS compile support

2014-04-01 10:56 JJ, revision 76249

OpenVMS (Alpha only) uses != operator in std::find ->needs operator defenition

2014-03-31 21:42 SC, revision 76248

fixing missing wxON_BLOCK_EXIT_OBJ1 error on gtk build

2014-03-31 20:28 SC, revision 76247

extra semicolon

2014-03-31 20:28 SC, revision 76246

testing whether this helps getting the drawing testsuite to build

2014-03-31 18:46 JS, revision 76245

Use style sheet when copying to the clipboard if available

2014-03-31 18:11 JS, revision 76244

Use style sheet when copying to the clipboard if available

2014-03-31 18:11 JS, revision 76243

Use style sheet when copying to the clipboard if available

2014-03-31 17:47 SC, revision 76242

single wxFALLTHROUGH change to test different builds

2014-03-31 17:46 SC, revision 76241

fixing parameter type

2014-03-31 17:46 SC, revision 76240

fixing extra semicolon

2014-03-31 17:46 SC, revision 76239

getting rid of clang warning due to variable size array

2014-03-31 17:45 SC, revision 76238

silencing paranoid analyzer

2014-03-31 17:44 SC, revision 76237

fixing include style

2014-03-31 17:28 SC, revision 76236

adding wxFALLTHROUGH to indicate intended fall through in switch statements

2014-03-31 14:58 SC, revision 76235

adding log for nonprecomp builds, hopefully fixes test compiles on builbot

2014-03-31 14:34 SC, revision 76234

adding correct return type

2014-03-31 13:23 SC, revision 76233

make sure platform constants exist by using defs.h instead of setup.h

2014-03-31 09:55 SC, revision 76232

adding minimal ios support for webview

2014-03-31 09:28 SC, revision 76231

removing extra semicola

2014-03-31 09:08 SC, revision 76230

removing extra semicola

2014-03-31 08:15 SC, revision 76229

removing unnecessary header

2014-03-31 08:02 SC, revision 76228

fixing extra semicola

2014-03-31 04:16 PC, revision 76227

use wxDialog::ShowModal() rather than gtk_dialog_run() so all the things wxDialog::ShowModal() does are not bypassed

2014-03-30 21:23 PC, revision 76226

Prevent dialog widget from being destroyed during ShowModal()

2014-03-30 19:17 VZ, revision 76225

Vietnamese translations update from Trần Ngọc Quân.

2014-03-30 13:47 SC, revision 76224

removing superfluous semicolon

2014-03-30 13:46 SC, revision 76223

adding empty base class implementation for OnNextIteration, call from OSXDoRun, allowing console event loop to override

2014-03-30 09:07 PC, revision 76222

use "new" wx-prefixed macros in samples

2014-03-30 03:52 PC, revision 76221

adjust size hints when decor size changes, to prevent changing a set client size during initial show closes #15794

2014-03-30 01:02 PC, revision 76220

use wxOVERRIDE

2014-03-29 17:53 VZ, revision 76219

Avoid overflows when calculating metafile coordinates in wxMSW. Use MulDiv() instead of naive multiplication followed by division as this could overflow, and did when large paper sizes were used in print preview. Closes #16138.

2014-03-29 17:53 VZ, revision 76218

Another PrepareForItem()-related fix in generic wxDataViewCtrl. This fix is similar to the previous commit but more speculative, as we currently don't have a bug scenario for it. Still, it seems to be wrong to call PrepareForItem() just before GetLineStart() which undoes its effect, so exchange the order of the calls. See #16132.

2014-03-29 17:53 VZ, revision 76217

Fix clicking on activatable toggle column in generic wxDataViewCtrl. Call PrepareForItem() after calling GetLineStart() as the latter calls PrepareForItem() for other items internally, undoing the effects of the first call. Closes #16132.

2014-03-29 17:53 VZ, revision 76216

Fix use of expander in non left most position in wxDataViewCtrl. Correct the expander rectangle definition to work when the expander column left boundary is not 0, i.e. if the expander column is not the left most one. Closes #16131.

2014-03-29 17:53 VZ, revision 76215

Simplify wxMSW wxToolBar controls support implementation. Rely on being able to set the separator size, which is supported since comctl32.dll v4.71 (the version distributed with IE 4.0...). This allows to remove big chunks of code dealing with multiple separators and simplifies the rest. Closes #16129.

2014-03-29 17:53 VZ, revision 76214

Avoid overflows when calculating metafile coordinates in wxMSW. Use MulDiv() instead of naive multiplication followed by division as this could overflow, and did when large paper sizes were used in print preview. Closes #16138.

2014-03-29 17:52 VZ, revision 76213

Another PrepareForItem()-related fix in generic wxDataViewCtrl. This fix is similar to the previous commit but more speculative, as we currently don't have a bug scenario for it. Still, it seems to be wrong to call PrepareForItem() just before GetLineStart() which undoes its effect, so exchange the order of the calls. See #16132.

2014-03-29 17:52 VZ, revision 76212

Fix clicking on activatable toggle column in generic wxDataViewCtrl. Call PrepareForItem() after calling GetLineStart() as the latter calls PrepareForItem() for other items internally, undoing the effects of the first call. Closes #16132.

2014-03-29 17:52 VZ, revision 76211

Fix use of expander in non left most position in wxDataViewCtrl. Correct the expander rectangle definition to work when the expander column left boundary is not 0, i.e. if the expander column is not the left most one. Closes #16131.

2014-03-29 14:06 VS, revision 76210

Don't emit wxEVT_TEXT in wxMSW's wxTextCtrl::SetFont(). Native text control sends EN_CHANGE when the font changes, producing a wxEVT_TEXT event as if the user changed the value. This is not the case, so supress the event.

2014-03-29 14:04 VS, revision 76209

Revert "Don't emit wxEVT_TEXT in wxMSW's wxTextCtrl::SetFont()." This reverts accidentally committed r76207.

2014-03-29 14:03 VS, revision 76208

OS X: fix wxFileDialog::SetupExtraControls()'s sandbox test. OS X 10.9 (possibly earlier) don't have nil contentView in NSSavePanel anymore, a NSRemoteView instance is used. The wx code that follows this test still crashes under sandbox, though, so update the check to use the APP_SANDBOX_CONTAINER_ID environment variable, which is only set when running under the sandbox. This is just another quick fix for the existing uncomfortably long-lived sandbox crash hotfix, not a proper solution.

2014-03-29 14:03 VS, revision 76207

Don't emit wxEVT_TEXT in wxMSW's wxTextCtrl::SetFont(). Native text control sends EN_CHANGE when the font changes, producing a wxEVT_TEXT event as if the user changed the value. This is not the case, so supress the event.

2014-03-29 14:02 VS, revision 76206

OS X: fix wxFileDialog::SetupExtraControls()'s sandbox test. OS X 10.9 (possibly earlier) don't have nil contentView in NSSavePanel anymore, a NSRemoteView instance is used. The wx code that follows this test still crashes under sandbox, though, so update the check to use the APP_SANDBOX_CONTAINER_ID environment variable, which is only set when running under the sandbox. This is just another quick fix for the existing uncomfortably long-lived sandbox crash hotfix, not a proper solution.

2014-03-27 23:10 VZ, revision 76205

Make "NOT the index" in wxListCtrl::SortItems() stand out even more. Any reasonable person expects the sort callback to receive the indices of the items, but it doesn't: it's passed the client data associated with them instead. Make it even more noticeable in the documentation.

2014-03-27 13:46 JS, revision 76204

Allow derivation from wxRichTextBufferDataObject

2014-03-27 13:05 VZ, revision 76203

Russian translations update from Pavel Maryanov.

2014-03-27 01:02 VZ, revision 76202

Make wxMSW owner drawn menu item code more clear and correct. The user-visible effect of this change is that removing the item from the menu and adding it back doesn't lose its icon any more. At the code level, wxMenuItem::SetBitmaps() and related methods are implemented outside of "#if wxUSE_OWNER_DRAWN" which allows to use them even in minimalistic library builds. And IsOwnerDrawn() is not used any more to determine whether the item has bitmaps, just only if it's really owner drawn, making the code more clear and fixing at least the bug above and possible more. Closes #13878.

2014-03-27 01:02 VZ, revision 76201

Rename wxMenuItem::MustUseOwnerDrawn() to MSWMustUseOwnerDrawn(). No real changes, just make it clear that this method is MSW-specific and is about using owner drawn items at MSW level and not wx one. See #13878.

2014-03-27 01:02 VZ, revision 76200

Close monitoring thread handles as soon as possible in wxMSW. Don't leave the handles of all threads used for monitoring the child processes open until the main process termination, rather close them as soon as the monitored process terminates. This ensures that we don't accumulate potentially unbounded number of open handles if we keep launching new child processes. An even better idea would be to actually use a single thread for monitoring all of them, but this fix is much simpler and should fix the most acute problem for now. Closes #16123.

2014-03-27 00:41 VZ, revision 76199

Close monitoring thread handles as soon as possible in wxMSW. Don't leave the handles of all threads used for monitoring the child processes open until the main process termination, rather close them as soon as the monitored process terminates. This ensures that we don't accumulate potentially unbounded number of open handles if we keep launching new child processes. An even better idea would be to actually use a single thread for monitoring all of them, but this fix is much simpler and should fix the most acute problem for now. Closes #16123.

2014-03-26 14:40 VZ, revision 76198

Dutch translations update from Thomas De Rocker.

2014-03-24 19:46 VZ, revision 76197

Add missing wxUSE_WXDIB checks. Fix compilation with wxUSE_WXDIB==0. Closes #16113.

2014-03-24 19:46 VZ, revision 76196

Don't change bitmap depth in wxMSW when copying it. Sometimes, creating a DDB may fail to create the bitmap of the requested depth and so a copy of wxBitmap could have a different depth than the original wxBitmap. Avoid this problem by falling back on using DIB if DDB with the right depth couldn't be created. Closes #11640.

2014-03-24 14:19 VZ, revision 76195

Add "View text" menu item to the webview sample. Allow to view just the text of the web page. Closes #16098.

2014-03-24 14:17 VZ, revision 76194

Fix reentrancy issues in wxMSW wxTextCtrl max length handling code. The changes of r75936 didn't work correctly if the handler of wxEVT_TEXT in some text control modified a (potentially) different text control, as the same global variable was reused with disastrous results. Avoid this by keeping a stack of insertion lengths instead. Additionally, fix another problem in r75936 which used 0 as a special marker for the insertion length, which result in redoing each insertion of empty string (which is another word for Remove()) twice unnecessarily, by using -1 instead. Closes #15980.

2014-03-24 14:06 VZ, revision 76193

Fix reentrancy issues in wxMSW wxTextCtrl max length handling code. The changes of r75940 didn't work correctly if the handler of wxEVT_TEXT in some text control modified a (potentially) different text control, as the same global variable was reused with disastrous results. Avoid this by keeping a stack of insertion lengths instead. Using a per-control field would work too, but would be a bit wasteful as the size of the stack will rarely be more than 1 (and never much more) and this change can also be applied to 3.0 branch without breaking ABI. Additionally, fix another problem in r75940 which used 0 as a special marker for the insertion length, which result in redoing each insertion of empty string (which is another word for Remove()) twice unnecessarily, by using -1 instead. Closes #15980.

2014-03-23 18:54 VZ, revision 76192

Add files included by richtext library to MSVC1{1,2} projects. Closes #16104.

2014-03-23 16:18 VZ, revision 76191

Fix setting menu item bitmaps after appending them in wxMSW. Update the bitmap used by Windows when using non-owner-drawn items with bitmaps. Closes #9388.

2014-03-23 16:18 VZ, revision 76190

Refactor wxMSW: move some code from wxMenu to wxMenuItem. This will allow reusing it for other wxMenuItem bitmap-related operations. See #9388.

2014-03-23 01:57 VZ, revision 76189

Fix toolbar repainting after deleting a tool in wxMSW. The toolbar was in an inconsistent state when recalculating the sizes of the separators used as placeholders for the controls and stretch spacers as the tool was already deleted from the native toolbar but still present in wx internal toolbar data and this resulted in discrepancies between the indices in the native and wx toolbars. Fix this by specially marking the already deleted but not yet removed tool and ignoring it during the recalculations. This makes the old, and only partially successful, attempt to work around this bug in DoDeleteTool() unnecessary and so the code is actually simplified by this change. Closes #16095.

2014-03-23 01:57 VZ, revision 76188

Document what wxPrintQuality really is. Mention that it can be either a predefined constant or a number expressing the resolution. See #14085.

2014-03-23 01:57 VZ, revision 76187

Fix wxFileSystemWatcher::RemoveAll() to actually work. We need to call DoRemove() on all watcher objects to really remove them, just removing our record of them was not enough and e.g. resulted in errors if we tried to re-add a previously watched path again. Closes #15531.

2014-03-23 01:57 VZ, revision 76186

Fix handling deletion of watched directory in MSW wxFileSystemWatcher. Don't log an incomprehensible error when the watched directory itself is deleted, but generate wxFSW_EVENT_DELETE for it. This is consistent with the behaviour under Unix and generally more useful. Closes #13294.

2014-03-23 01:57 VZ, revision 76185

Small refactoring in wxFileSystemWatcher MSW implementation. Make wxIOCPService::GetStatus() smarter about its return value, it makes sense to encapsulate the convention used to indicate the thread exit condition inside wxIOCPService class itself instead of sharing it between it wxIOCPThread itself. It will also make it easier to detect more detailed error conditions in this code.

2014-03-23 01:56 VZ, revision 76184

Disable the use of "override" keyword for MSVC < 11. While the keyword is indeed supported since MSVC 8, it's only since MSVC 11 that using it doesn't generate C4481 compiler warning ("nonstandard extension used"), so avoid using it with the earlier versions. See #16100.

2014-03-23 01:51 VZ, revision 76183

Fix toolbar repainting after deleting a tool in wxMSW. The toolbar was in an inconsistent state when recalculating the sizes of the separators used as placeholders for the controls and stretch spacers as the tool was already deleted from the native toolbar but still present in wx internal toolbar data and this resulted in discrepancies between the indices in the native and wx toolbars. Fix this by specially marking the already deleted but not yet removed tool and ignoring it during the recalculations. This makes the old, and only partially successful, attempt to work around this bug in DoDeleteTool() unnecessary and so the code is actually simplified by this change. Closes #16095.

2014-03-23 01:10 VZ, revision 76182

Fix wxFileSystemWatcher::RemoveAll() to actually work. We need to call DoRemove() on all watcher objects to really remove them, just removing our record of them was not enough and e.g. resulted in errors if we tried to re-add a previously watched path again. Closes #15531.

2014-03-23 01:10 VZ, revision 76181

Fix handling deletion of watched directory in MSW wxFileSystemWatcher. Don't log an incomprehensible error when the watched directory itself is deleted, but generate wxFSW_EVENT_DELETE for it. This is consistent with the behaviour under Unix and generally more useful. Closes #13294.

2014-03-23 01:10 VZ, revision 76180

Small refactoring in wxFileSystemWatcher MSW implementation. Make wxIOCPService::GetStatus() smarter about its return value, it makes sense to encapsulate the convention used to indicate the thread exit condition inside wxIOCPService class itself instead of sharing it between it wxIOCPThread itself. It will also make it easier to detect more detailed error conditions in this code.

2014-03-22 23:03 VZ, revision 76179

Handle normalization of directory names correctly in wxFileHistory. Don't use relative path for the directories, which can also be managed by wxFileHistory, because they don't have any and the old code resulted in showing an empty string for them.

2014-03-20 20:52 VZ, revision 76177

Put a __cplusplus guard around C++-specific tests in wx/defs.h. This avoids the warning about __cplusplus being undefined in the recently added wxOVERRIDE logic and make the existing wx_xxx_cast<>s definitions simpler.

2014-03-20 20:45 VZ, revision 76176

Mark some deprecated wxGrid methods as deprecated in the documentation. Point people to the new names of the deprecated methods. Closes #16103.

2014-03-20 20:45 VZ, revision 76175

Use Doxygen @deprecated tags for deprecated methods. Instead of just mentioning that the methods are deprecated in the documentation text, use the @deprecated tag for them to make it possible to detect it in documentation-processing tools too. Closes #16102.

2014-03-20 16:49 VZ, revision 76174

Remove configure test for override keyword. Detect its support in the code by testing __cplusplus value and using specific checks for MSVC and Clang as configure detects it as being available when using recent g++ versions in non-C++11 mode, which do support this keyword but warn when it is used without -std={gnu,c}++11 option, which makes actually using it a bad idea in this case.

2014-03-20 14:26 VZ, revision 76173

Add wxOVERRIDE and use it in common and wxOSX code. Make overriding virtual methods more explicit and enable additional checks provided by C++11 compilers when "override" is used. Closes #16100.

2014-03-20 14:26 VZ, revision 76172

Compilation fix in wchar_t build after r76171. Don't concatenate narrow wxLongLongFmtSpec with wide strings, just don't use wxT() at all. Closes #14685.

2014-03-19 23:57 VZ, revision 76171

Add wxInt64 support to wxText{Input,Output}Stream. Add explicit Read64[S]() and Write64() methods. Closes #14685.

2014-03-19 19:06 VZ, revision 76170

Use "virtual" keyword with overridden methods. No real changes, just make the code more clear by explicitly using "virtual". Closes #16097.

2014-03-19 19:01 VZ, revision 76169

Remove more unnecessary headers from drawing test. Don't include GUI headers in non-GUI code.

2014-03-19 18:59 VZ, revision 76168

Fix WX_ASSERT_SAME_AS_FILE() definition in the new drawing test. This macro should use AreFilesContentsEqual(), not AreImagesFilesContentsEqual(), used by WX_ASSERT_SAME_AS_IMAGE_FILE().

2014-03-18 21:12 VZ, revision 76166

Don't include apparently unnecessary headers in drawing test. wx/window.h shouldn't be needed in this non-GUI test.

2014-03-18 21:10 VZ, revision 76165

Remove redundant forward declaration of wxCursor from wx/window.h. We include wx/cursor.h from wx/window.h anyhow (and can't avoid it as we have a member of wxCursor type in wxWindowBase).

2014-03-18 20:31 VZ, revision 76164

Add a new test checking wxGraphicsContext implementation correctness. This test verifies that the output of wxGraphicsContext on the current system matches the pregenerated reference output.

2014-03-18 20:28 VZ, revision 76163

Include the individual headers that we really need instead.

2014-03-18 20:28 VZ, revision 76162

Don't include wx/dc.h from wx/graphics.h. This is not necessary and prevents compilation of this header in wxUSE_GUI=0 case.

2014-03-18 20:28 VZ, revision 76161

Don't include wx/cursor.h from wx/dc.h. This is simply not needed.

2014-03-18 18:23 VZ, revision 76160

Add font colour support to wxFontPickerCtrl. Currently this is only really implemented under Windows, just as the colour support in wxFontDialog, but make the API available under all platforms for consistency. Closes #11614.

2014-03-18 18:23 VZ, revision 76159

Use helper GetPickerWidget() function in wxFontPickerCtrl. No real changes, just use a helper function instead of an ugly M_PICKER macro. See #11614.

2014-03-18 18:08 VZ, revision 76158

Use "MultiProcessorCompilation" instead of explicit /MP in MSVS projects. Use the user-visible option instead of the command line option which is now hidden in the IDE. Closes #16093.

2014-03-18 18:07 VZ, revision 76157

Use "MultiProcessorCompilation" instead of explicit /MP in MSVS projects. Use the user-visible option instead of the command line option which is now hidden in the IDE. Closes #16093.

2014-03-18 15:21 VZ, revision 76156

Add margin to the right of the message in wxGenericProgressDialog. For some reason the border was used only on the left side but not on the right one, resulting in the ugly looking label flush to the right dialog border if it was long enough. Closes #16094.

2014-03-18 15:20 VZ, revision 76155

Add margin to the right of the message in wxGenericProgressDialog. For some reason the border was used only on the left side but not on the right one, resulting in the ugly looking label flush to the right dialog border if it was long enough. Closes #16094.

2014-03-18 10:14 JS, revision 76154

Improved calculation of spanning column widths.

2014-03-16 17:39 PC, revision 76153

update for GTK3

2014-03-16 14:05 VZ, revision 76152

Disable the use of new style wxDirDialog under Vista. IFileDialog-based dialog has a bug making it return a wrong path sometimes under Vista, disable its use there to avoid it. Closes #16005.

2014-03-16 14:05 VZ, revision 76151

Disable the use of new style wxDirDialog under Vista. IFileDialog-based dialog has a bug making it return a wrong path sometimes under Vista, disable its use there to avoid it. Closes #16005.

2014-03-15 20:34 PC, revision 76150

build fixes for wxUniversal

2014-03-15 19:44 PC, revision 76149

for GTK+ 3.6 and later, invalidate cached best size when GTK's style cache is updated, see #16088

2014-03-14 20:22 VZ, revision 76148

Fix showing of 32bpp bitmaps without alpha in wxMSW wxStaticBitmap. The native control doesn't make a secret copy of the image in this case (0RGB bitmap, i.e. 32bpp ARGB bitmap with all alpha values set to 0) and just shows the bitmap we assigned to it directly, so we must not delete it in this case, otherwise nothing is shown at all. Closes #16084.

2014-03-14 20:22 VZ, revision 76147

Also free internal handlers when wxMSW wxStaticBitmap is destroyed. r76142 fixed the resource leak when wxStaticBitmap image was replaced by another one but the leak still happened at the end, when the wxStaticBitmap was destroyed. Fix it there as well in the same way. Closes #16068.

2014-03-14 20:22 VZ, revision 76146

Fix recently introduced compilation error in wxUSE_PALETTE==0 build. Add missing "#if wxUSE_PALETTE" tests. Closes #16083.

2014-03-14 20:21 VZ, revision 76145

Also free internal handlers when wxMSW wxStaticBitmap is destroyed. r76141 fixed the resource leak when wxStaticBitmap image was replaced by another one but the leak still happened at the end, when the wxStaticBitmap was destroyed. Fix it there as well in the same way. Closes #16068.

2014-03-14 02:36 VZ, revision 76144

Add support for loading old V1 bitmap files to wxBMPHandler. Such files are apparently still seen in the wild, even though this format has been superseded since Windows 3.0 (!). Closes #3433.

2014-03-13 18:09 SC, revision 76143

adding 10.5 compatibility again

2014-03-13 17:20 VZ, revision 76142

Fix resource leak in wxMSW wxStaticBitmap when using RGBA icons. Release the old handle if it wasn't freed by STM_SETIMAGE itself. Closes #16068.

2014-03-13 17:19 VZ, revision 76141

Fix resource leak in wxMSW wxStaticBitmap when using RGBA icons. Release the old handle if it wasn't freed by STM_SETIMAGE itself. Closes #16068.

2014-03-13 17:17 VZ, revision 76140

Avoid unused variable warning in wxUSE_VALIDATORS==0 build. Closes #16076.

2014-03-13 17:15 VZ, revision 76139

Install wx/preferences.h and wx/testing.h in "make install". These headers were accidentally forgotten in files.bkl, add them there and rebake.

2014-03-13 17:12 VZ, revision 76138

Install wx/preferences.h and wx/testing.h in "make install". These headers were accidentally forgotten in files.bkl, add them there and rebake.

2014-03-13 14:03 VZ, revision 76137

Compilation fix to wxScopedArray use. The ctor taking the number of elements doesn't exist in 3.0, don't use it to fix compilation after the changes of r76124.

2014-03-13 00:04 VZ, revision 76136

Use wxScopedXXX<> instead of explicit memory management in wxBMPHandler. Make the code simpler and ensure there are no memory leaks in it.

2014-03-13 00:04 VZ, revision 76135

No changes, just use properly const variable in wxBMPHandler code. Initialize "data" pointer consistently with "alpha".

2014-03-13 00:04 VZ, revision 76134

Add support for saving 32bpp icons too. Save in 32bpp format if alpha channel is present in the image being saved in ICO format. See #15918.

2014-03-13 00:04 VZ, revision 76133

Allow saving 24 bpp ICO file in wxImage. Create ICO files with 24bpp if the image being saved contains more than 256 colours. Also use smaller values (4 bpp or monochrome) if the image uses fewer colours. See #15918.

2014-03-13 00:04 VZ, revision 76132

Add support for saving 256*256 ICOs in PNG format. Allow saving icons larger than 127*127 pixels (up to 256*256 which is the maximal size supported by the ICO format) and save large icons with the item data in PNG format, as it is normally done for these sizes. See #15918.

2014-03-13 00:04 VZ, revision 76131

Add support for loading icons in PNG format to wxImage. ICO files can contain data in PNG, as well as BMP, format in recent (i.e. from this millennium) versions of Windows, so check for this case in wxICOHandler and load such data using wxPNGHandler. See #15918.

2014-03-13 00:04 VZ, revision 76130

Handle verbosity correctly in wxICOHandler loading code. Pass on the "verbose" argument to LoadDib() function instead of always being verbose in it. Also remove the unused IsBmp variable. See #15918.

2014-03-13 00:04 VZ, revision 76129

Allow loading icons of width 256 from ICO files. Account for the tweak of ICO file format which uses 0 if the width is 256. See #15918.

2014-03-13 00:03 VZ, revision 76128

Fix possible memory leak in wxICOHandler loading code. Use wxScopedArray<> instead of a raw pointer to ensure that the memory is always freed, even in case of error return. See #15918.

2014-03-12 23:54 VZ, revision 76127

Add support for loading icons in PNG format to wxImage. ICO files can contain data in PNG, as well as BMP, format in recent (i.e. from this millennium) versions of Windows, so check for this case in wxICOHandler and load such data using wxPNGHandler. See #15918.

2014-03-12 23:54 VZ, revision 76126

Handle verbosity correctly in wxICOHandler loading code. Pass on the "verbose" argument to LoadDib() function instead of always being verbose in it. Also remove the unused IsBmp variable. See #15918.

2014-03-12 23:54 VZ, revision 76125

Allow loading icons of width 256 from ICO files. Account for the tweak of ICO file format which uses 0 if the width is 256. See #15918.

2014-03-12 23:54 VZ, revision 76124

Fix possible memory leak in wxICOHandler loading code. Use wxScopedArray<> instead of a raw pointer to ensure that the memory is always freed, even in case of error return. See #15918.

2014-03-12 23:20 VZ, revision 76123

Reset the system last error value before checking it in wxLog test. Explicitly set the last error indicator to 0 before checking that wxLogSysError() logs it correctly as it wasn't always set to 0 otherwise.

2014-03-12 17:02 VZ, revision 76122

Update the version string in manually managed VC11 project files. Use "31", not "30".

2014-03-12 14:23 VZ, revision 76121

Upgrade included Scintilla to version 3.3.9. Closes #15742.

2014-03-11 21:48 VZ, revision 76120

Add wxFont::GetBaseFont(). This can be used to "undo" the result of Bold() ,Underlined() or Italic() methods and returns an unadorned version of the font. Closes #11815.

2014-03-11 21:48 VZ, revision 76119

Remove unnecessarily overridden methods from wxToggleButtonBase. These methods already do exactly the same thing in the base wxAnyButton class, there is no need to override them again.

2014-03-11 21:48 VZ, revision 76118

No changes, just fix typos in my own name ("Zeitlin").

2014-03-11 17:04 VZ, revision 76117

Add wxEnhMetaFile::Detach(). Allow getting the handle from this class, this is useful if it needs to be passed to some other library, for example. Closes #15706.

2014-03-11 17:04 VZ, revision 76116

Correct wxThread::SetPriority() under Unix to hopefully work. The old implementation was completely broken, the new should hopefully work if pthread_setschedparam() behaviour really corresponds to its documentation. Mapping of our priorities in 0..100 range to pthread 1..99 range remains ugly but this seems to be unavoidable, unfortunately. Closes #14985.

2014-03-11 17:04 VZ, revision 76115

Fix accelerators in appended submenu items in wxGTK. They were not previously taken into account because we didn't call gtk_widget_add_accelerator() on the right GtkAccelGroup. Closes #16050.

2014-03-11 17:04 VZ, revision 76114

Add wxDynamicLibrary::GetModuleFromAddress(). Use dladdr() under Unix, if available, to provide the same functionality as we get from GetModuleHandleEx() under MSW and export it in a new public function. Closes #15248.

2014-03-11 16:20 VZ, revision 76113

Fix accelerators in appended submenu items in wxGTK. They were not previously taken into account because we didn't call gtk_widget_add_accelerator() on the right GtkAccelGroup. Closes #16050.

2014-03-10 20:05 VZ, revision 76111

Do run TextStreamTestCase::TestULongLong() test case. We ran TestLongLong test case twice because of an accidental typo.

2014-03-10 12:08 JS, revision 76110

Added on-demand image loading option to wxRTC.

2014-03-09 21:58 VZ, revision 76109

Fix size calculation for multi-column vertical toolbars in wxMSW. The width was calculated incorrectly in this case as we simply multiplied the width of the widest column by their number in this case, but actually each of them has its own width which needs to be calculated separately. See #13579.

2014-03-09 21:58 VZ, revision 76108

Fix background painting of multi-row toolbars in wxMSW. The item rectangle used wrong vertical coordinates which didn't matter (much?) for the single row toolbars but was completely wrong for toolbars with more than one row. Don't always anchor the rectangle at the window top to avoid this. See #13579.

2014-03-09 21:58 VZ, revision 76107

Disable stretchable spaces in multi-row toolbars in wxMSW. Stretchable separators simply don't work correctly when the space they are supposed to stretch onto is distributed across several different toolbar rows or columns, so just disable them for multi-row (or column, for vertical toolbars) case. See #13579.

2014-03-09 21:56 VZ, revision 76106

Fix size calculation for multi-column vertical toolbars in wxMSW. The width was calculated incorrectly in this case as we simply multiplied the width of the widest column by their number in this case, but actually each of them has its own width which needs to be calculated separately. See #13579.

2014-03-09 21:55 VZ, revision 76105

Fix background painting of multi-row toolbars in wxMSW. The item rectangle used wrong vertical coordinates which didn't matter (much?) for the single row toolbars but was completely wrong for toolbars with more than one row. Don't always anchor the rectangle at the window top to avoid this. See #13579.

2014-03-09 21:55 VZ, revision 76104

Disable stretchable spaces in multi-row toolbars in wxMSW. Stretchable separators simply don't work correctly when the space they are supposed to stretch onto is distributed across several different toolbar rows or columns, so just disable them for multi-row (or column, for vertical toolbars) case. See #13579.

2014-03-09 17:54 TIK, revision 76103

Don't assert if no keyboard has been found in wxGetKeyState(). Sometimes there really is no keyboard plugged in.

2014-03-09 17:51 TIK, revision 76102

wxBitmap::GetMask() asserts on invalid bitmap. Check for valid bitmap before calling GetMask().

2014-03-09 15:05 VZ, revision 76101

Make Move{Before,After}InTabOrder() work at any time in wxGTK. These functions only worked if called at the beginning, before showing the parent window containing the children whose TAB order was being adjusted, because it didn't refresh the GTK+ TAB order on the correct window: we need to do it for the parent of the window being moved, not this window itself. Closes #16032.

2014-03-09 15:03 VZ, revision 76100

Make Move{Before,After}InTabOrder() work at any time in wxGTK. These functions only worked if called at the beginning, before showing the parent window containing the children whose TAB order was being adjusted, because it didn't refresh the GTK+ TAB order on the correct window: we need to do it for the parent of the window being moved, not this window itself. Closes #16032.

2014-03-08 15:34 VZ, revision 76099

Fix handling of controls in vertical toolbars in wxMSW. Not adding the controls to vertical toolbar is not enough, we also need to hide them to prevent them from being shown as independent floating windows. And we also need to add separators instead of the controls themselves to keep the indices the same as in the horizontal case. Closes #11821.

2014-03-08 15:33 VZ, revision 76098

Fix handling of controls in vertical toolbars in wxMSW. Not adding the controls to vertical toolbar is not enough, we also need to hide them to prevent them from being shown as independent floating windows. And we also need to add separators instead of the controls themselves to keep the indices the same as in the horizontal case. Closes #11821.

2014-03-08 14:39 VZ, revision 76097

Fix handling of Esc while an auto-complete drop down is open in wxMSW. Just close the drop down instead of closing the dialog the text control using this auto-complete drop down is in, as this was completely unexpected and counter-intuitive. Closes #13945.

2014-03-08 14:39 VZ, revision 76096

Fix handling of Esc while an auto-complete drop down is open in wxMSW. Just close the drop down instead of closing the dialog the text control using this auto-complete drop down is in, as this was completely unexpected and counter-intuitive. Closes #13945.

2014-03-07 19:43 PC, revision 76095

fix memory leak in SetFont with GTK3

2014-03-07 14:17 VZ, revision 76094

Skip mouse button release events in wxGenericTreeCtrl. Not doing this prevented the default handling from taking place resulting in internal confusion in GtkNotebook when wxTreeCtrl was placed inside it: the code there set the button being held by user in its mouse press event handler and reset it in its mouse release event handler which was never called because we didn't skip the event, resulting in ignoring the next mouse press in the notebook. Closes #16055.

2014-03-07 14:16 VZ, revision 76093

Skip mouse button release events in wxGenericTreeCtrl. Not doing this prevented the default handling from taking place resulting in internal confusion in GtkNotebook when wxTreeCtrl was placed inside it: the code there set the button being held by user in its mouse press event handler and reset it in its mouse release event handler which was never called because we didn't skip the event, resulting in ignoring the next mouse press in the notebook. Closes #16055.

2014-03-07 02:19 VZ, revision 76092

Make stretchable spacers work in vertical toolbars too in wxMSW. Replace the old implementation of stretchable spacers based on changing the size of the separators used as spacers as the toolbar size itself changed with a new one, simply replacing the old separator with the new one of the correct size, as it also works for the vertical toolbars, unlike the old approach. Closes #13673.

2014-03-07 02:19 VZ, revision 76091

Document Insert() and Prepend() overloads taking wxMenu. Document these methods in addition to AppendSubMenu(). Closes #16052.

2014-03-07 01:58 VZ, revision 76090

Document Insert() and Prepend() overloads taking wxMenu. Document these methods in addition to AppendSubMenu(). Closes #16052.

2014-03-06 14:53 VZ, revision 76089

Update the URL of the web site images used in the test. The old images don't exist any more after web site redesign. Also, the new favicon can't be loaded from an unseekable stream because it contains multiple icons, so point to the old favicon instead. Closes #16049.

2014-03-06 14:49 VZ, revision 76088

Update the URL of the web site images used in the test. The old images don't exist any more after web site redesign. Also, the new favicon can't be loaded from an unseekable stream because it contains multiple icons, so point to the old favicon instead. Closes #16049.

2014-03-05 17:29 VZ, revision 76085

Add wxFD_NO_FOLLOW style for wxFileDialog. This style tells the dialog to return the paths of the link being selected without dereferencing it. Currently only implemented under wxMSW as the links are not dereferenced by default in wxGTK anyhow. But we may want to change this and implement it there too for consistency in the future. Closes #15429.

2014-03-05 17:29 VZ, revision 76084

Another compilation fix for wxUniv/MSW build. This should have been part of r76077, see #16039.

2014-03-05 00:57 VZ, revision 76082

Fix initializing bitmaps from DIB in wxMSW code. Don't call wxDIB::CreatePalette() on an invalid (because its handle had been detached from it) DIB object. Also add some comments to explain this code a bit better. Closes #16045.

2014-03-05 00:57 VZ, revision 76081

Fix initializing bitmaps from DIB in wxMSW code. Don't call wxDIB::CreatePalette() on an invalid (because its handle had been detached from it) DIB object. Also add some comments to explain this code a bit better. Closes #16045.

2014-03-04 15:20 VZ, revision 76080

Fix bug in vertical toolbar size calculation in wxMSW. Correct the changes of the r76035 to avoid using separators when calculating the fitting width of the vertical toolbars as this doesn't always work correctly. Closes #3788.

2014-03-04 15:17 VZ, revision 76079

Fix bug in vertical toolbar size calculation in wxMSW. Correct the changes of the r76034 to avoid using separators when calculating the fitting width of the vertical toolbars as this doesn't always work correctly. Closes #3788.

2014-03-04 15:07 VZ, revision 76078

Don't accept data in unsupported format in wxMSW dnd code. We wrongly pretended to accept the data in formats which we didn't actually accept and showed misleading cursors to the user. Fix this by partially reverting some of the changes of r72668 (see #14697). Closes #16042.

2014-03-04 15:07 VZ, revision 76077

Compilation fix for wxUniv/MSW in wxTLW code dealing with menus. The code used by WM_INITMENUPOPUP and WM_EXITMENULOOP handlers shouldn't be used in wxUniv build as it's not used there anyhow and doesn't even compile. Closes #16039.

2014-03-04 15:07 VZ, revision 76076

Don't accept data in unsupported format in wxMSW dnd code. We wrongly pretended to accept the data in formats which we didn't actually accept and showed misleading cursors to the user. Fix this by partially reverting some of the changes of r72668 (see #14697). Closes #16042.

2014-03-03 16:27 VZ, revision 76074

Romanian translations update from Catalin for 3.0.1.

2014-03-03 15:21 VZ, revision 76073

Romanian translations update from Catalin.

2014-03-03 08:04 SC, revision 76072

cleanup, see #15600

2014-03-03 00:46 VZ, revision 76071

Update wxForum URL in documentation overview.

2014-03-03 00:40 VZ, revision 76070

Add a one liner script to show symbols exported from a DLL. This is useful to check if ABI wasn't accidentally broken between two micro wxMSW releases.

2014-03-03 00:40 VZ, revision 76069

Remove non-existent wx/cairo.h from MSVC{11,12} projects. This file resulted in never ending rebuilds of the core project as MSVS tried to recreate the missing dependency (and failed). See http://blogs.msdn.com/b/andrewarnottms/archive/2012/06/07/enable-c-and-javascript-project-system-tracing.aspx for help with debugging such problems in the future.

2014-03-03 00:40 VZ, revision 76068

Enable debug information in release configuration of MSVC{11,12} projects. We want to generate debug information even in the release builds of the libraries in order to allow debugging of the programs using them. This is especially important for the DLLs but do it for the static release build too for consistency. This also almost fixes the constant rebuilding of the entire solution which happened because the PDBs, supposed to be generated by linker, were not found because they were not actually created as the debug information wasn't there. See #15780.

2014-03-03 00:40 VZ, revision 76067

Add missing XRC handlers to the manual VC{11,12} projects. XRC handler in aui, ribbon and richtext libraries were omitted in the initial versions of the projects for some reason. See #15780.

2014-03-03 00:37 VZ, revision 76066

Remove non-existent wx/cairo.h from MSVC{11,12} projects. This file resulted in never ending rebuilds of the core project as MSVS tried to recreate the missing dependency (and failed). See http://blogs.msdn.com/b/andrewarnottms/archive/2012/06/07/enable-c-and-javascript-project-system-tracing.aspx for help with debugging such problems in the future.

2014-03-03 00:37 VZ, revision 76065

Enable debug information in release configuration of MSVC{11,12} projects. We want to generate debug information even in the release builds of the libraries in order to allow debugging of the programs using them. This is especially important for the DLLs but do it for the static release build too for consistency. This also almost fixes the constant rebuilding of the entire solution which happened because the PDBs, supposed to be generated by linker, were not found because they were not actually created as the debug information wasn't there. See #15780.

2014-03-03 00:37 VZ, revision 76064

Add missing XRC handlers to the manual VC{11,12} projects. XRC handler in aui, ribbon and richtext libraries were omitted in the initial versions of the projects for some reason. See #15780.

2014-03-02 22:55 PC, revision 76063

fix for wxMiniFrame titlebar appearing blank

2014-03-02 19:58 PC, revision 76062

for GTK3, draw odd-width lines as a sharp, n-pixel wide line, rather than a fuzzy n+1-pixel wide line

2014-03-02 19:58 VZ, revision 76061

Refactor YieldFor() to avoid code duplication among the ports. Don't repeat the same code in all the ports, move it to the common base class and add a new virtual DoYieldFor() for the really port-specific code.

2014-03-02 19:27 VZ, revision 76060

Don't dispatch pending events from selective YieldFor(). Pending events list can contain events from all kinds and dispatching them from YieldFor() called to dispatch the events of some particular kind only (e.g. to redraw the window) is unexpected and wrong, e.g. it breaks some uses of wxProgressDialog, see #15799.

2014-03-02 19:07 VZ, revision 76059

Fix harmless signed/unsigned comparison warning in a test. Don't compare int with unsigned to avoid warnings that were introduced by the changes of r75936. See #15980.

2014-03-02 19:06 VZ, revision 76058

Fix harmless signed/unsigned comparison warning in a test. Don't compare int with unsigned to avoid warnings that were introduced by the changes of r75940. See #15980.

2014-03-02 17:07 VZ, revision 76057

Correct wrong version number in MSVC12 properties file. Use "30" in 3.0 branch.

2014-03-02 16:51 VZ, revision 76056

Fix off by 1 error in buffer size in wxOSX wxDropTarget code. The size of the buffer used for the data currently needs to include an extra byte for the trailing NUL. This is wrong, as it means that GetDataSize() and GetDataHere() behaviour is not consistent, but at least avoid overrunning the buffer for now. Also use wxCharBuffer instead of raw char array to make the code safer (both because it releases the memory automatically and because it also adds an extra byte for the trailing NUL automatically as well, making such bugs impossible). See #15914.

2014-03-02 16:51 VZ, revision 76055

Implement support for wxGA_VERTICAL style in wxOSX. Rotate the native control to make it look correct in vertical orientation. Closes #15682.

2014-03-02 16:51 VZ, revision 76054

Fix harmless signed/unsigned comparison warning in wxOSX wxJoystick. A better fix would probably be to make wxJoystick::GetNumberAxes() return an unsigned value.

2014-03-02 16:51 VZ, revision 76053

Remove redundant comparison of unsigned value with 0. This is always true and so is unnecessary.

2014-03-02 16:51 VZ, revision 76052

Really fix using install_name_tool with wxrc under OS X. Don't test for USE_XRC before it is set, correcting the wrong change of r75845. See #15946.

2014-03-02 16:51 VZ, revision 76051

Don't crash in wxOSX wxDataViewChoiceRenderer if selection was cancelled. Check for the index validity and ignore the value of -1 as it is passed if the selection in the popup was cancelled. Closes #16017.

2014-03-02 16:50 VZ, revision 76050

Fix off by 1 error in buffer size in wxOSX wxDropTarget code. The size of the buffer used for the data currently needs to include an extra byte for the trailing NUL. This is wrong, as it means that GetDataSize() and GetDataHere() behaviour is not consistent, but at least avoid overrunning the buffer for now. Also use wxCharBuffer instead of raw char array to make the code safer (both because it releases the memory automatically and because it also adds an extra byte for the trailing NUL automatically as well, making such bugs impossible). See #15914.

2014-03-02 16:50 VZ, revision 76049

Implement support for wxGA_VERTICAL style in wxOSX. Rotate the native control to make it look correct in vertical orientation. Closes #15682.

2014-03-02 16:50 VZ, revision 76048

Fix harmless signed/unsigned comparison warning in wxOSX wxJoystick. A better fix would probably be to make wxJoystick::GetNumberAxes() return an unsigned value.

2014-03-02 16:50 VZ, revision 76047

Remove redundant comparison of unsigned value with 0. This is always true and so is unnecessary.

2014-03-02 16:49 VZ, revision 76046

Really fix using install_name_tool with wxrc under OS X. Don't test for USE_XRC before it is set, correcting the wrong change of r75845. See #15946.

2014-03-02 16:49 VZ, revision 76045

Don't crash in wxOSX wxDataViewChoiceRenderer if selection was cancelled. Check for the index validity and ignore the value of -1 as it is passed if the selection in the popup was cancelled. Closes #16017.

2014-03-02 14:34 VZ, revision 76044

Fix setting the label for already existing menu items with bitmaps in wxMSW. Do update the label at Windows level if we don't use MF_OWNERDRAW style, checking for IsOwnerDrawn() is wrong because the flag it tests may be set even if the item is not really owner drawn from Windows point of view. This is a mess and setting the bitmap for the existing items is still broken, but at least setting the label works now. See #9388.

2014-03-02 14:34 VZ, revision 76043

Fix loading of top to bottom BMP files in wxMSW wxBitmap. The native LoadImage() function used by wxBMPFileHandler only supports the standard bottom to top BMPs, fall back to our own implementation in wxImage wxBMPHandler if it fails to also support the top to bottom ones. Closes #13650.

2014-03-02 14:22 VZ, revision 76042

Fix setting the label for already existing menu items with bitmaps in wxMSW. Do update the label at Windows level if we don't use MF_OWNERDRAW style, checking for IsOwnerDrawn() is wrong because the flag it tests may be set even if the item is not really owner drawn from Windows point of view. This is a mess and setting the bitmap for the existing items is still broken, but at least setting the label works now. See #9388.

2014-03-02 14:06 VZ, revision 76041

Fix loading of top to bottom BMP files in wxMSW wxBitmap. The native LoadImage() function used by wxBMPFileHandler only supports the standard bottom to top BMPs, fall back to our own implementation in wxImage wxBMPHandler if it fails to also support the top to bottom ones. Closes #13650.

2014-03-01 17:48 SC, revision 76036

using a lazy translation hash map for conversion between user friendly names and postscript names, so that we get only one warning per font family. The only way to completely get rid of this would be to pre-populate the map during startup which would mean to completely iterate through all installed fonts, so it's a compromise. see #15999

2014-03-01 00:40 VZ, revision 76035

Fix calculating the size of vertical toolbar in wxMSW. Use the width of the largest toolbar item as the toolbar width, not the width of the first one. The implicit assumption that all items had the same width was wrong and resulted in items wider than the first one being truncated. Closes #3788.

2014-03-01 00:39 VZ, revision 76034

Fix calculating the size of vertical toolbar in wxMSW. Use the width of the largest toolbar item as the toolbar width, not the width of the first one. The implicit assumption that all items had the same width was wrong and resulted in items wider than the first one being truncated. Closes #3788.

2014-02-28 23:35 VZ, revision 76033

Document possible problem with unbinding functors. Unbind() may currently disconnect the wrong functor as it compares them by address. See http://thread.gmane.org/gmane.comp.lib.wxwidgets.general/81445

2014-02-28 17:16 VS, revision 76032

Fix VarArgTestCase::ArgsValidation() after r76026.

2014-02-28 17:15 VS, revision 76031

Fix VarArgTestCase::ArgsValidation() after r76027.

2014-02-27 16:46 VZ, revision 76030

Allow passing NULL buffer to wx{,F}File::{Read,Write} when count==0. If the count of bytes to read or write is 0, the buffer pointer value shouldn't matter as it's not used at all anyhow, so relax the assert and allow it to be NULL in this case. Closes #16018.

2014-02-27 16:46 VZ, revision 76029

Fix Intel compiler warnings about hiding member variables. Rename method parameters to avoid conflicts with member variables names. Closes #15971.

2014-02-27 16:46 VZ, revision 76028

Don't build wxFileSystemWatcher test if wxUSE_FSWATCHER==0. Closes #16031.

2014-02-27 16:24 VS, revision 76027

Be more permissive when validating format string arguments. Previously, the code would assert if the caller passed too many arguments to wxPrintf() or other printf-like functions. But that can happen legitimately in translations: in some languages such as Hebrew, using "1" (i.e. "%d") in the singular feels unnatural and it's better to use the word "one" and left the variadic argument unused. Relax the check not to assert in this case. This is consistent with the standard library and other implementations. Notice that gettext's msgfmt doesn't complain about this case either in the specific case of singular forms.

2014-02-27 16:23 VS, revision 76026

Be more permissive when validating format string arguments. Previously, the code would assert if the caller passed too many arguments to wxPrintf() or other printf-like functions. But that can happen legitimately in translations: in some languages such as Hebrew, using "1" (i.e. "%d") in the singular feels unnatural and it's better to use the word "one" and left the variadic argument unused. Relax the check not to assert in this case. This is consistent with the standard library and other implementations. Notice that gettext's msgfmt doesn't complain about this case either in the specific case of singular forms.

2014-02-27 16:15 JS, revision 76025

Paragraph and image layout fixes

2014-02-27 16:14 JS, revision 76024

Paragraph layout fix

2014-02-27 11:07 JS, revision 76023

Correction for wxTextAttrCollectCommonAttributes

2014-02-27 11:03 JS, revision 76022

Corrections to attribute manipulation

2014-02-25 18:55 VS, revision 76017

Fix compilation with Xcode projects (type_traits). The changes to type_traits headers detection with Clang broke Clang use with the Xcode projects. Fix this by not setting HAVE_* macros in config_xcode.h for Clang and letting defs.h detect the features. See #15915.

2014-02-25 18:54 VS, revision 76016

Fix compilation with Xcode projects (type_traits). The changes to type_traits headers detection with Clang broke Clang use with the Xcode projects. Fix this by not setting HAVE_* macros in config_xcode.h for Clang and letting defs.h detect the features. See #15915.

2014-02-25 18:38 PC, revision 76015

Index: src/generic/graphicc.cpp =================================================================== --- src/generic/graphicc.cpp (revision 76007) +++ src/generic/graphicc.cpp (working copy) @@ -1569,12 +1569,13 @@ { const wxUint32 argb = *src++; - *alpha++ = (argb & 0xff000000) >> 24; + const unsigned char a = argb >> 24; + *alpha++ = a; // Copy the RGB data undoing the pre-multiplication. - *dst++ = Unpremultiply(*alpha, (argb & 0x00ff0000) >> 16); - *dst++ = Unpremultiply(*alpha, (argb & 0x0000ff00) >> 8); - *dst++ = Unpremultiply(*alpha, (argb & 0x000000ff)); + *dst++ = Unpremultiply(a, argb >> 16); + *dst++ = Unpremultiply(a, argb >> 8); + *dst++ = Unpremultiply(a, argb); } src = rowStart + stride;

2014-02-25 18:26 VZ, revision 76014

Fix wxGenericTreeCtrl::ScrollTo() for all ports, not just wxOSX. When scrolling down, make the item being scrolled into view completely visible instead of just showing its top part. The fix was already used for wxOSX but not for the other ports for some reason, do use it everywhere as this code is generic and behaves in the same way in all ports. Also fix the wrong comments about scrolling direction.

2014-02-25 18:26 VZ, revision 76013

Add a helper function to get the last tree item to the sample. This makes the behaviour of different menu commands working with the "last item" consistent as some of them used the last root child while others used the really last item (i.e. the last child of the last child). This should have been part of r75987.

2014-02-25 18:26 VZ, revision 76012

Fix font size when using wxGraphicsContext with wxPrinterDC in wxMSW. Use pixel size which is scaled correctly by GDI+ itself instead of the size in points which is currently not scaled correctly by wx. Closes #3566.

2014-02-25 18:26 VZ, revision 76011

Define wxUSE_BOOKCTRL as 1 if wxUSE_AUI==1. wxAuiNotebook needs wxBookCtrlBase. Closes #16025.

2014-02-25 18:26 VZ, revision 76010

Add missing semicolons to the example in wxThread documentation. wxDEFINE_EVENT() needs a semicolon after it. Closes #16026.

2014-02-25 18:26 VZ, revision 76009

Fix wxGenericTreeCtrl::ScrollTo() for all ports, not just wxOSX. When scrolling down, make the item being scrolled into view completely visible instead of just showing its top part. The fix was already used for wxOSX but not for the other ports for some reason, do use it everywhere as this code is generic and behaves in the same way in all ports. Also fix the wrong comments about scrolling direction.

2014-02-25 18:12 VZ, revision 76008

Fix font size when using wxGraphicsContext with wxPrinterDC in wxMSW. Use pixel size which is scaled correctly by GDI+ itself instead of the size in points which is currently not scaled correctly by wx. Closes #3566.

2014-02-24 21:55 VZ, revision 76007

Fix loading of bitmap with non-pre-multiplied alpha in wxMSW. Detect when the bitmap file doesn't have pre-multiplied alpha and pre-multiply it ourselves when loading it in this case. Closes #12762.

2014-02-24 21:54 VZ, revision 76006

Add helper Set32bppHDIB() method to wxMSW wxBitmapRefData. No real changes, just add a helper to allow replacing the HBITMAP stored in wxBitmapRefData without changing anything else, this is going to be used in another place soon. See #12762.

2014-02-24 21:54 VZ, revision 76005

Mention that wxAuiNotebook uses native theme under wxGTK. Closes #16021.

2014-02-24 21:54 VZ, revision 76004

Clarify that there is only a single TAB traversal implementation. Don't imply that wxPanel can use either native or generic TAB traversal implementation because this is not true. Closes #16020.

2014-02-24 21:54 VZ, revision 76003

Include wxEVT_AUINOTEBOOK_PAGE_XXX in the documented interface. This facilitates automatic language bindings generation. Closes #16019.

2014-02-24 20:31 VZ, revision 76002

Tamil translations update for 3.0.1 from DINAKAR T.D.

2014-02-24 20:31 VZ, revision 76001

Tamil translations update for 3.0.1 from DINAKAR T.D.

2014-02-24 15:47 VZ, revision 76000

Mention wxDD_DIR_MUST_EXIST support in wxGTK in the change log. Document the change of r75997, see #16002.

2014-02-24 09:17 SC, revision 75999

using old code for carbon only, new code for cocoa, fixing doubly apply flip of y axis

2014-02-24 09:10 SC, revision 75998

add fix for 32 bit builds, also when wx is drawing CGContextRef is always flipped

2014-02-24 07:44 PC, revision 75997

add support for wxDD_DIR_MUST_EXIST, closes #16002

2014-02-24 02:00 PC, revision 75996

native GTK3 implementation for DrawSash()

2014-02-23 20:14 SC, revision 75995

new DrawIcon implementation, turned off by default

2014-02-23 20:11 SC, revision 75994

adding NSImage support to wxIcon on OSX, as IconRefs are on their way out, and performance under 10.9 is suffering

2014-02-23 20:02 SC, revision 75993

make sure a frozen control calls a native 'thaw' on the tlw during destruction, otherwise tlws might end up unresponsive, see #16011

2014-02-23 16:09 VZ, revision 75992

Swedish translations update for 3.0.1 from Jonas Rydberg.

2014-02-23 16:08 VZ, revision 75991

Swedish translations update for 3.0.1 from Jonas Rydberg.

2014-02-22 23:40 VZ, revision 75990

Always initialize values returned from wxGDDC::GetChar{Width,Height}(). Don't return garbage in case of error.

2014-02-22 23:40 VZ, revision 75989

Improve parameter validation in wxStream code. Replace wxASSERT_MSG()s with wxCHECK_MSG()s to ensure that we don't crash even if we are passed a NULL pointer, saying "Warning: Null pointer is about to be used" and crashing just isn't very useful in the grand scheme of things.

2014-02-22 23:39 VZ, revision 75988

Remove confusing delete from wxIdRangeManager dtor. The singleton dtor shouldn't delete the global singleton object, if this were ever really possible, it would result in an infinite recursion. And even though it was not (because ms_instance was reset to NULL before destroying the object pointed by it), this delete was still confusing and unnecessary, so remove it.

2014-02-22 23:39 VZ, revision 75987

Remove code maintaining last item from the treectrl sample. The code was buggy (e.g. it didn't update the last item correctly after executing "Append many items" menu command) and seems to be unnecessary.

2014-02-22 23:39 VZ, revision 75986

Fix harmless warnings about unused global variables. Don't define variables that we never use to fix clang warnings about them. See #15915.

2014-02-22 23:39 VZ, revision 75985

Fix Unix build using clang with g++ 4.8 headers. Don't override HAVE_TR1_TYPE_TRAITS detected by configure with HAVE_TYPE_TRAITS detected by clang __has_include() as the latter is less reliable and can return true even when the header is not actually usable, as it happens with g++ 4.8 <type_traits> in non C++11 mode. Closes #15915.

2014-02-22 23:39 VZ, revision 75984

Fix harmless warnings about unused global variables. Don't define variables that we never use to fix clang warnings about them. See #15915.

2014-02-22 23:38 VZ, revision 75983

Fix Unix build using clang with g++ 4.8 headers. Don't override HAVE_TR1_TYPE_TRAITS detected by configure with HAVE_TYPE_TRAITS detected by clang __has_include() as the latter is less reliable and can return true even when the header is not actually usable, as it happens with g++ 4.8 <type_traits> in non C++11 mode. Closes #15915.

2014-02-22 20:45 VZ, revision 75982

Use settings in wx_vcN_local.props files if they exist. Allow overriding the default build settings in local properties files for VC11 and VC12 builds. See #15780.

2014-02-22 18:26 VZ, revision 75981

Allow customizing bitmap handling in wxSVGFileDC. Provide a built-in alternative for using external files for the bitmaps in SVG: allow embedding them inside the SVG itself using "data:" URI. And also allow to define custom handlers to make the behaviour even more flexible. Closes #15968.

2014-02-22 15:54 VZ, revision 75980

Fix several rounding problems with float values in wxPropertyGrid. Loss of precision when converting floating point numbers to text and back could result in several problems, notably comparing a valid value with the minimum could fail after a round trip through wxSpinCtrl. Fix this by using a specialization of NumericValidation() handling floating point values specially and correctly. Closes #15625.

2014-02-22 15:54 VZ, revision 75979

Use symbolic attributes names in wxPropertyGrid code. No real changes, just use constants instead of hardcoding their values. See #15625.

2014-02-22 15:54 VZ, revision 75978

Allow retrieving wxPG_FLOAT_PRECISION and not just setting it. It was possible to call SetAttribute() to change this attribute value but not to get it back. Override DoGetAttribute() to also allow the latter. See #15625.

2014-02-22 15:54 VZ, revision 75977

Expose ScintillaWX DoDragEnter() and DoDragLeave() methods. These methods are needed to allow implementing alternative wxDropTargets, in addition to the already public DoDragOver(). Closes #16010.

2014-02-22 15:54 VZ, revision 75976

Document interaction of wxSplitterWindow gravity with initial size. Document the somewhat counter intuitive (but difficult to change) behaviour of the splitter when both sash position and gravity are set. See #15996.

2014-02-22 15:54 VZ, revision 75975

Fix memory leak when not finishing iteration started by wxFindFirstFile(). Memory allocated by wxFindFirstFile() was only freed when no more files could be found by wxFindNextFile(), resulting in a memory leak if the iteration was never finished. Closes #4631.

2014-02-22 15:14 VZ, revision 75974

Fix wxOSX compilation error after r75956. wxScopedArray::get() needs to be explicitly called to access the array contents as a pointer. Closes #16015.

2014-02-22 15:09 VZ, revision 75973

Chinese translations update for 3.0.1 from Jiawei Huang.

2014-02-22 15:09 VZ, revision 75972

Chinese translations update for 3.0.1 from Jiawei Huang.

2014-02-22 15:06 VZ, revision 75971

German translations update for 3.0.1 from Sebastian Walderich.

2014-02-22 15:06 VZ, revision 75970

German translations update for 3.0.1 from Sebastian Walderich.

2014-02-22 10:08 SC, revision 75969

backport of r75966, make sure a frozen control calls a native 'thaw' on the tlw during destruction, otherwise tlws might end up unresponsive, see #16011

2014-02-21 22:47 VZ, revision 75968

Basque translations update for 3.0.1 from Xabier Aramendi.

2014-02-21 22:47 VZ, revision 75967

Basque translations update for 3.0.1 from Xabier Aramendi.

2014-02-21 20:05 SC, revision 75966

make sure a frozen control calls a native 'thaw' on the tlw during destruction, otherwise tlws might end up unresponsive, see #16011

2014-02-21 18:15 VZ, revision 75965

Ukrainian translations update for 3.0.1 from Yuri Chornoivan.

2014-02-21 18:15 VZ, revision 75964

Ukrainian translations update for 3.0.1 from Yuri Chornoivan.

2014-02-21 17:28 VZ, revision 75963

French translations update for 3.0.1 from Xavier Perrissoud. Apply to the trunk as well. See #16013.

2014-02-21 17:27 VZ, revision 75962

Regenerate all .po files in the trunk too. Bring them (more) in sync with 3.0 branch.

2014-02-21 17:22 VZ, revision 75961

French translations update for 3.0.1 from Xavier Perrissoud. Closes #16013.

2014-02-21 14:55 VZ, revision 75960

Regenerate message catalogs for 3.0.1 release. Add a couple of new strings which have been added since 3.0.0.

2014-02-21 01:51 VZ, revision 75959

Fix memory leak in wxRibbonToolBar in case of error. Use wxScopedPtr to ensure the tool is not leaked, even if we fail to insert it.

2014-02-21 01:51 VZ, revision 75958

Fix uninitialized variable use in wxPropertyGrid code. wxPGProperty::GetItemAtY() uses its input/output "nextItem" parameter, so it must be initialized before calling it.

2014-02-21 01:51 VZ, revision 75957

Ensure we don't read invalid memory in wxOSX wxDisplay code. Replace wxASSERT() with wxCHECK_MSG() to ensure that we don't read beyond the end of the array even if we are given an invalid index.

2014-02-21 01:51 VZ, revision 75956

Fix memory leak on error return in wxOSX wxDisplay code. Use wxScopedArray to ensure that memory is freed, even if wxCHECK_MSG() condition fails.

2014-02-21 01:51 VZ, revision 75955

Fix memory leak in case of error in wxOSX graphics code. Delete the pointer before returning from the function if we don't pass its ownership to CGDataProviderCreateWithData().

2014-02-21 01:51 VZ, revision 75954

Fix memory leak on error return from wxMsgCatalogFile::FillHash(). Use wxScopedPtr to make memory management simpler and to ensure that all pointers allocated in this function are deleted: this wasn't the case when we returned false earlier due to the MO file being invalid.

2014-02-21 01:51 VZ, revision 75953

No real changes, just use smart pointers in GIF decoding code. Use wxScopedArray to make the code much shorter and guarantee that it doesn't leak memory.

2014-02-21 01:51 VZ, revision 75952

Fix socket leak in Accept() in case of error.o We leaked a socket descriptor if creating the accepted socket object failed.

2014-02-21 01:51 VZ, revision 75951

Fix fall back to default resolution in wxOSX printing code. The code was written to use the default resolution if getting it from the printer failed but only handled failure of PMPrinterGetOutputResolution() and not of PMSessionGetCurrentPrinter() itself. Use default resolution if obtaining it failed for any reason (alternative could be to return error if obtaining it failed for any return...).

2014-02-21 01:51 VZ, revision 75950

Correct wxDataViewColumn::AppendXXXColumn() return value in case of failure. Don't return invalid column pointer if it was freed because actually appending it to the control failed. Fixes corresponding Coverity warnings.

2014-02-20 16:13 VZ, revision 75949

Fix crash when using wxThreadSpecificInfo from global object ctor. When not using compiler TLS support (which is the default now), TLS variable itself needs to be initialized and user-defined code in the global objects ctor could be called before this happened, resulting in using uninitialized CRITICAL_SECTION under Windows and a crash. Fix this by wrapping global wxThreadSpecificInfo itself in an accessor function ensuring that it is always initialized before use. Notice that this required adding wxTLS_TYPE_REF() as wxTLS_TYPE() itself can't be used for the function return value (__thread or similar can only be used on the variables). Closes #16009.

2014-02-20 16:12 VZ, revision 75948

Fix crash when using wxThreadSpecificInfo from global object ctor. When not using compiler TLS support (which is the default now), TLS variable itself needs to be initialized and user-defined code in the global objects ctor could be called before this happened, resulting in using uninitialized CRITICAL_SECTION under Windows and a crash. Fix this by wrapping global wxThreadSpecificInfo itself in an accessor function ensuring that it is always initialized before use. Notice that this required adding wxTLS_TYPE_REF() as wxTLS_TYPE() itself can't be used for the function return value (__thread or similar can only be used on the variables). Closes #16009.

2014-02-20 14:06 VZ, revision 75947

Use correct column type when adding columns to wxDataViewListCtrl. Using base class methods such as AppendBitmapColumn() resulted in wxDataViewListCtrl::AppendColumn() being called but this function always assumed the column was of "string" variant type -- which was, of course, false for bitmap columns and so resulted in heap corruption (thanks to the wonderfully type unsafe code using wxVariant) and a crash. Get the correct type to use from the column itself now to fix this. Closes #16008.

2014-02-20 14:05 VZ, revision 75946

Use correct column type when adding columns to wxDataViewListCtrl. Using base class methods such as AppendBitmapColumn() resulted in wxDataViewListCtrl::AppendColumn() being called but this function always assumed the column was of "string" variant type -- which was, of course, false for bitmap columns and so resulted in heap corruption (thanks to the wonderfully type unsafe code using wxVariant) and a crash. Get the correct type to use from the column itself now to fix this. Closes #16008.

2014-02-20 01:32 VZ, revision 75945

Don't show hidden MDI frames when maximizing them in wxMSW. This is inconsistent with the other ports and rather unexpected. Closes #2508.

2014-02-20 01:32 VZ, revision 75944

Don't show the MDI children implicitly by default in wxMSW any more. We kept doing it for compatibility with pre-2.5.3 versions but this was a long time ago and we don't need this any longer. See #2508.

2014-02-20 01:32 VZ, revision 75943

Fix wxCmdLineParser::Found(name) for options with values. Calling Found() without providing the second "value" argument started generating an assert since introduction of the negated options as it reused FoundSwitch() which can only be used for switches, i.e. options without values. Fix this to revert a regression since 2.8 and also add unit tests for the different Found() overloads. Closes #15986, #16001.

2014-02-20 01:32 VZ, revision 75942

Reduce code duplication in wxCmdLineParser implementation. No real changes, just extract the code for finding options from their names into a separate function instead of repeating it 4 (and 5, after the next commit changes) times.

2014-02-20 01:32 VZ, revision 75941

Don't use invalid pointer in file dialog hook procedure in wxMSW. We can receive WM_NOTIFY for other than CDN_XXX messages if we have a native control as our immediate child (which can happen with "extra" controls) and the LPARAM is not a pointer to OFNOTIFY at all in this case, so don't try to use it as such. This fixes a crash when adding a "bare" extra control, see #16003.

2014-02-20 01:32 VZ, revision 75940

Fix wxTextCtrl contents corruption with long strings in wxMSW. wxMSW automatically extended wxTextCtrl length limit beyond the tiny standard 32KB when it was exceeded, but part of the text being appended into the control was lost when doing it. Fix this by retrying insertion after extending the limit. Closes #15980.

2014-02-20 01:31 VZ, revision 75939

Fix wxCmdLineParser::Found(name) for options with values. Calling Found() without providing the second "value" argument started generating an assert since introduction of the negated options as it reused FoundSwitch() which can only be used for switches, i.e. options without values. Fix this to revert a regression since 2.8 and also add unit tests for the different Found() overloads. Closes #15986, #16001.

2014-02-20 01:31 VZ, revision 75938

Reduce code duplication in wxCmdLineParser implementation. No real changes, just extract the code for finding options from their names into a separate function instead of repeating it 4 (and 5, after the next commit changes) times.

2014-02-20 01:31 VZ, revision 75937

Don't use invalid pointer in file dialog hook procedure in wxMSW. We can receive WM_NOTIFY for other than CDN_XXX messages if we have a native control as our immediate child (which can happen with "extra" controls) and the LPARAM is not a pointer to OFNOTIFY at all in this case, so don't try to use it as such. This fixes a crash when adding a "bare" extra control, see #16003.

2014-02-20 01:31 VZ, revision 75936

Fix wxTextCtrl contents corruption with long strings in wxMSW. wxMSW automatically extended wxTextCtrl length limit beyond the tiny standard 32KB when it was exceeded, but part of the text being appended into the control was lost when doing it. Fix this by retrying insertion after extending the limit. Closes #15980.

2014-02-19 21:38 SC, revision 75935

backport of r75934, misplaced the orderOut: , see #15998, #15902

2014-02-19 21:24 SC, revision 75934

misplaced the orderOut: , see #15998, #15902

2014-02-19 15:52 VZ, revision 75933

Set model pointer in wxDataViewEvents generated under wxOSX. Add missing SetModel() calls. Closes #16004.

2014-02-19 15:51 VZ, revision 75932

Set model pointer in wxDataViewEvents generated under wxOSX. Add missing SetModel() calls. Closes #16004.

2014-02-19 00:36 VZ, revision 75930

Move DSS_HIDEPREFIX fallback definition to the central header. Do it only once now that it's used in 3 different places (it recently started to be used in src/msw/anybutton.cpp as well) instead of defining it thrice. This also fixes MinGW build.

2014-02-19 00:36 VZ, revision 75929

Move DSS_HIDEPREFIX fallback definition to the central header. Do it only once now that it's used in 3 different places (it recently started to be used in src/msw/anybutton.cpp as well) instead of defining it thrice. This also fixes MinGW build.

2014-02-18 18:47 SC, revision 75928

backport of r15902

2014-02-18 16:44 VZ, revision 75927

Mention the addition of VC{11,12} solution files in the change log. This is an important thing for a lot of people.

2014-02-18 16:43 VZ, revision 75926

Add projects for MSVC 11 and 12 (MSVS 2012 and 2013). Add manually created projects for now, as it looks that we are not going to have bakefile-generated ones any time soon. Closes #15780.

2014-02-18 16:40 VZ, revision 75925

Add projects for MSVC 11 and 12 (MSVS 2012 and 2013). Add manually created projects for now, as it looks that we are not going to have bakefile-generated ones any time soon. Closes #15780.

2014-02-18 16:14 VZ, revision 75924

Fix transparency in toolbar buttons when not using comctl32.dll v6. Old versions of comctl32.dll don't support alpha in the toolbar image list, so use the masks only for them. This is a backport of r75785, r75794 and r75923 from trunk. Closes #2609.

2014-02-18 16:13 VZ, revision 75923

Compilation fix for wxUSE_IMAGE==0 wxMSW build. Declare the variable used in any case outside of wxUSE_IMAGE-only block. See #2609.

2014-02-18 16:09 VZ, revision 75922

Don't delete child controls when deleting wxStaticBoxSizer. This is an incompatible change compared to 2.8 which can make the existing code crash and it also goes against the usual rule that the windows are never owned by sizers, only other windows. Closes #15698.

2014-02-18 16:08 VZ, revision 75921

Don't delete child controls when deleting wxStaticBoxSizer. This is an incompatible change compared to 2.8 which can make the existing code crash and it also goes against the usual rule that the windows are never owned by sizers, only other windows. Closes #15698.

2014-02-18 16:05 VZ, revision 75920

Add support for fixed spacers and labels to wxAuiToolBar XRC handler. Allow specifying "width" and "proportion" attributes for the "space" elements and add "label" element support. Closes #15964.

2014-02-18 14:13 SC, revision 75919

backport of r75899

2014-02-18 11:09 SC, revision 75918

fixing nested modal sessions, part 2, see #15902

2014-02-18 00:55 VZ, revision 75917

Add missing bounding box calculations in wxMSW wxDC code. Update the bounding box when drawing bitmaps (in one of several possible ways) and gradients. Closes #2132.

2014-02-18 00:55 VZ, revision 75916

Improve disabled buttons appearance in wxMSW when not using themes. Owner drawn buttons were not drawn in the same way as normal ones when they were disabled, use Win32 DrawState() to do it now to achieve the correct appearance. Closes #11746.

2014-02-18 00:55 VZ, revision 75915

Fix crash in wxMSW wxFileSystemWatcher when removing the same path twice. Starting to watch a path, stopping to watch it, starting to watch it again and stopping again resulted in a crash in wxMSW wxFileSystemWatcher implementation because the watcher object wasn't kept artificially kept alive when it was stopped for the second time. This happened because our way of keeping it alive was to store it in a hash map indexed by path, but if a watcher for the same path (added there when this path was first unwatched) was already present in the map, the watcher wasn't added to it and not kept alive. Fix this by using a vector instead of a map. We obviously sacrifice quick access to it by path but at least this doesn't crash any more. And we could actually still use a map, just indexed by the (unique) pointer to the object stored inside wxSharedPtr itself, and not its path. But a vector might be a more efficient data structure in practice, if we keep it from becoming too big as we should try to do by triggering artificial port completions when a watch is removed. At any rate, at least the crash is fixed for now. Closes #15995.

2014-02-18 00:55 VZ, revision 75914

Allow waiting for thread termination even without wxTheApp in wxMSW. Attempts to wait for thread termination after wxTheApp was destroyed resulted in an error in wxMSW since 2.9.something whereas it used to work in 2.8 and also generally makes sense to be allowed. So do make this work again by falling back to the simple non-interruptible wait for thread if we don't have the application object any more. Closes #13391.

2014-02-18 00:55 VZ, revision 75913

Fix handling of wxTEXT_ATTR_EFFECT_SMALL_CAPITALS in wxRichTextFontPage. Due to a typo when copy-and-pasting code wrong control was being updated. It would be better to have a function updating the given control from the given flag, of course, but for now just fix the bug. Closes #15990.

2014-02-18 00:55 VZ, revision 75912

Fix fallback format index in wxPropertyGetter wxUIntProperty code. Don't crash by accessing an out of bands array element if the format string index had been set to an invalid value, just use the default (decimal) format in this case. Closes #15984.

2014-02-18 00:55 VZ, revision 75911

Use symbolic constants in wxPropertyGrid wxUIntProperty code. No real changes, just use symbolic constants instead of hard coded magical constants. The code is still difficult to understand but slightly better than before.

2014-02-18 00:53 VZ, revision 75910

Add "const" to the recently added wxRTC XPM. This fixes half a page of warnings about converting string constants to non-const char* from g++.

2014-02-18 00:53 VZ, revision 75909

Add missing bounding box calculations in wxMSW wxDC code. Update the bounding box when drawing bitmaps (in one of several possible ways) and gradients. Closes #2132.

2014-02-18 00:53 VZ, revision 75908

Improve disabled buttons appearance in wxMSW when not using themes. Owner drawn buttons were not drawn in the same way as normal ones when they were disabled, use Win32 DrawState() to do it now to achieve the correct appearance. Closes #11746.

2014-02-18 00:53 VZ, revision 75907

Speed up wxHtmlHelpWindow startup time by freezing font choices. Appending the names of all fonts could take a significant amount of time if there were a lot of them, freeze the controls while doing it to speed it up. Closes #15978.

2014-02-18 00:53 VZ, revision 75906

Set wxHtmlHelpFrame title format before creating it. This ensures that it's always set before it can be used, fixing assert introduced in r75748. Closes #15977.

2014-02-18 00:53 VZ, revision 75905

Fix crash in wxMSW wxFileSystemWatcher when removing the same path twice. Starting to watch a path, stopping to watch it, starting to watch it again and stopping again resulted in a crash in wxMSW wxFileSystemWatcher implementation because the watcher object wasn't kept artificially kept alive when it was stopped for the second time. This happened because our way of keeping it alive was to store it in a hash map indexed by path, but if a watcher for the same path (added there when this path was first unwatched) was already present in the map, the watcher wasn't added to it and not kept alive. Fix this by using a vector instead of a map. We obviously sacrifice quick access to it by path but at least this doesn't crash any more. And we could actually still use a map, just indexed by the (unique) pointer to the object stored inside wxSharedPtr itself, and not its path. But a vector might be a more efficient data structure in practice, if we keep it from becoming too big as we should try to do by triggering artificial port completions when a watch is removed. At any rate, at least the crash is fixed for now. Closes #15995.

2014-02-18 00:53 VZ, revision 75904

Allow waiting for thread termination even without wxTheApp in wxMSW. Attempts to wait for thread termination after wxTheApp was destroyed resulted in an error in wxMSW since 2.9.something whereas it used to work in 2.8 and also generally makes sense to be allowed. So do make this work again by falling back to the simple non-interruptible wait for thread if we don't have the application object any more. Closes #13391.

2014-02-18 00:53 VZ, revision 75903

Fix handling of wxTEXT_ATTR_EFFECT_SMALL_CAPITALS in wxRichTextFontPage. Due to a typo when copy-and-pasting code wrong control was being updated. It would be better to have a function updating the given control from the given flag, of course, but for now just fix the bug. Closes #15990.

2014-02-18 00:52 VZ, revision 75902

Fix fallback format index in wxPropertyGetter wxUIntProperty code. Don't crash by accessing an out of bands array element if the format string index had been set to an invalid value, just use the default (decimal) format in this case. Closes #15984.

2014-02-18 00:52 VZ, revision 75901

Use symbolic constants in wxPropertyGrid wxUIntProperty code. No real changes, just use symbolic constants instead of hard coded magical constants. The code is still difficult to understand but slightly better than before.

2014-02-18 00:52 VZ, revision 75900

Document wxTopLevelWindow::Restore(). This was never documented, probably because it's not actually very clear to understand what exactly does it do.

2014-02-17 20:13 SC, revision 75899

fixing nested modal sessions

2014-02-17 17:25 PC, revision 75898

avoid potential NULL pointer dereference, closes #15993

2014-02-17 17:25 PC, revision 75897

fix ordering of function parameters, closes #15985

2014-02-17 15:54 JS, revision 75896

Fixed floating object layout when there is only a short text string in the paragraph

2014-02-17 15:54 JS, revision 75895

Fixed floating object layout when there is only a short text string in the paragraph

2014-02-16 21:05 JS, revision 75894

Removed rounding that didn't work for negative numbers

2014-02-16 21:05 JS, revision 75893

Removed rounding that didn't work for negative numbers; added ability to hide "move object" controls

2014-02-16 12:41 JS, revision 75892

Compile fix

2014-02-15 19:14 PC, revision 75888

mimic wxMSW wxSetCursorEvent propagation behavior, closes #15801

2014-02-15 19:11 JS, revision 75887

Sizing fix in wxRichTextImage::LoadImageCache

2014-02-15 17:59 VS, revision 75886

OS X: fix startup sequence when restoring session on >=10.7. Make sure that OnInit() is called before MacReopenApp(). This is normally the case, but it is possible for it to be called as the first thing. This can happen when OS X restores running apps when starting a new user session. Apps that were hidden (dock only) when the previous session terminated are only restored in a limited, resources-saving way - the event loop is running, but didn't call anything in the app delegate yet. When the user clicks the icon, applicationShouldHandleReopen: is called, but we didn't call OnInit() yet. In this case, we shouldn't call MacReopenApp(), but should proceed with normal initialization.

2014-02-15 17:59 VS, revision 75885

OS X: fix startup sequence when restoring session on >=10.7. Make sure that OnInit() is called before MacReopenApp(). This is normally the case, but it is possible for it to be called as the first thing. This can happen when OS X restores running apps when starting a new user session. Apps that were hidden (dock only) when the previous session terminated are only restored in a limited, resources-saving way - the event loop is running, but didn't call anything in the app delegate yet. When the user clicks the icon, applicationShouldHandleReopen: is called, but we didn't call OnInit() yet. In this case, we shouldn't call MacReopenApp(), but should proceed with normal initialization.

2014-02-15 17:19 JS, revision 75884

Optimized wxRTC insertion and deletion when floating objects are present.

2014-02-13 17:47 PC, revision 75883

avoid setting negative window size, see #15976

2014-02-13 17:46 PC, revision 75882

avoid forcing a paint on a window with zero size, see #15976

2014-02-13 13:32 JS, revision 75881

Added ability to disable images in wxRTC for performance or image corruption reasons

2014-02-13 13:01 JS, revision 75880

Corrected wxTextBoxAttr::IsDefault() implementation

2014-02-13 13:00 JS, revision 75879

Corrected wxTextBoxAttr::IsDefault() implementation

2014-02-13 12:57 JS, revision 75878

Border drawing corrections

2014-02-13 12:47 JS, revision 75877

Fixed a bug that prevented floating objects from being updated correctly

2014-02-13 12:46 JS, revision 75876

Fixed a bug that prevented floating objects from being updated correctly

2014-02-12 14:15 VZ, revision 75875

Provide more detailed deprecation message for wxFont ctor. Be more clear about how should the code be changed. Closes #15972.

2014-02-10 18:32 PC, revision 75867

finish setting size before sending wxMoveEvent

2014-02-10 18:25 PC, revision 75866

remove stuff that is already done by gtk_window_set_transient_for()

2014-02-10 18:11 PC, revision 75865

generate wxMoveEvent from wxPopupWindow::DoSetSize()

2014-02-09 20:53 PC, revision 75864

add missing GTK3 implementations of GTKGetWindow()

2014-02-09 19:36 PC, revision 75863

emit signal by id instead of name

2014-02-09 19:15 PC, revision 75862

get non-default wxTextCtrl cursors working with GTK3

2014-02-09 17:49 PC, revision 75861

Use "state-flags-changed" signal with GTK3, deprecated "state-changed" is ignored.

2014-02-09 14:40 VZ, revision 75858

Extract private methods when generating documentation too. The only private methods appearing in interface/wx/*.h files are meant to be documented, so do extract them. This should fix wxThread::OnExit() not appearing in the generated documentation, for example.

2014-02-08 15:12 VZ, revision 75846

Fix wxToolBar size in wxMSW when not using icons. There were several problems when the toolbar style was toggled to not show icons, fix them by adding missing checks for wxTB_NOICONS style. Closes #13578.

2014-02-08 15:12 VZ, revision 75845

Fix build under OS X with --disable-xrc. Don't try to change the install names in non-existent (in this case) wxrc. Closes #15946.

2014-02-08 15:04 VZ, revision 75844

Fix build under OS X with --disable-xrc. Don't try to change the install names in non-existent (in this case) wxrc. Closes #15946.

2014-02-08 12:55 JS, revision 75843

Return true from GetRangeSize or partial extents will be incorrectly filled in

2014-02-08 12:55 JS, revision 75842

Return true from GetRangeSize or partial extents will be incorrectly filled in

2014-02-08 01:46 VZ, revision 75839

Don't show "deleted stale lock file" message by default. The user typically can't do anything about this error anyhow, so don't show it by default. Still do show it when running in the verbose mode as this might add diagnosing the problem when something goes unexpectedly wrong. Closes #15944.

2014-02-08 01:46 VZ, revision 75838

Don't show "deleted stale lock file" message by default. The user typically can't do anything about this error anyhow, so don't show it by default. Still do show it when running in the verbose mode as this might add diagnosing the problem when something goes unexpectedly wrong. Closes #15944.

2014-02-08 01:43 VZ, revision 75837

Don't use try/catch if exceptions support is disabled. Closes #15954.

2014-02-08 01:41 VZ, revision 75836

Don't use try/catch if exceptions support is disabled. Closes #15954.

2014-02-07 16:02 VZ, revision 75835

Don't log error from wxMSW wxWakeUpIdle(). This is not necessary as there is nothing that can be done about this error anyhow and the function still "works" even if it occurs (it doesn't wake up anything but it is not necessary to do it if the message queue is already full) and, worse, results in a crash due to stack overflow. Closes #15951.

2014-02-07 16:02 VZ, revision 75834

Don't log error from wxMSW wxWakeUpIdle(). This is not necessary as there is nothing that can be done about this error anyhow and the function still "works" even if it occurs (it doesn't wake up anything but it is not necessary to do it if the message queue is already full) and, worse, results in a crash due to stack overflow. Closes #15951.

2014-02-07 15:35 VZ, revision 75833

Avoid crashes when deleting owned top level windows. Don't delay the TLW destruction if it has a parent and its parent is already being deleted: we can't delay the inevitable in this case and only succeed in making the program crash if we try. Closes #15743.

2014-02-07 15:35 VZ, revision 75832

Fix exit on last TLW logic after the change of r75630. The changes in this revision meant to prevent the closure of transient dialogs from quitting the application (see #15880) prevented any application using AUI, including the aui sample, from exiting as the AUI utility frames deleted during the main frame destruction were returning false from their IsLastBeforeExit() now. Fix this by relaxing the check and ignoring the parent if it is already being deleted anyhow -- in this case there is no danger of closing it accidentally. Closes #15894.

2014-02-06 18:27 PC, revision 75826

Don't update position variables from window dragging code. Let "configure-event" handler do it so it can also generate proper move events. closes #15904

2014-02-06 16:10 VZ, revision 75825

Revert "Add XRC handler file to MSVC 10 project." This reverts r75789 which shouldn't have been applied to 3.0 branch as the files added to the project don't exist in it. Closes #15942.

2014-02-06 11:15 VS, revision 75824

Fix failing TextFileTestCase::ReadMixedWithFuzzing(). The test failed with 33% probability because it didn't account for trailing non-newline character. Fixed and also changed the test to repeat itself a hundred times, to increase the probability of catching problems like this.

2014-02-06 11:15 VS, revision 75823

Fix failing TextFileTestCase::ReadMixedWithFuzzing(). The test failed with 33% probability because it didn't account for trailing non-newline character. Fixed and also changed the test to repeat itself a hundred times, to increase the probability of catching problems like this.

2014-02-06 09:54 PC, revision 75821

Fix wxSetCursorEvent handling For compatibility with wxMSW, send event up the parent chain. Properly handle setting the cursor for a wxSetCursorEvent, and don't overwrite the window cursor. see #15801

2014-02-06 05:43 PC, revision 75807

Different fix for cursor inheritance and busy cursor/global cursor. Previous work was not compatible with GTK < 2.18 and did not properly handle some cases see #15801

2014-02-05 23:12 VZ, revision 75806

Add support for sorting by more than one column to generic wxDataViewCtrl. Maintain a list of columns used for sorting instead of a single sort column index and allow to add/remove columns to/from it interactively by right clicking them if AllowMultiColumnSort() was used. See https://github.com/wxWidgets/wxWidgets/pull/3

2014-02-05 19:29 VS, revision 75804

Add line-endings fuzzing test to TextFileTestCase. Stress-test wxTextFile's handling of unusual CR,LF characters.

2014-02-05 19:29 VS, revision 75803

Rewrite wxTextFile's newlines parsing to fix multiple bugs. Remove the complicated parsing state machine that contained bugs with unexpected inputs and was very hard to modify correctly. Replace it with much simpler code that looks ahead, instead of deducing line endings from past characters. The new code never looses lines with data and calls AddLine() on the first newline character it encounters, peeking ahead to determine the line ending type.

2014-02-05 19:29 VS, revision 75802

TextFileTestCase: test for \r\r\r\n parsing. While r75387 fixed parsing of \r\r\n, it still didn't handle triple-\r correctly.

2014-02-05 19:29 VS, revision 75801

TextFileTestCase: test for correct parsing of empty Mac lines. (This is failing both with and without r75387.)

2014-02-05 19:29 VS, revision 75800

Add line-endings fuzzing test to TextFileTestCase. Stress-test wxTextFile's handling of unusual CR,LF characters.

2014-02-05 19:28 VS, revision 75799

Rewrite wxTextFile's newlines parsing to fix multiple bugs. Remove the complicated parsing state machine that contained bugs with unexpected inputs and was very hard to modify correctly. Replace it with much simpler code that looks ahead, instead of deducing line endings from past characters. The new code never looses lines with data and calls AddLine() on the first newline character it encounters, peeking ahead to determine the line ending type.

2014-02-05 19:28 VS, revision 75798

TextFileTestCase: test for \r\r\r\n parsing. While r75387 fixed parsing of \r\r\n, it still didn't handle triple-\r correctly.

2014-02-05 19:28 VS, revision 75797

TextFileTestCase: test for correct parsing of empty Mac lines. (This is failing both with and without r75387.)

2014-02-05 12:29 JS, revision 75796

Return true from OnCellClicked if the event was processed, otherwise further processing will use default behaviour which may negate the effect of the event handler.

2014-02-05 02:04 VZ, revision 75794

Compilation fix for PCH-less build. This should fix compilation without PCH after r75785. See #2609.

2014-02-04 20:10 JS, revision 75793

Return true from OnCellClicked if the event was processed, otherwise further processing will use default behaviour which may negate the effect of the event handler.

2014-02-04 20:10 JS, revision 75792

Return true from OnCellClicked if the event was processed, otherwise further processing will use default behaviour which may negate the effect of the event handler.

2014-02-04 19:57 JS, revision 75791

Added the ability to restore the last selected page in a wxRTC formatting dialog.

2014-02-04 17:59 DS, revision 75790

Added support for wxEVT_COMBOBOX_DROPDOWN and wxEVT_COMBOBOX_CLOSEUP events to wxOSX/Cocoa. Backport of r75783. Closes #15762.

2014-02-04 17:42 VZ, revision 75789

Add XRC handler file to MSVC 10 project. Closes #15942.

2014-02-04 17:40 VZ, revision 75788

Add XRC handler file to MSVC 10 project. Closes #15942.

2014-02-04 16:59 VZ, revision 75787

Add new XRC headers to the core project too. Closes #15942.

2014-02-04 16:59 VZ, revision 75786

Allow using wxRearrangeList::Check() to change state programmatically. Previous this resulted in an assert and broken behaviour as it didn't update the internally stored state. Do update it now and remove the assert as it isn't possible to distinguish between user code calling Check() and wxGTK doing it itself from wxCheckListBox implementation. Closes #15940.

2014-02-04 16:59 VZ, revision 75785

Fix transparency in toolbar buttons when not using comctl32.dll v6. Old versions of comctl32.dll don't support alpha in the toolbar image list, so use the masks only for them. Closes #2609.

2014-02-04 16:46 VZ, revision 75784

Add new XRC headers to the core project too. Closes #15942.

2014-02-04 10:32 DS, revision 75783

Added support for wxEVT_COMBOBOX_DROPDOWN and wxEVT_COMBOBOX_CLOSEUP events to wxOSX/Cocoa. See #15762.

2014-02-04 08:37 JJ, revision 75782

correction on commit 75776

2014-02-03 21:32 SC, revision 75780

backport merging in Václav's fix for getting CPU usage down in ShowModal

2014-02-03 21:31 SC, revision 75779

merging in Václav's fix for getting CPU usage down in ShowModal

2014-02-03 18:44 SC, revision 75778

backport from trunk

2014-02-03 18:40 SC, revision 75777

passing correct timeout values, patch from Václav

2014-02-03 15:06 JJ, revision 75776

synchronizing the definition of wxLoadQueryNearestFont

2014-02-02 22:47 VZ, revision 75775

Remove unnecessary CommandStateChangeConstants enum redeclaration. This declaration conflicted with the one in the latest MinGW-W64 headers and wasn't needed anyhow as we don't use neither the enum itself nor its members in our code, so just remove it to fix the build in 64 bits with MinGW-W64 4.8. This is the backport of r75669 from trunk.

2014-02-02 02:46 VZ, revision 75772

Compilation fix after r75765. Forgot to backport ResetAlpha() addition which is used by the code of r75765.

2014-02-02 02:16 VZ, revision 75771

Restore wxBusyCursor::Get{Story,Busy}Cursor() in wxGTK. Even if these methods are completely useless, we still need to keep them in wxGTK 3.0 for ABI compatibility.

2014-02-02 02:15 VZ, revision 75770

Improve appearance of tools using bitmaps with alpha in wxMSW wxToolBar. Use alpha in the combined toolbar bitmap if any of its tools has a bitmap using alpha. This greatly improves the appearance of the automatically generated disabled images for the tools with bitmaps using alpha. See #15876.

2014-02-02 02:15 VZ, revision 75769

Fix appearance of tools with alpha bitmaps in wxMSW wxToolBar. Recent changes broke the handling of tools with alpha bitmaps as drawing them on the global toolbar bitmap changes its underlying HBITMAP now, but the code in wxToolBar didn't expect this. Fix it by updating the HBITMAP used after every DrawBitmap() call, just in case it changed (it doesn't cost anything to reset it if it did not). Closes #15876.

2014-02-02 02:15 VZ, revision 75768

Make wxFILTER_INCLUDE_LIST in wxTextValidator actually usable. Only check for its violation once the full text is entered as otherwise nothing could ever be entered when it was used. Closes #15778.

2014-02-02 02:15 VZ, revision 75767

Fix handling of menu items checked before being attached in wxMSW. Calling wxMenuItem::Check() before appending the item to a menu didn't have any effect, fix this by checking the item state when actually attaching it. Closes #15748.

2014-02-02 02:15 VZ, revision 75766

Prevent wxGrid rows/columns from becoming too small on double click. The minimal size wasn't respected when auto-sizing rows/columns in Set{Row,Col}Size() which was called in response to double clicking the separator line, which resulted in clearly wrong behaviour as the user was prevented from resizing the row/column to a smaller size by dragging them but not by double clicking, so fix this to respect the minimal size as well. Closes #15627.

2014-02-02 02:15 VZ, revision 75765

Fix alpha channel values when using wxGCDC with wxMemoryDC in wxMSW. Ensure that 32bpp bitmaps selected in wxMemoryDC use DIB for their internal representation as GDI+ functions don't seem to work correctly with DDBs with alpha channel. Closes #13328.

2014-02-02 02:15 VZ, revision 75764

Disable the use of compiler TLS by default under Windows. While compiler TLS support is simpler to use and much faster than using our own Win32 API-based TLS implementation, it results in difficult to debug crashes when used inside a dynamically loaded DLL under Windows XP, so disable it by default to be safe. Closes #13116.

2014-02-02 02:15 VZ, revision 75763

Move wxCHECK_MINGW32_VERSION() declaration to wx/msw/gccpriv.h. Unfortunately we can't keep it in wx/compiler.h which is included too early, before UNICODE macro is defined, and we can't define it before including wx/setup.h which itself must be included after wx/compiler.h. So move it to wx/msw/gccpriv.h which is not a great solution, as the best would be to get rid of this gcc-specific file completely, but at least should make everything build again and ensure that _mingw.h is included after UNICODE definition. Closes #15798.

2014-02-01 22:01 PC, revision 75761

don't avoid no-window widgets in GTKUpdateCursor() it doesn't work for things like multi-line text control where m_widget is a no-window GtkScrolledWindow

2014-02-01 21:05 PC, revision 75760

fix running with GTK < 2.18 when built with later GTK

2014-02-01 19:26 PC, revision 75759

restore non-default cursors in native widgets when unsetting wxCursor

2014-02-01 19:22 VZ, revision 75758

Recompute the tooltip width when changing its text in wxMSW. This avoids unnecessarily wrapping the tooltips if they are set to a longer string than their initial value later. Closes #4685.

2014-02-01 19:18 VZ, revision 75757

Don't show windows with "hidden" XRC attribute at all. This is better than showing them initially and then hiding them if only because it avoids the unexpected wxEVT_SHOW events being generated. Closes #15919.

2014-02-01 19:18 VZ, revision 75756

Recompute the tooltip width when changing its text in wxMSW. This avoids unnecessarily wrapping the tooltips if they are set to a longer string than their initial value later. Closes #4685.

2014-02-01 18:08 PC, revision 75755

don't override non-default cursors in native controls when no wxCursor is set, a regression introduced by r75690

2014-02-01 11:39 TIK, revision 75754

Add Kabyle language, as rare language it uses a three-letter code as per ISO 639-2.

2014-02-01 11:39 TIK, revision 75753

Add Kabyle language, as rare language it uses a three-letter code as per ISO 639-2.

2014-02-01 11:39 TIK, revision 75752

Add Kabyle language, as rare language it uses a three-letter code as per ISO 639-2.

2014-01-31 20:33 VZ, revision 75751

Use automatic resource management in wxMSW wxDC::DrawRotatedText(). No real changes, just simplify the code by using RAII classes. Also avoid unnecessary indentation by returning after checking for the special cases.

2014-01-31 20:33 VZ, revision 75750

Support multiline strings in wxDC::DrawRotatedText() in wxMSW. The native API doesn't support this, so do it by splitting the string into lines manually. Closes #9686.

2014-01-31 19:26 PC, revision 75749

build fix for GTK3, see #15930

2014-01-31 17:06 VZ, revision 75748

Try to detect invalid wxHtmlWindow title format earlier. Assert directly in wxHtmlWindow::SetRelatedFrame() instead of doing it much later, hopefully people will read the comment at the assert point.

2014-01-30 20:40 VZ, revision 75747

Add xh_ribbon.cpp to MSVC 10 ribbon library project. Fix linking errors when using wxRibbonXmlHandler. Closes #15927.

2014-01-30 20:40 VZ, revision 75746

Reduce the number of realloc() calls in wxHtmlTableCell. Don't call realloc() after adding each row, this is horribly inefficient, so preallocate more memory to avoid this. Closes #15931.

2014-01-30 20:40 VZ, revision 75745

Correctly detect cancelled drag-and-drop operations in wxGTK. The status of the drop operation wasn't propagated back to the initiator of drag and drop, so failing to drop data over a possibly accepting recipient could result in wrong behaviour and even data loss. Closes #15930.

2014-01-30 20:40 VZ, revision 75744

Deprecate wxTipProvider::PreprocessTip(). It is completely useless, and there is no reason to keep it. Closes #15916.

2014-01-30 20:14 VZ, revision 75743

Add xh_ribbon.cpp to MSVC 10 ribbon library project. Fix linking errors when using wxRibbonXmlHandler. Closes #15927.

2014-01-30 19:58 VZ, revision 75742

Reduce the number of realloc() calls in wxHtmlTableCell. Don't call realloc() after adding each row, this is horribly inefficient, so preallocate more memory to avoid this. Closes #15931.

2014-01-30 04:32 VZ, revision 75741

Update copyright year in the library versions. Update the version info dialog and the version info included in MSW DLLs.

2014-01-29 23:29 VZ, revision 75740

Don't mark wxMSW applications as being DPI aware. Because they are not, fully. While our standard controls do appear correctly in any DPI, anything using bitmaps/icons (e.g. toolbars, AUI title bars, ...) isn't usable at all without scaling at high DPI, so it's better to avoid pretending that we're DPI aware at all rather than doing it without being it for 100%. This reverts the changes of r63990.

2014-01-29 23:26 VZ, revision 75739

Fix a bug which could result in two default buttons in wxMSW dialogs. Exchange the order of setting/resetting the new/old button as the default one when focus is lost/gained to avoid the possibility of having two simultaneously default buttons at once. Closes #9528.

2014-01-29 23:25 VZ, revision 75738

Fix handling of wxSET, wxCLEAR and wxINVERT ROPs in wxMSW. Avoid passing source HDC to MaskBlt() for these ROPs which only use the destination HDC as they produce garbage instead of just ignoring the source in if it's non-NULL. Closes #2047.

2014-01-29 23:25 VZ, revision 75737

Fix wxClientDC::Clear() for scrolled windows in wxMSW. Take the DC origin into account when clearing a window DC and not only a memory one. Closes #2048.

2014-01-29 23:25 VZ, revision 75736

Fix wxPrinterDC::DrawIcon() in wxMSW. Make DrawIcon() work when printing: it previously didn't, as we used ::DrawIconEx() Windows function which wasn't supported when printing. Work around this by using DrawBitmap() if necessary. Closes #379.

2014-01-29 23:25 VZ, revision 75735

Fix display of bitmaps with alpha in wxStaticBitmap under MSW. Avoid double alpha pre-multiplication by converting the bitmap into a non pre-multiplied format before passing it to STM_SETIMAGE. Closes #2395.

2014-01-29 23:25 VZ, revision 75734

Virtualize wxXmlNode methods used by wxAuiToolBarXmlHandler. This fixes the DLL build of aui library as it can now be linked without leaving any unresolved dependencies to the code in xml library (where wxXmlNode is implemented). Closes #15686.

2014-01-29 23:25 VZ, revision 75733

Fix bug with non-NUL-terminaed inputs in wxMBConvUTF8. We read beyond the provided maximal length as we didn't update the remaining length while parsing the remaining bytes of an UTF-8-encoded code point. Fix this and add a test for it. Closes #15901.

2014-01-29 23:24 VZ, revision 75732

Fix a bug which could result in two default buttons in wxMSW dialogs. Exchange the order of setting/resetting the new/old button as the default one when focus is lost/gained to avoid the possibility of having two simultaneously default buttons at once. Closes #9528.

2014-01-29 23:24 VZ, revision 75731

Fix handling of wxSET, wxCLEAR and wxINVERT ROPs in wxMSW. Avoid passing source HDC to MaskBlt() for these ROPs which only use the destination HDC as they produce garbage instead of just ignoring the source in if it's non-NULL. Closes #2047.

2014-01-29 23:24 VZ, revision 75730

Fix wxClientDC::Clear() for scrolled windows in wxMSW. Take the DC origin into account when clearing a window DC and not only a memory one. Closes #2048.

2014-01-29 23:24 VZ, revision 75729

Fix wxPrinterDC::DrawIcon() in wxMSW. Make DrawIcon() work when printing: it previously didn't, as we used ::DrawIconEx() Windows function which wasn't supported when printing. Work around this by using DrawBitmap() if necessary. Closes #379.

2014-01-29 23:24 VZ, revision 75728

Fix bug with non-NUL-terminaed inputs in wxMBConvUTF8. We read beyond the provided maximal length as we didn't update the remaining length while parsing the remaining bytes of an UTF-8-encoded code point. Fix this and add a test for it. Closes #15901.

2014-01-29 23:24 VZ, revision 75727

Fix display of bitmaps with alpha in wxStaticBitmap under MSW. Avoid double alpha pre-multiplication by converting the bitmap into a non pre-multiplied format before passing it to STM_SETIMAGE. Closes #2395.

2014-01-28 17:52 VZ, revision 75725

Fix embarrassing typo in the last commit.

2014-01-28 14:45 VZ, revision 75724

Add forward declaration of wxCmdLineParser to fix compilation. This should fix the build after the previous commit.

2014-01-28 14:04 VZ, revision 75723

Allow iterating over wxCmdLineParser arguments in order. This allows the meaning of the options to depend on their order relatively to the other options which wasn't possible before. See http://review.bakefile.org/r/557/

2014-01-27 08:53 RD, revision 75718

Add some of the Draw* methods that have been available in wxPython.

2014-01-27 08:50 RD, revision 75716

Add some of the Draw* methods that have been available in wxPython.

2014-01-26 17:24 VZ, revision 75715

Try rounding the values when resizing wxImage instead of truncating. This would seem to make more sense and might also fix the test failures resulting from tiny differences in arithmetic operations when compiled with different compilers/under different architectures. Regenerate the test files and commit (disabled) change to the unit test allowing to do it again in the future.

2014-01-26 15:08 VZ, revision 75714

Don't keep dangling pointers in other wxRibbonButtonBar members neither. This should have been part of r75710: after deleting the button, also reset any stored pointers to it. Closes #15909.

2014-01-26 15:08 VZ, revision 75713

Fix `wx-config --libs` in monolithic build. Don't include non-existent libraries (which are built as part of the main monolithic one) in this case. Closes #15567.

2014-01-26 14:52 VZ, revision 75712

Fix `wx-config --libs` in monolithic build. Don't include non-existent libraries (which are built as part of the main monolithic one) in this case. Closes #15567.

2014-01-25 18:39 VZ, revision 75711

Don't leave dandling pointers in wxDataViewCtrl in wxOSX. The previous m_ModelNotifier became invalid but wasn't always replaced with a valid one, resulting in a crash due to the use of an invalid pointer. Closes #15910.

2014-01-25 18:39 VZ, revision 75710

Delete the button object in wxRibbonButtonBar::DeleteButton(). Unlike ClearButtons(), DeleteButton() didn't actually delete the button. Fix this and document this behaviour. Closes #15909.

2014-01-25 18:38 VS, revision 75709

Fix improper NSGraphicsContext handling in wxOSXCreateBitmapContextFromNSImage. Don't leave currentContext set to the temporary context indefinitely, but restore the previous one when done. It's apparent from the code that this is how it was meant to be done. Not doing this can result in strange, insanely hard to debug errors in completely unrelated places, because OS X (at least < 10.9) reuses a pool of contexts. For example, this change fixes Quicklook crashes in file open panel on 10.8. For detailed explanation, see the lengthy discussion at https://code.google.com/p/chromium/issues/detail?id=90140

2014-01-25 18:38 VS, revision 75708

Fix improper NSGraphicsContext handling in wxOSXCreateBitmapContextFromNSImage. Don't leave currentContext set to the temporary context indefinitely, but restore the previous one when done. It's apparent from the code that this is how it was meant to be done. Not doing this can result in strange, insanely hard to debug errors in completely unrelated places, because OS X (at least < 10.9) reuses a pool of contexts. For example, this change fixes Quicklook crashes in file open panel on 10.8. For detailed explanation, see the lengthy discussion at https://code.google.com/p/chromium/issues/detail?id=90140

2014-01-25 18:28 VZ, revision 75707

Don't leave dandling pointers in wxDataViewCtrl in wxOSX. The previous m_ModelNotifier became invalid but wasn't always replaced with a valid one, resulting in a crash due to the use of an invalid pointer. Closes #15910.

2014-01-24 22:08 SC, revision 75700

backport, fixes memory leak

2014-01-24 22:07 SC, revision 75699

backport, fixes normalization

2014-01-24 21:27 SC, revision 75698

make things work as advertised

2014-01-24 20:55 SC, revision 75697

fixing memory leak

2014-01-24 19:29 PC, revision 75696

fix GetBordersForSizer(), closes #15872

2014-01-23 22:02 JS, revision 75693

Added an optimisation when the control is frozen

2014-01-23 22:01 JS, revision 75692

Added an optimisation when the control is frozen

2014-01-23 19:37 PC, revision 75691

remove some debugging code inadvertently checked in as part of r75690

2014-01-23 19:27 PC, revision 75690

Fix cursor inheritance and busy cursor/global cursor, closes #15801

2014-01-23 06:54 PC, revision 75689

use the more appropriate letter 'h' for height

2014-01-23 06:47 PC, revision 75688

fix a couple GTK assertions about setting negative sizes, closes #15891

2014-01-23 05:46 PC, revision 75687

fix wxPopupTransientWindow mouse events with GTK3, also fixes wxOwnerDrawnComboBox, wxDatePickerCtrl. closes #15874

2014-01-23 01:18 RD, revision 75676

Add missing joystick methods

2014-01-23 01:17 RD, revision 75675

add SetRGB overload

2014-01-23 01:17 RD, revision 75674

Add missing joystick methods

2014-01-23 01:16 RD, revision 75673

add SetRGB overload

2014-01-22 14:10 VZ, revision 75672

Russian translations update from Dmitry Levichev.

2014-01-22 14:10 VZ, revision 75671

Russian translations update from Dmitry Levichev.

2014-01-22 05:14 PC, revision 75670

restrict fix from r75668 to GTK3 only, as it might cause flickering

2014-01-21 22:46 VZ, revision 75669

Remove unnecessary CommandStateChangeConstants enum redeclaration. This declaration conflicted with the one in the latest MinGW-W64 headers and wasn't needed anyhow as we don't use neither the enum itself nor its members in our code, so just remove it to fix the build in 64 bits with MinGW-W64 4.8.

2014-01-21 20:37 PC, revision 75668

Fix best size calculation with GTK3 GTK3 reports preferred size of hidden widgets as zero. see #15896

2014-01-21 20:32 VZ, revision 75667

Move deprecated wxFont ctor implementation out of line. Blind fix to avoid strange warnings given by OS X build slave about the ctor being deprecated when it's defined, not used.

2014-01-21 20:32 VZ, revision 75666

Add a virtual dtor to wxEventLoopSourcesManagerBase to avoid g++ warnings. This virtual dtor is not really needed as manager objects are static singletons and are not destroyed via their pointer, but add a virtual dtor just to avoid g++ warnings about its absence.

2014-01-21 19:39 VZ, revision 75665

Send events when toggling wxPropertyGrid nodes from keyboard. Closes #15899.

2014-01-21 19:39 VZ, revision 75664

Draw the selected bitmap correctly in wxMSW buttons. Clear the previously drawn bitmap before drawing the new one. Closes #12550.

2014-01-21 19:39 VZ, revision 75663

Avoid selecting invalid tab when removing last page from wxOSX wxNotebook. Closes #15897.

2014-01-20 15:45 VZ, revision 75662

Remove unnecessary redundant assignments. Don't assign values consecutively to the same variable without using it in between the assignments, this is useless. See #15893.

2014-01-20 15:45 VZ, revision 75661

Remove redundant checks from conditional statements. It is not necessary to test for the condition which is already known to be true or false because the code is inside the if statement checking it. See #15893.

2014-01-20 15:45 VZ, revision 75660

Correct wrong error handler in wxDialUpManagerMSW code. Forgot to set the success flag to false if thread creation failed. See #15893.

2014-01-20 15:45 VZ, revision 75659

Don't pass input parameter by non-const reference unnecessarily. This is confusing. See #15893.

2014-01-20 15:45 VZ, revision 75658

Don't pass ID to wxWindow::LoadNativeDialog() by reference. This is completely unnecessary and confusing. See #15893.

2014-01-20 15:45 VZ, revision 75657

Pass non-primitive types by const reference instead of value. No real changes, just avoid the unnecessary copying and also make the signatures more consistent by adding the apparently forgotten "&" in a couple of places. See #15893.

2014-01-20 15:44 VZ, revision 75656

Fix exit on last TLW logic after the change of r75633. The changes in this revision meant to prevent the closure of transient dialogs from quitting the application (see #15880) prevented any application using AUI, including the aui sample, from exiting as the AUI utility frames deleted during the main frame destruction were returning false from their IsLastBeforeExit() now. Fix this by relaxing the check and ignoring the parent if it is already being deleted anyhow -- in this case there is no danger of closing it accidentally. Closes #15894.

2014-01-20 15:44 VZ, revision 75655

Deal correctly with non-ASCII hostnames in wxGetFullHostName() in wxMSW. Somewhat surprisingly, Windows can return a non-ASCII string from gethostname(). It's not really clear what happens if the host name is not representable in the current locale encoding at all, but at least make the function work in case it is. Closes #15875.

2014-01-20 15:44 VZ, revision 75654

Ensure wxChoice reported width never becomes negative in wxMSW. Don't set the pending size to (-1, valid-height) as it is always supposed to be either fully valid or fully invalid (meaning there is no pending size change). Closes #15723.

2014-01-19 20:03 VZ, revision 75653

Work around g++ warning about comparing compatibility_iterator with NULL. Use double negation to placate both it and MSVC, see r75445.

2014-01-19 15:14 VZ, revision 75652

Use wxUSE_WXDIB in preprocessor tests. NEVER_USE_DIB is meant to be used only in conjunction with {SOMETIMES,ALWAYS}_USE_DIB constants, use wxUSE_WXDIB elsewhere. This is more logical and also fixes inadvertent use of NEVER_USE_DIB before it is defined added by the changes of r75648. See #13328.

2014-01-19 15:14 VZ, revision 75651

Exclude wxMSW-specific code from compilation under other platforms. Compilation fix after r75648, see #13328.

2014-01-19 14:16 VZ, revision 75650

Improve appearance of tools using bitmaps with alpha in wxMSW wxToolBar. Use alpha in the combined toolbar bitmap if any of its tools has a bitmap using alpha. This greatly improves the appearance of the automatically generated disabled images for the tools with bitmaps using alpha. See #15876.

2014-01-19 14:15 VZ, revision 75649

Fix appearance of tools with alpha bitmaps in wxMSW wxToolBar. Recent changes broke the handling of tools with alpha bitmaps as drawing them on the global toolbar bitmap changes its underlying HBITMAP now, but the code in wxToolBar didn't expect this. Fix it by updating the HBITMAP used after every DrawBitmap() call, just in case it changed (it doesn't cost anything to reset it if it did not). Closes #15876.

2014-01-19 14:15 VZ, revision 75648

Fix alpha channel values when using wxGCDC with wxMemoryDC in wxMSW. Ensure that 32bpp bitmaps selected in wxMemoryDC use DIB for their internal representation as GDI+ functions don't seem to work correctly with DDBs with alpha channel. Closes #13328.

2014-01-19 14:15 VZ, revision 75647

Use AssocQueryString() instead of manual accessing registry in wxMSW. AssocQueryString() is more reliable and should work under all Windows versions, including Windows 8 for which our previous implementation, reading the values directly from the registry, had some problems.

2014-01-19 14:15 VZ, revision 75646

Restore correct handling of wxDocument::OnCreate() error return value. The changes of r74515 didn't quite restore the old behaviour, the document was still not being cleaned up if its OnCreate() simply returned false and not threw an exception. Do add cleanup in this code branch too, just duplicating what we in case of exception (this duplication can't be easily avoided unfortunately). Closes #15883.

2014-01-19 14:15 VZ, revision 75645

Focus generic spin control when its spin button is pressed. This is consistent with the behaviour of the native control under MSW and GTK and generally makes sense as otherwise focus could remain on a completely unrelated control. Closes #15885.

2014-01-19 13:58 VZ, revision 75644

Fix setting fonts and colours for wxToggleButton with bitmaps in wxGTK. Apply the fixes of r54138 to wxToggleButton too, the problem of #3939 was not specific to just plain wxButtons.

2014-01-19 13:57 VZ, revision 75643

Fix setting fonts and colours for wxToggleButton with bitmaps in wxGTK. Apply the fixes of r54138 to wxToggleButton too, the problem of #3939 was not specific to just plain wxButtons.

2014-01-19 12:44 VZ, revision 75642

Fix possible crash in TAR header parsing code. Check that the iterator is valid before using its value, otherwise the validity check was useless. Closes #15888.

2014-01-19 12:39 VZ, revision 75641

Fix possible crash in TAR header parsing code. Check that the iterator is valid before using its value, otherwise the validity check was useless. Closes #15888.

2014-01-17 19:56 VZ, revision 75640

Override Do{Freeze,Thaw}() instead of {Freeze,Thaw}() in wxPropGrid code. {Freeze,Thaw}() themselves are not virtual any more, so overriding them doesn't really work and it is unnecessary to reimplement the reference counting already done by the base class anyhow, so override the DoXXX() versions instead. Closes #15877.

2014-01-17 17:50 PC, revision 75639

avoid crash with GTK3 when deleting an item, closes #15786

2014-01-17 15:33 VZ, revision 75638

Fix wrong variable name in the example in wxVariantDataSafeArray documentation. Closes #15882.

2014-01-17 15:32 VZ, revision 75637

Compilation fix for the example in wxThread documentation. Make MyThread a friend to allow it accessing the private fields of MyFrame. Notice that this example still remains badly written and should be ideally entirely redone using conditions and mutexes. See #15881.

2014-01-17 15:32 VZ, revision 75636

Fix syntax error in the QueueEvent() documentation example. Use ".", not "->", on the object. Closes #15881.

2014-01-16 22:45 VZ, revision 75635

wxWindow::SetWindowVariant() does do something under ports other than wxOSX. Document that this function adjusts the window font size under non-OS X systems and explain why it should still be used instead of changing the font size directly.

2014-01-16 22:44 VZ, revision 75634

Ensure that the help viewer keeps running as long as its main frame is opened. Do prevent the app from exiting when the help frame is shown in the special case of the help viewer application where the default behaviour of exiting the application when only the help window remains open is inappropriate and results in unexpected program exit if we open and then close any dialog, e.g. from the help frame toolbar. Even though the previous commit actually already fixed the problem in the current code, still apply this fix as well, just in case we can (or could, in the future) should any dialogs with NULL parent in this program. Closes #15880.

2014-01-16 22:44 VZ, revision 75633

Avoid automatically closing parent frame if a child dialog was closed. This counterintuitive behaviour could happen when a dialog of a frame returning false from its ShouldPreventAppExit() was closed: if there were no other TLWs in the application, then the parent frame could be closed as well, even if this clearly shouldn't happen. See #15880.

2014-01-16 22:41 VZ, revision 75632

wxWindow::SetWindowVariant() does do something under ports other than wxOSX. Document that this function adjusts the window font size under non-OS X systems and explain why it should still be used instead of changing the font size directly.

2014-01-16 22:33 VZ, revision 75631

Ensure that the help viewer keeps running as long as its main frame is opened. Do prevent the app from exiting when the help frame is shown in the special case of the help viewer application where the default behaviour of exiting the application when only the help window remains open is inappropriate and results in unexpected program exit if we open and then close any dialog, e.g. from the help frame toolbar. Even though the previous commit actually already fixed the problem in the current code, still apply this fix as well, just in case we can (or could, in the future) should any dialogs with NULL parent in this program. Closes #15880.

2014-01-16 22:33 VZ, revision 75630

Avoid automatically closing parent frame if a child dialog was closed. This counterintuitive behaviour could happen when a dialog of a frame returning false from its ShouldPreventAppExit() was closed: if there were no other TLWs in the application, then the parent frame could be closed as well, even if this clearly shouldn't happen. See #15880.

2014-01-14 06:36 RD, revision 75625

Add missing GetControl and SetControl methods

2014-01-14 06:36 RD, revision 75624

add missing GetVeto method

2014-01-14 06:35 RD, revision 75623

Add missing GetControl and SetControl methods

2014-01-14 06:35 RD, revision 75622

add missing GetVeto method

2014-01-13 14:38 VZ, revision 75608

Document wxWindow::FindWindow() TLW skipping behaviour. Explicitly mention that TLW "children" are not searched by this function (which is the case since r74721).

2014-01-13 14:38 VZ, revision 75607

Document incompatible change to wxWindow::FindWindow() in 3.0. We now skip the TLW children in this method, see r74721. Also explicitly mention that TLW "children" are not searched by this function in the documentation.

2014-01-12 15:13 VZ, revision 75606

Support file associations using "show" verb under MSW too. If we failed to find the "open" command, try the "show" one as some programs (notable Microsoft viewers for Office file formats) only define the latter but not the former. Closes #15821.

2014-01-12 15:13 VZ, revision 75605

Support file associations using "show" verb under MSW too. If we failed to find the "open" command, try the "show" one as some programs (notable Microsoft viewers for Office file formats) only define the latter but not the former. Closes #15821.

2014-01-11 15:25 VZ, revision 75590

Don't use deprecated wxBOLD, wxNORMAL and similar constants. Replace them with wxFONTWEIGHT_BOLD, wxFONTSTYLE_NORMAL or wxFONTWEIGHT_NORMAL and equivalents in the code of the library itself and in the samples. Also simplify font construction using wxFontInfo where possible to avoid specifying these constants at all if they are not needed.

2014-01-11 15:25 VZ, revision 75589

Remove commented out line from the dnd sample. No real changes, just remove the unnecessary line and its outdated comment (wxPaintDC::Clear() can be called in wxGTK, it's just not useful).

2014-01-11 15:24 VZ, revision 75588

wxBitmap with cleared alpha channel doesn't keep its alpha flag any more. Explicitly reset wxBitmap alpha flag after clearing its alpha channel to ensure that we don't treat it as having alpha after going to all the trouble of ensuring that it doesn't/ See #14403.

2014-01-11 03:52 VZ, revision 75587

Rename wxLANGUAGE_CAMBODIAN to wxLANGUAGE_KHMER. Keep the old name for compatibility. See https://github.com/wxWidgets/wxWidgets/pull/2

2014-01-11 03:52 VZ, revision 75586

No real changes, just fix a typo in a comment. z/preffered/preferred/

2014-01-10 15:18 VZ, revision 75585

Allow building wxGTK using GTK+3 under Windows too. No real changes, just use the right libraries for GTK+3 port. Closes #15871.

2014-01-10 06:15 RD, revision 75579

Add doc for wxFlexGridSizer::GetRowHeights and GetColWidths

2014-01-10 06:14 RD, revision 75578

Add doc for wxFlexGridSizer::GetRowHeights and GetColWidths

2014-01-08 16:56 JJ, revision 75572

Fix compilation on OpenVMS id the logical CONFIG is defined

2014-01-08 01:38 VZ, revision 75571

Disable wxUSE_PREFERENCES_EDITOR in correct place in wxiOS. wx/osx/setup0.h is auto-generated, so r74708 shouldn't have changed it as the change was overwritten by r75568 which regenerated that file. Instead, disable wxUSE_PREFERENCES_EDITOR in iPhone-specific file.

2014-01-07 22:54 VZ, revision 75570

Fix check for the item being checked when appending it under wxMSW. The changes of r75448 were wrong, we can't ask Windows for the item state before attaching it to the menu, so just check the internal flag here. See ##15748.

2014-01-07 22:54 VZ, revision 75569

Fix benchmarks compilation with WXWIN_COMPATIBILITY_2_8 set to 0. Include wx/crt.h explicitly to be able to use wxPrintf() and friends.

2014-01-07 22:54 VZ, revision 75568

Disable the use of compiler TLS by default under Windows. While compiler TLS support is simpler to use and much faster than using our own Win32 API-based TLS implementation, it results in difficult to debug crashes when used inside a dynamically loaded DLL under Windows XP, so disable it by default to be safe. Closes #13116.

2014-01-07 22:13 VZ, revision 75567

Fix handling of bitmaps with alpha channel in wxMSW wxImageList. Don't use mask and alpha together, this results in visual artefacts and masks are unnecessary with RGBA bitmaps anyhow. The only potentially problematic remaining case is mixing bitmaps with alpha and mask inside the same image list (as we need to indicate whether we use the mask or not when creating it), but this should probably be rare and in the meanwhile we can at least RGBA bitmaps with image lists, which includes doing this implicitly when they are used as button bitmaps. Also refactor wxBitmap code to extract part of CopyFromIconOrCursor() to allow reusing it in the newly added MSWUpdateAlpha(). See #11476.

2014-01-07 22:13 VZ, revision 75566

Fix alpha after drawing a bitmap with alpha on a purely RGB bitmap in wxMSW. Previously, the area of the bitmap outside of the rectangle covered by the bitmap being drawn became completely transparent, "losing" the original bitmap contents. This was due to some pixels of the bitmap having non-0 alpha value after AlphaBlend() call, as it updates both the colours and alpha of the destination. As there doesn't seem to be any way to prevent it from doing this, just reset alpha back to 0 after calling it to avoid the problem. Closes #14403.

2014-01-06 13:42 VZ, revision 75565

Just deprecate but don't schedule for removal wxNORMAL and friends. Deprecate the use of the old untyped constants but don't schedule them from removal in a future wx version by removing "#if WXWIN_COMPATIBILITY_3_0" tests around their definition and use. Provoking deprecation warnings in the code using these constants is worth it as they are unclear and it's easy to make mistakes when using them, but breaking this code compilation outright can't be justified -- even in the future. Also use more informational wxDEPRECATED_MSG() instead of a simple wxDEPRECATED() as it might not be obvious at all how should the code be updated exactly. Finally, avoid the use of deprecated constants inside the library itself. As a side effect, this closes #15814.

2014-01-06 13:42 VZ, revision 75564

Actually implement default wxPasswordEntryDialog ctor. This was added in r75404 but not implemented, do provide the trivial definition of this function too. Closes #15770.

2014-01-05 22:11 VZ, revision 75563

Fix mouse wheel event coordinates in wxFrame in wxMSW. The screen to client conversion for this event coordinates took the toolbar height into account twice, resulting in a wrong value if the event was handled in a frame that did have a toolbar. Closes #15812.

2014-01-05 22:11 VZ, revision 75562

Update the versions of the libraries built by wx_vc10.sln. Use "31" or "310" in the library names instead of "30". Closes #15810.

2014-01-05 22:10 VZ, revision 75561

Deprecate wxPropertyGrid::DoubleToString(). Simply use wxNumberFormatter instead, this reduces code duplication and avoids bugs due to formatting inconsistencies in DoubleToString(). Closes #15625.

2014-01-05 22:10 VZ, revision 75560

Fix several problems with number formatting in wxNumberFormatter. We shouldn't add thousands separators nor remove trailing zeros for the numbers in scientific format. Also avoid "-0" as output. See #15625.

2014-01-05 22:10 VZ, revision 75559

Fix mouse wheel event coordinates in wxFrame in wxMSW. The screen to client conversion for this event coordinates took the toolbar height into account twice, resulting in a wrong value if the event was handled in a frame that did have a toolbar. Closes #15812.

2014-01-05 20:20 VZ, revision 75558

Portuguese translations update from Manuela Silva.

2014-01-05 20:20 VZ, revision 75557

Portuguese translations update from Manuela Silva.

2014-01-05 14:56 VZ, revision 75556

Remove unnecessary _mingw.h inclusion from wx/msw/missing.h. This header is already included from wx/platform.h which is always included before wx/msw/missing.h.

2014-01-05 14:56 VZ, revision 75555

Move wxCHECK_MINGW32_VERSION() declaration to wx/msw/gccpriv.h. Unfortunately we can't keep it in wx/compiler.h which is included too early, before UNICODE macro is defined, and we can't define it before including wx/setup.h which itself must be included after wx/compiler.h. So move it to wx/msw/gccpriv.h which is not a great solution, as the best would be to get rid of this gcc-specific file completely, but at least should make everything build again and ensure that _mingw.h is included after UNICODE definition. Closes #15805.

2014-01-05 14:55 VZ, revision 75554

Revert "Move UNICODE section of wx/platform.h before wx/compiler.h inclusion." Unfortunately this fix for MinGW broke compilation under Unix, see #15805. This reverts r75520.

2014-01-05 14:55 VZ, revision 75553

Revert "Define wxUSE_UNICODE on compiler command line in Unix builds too." This fix only helps with building wxWidgets itself but doesn't help when building user code using it, so revert it as we need another solution to this problem anyhow. This reverts r75536, see #15805.

2014-01-05 14:55 VZ, revision 75552

Simplify and fix column determination code in wxGridStringTable. The number of columns in the table is now (since r60717) stored in m_numCols, so there is no need to get it from wxGrid any more. This is not only simpler and faster but also more correct as the first row might not have the full number of values yet. Closes #15809.

2014-01-05 13:56 VZ, revision 75551

Simplify and fix column determination code in wxGridStringTable. The number of columns in the table is now (since r60717) stored in m_numCols, so there is no need to get it from wxGrid any more. This is not only simpler and faster but also more correct as the first row might not have the full number of values yet. Closes #15809.

2014-01-04 23:50 VZ, revision 75550

Add Aragonese translations by Jorge Pérez.

2014-01-04 23:50 VZ, revision 75549

Fix another wxDOT deprecation warning, this time in wxGTK build. Use wxPENSTYLE_DOT instead.

2014-01-04 23:50 VZ, revision 75548

Add Aragonese translations by Jorge Pérez.

2014-01-04 23:20 VZ, revision 75547

Fix tons of warnings in wxMSW after deprecating wxPen/wxBrush int styles &c. Replacement of FUTURE_WXWIN_COMPATIBILITY_3_0 with WXWIN_COMPATIBILITY_3_0 in r75532 resulted in tons of warnings as all code using wxSOLID and similar constants now uses the deprecated methods taking int instead of the preferred ones taking wx{Pen,Brush}Style (and similarly for wxFont{Style,Weight,Family}). Fix all of them but this also would seem to mean that this change might not be such a good idea at all.

2014-01-04 22:58 VZ, revision 75538

Revert "Hack wxMSW wxNotebook to show the text controls correctly initially." This hack resulted in showing a black rectangle corresponding to the initial size of the first notebook page when creating the notebook, as could be seen in the notebook sample by pressing Alt+2,Alt+1 to recreate the notebook after the startup. If the bug that this hack was supposed to fix hasn't been fixed yet (and it might have been by r73126, but it's hard to be sure as we don't have any test case for that bug), we could reintroduce this call to Update() but only if we're not inside a deferred resize (i.e. m_hDWP != 0) as it just can't work correctly in this case. This reverts r69793.

2014-01-04 22:58 VZ, revision 75537

Remove unnecessary ::SetWindowLong() call in wxMSW wxNotebook code. There is no point in manually resetting WS_VISIBLE style before calling wxWindow::Show(false) which does it too.

2014-01-04 22:58 VZ, revision 75536

Define wxUSE_UNICODE on compiler command line in Unix builds too. Under Windows we already define _UNICODE which gets picked up and translated to wxUSE_UNICODE by wx/platform.h, but under Unix we didn't do it until now. Do it both for consistency and to fix the build breakage since r75520 which moved the tests for wxUSE_UNICODE being defined before wx/setup.h. This seems like the simplest solution because otherwise there doesn't seem to be any single header order which would work under both Windows and Unix: under Windows we need to include wx/compiler.h, and hence _mingw.h included from it, before wx/setup.h, which implies that wxUSE_UNICODE must be set before doing it, but under Unix wxUSE_UNICODE was only defined in wx/setup.h and so couldn't be tested before including wx/compiler.h. And just the explanation above should convincingly show that defining wxUSE_UNICODE in CPPFLAGS makes things simpler. Closes #15805.

2014-01-04 22:58 VZ, revision 75535

Fix wrong comment in the scroll sample. Fix coordinates in the comment to match those used by the code. Closes #15804.

2014-01-04 22:58 VZ, revision 75534

Reset sorting column index in generic wxDataViewCtrl when clearing columns. Otherwise we could continue to use the now invalid index for sorting. Closes #15803.

2014-01-04 21:48 VZ, revision 75533

Reset sorting column index in generic wxDataViewCtrl when clearing columns. Otherwise we could continue to use the now invalid index for sorting. Closes #15803.

2014-01-04 21:07 PC, revision 75532

remove WXWIN_COMPATIBILITY_2_6, add WXWIN_COMPATIBILITY_3_0 closes #15792

2014-01-03 15:40 VZ, revision 75523

Avoid asserts in wxGTK when wxMDIChildFrame::SetSize() is called. SetSize() doesn't do anything for MDI children in wxGTK and other ports using TDI version of MDI, but it shouldn't result in an assert from wxTLW::DoMoveWindow() neither, so override DoMoveWindow() in wxTDIChildFrame to avoid it.

2014-01-03 15:40 VZ, revision 75522

Avoid asserts in wxGTK when wxMDIChildFrame::SetSize() is called. SetSize() doesn't do anything for MDI children in wxGTK and other ports using TDI version of MDI, but it shouldn't result in an assert from wxTLW::DoMoveWindow() neither, so override DoMoveWindow() in wxTDIChildFrame to avoid it.

2014-01-03 02:34 VZ, revision 75521

Revert "Don't intercept accelerators in wxTextValidator in wxGTK." Testing for absence of Alt modifier is wrong as it could be specified for the events generated by AltGr-letter key combinations (AltGr is Alt+Ctrl), so this commit broke the validation of any such symbols entered from non-US keyboard. This is worse than the problem it was trying to fix, so revert this for now. The real fix will need to ensure that the mnemonics are checked first, i.e. before generating EVT_CHAR, in wxGTK, just as it already happens in wxMSW. This reverts r75453. See #15777.

2014-01-03 02:18 VZ, revision 75520

Move UNICODE section of wx/platform.h before wx/compiler.h inclusion. This fixes the build with some versions of MinGW which depend on UNICODE being defined correctly in _mingw.h which is included from wx/compiler.h, so that before this change the build was broken as inconsistent definitions of UNICODE were used there and in windows.h included later.

2014-01-03 02:12 VZ, revision 75519

Define HAVE_VARIADIC_MACROS as 1, not nothing, in wx/cpp.h. This avoids g++ warning about HAVE_VARIADIC_MACROS redefinition in setup.h if wx/cpp.h happens to be included before it.

2014-01-03 02:08 VZ, revision 75518

Don't keep using the old wxBitmap data after modifying it directly in wxGTK. Drawing on a wxBitmap via wxMemoryDC modified its pixmap representation in wxGTK and even if its pixbuf representation was later changed using direct access to the bitmap pixels, the out of date pixmap continued to be used, creating the illusion of direct access being completely ignored. Fix this by purging the old pixmap representation when locking the bitmap for raw access.

2014-01-03 02:06 VZ, revision 75517

Don't keep using the old wxBitmap data after modifying it directly in wxGTK. Drawing on a wxBitmap via wxMemoryDC modified its pixmap representation in wxGTK and even if its pixbuf representation was later changed using direct access to the bitmap pixels, the out of date pixmap continued to be used, creating the illusion of direct access being completely ignored. Fix this by purging the old pixmap representation when locking the bitmap for raw access.

2014-01-02 01:24 RD, revision 75515

Turn off wxUSE_COMPILER_TLS for wxPython builds to avoid crashes on XP.

2014-01-02 01:21 RD, revision 75514

Turn off wxUSE_COMPILER_TLS for wxPython builds to avoid crashes on XP.

2013-12-31 15:03 VZ, revision 75507

Mention horizontal scrolling in wxScrollBar documentation too. Up/down can also mean left/right. Closes #15791.

2013-12-31 15:03 VZ, revision 75506

No real changes, just fix some typos in the comments. Fix spelling in a couple of comments. Closes #15790.

2013-12-31 15:03 VZ, revision 75505

Use wxScopedArray instead of raw new[]/delete[] and fix memory leak. Don't leak memory in case of error when reading from the stream in BMP loading code. Closes #15789.

2013-12-31 15:03 VZ, revision 75504

Allow initializing wxScopedArray more conveniently. Typical wxScopedArray initialization uses "new T[n]" expression, allow to omit most of it and specify just n, the number of elements to allocate. Use the new shorter form in the places where wxScopedArray(new ...) was used (which is in almost all of them)

2013-12-31 14:58 VZ, revision 75503

Fix possible memory leak in BMP reading code. Don't forget to free the arrays even in case of an error while reading from the stream. Closes #15789.

2013-12-29 20:14 PC, revision 75490

fix memory leak, closes #15785

2013-12-29 12:49 SC, revision 75489

moving special characters handling for EVT_CHAR into SetupKeyEvent, fixes #15784

2013-12-29 11:39 SC, revision 75488

routing to common code, see #15784

2013-12-29 10:04 SC, revision 75487

copy over all modifiers for single char events, fixes shift-tabs for single line controls, see #15784

2013-12-29 04:37 RD, revision 75466

Add missing wxMenuItem methods

2013-12-29 04:37 RD, revision 75465

Slight tweaks for the wxWebKitCtrl doc. Remove inline function bodies.

2013-12-29 04:36 RD, revision 75464

Add wxWebKitCtrl header.

2013-12-29 04:36 RD, revision 75463

Workaround for OSX crash in STC’s CallTip popup. Revert this when the fix in #15765 is backported.

2013-12-29 04:36 RD, revision 75462

Document ctors and dtor for wxListView

2013-12-29 04:36 RD, revision 75461

Add the ability to show a CallTip in the stc sample.

2013-12-29 04:36 RD, revision 75460

Guard against trying to use extend() with None

2013-12-29 04:23 RD, revision 75459

Add missing wxMenuItem methods

2013-12-29 04:22 RD, revision 75458

Slight tweaks for the wxWebKitCtrl doc. Remove inline function bodies.

2013-12-29 04:22 RD, revision 75457

Add wxWebKitCtrl header.

2013-12-29 04:22 RD, revision 75456

Document ctors and dtor for wxListView

2013-12-29 04:22 RD, revision 75455

Add the ability to show a CallTip in the stc sample.

2013-12-29 04:22 RD, revision 75454

Guard against trying to use extend() with None

2013-12-29 01:19 VZ, revision 75453

Don't intercept accelerators in wxTextValidator in wxGTK. Key events with modifiers shouldn't be filtered by the validator as they are used as accelerators and not for the text entry at all. Closes #15777.

2013-12-29 01:19 VZ, revision 75452

Simplify wxTextValidator EVT_CHAR handler. Ignore the event by default to reduce the number of event.Skip() calls. No changes in the code behaviour.

2013-12-29 01:19 VZ, revision 75451

Handle Unicode keys correctly in wxTextValidator. Don't allow entering arbitrary Unicode keys in wxTextValidator limited to digits only, for example.

2013-12-29 01:01 VZ, revision 75450

Make wxTextValidator validation error messages more informative. Saying that "something is invalid" really doesn't help much at all, so try to be at least a bit more informative.

2013-12-29 01:01 VZ, revision 75449

Make wxFILTER_INCLUDE_LIST in wxTextValidator actually usable. Only check for its violation once the full text is entered as otherwise nothing could ever be entered when it was used. Closes #15778.

2013-12-29 01:01 VZ, revision 75448

Fix handling of menu items checked before being attached in wxMSW. Calling wxMenuItem::Check() before appending the item to a menu didn't have any effect, fix this by checking the item state when actually attaching it. Closes #15748.

2013-12-29 01:01 VZ, revision 75447

Avoid crashes when deleting owned top level windows. Don't delay the TLW destruction if it has a parent and its parent is already being deleted: we can't delay the inevitable in this case and only succeed in making the program crash if we try. Closes #15743.

2013-12-29 01:01 VZ, revision 75446

Prevent wxGrid rows/columns from becoming too small on double click. The minimal size wasn't respected when auto-sizing rows/columns in Set{Row,Col}Size() which was called in response to double clicking the separator line, which resulted in clearly wrong behaviour as the user was prevented from resizing the row/column to a smaller size by dragging them but not by double clicking, so fix this to respect the minimal size as well. Closes #15627.

2013-12-29 01:01 VZ, revision 75445

Fix harmless MSVC warning. Avoid "converting value to bool" warning introduced by r75310.

2013-12-28 23:20 VZ, revision 75444

Update the generated file after gen_iface.py change. Regenerate the file to use the symbolic constants instead of the raw values. See #15783.

2013-12-28 23:20 VZ, revision 75443

Use symbolic constants names in the generated wxSTC files. Update the script generating stc.cpp to put the symbolic constants names and not their raw numeric values into the generated code. This makes it much easier to read and understand. Closes #15783.

2013-12-28 16:11 VZ, revision 75439

Mention that raw pixel access is efficient only with DIBs under MSW. While accessing DDBs (now) works too, it's inefficient and should be avoided.

2013-12-28 16:11 VZ, revision 75438

Make raw pixel access work even with DDBs under MSW. This is inefficient, because we need to copy pixels to and from them, but better than silently doing nothing.

2013-12-24 23:17 RD, revision 75428

Fix blank wxComboBox appearance broken by the changes of r75134.

2013-12-23 23:05 RD, revision 75417

Add comment about use of wxFRAME_TOOL_WINDOW

2013-12-23 23:04 RD, revision 75416

Document ctors and dtor for wxListView

2013-12-23 23:04 RD, revision 75415

Add the ability to show a CallTip in the stc sample.

2013-12-23 23:04 RD, revision 75414

Guard against trying to use extend() with None

2013-12-23 23:04 RD, revision 75413

Include frame.h at the beginning of the file instead of in the middle. It will be needed earlier in some cases.

2013-12-23 23:04 RD, revision 75412

Use wxFRAME_TOOL_WINDOW style for the STC’s calltip window to avoid crashing on OSX.

2013-12-23 21:02 RD, revision 75411

A new branch for minor tweaks needed for wxPython 3.0.0.

2013-12-23 17:43 VZ, revision 75409

Use wxPENSTYLE_{SOLID,TRANSPARENT} instead of deprecated versions in the docs. Don't push people to use the deprecated wxSOLID and wxTRANSPARENT. Closes #15775.

2013-12-21 23:26 VZ, revision 75408

Add wxNumberEntryDialog default ctor and Create(). Allow creating wxNumberEntryDialog in 2 steps, as most of the other classes. Closes #15769.

2013-12-21 15:59 SC, revision 75405

- one single method for sending char events from a NSString - adding insertText override for multiline fields as char events went missing after r74945

2013-12-21 13:23 VZ, revision 75404

Add wxPasswordEntryDialog default ctor and Create(). Allow creating wxPasswordEntryDialog in 2 steps, as most of the other classes. Closes #15770.

2013-12-20 18:55 VZ, revision 75403

Don't link with -lm if the check using it failed. It is useless and can, apparently, result in problems, see #15746.

2013-12-20 18:50 VZ, revision 75402

Document wxEVT_MEDIA_XXX event types. Closes #15768.

2013-12-20 17:03 SC, revision 75401

reverting r74098, applying John's version, see #15008, #15765, #13841 will be backported if no regressions are discovered

2013-12-18 17:18 VZ, revision 75400

Don't crash in wxAuiToolBar::GetToolBarFits(). The code could crash if m_overflowVisible was true but m_overflowSizerItem was NULL. Ideally this shouldn't happen in the first place, but it did, so at least fix the crash for now -- and hopefully this code will be refactored to make it more clear later. Closes #15747.

2013-12-18 17:18 VZ, revision 75399

Don't crash in wxAuiToolBar::GetToolBarFits(). The code could crash if m_overflowVisible was true but m_overflowSizerItem was NULL. Ideally this shouldn't happen in the first place, but it did, so at least fix the crash for now -- and hopefully this code will be refactored to make it more clear later. Backport from trunk, see #15747.

2013-12-18 17:00 VZ, revision 75398

Add wxHtmlWindow::SetDefaultHTMLCursor(). This allows to change the cursors used by any HTML windows, before creating them. Closes #15324.

2013-12-18 17:00 VZ, revision 75397

Document wxMediaState enum. Closes #15760.

2013-12-18 17:00 VZ, revision 75396

Treat empty variants as null ones in wxMSW OLE code. Simply ignoring VT_EMPTY variants doesn't make any sense and can result in completely unexpected results, so don't do it. Closes #15757.

2013-12-18 17:00 VZ, revision 75395

Remove wx/generic/colrdlgg.h from common GUI headers. This header is not used in all ports, notably not in wxMSW nor wxGTK. See #15753.

2013-12-18 17:00 VZ, revision 75394

Add default ctor and Create() to wxContextHelpButton. Allow two step creation of wxContextHelpButton. Closes #14848.

2013-12-18 17:00 VZ, revision 75393

Document wxMediaState enum. Closes #15760.

2013-12-16 19:55 VS, revision 75388

wxTextFile: don't loose data with CRCRLF line endings. Previously, when reading files with completely nonstandard - but occurring in the wild thanks to broken Notepad - files with CRCRLF, all content would be replaced with empty lines. Fix the code to do what many editors do with such files: treat this as data line followed by an empty one. This is not ideal, but it is better than discarding data - and arguably, silently cleaning up the endings wouldn't be great either (and would add extra complications for what is an obscure and broken case). See http://stackoverflow.com/questions/6998506/text-file-with-0d-0d-0a-line-breaks

2013-12-16 19:54 VS, revision 75387

wxTextFile: don't loose data with CRCRLF line endings. Previously, when reading files with completely nonstandard - but occurring in the wild thanks to broken Notepad - files with CRCRLF, all content would be replaced with empty lines. Fix the code to do what many editors do with such files: treat this as data line followed by an empty one. This is not ideal, but it is better than discarding data - and arguably, silently cleaning up the endings wouldn't be great either (and would add extra complications for what is an obscure and broken case). See http://stackoverflow.com/questions/6998506/text-file-with-0d-0d-0a-line-breaks

2013-12-16 17:36 VS, revision 75386

Support keyboard navigation with Tab in generic wxDataViewCtrl. Move keyboard focus between columns with Tab and Shift-Tab. Works similarly to left and right arrows, but wraps around to go to the next or previous line and doesn't collapse tree nodes. If focus reaches the last or first cell, the key event is skipped, allowing normal Tab handling for moving to another control.

2013-12-16 12:12 JJ, revision 75385

Update OpenVMS compile support

2013-12-16 11:51 JJ, revision 75384

Add OpenVMS to the systems that support the Bind-Event

2013-12-15 03:07 PC, revision 75383

fix inconsistent line endings

2013-12-15 03:04 PC, revision 75382

just put GtkBorder variable on the stack fixes missing runtime version check

2013-12-15 02:29 PC, revision 75381

fix missing/incorrect GTK runtime version checks

2013-12-14 16:33 JS, revision 75380

Ensure a small spanned column doesn't shrink its columns too much by checking for min column sizes

2013-12-14 16:32 JS, revision 75379

Ensure a small spanned column doesn't shrink its columns too much by checking for min column sizes

2013-12-12 17:08 SC, revision 75378

backport, fixes #15688

2013-12-11 18:27 VZ, revision 75377

Afrikaans translations update from Friedel Wolff.

2013-12-11 18:26 VZ, revision 75376

Afrikaans translations update from Friedel Wolff.

2013-12-11 13:06 JS, revision 75375

Fix for occasionally missing cells in tables

2013-12-11 13:05 JS, revision 75374

Fix for occasionally missing cells in tables

2013-12-10 16:24 JS, revision 75373

Added scrollbar hysteresis detection to stop infinite looping when vertical scrollbar presence or absence affects the content height.

2013-12-09 22:09 SC, revision 75364

trying 10.5 / 10.6 fix for #15688

2013-12-08 11:30 JS, revision 75363

Fixed overlapping text and floating objects by simplifying the available rectangle calculation

2013-12-08 11:30 JS, revision 75362

Fixed overlapping text and floating objects by simplifying the available rectangle calculation

2013-12-07 16:51 JS, revision 75361

Clicking on a floating (non-container) object no longer sets the caret position. Double-clicking on a floating (non-container) object selects it instead of selecting a word. Selection refresh now takes floating objects into account. The last line of a paragraph now takes floating objects into account.

2013-12-07 16:50 JS, revision 75360

Clicking on a floating (non-container) object no longer sets the caret position. Double-clicking on a floating (non-container) object selects it instead of selecting a word. Selection refresh now takes floating objects into account. The last line of a paragraph now takes floating objects into account.

2013-12-07 16:12 JS, revision 75359

Backported r75354: Fix layout of content within a floating object by using Move and not SetPosition; prevent creeping of floating objects on layout.

2013-12-07 13:30 VZ, revision 75358

Don't build wxOSX/Cocoa twice in wxOSX buildbot. Both trunk builds were using Cocoa, change the one supposed to be Carbon to use Carbon instead. Also add Carbon stable branch build as this is probably even more important than testing Carbon in the trunk.

2013-12-07 12:59 VZ, revision 75357

Clarify wxGetTopLevelParent() behaviour for TLWs. It doesn't return the parent of a TLW but TLW itself. Whether this is a good idea or bad one, this is how it works since a very long time and we don't want to change it any more.

2013-12-07 12:55 VZ, revision 75356

Big Galician translation update from Nuria Andión.

2013-12-07 12:55 VZ, revision 75355

Big Galician translation update from Nuria Andión.

2013-12-05 20:56 JS, revision 75354

Fix layout of content within a floating object by using Move and not SetPosition; prevent creeping of floating objects on layout.

2013-12-05 20:16 SC, revision 75353

backporting SDK 10.5

2013-12-05 10:13 SC, revision 75352

support 10.5 SDK build

2013-12-04 15:33 VS, revision 75351

wxOSX Retina fixes: wxImageList::GetSize(). wxImageList returns size of its bitmap as pixel size, i.e. twice the displayed screen on HiDPI screens. Unfortunately, wxImageList::GetSize() is used heavily in (generic) GUI drawing code, e.g. to properly size wxListCtrl's icon columns. As wxImageList is used primarily by controls, it seems reasonable to adjust for scaling here, rather than requiring all users of the class to do it.

2013-12-04 15:33 VS, revision 75350

wxOSX Retina fixes: size wxStaticBitmap and wxBitmapButton properly. The size is expressed in logical coordinates and needs to use bitmap's scaled size, otherwise it would appear twice as large in both dimensions.

2013-12-04 15:32 VS, revision 75349

wxOSX Retina fixes: wxImageList::GetSize(). wxImageList returns size of its bitmap as pixel size, i.e. twice the displayed screen on HiDPI screens. Unfortunately, wxImageList::GetSize() is used heavily in (generic) GUI drawing code, e.g. to properly size wxListCtrl's icon columns. As wxImageList is used primarily by controls, it seems reasonable to adjust for scaling here, rather than requiring all users of the class to do it.

2013-12-04 15:32 VS, revision 75348

wxOSX Retina fixes: size wxStaticBitmap and wxBitmapButton properly. The size is expressed in logical coordinates and needs to use bitmap's scaled size, otherwise it would appear twice as large in both dimensions.

2013-12-04 14:23 VS, revision 75347

Auto grow the last wxDataViewCtrl column on all platforms. The GTK+ implementation always did this and it doesn't make much sense to let the space be wasted, so do as GTK+ does: expand the last column to cover the remaining unused space in the OS X and generic implementations too. Don't do anything if the space is insufficient. Respect the last column's minimal width. See #13904.

2013-12-04 13:38 VS, revision 75346

Fix fixed-width progress columns in generic wxDataViewCtrl. Both native wxDVC implementations grow the progress column, the generic one didn't. This change fixes it and _seems_ not to break other things. As a consequence, progress columns no longer have a 40px minimal width, but that should be OK. Fixes #15745.

2013-12-04 13:36 VS, revision 75345

Fix fixed-width progress columns in generic wxDataViewCtrl. Both native wxDVC implementations grow the progress column, the generic one didn't. This change fixes it and _seems_ not to break other things. As a consequence, progress columns no longer have a 40px minimal width, but that should be OK. Fixes #15745.

2013-12-03 19:41 JS, revision 75344

Applied patch #15744: wxRichTextCtrl: HitTest can't find top-level floats (dghart)

2013-12-03 19:41 JS, revision 75343

Applied patch #15744: wxRichTextCtrl: HitTest can't find top-level floats (dghart)

2013-12-03 15:53 VZ, revision 75342

Fix crash when Destroy()-ing a TLW with a non-TLW parent. Generalize the code in wxTopLevelWindowBase dtor checking for the children of the TLW being destroyed pending for deletion themselves to work when the child TLW is an indirect child, i.e. was created with a child window of this TLW as parent and not this TLW itself. Closes #15743.

2013-12-03 15:53 VZ, revision 75341

Fix crash when Destroy()-ing a TLW with a non-TLW parent. Generalize the code in wxTopLevelWindowBase dtor checking for the children of the TLW being destroyed pending for deletion themselves to work when the child TLW is an indirect child, i.e. was created with a child window of this TLW as parent and not this TLW itself. Closes #15743.

2013-12-03 14:38 VZ, revision 75340

Work around wrong vsscanf() declaration under HP-UX. Under this system vsscanf() is declared as taking a non-const char* as first argument which prevented our code using it from compiling. Wrap it in wxCRT_VsscanfA() adding the necessary const_cast<> to fix this. Closes #15638.

2013-12-03 14:36 VZ, revision 75339

Work around wrong vsscanf() declaration under HP-UX. Under this system vsscanf() is declared as taking a non-const char* as first argument which prevented our code using it from compiling. Wrap it in wxCRT_VsscanfA() adding the necessary const_cast<> to fix this. Closes #15638.

2013-12-02 18:46 VS, revision 75336

Minor clarifications to wxTextEntry::SetHint() docs. Update platforms support docs. Mention event handlers interaction in the generic implementation.

2013-12-02 18:46 VS, revision 75335

Implement wxTextEntry::SetHint() natively for GTK+3.

2013-12-02 18:46 VS, revision 75334

Don't use native cue banners in wxTextEntry::SetHint() on XP. The code apparently expected EM_SETCUEBANNER to return false on pre-Vista systems (where the cue banners don't work). This isn't the case in practice, so check for Vista explicitly and use the generic implementation on XP.

2013-12-02 18:45 VS, revision 75333

Don't use native cue banners in wxTextEntry::SetHint() on XP. The code apparently expected EM_SETCUEBANNER to return false on pre-Vista systems (where the cue banners don't work). This isn't the case in practice, so check for Vista explicitly and use the generic implementation on XP.

2013-12-02 18:45 VS, revision 75332

Backport r75319: support for localized help menus

2013-12-02 17:50 VZ, revision 75331

Try to use /proc/self instead of /dev/core in the unit test. /dev/core doesn't seem to exist on the machines running Travis CI builds, check if /proc/self can work there.

2013-12-02 17:34 VZ, revision 75330

Fix clicking on checkboxes in generic wxDataViewCtrl. Back port the fix of r75329 from the trunk but without changing GetEffectiveAlignment() visibility to avoid changing the ABI. See #15731.

2013-12-02 17:30 VZ, revision 75329

Use correct cell alignment in generic wxDataViewCtrl mouse handling code. Don't fall back to wxALIGN_CENTRE, even if the renderer doesn't specify its own alignment we still have to take the column alignment in consideration, so use GetEffectiveAlignment() (which had to be made public for this). This notably fixes (again) hit testing for wxDataViewToggleRenderer in the generic version. Closes #15731.

2013-12-02 13:58 VZ, revision 75328

Check if colour really changed in wxGenericListCtrl::SetBackgroundColour(). Call the base class version to update the colour stored in the base class and also to avoid changing the colour of the main window unnecessarily if the colour didn't really change. This is also consistent with the code in SetForegroundColour() just below.

2013-12-02 13:58 VZ, revision 75327

Don't change header window foreground colour in wxGenericListCtrl. As calling wxGenericListCtrl::SetBackgroundColour() doesn't change the header window background, don't change its foreground in SetForegroundColour() neither. Closes #15741.

2013-12-02 13:58 VZ, revision 75326

Add a missing string in Slovakian translations. Closes #15740.

2013-12-02 13:56 VZ, revision 75325

Don't change header window foreground colour in wxGenericListCtrl. As calling wxGenericListCtrl::SetBackgroundColour() doesn't change the header window background, don't change its foreground in SetForegroundColour() neither. Closes #15741.

2013-12-02 13:52 VZ, revision 75324

Add a missing string in Slovakian translations. Closes #15740.

2013-12-02 11:38 JS, revision 75323

Fixed #15717: wxRichTextStyleOrganiserDialog returns wxID_OK when closed with Escape key (ikamakj)

2013-12-02 11:38 JS, revision 75322

Fixed #15717: wxRichTextStyleOrganiserDialog returns wxID_OK when closed with Escape key (ikamakj)

2013-12-02 10:06 JS, revision 75321

Apply fix for #15734: wxRichTextCtrl: A floating wxRichTextTable's cells aren't drawn (dghart)

2013-12-02 10:06 JS, revision 75320

Apply fix for #15734: wxRichTextCtrl: A floating wxRichTextTable's cells aren't drawn (dghart)

2013-12-01 21:10 SC, revision 75319

support for localized help menus

2013-11-28 17:50 JS, revision 75318

Partial fix for #15714: Caret jumping problem in wxRichTextCtrl text selection

2013-11-28 17:50 JS, revision 75317

Partial fix for #15714: Caret jumping problem in wxRichTextCtrl text selection

2013-11-28 17:29 JS, revision 75316

Fix for #15716: wxRichTextCompositeObject::Dump() should also dump the object itself?

2013-11-28 17:29 JS, revision 75315

Fix for #15716: wxRichTextCompositeObject::Dump() should also dump the object itself?

2013-11-28 17:24 JS, revision 75314

Fix for #15718: wxSymbolPickerDialog crashes on ampersand character

2013-11-28 17:24 JS, revision 75313

Fix for #15718: wxSymbolPickerDialog crashes on ampersand character

2013-11-28 17:23 JS, revision 75312

Fix for #15715: NULL check required in wxRichTextBuffer::SetStyleSheetAndNotify()

2013-11-28 17:23 JS, revision 75311

Fix for #15715: NULL check required in wxRichTextBuffer::SetStyleSheetAndNotify()

2013-11-28 14:47 VZ, revision 75310

Fix wxCommandProcessor::IsDirty() for unsaved unmodified case. IsDirty() still returned true even after undoing all the commands which was wrong, as there was nothing to save in this case. Closes #15722.

2013-11-28 14:46 VZ, revision 75309

Fix wxCommandProcessor::IsDirty() for unsaved unmodified case. IsDirty() still returned true even after undoing all the commands which was wrong, as there was nothing to save in this case. Closes #15722.

2013-11-28 13:43 VZ, revision 75308

Fix unwanted focus events when deleting a wxTreeCtrl item in wxMSW. Disable setting focus in response to TVN_SELCHANGING when deleting an item in a single selection control too -- this was already done in multi selection case but not in this one, for some reason. Also refactor the code to avoid duplicating TreeView_DeleteItem() calls. Closes #15721.

2013-11-28 13:43 VZ, revision 75307

Round values in wxBitmap::CreateScaled() and GetScaledSize(). Do it for consistency with wxMSW and because rounding probably makes more sense than truncation here. Closes #15720.

2013-11-28 13:39 VZ, revision 75306

Fix unwanted focus events when deleting a wxTreeCtrl item in wxMSW. Disable setting focus in response to TVN_SELCHANGING when deleting an item in a single selection control too -- this was already done in multi selection case but not in this one, for some reason. See #15721.

2013-11-27 17:12 VZ, revision 75305

Fix wxCHECK_MINGW32_VERSION() definition. Include _mingw.h before testing for __MINGW32_MAJOR_VERSION as it's only defined in that header. Closes #15696.

2013-11-27 17:12 VZ, revision 75304

Fix wxCHECK_MINGW32_VERSION() definition. Include _mingw.h before testing for __MINGW32_MAJOR_VERSION as it's only defined in that header. Closes #15696.

2013-11-27 16:34 VS, revision 75303

Fix OS X startup to not hang if the application doesn't get focus. If the application launches while the parent process doesn't have an active window, [NSApp run] won't terminate immediately, as was assumed here. Instead, it blocks until some input arrives, e.g. clicking the Dock icon. Work around this by adding a dummy event to the queue.

2013-11-27 16:34 VS, revision 75302

Fix OS X startup to not hang if the application doesn't get focus. If the application launches while the parent process doesn't have an active window, [NSApp run] won't terminate immediately, as was assumed here. Instead, it blocks until some input arrives, e.g. clicking the Dock icon. Work around this by adding a dummy event to the queue.

2013-11-27 00:31 VZ, revision 75299

Fix wxWindow::SetSizeHints() documentation. Add the missing @overload. Closes #15707.

2013-11-27 00:30 VZ, revision 75298

Fix wxWindow::SetSizeHints() documentation. Add the missing @overload. Closes #15707.

2013-11-26 15:50 VZ, revision 75297

Yet another fix after wxMenu::Remove() refactoring. wxMenu::Remove() was still broken in wxMSW after r75250, even with the fix in r75290, as wxMSW code relied on the item still being present in wxMenu::m_items. Delay removing it from there until after DoRemove() call to fix this. See #3424.

2013-11-26 15:28 SC, revision 75296

correct behavior in case it is still used with ShowModal

2013-11-26 15:18 SC, revision 75295

fixing shadowed var

2013-11-26 15:16 SC, revision 75294

fixing shadowed var

2013-11-26 13:53 SC, revision 75293

correct behavior in case it is still used with ShowModal

2013-11-25 17:50 PC, revision 75292

always initialize m_statText

2013-11-25 15:21 SC, revision 75291

backporting r75289

2013-11-25 14:57 VZ, revision 75290

Fix menu item destruction broken by r75250. The menu items were not removed from the menu any longer when they were deleted or destroyed after the changes in this revision. Fix this by calling the public Remove(), which does the right thing, instead of the private DoRemove(), which only does part of the job of removing the item, in DoDelete() and DoDestroy(). See #3424.

2013-11-25 14:51 SC, revision 75289

making sure no pending deletes get executed while a modal loop is running, avoiding double deletes because the dialogs are mostly allocated on the stack.

2013-11-25 14:41 VZ, revision 75288

Fix multiple calls to wxSocket::Initialize() in wxMSW. Subsequent calls didn't initialize the hidden window correctly because wxSocket::Shutdown() unregistered the window class used for it, but wxSocket::Initialize() still kept a pointer to the previously registered class name. Don't remember it any longer, unlike in the other cases where we use wxCreateHiddenWindow(), this function is only ever going to be called once until the class is unregistered anyhow, so it doesn't have to be static. Closes #15701.

2013-11-25 14:40 VZ, revision 75287

Fix multiple calls to wxSocket::Initialize() in wxMSW. Subsequent calls didn't initialize the hidden window correctly because wxSocket::Shutdown() unregistered the window class used for it, but wxSocket::Initialize() still kept a pointer to the previously registered class name. Don't remember it any longer, unlike in the other cases where we use wxCreateHiddenWindow(), this function is only ever going to be called once until the class is unregistered anyhow, so it doesn't have to be static. Closes #15701.

2013-11-25 13:31 VZ, revision 75286

Correct the author of wxAuiToolBarXmlHandler. See #15686.

2013-11-25 13:12 VZ, revision 75285

Document the order in which event tables are examined. Static event tables are search top to bottom while dynamic event tables are searched in the most-recently-bound to the most-early-bound order.

2013-11-24 19:07 PC, revision 75284

avoid deprecated gtk_style_context_get_font(), closes #15697

2013-11-24 18:20 VS, revision 75283

fix GCC warning "logical ‘or’ applied to non-boolean constant"

2013-11-23 17:23 VZ, revision 75282

Remove never used ALL_WX_LIBS variable from configure. It wasn't up to date (e.g. aui, ribbon, propgrid, richtext were not included in it) and wasn't used anywhere anyhow.

2013-11-23 16:10 VS, revision 75281

Recognize Windows 8 and 8.1 in wxGetOsDescription().

2013-11-23 16:10 VS, revision 75280

Differentiate between WXK_UP etc. and WXK_NUMPAD_ variants in NSMenuItem code.

2013-11-23 16:10 VS, revision 75279

Don't add NSFunctionKeyMask to NSMenuItem modifiers. This code probably misunderstood NSEvent documentation, where this mask is mentioned, but setKeyEquivalentModifierMask: documentation doesn't list it as allowed. More importantly, it causes "fn" to appear in the menu item and the accelerator doesn't work.

2013-11-23 16:10 VS, revision 75278

Recognize Windows 8 and 8.1 in wxGetOsDescription().

2013-11-23 16:09 VS, revision 75277

Differentiate between WXK_UP etc. and WXK_NUMPAD_ variants in NSMenuItem code.

2013-11-23 16:09 VS, revision 75276

Don't add NSFunctionKeyMask to NSMenuItem modifiers. This code probably misunderstood NSEvent documentation, where this mask is mentioned, but setKeyEquivalentModifierMask: documentation doesn't list it as allowed. More importantly, it causes "fn" to appear in the menu item and the accelerator doesn't work.

2013-11-23 11:56 VS, revision 75275

Fix selection behavior on right-click in wxGTK wxDataViewCtrl. Select the item under the cursor even when right-clicking it, because it's expected behavior (Nautilus does it too). Fixes #13531.

2013-11-23 11:56 VS, revision 75274

Allow NULL model in wxGTK's wxDataViewCtrl. This is consistent with other ports. Fixes #14616.

2013-11-23 11:56 VS, revision 75273

Fix selection behavior on right-click in wxGTK wxDataViewCtrl. Select the item under the cursor even when right-clicking it, because it's expected behavior (Nautilus does it too). Fixes #13531.

2013-11-23 11:56 VS, revision 75272

Allow NULL model in wxGTK's wxDataViewCtrl. This is consistent with other ports. Fixes #14616.

2013-11-23 01:34 VZ, revision 75271

Add XRC handler for wxAuiToolBar. Also add the demonstration of AUI handlers (this one and the existing one for wxAuiNotebook) to the xrc sample. See #15686.

2013-11-23 01:34 VZ, revision 75270

More version change related changes to the generated files. Somehow not all files seem to have been regenerated after version.bkl change.

2013-11-23 01:33 VZ, revision 75269

Initialize wxAuiNotebookXmlHandler::m_isInside in ctor. Closes #15694.

2013-11-21 21:54 JS, revision 75268

Improved equality test to ignore invalid attributes

2013-11-21 21:54 JS, revision 75267

Improved equality test to ignore invalid attributes

2013-11-21 16:25 JS, revision 75266

Corrected bugs with text effects comparison and style removal

2013-11-21 16:25 JS, revision 75265

Corrected bugs with text effects comparison and style removal

2013-11-21 14:51 VS, revision 75264

Add symbols added in r75258 to version-script.in.

2013-11-21 14:49 VZ, revision 75263

Update version to 3.0.1. And regenerate everything.

2013-11-21 14:49 VZ, revision 75262

Correct the name of Doxyfile containing the version. Use the correct file name in the version update script and version update instructions, it is called just Doxyfile and not Doxyfile_inc now.

2013-11-21 14:47 VZ, revision 75261

Update version to 3.1.0. And regenerate everything.

2013-11-21 14:45 VZ, revision 75260

Correct the name of Doxyfile containing the version. Use the correct file name in the version update script and version update instructions, it is called just Doxyfile and not Doxyfile_inc now.

2013-11-21 14:13 VS, revision 75259

Override ClearColumns() in wxDataViewListCtrl. Without this, the associated store's columns would be out of sync, causing asserts next time a column is appended. Fixes #14952.

2013-11-21 14:11 VS, revision 75258

Override ClearColumns() in wxDataViewListCtrl. Without this, the associated store's columns would be out of sync, causing asserts next time a column is appended. Fixes #14952.

2013-11-21 01:08 VZ, revision 75257

Fix joystick detection in configure under OS X. Don't compare toolkit with OSX which is never used for it, compare it with OSX_COCOA instead. Closes #15692.

2013-11-21 01:08 VZ, revision 75256

Fix wrong printf() format specifiers in the joystick sample. Use "%ld" for the long values, not "%d", they are not the same under LP64 platforms. Closes #15691.

2013-11-21 01:07 VZ, revision 75255

Don't perform any tests for joystick in configure under OS X. The test for setEventCallout() was added in r34541 to work around some problem with OS X 10.1 SDK. As we don't support this version of OS X since a very long time, it shouldn't be needed any longer. See #15692.

2013-11-21 01:07 VZ, revision 75254

Fix joystick detection in configure under OS X. Don't compare toolkit with OSX which is never used for it, compare it with OSX_COCOA instead. Closes #15692.

2013-11-21 01:07 VZ, revision 75253

Fix wrong printf() format specifiers in the joystick sample. Use "%ld" for the long values, not "%d", they are not the same under LP64 platforms. Closes #15691.

2013-11-20 17:04 VZ, revision 75252

Don't process events handled in user code in generic scrolling code. Undo the change introduced, probably accidentally, by r11369 (12 years ago) and skip the default handling of all events except wxEVT_SIZE and wxEVT_PAINT, which are special for the reasons explained in the comments in the code, if the user code has already handled the event. This allows to customize scrolling by selectively handling some scrolling events only and generally makes sense. Closes #15684.

2013-11-20 13:01 VZ, revision 75251

Fix wxRegion::Offset() copy on write behaviour in wxMSW. Offset the correct, new and unshared, region handle instead of the old and possibly shared one. Closes #15690.

2013-11-20 13:01 VZ, revision 75250

Fix assert message when removing non-existent items from wxMenu. The assert complained about a bug in wxMenu code itself, but actually could be triggered by simply trying to remove a non-existent item from the menu. Fix this by checking for the item existence, and also removing it from the internal menu data structure, in wxMenuBase::Remove() and only dealing with the item itself in DoRemove(). Closes #3424.

2013-11-20 13:01 VZ, revision 75249

Fix wxRegion::Offset() copy on write behaviour in wxMSW. Offset the correct, new and unshared, region handle instead of the old and possibly shared one. Closes #15690.

2013-11-19 15:15 VZ, revision 75248

Fix swapping items client data in wxEditableListBox. Use wxUIntPtr, not long, and SetItemPtrData() instead of SetItemData(), to ensure that we preserve the values of client data pointers in 64 bit build, otherwise they were truncated to 32 bits. Closes #15687.

2013-11-19 15:15 VZ, revision 75247

Fix swapping items client data in wxEditableListBox. Use wxUIntPtr, not long, and SetItemPtrData() instead of SetItemData(), to ensure that we preserve the values of client data pointers in 64 bit build, otherwise they were truncated to 32 bits. Closes #15687.

2013-11-19 14:13 VZ, revision 75246

Don't allocate way too much memory in wxVector::reserve(). We multiplied the number of items by the size of each element twice, once in wxVector::reserve() itself and once in Ops::Realloc() it called, so we allocated much more memory than actually needed. Fix this by passing the number of elements to Ops::Realloc().

2013-11-19 14:12 VZ, revision 75245

Don't allocate way too much memory in wxVector::reserve(). We multiplied the number of items by the size of each element twice, once in wxVector::reserve() itself and once in Ops::Realloc() it called, so we allocated much more memory than actually needed. Fix this by passing the number of elements to Ops::Realloc().

2013-11-18 15:21 VZ, revision 75244

Fix replacing "Window" menu in wxMDIParentFrame in wxMSW. When setting a new "Window" menu (as opposed to just modifying the existing one which did work correctly), we shouldn't show it immediately in the menu bar if there are no MDI children, this results in wrong UI and assert failures. Closes #15663.

2013-11-18 15:20 VZ, revision 75243

Fix problem with inserting menus in wxMDIParentFrame menu bar. Account for the "Window" menu (and any other foreign windows lurking in our menu bar) correctly in wxMenuBar::Insert() instead of the old code which apparently tried to do something similar but didn't make much sense and didn't work when trying to insert the menu at the position actually occupied by the "Window" menu in the menu bar. Closes #15662, #1732.

2013-11-18 15:19 VZ, revision 75242

Fix replacing "Window" menu in wxMDIParentFrame in wxMSW. When setting a new "Window" menu (as opposed to just modifying the existing one which did work correctly), we shouldn't show it immediately in the menu bar if there are no MDI children, this results in wrong UI and assert failures. Closes #15663.

2013-11-18 15:19 VZ, revision 75241

Fix problem with inserting menus in wxMDIParentFrame menu bar. Account for the "Window" menu (and any other foreign windows lurking in our menu bar) correctly in wxMenuBar::Insert() instead of the old code which apparently tried to do something similar but didn't make much sense and didn't work when trying to insert the menu at the position actually occupied by the "Window" menu in the menu bar. Closes #15662, #1732.

2013-11-18 12:14 JS, revision 75240

Use % instead of percent in Size dialog; controls more legible on wxGTK

2013-11-18 12:14 JS, revision 75239

Use % instead of percent in Size dialog; controls more legible on wxGTK

2013-11-18 08:49 JS, revision 75238

Fixed refresh bug in border preview control when resizing

2013-11-18 08:49 JS, revision 75237

Fixed refresh bug in border preview control when resizing

2013-11-17 22:55 JS, revision 75236

Backported colour/color consistency

2013-11-17 22:50 JS, revision 75235

Applied #15681: wxRichTextCtrl: Crash when deleting a wxRichTextTable row or column (dghart)

2013-11-17 22:50 JS, revision 75234

Applied #15681: wxRichTextCtrl: Crash when deleting a wxRichTextTable row or column (dghart)

2013-11-17 19:03 VS, revision 75233

Fix Czech translation of "About %s". It is used for the app name, translate it in the commonly used way ("About application %s").

2013-11-17 19:03 VS, revision 75232

Put Services submenu into the Apple menu on OS X. Native applications have a Services submenu in the apple menu. wx applications didn't until now.

2013-11-17 19:03 VS, revision 75231

Add wxMenuBar::OSXGetAppleMenu(). Native OS X apps sometimes have certain app-wide comments in the Apple/app menu ("Check for Updates" is a typical example). Make it possible to write well-behaved OS X apps by exposing this menu to user code.

2013-11-17 19:02 VS, revision 75230

Fix i18n-unfriendly About menu code in wxOSX. The code didn't follow the golden rule of localization and broke user-visible string into separately translated substrings. Replace with the same _("About %s") string already used in wxAboutDialog.

2013-11-17 19:02 VS, revision 75229

Don't duplicate code for Apple menu creation. Have just one copy of the code, instead of two. Eliminate differences between the two versions. As a result, applications now properly have preferences and about items even if window-less.

2013-11-17 19:02 VS, revision 75228

Fix Czech translation of "About %s". It is used for the app name, translate it in the commonly used way ("About application %s").

2013-11-17 19:02 VS, revision 75227

Put Services submenu into the Apple menu on OS X. Native applications have a Services submenu in the apple menu. wx applications didn't until now.

2013-11-17 19:02 VS, revision 75226

Add wxMenuBar::OSXGetAppleMenu(). Native OS X apps sometimes have certain app-wide comments in the Apple/app menu ("Check for Updates" is a typical example). Make it possible to write well-behaved OS X apps by exposing this menu to user code.

2013-11-17 19:02 VS, revision 75225

Fix i18n-unfriendly About menu code in wxOSX. The code didn't follow the golden rule of localization and broke user-visible string into separately translated substrings. Replace with the same _("About %s") string already used in wxAboutDialog.

2013-11-17 19:02 VS, revision 75224

Don't duplicate code for Apple menu creation. Have just one copy of the code, instead of two. Eliminate differences between the two versions. As a result, applications now properly have preferences and about items even if window-less.

2013-11-17 13:43 JS, revision 75223

Removed GetId/GetId and changed span storage to be compatible with 3.0. Fixed border control style.

2013-11-17 11:37 JS, revision 75222

Backported part of r75124: Generalised wxRICHTEXT_CHANGE_OBJECT command so it can now apply to a paragraph as well as an object within a paragraph.

2013-11-17 11:32 JS, revision 75221

Backported r75109: Corrected multiple cell property editing

2013-11-17 11:28 JS, revision 75220

Backported r75108: Fixed print preview glitch and vertical cell alignment.

2013-11-17 11:23 JS, revision 75219

Backported r75107: Fixed selection bug.

2013-11-17 11:20 JS, revision 75218

Backported layout fixes portion of r75105

2013-11-17 10:43 JS, revision 75217

Don't delete composite objects when defragmenting (backport of r75099 from trunk)

2013-11-17 00:41 VZ, revision 75216

Don't eat TAB presses for wxComboBox with wxTE_PROCESS_ENTER in wxMSW. Still allow to use TAB for navigation even when a wxComboBox has wxTE_PROCESS_ENTER style. Use the same hack for wxTextCtrl, i.e. implement the navigation ourselves as we can't let IsDialogMessage() handle it but still get VK_ENTER key presses. Closes #12808.

2013-11-17 00:41 VZ, revision 75215

Add xh_auinotbk.{h,cpp} to the manually maintained VC10 project files. This file existed in automatically generated projects but not this one. Closes #15673.

2013-11-17 00:41 VZ, revision 75214

Allow changing the colour of wxInfoBarGeneric text. Override SetForegroundColour() to forward it to the text control. See #15671.

2013-11-17 00:41 VZ, revision 75213

Set wxInfoBarGeneric text colour correctly. For some reason SetOwnForegroundColour() was used, but we really need to set the colour of the child text control and not our own colour here (which is not used for anything). This makes the text visible even when using non default tooltip colours, which could previously result in black-on-black text. See #15671.

2013-11-17 00:40 VZ, revision 75212

Define SIZEOF_LONG_LONG for Windows. This is important not only for consistency with the other platforms but also because without SIZEOF_LONG_LONG being defined, "%lu" format specifier can't be used with size_t values under Win64, as Arg_Size_t is not defined correctly there if SIZEOF_LONG_LONG is unknown. Closes #15670.

2013-11-17 00:40 VZ, revision 75211

Fix wxSocket::WaitForAccept() in worker thread. This was broken because Select() never returned wxSOCKET_CONNECTION_FLAG which is supposed to be set when a connection is accepted. Closes #15669.

2013-11-17 00:37 VZ, revision 75210

Don't eat TAB presses for wxComboBox with wxTE_PROCESS_ENTER in wxMSW. Still allow to use TAB for navigation even when a wxComboBox has wxTE_PROCESS_ENTER style. Use the same hack for wxTextCtrl, i.e. implement the navigation ourselves as we can't let IsDialogMessage() handle it but still get VK_ENTER key presses. Closes #12808.

2013-11-17 00:37 VZ, revision 75209

Add xh_auinotbk.{h,cpp} to the manually maintained VC10 project files. This file existed in automatically generated projects but not this one. Closes #15673.

2013-11-17 00:37 VZ, revision 75208

Allow changing the colour of wxInfoBarGeneric text. Override SetForegroundColour() to forward it to the text control. See #15671.

2013-11-17 00:37 VZ, revision 75207

Set wxInfoBarGeneric text colour correctly. For some reason SetOwnForegroundColour() was used, but we really need to set the colour of the child text control and not our own colour here (which is not used for anything). This makes the text visible even when using non default tooltip colours, which could previously result in black-on-black text. See #15671.

2013-11-17 00:37 VZ, revision 75206

Define SIZEOF_LONG_LONG for Windows. This is important not only for consistency with the other platforms but also because without SIZEOF_LONG_LONG being defined, "%lu" format specifier can't be used with size_t values under Win64, as Arg_Size_t is not defined correctly there if SIZEOF_LONG_LONG is unknown. Closes #15670.

2013-11-17 00:37 VZ, revision 75205

Fix wxSocket::WaitForAccept() in worker thread. This was broken because Select() never returned wxSOCKET_CONNECTION_FLAG which is supposed to be set when a connection is accepted. Closes #15669.

2013-11-16 14:29 VZ, revision 75204

Make OSXIsGUIApplication() documentation more clear for non Mac people. Provide a more detailed explanation of what this function does and does not.

2013-11-16 14:28 VZ, revision 75203

Port OSXIsGUIApplication() documentation from trunk too. Now that it is implemented (see r75201), it should be documented as well.

2013-11-16 08:19 SC, revision 75202

non-unicode fixes

2013-11-16 08:19 SC, revision 75201

porting fix for non-bundled apps to 3.0.1

2013-11-16 08:11 SC, revision 75200

fixing non-unicode compile

2013-11-15 19:25 VS, revision 75199

Don't crash in wxWindowMac::OSXSimulateFocusEvents(). The code didn't properly account for the possibility of wxEVT_KILL_FOCUS handler deleting the focused window (as happens e.g. in wxListCtrl inline edit controls). E.g. rapidly clicking wxEditableListBox buttons could trigger a crash here when sending wxEVT_SET_FOCUS to an already-deleted window. Use wxWeakRef<> to check if the window is still alive.

2013-11-15 19:25 VS, revision 75198

Don't crash in wxWindowMac::OSXSimulateFocusEvents(). The code didn't properly account for the possibility of wxEVT_KILL_FOCUS handler deleting the focused window (as happens e.g. in wxListCtrl inline edit controls). E.g. rapidly clicking wxEditableListBox buttons could trigger a crash here when sending wxEVT_SET_FOCUS to an already-deleted window. Use wxWeakRef<> to check if the window is still alive.

2013-11-15 18:28 PC, revision 75197

Simplify mode matching test, and add actual mode (not function parameter) to modes list, in GetModes()

2013-11-15 16:26 VZ, revision 75196

Fix blank wxComboBox appearance broken by the changes of r75134. We didn't repaint the owner drawn combobox items any more because they were not found by MSWFindItem(). Fix this by restricting the check to the real windows with the same ID as the combobox, not the dropdown items which are not windows at all. See #15674.

2013-11-15 16:24 VZ, revision 75195

Fix blank wxComboBox appearance broken by the changes of r75134. We didn't repaint the owner drawn combobox items any more because they were not found by MSWFindItem(). Fix this by restricting the check to the real windows with the same ID as the combobox, not the dropdown items which are not windows at all. Closes #15674.

2013-11-15 14:40 VZ, revision 75194

Update the branches to use in the buildbot builds. Stable branch is 3.0 now and not 2.8 any more.

2013-11-15 14:35 VZ, revision 75193

Don't eat mouse wheel events if we can't handle them in wxGTK. The recent changes to mouse wheel scrolling broke it for the generic wxListCtrl and probably any other situation in which scrollbars don't scroll the window itself but some subwindow of it. In this case, the scroll wheel event handler doesn't have any scrollbar to adjust, so it simply does nothing and shouldn't return true, as it did since r74911. Just return false in case we are not doing anything to let the mouse wheel work as before.

2013-11-15 14:34 VZ, revision 75192

Fix assert due to incorrect format being used in listctrl sample. "%d" can't be used with long wxListEvent::GetIndex() value in 64 bit builds.

2013-11-15 14:33 VZ, revision 75191

Don't eat mouse wheel events if we can't handle them in wxGTK. The recent changes to mouse wheel scrolling broke it for the generic wxListCtrl and probably any other situation in which scrollbars don't scroll the window itself but some subwindow of it. In this case, the scroll wheel event handler doesn't have any scrollbar to adjust, so it simply does nothing and shouldn't return true, as it did since r74911. Just return false in case we are not doing anything to let the mouse wheel work as before.

2013-11-15 14:33 VZ, revision 75190

Start a new change log for the changes in wxWidgets 3.1 and later. Keep the old change log as docs/changes_30.txt, it will need to be updated with docs/changes.txt from the 3.0 branch in the future.

2013-11-15 14:33 VZ, revision 75189

Fix assert due to incorrect format being used in listctrl sample. "%d" can't be used with long wxListEvent::GetIndex() value in 64 bit builds.

2013-11-15 14:33 VZ, revision 75188

Add a few more post-release TODO items to the instructions. Announce the release at isocpp.org.

2013-11-15 07:16 PC, revision 75187

Introduce variables for the display and screen in the video mode functions. This cleans up the code somewhat, and prepares for some upcoming changes.

2013-11-14 13:15 VS, revision 75186

Grow text editor control to contain all text in generic wxDataViewCtrl. Implement the behavior that Explorer uses: if the column is too narrow to fit the current text of a cell into it, don't create a too-small text control for it, because it is annoying and confusing (typically, the beginning of the text would be hidden, which is disastrous if it happens to contain numbers). Instead, grow the text control to be larger than the column for more comfortable editing.

2013-11-14 13:14 VS, revision 75185

Cancel editing in generic wxDVC when clicking outside of the editor control. wxDataViewCtrl should behave as Explorer does on Windows: when an inline editor control is open, clicking outside of it should close the editor (preserving changes) in most cases - as a rule of thumb, when the subsequent action could interfere with the editor somehow. This was implemented by watching for focus change and so ignored clicks made on non-focusable controls outside of wxDVC's main window area. In particular, clicks on the list's header were ignored, even though they could result in modifications of the editor's position or size. Don't finish editing when the user right-clicks on the header, consistently with Explorer. Opening the menu likewise still doesn't finish editing, it is needed for access to editing operations. Fixes #15152.

2013-11-14 13:13 VS, revision 75184

Cancel editing in generic wxDVC when clicking outside of the editor control. wxDataViewCtrl should behave as Explorer does on Windows: when an inline editor control is open, clicking outside of it should close the editor (preserving changes) in most cases - as a rule of thumb, when the subsequent action could interfere with the editor somehow. This was implemented by watching for focus change and so ignored clicks made on non-focusable controls outside of wxDVC's main window area. In particular, clicks on the list's header were ignored, even though they could result in modifications of the editor's position or size. Don't finish editing when the user right-clicks on the header, consistently with Explorer. Opening the menu likewise still doesn't finish editing, it is needed for access to editing operations. Fixes #15152.

2013-11-14 13:13 VS, revision 75183

Grow text editor control to contain all text in generic wxDataViewCtrl. Implement the behavior that Explorer uses: if the column is too narrow to fit the current text of a cell into it, don't create a too-small text control for it, because it is annoying and confusing (typically, the beginning of the text would be hidden, which is disastrous if it happens to contain numbers). Instead, grow the text control to be larger than the column for more comfortable editing.

2013-11-13 19:03 PC, revision 75182

build fix for GTK+ 3.10, closes #15667

2013-11-13 18:43 JS, revision 75181

Fixed clashing attribute values

2013-11-13 13:53 VZ, revision 75180

Fix crash when setting invalid label with "&" at the end. We detected that the label was invalid and gave a debug warning message about it but then still proceeded to crash by accessing the data beyond the end of the string. Don't do this. Closes #15665.

2013-11-13 13:52 VZ, revision 75179

Fix crash when setting invalid label with "&" at the end. We detected that the label was invalid and gave a debug warning message about it but then still proceeded to crash by accessing the data beyond the end of the string. Don't do this. Closes #15665.

2013-11-12 19:06 VZ, revision 75178

Merge the changes from 3.0 branch.

2013-11-11 21:59 VZ, revision 75177

Update the checksums for the 3.0 release notes files. Also mention the binaries existence in the top level file.

2013-11-11 14:22 VZ, revision 75176

Tag 3.0.0 release.

2013-11-11 14:10 VZ, revision 75175

Remove "rc2" from the release notes. The hashes are still the old ones and will be updated later as the binaries are not ready yet.

2013-11-11 14:10 VZ, revision 75174

Update the version in wx/version.h and add an item for it to the docs. Mention the need to udpate this file in the release checklist.

2013-11-11 14:10 VZ, revision 75173

Fix the 3.0.0 release date and update the release announcement slightly.

2013-11-11 14:10 VZ, revision 75172

Update the README file to follow the manual introduction closer. It makes sense for the introduction to be a longer version of the README, not a completely different topic.

2013-11-11 13:37 VZ, revision 75171

Add the scripts used to build MSVS wxMSW binaries. Closes #14495.

2013-11-10 19:35 PC, revision 75170

don't need Pango workaround code with GTK+3

2013-11-10 19:26 PC, revision 75169

use gtk_combo_box_get_wrap_width(), we require GTK+ 2.6 now

2013-11-10 19:26 PC, revision 75168

fully initialize GTypeInfo structure

2013-11-10 19:25 VZ, revision 75167

Fix wxFileName compilation in Cygwin builds. Do define StatAny() helper calling either stat() or lstat() under Cygwin, it is available and should be used there even if __WIN32__ is defined.

2013-11-10 19:25 VZ, revision 75166

Add a comment explaining the need for a temporary NULL variable. Explain the changes of r75162 as they risk not being preserved otherwise. Also make this variable static and const because it's really a constant.

2013-11-10 19:25 VZ, revision 75165

Use Cocoa by default for --with-osx and --with-mac configure options. Even though Cocoa is now officially the default port, these options still selected Carbon.

2013-11-10 19:25 VZ, revision 75164

Update minimal required GTK+ version to 2.6 in another place. It really should only appear in a single place only, ideally, but currently we have it in several different documents inside and outside the manual.

2013-11-10 19:13 PC, revision 75163

use G_VALUE_INIT

2013-11-10 18:26 PC, revision 75162

avoid NULL casts, clang says casting nullptr_t is not allowed closes #15660

2013-11-10 16:56 JS, revision 75161

Corrected and tidied XML import/export of standard data members

2013-11-10 14:45 DS, revision 75160

spelling and styling fixes

2013-11-10 14:28 DS, revision 75159

Doc changes. Updated some wxOSX related information.

2013-11-10 10:09 DS, revision 75158

Spelling fixes. Changed "MacOS X" occurrences to "OS X" (in docs only).

2013-11-10 02:48 PC, revision 75157

spelling fixes

Select page:

[] [1 2 3 4 5 27 49 71] []

Imprint