Changelogs

Overview

These changelogs reflect the history of all files in the Subversion repository. The changelog has been generated at 2016-05-09 08:38:04

Changes per page:

25 50 100 250 500 1000 2000

Changelog for wxWidgets (70435 changes):

2012-12-08 01:37 VZ, revision 73139

Catch attempts to create a window with itself as parent. This doesn't happen often but when it does, the results are catastrophic and not always easy to debug, so try catch this as soon as possible.

2012-12-08 01:37 VZ, revision 73138

Remove check of eof() return value validity. It's useless and resulted in a warning from Coverity as it correctly determined that this code could never be executed under Unix.

2012-12-06 06:33 PC, revision 73136

disable Ubuntu "overlay scrollbar", see #14871

2012-12-05 18:38 PC, revision 73134

fix tests for valid pen and brush, broken in r73099

2012-12-05 17:23 JS, revision 73133

wxRTC text box layout fixes

2012-12-04 13:28 VZ, revision 73127

Compilation fir for VC6 after r73124. VC6 doesn't have __debugbreak().

2012-12-04 01:39 VZ, revision 73126

Explicitly set margins for single line text controls in wxMSW. The margin used by them was inconsistent and depended on the initial size the control was created with for some reason. Call EM_SETMARGINS explicitly to ensure consistent appearance in all cases. Closes #2438.

2012-12-04 01:39 VZ, revision 73125

Add missing critical section locking before accessing shared variable. WinThreadStart() in wxMSW wxThread implementation accessed the variable containing the thread state without locking which was wrong, do it only inside the critical section. Notice that there is still an unavoidable race condition between exiting the thread and starting it, so it's not clear at all if we should try to avoid calling DoThreadStart() here. Closes #14865.

2012-12-04 01:39 VZ, revision 73124

Open debugger at the location of failing assert, if possible. Break into the debugger in the function containing the assert that failed instead of inside wxWidgets assert handler which is several (~8) levels below the last line of the user code. This is much more useful in practice and also less confusing. Currently this only works for MSVC as the other compilers don't have any __debugbreak intrinsice equivalent. Also update the except sample to test wxTrap() directly too. Closes #11184.

2012-12-04 00:56 VZ, revision 73123

Tag complete libtiff 4.0.3 on vendor branch.

2012-12-04 00:55 VZ, revision 73122

Add directory somehow omitted from libtiff 4.0.3 import. We don't really need this one but add it to avoid unnecessary differences with the upstream sources.

2012-12-03 20:09 VZ, revision 73113

Tag libtiff 4.0.3 on vendor branch.

2012-12-03 19:22 VZ, revision 73112

Update vendor libtiff sources to version 4.0.3. See #12301.

2012-12-03 19:14 PC, revision 73111

Remove SashHitTest() "tolerance" parameter Mouse events (LeftDown in particular) will only occur if the mouse is over the sash, so it does not make sense to have a fudge factor

2012-12-03 19:04 PC, revision 73110

Avoid setting sash resize cursor when mouse is still over border of second pane with wxGTK This made it possible to have the resize cursor, but not be able to drag the sash, and happened because wxGTK sends a leave event when mouse leaves client area instead of outer border of window. Setting the useless SashHitTest() "tolerance" parameter to zero avoids the problem. Fixes #1397

2012-12-03 18:37 PC, revision 73109

Fix SashHitTest() returning true one pixel past the sash If the sash is n pixels wide, the last position over the sash is start + n - 1, not start + n

2012-12-03 18:05 VZ, revision 73108

Exclude files in vendor branches from svn hook checks. These files correspond to upstream sources and shouldn't be subject to our checks.

2012-12-03 01:34 VZ, revision 73107

wxGTK linking fix after r73102. Remove SendSelectionChangedEvent() declaration, it's now in the base class.

2012-12-03 00:50 VZ, revision 73106

Correct lookup of Explorer-specific file association information. The code added in r52154 never worked because it was looking for the Progid value in a wrong place, look for it under UserChoice subkey where it really is. Also add a way to look up the command to open files with the given extension to the exec sample. Closes #12302.

2012-12-03 00:50 VZ, revision 73105

No changes, just reorganize the menu slightly in the exec sample. Move all file association related commands under "File" menu from the "Exec" one, having them there makes more sense and "Exec" menu is already quite big.

2012-12-03 00:49 VZ, revision 73104

Allow specifying -1 as font size to mean "default" in wxMSW. This has never been officially documented but used to work in 2.8 and still works in wxGTK, so make it works in wxMSW too for consistency. Closes #12541.

2012-12-03 00:49 VZ, revision 73103

Make wxChoice and wxComboBox behaviour same as in native controls in wxMSW. Keep the item selected from the drop down using keyboard when switching away from the control by pressing TAB: although this generates CBN_SELENDCANCEL notification, the selection is actually kept by the native controls in this case, so don't reset it ourselves -- even though it makes sense, it makes wx applications behave differently from the native ones.

2012-12-03 00:48 VZ, revision 73102

Add wxControlWithItems::SendSelectionChangedEvent() helper. Reuse the same event generation code for wxChoice in wxMSW, wxGTK and wxOSX and also wxComboBox in wxMSW and wxGTK instead of duplicating it (incompletely and so partially incorrectly in wxOSX case). This is just a refactoring so no changes in behaviour.

2012-12-03 00:48 VZ, revision 73101

Avoid using "do { ... } while ( wxFalse )" pseudo-loop. This loop can't be optimized away by the compiler because wxFalse is an extern variable which can't be known to be always false. Additionally, this creates many false positives from Coverity as it assumes that the loop can be executed more than once. Define wxSTATEMENT_MACRO_BEGIN/END macros abstracting the exact solution used and replace wxFalse with "(void)0, 0" for now as this seems to placate MSVC (which warns about using a bare "0" as a condition) while still allowing the loop to be completely optimized away.

2012-12-02 21:24 VZ, revision 73100

Warn, don't assert, about unexpected inotify events. In practice we seem to be getting some unexpected inotify() events during heavy IO activity. This shouldn't happen but it does, so at least don't prevent the program from running by popping up the assertion dialog when it happens. Closes #14854.

2012-12-02 06:48 PC, revision 73099

simplify code so it always returns the same object

2012-12-02 06:11 PC, revision 73098

clean up wxCairoRenderer initialization mess Remove unused Unload(), wxCairoCleanUp(), m_loaded and gCairoRenderer, and redundant Load() and EnsureIsLoaded(). Just call wxCairoInit() directly, and for GTK do nothing at all.

2012-12-02 04:35 PC, revision 73097

remove unnecessary include of wx/cairo.h

2012-12-02 03:28 PC, revision 73096

Remove nearly empty wx/cairo.h header It does so little now it's not worth having. And it should not have been a public header.

2012-12-02 00:06 PC, revision 73095

use stock colour/pen/brush objects in samples

2012-12-01 23:34 PC, revision 73092

use new pen/brush style names in samples

2012-12-01 23:14 PC, revision 73091

remove colour/pen/brush arguments which are the default in the samples

2012-12-01 19:30 PC, revision 73089

Fix path returned from wxFileDialog, closes #14786

2012-12-01 01:14 VZ, revision 73086

Use disabled colour for the dropdown arrow of disabled ribbon. Previously the normal colour was used for the arrow in MSW art provider even if the ribbon was disabled. Closes #14864.

2012-12-01 01:14 VZ, revision 73085

Miscellaneous spelling and typo fixes in the documentation. Closes #14866.

2012-12-01 01:14 VZ, revision 73084

Fix premature truncation of brief descriptions in Doxygen comments. Don't end the brief description at the first period if it's a period which is part of "i.e." or "e.g.": escape the space following it to prevent Doxygen from recognizing it as an end of sentence. See #14866.

2012-12-01 01:13 VZ, revision 73083

Fix documentation of wxGridBagSizer::Add() spacer overload. Describe the width and height parameters. See #14866.

2012-11-30 23:28 RD, revision 73070

Interface fixes for Phoenix

2012-11-30 19:21 PC, revision 73068

simplify code to return from the end of the function

2012-11-30 19:01 PC, revision 73067

indentation fixes

2012-11-30 07:56 PC, revision 73066

move wxGet{Colour,Font}FromUser() out of utilscmn.cpp so they don't have to be in every app that links statically

2012-11-29 23:03 VZ, revision 73065

Don't assert when stopping watching a just renamed file. (Almost) silently ignore renames of the files which we don't watch any longer instead of asserting if this happens. Closes #14863.

2012-11-29 23:02 VZ, revision 73064

Log invalid inotify() events without a valid watch descriptor. Apparently we can get events without any valid watch descriptor, even though this is not supposed to happen. At least warn about them. See #14854.

2012-11-29 23:02 VZ, revision 73063

Correct handling of IN_Q_OVERFLOW in wxFileSystemWatcher Linux code. Don't use wd field if it's -1 which can happen for IN_Q_OVERFLOW. See #14854.

2012-11-29 11:17 JS, revision 73060

Cope with the common case of utf-8 being specified in the .hhp file, and convert the book title.

2012-11-29 11:15 JS, revision 73059

Cope with the common case of utf-8 being specified in the .hhp file, and convert the book title.

2012-11-29 08:53 PC, revision 73058

declare wxQsort in vector.h as well as utils.h to work around circular header dependency mess

2012-11-29 08:00 JJ, revision 73057

Do not use GTKIsUsingGlobalMenu when compiled against gtk1.x

2012-11-29 00:56 VZ, revision 73056

Fix bezel used for bitmap buttons in wxOSX/Cocoa. Don't use NSRoundedBezelStyle for bitmap buttons as this bezel has fixed height. Instead, use NSRegularSquareBezelStyle which can used with buttons of any size and is the correct bezel to use for the buttons mostly identified by their icon according to Apple docs. Notice that we still use the standard bezel for the "small" (where "small" is arbitrarily defined by the hard coded 20 pixels height) icons as those are usually used in addition to the text and not replacing it and so it makes more sense to use the same bezel as for the normal buttons for them.

2012-11-29 00:56 VZ, revision 73055

Select the entire spin control contents when changing its value. Selecting the entire contents makes it more convenient for the user to enter the new value.

2012-11-29 00:55 VZ, revision 73054

Handle Shift-TAB correctly in wxOSX/Carbon wxComboBox. The navigation event direction should depend on Shift key state. See #3821.

2012-11-28 21:57 SC, revision 73053

adding some additional fixes for programmatic selection handling

2012-11-28 18:14 RD, revision 73052

Compilation fix.

2012-11-28 16:42 VZ, revision 73051

Compilation fixes after r73050. See #14862.

2012-11-28 15:18 VZ, revision 73050

Add "rect" paramerer to wxRichToolTip::ShowFor(). Allow to show the tooltip at the exact specified position instead of placing it automatically. Closes #14862.

2012-11-28 15:17 VZ, revision 73049

Add missing wxUSE_OLE checks to safearray.cpp. Fix compilation with wxUSE_OLE==0. Closes #14860.

2012-11-28 15:17 VZ, revision 73048

Compilation fix for wxDocManager after r73004. Define GetXXXVector() methods after all the classes are fully declared to ensure that static_cast<> inside wxList::AsVector() they use compiles with the OpenVMS compiler. See #14814.

2012-11-28 11:13 SC, revision 73047

support for inheriting non-standard attributes (explicit fonts instead of window variants), fixes #3583

2012-11-28 09:51 SC, revision 73046

supporting selection methods when not focused, closes #1480

2012-11-27 20:16 SC, revision 73045

simulating focus events, see #13495

2012-11-27 20:09 SC, revision 73044

support for simulating focus events since not all controls can be focused

2012-11-27 14:23 SC, revision 73043

emulating wx' focus-lost behavior

2012-11-27 14:22 SC, revision 73042

spell error fixed

2012-11-27 09:29 SC, revision 73041

workaround, see #14856

2012-11-27 08:42 JJ, revision 73040

Fix OpenVMS makefile

2012-11-27 02:19 RD, revision 73029

More interface fixes for Phoenix

2012-11-27 00:53 VZ, revision 73028

Compilation fix to docview sample after r73004. Don't use wxDocManager::GetDocumentsVector() with VC6 which doesn't have it.

2012-11-26 19:30 PC, revision 73027

disconnect "toggled" signal in dtor when style has wxALIGN_RIGHT

2012-11-26 18:53 PC, revision 73026

fix for GTK assert after r72696, a draw/expose_event signal may also be attached to parent

2012-11-26 16:51 VZ, revision 73025

Disable CallAfter() for MSVC 7 too, it can't compile this code. It was already disabled for VC6 but VC7 doesn't compile this code neither, so disable it for this compiler as well.

2012-11-26 16:50 VZ, revision 73024

Bracket vararg macro definition with wxHAS_VARIADIC_MACROS. This should fix tests compilation with VC6.

2012-11-26 14:50 VZ, revision 73023

Another Nepalese translations update.

2012-11-26 14:14 VZ, revision 73022

Fix wxALWAYS_SHOW_SB behaviour in wxGTK. Don't show the scrollbar always if it's not enabled at all, i.e. if the corresponding wxHSCROLL or wxVSCROLL style is not specified.

2012-11-26 14:14 VZ, revision 73021

Fix harmless warning about uninitialized variable in fswatcher sample. Just always initialize it.

2012-11-26 14:13 VZ, revision 73020

Fix warnings about using type attribute on forward declaration. This results in many, many warnings in OS X build.

2012-11-26 00:18 VZ, revision 73019

Fix wxGenericListCtrl scrolling by not processing the events twice. Scrolling wxGenericListCtrl was broken since r72939 because its OnScroll() event handler explicitly called wxScrollHelper::HandleOnScroll() which was also called by the base class ProcessEvent(). Arguably, wxScrollHelper::ProcessEvent() should be updated to allow handling events directly like this by not processing it again if the event wasn't skipped but for now just do skip the event and let the default handling take place which at least makes wxGenericListCtrl work correctly again. Closes #14852.

2012-11-26 00:17 VZ, revision 73018

Fix TAB navigation in wxGTK broken by r72663. Don't call SetCanFocus(true) for container windows with focusable children, this doesn't play well at all with wxGTK focus handling and in particular totally disabled TAB navigation.

2012-11-26 00:17 VZ, revision 73017

Restore generic GetPartialTextExtents() version use in wxGTK and wxMSW. Non-wxWindowDC-derived wxDC classes in wxGTK, such as wxGtkPrinterDCImpl, have to fall back on the generic implementation of GetPartialTextExtents() as Pango version can't be used with them. This fixes a crash due to using NULL Pango layout when printing wxRichTextCtrl in wxGTK. Closes #14847.

2012-11-26 00:17 VZ, revision 73016

Don't dereference NULL output pointer in wxTextMeasure. Check that pointers are non-NULL before assigning 0 to them.

2012-11-25 22:30 PC, revision 73015

backport r56474, "fix for assert failure when first paint event occurs before first idle event" closes #10085

2012-11-25 12:51 VZ, revision 73014

Handle UBUNTU_MENUPROXY=0 as "not using global menu". Although the correct way to disable the global menu bar under Ubuntu is to set UBUNTU_MENUPROXY to an empty string, many guides on the web advise setting it to "0", so handle this special case in wxApp::GTKIsUsingGlobalMenu() too.

2012-11-25 04:41 PC, revision 73013

avoid functions deprecated in GTK3

2012-11-25 03:49 PC, revision 73012

fix wxBitmapComboBox Gtk-CRITICAL assertion `GTK_IS_ENTRY (entry)' failed

2012-11-25 03:30 PC, revision 73011

non-pch build fix

2012-11-25 03:23 PC, revision 73010

Simplify GetDefaultAttributesFromGTKWidget() by passing the widget to use, rather than a pointer to a function to create the widget

2012-11-25 01:15 VZ, revision 73009

Use idle time menu updating when using global menu bar in wxGTK. We don't get wxEVT_MENU_OPEN events when using the global menu bar so don't rely on them for updating the menu items status and fall back to idle time menu updating if the global menu bar is used. This required changing wxUSE_IDLEMENUUPDATES tests from compile- to run-time ones. Closes #14302.

2012-11-25 01:15 VZ, revision 73008

Add wxApp::GTKIsUsingGlobalMenu() helper to wxGTK. This allows to check whether the global menu is being used and will be mostly useful for working around various bugs/problems uncovered by it. See #14302.

2012-11-25 01:15 VZ, revision 73007

Ignore menu events while modal dialogs are shown in wxGTK. Normally menus are disabled in this case but not when running under Ubuntu Unity, so add an explicit test for this to avoid breaking the program expected flow of control by allowing the user to show the same modal dialog twice, for example. This is not ideal, it would be better to visually disable the menu while the modal dialogs are shown but is better than nothing. Closes #14823.

2012-11-25 00:01 VZ, revision 73006

Blind compilation fix for VC6 after r73004. Define wxDocTemplateVector for VC6 too, it's used in docview.cpp. Also wrap too long lines.

2012-11-24 22:49 PC, revision 73005

silence GCC warning "enumeral and non-enumeral type in conditional expression"

2012-11-24 18:37 VZ, revision 73004

Add wxDocManager::Get{Views,Documents,Templates}Vector(). Add accessors returning more convenient wxVectors to supplement the existing ones giving access to internally used wxLists. Closes #14814.

2012-11-24 18:36 VZ, revision 73003

Add wxList::AsVector<>() helper. This can be useful in legacy code using wxList to progressively replace it with wxVector. See #14814.

2012-11-24 18:36 VZ, revision 73002

Don't include wx/utils.h from wx/vector.h. This will allow to include wx/vector.h from wx/list.h which is itself included from wx/utils.h by breaking this circular dependency. Don't use wxMin(), defined in wx/utils.h, in order to do this. See #14814.

2012-11-24 01:33 VZ, revision 73001

Use wxBufferedPaintDC for wxStyledTextCtrl drawing in wxGTK. GTK+ doesn't seem to use double buffering for Scintilla window for some reason, resulting in bad flicker when it's updated, e.g. when the user types into it. Force the use of double buffering at wxWidgets level by using wxBufferedPaintDC for painting it. This may be inefficient if GTK+ does double buffer it in some cases but at least it gets rid of the flicker. Closes #12704, #14828.

2012-11-24 01:33 VZ, revision 73000

Add check for destroying window with mouse capture in wxGTK. We already have an assert checking for this at wxWindowBase level but it seems that it wasn't always triggered somehow (maybe because we crashed before getting there?), so do it sooner. Closes #14602.

2012-11-23 20:02 SC, revision 72999

support for custom app controllers, override OSXCreateAppController in wxApp subclass

2012-11-23 15:34 VZ, revision 72998

Fix ribbon bar scroll buttons visibility bug. Fix scroll buttons update code in wxRibbonPage. Closes #14844.

2012-11-23 15:32 VZ, revision 72997

Add possibility to delay showing wxRichToolTip. Optionally show the tooltip after a delay instead of doing it immediately when Show() is called. Closes #14846.

2012-11-23 08:55 SC, revision 72996

fixing overrelease and out-of-bounds write, fixes #13725

2012-11-20 13:49 VZ, revision 72995

Implement GetSizeFromTextSize() for wxSpinCtrl. Implement it for the native MSW and GTK versions and the generic one used in the other ports and also for wxSpinCtrlDouble under MSW. Also test this function in the spin page of the widgets sample. Closes #14840.

2012-11-20 13:49 VZ, revision 72994

Make wxSpinCtrlGenericBase a wxCompositeWindow. This takes care of propagating methods setting fonts and colours to the subwindows automatically, so that setting font for the generic wxSpinCtrl now works, unlike before. Closes #14839.

2012-11-20 13:49 VZ, revision 72993

Revert all wxNOEXCEPT-related changes. This reverts r72978, 72984, 72989 and 72992. Do not use wxNOEXCEPT for wxTextCtrl dtor as this breaks compilation of any user-defined classes inheriting from it unless they use wxNOEXCEPT as well and the benefits (fixing a harmless warning for the niche ICC compiler) are just not worth the compatibility breakage. See #14826.

2012-11-20 01:57 VZ, revision 72992

Fix another compilation problem after wxNOEXCEPT introduction. Also add wxNOEXCEPT to wxTextCtrl dtor definition in wxMSW. See #14826.

2012-11-19 19:07 VZ, revision 72990

Add wxTL_NO_HEADER style to wxTreeListCtrl. Closes #14838.

2012-11-19 19:01 VZ, revision 72989

More compilation fixes after wxNOEXCEPT introduction. This is a temporary change, r72984 and the following changes (see #14826) will probably be reverted soon anyhow, but for now at least fix wxGTK compilation. Closes #14837.

2012-11-19 14:06 SC, revision 72988

implementing delayed freezing, fixes #12865

2012-11-19 13:52 VZ, revision 72987

Add wxFSW_EVENT_UNMOUNT wxFileSystemWatcher flag and implement it for Linux. This flag generates the corresponding event when the file system containing the watched directory is unmounted. Currently it is only implemented for Linux where unmounting now generates this event instead of an error. Closes #14834.

2012-11-19 13:51 VZ, revision 72986

Convert wxFSW_EVENT_{WARNING,ERROR} to string correctly. Previously these types were not handled at all, resulting in asserts. See #14834.

2012-11-19 12:54 VZ, revision 72985

Implement wxLocale::GetSystemEncodingName() for wxOSX. Use CFStringGetNameOfEncoding() to get the canonical name of the encoding from OS X itself. Closes #2571.

2012-11-19 12:53 VZ, revision 72984

Add wxNOEXCEPT to all wxTextCtrl dtors. Fix compilation with some compilers after r72978 which added wxNOEXCEPT to wxTextCtrlBase dtor and wxTextCtrl dtor in wxMSW but not in all the other ports. See #14826.

2012-11-19 05:17 PC, revision 72983

put both versions of wxGetMousePosition in one place so they can use one implementation

2012-11-19 03:29 PC, revision 72982

fix object referencing with wxSL_MIN_MAX_LABELS

2012-11-18 01:17 VZ, revision 72981

Define SPI_GETCARETWIDTH ourselves if it's not defined. This fixes another compilation error for VC6.

2012-11-18 01:14 VZ, revision 72980

Compilation fixes for VC6 after MSWGetComboBoxInfo() introduction. Don't use COMBOBOXINFO outside of WINVER checks, we can only use tagCOMBOBOXINFO that we forward declared ourselves.

2012-11-18 00:56 VZ, revision 72979

Fix path returned from wxGTK wxFileDialog too. This is similar to the fixes to wxDirDialog in r72779. Closes #14786.

2012-11-18 00:56 VZ, revision 72978

Add wxNOEXCEPT and use it for std::streambuf-derived classes. This fixes warnings from Intel compiler about overriding function using a different exception specification than the base one and also incidentally provides a handy macro that can be useful in other situations. Closes #14826.

2012-11-18 00:56 VZ, revision 72977

Add wxFSW_EVENT_ATTRIB wxFileSystemWatcher flag. This flag allows to monitor changes to the file attributes, such as file modification time. This patch adds the flag, support for it under Linux and the corresponding modifications to the sample and the test suite. Closes #14833.

2012-11-18 00:55 VZ, revision 72976

Fix typo in include/wx/generic/private/richtooltip.h header guard. A wrong symbol was being defined.

2012-11-17 23:17 RD, revision 72966

Fix broken and missing DataView interface items for Phoenix

2012-11-17 14:34 SJL, revision 72965

Fixed unused parameter warnings for webview on OSX.

2012-11-16 08:35 PC, revision 72964

avoid deprecated functions with GTK3

2012-11-16 08:30 PC, revision 72963

silence warnings about unhandled enum value in switch

2012-11-16 08:24 PC, revision 72962

Remove code that has no effect Adjusting the wxEVT_ENTER_WINDOW mouse position is pointless, execution won't reach that far if gdk_event->window != gtk_widget_get_window(widget), and GetClientAreaOrigin() always returns (0,0).

2012-11-15 23:24 VZ, revision 72961

Support monitoring only some events in wxGTK wxFileSystemWatcher. Call inotify() with the appropriate flags instead of always using IN_ALL_EVENTS. Closes #14832.

2012-11-15 19:48 VZ, revision 72960

Restore setting focus to generic wxDataViewCtrl on any mouse click. The changes of r72632 resulted in focus not being given to wxDataViewMainWindow on right or middle click, restore this behaviour.

2012-11-15 19:45 VZ, revision 72959

Document how to build wxOSX/Carbon under recent OS X. Mention that Xcode 3 is needed for this. Closes #14524.

2012-11-15 13:22 VZ, revision 72958

Add back WINVER check to fix VC6 compilation of wxMSW. The changes of r72953 removed the check for WINVER around the code using COMBOBOXINFO but it's still needed with VC^, so restore it.

2012-11-14 19:19 PC, revision 72957

Fix GetClientSize() when scrollbars are present The value of GtkScrolledWindowClass.scrollbar_spacing seems to be invalid (-1). Use the style property "scrollbar-spacing" instead.

2012-11-14 17:55 PC, revision 72956

re-enable using our own resize grip with GTK3, themes can (and do) disable the native grip

2012-11-14 14:48 VZ, revision 72955

Implement wxComboCtrl::GetSizeFromTextSize(). Improve calculation of wxComboCtrl best size which doesn't work correctly for non-default fonts as shown by r72935. It is still not perfect but better now. Closes #14825.

2012-11-14 14:47 VZ, revision 72954

Implement DoGetSizeFromTextSize() for wxMSW wx{Choice,Combobox,TextCtrl}. Refactor and improve the existing DoGetBestSize() implementations to use DoGetBestSize(). Closes #14816.

2012-11-14 14:47 VZ, revision 72953

No changes, just refactor wxMSW wxComboBox code calling GetComboBoxInfo(). Move the code dynamically loading this function to the base wxChoice class to make it possible to use it from there in the upcoming commit.

2012-11-14 14:47 VZ, revision 72952

Handle wxBORDER_NONE in wxGTK wxTextCtrl::DoGetSizeFromTextSize(). Don't add margins for the controls without borders, they are not used in this case. See #14816.

2012-11-14 14:46 VZ, revision 72951

Don't call setlocale("") on startup by default any longer. This undoes the changes of r44773 because calling setlocale() resulted in C locale being set differently from C++ locale which was confusing and led to huge slowdowns in any code using std::stream with at least MinGW. And setting the C++ locale to be the same, as r72719 tried to do, doesn't seem to be practical as it results in immediate crashes under OS X and MinGW when used under XP. Do provide wxApp::SetCLocale() helper to explicitly do what was previously done implicitly, even though currently it is a trivial wrapper for setlocale() and we don't even need to call gtk_set_locale() as it has never done anything else and is deprecated since GTK+ 2.24. Closes #14780.

2012-11-14 01:16 VZ, revision 72950

Optionally allow showing tooltips for disabled ribbon buttons. Add wxRibbonButtonBar::SetShowToolTipsForDisabled() to allow enabling the tooltips even for the disabled buttons. Closes #14820.

2012-11-13 18:38 PC, revision 72949

re-enable drawing our own resize grip with GTK3, themes can (and do) disable the native grip

2012-11-13 13:36 VS, revision 72948

Fix wxGTK's wxFileDialog:Get/SetFilename() to be in sync. The m_fileName and m_dir variables, managed by the base class, were out of sync when the dialog wasn't shown yet, because the wxGTK implementation didn't always set them. GetFilename() following SetFilename(x) could return something other than x. Fixed by calling the base class version.

2012-11-12 16:50 VZ, revision 72947

Replace a template function with template class to fix VC6 build. VC6 doesn't like template methods, so use a helper template class instead, hopefully this will finally allow it to compile the test suite again.

2012-11-12 14:36 SC, revision 72946

making sure we have an initial frame buffer, even though the first initial rootview controller lead to an empty framebuffer

2012-11-11 14:10 VZ, revision 72945

Use wxID_EXIT for the "Quit" item in the exec sample. This fixes the behaviour of the standard "Quit" menu item under OS X. See #3204.

2012-11-10 13:40 VZ, revision 72944

Disallow drop downs on AUI check buttons. This doesn't make much sense and disallowing it makes check items consistent with radio ones as previously you could set up a dropdown for the former but not for the latter. Also update the documentation of the relevant methods. Closes #14795.

2012-11-10 13:22 VZ, revision 72943

Fix crashes after using "wildcard" wxEvtHandler::Disconnect(). When not specifying the function to disconnect, the associated event sink was destroyed too early resulting in crashes later. Fix this and add unit tests verifying that things work as expected and at least don't crash. Closes #14563.

2012-11-10 13:22 VZ, revision 72942

No changes, just fix a harmless warning in FileSystemWatcherTestCase. Fix an unused parameter warning under non-Unix platforms.

2012-11-10 13:21 VZ, revision 72941

Fix filename test compilation with VC6. Just disable tests resulting in an internal compiler error.

2012-11-10 01:53 VZ, revision 72940

Fix link errors with VC 11 in DLL STL build. Don't declare wxWindowList as DLL-exported. It's unnecessary and appears to create problems for VC 11. Closes #14741.

2012-11-10 01:53 VZ, revision 72939

Simplify wxEVT_PAINT handling in wxScrollHelperBase. Just always call the virtual OnDraw() if wxEVT_PAINT wasn't handled. This is much simpler than connecting our own special handler just to set a flag saying whether the event was processed which was very complicated and didn't work anyhow for the statically connected wxEVT_PAINT handlers. See #14757.

2012-11-10 01:52 VZ, revision 72938

Cache HDC used for painting for the entire duration of WM_PAINT processing. This fixes a long standing problem with 2 wxPaintDC created one after another (and not with nested lifetimes, which was handled by the caching mechanism previously used) not working correctly. And as this was exactly what happened when handling wxEVT_PAINT for wxScrolled, it also fixes drawing artefacts when using scrolled windows. Closes #14757.

2012-11-10 01:52 VZ, revision 72937

Fix incorrect wxSizerFlags::Border() call in the scroll sample. Using 20 instead of a wxDirection resulted in an assert, fix the syntax.

2012-11-10 01:52 VZ, revision 72936

Set ID correctly for wxScrollWinEvents generated by wxScrollHelper. Add forgotten wxEvent::SetId() calls. See #14757.

2012-11-09 22:11 VZ, revision 72935

Add wxControl::GetSizeFromTextSize() to size the control to its text. This function can be used to size a, say, wxTextCtrl to be exactly of the size needed to enter the given amount of text in it. This patch adds wxGTK implementation for wxTextCtrl, wxChoice and wxCombobox; changes to the samples and the documentation. Closes #14812.

2012-11-09 07:17 PC, revision 72934

avoid deprecated functions with GTK3

2012-11-09 06:02 RD, revision 72933

wxBrushList and wxFontList do not derive from wxList.

2012-11-08 18:47 PC, revision 72927

don't assign NULL to wxUIntPtr, wxUIntPtr is not a pointer, closes #14811

2012-11-08 18:34 PC, revision 72926

avoid using deprecated gdk_cursor_unref() with GTK3

2012-11-08 18:18 PC, revision 72925

Disable GTK2-specific code to change theme when building wxGTK3. It doesn't work with GTK3, it causes deprecation warnings, and allowing an app to change its theme is a dumb idea

2012-11-08 16:46 SC, revision 72924

support for freeze and thaw under cocoa

2012-11-08 15:20 VZ, revision 72923

No changes, just remove unnecessary forward declarations. wxToggleBitmapButton doesn't exist any more, don't forward declare it. wxToggleButton does exist but is (fully) declared just below, so don't forward declare it neither.

2012-11-07 19:10 VZ, revision 72922

Another Nepalese translations update from Him Prasad Gautam.

2012-11-07 18:58 PC, revision 72921

update fullscreen state when it is changed by the WM

2012-11-07 11:02 JJ, revision 72920

Update OpenVMS make-files

2012-11-07 10:00 JJ, revision 72919

Fix for specific filename syntax of OpenVMS

2012-11-07 07:32 PC, revision 72918

add GTK3 implementations for remaining renderer functions

2012-11-07 00:57 VZ, revision 72917

Don't leave orphan taskbar icon window alive if setting it up fails. This fixes a rare bug which happens when we fail to install the task bar icon under MSW for whatever reason (the only known way to reproduce it is to try to do it very quickly after resume from suspend but there might be other situations in which this happens). In this case we must delete the icon as we are not going to get any timeout expiration notifications for it and so if we don't delete it immediately, it would remain alive forever, preventing the application from exiting as it counts as a top level window.

2012-11-07 00:56 VZ, revision 72916

Keep item data in sync with their position in wxEditableListBox. When swapping the items, we also need to swap their client data and not just their labels. Closes #14800.

2012-11-07 00:56 VZ, revision 72915

Restore propagation of EVT_SEARCHCTRL_CANCEL_BTN events to the parent. This was broken by r72581, add event.Skip() call to the handler for this event added there. Also add a handler for this event to the corresponding page of the widgets sample to be able to test this. Closes #14799.

2012-11-07 00:54 VZ, revision 72914

Fix regression with wxAuiToolBar gripper and overflow members initialization. The changes of r72785 moved m_gripperVisible and m_overflowVisible initialization to Init() but this was too early as these fields depend on the window style only set when it's really created, so re-initialize them to their proper values in Create(). Closes #14794.

2012-11-07 00:54 VZ, revision 72913

Use wxAUI_TB_DEFAULT_STYLE instead of 0 as default style value. No real changes. See #14794.

2012-11-07 00:54 VZ, revision 72912

Minor improvements to wxEVT_COMMAND_DIRCTRL_CHANGED generation. Set the event object for this event. Also don't skip the original tree event if the wxEVT_COMMAND_DIRCTRL_CHANGED event was handled and disallowed. Closes #14792.

2012-11-07 00:53 VZ, revision 72911

Add wxUSE_BASE checks for wxLog classes in the interface header. Also rearrange them so that the derived classes always appear after the base ones, otherwise SWIG can't compile this file. Closes #14784.

2012-11-07 00:53 VZ, revision 72910

Add wxUSE_{BASE,GUI} checks to interface headers. This allows to define just one of them to run some tool, e.g. SWIG, on only the classes defined in the base or in the core library (both are defined by default for Doxygen itself). Closes #14785.

2012-11-06 18:43 PC, revision 72908

add GTK3-specific code for DrawItemSelectionRect(), fixes drawing selected tree control item

2012-11-06 17:51 VZ, revision 72907

No changes, just fix indentation in wxDataViewMainWindow::Expand(). The code was indented two extra levels for some reason.

2012-11-06 17:51 VZ, revision 72906

Update the current row after item deletion in generic wxDataViewCtrl. Also change the code changing the current item to collect the range checks inside OnVerticalNavigation() itself instead of doing them in the caller. Closes #14802.

2012-11-06 17:50 VZ, revision 72905

Never collapse invisible root item in generic wxDataViewCtrl. Since the changes of r72325, the root item could be collapsed and marked as not having any children but this was wrong because no items could be added to it after this. Just ignore any attempts to collapse it. Closes #14801.

2012-11-06 17:25 VZ, revision 72904

Remove __WXMSW__ check around background erasing in generic wxDataViewCtrl. The background was erased only under MSW for some reason, do it everywhere now.

2012-11-06 07:35 SC, revision 72903

fixing compile for ios

2012-11-06 07:31 SC, revision 72902

supporting iOS 6 autorotate

2012-11-05 00:55 VZ, revision 72898

Slightly improve the date/time dialogs in the calendar sample. Use CreateStdDialogButtonSizer() instead of constructing wxStdDialogButtonSizer directly, not only this is shorter but it also makes the "OK" button default correctly. Also initialize the labels instead of leaving them initially empty.

2012-11-05 00:55 VZ, revision 72897

Don't move the insertion point if text didn't change in wxTextEntry. This avoids accidentally resetting the selection if SetValue() is called again with the same value. Closes #13728.

2012-11-05 00:54 VZ, revision 72896

Make hack for button creation in wxOSX more robust. Don't crash when creating a plain wxButton with wxBU_NOTEXT style. This happened because we skipped creating the peer (real implementation) in this case entirely on the assumption that we were creating a wxBitmapButton, but this is not necessarily the case. So now test that the creation of the peer is really disabled before skipping it (this required adding ShouldCreatePeer() accessor). Merging wxWidgetImpl::CreateButton() and CreateBitmapButton() (and the same thing for toggle buttons) would still be a better solution but while it's trivial to do for Cocoa, it isn't for Carbon. And we can't use a single function for Cocoa but different functions for Carbon, so for now just continue to use this hack. Closes #13622.

2012-11-05 00:54 VZ, revision 72895

Ensure that paths used inside wxOSX are always in NFC form. OSX uses NFKD but this is unexpected for wx applications, so normalize the string to use the composed form whenever we receive a file system path from OS X. Closes #13504.

2012-11-05 00:53 VZ, revision 72894

Add wxCFStringRef::AsStringWithNormalizationFormC() Cocoa overload. Provide an overload taking NSString and casting it to CFStringRef, just as for AsStringWithNormalizationFormC(). See #13504.

2012-11-05 00:53 VZ, revision 72893

Use kCGBlendModeExclusion for wxCOMPOSITION_XOR operation. The previously used kCGBlendModeXOR doesn't seem to be the right mode to use. Closes #13095.

2012-11-05 00:53 VZ, revision 72892

Implement setting default wxTextCtrl style in wxOSX. Use NSTextView setTypingAttributes to change the attributes used for the new text by default as setting them for the selected region didn't do anything useful under OS X (and did nothing at all when there was no selection). Closes #12839.

2012-11-05 00:52 VZ, revision 72891

No changes, just remove unnecessary wxTextAttr tests. If wxTextAttr::HasFoo() returns true, there is no need to test for GetFoo().IsOk().

2012-11-05 00:52 VZ, revision 72890

Suppress warnings about NSText not responding to setAllowsUndo. Cast NSText to NSTextView when sending this message to it. Hopefully it doesn't change the run-time behaviour but just fixes several lines of warnings that were given without this cast.

2012-11-05 00:51 VZ, revision 72889

No changes, just make it easier to tweak splitter sample. The sample contains disabled code for using other type of windows than MyCanvas for the splitter children but it didn't compile any more because the variables were declared as wxScrolledWindow. Fix this by using just wxWindow for them.

2012-11-05 00:51 VZ, revision 72888

Create tags for Cocoa, not Carbon, by default under wxOSX. Just change the default value of the "port" parameter.

2012-11-05 00:51 VZ, revision 72887

Fix annoying warning when running the script to generate tags under OS X. It complained about no matches for src/osx/cocoa/*.cpp.

2012-11-05 00:50 VZ, revision 72886

Update the button bezel to account for multi-line labels in wxOSX. If a button was created using a normal single-line label (including empty one) and then its label was changed to something multi-line later, its size stayed wrong in wxOSX as it still used the fixed size bezel used by normal buttons. Adjust the bezel after each bezel change now to update the size of the button if necessary. Closes #12491.

2012-11-05 00:50 VZ, revision 72885

No changes, just rename OSXSetAcceleratorFromLabel(). Make the name of the function more general and call it OSXUpdateAfterLabelChange() as it's supposed to be called whenever the label changes.

2012-11-05 00:50 VZ, revision 72884

No real change, just make bezel setting code in wxOSX more clear. Avoid code duplication between SetAcceleratorFromLabel() and wxWidgetImpl::CreateButton(), generalize the former to handle the special cases taken into account only in the latter previously. Also use a switch on border flags instead of series of nested ifs as this seems to be more clear. No changes in behaviour.

2012-11-05 00:49 VZ, revision 72883

Revert "Fix the pages range in the print dialog in wxOSX." This reverts r72805 (leaving only the changes to printdlg.cpp which seem harmless and potentially useful) as it resulted in crashes when using wxHtmlEasyPrinting because we called wxPrintout::OnPreparePrinting() before setting the DC to be used, which was wrong. In fact it's not clear how can we get the correct range of pages at all because we need a DC to paginate properly (i.e. taking into account its size) but we need to show a dialog, in which we already want to show the pages range, before choosing the DC. Perhaps we could create a dummy DC for pagination purposes but how could this work with printers using different page sizes? The best would probably be to avoid setting any limits on the page range as showing 9999 looks ugly but anything else would be wrong. See #8349, #11779.

2012-11-05 00:49 VZ, revision 72882

Update tree control layout in EditLabel() for wxOSX too. A special preprocessor check for OS X prevented the control from being relaid out correctly in EditLabel() there, which resulted in problems when trying to edit a just added item. Simply remove this check for OS X (and also MSW but this is less important as this version of the control is almost never used there anyhow) to fix it. Closes #11179.

2012-11-04 18:39 PC, revision 72881

fix setting background color in wxGTK3 with themes which use background images or gradients, fixes #14759

2012-11-04 13:44 VZ, revision 72880

Check that doxygen version is 1.8.2 in docs generation script. Doxygen often has backwards incompatible changes, so verify that we really use the version the docs are supposed to be generated with.

2012-11-04 13:44 VZ, revision 72879

Don't use "readlink -e" in docs generation script, it's not portable. "readlink" command also exists under OS X but with a completely different syntax than under Linux, so just use "pwd -P" to get the physical path name instead, this should hopefully work everywhere as it's POSIX. Closes #14796.

2012-11-04 13:44 VZ, revision 72878

Allow using _T() in docs/doxygen/overviews/changes_since28.h. This file describes changes to this macro so don't block commits changing it just because it contains "_T".

2012-11-03 19:34 BP, revision 72877

Finished adding @tableofcontents to all overviews in the manual.

2012-11-03 19:33 BP, revision 72876

Bumped the reference manual date.

2012-11-03 19:33 BP, revision 72875

Fixed up Windows regen.bat script to use environment variables instead of conditional config file includes.

2012-11-03 19:33 BP, revision 72874

Moved format selection logic into environment variables instead of conditional config file includes.

2012-11-03 19:33 BP, revision 72873
  • D /wxWidgets/trunk/docs/doxygen/background_navigation.png
  • D /wxWidgets/trunk/docs/doxygen/img_downArrow.png
  • D /wxWidgets/trunk/docs/doxygen/jquery-1.3.2.min.js
  • M /wxWidgets/trunk/docs/doxygen/regen.sh
  • D /wxWidgets/trunk/docs/doxygen/wxdocsettabs.css
  • D /wxWidgets/trunk/docs/doxygen/wxdocsetwidgets.css

Removed obsolete files from old Doxygen versions.

2012-11-03 19:33 BP, revision 72872

Cleaned up the server based search results page styles.

2012-11-03 19:32 BP, revision 72871

Fixed appearance images to use Doxygen @image command (Doxygen will now copy files automatically), and cleaned up some more overviews.

2012-11-03 19:29 BP, revision 72870

Fixed docs footer to bottom, and fixed up TOC on all main pages, and some overviews.

2012-11-03 19:08 BP, revision 72869

Documentation screenshot generator source code cleanup.

2012-11-03 19:08 BP, revision 72868

Upgraded Doxygen to 1.8.2 for the docs.

2012-11-02 18:02 SC, revision 72865

missing commit, fixes #14797

2012-11-02 11:46 SC, revision 72864

using smaller size for font on non native toolbar

2012-11-02 11:45 SC, revision 72863

fixing class

2012-11-02 11:45 SC, revision 72862

using button impl

2012-11-02 11:41 SC, revision 72861

exposing common used button impl class

2012-11-02 11:06 SC, revision 72860

exposing common used button impl class

2012-11-01 23:56 RD, revision 72858

Fixes and tweaks and additions to the wxHtml docs for Phoenix

2012-11-01 19:25 VS, revision 72850

wxCALL_FOR_EACH compilation fix for VC++. VC++ has a bug where __VA_ARGS__ is incorrectly expanded as a single token, contrary to C99. The solution is to pass the arguments to another macro as a single token inside parenthesis. See http://stackoverflow.com/questions/9183993/msvc-variadic-macro-expansion for the gory details.

2012-11-01 19:25 VS, revision 72849

Compilation fix for PCH-less build.

2012-11-01 18:15 VZ, revision 72848

Refactor and simplify wxChoice::DoGetBestSize(). Use wxTextMeasure instead of duplicating its code and also reuse the code between different ports. Closes #14706.

2012-11-01 18:15 VZ, revision 72847

Invalidate best size of wxOSX wxChoice after its number of items changes. This fixes the calculation of the initial best size as previously the default value was not updated even if longer strings were added later.

2012-11-01 18:15 VZ, revision 72846

Allow creating wxTextMeasure without specifying the font. Use the default window/DC font by default as this is the most common case.

2012-11-01 18:15 VZ, revision 72845

Always set the font to use in wxMSW wxTextMeasure when using a window. The default window HDC font is not the same as the wxWindow font, so we need to always set the font explicitly in this case (when using a wxDC, its HDC does have the current wxDC font already selected into it, so doing it once again would be unnecessarily wasteful).

2012-11-01 18:15 VZ, revision 72844

Allow constructing wxGTK wxTextMeasure with NULL font. The font is explicitly documented as being possibly NULL in the base class and wxMSW handles NULL font just fine, so also handle it in the GTK version. See #14706.

2012-11-01 18:15 VZ, revision 72843

Don't crash in wxHTML when parsing empty tables with empty width parameter. Guard against accessing invalid string element.

2012-11-01 18:15 VZ, revision 72842

Added wxEVT_COMMAND_DIRCTRL_CHANGED for wxDirCtrl selection changes. This makes it much simpler to react to the changes in the control, update the sample to show it. Closes #14792.

2012-11-01 18:15 VZ, revision 72841

No changes, just some cleanup in wxGenericDirCtrl code. Use GetItemData() helper to only write a cast to wxDirItemData in this function instead of repeating it many times. See #14790.

2012-11-01 18:14 VZ, revision 72840

Add distclean target to samples/Makefile. It is necessary because it is used by the distclean target of the top level makefile. Closes #14793.

2012-11-01 18:14 VZ, revision 72839

Deal correctly with wx directory being a symlink in docs generation script. The script calling Doxygen is smart enough to strip the path of the wxWidgets directory from the paths of the files, but it didn't do it correctly if this directory was a symlink. Fix this by using readlink, if available, to get the canonical name. Closes #14796.

2012-11-01 17:45 VS, revision 72838

Tests for wxTEST_DIALOG and wx/testing.h.

2012-11-01 17:45 VS, revision 72837

Add wxTEST_DIALOG for testing of modal dialogs.

2012-11-01 17:45 VS, revision 72836

Add wxCALL_FOR_EACH() macro.

2012-10-31 14:39 VZ, revision 72833

Nepalese translations update from Him Prasad Gautam.

2012-10-31 13:55 VZ, revision 72832

Revert "Split documentation of the GUI wxLog classes in a separate file." This reverts r72818 as it resulted in wrong header files being generated in the documentation for the GUI wxLog classes. See #14784.

2012-10-31 08:16 SC, revision 72831

adding principal class for command line builds (High Resolution Support), changing years in copyright info

2012-10-31 08:10 SC, revision 72830

adding constants for newer OSX versions to make sure our conditional expressions are working with earlier SDKs

2012-10-31 06:43 PC, revision 72829

fix WakeUpIdle() when called from another thread while idle processing is in progress

2012-10-31 01:17 VZ, revision 72828

Define wxSOCKET_XXX flags as wxSOCKET_XXX_READ|wxSOCKET_XXX_WRITE. The recently introduced (in r72591) wxSOCKET_{WAITALL,NOWAIT}_{READ,WRITE} flags weere for some reason completely different and unrelated to the existing bidirectional wxSOCKET_{WAITALL,NOWAIT} ones. Change this by defining the bidirectional version simply as the sum of the two others. This makes much more sense than testing for either wxSOCKET_XXX or wxSOCKET_XXX_READ or wxSOCKET_XXX_WRITE being specified. And it also fixes an assert in wxSocketWaitModeChanger where a sanity check failed when this class was used with wxSOCKET_WAITALL|wxSOCKET_WAITALL_READ. See #14506.

2012-10-30 15:04 VZ, revision 72825

Revert "Split documentation of non-GUI wxEvent-related classes." This reverts r72817 as it resulted in build problems for wxPython and incorrect headers in the generated documentation. See #14785.

2012-10-29 19:30 VZ, revision 72820

Compare file paths using wxFileName, not wxString, in the sample. Comparing paths using wxString is a bad idea as identical paths can be seen as mismatching because of case-only differences. Also, don't reset wxRadioBox selection from its selection handler, this doesn't work under e.g. wxGTK and is a bad example. Closes #14791.

2012-10-29 19:30 VZ, revision 72819

Add wxDirCtrl::GetPath(). This allows to retrieve the directory being affected by wxTreeCtrl event. Closes #14790.

2012-10-29 16:15 VZ, revision 72818

Split documentation of the GUI wxLog classes in a separate file. Put the GUI classes in a new interface/wx/generic/logg.h to make it easier to generate wrappers for only the base or only the core libraries. Also change the order of the classes remaining in log.h to ensure that the base classes are always defined before the derived ones. Closes #14784.

2012-10-29 16:15 VZ, revision 72817

Split documentation of non-GUI wxEvent-related classes. Separate GUI from base classes to make it easier to generate wrappers for just the latter using e.g. SWIG. Closes #14785.

2012-10-29 15:50 VZ, revision 72816

Get rid of wxAuiToolBar::m_style and just use base class m_windowStyle. This fixes an assert exposed by the addition of wxAuiToolBar::Create() in r72785: as m_style was not initialized before, calling GetWindowStyle() from wxControl::Create() returned wrong flags. Fix this by just removing m_style completely, there doesn't seem to be any need for it nor for overriding GetWindowStyleFlag(). See #13520.

2012-10-29 02:20 VZ, revision 72815

Fix the use of obsolete wxDD_NEW_DIR_BUTTON in wxOSX. Use wxDD_DIR_MUST_EXIST, testing for wxDD_NEW_DIR_BUTTON always failed. Closes #13596.

2012-10-29 02:20 VZ, revision 72814

No changes, just avoid code duplication in wxOSX wxDirDialog. Factor our common parts of wxDirDialog::ShowModal() and ShowWindowModal() in OSXCreatePanel() helper. Also some minor cosmetic changes.

2012-10-29 02:20 VZ, revision 72813

Avoid double destruction of wxTipWindow under wxOSX. Hiding the window results in wxEVT_KILL_FOCUS under OS X and this destroys it already, so when we call Destroy() from wxTipWindow::Close() later, it triggers assert about destroying it twice. Avoid doing this under OS X for now, even though the real problem is probably the discrepancy in wxEVT_KILL_FOCUS event generation under different platforms. Closes #14651.

2012-10-28 22:01 SJL, revision 72812

Document which wxWebView methods must wait for a page load before being called. Closes #14768

2012-10-28 14:31 VZ, revision 72811

Don't return "void" to fix MSVC6 compilation. VC6 doesn't support returning void "value".

2012-10-28 13:36 VZ, revision 72810

Updates to Indonesian translations by Rahmat Bambang.

2012-10-28 02:08 VZ, revision 72809

Implement support for button mnemonics in wxOSX/Cocoa. Set the mnemonic as "key equivalent". Closes #12917.

2012-10-28 02:08 VZ, revision 72808

Improve splitter appearance in wxOSX/Cocoa. Try to imitate NSSplitView better. Closes #12921.

2012-10-28 02:08 VZ, revision 72807

Implement image support for wxNotebook pages in wxOSX/Cocoa. This currently doesn't work correctly for left/right orientations but at least it does work for the default top (and also bottom) one. Closes #12754.

2012-10-28 02:08 VZ, revision 72806

Fix taskbar sample compilation under wxOSX/Cocoa. Use wxTBI_XXX constants instead of wxTaskBarIcon::XXX ones which don't seem to exist any longer. See #11831.

2012-10-28 02:08 VZ, revision 72805

Fix the pages range in the print dialog in wxOSX. Set the min/max pages earlier for them to be taken into account and also actually do set them in the print settings. Closes #8349.

2012-10-27 14:28 VZ, revision 72803

Another attempt to fix wxTextMeasure compilation with VC6. Simply make the methods accessed by the nested class public.

2012-10-27 14:28 VZ, revision 72802

Allow using wxTextMeasure::GetLargestStringExtent() with wxArrayString. Change the signature of this method to take the number of strings and the pointer to the first of them instead of wxVector<wxString> as this allows it to be used with all of wxVector<wxString>, wxArrayString and raw arrays of wxStrings. Also return the computed size from it instead of filling output parameters. Closes #14781.

2012-10-27 14:27 VZ, revision 72801

Allow wxTextMeasure to work with non-native wxDC objects too. Just forward back to wxDC itself in this case instead of using the platform-specific code in wxTextMeasure that only works with native DCs. See #14781.

2012-10-27 14:27 VZ, revision 72800

Fix warning about signed/unsigned comparison in wxFile::ReadAll(). Compare ssize_t value with another ssize_t value instead of size_t one to avoid warnings.

2012-10-27 14:27 VZ, revision 72799

Just fix header comments of wxTextMeasure-related files, no real changes. See #14781.

2012-10-27 07:51 PC, revision 72798

redo r72781 in a way that preserves binary compatibility, closes #14525

2012-10-27 05:15 RD, revision 72788

Add missing WXK constants for the control keys

2012-10-27 05:15 RD, revision 72787

Generate the interface file for STC from gen_iface too.

2012-10-27 03:27 VZ, revision 72786

Fix incorrect libraries in the documentation. Use wxcore for the GUI classes that were mistakenly documented as belonging to the wxbase library. Closes #14783.

2012-10-27 03:27 VZ, revision 72785

Add wxAuiToolBar::Create(). Implement two-step creation of wxAuiToolBar to allow doing it from XRC. See #13520.

2012-10-27 03:27 VZ, revision 72784

Renamed file containing wxAuiToolBar documentation. The real header is called wx/aui/auibar.h, not wx/aui/toolbar.h.

2012-10-27 03:27 VZ, revision 72783

Fix PCH-less build after previous commit. Need to include wx/window.h now that wx/animate.h is not included any more.

2012-10-27 02:46 VZ, revision 72782

Break implicit dependency of "core" on "adv" via wxXmlResourceHandlerImplBase. wxXmlResourceHandlerImplBase::GetAnimation() returned wxAnimation by value which created references to wxAnimationCtrlNameStr and wxNullAnimation symbols, defined in the "adv" library, in "core" when using Sun CC even though they were not referenced directly. Fix this by returning wxAnimation by pointer to keep it opaque for "core" code.

2012-10-26 18:32 PC, revision 72781

Store the selected directory in wxGTK wxDirDialog, fixes #14525

2012-10-26 01:55 VZ, revision 72780

Compilation fix for STL build after the last commit. Add missing fn_str() call.

2012-10-26 01:26 VZ, revision 72779

Store the selected directory in wxGTK wxDirDialog. This should help with the selected directory not being remembered since GTK+ 2.24.11 as apparently gtk_file_chooser_get_filename() doesn't work any more now after hiding the dialog -- so call it before doing this and save the result. Also get rid of the ugly and apparently completely unnecessary OnFakeOk(). Closes #14525.

2012-10-26 01:26 VZ, revision 72778

Prevent pasting too much text into limited length wxTextCtrl in wxGTK. Improve insert-text signal handler to block pasting text into the control, which may overflow the specified max length in one action, and not only entering individual characters. See #3158.

2012-10-26 00:30 VZ, revision 72777

Make wxFILE_EXISTS_SYMLINK work on its own, without wxFILE_EXISTS_NO_FOLLOW. Include the wxFILE_EXISTS_NO_FOLLOW bit in wxFILE_EXISTS_SYMLINK definition to allow using just wxFileName::Exists(wxFILE_EXISTS_SYMLINK) which used to never work because the link was followed. Closes #14777.

2012-10-26 00:19 VZ, revision 72776

Include wx/xml/xml.h from the XRC handlers that need it. Including this header from wx/xrc/xmlres.h itself only when WXMAKINGDLL_XRC is defined doesn't work when we're building a static library and not a shared/DLL one and we don't have any symbol defined in this case, so just don't try to be smart and include this header from the files that need it. This fixes breakage of r72756.

2012-10-25 15:37 JS, revision 72775

Backported menu update event processing, but only in wxGTK if idle update processing is being used to work around the global menu not generating open events in Ubuntu Unity. This is the minimal code change to get idle processing working in wxGTK. You can either edit platform.h to switch on idle event processing, or set UBUNTU_MENUPROXY to 0 in your application before GTK+ initialisation, e.g. in your app class ctor, to switch off the global menu and avoid the bug.

2012-10-25 01:41 VZ, revision 72763

PCH-less build fix for DynamicLibraryTestCase. Include wx/log.h needed by wxLogWarning().

2012-10-25 01:40 VZ, revision 72762

Implement clipping in wxSVGFileDC. Support setting the clipping region and add update the documentation and the sample accordingly. Closes #14462.

2012-10-25 01:40 VZ, revision 72761

No real changes, just avoid unnecessary string operations in wxSVGFileDCImpl. Simply write string together instead of concatenating them during run-time. See #14462.

2012-10-25 01:39 VZ, revision 72760

No changes, just remove unused variable from wxSVGFileDCImpl. sWarn was never used, drop it. See #14462.

2012-10-25 01:14 VZ, revision 72759

Show some information about the environment in the unit tests. For now just show the system description and the locale, this should already be helpful for diagnosing some test failures.

2012-10-25 01:13 VZ, revision 72758

Test for the shared library existence in DynamicLibraryTestCase. Trying to understand why does the test fail in some build slaves builds.

2012-10-25 01:13 VZ, revision 72757

Add a missing test for wxHAS_CALL_AFTER in the implementation too. This completes the changes of r72743.

2012-10-24 20:34 VZ, revision 72756

Try to avoid accidental use of wxXmlNode in XRC handlers. Now that the handlers can be defined outside of the XRC library, we can't use wxXmlNode in them because this would create an (unsatisfied) link dependency on the xml library. To avoid this happening accidentally, don't include wx/xml/xml.h from the XRC header, unless building the xrc library itself.

2012-10-24 20:33 VZ, revision 72755

Disable dropdown menu support in wxRibbonXmlHandler. The code handling it uses wxXmlNode directly as it's written now which isn't allowed as it introduces a dependency of ribbon library on the xml one and so currently breaks linking of the ribbon DLL under MSW. See #12058.

2012-10-24 20:22 VZ, revision 72754

Don't call wxSafeYield() from wxGenericListCtrl::EditLabel(). This could result in wxYield() reentrancy and while it could be avoided by using wxSafeYield(NULL, true /* only if needed */) it seems that we don't actually need to yield here at all and a simple Update() should be enough. Closes #14727.

2012-10-24 20:22 VZ, revision 72753

Don't iterate over files in wxFileSystemWatcherBase. We ignore the files anyhow when recursively adding watches for the entire tree, so don't include them in the iteration. See #14543.

2012-10-24 20:21 VZ, revision 72752

Remove wxAUI dependency on wxXML as it doesn't depend on it. Don't include wxAUI -> wxXML dependency in the libraries diagram in the manual.

2012-10-24 20:21 VZ, revision 72751

Respect wxFileName::DontFollowLink() in wxFileSystemWatcher. Watch the link itself and not its target if DontFollowLink() had been called. Closes #14543.

2012-10-24 16:02 VZ, revision 72750

Make wxDateTime invalid after Set((time_t)-1) call. Closes #14776.

2012-10-24 16:02 VZ, revision 72749

Close wxLogWindow automatically if it's the last remaining TLW. Don't keep the application opened just because a log window is shown. Closes #14775.

2012-10-24 16:01 VZ, revision 72748

Add wxVector::assign(). Closes #14703.

2012-10-24 15:13 JS, revision 72747

Updated Lativan translation

2012-10-24 15:11 JS, revision 72746

Updated Latvian translation

2012-10-24 02:25 VZ, revision 72745

Don't use std::min(), it's not available everywhere. Fix compilation using Sun CC under Solaris.

2012-10-24 02:25 VZ, revision 72744

Don't use Shift-TAB in keyboard test. This key combination seems to be intercepted by GTK now for keyboard navigation purposes and we never get key up events for it. Just use a different key.

2012-10-24 02:17 VZ, revision 72743

Disable wxEvtHandler::CallAfter() for VC6, it's too broken for it. There is no clear way to implement wxRemoveRef() for VC6 so just disable it, and CallAfter() as it relies on it, for this compiler.

2012-10-24 01:58 VZ, revision 72742

Don't follow symlinks in wxFileName::Rmdir(wxPATH_RMDIR_RECURSIVE). Following symlinks, possibly leading outside of the directory being removed, is at best surprising and at worst dangerous, so don't do it and just mimic the behaviour of "rm -rf", i.e. remove everything inside this directory, including the symlinks themselves, but don't follow them. Closes #14649.

2012-10-24 01:57 VZ, revision 72741

Mention wxFILE_EXISTS_NO_FOLLOW in wxFILE_EXISTS_SYMLINK description. Using wxFILE_EXISTS_SYMLINK without wxFILE_EXISTS_NO_FOLLOW can only be fruitless, so mention that they should normally be used together in the documentation. An alternative solution would be to always add wxFILE_EXISTS_NO_FOLLOW automatically if wxFILE_EXISTS_SYMLINK is used, perhaps we should do this instead. See #14542.

2012-10-24 01:57 VZ, revision 72740

Add wxDIR_NO_FOLLOW flag for wxDir iteration. This flag allows to avoid following the symbolic links during the directory traversal. In particular, this means that links to the directories (potentially outside the directory being traversed) are not considered as directories at all when it is used, potentially avoiding surprises. Closes #14542.

2012-10-24 01:57 VZ, revision 72739

Change the way directory iteration flags are constructed. Instead of explicitly constructing the flags from the flags that should be included, construct them by excluding the flags that shouldn't be used. This makes the code more stable in the sense that it will continue to work when new flags, such as the upcoming wxDIR_NO_FOLLOW, are added. See #14542.

2012-10-23 22:48 JS, revision 72738

We need to generate an event even if the value is the same else combobox event-ignoring behaviour breaks and a combobox in a property editor (for example) can fail to respond to the first key press.

2012-10-23 19:29 PC, revision 72737

non-pch build fix

2012-10-23 19:28 PC, revision 72736

Minor changes to some comments remove ambiguous "only" procession --> processing

2012-10-23 16:30 VZ, revision 72731

Fix for PCH-less compilation of wxRibbonXmlHandler. Need to have wxMenu declaration in order to wxDynamicCast() to it.

2012-10-23 16:03 VZ, revision 72730

Guard gmake-specific syntax with IF_GNU_MAKE in make_dist.mk. Debian distribution target uses GNU make extensions to make syntax which makes the entire makefile impossible to use with other make versions, e.g. Solaris make. Fix this by prepending IF_GNU_MAKE to all Debian-specific lines, there should be never any need to use them with non-GNU make.

2012-10-23 15:52 VZ, revision 72729

Add support for wxRibbonBar and related controls to XRC. Add wxRibbonXmlHandler and an example of using it to the xrc sample. Closes #12058.

2012-10-23 15:51 VZ, revision 72728

Add support for wxAuiNotebook to XRC. Add wxAuiNotebookXmlHandler to "aui" library, now that we can do it without adding a dependency of it on "xrc" one. Closes #10889.

2012-10-23 15:51 VZ, revision 72727

Refactor wxXRC to allow defining handlers outside of xrc library. Split wxXmlResourceHandler into an ABC and the real implementation to allow referencing the ABC in the core library itself but without pulling in all of the XRC into it. This also allows defining XRC handlers, which only depend on this ABC and not the xrc library, in other libraries, such as richtext, as demonstrated by the now enabled wxRichTextXMLHandler. Closes #10996.

2012-10-23 15:51 VZ, revision 72726

Define WXDLLIMPEXP_FWD_RIBBON for consistency with all the other libraries. We defined only WXDLLIMPEXP_RIBBON but not the FWD version, do add it now.

2012-10-23 14:06 VZ, revision 72725

Recognize more XRC elements as containing translatable strings. This allows to translate the text of these elements in wxrc-generated code using gettext. Closes #14765.

2012-10-23 14:03 VZ, revision 72724

Add a simple unit test for wxRegion::Intersect(). Check that Intersect() returns true, yet the intersection is empty.

2012-10-23 14:02 VZ, revision 72723

Process pending events from wxYield() in wxGTK. Calling wxYield() is supposed to process the pending events but it didn't, any more, in wxGTK. Restore this by explicitly calling ProcessPendingEvents() from wxGTK wxYield() implementation as wxGUIEventLoop::ProcessIdle() does not call it, in spite of a comment to the contrary in the sources. Closes #14760.

2012-10-23 14:02 VZ, revision 72722

Add wxEvtHandler::CallAfter() for asynchronous method calls. Add wxAsyncMethodCallEvent that is handled simply by calling the method this event was created for and add default handler for this event to wxEvtHandler. Implement CallAfter() overloads for up to 2 parameters only for now.

2012-10-23 14:02 VZ, revision 72721

Add wx/meta/removeref.h header defining wxRemoveRef<> helper. This is a very simple template allowing to remove the reference from the given type, similar to std::remove_reference<>.

2012-10-22 23:46 VZ, revision 72720

Fix border size computation in wxAuiTabArt. Space was reserved for the borders even when it wasn't filled, resulting in visual artefacts. Fix this by virtualizing the function returning the additional space needed for the borders and only overriding it to return non zero in wxAuiGtkTabArt. Closes #14710.

2012-10-22 17:51 VZ, revision 72719

Set C++ global locale too in wxAppTraitsBase::SetLocale(). Ensure that C++ locale matches the C one, otherwise operations on C++ streams may get much slower because some implementations (notable MinGW-64) change and reset the C locale on every function call in this case.

2012-10-22 17:51 VZ, revision 72718

Revert accidental incompatible change to wxFileName::DirExists(). The non-static version tests for the existence of the directory part of the object only as is explicitly mentioned in the documentation, so do the test on GetPath() and not GetFullPath() as we did since r72707. Also add a unit test for this behaviour. Closes #14771.

2012-10-22 13:21 VZ, revision 72717

Ensure the correct cleanup order for GDI+-related modules in wxMSW. GDI+ DLL could be unloaded by wxGdiPlusModule before wxGDIPlusRendererModule:: OnExit() was called, resulting in a crash when trying to call a GDI+ function from the latter. Fix this by adding a correct dependency between the modules. Closes #14769.

2012-10-21 22:48 VZ, revision 72716

Remove unnecessary SetInitialSize() from wxGTK wxComboBox::Create(). SetInitialSize() is already done by PostCreation() called just above, no need to call it twice.

2012-10-21 22:33 SJL, revision 72715

Explicitly unregister custom wxWebViewIE namespaces when we are done with them. Also add a missing ClassFactory::AddRef. Closes #14749

2012-10-20 16:49 VZ, revision 72714

Check the return value of system() and pipe() in the test suite. This is mainly to avoid -Wunused-result warnings under recent Linux systems but also could give valuable information if the call does fail.

2012-10-20 16:48 VZ, revision 72713

Fix tests compilation in STL build after r72707. Add an explicit call to wxString::c_str() as there is no implicit conversion in STL build.

2012-10-20 14:04 VZ, revision 72712

Nepali translation update from Him Prasad Gautam.

2012-10-20 00:03 VZ, revision 72711

Update header control when wxPropertyGridManager is resized. Closes #14762.

2012-10-20 00:03 VZ, revision 72710

Allow specifying all wxFlexGridSizer parameters in XRC. Add support for specifying flexible direction, grow mode in non-flexible direction and row/column proportions for the growable ones. Closes #14767.

2012-10-20 00:03 VZ, revision 72709

Add more error checks to XRC handler for longs, doubles and fonts. Verify that the values in the XRC really conform to the expected type. Closes #14766.

2012-10-20 00:02 VZ, revision 72708

Add missing styles support to wxWindow XRC handler. wxBORDER_RAISED, wx[HV]SCROLL and a few extended styles were not recognized. See #14766.

2012-10-20 00:02 VZ, revision 72707

Allow testing for existence of specific file types in wxFileName. Add "flags" parameter to wxFileName::Exists() to allow testing for the existing of files of specific type: not only regular or directory but also symlink, device, FIFO or socket. And also to pass wxFILE_EXISTS_NO_FOLLOW flag inhibiting following the symlinks without using DontFollowLink(). Closes #14542.

2012-10-19 13:06 VZ, revision 72706

Remove assert checking for valid font in wxMSW wxDC::GetTextExtent(). It wasn't there before wxTextMEasure changes and it doesn't seem obvious why should it be there, it should be possible to measure the text using the default wxDC font without setting one explicitly.

2012-10-19 12:43 VZ, revision 72705

Declare MeasuringGuard as friend in wxTextMeasureBase. This should hopefully fix VC6 compilation.

2012-10-19 12:42 VZ, revision 72704

Invalidate wxGrid best size when the grid is changed. Don't keep using the cached best size if rows/columns are added/removed to/from wxGrid or resized, doing this meant that we always used the first computed best size which was way too small after adding rows/columns to the grid. There could be more places where the grid best size may need to be invalidated but this should be a good start. Closes #14761.

2012-10-19 01:41 VZ, revision 72703

Fix bug in wxFileName::Exists("/"). Don't remove too many trailing slashes, the lone slash of "/" should remain.

2012-10-18 20:35 RD, revision 72702

non-pch build fix

2012-10-18 07:06 PC, revision 72701

non-pch build fix

2012-10-18 01:06 VZ, revision 72700

Fix crash in wxDC::GetMultiLineTextExtent() after last commit. Don't call wxTextMeasure::DoGetTextExtent() with NULL width pointer, it now supposes that both width and height pointers are non-NULL. Add at least a trivial unit test for GetMultiLineTextExtent().

2012-10-18 00:35 VZ, revision 72699

Factor out text measurement from wxDC and wxWindow into wxTextMeasure. Add a new private wxTextMeasure class implementing methods for measuring text and move the often duplicated (but not always identically) code for doing the same from wxDC and wxWindow into it. Currently this class is only really implemented in wxMSW and wxGTK. Also extend the test for text measuring functions and rename it to MeasuringTextTestCase from MeasuringContextTestCase as it's not wxGC-specific any more. Closes #14705.

2012-10-18 00:35 VZ, revision 72698

Remove unused code from MeasuringContextTestCase. m_win variable was never used and setUp() and tearDown() were simply not needed here.

2012-10-17 18:44 VZ, revision 72697

Fix wxGrid editors background painting. There were two fundamental problems: first, we painted on a separately created wxClientDC instead of using the wxPaintDC already available in wxGrid. Second, we invalidated the control while painting, resulting in endless repainting, at least under wxGTK. Fix the first problem by passing wxDC to wxGridCellEditor::PaintBackground() and the second one by not refreshing the control from there as it just seems unnecessary. Also pass the attribute by reference for consistency with wxGridCellRenderer::Draw() and because this pointer can never be NULL. Closes #2628.

2012-10-17 18:23 PC, revision 72696

Disconnect all GTK signals referencing a wx object which is being destructed or which is destroying the associated GTK object

2012-10-17 17:45 VZ, revision 72695

Make wxFindReplaceData accessors const. Closes #14755.

2012-10-17 02:24 VZ, revision 72694

Added buildbot slave configuration for brandt64. New 64 bit build slave ran by Gerald Brandt with just a couple of builds for now.

2012-10-17 00:28 VZ, revision 72693

Add wxEvent::GetEventUserData() and improve user data documentation. Provide a public and documented accessor for wxEvent::m_callbackUserData. Also document better the user data semantics and how it can be used. Closes #14748.

2012-10-17 00:28 VZ, revision 72692

Define CLSID_DragDropHelper ourselves to fix VC6 build. VC6 SDK doesn't define CLSID_DragDropHelper constant neither, so do it ourselves too to complete the changes of r72673. Closes #14697.

2012-10-16 20:05 PC, revision 72691

fix crash in wxWindowGTK::GTKHandleUnrealize(), closes #14752

2012-10-16 16:06 VZ, revision 72690

Use the correct window as parent of wxInfoBar close button. Fix breakage of r72474 that used the parent window instead of wxInfoBar itself as the parent of its close button. Closes #14750.

2012-10-16 16:02 VZ, revision 72689

Improve inotify()-based wxFileSystemWatcher to handle creation/deletion. Handle creation and deletion of directories under the watched path better. See #14544.

2012-10-16 16:02 VZ, revision 72688

Add a debug helper to show information about a GtkWidget under gdb. For now just give its type which is not exactly exhaustive but better than nothing.

2012-10-16 16:01 VZ, revision 72687

Correct example of handling property values changes in the docs. "." was incorrectly used with a pointer, replace it with a "->".

2012-10-15 03:17 VZ, revision 72686

Correctly document the library the classes belong to. Many classes were documented as being in a wrong library, mostly a lot of wxbase vs wxcore confusion but we even managed to document wxAuiManager as being in wxbase. Correct all this. Closes #14745, #14747.

2012-10-15 03:13 VZ, revision 72685

Make help strings for --enable-webview* configure options match their names. The options didn't have the underscore shown in the help message, so remove the underscore (while it could be argued that underscore makes the option names more readable, it seems better to preserve the existing names for compatibility).

2012-10-15 03:10 VZ, revision 72684

Mention David Hart bug fixes in wxFileSystemWatcher. See #14488, #14490, #14544.

2012-10-15 03:10 VZ, revision 72683

Handle deletion of watched directories in wxFileSystemWatcher sample. Don't assert when trying to stop watching a directory that doesn't exist any more later. See #14544.

2012-10-15 03:09 VZ, revision 72682

Fix bug in Unix wxFileSystemWatcher implementation when watch is deleted. Don't assert when removing a watch descriptor from the stale descriptors list. See #14544.

2012-10-15 03:09 VZ, revision 72681

Check for filespec when generating events in wxFileSystemWatcher. Instead of setting watches on individual files when a non-empty filespec is given, always watch all the files but just ignore the events from the ones not matching the filespec. This makes the code simpler and fixes several bugs. See #14544.

2012-10-15 03:09 VZ, revision 72680

Add support for symlinks to wxFileName. Allow to work with the symlinks themselves and not the file they reference by calling the new wxFileName::DontFollowLink(). Update Unix wxDir implementation to not treat symlinks to directories as directories, this ensures that we don't recurse into the directories outside of the original parent accidentally. Closes #14542.

2012-10-15 03:08 VZ, revision 72679

Make wxFileSystemWatcher watch entries reference-counted. This helps to avoid problems that arise from watching the same physical file system path multiple times, which could happen when adding a watch for a path already watched because of a recursive watch on a parent directory, for example. Closes #14490.

2012-10-15 03:08 VZ, revision 72678

Improve handling of file spec in wxFileSystemWatcher::AddTree(). Fix watching too many files (i.e. even those not matching the provided spec) and asserts when removing a recursive watch with a file spec in wxMSW. Closes #14488.

2012-10-14 21:30 VS, revision 72677

anybutton.cpp compilation fix for wxUSE_IMAGE=0. Disabled bitmaps are not rendered properly in this configuration, they look the same as normal ones. This is hardly ideal, but such degradations are to be expected when disabling something as widely used as wxImage.

2012-10-14 21:15 VS, revision 72676

Compilation fix - wx/vector.h is not part of PCH.

2012-10-14 21:14 VS, revision 72675

wxDisplay only needs dynlib.h, not dynload.h.

2012-10-14 16:55 VZ, revision 72674

Make GetClippingBox() work for wxPrinterDC in wxGTK. GetClippingBox() implementation relies on wxDCImpl::m_clip[XY][12] being updated in DoSetClippingRegion() but this wasn't done here. Fix this by adding the code to do this to the base class version of this method and calling it from wxGtkPrinterDCImpl. Also, refactor wxGCDCImpl to reuse the same code instead of duplicating it. Closes #14697.

2012-10-14 16:42 VZ, revision 72673

Provide stand-in IDropTargetHelper definition to fix VC6 build. VC6 SDK doesn't define this interface, so do it ourselves to fix its build after the changes of r72668. See #14697.

2012-10-14 00:55 VZ, revision 72672

Make TAB behaviour in wxGrid more configurable. Allow making TAB/Shift-TAB wrap to the next/previous row or going to the next/previous control when the cursor is at the end/beginning of the current row easily. Also add wxEVT_GRID_TABBING event to allow customizing TAB behaviour even further. Update the sample to show the different possible standard behaviours and a stupid example of a custom one (it would be probably more useful to implement something a tad more realistic, e.g. tabbing to the next non-empty cell). Closes #14711.

2012-10-14 00:54 VZ, revision 72671

Just correct the path in the header comment. Add the missing "private" path component.

2012-10-14 00:54 VZ, revision 72670

Document that HasFocus() is new in 2.9. Closes #14740.

2012-10-14 00:54 VZ, revision 72669

No changes, just update a comment about default buttons in wxMSW. Remove the TODO from it because it's not really obvious if using the proposed approach is such a good idea.

2012-10-14 00:53 VZ, revision 72668

Display system-provided drag images during drag-and-drop in wxMSW. This is especially useful when dragging files from Explorer as it provides big, informative drag images for them that can be easily displayed using Windows shell support for them. See #14697.

2012-10-14 00:53 VZ, revision 72667

Use a "hidden" dialog, not frame, in sync wxExecute() hack in wxMSW. Replace a "hidden" (not really, but shown far off screen) frame with a dialog to avoid this frame appearing in the Alt+TAB list. Closes #13251.

2012-10-14 00:52 VZ, revision 72666

Set the standard sample icon for the exec sample. Do this for consistency with all the other ones and also because it makes it simpler to notice any unwanted icons for hidden windows created by this sample. See #13251.

2012-10-14 00:52 VZ, revision 72665

Freeze wxTreeCtrl in wxMSW by hiding it. This is far from perfect but better than alternative as freezing this control by sending WM_SETREDRAW to it can result in completely broken behaviour as explained in http://support.microsoft.com/kb/130611. And not freezing it at all shows horrible flicker when adding even a relatively small number of items at once to the control because it recalculates and repositions its scrollbars after every parent node addition.

2012-10-14 00:52 VZ, revision 72664

Set wxTAB_TRAVERSAL for wxNavigationEnabled<> windows with focusable children. We need to have this flag under wxMSW in order for navigation events to be generated for the window. As wxNavigationEnabled can't set this flag on creation because its ctor is called too early, do it in overridden AddChild(). Closes #13271.

2012-10-14 00:51 VZ, revision 72663

Allow using windows that can't be focused with wxNavigationEnabled<>. The code in wxNavigationEnabled<> assumed that the window itself could be focused if it didn't have any focusable children because it was originally extracted from wxPanel that can, indeed, be focused. This is however not the case for all windows, notably not for wxStaticBox which now derives from wxNavigationEnabled as well but can never be focused itself. Add wxControlContainer::DisableSelfFocus() and call it from wxStaticBox to support this situation. This required splitting m_acceptsFocus flag into m_acceptsFocusSelf and m_acceptsFocusChildren and updating various methods using them. See #13271.

2012-10-14 00:51 VZ, revision 72662

Use WS_EX_CONTROLPARENT for wxStaticBox in wxMSW. This doesn't change anything currently but it seems correct to use this style with wxStaticBox as it can now contain other windows (and so be "control parent"), so it could allow Windows or other programs checking for this style to handle it more correctly.

2012-10-14 00:51 VZ, revision 72661

Remove unused wxNavigationEnabled::AcceptFocus() method. This doesn't seem to be ever called or used from anywhere else.

2012-10-14 00:50 VZ, revision 72660

Document wxListBox limitation concerning TAB characters. TABs appear simply as a space under MSW (because we don't use LBS_USETABSTOPS style there) but are aligned to (multiple of 8?) tab stops under GTK. It's not clear which behaviour is actually preferable so for now just document the inconsistency and advise people to use spaces instead.

2012-10-14 00:50 VZ, revision 72659

Remove mention of "listbox callback" from wxListBox documentation. This is probably a left over from wxWidgets 1.x.

2012-10-14 00:49 VZ, revision 72658

Improve explanation of maximal number of wxListBox items in the documentation. Don't say that it's limited -- because, strictly speaking, it isn't -- but mention other controls that are better alternatives for large numbers of items.

2012-10-14 00:49 VZ, revision 72657

Do give focus to the wxNotebook page when switching to it under MSW. Switching to the page but keeping the focus on the notebook itself makes it difficult to use the UI from keyboard and is inconsistent with the behaviour of native property sheets. Do restore the code to set the focus to the page as the bug that resulted in a wrong radio button being selected when we did this was apparently fixed elsewhere in the meanwhile because it doesn't happen any more even with this change. See #2268.

2012-10-12 20:45 VZ, revision 72656

Tamil translations update from DINAKAR T.D.

2012-10-12 00:29 VZ, revision 72655

Document default argument value of wxListCtrl::EnableBellOnNoMatch(). In addition to forgetting to specify the default value in wxGenericListCtrl, it was also not documented, do it now to complete the fix of r72654.

2012-10-11 14:41 VZ, revision 72654

Use "true" by default in wxGenericListCtrl::EnableBellOnNoMatch(). The changes of r72639 mistakenly omitted the default value for EnableBellOnNoMatch() argument in this class (although it was present in the base class and in wxGenericTreeCtrl), fix this.

2012-10-11 13:15 JJ, revision 72653

Update setup.h for OpenVMS

2012-10-10 20:47 VZ, revision 72652

Mention InvalidateBestSize() in DoGetBestClientSize() documentation. It is not obvious that it needs to be called when the best size changes, so give at least a hint.

2012-10-10 17:45 JS, revision 72651

Don't write text if it's empty

2012-10-10 17:43 JS, revision 72650

Don't write text if it's empty

2012-10-09 23:28 VZ, revision 72649

Do return the protocol part from GetLocaltion() for local wxFSFiles. wxLocalFSHandler created wxFSFile without the protocol information which means that calling GetLocaltion() on this file later doesn't return it, contrary to the documentation. Do include the protocol to fix this. Closes #14638.

2012-10-09 23:02 VZ, revision 72648

Generate text events in generic wxSpinCtrl itself. The text events in a wxSpinCtrl should originate from the control itself but they were just propagated upwards from wxTextCtrl embedded into it and hence had wrong event object and event ID fields. Fix this by making EVT_TEXT come from wxSpinCtrl itself, in addition to EVT_TEXT_ENTER ones which we already forwarded like this.

2012-10-09 23:01 VZ, revision 72647

Copy wxCommandEvent string explicitly in its copy ctor. Due to the optimization used in wxCommandEvent::GetString(), which returns the string from the text control that generated the event only if it's really needed, wxCommandEvent::m_cmdString field may be empty even when it does have an associated string. As we lose the possibility to retrieve the value on demand from wxTextCtrl when we make a copy (because it can be associated with a different object), we need to explicitly copy the string to avoid losing this data entirely. This fixes GetString() value for the text events generated by generic wxSearchCtrl.

2012-10-09 23:01 VZ, revision 72646

Fix printing in landscape mode in wxGTK. Only apply Cairo transforms in StartPage(), doing it earlier interferes with the code doing the coordinate system rotation inside GTK+ itself when a non-portrait printing mode is used. Closes #14732.

2012-10-09 06:01 PC, revision 72645

backport r69863 "Don't include pbt.h from wxMSW code unnecessarily"

2012-10-08 14:09 VZ, revision 72643

Document wxGrid methods dealing with cell overflow. Closes #14733.

2012-10-08 14:09 VZ, revision 72642

Recreate GtkPrintOperation every time when printing in wxGTK. Apparently reusing GtkPrintOperation is not allowed, so create a new one every time we need it. Closes #14731.

2012-10-08 14:09 VZ, revision 72641

Improve wxAuiNotebook appearance when using some GTK themes. Let wxAuiNotebook render the border itself, instead of doing it in dock art class. This allows the notebook to do it correctly for the current theme. Closes #14710.

2012-10-08 00:42 VZ, revision 72640

Ensure that key events are sent to focused window first in wxGTK. Start processing key events from the currently focused window, this ensures that its key event handlers are tried before the top level window accelerators. This is consistent with wxMSW and allows a window to locally override the global accelerators which really makes sense. Closes #14553.

2012-10-08 00:42 VZ, revision 72639

Implement incremental search in wxGenericListCtrl. Mostly copy wxGenericTreeCtrl incremental search implementation to wxGenericListCtrl (unfortunately there is no simple way to reuse this code currently), including the recently added EnableBellOnNoMatch() method. Update the sample to test it, the key event handling in it had to be modified to allow it.

2012-10-08 00:42 VZ, revision 72638

Add a possibility to beep on no match to wxGenericTreeCtrl. For consistency with Windows, allow to optionally generate a beep when incremental search in the tree control doesn't find anything.

2012-10-08 00:41 VZ, revision 72637

Fix return value of wxGenericTreeCtrl::FindItem(). We incorrectly returned the item we started from instead of invalid item if there was no match, fix this.

2012-10-08 00:41 VZ, revision 72636

Handle successive key presses better in wxGenericTreeCtrl search code. Go to the next item starting with the given character if the same one is pressed multiple times. This is more useful than searching for an item starting with multiple occurrences of this character (which usually won't exist) and is more consistent with how Windows handles this.

2012-10-08 00:40 VZ, revision 72635

Recognize "_" as alphanumeric key in wxGenericTreeCtrl find item code. Items can have underscores in their names too, not just letters and digits.

2012-10-08 00:40 VZ, revision 72634

Fix spurious label editing in generic wx{List,Tree,DataView}Ctrl. Clicking on the control to give it focus must not start editing the label of an item in it, this is bad UI as you need to carefully select where do you click to avoid starting to edit the label and nobody else does it like this (probably because of the former reason). As a side note, it would be really great to abstract the item handling in a class that could be reused by all these controls instead of having to update 3 slightly different versions of the same code every time.

2012-10-08 00:40 VZ, revision 72633

Don't set focus explicitly in wxGenericListCtrl mouse handling code. Just skip the event to allow the system to set the focus to the control itself. This is more consistent with the other controls and should result in correct behaviour everywhere automatically.

2012-10-08 00:39 VZ, revision 72632

Don't set focus to generic wxDataViewCtrl on any button press. Only set focus if the left button was pressed for consistency with just about everything else. Also, just skip the event instead of setting the focus explicitly.

2012-10-08 00:39 VZ, revision 72631

No real changes, just don't use brush styles for background mode in wxHTML. Use just wxTRANSPARENT and wxSOLID instead of wxBRUSHSTYLE_TRANSPARENT and wxBRUSHSTYLE_SOLID when changing the background mode. See #14599.

2012-10-08 00:38 VZ, revision 72630

Support some CSS styles for the links in wxHTML too. Refactor limited CSS styles support for <span> tag to reuse it for <a> tag as well. Closes #14599.

2012-10-08 00:38 VZ, revision 72629

Flush log messages from other threads on shutdown too. Add a call to wxLog::FlushActive() to the shutdown code as calling just wxLog::SetActiveTarget(NULL) is not enough, it flushes the current log target only but not the ones used by other threads. Closes #14595.

2012-10-08 00:38 VZ, revision 72628

Update the year in the copyright for wxMSW DLLs. Just s/2010/2012/

2012-10-08 00:37 VZ, revision 72627

Fix drawing of wxAuiNotebook with GTK theme when active tab is invisible. Draw a box using gtk_paint_box() for the tabs, without border for the active one to avoid an extra line across the gap, and with the border for the others. Closes #14728.

2012-10-08 00:37 VZ, revision 72626

Fix test for __WXGTK__ in wxCairoContext. It must be tested with #ifdef, not #if.

2012-10-07 18:49 VS, revision 72625

Fix wxGenericCollapsiblePane to expand frame's size. wxGenericCollapsiblePane::DoGetBestSize() is dynamic, returning different values for collapsed and open states. Therefore the control must invalidate best sizes cache every time its state changes.

2012-10-05 01:24 VZ, revision 72621

Add support for wxALWAYS_SHOW_SB style to wxScrolled<>. Simply call ShowScrollbars(wxSHOW_SB_ALWAYS) if this style is specified. Closes #13616.

2012-10-05 01:24 VZ, revision 72620

Document wxHSCROLL and wxVSCROLL styles for wxScrolled<>. Explain that by default both styles are assumed but that using just one of them disables the scrolling in the other direction.

2012-10-05 01:23 VZ, revision 72619

Add a setting for the disabled text colour to wxRibbon art. Allow specifying the text for the labels of the disabled items separately. Closes #14721.

2012-10-05 01:23 VZ, revision 72618

Add a more convenient wxColour::MakeDisabled() overload. Allow creating a disabled version of the colour without having to manually break it into RGB components and then recreating it from them.

2012-10-05 00:49 VZ, revision 72617

Remove unneeded variable initializations in wxPM code. Closes #14724.

2012-10-05 00:48 VZ, revision 72616

Fix bugs in the recently added wxDateTime::DiffAsDateSpan(). Correct the test for negative spans less than a month and use the correct month for computing the number of days in it. Also add unit tests for problematic cases. Closes #14704.

2012-10-05 00:48 VZ, revision 72615

Add wxDateSpan::GetTotalMonths() method. This is similar to the existing GetTotalDays() and counts both months and years. See #14704.

2012-10-05 00:47 VZ, revision 72614

Fix fatal bug in the recently added wxFile::ReadAll(). Make sure we exit the loop when reading the file in chunks in wxFile::ReadAll() and add a unit test for it to ensure that it's really correct. Closes #14725.

2012-10-04 18:08 PC, revision 72613

non-pch build fix

2012-10-04 17:58 PC, revision 72612

remove always-true comparison of unsigned value >= 0

2012-10-04 17:55 PC, revision 72611

silence warnings about shadowed variables with GCC -Wshadow

2012-10-03 10:32 VZ, revision 72610

Do use IsEscapeKey() in wxDialog escape key handling. This method was added back in r40686 but was never actually used anywhere. Do use it in wxDialogBase::OnCharHook() now instead of hard-coding the check for WXK_ESCAPE, this should allow using Cmd+. to work like Escape under Mac which was apparently the intention of the code in src/osx/dialog_osx.cpp. Also fix IsEscapeKey() itself to ignore any modifiers as at least under MSW Esc always closes the dialog, even if Shift or Alt is pressed.

2012-10-03 09:58 VZ, revision 72609

Add missing header to fix MiscGUIFuncsTestCase compilation. Need full wxPanel declaration here now.

2012-10-03 02:16 VZ, revision 72608

Fix wxFindWindowAtPoint() unit test to pass under GTK. We need to ensure that all windows are realized before querying their positions on screen, so add an extra wxYield(). Also adjust the tests slightly as the windows are now all created in the beginning of the function. Finally, use Destroy() instead of wxDELETE() for windows.

2012-10-03 02:16 VZ, revision 72607

Added a simple unit test for wxWindow::ClientToScreen(). Check that this function works consistently for the TLW and its children and grand-children.

2012-10-03 02:16 VZ, revision 72606

Avoid creating children of wxButton in MiscGUIFuncsTestCase. This doesn't work in wxGTK, use a normal wxWindow instead of wxButton in this case.

2012-10-02 18:19 PC, revision 72605

remove some unnecessary casts

2012-10-02 17:57 PC, revision 72604

make more Init() functions private

2012-10-01 12:47 VZ, revision 72603

Fix assert about passing long as "%d" in wxXRC code. Closes #14718.

2012-10-01 11:55 VZ, revision 72602

No changes, just remove some unneeded variables initializations. Closes #14716, #14717.

2012-10-01 11:55 VZ, revision 72601

Test for wxAuiMDIClientWindow being non-NULL before using it. wxAuiMDIParentFrame::GetActiveChild() may be called before the client window is created, don't crash in this case but just return NULL. Closes #14684.

2012-10-01 11:55 VZ, revision 72600

Add wxDateTime::DiffAsDateSpan(). This method returns the difference between the dates as wxDateSpan, unlike the existing Subtract() and overloaded operator-() that return wxTimeSpan. Closes #14704.

2012-10-01 11:40 VZ, revision 72599

Fix PCH-less build after the changes of r72589. Use wx{SOLID,TRANSPARENT} instead of wxBRUSHSTYLE_{SOLID,TRANSPARENT}. This makes more sense as we're setting background mode, not brush style, here and also fixed compilation when not using PCH.

2012-10-01 00:28 VZ, revision 72598

Read and write files using binary mode in wxStyledTextCtrl. Use binary mode to preserve the original file EOLs when loading it and also to save it with the same EOLs later. Add very primitive EOL auto-detection to LoadFile(). Also add SaveFile()/LoadFile() which were missing in !wxUSE_TEXTCTRL case.

2012-10-01 00:28 VZ, revision 72597

Small optimization of wxFFile::ReadAll(): avoid extra string copy. Use swap() to move the newly created string into its destination instead of copying it there. This can be relatively important as the string represents an entire file contents here and so could be quite long.

2012-10-01 00:28 VZ, revision 72596

Added wxFile::ReadAll() for consistency with wxFFile::ReadAll(). Make it possible to use wxFFile and wxFile interchangeably for simply reading the entire contents of the file as a string.

2012-10-01 00:27 VZ, revision 72595

Reimplement wxTextEntry::DoSetValue() in wxStyledTextCtrl. The version inherited from the base class does work already but calling Scintilla SetText() directly should be more efficient than selecting everything and then calling ReplaceSelection() as the base class version does, less code is executed.

2012-10-01 00:27 VZ, revision 72594

Fix wxStyledTextCtrl::WriteText() to replace the selection. WriteText() must replace the selection, not just insert the new text, otherwise SetValue() implementation inherited from the base class doesn't work as it doesn't clear the old contents of the control before adding new text to it.

2012-10-01 00:26 VZ, revision 72593

Don't call ClearAll() before LoadFile() in the stc sample. There is no need to clear the control contents before loading a file into it because LoadFile() is supposed to do this on its own (although currently it doesn't, which will be fixed soon).

2012-10-01 00:26 VZ, revision 72592

Make stc sample startup faster. Don't show "About" dialog on startup, this has nothing to do with the purpose of this sample and is just annoying. Also, don't select the entire file after opening it.

2012-10-01 00:21 VZ, revision 72591

Add per-direction wxSocket wait flags and byte counters. Allow to specify whether the socket should block until all the data is read or written or, on the contrary, avoid blocking only when reading or writing instead of always using the same behaviour in both directions. Also add separate counters for the bytes read/written instead of using the same one for both. These changes make it possible to use the same socket for reading/writing in different threads. Closes #14506.

2012-10-01 00:21 VZ, revision 72590

Don't crash in generic wxDataViewCtrl if it doesn't have any model. A model may be dissociated from a still existing control, don't crash if it happens (notice that we still would crash in the native GTK version right now, so this still remains to be fixed there). See #14616.

2012-10-01 00:20 VZ, revision 72589

Add support for background-color style to span element in wxHTML. Add code for setting/restoring background mode and use it to implement support for changing the text background colour. Closes #14443.

2012-10-01 00:20 VZ, revision 72588

Fix handling of spaces after <img> tag in wxHTML. Don't collapse the spaces following this tag with the ones preceding it. See #14557. Closes #2980.

2012-10-01 00:20 VZ, revision 72587

Convert image tags to text using their alt attribute in wxHTML. This is useful when copying wxHtmlWindow contents to clipboard, for example. Closes #14557.

2012-10-01 00:19 VZ, revision 72586

Fix handling of not fully specified min/max size in wxBoxSizer. wxSizerItem::AddBorderToSize() added in r72344 (see #11497) didn't work correctly as it replaced unspecified (i.e. set to -1) components of wxSize with the small positive values that did take effect, contrary to the intention. Fix it to only adjust the actually set component(s) of wxSize. Closes #14696.

2012-10-01 00:19 VZ, revision 72585

No changes, just fix some typos in comments in wxXRC code. Closes #14714.

2012-10-01 00:19 VZ, revision 72584

No changes, just remove unneeded variable initialization. Closes #14712, #14713.

2012-09-30 22:35 VZ, revision 72583

Revert "Don't use StringFormat::GenericTypographic() in MSW wxGraphicsContext." This reverts r72442 and restores the use of GenericTypographic string format for GDI+ text rendering. While it's true that using this flag with small font sizes results in pretty bad output, especially under Windows XP, not using it results in wrong text extent calculations for all sizes which is even worse. See #14537.

2012-09-30 22:35 VZ, revision 72582

Fix computation of menu button best size in generic wxSearchCtrl. Invalidate the cached best size when the bitmap changes. Closes #14708.

2012-09-30 22:35 VZ, revision 72581

Clear the search control automatically when it's "Cancel" button is pressed. This should be the desired behaviour in the vast majority of cases, so do it by default. Replace the useless OnSearchButton() doing nothing with search button events with OnCancelButton() handling cancel button events and clearing the control.

2012-09-30 22:34 VZ, revision 72580

Don't use text control foreground colour for generic wxSearchCtrl itself. Logically, it should be done in the other direction and also doing it like this means that the search and cancel icons, rendered using the current foreground colour, are barely visible when using generic wxTextCtrl::SetHint() implementation, as in wxGTK, because the text control foreground is set to light grey in this case.

2012-09-30 18:55 PC, revision 72579

make wxWindowGTK::Init() private, it is not meant to be called from derived classes

2012-09-30 04:33 RD, revision 72578

Use Refresh when the initial paint was abandoned by Scintilla so it will trigger a repaint of the whole window. This is done for things like style changes, word wrapping or brace highlights where more than the current line is affected. Fixes #14653.

2012-09-29 01:50 VZ, revision 72577

Fix generic wxSearchCtrl best size calculation. The best size of its text control part was not calculated correctly any more because a wrong best size was cached during wxSearchTextCtrl construction, when the final class overridden DoGetBestSize() was not called. Fix this by explicitly invalidating the best size at the end of constructor for now even though it would be arguably better to fix this in some way not requiring anything extra to be done to always take the overridden method into account, especially as it used to work before. But it's not clear how exactly to restore this so for now do at least fix wxSearchCtrl appearance. Closes #14708.

2012-09-29 01:50 VZ, revision 72576

Fix wxSearchCtrl recreation in the widgets sample. The control wasn't readded to the sizer correctly after being recreated.

2012-09-29 01:49 VZ, revision 72575

Remove unused SearchCtrlWidgetsPage::Reset() from widgets sample. This method was simply unused and unneeded.

2012-09-29 01:49 VZ, revision 72574

Don't send events for disabled ribbon bar buttons. Hover and activation events were sent even for the disabled buttons which was unexpected and inconsistent with wxRibbonToolBar, so don't do it. Closes #14709.

2012-09-29 01:48 VZ, revision 72573

Make wxHelpControllerBase::SetFrameParameters() title more clear. Describe it as "title format string" and call it "titleFormat" and not just "title" because this is what it is. Closes #14707.

2012-09-29 01:48 VZ, revision 72572

Add "inherit" to <font> XRC tag. This allows to construct a font based on the parent window font instead of either fully specifying all font parameters or basing it on a standard font. Closes #14632.

2012-09-29 01:48 VZ, revision 72571

Fix testing for existence of paths with trailing separators in wxMSW. We removed the trailing separators, that prevented GetFileAttributes() from working correctly, from the path but then didn't pass the modified path to it but the original one. Fix this and do use the updated path.

2012-09-28 18:09 PC, revision 72569

Avoid unrealizing a frozen window It seems to continue to prevent updates to the affected area Fixes #13543

2012-09-28 00:41 VZ, revision 72568

Make wxTextEntryDialog resizable. It can be used for entry of relatively long text now, especially when wxTE_MULTILINE flag is used, so allow the user to resize it to facilitate the entry. Closes #14702.

2012-09-28 00:41 VZ, revision 72567

Add two step creation to wxTextEntryDialog. Add Create() method and default ctor for consistency with the other classes. See #14702.

2012-09-28 00:41 VZ, revision 72566

Use SelectAll() instead of SetSelection(-1, -1). The former is more clear and also shorter. Closes #14701.

2012-09-28 00:40 VZ, revision 72565

Remove the now unnecessary wxRichTextCtrl::SelectAll(). It is already inherited from the base wxTextEntry class. See #14701.

2012-09-27 15:58 VZ, revision 72564

Fix _tputenv() return value test in wxSetEnv(). _tputenv() returns -1, not 0, on error, as all the other CRT functions, so the test added by r72496 resulted in wxSetEnv() and wxUnsetEnv() always failing when using MSVC.

2012-09-27 14:47 VZ, revision 72563

Account correctly for the controller when computing wxBookCtrl best size. We must not increase the total control size in the direction along the controller window as the size of the controller in this direction is determined by the size of the control itself. So doing this resulted in always increasing best size in this direction to be at least equal to the current size which was wrong. Closes #14496.

2012-09-27 14:47 VZ, revision 72562

Use wxSize::IncTo() in wxBookCtrlBase::DoGetBestSize(). No changes, just use an existing wxSize method instead of reimplementing it in the loop over the pages in wxBookCtrlBase.

2012-09-27 14:46 VZ, revision 72561

Avoid useless iteration on all pages in wxBookCtrlBase::DoGetBestSize(). If m_fitToCurrentPage is true, there is no need to iterate over all the pages computing their max best size only in order to overwrite it with the best size of the current page later. This doesn't result in any changes in the behaviour, just avoids useless best size computations.

2012-09-27 00:30 VZ, revision 72560

Do not unref GtkWidget of unattached wxMenuBar. This results in the destruction of the widgets of all of its menu and when wxMenu objects are themselves destroyed in the base class dtor, we try to destroy their already destroyed widgets, resulting in critical GTK warnings. Simply don't do anything in wxMenuBar dtor itself if the menu bar is not attached to a frame as the workaround was only needed in case of destroying attached menu bars.

2012-09-27 00:29 VZ, revision 72559

Fix GTK warnings when destroying unattached wxMenuBar. Reset m_focusWidget to NULL when destroying m_widget in wxMenuBar dtor, otherwise we try to use this already destroyed (because it's the same as m_widget) widget in wxWindow dtor later resulting in critical GTK warnings.

2012-09-27 00:29 VZ, revision 72558

Don't crash in wxMenuBar::Remove() if unattached in wxGTK. It should be possible to remove a menu from a menu bar even before it is attached to a frame without crashing.

2012-09-26 14:20 VZ, revision 72557

Update MSW installation instructions for 2.9. Remove all mentions of 16 bit build. Update the list of supported compilers and their versions. Update Unicode build description. Closes #11908.

2012-09-26 14:20 VZ, revision 72556

Merge "selected" and "active" child in wxAuiMDIParentFrame. They are one and the same thing and so just make them really synonymous instead of (unsuccessfully) trying to keep them synchronized. Closes #14684.

2012-09-26 01:53 RD, revision 72555

Reserve the whole style byte for styles. See #14688

2012-09-26 01:53 RD, revision 72554

Scintilla's Point class no longer matches the structure of wxPoint, so we need to copy points to a wxPoint array instead of just typcasting Scintilla's array. Fixes #14687

2012-09-25 22:40 BP, revision 72553

Fixed interface typo breaking wxRibbonBar docs (from r72495).

2012-09-25 20:01 PC, revision 72552

call Thaw() instead of DoThaw() so frozen status will be properly updated, and use a loop in case window has been frozen more than once

2012-09-25 19:55 PC, revision 72551

fix deleting a frozen multi-line wxTextCtrl, see #13543

2012-09-25 15:50 VZ, revision 72550

Attempt to fix wxHelpControllerBase::SetFrameParameters() documentation. Don't use "%s" in the brief comment, "%" is apparently not allowed there.

2012-09-25 15:08 SC, revision 72549

adding constants for newer OSX versions to make sure our conditional expressions are working with earlier SDKs

2012-09-25 12:50 VZ, revision 72548

Add wxGenericAboutDialog documentation. Closes #14660.

2012-09-25 12:50 VZ, revision 72547

Fix too hastily copy-pasted wxVariantDataSafeArray documentation. Some parts were not updated after copying them from wxVariantDataErrorCode. Closes #14689.

2012-09-25 12:49 VZ, revision 72546

Really fix stack dumps for asserts and wxStackWalker::Walk() calls. The code apparently tried to compensate for the wrong "skip" values used in the calls to wxStackWalker::Walk() by skipping too much in Walk() itself which was wrong as it dropped the frames that should have been shown. Fix this by skipping only the one extra (compared to Walk() itself) frame we add in wxStackWalker Unix implementation and not 3 of them and do skip more frames when calling Walk() from assert failure handlers. Also fix the wrong number of frames used in ProcessFrames(): we must not subtract the number of skipped frames, they were already skipped. Closes #14690.

2012-09-25 12:49 VZ, revision 72545

Use utf8_str(), not mb_str(), for strings passed to GTK+. All GTK+ strings must be encoded in UTF-8, not whichever encoding the current locale happens to use.

2012-09-25 12:48 VZ, revision 72544

Vietnamese translations update from Trần Ngọc Quân.

2012-09-24 00:49 VZ, revision 72543

Improve SAFEARRAY support in wxMSW OLE Automation code. Add a new wxSafeArray<> class wrapping SAFEARRAY. Also add support for converting VARIANTs containing other, previously unsupported, standard types. Closes #14637.

2012-09-24 00:49 VZ, revision 72542

Explain EVT_CONTEXT_MENU generation in more details. Document that you should not count on specific order of mouse right button and context menu events. Closes #12535.

2012-09-24 00:49 VZ, revision 72541

No changes, just reuse a bit of code in wxMSW wxMDIParentFrame. Call wxMDIChildFrame::Activate() instead of redoing the same thing. This also ensures that iconized MDI children are restored before being activated (see previous commit). See #13946.

2012-09-24 00:48 VZ, revision 72540

Restore an iconized MDI child frame when activating it. Without doing this activating an iconized frame doesn't do anything at all, i.e. doesn't present it to the user as presumably intended. Closes #13946.

2012-09-24 00:48 VZ, revision 72539

Correct best size computation for wxCheckBox with borders under MSW. As wxCheckBox can now have borders (see previous commit), we must override DoGetBestClientSize() and not DoGetBestSize() in it to take account of them.

2012-09-24 00:47 VZ, revision 72538

Respect styles translated to WS_EX_XXX in wxMSW wxCheckBox and wxRadioButton. Take into account the window styles that translate to extended Windows styles at MSW level. Also override MSWGetStyle() in these classes, just as in most (all?) other ones, for consistency instead of doing wx-to-MSW styles translation directly in Create(). Notice that as a side effect of this change, border styles now work for wxCheckBox which wasn't the case before. It's not clear if this is really wanted but OTOH there doesn't seem to be any real reason to forbid them neither. Closes #14674.

2012-09-22 18:16 VZ, revision 72537

Allow wxWrapSizer to request more size than it used previously. The code in wxWrapSizer::CalcMin() ensured that the sizer never requested more space than what it had been already given which, while clearly done intentionally, seems to be wrong because it can never end up with enough space for all its rows/columns unless it is set to up to expand in the containing sizer. In other words, the old code could return the size which was not enough to show the sizer contents fully which is against CalcMin() contract. Change this by simply removing the check for the new minimal size being less than the old one. This allows the wrap sizer demo in the layout sample to work correctly whereas before the sizer contents was completely invisible initially.

2012-09-22 18:16 VZ, revision 72536

Make wxWrapSizer demo in the layout sample more dynamic. Allow adding checkboxes to and removing them from the wrap sizer to demonstrate how it adjusts to its contents dynamically.

2012-09-22 18:16 VZ, revision 72535

Credit "sodev" with correct full name. Amend the change log entry of r71701. See #14380.

2012-09-21 12:26 VZ, revision 72534

Fix crash on wxMediaCtrl creation in wxMSW. A valid RECT pointer must be passed to DoVerb(OLEIVERB_INPLACEACTIVATE) but r72027 (see #14209) broke this and passed it NULL resulting in an instant crash. Revert this part of the change and do pass out window client area. Closes #14682.

2012-09-21 01:12 VZ, revision 72533

Fix wxPluginLibrary wxClassInfo pointers initialization. The values of m_ourFirst and m_ourLast were inversed in wxPluginLibrary ctor. Fix this and explain in a comment that "first" and "last" here refer to the order in the linked list and not the chronological order. Closes #14483.

2012-09-21 01:12 VZ, revision 72532

Fix wrong configure test for abi::__forced_unwind in previous commit. The previous commit was accidental and contained an initial version of the patch which didn't test for NPTL abi::__forced_unwind correctly and just tested whether cxxabi.h header was available. Tighten the check to work on the other systems and check for __forced_unwind existence itself. Also check for cxxabi.h before testing for __cxa_demangle as there is no need to try to compile another test program if we already know that this entire header is unavailable anyhow. See #14626.

2012-09-21 01:00 VZ, revision 72531

Rethrow abi::__forced_unwind in wxThread code under Unix. We must always rethrow the special abi::__forced_unwind exception when handling exception in threads under Linux as the NPTL simply terminates the process at first opportunity if this exception is not rethrown. See http://udrepper.livejournal.com/21541.html for more details. Closes #14626.

2012-09-21 00:15 VZ, revision 72530

Add public (but not documented) wxCheckBox::MSWMakeOwnerDrawn(). It can be useful to explicitly make a check box owner drawn, so make the private MakeOwnerDrawn() public and add "MSW" prefix to it to allow doing this from the user code. Closes #14679.

2012-09-20 22:02 VZ, revision 72529

Fix and enhance support for client data in wxRibbonButtonBar. Add the possibility to retrieve the client data associated with a button and not only set it (which wasn't very useful on its own). Also allow having both typed (owned) and untyped (not owned) client data, as in the other wxWidgets controls. To avoid confusion between two different kinds of data, remove "client_data" argument from the functions adding buttons and provide separate methods with distinct names for setting and getting client data. Closes #14630.

2012-09-20 22:02 VZ, revision 72528

Add wxRibbonButtonBarEvent::GetButton(). Allow to retrieve the button associated with the given button bar event. See #14630.